Apache DataFusion SQL Query Engine
feat: support f16 in coercion logic (#18944)
Jeffrey Vo796c7d1daea5
diff --git a/datafusion/expr-common/src/signature.rs b/datafusion/expr-common/src/signature.rsindex 54bb84f03d..4c766b2cc5 100644--- a/datafusion/expr-common/src/signature.rs+++ b/datafusion/expr-common/src/signature.rs@@ -1585,6 +1585,7 @@ mod tests {vec![DataType::UInt16, DataType::UInt16],vec![DataType::UInt32, DataType::UInt32],vec![DataType::UInt64, DataType::UInt64],+ vec![DataType::Float16, DataType::Float16],vec![DataType::Float32, DataType::Float32],vec![DataType::Float64, DataType::Float64]]diff --git a/datafusion/expr-common/src/type_coercion/aggregates.rs b/datafusion/expr-common/src/type_coercion/aggregates.rsindex 01d093950d..ab4d086e4c 100644--- a/datafusion/expr-common/src/type_coercion/aggregates.rs+++ b/datafusion/expr-common/src/type_coercion/aggregates.rs@@ -42,6 +42,7 @@ pub static NUMERICS: &[DataType] = &[DataType::UInt16,DataType::UInt32,DataType::UInt64,+ DataType::Float16,DataType::Float32,DataType::Float64,];diff --git a/datafusion/expr/src/type_coercion/functions.rs b/datafusion/expr/src/type_coercion/functions.rsindex d839d84c66..90c137de24 100644--- a/datafusion/expr/src/type_coercion/functions.rs+++ b/datafusion/expr/src/type_coercion/functions.rs@@ -852,10 +852,13 @@ fn coerced_from<'a>((UInt16, Null | UInt8 | UInt16) => Some(type_into.clone()),(UInt32, Null | UInt8 | UInt16 | UInt32) => Some(type_into.clone()),(UInt64, Null | UInt8 | UInt16 | UInt32 | UInt64) => Some(type_into.clone()),+ (Float16, Null | Int8 | Int16 | UInt8 | UInt16 | Float16) => {+ Some(type_into.clone())+ }(Float32,Null | Int8 | Int16 | Int32 | Int64 | UInt8 | UInt16 | UInt32 | UInt64- | Float32,+ | Float16 | Float32,) => Some(type_into.clone()),(Float64,@@ -868,6 +871,7 @@ fn coerced_from<'a>(| UInt16| UInt32| UInt64+ | Float16| Float32| Float64| Decimal32(_, _)diff --git a/datafusion/optimizer/src/analyzer/type_coercion.rs b/datafusion/optimizer/src/analyzer/type_coercion.rsindex 1e59ceb972..a98678f7cf 100644--- a/datafusion/optimizer/src/analyzer/type_coercion.rs+++ b/datafusion/optimizer/src/analyzer/type_coercion.rs@@ -1892,7 +1892,7 @@ mod test {.err().unwrap().strip_backtrace();- assert!(err.starts_with("Error during planning: Failed to coerce arguments to satisfy a call to 'avg' function: coercion from Utf8 to the signature Uniform(1, [Int8, Int16, Int32, Int64, UInt8, UInt16, UInt32, UInt64, Float32, Float64]) failed"));+ assert!(err.starts_with("Error during planning: Failed to coerce arguments to satisfy a call to 'avg' function: coercion from Utf8 to the signature Uniform(1, [Int8, Int16, Int32, Int64, UInt8, UInt16, UInt32, UInt64, Float16, Float32, Float64]) failed"));Ok(())}diff --git a/datafusion/sqllogictest/test_files/aggregate.slt b/datafusion/sqllogictest/test_files/aggregate.sltindex ab217b192b..b819fd3477 100644--- a/datafusion/sqllogictest/test_files/aggregate.slt+++ b/datafusion/sqllogictest/test_files/aggregate.slt@@ -571,6 +571,16 @@ SELECT covar(c2, c12) FROM aggregate_test_100-----0.079969012479+query R+SELECT covar_pop(arrow_cast(c2, 'Float16'), arrow_cast(c12, 'Float16')) FROM aggregate_test_100+----+-0.079163311005++query R+SELECT covar(arrow_cast(c2, 'Float16'), arrow_cast(c12, 'Float16')) FROM aggregate_test_100+----+-0.079962940409+# single_row_query_covar_1query Rselect covar_samp(sq.column1, sq.column2) from (values (1.1, 2.2)) as sq@@ -1313,6 +1323,24 @@ select approx_median(arrow_cast(col_f32, 'Float16')), arrow_typeof(approx_median----2.75 Float16+# This shouldn't be NaN, see:+# https://github.com/apache/datafusion/issues/18945+query RT+select+ percentile_cont(0.5) within group (order by arrow_cast(col_f32, 'Float16')),+ arrow_typeof(percentile_cont(0.5) within group (order by arrow_cast(col_f32, 'Float16')))+from median_table;+----+NaN Float16++query RT+select+ approx_percentile_cont(0.5) within group (order by arrow_cast(col_f32, 'Float16')),+ arrow_typeof(approx_percentile_cont(0.5) within group (order by arrow_cast(col_f32, 'Float16')))+from median_table;+----+2.75 Float16+query ?Tselect approx_median(NULL), arrow_typeof(approx_median(NULL)) from median_table;----@@ -6719,7 +6747,12 @@ from aggregate_test_100;----0.051534002628 0.48427355347 100 0.001929150558 0.479274948239 0.508972509913 6.707779292571 9.234223721582 0.345678715695-+query R+select+ regr_slope(arrow_cast(c12, 'Float16'), arrow_cast(c11, 'Float16'))+from aggregate_test_100;+----+0.051477733249# regr_*() functions ignore NULLsquery RRIRRRRRR