Skip to content

Apache DataFusion SQL Query Engine

fix: report OneOf signature mismatches as planning errors (#26329)

Singleton81824e8230c1
diff --git a/datafusion/expr/src/type_coercion/functions.rs b/datafusion/expr/src/type_coercion/functions.rs
index ad7b086f39..1e4e7c0a3e 100644
--- a/datafusion/expr/src/type_coercion/functions.rs
+++ b/datafusion/expr/src/type_coercion/functions.rs
@@ -559,9 +559,13 @@ fn get_valid_types_with_udf<F: UDFCoercionExt>(
}
}
- // Every signature failed, return the joined error
+ // Every signature failed. That means the caller passed the wrong
+ // number or types of arguments, which is a user mistake rather than
+ // a bug in DataFusion, so report it as a planning error. Reporting it
+ // as an internal error told users to file a bug report for their own
+ // typo, and the caller appends the candidate signatures anyway.
if res.is_empty() {
- return internal_err!(
+ return plan_err!(
"Function '{}' failed to match any signature, errors: {}",
func.name(),
errors.join(",")
diff --git a/datafusion/sqllogictest/test_files/array/array_range.slt b/datafusion/sqllogictest/test_files/array/array_range.slt
index 022740239a..14d47021ce 100644
--- a/datafusion/sqllogictest/test_files/array/array_range.slt
+++ b/datafusion/sqllogictest/test_files/array/array_range.slt
@@ -244,17 +244,17 @@ select generate_series(arrow_cast('2021-01-01T00:00:00', 'Timestamp(Nanosecond,
[2021-01-01T00:00:00-05:00, 2021-01-01T01:29:54.500-05:00, 2021-01-01T02:59:49-05:00, 2021-01-01T04:29:43.500-05:00, 2021-01-01T05:59:38-05:00]
## mixing types for timestamps is not supported
-query error DataFusion error: Error during planning: Internal error: Function 'generate_series' failed to match any signature
+query error DataFusion error: Error during planning: Function 'generate_series' failed to match any signature
select generate_series(arrow_cast('2021-01-01T00:00:00', 'Timestamp(Nanosecond, Some("-05:00"))'), DATE '2021-01-02', INTERVAL '1' HOUR);
## mixing types not allowed even if an argument is null
-query error DataFusion error: Error during planning: Internal error: Function 'generate_series' failed to match any signature
+query error DataFusion error: Error during planning: Function 'generate_series' failed to match any signature
select generate_series(TIMESTAMP '1992-09-01', DATE '1993-03-01', NULL);
-query error DataFusion error: Error during planning: Internal error: Function 'generate_series' failed to match any signature
+query error DataFusion error: Error during planning: Function 'generate_series' failed to match any signature
select generate_series(1, '2024-01-01', '2025-01-02');
-query error DataFusion error: Error during planning: Internal error: Function 'generate_series' failed to match any signature
+query error DataFusion error: Error during planning: Function 'generate_series' failed to match any signature
select generate_series('2024-01-01'::timestamp, '2025-01-02', interval '1 day');
## should return NULL
diff --git a/datafusion/sqllogictest/test_files/errors.slt b/datafusion/sqllogictest/test_files/errors.slt
index d9722dbd73..674e8f969b 100644
--- a/datafusion/sqllogictest/test_files/errors.slt
+++ b/datafusion/sqllogictest/test_files/errors.slt
@@ -124,7 +124,7 @@ from aggregate_test_100
order by c9
# WindowFunction wrong signature
-statement error DataFusion error: Error during planning: Internal error: Function 'nth_value' failed to match any signature
+statement error DataFusion error: Error during planning: Function 'nth_value' failed to match any signature
select
c9,
nth_value(c5, 2, 3) over (order by c9) as nv1
diff --git a/datafusion/sqllogictest/test_files/math.slt b/datafusion/sqllogictest/test_files/math.slt
index 1b9fa63bf8..9ef5043264 100644
--- a/datafusion/sqllogictest/test_files/math.slt
+++ b/datafusion/sqllogictest/test_files/math.slt
@@ -175,10 +175,10 @@ NULL
query error DataFusion error: Error during planning: 'round' does not support zero arguments
SELECT round();
-query error Error during planning: Internal error: Function 'round' failed to match any signature
+query error Error during planning: Function 'round' failed to match any signature
SELECT round(1, 2, 3);
-query error Error during planning: Internal error: Function 'round' failed to match any signature
+query error Error during planning: Function 'round' failed to match any signature
SELECT round('x');
query error round decimal_places 2147483648 is out of supported i32 range
diff --git a/datafusion/sqllogictest/test_files/spark/math/round.slt b/datafusion/sqllogictest/test_files/spark/math/round.slt
index 9ea027dada..dc7bc139df 100644
--- a/datafusion/sqllogictest/test_files/spark/math/round.slt
+++ b/datafusion/sqllogictest/test_files/spark/math/round.slt
@@ -593,13 +593,13 @@ set datafusion.execution.enable_ansi_mode = false;
# -------------------------------------------------------------------
# round(string) should fail
-query error Error during planning: Internal error: Function 'round' failed to match any signature
+query error Error during planning: Function 'round' failed to match any signature
SELECT round('hello'::varchar);
# round(boolean) should fail
-query error Error during planning: Internal error: Function 'round' failed to match any signature
+query error Error during planning: Function 'round' failed to match any signature
SELECT round(true);
# round(timestamp) should fail
-query error Error during planning: Internal error: Function 'round' failed to match any signature
+query error Error during planning: Function 'round' failed to match any signature
SELECT round('2023-01-01T00:00:00'::timestamp);