Skip to content

Apache DataFusion SQL Query Engine

Fix `concat_elements_utf8view` capacity initialization. (#18003)

Samuele Resca9079bbd4f337
diff --git a/datafusion/physical-expr/src/expressions/binary/kernels.rs b/datafusion/physical-expr/src/expressions/binary/kernels.rs
index 71d1242eea..36ecd1c816 100644
--- a/datafusion/physical-expr/src/expressions/binary/kernels.rs
+++ b/datafusion/physical-expr/src/expressions/binary/kernels.rs
@@ -145,12 +145,14 @@ pub fn concat_elements_utf8view(
left: &StringViewArray,
right: &StringViewArray,
) -> std::result::Result<StringViewArray, ArrowError> {
- let capacity = left
- .data_buffers()
- .iter()
- .zip(right.data_buffers().iter())
- .map(|(b1, b2)| b1.len() + b2.len())
- .sum();
+ if left.len() != right.len() {
+ return Err(ArrowError::ComputeError(format!(
+ "Arrays must have the same length: {} != {}",
+ left.len(),
+ right.len()
+ )));
+ }
+ let capacity = left.len();
let mut result = StringViewBuilder::with_capacity(capacity);
// Avoid reallocations by writing to a reused buffer (note we