Skip to content

Apache DataFusion SQL Query Engine

chore: run the circular dependency check on the fork for fork PRs (#26574)

Neil Conway95ef315f37ff
diff --git a/.github/workflows/dependencies.yml b/.github/workflows/dependencies.yml
index bc65759270..7cba37e638 100644
--- a/.github/workflows/dependencies.yml
+++ b/.github/workflows/dependencies.yml
@@ -40,23 +40,6 @@ permissions:
contents: read
jobs:
- depcheck:
- name: Circular Dependency Check
- runs-on: ubuntu-latest
- container:
- image: amd64/rust
- steps:
- - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
- with:
- submodules: true
- fetch-depth: 1
- - name: Setup Rust toolchain
- uses: ./.github/actions/setup-builder
- with:
- rust-version: stable
- - name: Check dependencies
- run: bash ci/scripts/check_circular_dependencies.sh
-
detect-unused-dependencies:
name: Detect Unused Dependencies
runs-on: ubuntu-slim
diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
index 602ec66046..7df585ddad 100644
--- a/.github/workflows/rust.yml
+++ b/.github/workflows/rust.yml
@@ -979,3 +979,22 @@ jobs:
- name: Check datafusion-proto
working-directory: datafusion/proto
run: cargo msrv --output-format json --log-target stdout verify
+
+ # Check for dependency cycles between DataFusion crates with `dev/depcheck`.
+ depcheck:
+ name: Circular Dependency Check
+ if: ${{ !(github.event_name == 'push' && github.ref == 'refs/heads/main' && github.repository == 'apache/datafusion') && !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork && github.base_ref == 'main') }}
+ runs-on: ubuntu-latest
+ container:
+ image: amd64/rust
+ steps:
+ - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
+ with:
+ submodules: true
+ fetch-depth: 1
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup-builder
+ with:
+ rust-version: stable
+ - name: Check dependencies
+ run: bash ci/scripts/check_circular_dependencies.sh
diff --git a/ci/scripts/check_rust_workflow_skips.py b/ci/scripts/check_rust_workflow_skips.py
index 4d9ea090d3..a04c302ebf 100755
--- a/ci/scripts/check_rust_workflow_skips.py
+++ b/ci/scripts/check_rust_workflow_skips.py
@@ -52,6 +52,7 @@ POST_MERGE_SKIPPED_JOBS = frozenset(
"check-fmt",
"check-workflow-tool-installs",
"config-docs-check",
+ "depcheck",
"examples-docs-check",
"linux-cargo-check-datafusion",
"linux-cargo-check-datafusion-spark",
@@ -82,6 +83,7 @@ FORK_PR_SKIPPED_JOBS = frozenset(
"cargo-toml-formatting-checks",
"clippy",
"config-docs-check",
+ "depcheck",
"examples-docs-check",
"linux-build-lib",
"linux-cargo-check-datafusion",