Skip to content

Apache DataFusion SQL Query Engine

fix(spark): accept every integer width in `factorial`, matching Spark's implicit cast (#24943)

Shayan Gha5a525e1d67a
diff --git a/datafusion/spark/src/function/math/factorial.rs b/datafusion/spark/src/function/math/factorial.rs
index 3c41479174..5a54f2be97 100644
--- a/datafusion/spark/src/function/math/factorial.rs
+++ b/datafusion/spark/src/function/math/factorial.rs
@@ -21,11 +21,15 @@ use arrow::array::{Array, Int64Array};
use arrow::datatypes::DataType;
use arrow::datatypes::DataType::{Int32, Int64};
use datafusion_common::cast::as_int32_array;
+use datafusion_common::types::logical_int32;
use datafusion_common::{
DataFusionError, Result, ScalarValue, exec_err, utils::take_function_args,
};
use datafusion_expr::Signature;
-use datafusion_expr::{ColumnarValue, ScalarFunctionArgs, ScalarUDFImpl, Volatility};
+use datafusion_expr::{
+ Coercion, ColumnarValue, ScalarFunctionArgs, ScalarUDFImpl, TypeSignatureClass,
+ Volatility,
+};
/// <https://spark.apache.org/docs/latest/api/sql/index.html#factorial>
#[derive(Debug, PartialEq, Eq, Hash)]
@@ -43,7 +47,13 @@ impl Default for SparkFactorial {
impl SparkFactorial {
pub fn new() -> Self {
Self {
- signature: Signature::exact(vec![Int32], Volatility::Immutable),
+ signature: Signature::coercible(
+ vec![Coercion::new_implicit_native(
+ logical_int32(),
+ vec![TypeSignatureClass::Integer],
+ )],
+ Volatility::Immutable,
+ ),
aliases: vec![],
}
}
diff --git a/datafusion/sqllogictest/test_files/spark/math/factorial.slt b/datafusion/sqllogictest/test_files/spark/math/factorial.slt
index f8eae5d95a..e39132c4c7 100644
--- a/datafusion/sqllogictest/test_files/spark/math/factorial.slt
+++ b/datafusion/sqllogictest/test_files/spark/math/factorial.slt
@@ -62,5 +62,20 @@ NULL
NULL
NULL
-query error Error during planning: Failed to coerce arguments to satisfy a call to 'factorial' function
-SELECT factorial(5::BIGINT);
+query IIIII
+SELECT factorial(5) AS i64_literal,
+ factorial(5::TINYINT) AS i8,
+ factorial(5::SMALLINT) AS i16,
+ factorial(5::BIGINT) AS i64,
+ factorial(NULL) AS null_input;
+----
+120 120 120 120 NULL
+
+query I
+SELECT factorial(a) FROM VALUES (-1::BIGINT), (0::BIGINT), (20::BIGINT), (21::BIGINT), (NULL) AS t(a);
+----
+NULL
+1
+2432902008176640000
+NULL
+NULL