Apache DataFusion SQL Query Engine
feat: Support FixedSizedBinary type for approx_distinct (#23417)
Michael Kleencd47b9550859
diff --git a/datafusion/functions-aggregate/src/approx_distinct.rs b/datafusion/functions-aggregate/src/approx_distinct.rsindex a8dbd8611d..0e35b47d64 100644--- a/datafusion/functions-aggregate/src/approx_distinct.rs+++ b/datafusion/functions-aggregate/src/approx_distinct.rs@@ -799,6 +799,7 @@ impl AggregateUDFImpl for ApproxDistinct {| DataType::Utf8View| DataType::Binary| DataType::BinaryView+ | DataType::FixedSizeBinary(_)| DataType::LargeBinary => Box::new(HLLAccumulator::new()),DataType::Null => {Box::new(NoopAccumulator::new(ScalarValue::UInt64(Some(0))))@@ -868,6 +869,7 @@ fn is_hll_groups_type(data_type: &DataType) -> bool {| DataType::Utf8View| DataType::Binary| DataType::BinaryView+ | DataType::FixedSizeBinary(_)| DataType::LargeBinary)}diff --git a/datafusion/sqllogictest/test_files/aggregate.slt b/datafusion/sqllogictest/test_files/aggregate.sltindex 37ee3d8a95..c5970bde9c 100644--- a/datafusion/sqllogictest/test_files/aggregate.slt+++ b/datafusion/sqllogictest/test_files/aggregate.slt@@ -1953,6 +1953,22 @@ SELECT g, approx_distinct(arrow_cast(arrow_cast(s, 'Binary'), 'BinaryView')) FRO4 1+# FixedSizeBinary non-grouped+query I+SELECT approx_distinct(arrow_cast(arrow_cast(s, 'Binary'), 'FixedSizeBinary(1)')) FROM approx_distinct_group_test WHERE g = 2;+----+2++# FixedSizeBinary grouped+query II+SELECT g, approx_distinct(arrow_cast(arrow_cast(s, 'Binary'), 'FixedSizeBinary(1)')) FROM approx_distinct_group_test GROUP BY g ORDER BY g;+----+1 2+2 2+3 0+4 1++# Integers (Int32): group 1 -> {10,20}=2, group 2 -> {30,40}=2, group 3 -> 0, group 4 -> {50}=1query IISELECT g, approx_distinct(i) FROM approx_distinct_group_test GROUP BY g ORDER BY g;