Skip to content

Apache DataFusion SQL Query Engine

minor: Use allow->expect to explicitly suppress Clippy lint checks (#18686)

Yongting Youd88a3b20f008
diff --git a/datafusion/core/src/dataframe/mod.rs b/datafusion/core/src/dataframe/mod.rs
index 2b94bcf63b..08ca1a176e 100644
--- a/datafusion/core/src/dataframe/mod.rs
+++ b/datafusion/core/src/dataframe/mod.rs
@@ -2392,7 +2392,7 @@ impl DataFrame {
/// # Ok(())
/// # }
/// ```
- #[allow(clippy::needless_pass_by_value)]
+ #[expect(clippy::needless_pass_by_value)]
pub fn fill_null(
&self,
value: ScalarValue,
diff --git a/datafusion/core/src/physical_planner.rs b/datafusion/core/src/physical_planner.rs
index 154fd6f9cb..6bcc45e9e4 100644
--- a/datafusion/core/src/physical_planner.rs
+++ b/datafusion/core/src/physical_planner.rs
@@ -2246,7 +2246,7 @@ impl DefaultPhysicalPlanner {
/// Optimize a physical plan by applying each physical optimizer,
/// calling observer(plan, optimizer after each one)
- #[allow(clippy::needless_pass_by_value)]
+ #[expect(clippy::needless_pass_by_value)]
pub fn optimize_physical_plan<F>(
&self,
plan: Arc<dyn ExecutionPlan>,
diff --git a/datafusion/expr/src/execution_props.rs b/datafusion/expr/src/execution_props.rs
index fe20ed9331..acfcc61b7e 100644
--- a/datafusion/expr/src/execution_props.rs
+++ b/datafusion/expr/src/execution_props.rs
@@ -102,7 +102,7 @@ impl ExecutionProps {
}
/// Returns the provider for the `var_type`, if any
- #[allow(clippy::needless_pass_by_value)]
+ #[expect(clippy::needless_pass_by_value)]
pub fn get_var_provider(
&self,
var_type: VarType,
diff --git a/datafusion/expr/src/literal.rs b/datafusion/expr/src/literal.rs
index c7345a455a..09d8e9bb58 100644
--- a/datafusion/expr/src/literal.rs
+++ b/datafusion/expr/src/literal.rs
@@ -21,12 +21,12 @@ use crate::Expr;
use datafusion_common::{metadata::FieldMetadata, ScalarValue};
/// Create a literal expression
-#[allow(clippy::needless_pass_by_value)]
+#[expect(clippy::needless_pass_by_value)]
pub fn lit<T: Literal>(n: T) -> Expr {
n.lit()
}
-#[allow(clippy::needless_pass_by_value)]
+#[expect(clippy::needless_pass_by_value)]
pub fn lit_with_metadata<T: Literal>(n: T, metadata: Option<FieldMetadata>) -> Expr {
let Some(metadata) = metadata else {
return n.lit();
@@ -47,7 +47,7 @@ pub fn lit_with_metadata<T: Literal>(n: T, metadata: Option<FieldMetadata>) -> E
}
/// Create a literal timestamp expression
-#[allow(clippy::needless_pass_by_value)]
+#[expect(clippy::needless_pass_by_value)]
pub fn lit_timestamp_nano<T: TimestampLiteral>(n: T) -> Expr {
n.lit_timestamp_nano()
}
diff --git a/datafusion/expr/src/logical_plan/plan.rs b/datafusion/expr/src/logical_plan/plan.rs
index c70501f110..d879a58b29 100644
--- a/datafusion/expr/src/logical_plan/plan.rs
+++ b/datafusion/expr/src/logical_plan/plan.rs
@@ -3484,7 +3484,7 @@ impl Aggregate {
///
/// This method should only be called when you are absolutely sure that the schema being
/// provided is correct for the aggregate. If in doubt, call [try_new](Self::try_new) instead.
- #[allow(clippy::needless_pass_by_value)]
+ #[expect(clippy::needless_pass_by_value)]
pub fn try_new_with_schema(
input: Arc<LogicalPlan>,
group_expr: Vec<Expr>,
diff --git a/datafusion/expr/src/utils.rs b/datafusion/expr/src/utils.rs
index b4e763cdf4..8e8483bc2a 100644
--- a/datafusion/expr/src/utils.rs
+++ b/datafusion/expr/src/utils.rs
@@ -928,7 +928,7 @@ pub fn find_valid_equijoin_key_pair(
/// round(Float64)
/// round(Float32)
/// ```
-#[allow(clippy::needless_pass_by_value)]
+#[expect(clippy::needless_pass_by_value)]
pub fn generate_signature_error_msg(
func_name: &str,
func_signature: Signature,
diff --git a/datafusion/physical-expr/src/expressions/literal.rs b/datafusion/physical-expr/src/expressions/literal.rs
index 359bfcefdb..1f3fefc60b 100644
--- a/datafusion/physical-expr/src/expressions/literal.rs
+++ b/datafusion/physical-expr/src/expressions/literal.rs
@@ -137,7 +137,7 @@ impl PhysicalExpr for Literal {
}
/// Create a literal expression
-#[allow(clippy::needless_pass_by_value)]
+#[expect(clippy::needless_pass_by_value)]
pub fn lit<T: datafusion_expr::Literal>(value: T) -> Arc<dyn PhysicalExpr> {
match value.lit() {
Expr::Literal(v, _) => Arc::new(Literal::new(v)),