Skip to content

Apache DataFusion SQL Query Engine

chore: Avoid build fails on MinIO rate limits (#20472)

Oleks Vdf8f818b29d2
diff --git a/datafusion-cli/tests/cli_integration.rs b/datafusion-cli/tests/cli_integration.rs
index 8b8b786d65..99fc2d527e 100644
--- a/datafusion-cli/tests/cli_integration.rs
+++ b/datafusion-cli/tests/cli_integration.rs
@@ -44,7 +44,7 @@ fn make_settings() -> Settings {
settings
}
-async fn setup_minio_container() -> ContainerAsync<minio::MinIO> {
+async fn setup_minio_container() -> Result<ContainerAsync<minio::MinIO>, String> {
const MINIO_ROOT_USER: &str = "TEST-DataFusionLogin";
const MINIO_ROOT_PASSWORD: &str = "TEST-DataFusionPassword";
@@ -99,27 +99,23 @@ async fn setup_minio_container() -> ContainerAsync<minio::MinIO> {
let stdout = container.stdout_to_vec().await.unwrap_or_default();
let stderr = container.stderr_to_vec().await.unwrap_or_default();
- panic!(
+ return Err(format!(
"Failed to execute command: {}\nError: {}\nStdout: {:?}\nStderr: {:?}",
cmd_ref,
e,
String::from_utf8_lossy(&stdout),
String::from_utf8_lossy(&stderr)
- );
+ ));
}
}
- container
+ Ok(container)
}
- Err(TestcontainersError::Client(e)) => {
- panic!(
- "Failed to start MinIO container. Ensure Docker is running and accessible: {e}"
- );
- }
- Err(e) => {
- panic!("Failed to start MinIO container: {e}");
- }
+ Err(TestcontainersError::Client(e)) => Err(format!(
+ "Failed to start MinIO container. Ensure Docker is running and accessible: {e}"
+ )),
+ Err(e) => Err(format!("Failed to start MinIO container: {e}")),
}
}
@@ -253,7 +249,14 @@ async fn test_cli() {
return;
}
- let container = setup_minio_container().await;
+ let container = match setup_minio_container().await {
+ Ok(c) => c,
+ Err(e) if e.contains("toomanyrequests") => {
+ eprintln!("Skipping test: Docker pull rate limit reached: {e}");
+ return;
+ }
+ e @ Err(_) => e.unwrap(),
+ };
let settings = make_settings();
let _bound = settings.bind_to_scope();
@@ -286,7 +289,14 @@ async fn test_aws_options() {
let settings = make_settings();
let _bound = settings.bind_to_scope();
- let container = setup_minio_container().await;
+ let container = match setup_minio_container().await {
+ Ok(c) => c,
+ Err(e) if e.contains("toomanyrequests") => {
+ eprintln!("Skipping test: Docker pull rate limit reached: {e}");
+ return;
+ }
+ e @ Err(_) => e.unwrap(),
+ };
let port = container.get_host_port_ipv4(9000).await.unwrap();
let input = format!(
@@ -377,7 +387,14 @@ async fn test_s3_url_fallback() {
return;
}
- let container = setup_minio_container().await;
+ let container = match setup_minio_container().await {
+ Ok(c) => c,
+ Err(e) if e.contains("toomanyrequests") => {
+ eprintln!("Skipping test: Docker pull rate limit reached: {e}");
+ return;
+ }
+ e @ Err(_) => e.unwrap(),
+ };
let mut settings = make_settings();
settings.set_snapshot_suffix("s3_url_fallback");
@@ -407,8 +424,14 @@ async fn test_object_store_profiling() {
return;
}
- let container = setup_minio_container().await;
-
+ let container = match setup_minio_container().await {
+ Ok(c) => c,
+ Err(e) if e.contains("toomanyrequests") => {
+ eprintln!("Skipping test: Docker pull rate limit reached: {e}");
+ return;
+ }
+ e @ Err(_) => e.unwrap(),
+ };
let mut settings = make_settings();
// as the object store profiling contains timestamps and durations, we must