Skip to content

Apache DataFusion SQL Query Engine

chore: enforce clippy lint needless_pass_by_value to datafusion-proto (#18715)

Dhanushe730101c4dc2
diff --git a/datafusion/proto/src/lib.rs b/datafusion/proto/src/lib.rs
index b16b12bc05..130538d5af 100644
--- a/datafusion/proto/src/lib.rs
+++ b/datafusion/proto/src/lib.rs
@@ -23,6 +23,9 @@
// Make sure fast / cheap clones on Arc are explicit:
// https://github.com/apache/datafusion/issues/11143
#![deny(clippy::clone_on_ref_ptr)]
+// https://github.com/apache/datafusion/issues/18503
+#![deny(clippy::needless_pass_by_value)]
+#![cfg_attr(test, allow(clippy::needless_pass_by_value))]
//! Serialize / Deserialize DataFusion Plans to bytes
//!
diff --git a/datafusion/proto/src/physical_plan/to_proto.rs b/datafusion/proto/src/physical_plan/to_proto.rs
index dc0a78dbcc..820628ff70 100644
--- a/datafusion/proto/src/physical_plan/to_proto.rs
+++ b/datafusion/proto/src/physical_plan/to_proto.rs
@@ -52,6 +52,7 @@ use crate::protobuf::{
use super::PhysicalExtensionCodec;
+#[expect(clippy::needless_pass_by_value)]
pub fn serialize_physical_aggr_expr(
aggr_expr: Arc<AggregateFunctionExpr>,
codec: &dyn PhysicalExtensionCodec,