Skip to content

Apache DataFusion SQL Query Engine

perf: Optimize compare_element_to_list (#20323)

Neil Conwaye9bcfb449c91
diff --git a/datafusion/functions-nested/src/position.rs b/datafusion/functions-nested/src/position.rs
index d085fa29cc..fc3a295963 100644
--- a/datafusion/functions-nested/src/position.rs
+++ b/datafusion/functions-nested/src/position.rs
@@ -164,7 +164,6 @@ fn general_position_dispatch<O: OffsetSizeTrait>(args: &[ArrayRef]) -> Result<Ar
let arr_from = if args.len() == 3 {
as_int64_array(&args[2])?
.values()
- .to_vec()
.iter()
.map(|&x| x - 1)
.collect::<Vec<_>>()
diff --git a/datafusion/functions-nested/src/utils.rs b/datafusion/functions-nested/src/utils.rs
index 4a9fffa7d1..9f46917a87 100644
--- a/datafusion/functions-nested/src/utils.rs
+++ b/datafusion/functions-nested/src/utils.rs
@@ -22,7 +22,7 @@ use std::sync::Arc;
use arrow::datatypes::{DataType, Field, Fields};
use arrow::array::{
- Array, ArrayRef, BooleanArray, GenericListArray, OffsetSizeTrait, Scalar, UInt32Array,
+ Array, ArrayRef, BooleanArray, GenericListArray, OffsetSizeTrait, Scalar,
};
use arrow::buffer::OffsetBuffer;
use datafusion_common::cast::{
@@ -161,8 +161,7 @@ pub(crate) fn compare_element_to_list(
);
}
- let indices = UInt32Array::from(vec![row_index as u32]);
- let element_array_row = arrow::compute::take(element_array, &indices, None)?;
+ let element_array_row = element_array.slice(row_index, 1);
// Compute all positions in list_row_array (that is itself an
// array) that are equal to `from_array_row`