Apache DataFusion SQL Query Engine
minor(fix): correct to_date results for formatted pre-epoch datetimes (#24049)
Burak Şeneb8e38e1de73
diff --git a/datafusion/functions/src/datetime/to_date.rs b/datafusion/functions/src/datetime/to_date.rsindex ed5b8b1632..e0a14e056a 100644--- a/datafusion/functions/src/datetime/to_date.rs+++ b/datafusion/functions/src/datetime/to_date.rs@@ -100,7 +100,7 @@ impl ToDateFunc {args,|s, format| {string_to_timestamp_millis_formatted(s, format)- .map(|n| n / (24 * 60 * 60 * 1_000))+ .map(|n| n.div_euclid(24 * 60 * 60 * 1_000)).and_then(|v| {v.try_into().map_err(|_| {internal_datafusion_err!("Unable to cast to Date32 for converting from i64 to i32 failed")diff --git a/datafusion/sqllogictest/test_files/datetime/dates.slt b/datafusion/sqllogictest/test_files/datetime/dates.sltindex abf92e1565..a6a5f480f7 100644--- a/datafusion/sqllogictest/test_files/datetime/dates.slt+++ b/datafusion/sqllogictest/test_files/datetime/dates.slt@@ -139,6 +139,12 @@ SELECT to_date('01-14-2023 01:01:30+05:30', '%q', '%d-%m-%Y %H/%M/%S', '%+', '%m----2023-01-13+# Formatted pre-epoch datetimes retain their calendar date+query D+SELECT to_date('1969-12-31 12:00:00', '%Y-%m-%d %H:%M:%S');+----+1969-12-31+statement error DataFusion error: Execution error: to_date function unsupported data type at index 1: ListSELECT to_date('2022-08-03T14:38:50+05:30', make_array('%s', '%q', '%d-%m-%Y %H:%M:%S%#z', '%+'));