Skip to content

Apache DataFusion SQL Query Engine

fix: report map_extract on a non-map argument as a plan error (#25996)

jackyleef6a155876bb0
diff --git a/datafusion/functions-nested/src/utils.rs b/datafusion/functions-nested/src/utils.rs
index 73bf3cbf4c..b1abc5fad3 100644
--- a/datafusion/functions-nested/src/utils.rs
+++ b/datafusion/functions-nested/src/utils.rs
@@ -447,7 +447,7 @@ pub(crate) fn get_map_entry_field(data_type: &DataType) -> Result<&Fields> {
}
}
}
- _ => internal_err!("Expected a Map type, got {data_type}"),
+ _ => plan_err!("Expected a Map type, got {data_type}"),
}
}
diff --git a/datafusion/sqllogictest/test_files/map.slt b/datafusion/sqllogictest/test_files/map.slt
index eef6c05b8d..38b1206ac1 100644
--- a/datafusion/sqllogictest/test_files/map.slt
+++ b/datafusion/sqllogictest/test_files/map.slt
@@ -1322,3 +1322,11 @@ INSERT INTO map_primitive_cast_insert VALUES (MAP {NULL: 1});
statement ok
DROP TABLE map_primitive_cast_insert;
+
+# element_at / map_extract on a non-map argument is a user error reported at
+# planning, not an internal error ("bug in DataFusion").
+query error Error during planning: Expected a Map type, got Int64
+SELECT element_at(1, 1);
+
+query error Error during planning: Expected a Map type, got Int64
+SELECT map_extract(1, 1);