Apache DataFusion SQL Query Engine
feat: Support BinaryView type in approx_distinct (#23333)
Michael Kleenf755cb44fa33
diff --git a/datafusion/functions-aggregate/src/approx_distinct.rs b/datafusion/functions-aggregate/src/approx_distinct.rsindex 3b74d3b714..a8dbd8611d 100644--- a/datafusion/functions-aggregate/src/approx_distinct.rs+++ b/datafusion/functions-aggregate/src/approx_distinct.rs@@ -798,6 +798,7 @@ impl AggregateUDFImpl for ApproxDistinct {| DataType::LargeUtf8| DataType::Utf8View| DataType::Binary+ | DataType::BinaryView| DataType::LargeBinary => Box::new(HLLAccumulator::new()),DataType::Null => {Box::new(NoopAccumulator::new(ScalarValue::UInt64(Some(0))))@@ -866,6 +867,7 @@ fn is_hll_groups_type(data_type: &DataType) -> bool {| DataType::LargeUtf8| DataType::Utf8View| DataType::Binary+ | DataType::BinaryView| DataType::LargeBinary)}diff --git a/datafusion/sqllogictest/test_files/aggregate.slt b/datafusion/sqllogictest/test_files/aggregate.sltindex 7f538a9bfe..37ee3d8a95 100644--- a/datafusion/sqllogictest/test_files/aggregate.slt+++ b/datafusion/sqllogictest/test_files/aggregate.slt@@ -1936,6 +1936,23 @@ SELECT g, approx_distinct(arrow_cast(s, 'Utf8View')) FROM approx_distinct_group_3 04 1+# BinaryView non-grouped+query I+SELECT approx_distinct(arrow_cast(arrow_cast(s, 'Binary'), 'BinaryView')) FROM approx_distinct_group_test WHERE g = 2;+----+2+++# BinaryView grouped+query II+SELECT g, approx_distinct(arrow_cast(arrow_cast(s, 'Binary'), 'BinaryView')) FROM approx_distinct_group_test GROUP BY g ORDER BY g;+----+1 2+2 2+3 0+4 1++# Integers (Int32): group 1 -> {10,20}=2, group 2 -> {30,40}=2, group 3 -> 0, group 4 -> {50}=1query IISELECT g, approx_distinct(i) FROM approx_distinct_group_test GROUP BY g ORDER BY g;