Apache DataFusion SQL Query Engine
test: drive stdin store reuse through get_or_create (#23061)
Xin Huangfafb4ec3a2e9
diff --git a/datafusion-cli/src/object_storage/stdin.rs b/datafusion-cli/src/object_storage/stdin.rsindex c6136be3c4..9e63068f4f 100644--- a/datafusion-cli/src/object_storage/stdin.rs+++ b/datafusion-cli/src/object_storage/stdin.rs@@ -268,15 +268,26 @@ mod tests {// stdin can only be read once, so a second `stdin://` table must reuse// the store buffered by the first instead of re-reading (now-empty)// stdin and overwriting it.+ //+ // The very first read happens inside `get_or_create` -> `object_store`,+ // which consumes the real process stdin and so cannot be driven from a+ // unit test. Seed the registry with the store that first read would have+ // produced (as the first `CREATE EXTERNAL TABLE` does), then drive the+ // lookup through `get_or_create` and assert it hands back that exact+ // store rather than rebuilding it.let url = Url::parse("stdin:///stdin.csv").unwrap();- let store =- StdinUtils::in_memory_object_store(&url, b"a\n1\n2\n".to_vec()).await?;+ let path = ObjectStorePath::from_url_path(url.path())?;+ let buffered: Arc<dyn ObjectStore> = Arc::new(InMemory::new());+ buffered.put(&path, b"a\n1\n2\n".to_vec().into()).await?;let ctx = SessionContext::new();- ctx.register_object_store(&url, store);+ ctx.register_object_store(&url, Arc::clone(&buffered));let reused = StdinUtils::get_or_create(&ctx.state(), &url).await?;- let path = ObjectStorePath::from_url_path(url.path())?;+ assert!(+ Arc::ptr_eq(&buffered, &reused),+ "get_or_create must reuse the registered stdin store, not rebuild it"+ );let bytes = reused.get(&path).await?.bytes().await?;assert_eq!(bytes.as_ref(), b"a\n1\n2\n");Ok(())