Skip to content

Apache DataFusion SQL Query Engine

Add comments to Cargo.toml about workspace overrides (#18526)

Andrew Lambfe2469099759
diff --git a/benchmarks/Cargo.toml b/benchmarks/Cargo.toml
index b3fd520814..870c826f55 100644
--- a/benchmarks/Cargo.toml
+++ b/benchmarks/Cargo.toml
@@ -26,6 +26,9 @@ repository = { workspace = true }
license = { workspace = true }
rust-version = { workspace = true }
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion-examples/Cargo.toml b/datafusion-examples/Cargo.toml
index 0ec410ecc6..38f1f8b0e0 100644
--- a/datafusion-examples/Cargo.toml
+++ b/datafusion-examples/Cargo.toml
@@ -29,6 +29,9 @@ license = { workspace = true }
authors = { workspace = true }
rust-version = { workspace = true }
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/catalog-listing/Cargo.toml b/datafusion/catalog-listing/Cargo.toml
index 4eaeed675a..4b802c0067 100644
--- a/datafusion/catalog-listing/Cargo.toml
+++ b/datafusion/catalog-listing/Cargo.toml
@@ -51,6 +51,9 @@ tokio = { workspace = true }
[dev-dependencies]
datafusion-datasource-parquet = { workspace = true }
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/catalog/Cargo.toml b/datafusion/catalog/Cargo.toml
index a1db45654b..1009e9aee4 100644
--- a/datafusion/catalog/Cargo.toml
+++ b/datafusion/catalog/Cargo.toml
@@ -49,5 +49,8 @@ object_store = { workspace = true }
parking_lot = { workspace = true }
tokio = { workspace = true }
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/common-runtime/Cargo.toml b/datafusion/common-runtime/Cargo.toml
index e53d97b413..fd9a818bcb 100644
--- a/datafusion/common-runtime/Cargo.toml
+++ b/datafusion/common-runtime/Cargo.toml
@@ -31,6 +31,9 @@ rust-version = { workspace = true }
[package.metadata.docs.rs]
all-features = true
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/common/Cargo.toml b/datafusion/common/Cargo.toml
index a9eb0f2220..b222ae12b9 100644
--- a/datafusion/common/Cargo.toml
+++ b/datafusion/common/Cargo.toml
@@ -31,6 +31,9 @@ rust-version = { workspace = true }
[package.metadata.docs.rs]
all-features = true
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/core/Cargo.toml b/datafusion/core/Cargo.toml
index f672e3a946..67a73ac6f6 100644
--- a/datafusion/core/Cargo.toml
+++ b/datafusion/core/Cargo.toml
@@ -32,6 +32,9 @@ rust-version = { workspace = true }
[package.metadata.docs.rs]
all-features = true
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/datasource-arrow/Cargo.toml b/datafusion/datasource-arrow/Cargo.toml
index b3d1e3f2ac..fbadc8708c 100644
--- a/datafusion/datasource-arrow/Cargo.toml
+++ b/datafusion/datasource-arrow/Cargo.toml
@@ -51,6 +51,9 @@ tokio = { workspace = true }
[dev-dependencies]
chrono = { workspace = true }
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/datasource-avro/Cargo.toml b/datafusion/datasource-avro/Cargo.toml
index 6bab899e7f..c9299aeb10 100644
--- a/datafusion/datasource-avro/Cargo.toml
+++ b/datafusion/datasource-avro/Cargo.toml
@@ -47,6 +47,9 @@ object_store = { workspace = true }
[dev-dependencies]
serde_json = { workspace = true }
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/datasource-csv/Cargo.toml b/datafusion/datasource-csv/Cargo.toml
index 209cea4038..c9e138759e 100644
--- a/datafusion/datasource-csv/Cargo.toml
+++ b/datafusion/datasource-csv/Cargo.toml
@@ -47,6 +47,9 @@ object_store = { workspace = true }
regex = { workspace = true }
tokio = { workspace = true }
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/datasource-json/Cargo.toml b/datafusion/datasource-json/Cargo.toml
index 987ab60c70..37fa8d43a0 100644
--- a/datafusion/datasource-json/Cargo.toml
+++ b/datafusion/datasource-json/Cargo.toml
@@ -46,6 +46,9 @@ futures = { workspace = true }
object_store = { workspace = true }
tokio = { workspace = true }
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/datasource-parquet/Cargo.toml b/datafusion/datasource-parquet/Cargo.toml
index 1f866ffd6c..a5f6f56ac6 100644
--- a/datafusion/datasource-parquet/Cargo.toml
+++ b/datafusion/datasource-parquet/Cargo.toml
@@ -57,6 +57,9 @@ tokio = { workspace = true }
[dev-dependencies]
chrono = { workspace = true }
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/datasource/Cargo.toml b/datafusion/datasource/Cargo.toml
index 8e0738448a..19b247829d 100644
--- a/datafusion/datasource/Cargo.toml
+++ b/datafusion/datasource/Cargo.toml
@@ -74,6 +74,9 @@ zstd = { version = "0.13", optional = true, default-features = false }
criterion = { workspace = true }
tempfile = { workspace = true }
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/doc/Cargo.toml b/datafusion/doc/Cargo.toml
index b8324565a0..c1368c1531 100644
--- a/datafusion/doc/Cargo.toml
+++ b/datafusion/doc/Cargo.toml
@@ -31,6 +31,9 @@ rust-version = { workspace = true }
[package.metadata.docs.rs]
all-features = true
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/execution/Cargo.toml b/datafusion/execution/Cargo.toml
index 67a37a86c7..f9f7a1bc63 100644
--- a/datafusion/execution/Cargo.toml
+++ b/datafusion/execution/Cargo.toml
@@ -31,6 +31,9 @@ rust-version = { workspace = true }
[package.metadata.docs.rs]
all-features = true
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/expr-common/Cargo.toml b/datafusion/expr-common/Cargo.toml
index db85f32079..0c4fa2c211 100644
--- a/datafusion/expr-common/Cargo.toml
+++ b/datafusion/expr-common/Cargo.toml
@@ -31,6 +31,9 @@ rust-version = { workspace = true }
[package.metadata.docs.rs]
all-features = true
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/expr/Cargo.toml b/datafusion/expr/Cargo.toml
index e6b2734cff..11d6ca1533 100644
--- a/datafusion/expr/Cargo.toml
+++ b/datafusion/expr/Cargo.toml
@@ -31,6 +31,9 @@ rust-version = { workspace = true }
[package.metadata.docs.rs]
all-features = true
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/ffi/Cargo.toml b/datafusion/ffi/Cargo.toml
index babfe28ad5..3ac08180fb 100644
--- a/datafusion/ffi/Cargo.toml
+++ b/datafusion/ffi/Cargo.toml
@@ -30,6 +30,9 @@ rust-version = { workspace = true }
[package.metadata.docs.rs]
all-features = true
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/functions-aggregate-common/Cargo.toml b/datafusion/functions-aggregate-common/Cargo.toml
index a6e0a1fc2f..1d4fb29d9c 100644
--- a/datafusion/functions-aggregate-common/Cargo.toml
+++ b/datafusion/functions-aggregate-common/Cargo.toml
@@ -31,6 +31,9 @@ rust-version = { workspace = true }
[package.metadata.docs.rs]
all-features = true
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/functions-aggregate/Cargo.toml b/datafusion/functions-aggregate/Cargo.toml
index ffc6f3bb7a..428855a616 100644
--- a/datafusion/functions-aggregate/Cargo.toml
+++ b/datafusion/functions-aggregate/Cargo.toml
@@ -31,6 +31,9 @@ rust-version = { workspace = true }
[package.metadata.docs.rs]
all-features = true
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/functions-nested/Cargo.toml b/datafusion/functions-nested/Cargo.toml
index 6e0d1048f9..8e4801ba27 100644
--- a/datafusion/functions-nested/Cargo.toml
+++ b/datafusion/functions-nested/Cargo.toml
@@ -31,6 +31,9 @@ rust-version = { workspace = true }
[package.metadata.docs.rs]
all-features = true
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/functions-table/Cargo.toml b/datafusion/functions-table/Cargo.toml
index 78d59257dd..a5f50c072d 100644
--- a/datafusion/functions-table/Cargo.toml
+++ b/datafusion/functions-table/Cargo.toml
@@ -31,6 +31,9 @@ rust-version = { workspace = true }
[package.metadata.docs.rs]
all-features = true
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/functions-window-common/Cargo.toml b/datafusion/functions-window-common/Cargo.toml
index 466e7bc68b..6af668c145 100644
--- a/datafusion/functions-window-common/Cargo.toml
+++ b/datafusion/functions-window-common/Cargo.toml
@@ -31,6 +31,9 @@ version = { workspace = true }
[package.metadata.docs.rs]
all-features = true
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/functions-window/Cargo.toml b/datafusion/functions-window/Cargo.toml
index 23ee608a82..7036bbec9d 100644
--- a/datafusion/functions-window/Cargo.toml
+++ b/datafusion/functions-window/Cargo.toml
@@ -31,6 +31,9 @@ rust-version = { workspace = true }
[package.metadata.docs.rs]
all-features = true
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/functions/Cargo.toml b/datafusion/functions/Cargo.toml
index 1dbeee7159..ad52a551a7 100644
--- a/datafusion/functions/Cargo.toml
+++ b/datafusion/functions/Cargo.toml
@@ -31,6 +31,9 @@ rust-version = { workspace = true }
[package.metadata.docs.rs]
all-features = true
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/macros/Cargo.toml b/datafusion/macros/Cargo.toml
index 64781ddeaf..35714bfe96 100644
--- a/datafusion/macros/Cargo.toml
+++ b/datafusion/macros/Cargo.toml
@@ -31,6 +31,9 @@ rust-version = { workspace = true }
[package.metadata.docs.rs]
all-features = true
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/optimizer/Cargo.toml b/datafusion/optimizer/Cargo.toml
index f10510e097..15d3261ca5 100644
--- a/datafusion/optimizer/Cargo.toml
+++ b/datafusion/optimizer/Cargo.toml
@@ -31,6 +31,9 @@ rust-version = { workspace = true }
[package.metadata.docs.rs]
all-features = true
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/physical-expr-common/Cargo.toml b/datafusion/physical-expr-common/Cargo.toml
index 58dc767dba..4602e59c42 100644
--- a/datafusion/physical-expr-common/Cargo.toml
+++ b/datafusion/physical-expr-common/Cargo.toml
@@ -31,6 +31,9 @@ rust-version = { workspace = true }
[package.metadata.docs.rs]
all-features = true
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/physical-expr/Cargo.toml b/datafusion/physical-expr/Cargo.toml
index b7654a0f6f..953a46929c 100644
--- a/datafusion/physical-expr/Cargo.toml
+++ b/datafusion/physical-expr/Cargo.toml
@@ -31,6 +31,9 @@ rust-version = { workspace = true }
[package.metadata.docs.rs]
all-features = true
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/physical-optimizer/Cargo.toml b/datafusion/physical-optimizer/Cargo.toml
index 4df011fc0a..395da10d62 100644
--- a/datafusion/physical-optimizer/Cargo.toml
+++ b/datafusion/physical-optimizer/Cargo.toml
@@ -31,6 +31,9 @@ rust-version = { workspace = true }
[package.metadata.docs.rs]
all-features = true
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/physical-plan/Cargo.toml b/datafusion/physical-plan/Cargo.toml
index 607224782f..5858deb83c 100644
--- a/datafusion/physical-plan/Cargo.toml
+++ b/datafusion/physical-plan/Cargo.toml
@@ -31,6 +31,9 @@ rust-version = { workspace = true }
[package.metadata.docs.rs]
all-features = true
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/proto-common/gen/Cargo.toml b/datafusion/proto-common/gen/Cargo.toml
index ef56d2697d..2d2557811d 100644
--- a/datafusion/proto-common/gen/Cargo.toml
+++ b/datafusion/proto-common/gen/Cargo.toml
@@ -29,6 +29,9 @@ publish = false
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/proto/gen/Cargo.toml b/datafusion/proto/gen/Cargo.toml
index c2096b6011..d446ab0d89 100644
--- a/datafusion/proto/gen/Cargo.toml
+++ b/datafusion/proto/gen/Cargo.toml
@@ -29,6 +29,9 @@ publish = false
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/pruning/Cargo.toml b/datafusion/pruning/Cargo.toml
index 2429123bdf..bd898cba20 100644
--- a/datafusion/pruning/Cargo.toml
+++ b/datafusion/pruning/Cargo.toml
@@ -9,6 +9,9 @@ repository = { workspace = true }
license = { workspace = true }
authors = { workspace = true }
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/session/Cargo.toml b/datafusion/session/Cargo.toml
index 0489da61ee..230e26d1fc 100644
--- a/datafusion/session/Cargo.toml
+++ b/datafusion/session/Cargo.toml
@@ -38,5 +38,8 @@ datafusion-expr = { workspace = true }
datafusion-physical-plan = { workspace = true }
parking_lot = { workspace = true }
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/spark/Cargo.toml b/datafusion/spark/Cargo.toml
index 7f6210fb32..279c88b525 100644
--- a/datafusion/spark/Cargo.toml
+++ b/datafusion/spark/Cargo.toml
@@ -29,6 +29,9 @@ edition = { workspace = true }
[package.metadata.docs.rs]
all-features = true
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/sql/Cargo.toml b/datafusion/sql/Cargo.toml
index ea2cd6dfcc..5e10781417 100644
--- a/datafusion/sql/Cargo.toml
+++ b/datafusion/sql/Cargo.toml
@@ -31,6 +31,9 @@ rust-version = { workspace = true }
[package.metadata.docs.rs]
all-features = true
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/sqllogictest/Cargo.toml b/datafusion/sqllogictest/Cargo.toml
index 9cf3972701..177761e4af 100644
--- a/datafusion/sqllogictest/Cargo.toml
+++ b/datafusion/sqllogictest/Cargo.toml
@@ -30,6 +30,9 @@ version = { workspace = true }
[package.metadata.docs.rs]
all-features = true
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/substrait/Cargo.toml b/datafusion/substrait/Cargo.toml
index bff9a07a13..0d7e34881c 100644
--- a/datafusion/substrait/Cargo.toml
+++ b/datafusion/substrait/Cargo.toml
@@ -27,6 +27,9 @@ license = { workspace = true }
authors = { workspace = true }
rust-version = { workspace = true }
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/datafusion/wasmtest/Cargo.toml b/datafusion/wasmtest/Cargo.toml
index a1e344979a..d8b042cbb7 100644
--- a/datafusion/wasmtest/Cargo.toml
+++ b/datafusion/wasmtest/Cargo.toml
@@ -30,6 +30,9 @@ rust-version = { workspace = true }
[package.metadata.docs.rs]
all-features = true
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true
diff --git a/test-utils/Cargo.toml b/test-utils/Cargo.toml
index 3a161d5f4d..cdaee6f442 100644
--- a/test-utils/Cargo.toml
+++ b/test-utils/Cargo.toml
@@ -22,6 +22,9 @@ edition = { workspace = true }
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
+# Note: add additional linter rules in lib.rs.
+# Rust does not support workspace + new linter rules in subcrates yet
+# https://github.com/rust-lang/cargo/issues/13157
[lints]
workspace = true