Skip to content

armgit / dbx

Public Imported from GitHub
0

25 MB lightweight cross-platform database client for 100+ databases, including MySQL, PostgreSQL, SQLite, Redis, MongoDB, DuckDB, SQL Server, and Dameng. Built-in AI, MCP Server, CLI, desktop and Docker. | 轻量级跨平台数据库管理工具,支持 MySQL、PostgreSQL、SQLite、Redis、MongoDB、达梦等 100+ 数据库,提供桌面端、Docker、CLI、内置 AI 助手和 MCP。

63.2 KB
Raw Blame
use dbx_core::agent_manager::{
    AgentManager, AgentRegistry, ArtifactInfo, DriverInfo, InstalledDriver, JavaRuntimeConfig, JavaRuntimeMode,
    JreInfo, DEFAULT_JRE_KEY,
};
use dbx_core::agent_service::{
    build_agent_list, clear_agent_download_cache, github_url_to_r2_path, import_agent_driver, import_agent_jar,
    import_agents_from_package, import_agents_from_zip, inspect_offline_package, inspect_offline_zip,
    is_app_version_compatible, jre_needs_install, local_agent_jar_candidates, replace_download, uninstall_agent_driver,
    AgentProgressEvent,
};

fn test_manager(name: &str) -> AgentManager {
    let dir = std::env::temp_dir().join(format!("dbx-agent-service-{name}-{}", uuid::Uuid::new_v4()));
    AgentManager::new_with_base_dir(dir)
}

fn write_standalone_jre(path: &std::path::Path, version: &str, java: Option<&[u8]>) {
    let encoder = zstd::stream::write::Encoder::new(std::fs::File::create(path).unwrap(), 0).unwrap();
    let mut archive = tar::Builder::new(encoder);
    let mut append = |name: &str, bytes: &[u8]| {
        let mut header = tar::Header::new_gnu();
        header.set_size(bytes.len() as u64);
        header.set_mode(0o755);
        header.set_cksum();
        archive.append_data(&mut header, name, bytes).unwrap();
    };
    append("dbx-jre/release", format!("JAVA_VERSION=\"{version}\"\n").as_bytes());
    if let Some(java) = java {
        append(if cfg!(windows) { "dbx-jre/bin/java.exe" } else { "dbx-jre/bin/java" }, java);
    }
    archive.into_inner().unwrap().finish().unwrap();
}

#[tokio::test]
async fn standalone_jre_import_works_without_registry_and_with_renamed_upload() {
    let dir = tempfile::tempdir().unwrap();
    let package = dir.path().join("agent-offline-upload.tar.zst");
    let binary = current_platform_native_binary();
    write_standalone_jre(&package, "21.0.12.1", Some(&binary));
    let plan = inspect_offline_package(&package).unwrap();
    assert!(plan.includes_jre);
    assert!(plan.driver_keys.is_empty());
    let manager = AgentManager::new_with_base_dir(dir.path().join("agents"));
    let result = import_agents_from_package(&manager, &package, |_| {}).await.unwrap();
    assert_eq!(result.jre_installed, vec!["21"]);
    assert!(result.drivers_installed.is_empty());
    assert!(manager.is_jre_installed("21"));
    assert_eq!(manager.load_state().jre_versions["21"], "21.0.12.1");
}

#[tokio::test]
async fn standalone_jre_invalid_package_preserves_existing_runtime() {
    let dir = tempfile::tempdir().unwrap();
    let manager = AgentManager::new_with_base_dir(dir.path().join("agents"));
    let package = dir.path().join("upload.tar.zst");
    write_standalone_jre(&package, "21.0.12.1", Some(&current_platform_native_binary()));
    import_agents_from_package(&manager, &package, |_| {}).await.unwrap();
    for (version, java) in
        [("21.0.13", None), ("../../outside", Some(b"bad".as_slice())), ("21.0.13", Some(b"bad".as_slice()))]
    {
        write_standalone_jre(&package, version, java);
        assert!(inspect_offline_package(&package).is_err());
        assert!(import_agents_from_package(&manager, &package, |_| {}).await.is_err());
        assert_eq!(manager.load_state().jre_versions["21"], "21.0.12.1");
        assert!(manager.is_jre_installed("21"));
    }
    write_standalone_jre(&package, "21.0.13", Some(&current_platform_native_binary()));
    import_agents_from_package(&manager, &package, |_| {}).await.unwrap();
    assert_eq!(manager.load_state().jre_versions["21"], "21.0.13");
}

#[test]
fn standalone_jre_rejects_wrong_cpu_architecture() {
    let dir = tempfile::tempdir().unwrap();
    let package = dir.path().join("upload.tar.zst");
    write_standalone_jre(&package, "21.0.12.1", Some(&native_binary_for_arch(!cfg!(target_arch = "aarch64"))));
    assert!(inspect_offline_package(&package).unwrap_err().contains("does not support platform"));
}

#[test]
fn standalone_jre_rejects_links_outside_archive() {
    let dir = tempfile::tempdir().unwrap();
    let package = dir.path().join("upload.tar.zst");
    let encoder = zstd::stream::write::Encoder::new(std::fs::File::create(&package).unwrap(), 0).unwrap();
    let mut archive = tar::Builder::new(encoder);
    let release = b"JAVA_VERSION=\"21.0.12.1\"\n";
    let mut header = tar::Header::new_gnu();
    header.set_size(release.len() as u64);
    header.set_mode(0o644);
    header.set_cksum();
    archive.append_data(&mut header, "dbx-jre/release", release.as_slice()).unwrap();
    let mut header = tar::Header::new_gnu();
    header.set_entry_type(tar::EntryType::Symlink);
    header.set_size(0);
    header.set_mode(0o777);
    archive.append_link(&mut header, "dbx-jre/lib/escape", "../../outside").unwrap();
    archive.into_inner().unwrap().finish().unwrap();
    assert!(inspect_offline_package(&package).unwrap_err().contains("non-regular entry"));
    assert!(!dir.path().join("outside").exists());
}

#[tokio::test]
#[ignore = "requires DBX_TEST_JRE_PACKAGE containing an official package for the current platform"]
async fn standalone_jre_official_package_runs_java_after_import() {
    let package = std::path::PathBuf::from(std::env::var("DBX_TEST_JRE_PACKAGE").unwrap());
    let dir = tempfile::tempdir().unwrap();
    let manager = AgentManager::new_with_base_dir(dir.path().join("agents"));
    assert!(inspect_offline_package(&package).unwrap().includes_jre);
    let result = import_agents_from_package(&manager, &package, |_| {}).await.unwrap();
    let key = &result.jre_installed[0];
    let java = manager.jre_dir(key).join("bin").join(if cfg!(windows) { "java.exe" } else { "java" });
    let output = std::process::Command::new(java).arg("-version").output().unwrap();
    assert!(output.status.success(), "{}", String::from_utf8_lossy(&output.stderr));
    println!("{}", String::from_utf8_lossy(&output.stderr));
}

fn registry_with_driver(db_type: &str, version: &str, jre: &str) -> AgentRegistry {
    let mut drivers = std::collections::HashMap::new();
    drivers.insert(
        db_type.to_string(),
        DriverInfo {
            version: version.to_string(),
            label: db_type.to_string(),
            min_app_version: "0.1.0".to_string(),
            jre: jre.to_string(),
            jar: Some(ArtifactInfo {
                url: format!("https://example.com/dbx-agent-{db_type}.jar"),
                sha256: None,
                size: 42,
                format: None,
                delta: None,
            }),
            native: std::collections::HashMap::new(),
        },
    );
    AgentRegistry { jre: None, jres: std::collections::HashMap::new(), drivers }
}

fn registry_with_jre_driver(db_type: &str, driver_version: &str, jre: &str, jre_version: &str) -> AgentRegistry {
    let mut registry = registry_with_driver(db_type, driver_version, jre);
    registry.jres.insert(
        jre.to_string(),
        JreInfo { version: jre_version.to_string(), platforms: std::collections::HashMap::new() },
    );
    registry
}

fn registry_with_native_driver(db_type: &str, version: &str, jre: &str) -> AgentRegistry {
    let mut drivers = std::collections::HashMap::new();
    drivers.insert(
        db_type.to_string(),
        DriverInfo {
            version: version.to_string(),
            label: db_type.to_string(),
            min_app_version: "0.1.0".to_string(),
            jre: jre.to_string(),
            jar: Some(ArtifactInfo {
                url: format!("https://example.com/dbx-agent-{db_type}-legacy-placeholder.jar"),
                sha256: None,
                size: 0,
                format: None,
                delta: None,
            }),
            native: [(
                AgentManager::current_platform().to_string(),
                ArtifactInfo {
                    url: format!("https://example.com/dbx-agent-{db_type}"),
                    sha256: None,
                    size: 42,
                    format: None,
                    delta: None,
                },
            )]
            .into_iter()
            .collect(),
        },
    );
    AgentRegistry { jre: None, jres: std::collections::HashMap::new(), drivers }
}

/// A native-only driver the registry publishes for every platform *except* this
/// one, mirroring the Windows-only Oracle OCI agent on macOS and Linux.
fn registry_with_foreign_platform_native_driver(db_type: &str, version: &str) -> AgentRegistry {
    let current = AgentManager::current_platform();
    let native = ["macos-aarch64", "macos-x64", "linux-aarch64", "linux-x64", "windows-aarch64", "windows-x64"]
        .into_iter()
        .filter(|platform| *platform != current)
        .map(|platform| {
            (
                platform.to_string(),
                ArtifactInfo {
                    url: format!("https://example.com/dbx-agent-{db_type}-{platform}"),
                    sha256: None,
                    size: 42,
                    format: None,
                    delta: None,
                },
            )
        })
        .collect();
    let mut drivers = std::collections::HashMap::new();
    drivers.insert(
        db_type.to_string(),
        DriverInfo {
            version: version.to_string(),
            label: db_type.to_string(),
            min_app_version: "0.1.0".to_string(),
            jre: DEFAULT_JRE_KEY.to_string(),
            // Native-only drivers still carry a zero-size legacy JAR placeholder,
            // which must not be mistaken for an installable fallback.
            jar: Some(ArtifactInfo {
                url: format!("https://example.com/dbx-agent-{db_type}-legacy-placeholder.jar"),
                sha256: None,
                size: 0,
                format: None,
                delta: None,
            }),
            native,
        },
    );
    AgentRegistry { jre: None, jres: std::collections::HashMap::new(), drivers }
}

#[test]
fn agent_list_hides_a_driver_the_registry_publishes_for_other_platforms_only() {
    let manager = test_manager("foreign-platform-hidden");
    let registry = registry_with_foreign_platform_native_driver("oracle-oci", "0.1.0");

    let agents = build_agent_list(&manager, Some(&registry));

    assert!(
        !agents.iter().any(|agent| agent.db_type == "oracle-oci"),
        "a driver with no artifact for this platform must not be offered for install"
    );
}

#[test]
fn agent_list_keeps_an_installed_driver_the_registry_publishes_for_other_platforms_only() {
    let manager = test_manager("foreign-platform-installed");
    let native_path = manager.driver_native_path("oracle-oci");
    std::fs::create_dir_all(native_path.parent().unwrap()).unwrap();
    std::fs::write(&native_path, b"agent").unwrap();
    manager
        .save_state(&dbx_core::agent_manager::AgentState {
            installed_drivers: [(
                "oracle-oci".to_string(),
                InstalledDriver {
                    version: "0.1.0".to_string(),
                    installed_at: "2026-05-18T00:00:00Z".to_string(),
                    jre: DEFAULT_JRE_KEY.to_string(),
                },
            )]
            .into_iter()
            .collect(),
            ..Default::default()
        })
        .unwrap();
    let registry = registry_with_foreign_platform_native_driver("oracle-oci", "0.1.0");

    let agents = build_agent_list(&manager, Some(&registry));

    let oci = agents
        .iter()
        .find(|agent| agent.db_type == "oracle-oci")
        .expect("an installed driver must stay listed so it can be upgraded or removed");
    assert!(oci.installed);
}

#[test]
fn agent_list_keeps_the_sqlite_worker_although_its_binaries_target_another_platform() {
    // The SSH worker executes on the remote host, so a `native` set without a
    // desktop platform must not hide it (#8987).
    let manager = test_manager("sqlite-worker-platform-gate");
    let registry = registry_with_foreign_platform_native_driver("sqlite-worker", "0.1.0");

    let agents = build_agent_list(&manager, Some(&registry));

    assert!(agents.iter().any(|agent| agent.db_type == "sqlite-worker"));
}

#[test]
fn built_in_agent_list_includes_expected_driver_labels() {
    let manager = test_manager("labels");

    let agents = build_agent_list(&manager, None);

    assert!(agents.iter().any(|agent| agent.db_type == "tdengine" && agent.label == "TDengine"));
    assert!(agents.iter().any(|agent| agent.db_type == "iotdb" && agent.label == "Apache IoTDB"));
    assert!(agents.iter().any(|agent| agent.db_type == "yashandb" && agent.label == "崖山 YashanDB"));
    assert!(agents.iter().any(|agent| agent.db_type == "access" && agent.label == "Microsoft Access"));
}

#[test]
fn agent_list_marks_installed_driver_update_when_registry_version_differs() {
    let manager = test_manager("update");
    let jar_path = manager.driver_jar_path("h2");
    std::fs::create_dir_all(jar_path.parent().unwrap()).unwrap();
    write_test_agent_jar(&jar_path);
    manager
        .save_state(&dbx_core::agent_manager::AgentState {
            installed_drivers: [(
                "h2".to_string(),
                InstalledDriver {
                    version: "0.1.0".to_string(),
                    installed_at: "2026-05-18T00:00:00Z".to_string(),
                    jre: DEFAULT_JRE_KEY.to_string(),
                },
            )]
            .into_iter()
            .collect(),
            ..Default::default()
        })
        .unwrap();
    let registry = registry_with_driver("h2", "0.2.0", "21");

    let agents = build_agent_list(&manager, Some(&registry));
    let h2 = agents.iter().find(|agent| agent.db_type == "h2").unwrap();

    assert!(h2.installed);
    assert_eq!(h2.installed_version.as_deref(), Some("0.1.0"));
    assert_eq!(h2.version, "0.2.0");
    assert_eq!(h2.size, 42);
    assert_eq!(h2.jre, "21");
    assert!(h2.requires_java_runtime);
    assert!(h2.update_available);
}

#[test]
fn agent_list_marks_update_when_installed_managed_jre_version_differs() {
    let manager = test_manager("jre-update");
    let jar_path = manager.driver_jar_path("h2");
    let java_path = manager.jre_java_path(DEFAULT_JRE_KEY);
    std::fs::create_dir_all(jar_path.parent().unwrap()).unwrap();
    std::fs::create_dir_all(java_path.parent().unwrap()).unwrap();
    write_test_agent_jar(&jar_path);
    std::fs::write(&java_path, b"java").unwrap();
    manager
        .save_state(&dbx_core::agent_manager::AgentState {
            jre_versions: [(DEFAULT_JRE_KEY.to_string(), "21.0.10".to_string())].into_iter().collect(),
            installed_drivers: [(
                "h2".to_string(),
                InstalledDriver {
                    version: "0.2.0".to_string(),
                    installed_at: "2026-05-18T00:00:00Z".to_string(),
                    jre: DEFAULT_JRE_KEY.to_string(),
                },
            )]
            .into_iter()
            .collect(),
            ..Default::default()
        })
        .unwrap();
    let registry = registry_with_jre_driver("h2", "0.2.0", DEFAULT_JRE_KEY, "21.0.11");

    let agents = build_agent_list(&manager, Some(&registry));
    let h2 = agents.iter().find(|agent| agent.db_type == "h2").unwrap();

    assert!(h2.update_available);
}

#[test]
fn agent_list_does_not_mark_jre_update_for_system_java_runtime() {
    let manager = test_manager("system-java-no-jre-update");
    let jar_path = manager.driver_jar_path("dameng");
    std::fs::create_dir_all(jar_path.parent().unwrap()).unwrap();
    write_test_agent_jar(&jar_path);
    manager
        .save_state(&dbx_core::agent_manager::AgentState {
            java_runtime: JavaRuntimeConfig { mode: JavaRuntimeMode::System, custom_java_path: None },
            installed_drivers: [(
                "dameng".to_string(),
                InstalledDriver {
                    version: "0.2.0".to_string(),
                    installed_at: "2026-05-18T00:00:00Z".to_string(),
                    jre: DEFAULT_JRE_KEY.to_string(),
                },
            )]
            .into_iter()
            .collect(),
            ..Default::default()
        })
        .unwrap();
    let registry = registry_with_jre_driver("dameng", "0.2.0", DEFAULT_JRE_KEY, "21.0.11");

    let agents = build_agent_list(&manager, Some(&registry));
    let dameng = agents.iter().find(|agent| agent.db_type == "dameng").unwrap();

    assert!(dameng.installed);
    assert!(!dameng.jre_installed);
    assert!(!dameng.update_available);
}

#[test]
fn agent_list_does_not_require_jre_for_native_agent() {
    let manager = test_manager("native-no-jre");
    let native_path = manager.driver_native_path("dameng");
    std::fs::create_dir_all(native_path.parent().unwrap()).unwrap();
    std::fs::write(&native_path, b"agent").unwrap();
    manager
        .save_state(&dbx_core::agent_manager::AgentState {
            installed_drivers: [(
                "dameng".to_string(),
                InstalledDriver {
                    version: "0.2.0".to_string(),
                    installed_at: "2026-05-18T00:00:00Z".to_string(),
                    jre: DEFAULT_JRE_KEY.to_string(),
                },
            )]
            .into_iter()
            .collect(),
            ..Default::default()
        })
        .unwrap();

    let agents = build_agent_list(&manager, None);
    let dameng = agents.iter().find(|agent| agent.db_type == "dameng").unwrap();

    assert!(dameng.installed);
    assert!(!dameng.requires_java_runtime);
    assert!(dameng.jre_installed);
}

#[test]
fn agent_list_does_not_require_jre_for_registry_native_agent() {
    let manager = test_manager("registry-native-no-jre");
    let registry = registry_with_native_driver("xugu", "0.2.0", DEFAULT_JRE_KEY);

    let agents = build_agent_list(&manager, Some(&registry));
    let xugu = agents.iter().find(|agent| agent.db_type == "xugu").unwrap();

    assert!(!xugu.installed);
    assert_eq!(xugu.jre, DEFAULT_JRE_KEY);
    assert!(!xugu.requires_java_runtime);
    assert!(xugu.jre_installed);
}

#[test]
fn agent_list_keeps_jre_requirement_for_installed_jar_when_registry_has_native() {
    let manager = test_manager("installed-jar-registry-native");
    let jar_path = manager.driver_jar_path("xugu");
    std::fs::create_dir_all(jar_path.parent().unwrap()).unwrap();
    write_test_agent_jar(&jar_path);
    manager
        .save_state(&dbx_core::agent_manager::AgentState {
            installed_drivers: [(
                "xugu".to_string(),
                InstalledDriver {
                    version: "0.2.0".to_string(),
                    installed_at: "2026-05-18T00:00:00Z".to_string(),
                    jre: DEFAULT_JRE_KEY.to_string(),
                },
            )]
            .into_iter()
            .collect(),
            ..Default::default()
        })
        .unwrap();
    let registry = registry_with_native_driver("xugu", "0.2.0", DEFAULT_JRE_KEY);

    let agents = build_agent_list(&manager, Some(&registry));
    let xugu = agents.iter().find(|agent| agent.db_type == "xugu").unwrap();

    assert!(xugu.installed);
    assert!(xugu.requires_java_runtime);
    assert!(!xugu.jre_installed);
}

#[test]
fn agent_list_reports_missing_jre_for_uninstalled_java_drivers() {
    let manager = test_manager("uninstalled-java-driver-missing-jre");
    let registry = registry_with_jre_driver("dameng", "0.2.0", DEFAULT_JRE_KEY, "21.0.11");

    let agents = build_agent_list(&manager, Some(&registry));
    let dameng = agents.iter().find(|agent| agent.db_type == "dameng").unwrap();

    assert!(!dameng.installed);
    assert!(!dameng.jre_installed);
}

#[test]
fn agent_list_uses_legacy_default_jre_version_when_checking_updates() {
    let manager = test_manager("legacy-jre-version");
    let jar_path = manager.driver_jar_path("dameng");
    let java_path = manager.jre_java_path(DEFAULT_JRE_KEY);
    std::fs::create_dir_all(jar_path.parent().unwrap()).unwrap();
    std::fs::create_dir_all(java_path.parent().unwrap()).unwrap();
    write_test_agent_jar(&jar_path);
    std::fs::write(&java_path, b"java").unwrap();
    manager
        .save_state(&dbx_core::agent_manager::AgentState {
            jre_version: Some("21.0.11".to_string()),
            installed_drivers: [(
                "dameng".to_string(),
                InstalledDriver {
                    version: "0.2.0".to_string(),
                    installed_at: "2026-05-18T00:00:00Z".to_string(),
                    jre: DEFAULT_JRE_KEY.to_string(),
                },
            )]
            .into_iter()
            .collect(),
            ..Default::default()
        })
        .unwrap();
    let registry = registry_with_jre_driver("dameng", "0.2.0", DEFAULT_JRE_KEY, "21.0.11");

    let agents = build_agent_list(&manager, Some(&registry));
    let dameng = agents.iter().find(|agent| agent.db_type == "dameng").unwrap();

    assert!(!dameng.update_available);
}

#[test]
fn jre_needs_install_when_managed_runtime_version_differs() {
    let manager = test_manager("jre-needs-install");
    let java_path = manager.jre_java_path(DEFAULT_JRE_KEY);
    std::fs::create_dir_all(java_path.parent().unwrap()).unwrap();
    std::fs::write(&java_path, b"java").unwrap();
    manager
        .save_state(&dbx_core::agent_manager::AgentState {
            jre_versions: [(DEFAULT_JRE_KEY.to_string(), "21.0.10".to_string())].into_iter().collect(),
            ..Default::default()
        })
        .unwrap();
    let registry = registry_with_jre_driver("h2", "0.2.0", DEFAULT_JRE_KEY, "21.0.11");

    assert!(jre_needs_install(&manager, &registry, DEFAULT_JRE_KEY));
}

#[test]
fn local_agent_jar_candidates_include_monorepo_and_legacy_build_output() {
    let candidates = local_agent_jar_candidates("tdengine");

    assert!(candidates.iter().any(|path| path.ends_with("agents/drivers/tdengine/build/libs/dbx-agent-tdengine.jar")));
    assert!(candidates.iter().any(|path| path.ends_with("dbx-agents/tdengine/build/libs/dbx-agent-tdengine.jar")));
}

#[test]
fn github_agent_asset_urls_map_to_r2_paths_by_category() {
    assert_eq!(
        github_url_to_r2_path("https://github.com/t8y2/dbx-agents/releases/download/v1/dbx-jre-21.tar.gz", "jre"),
        "agents/jre/dbx-jre-21.tar.gz"
    );
    assert_eq!(
        github_url_to_r2_path("https://github.com/t8y2/dbx-agents/releases/download/v1/dbx-agent-h2.jar", "driver"),
        "agents/drivers/dbx-agent-h2.jar"
    );
    assert_eq!(
        github_url_to_r2_path("https://github.com/t8y2/dbx/releases/download/agents-v0.3.0/dbx-agent-h2.jar", "driver"),
        "agents/drivers/dbx-agent-h2.jar"
    );
}

fn test_path(name: &str) -> std::path::PathBuf {
    std::env::temp_dir().join(format!("dbx-agent-service-{name}-{}", uuid::Uuid::new_v4()))
}

#[test]
fn accepts_current_app_when_min_version_is_not_newer() {
    assert!(is_app_version_compatible("0.5.13", "0.5.13"));
    assert!(is_app_version_compatible("0.5.12", "0.5.13"));
    assert!(!is_app_version_compatible("0.5.14", "0.5.13"));
}

#[test]
fn atomic_replace_moves_download_into_place() {
    let dir = test_path("atomic");
    std::fs::create_dir_all(&dir).unwrap();
    let dest = dir.join("agent.jar");
    let tmp = dir.join("agent.jar.download");
    std::fs::write(&dest, b"old").unwrap();
    std::fs::write(&tmp, b"new").unwrap();

    replace_download(&tmp, &dest).unwrap();

    assert_eq!(std::fs::read(&dest).unwrap(), b"new");
    assert!(!tmp.exists());
    std::fs::remove_dir_all(dir).ok();
}

#[test]
fn agent_progress_event_serializes_backward_compatible_fields() {
    let event = AgentProgressEvent::transfer("driver", 512, 1024)
        .with_batch(Some("h2"), Some(1), Some(2))
        .with_operation_id("upgrade-123");

    let value = serde_json::to_value(event).unwrap();

    assert_eq!(value["step"], "driver");
    assert_eq!(value["downloaded"], 512);
    assert_eq!(value["total"], 1024);
    assert_eq!(value["db_type"], "h2");
    assert_eq!(value["current"], 1);
    assert_eq!(value["total_drivers"], 2);
    assert_eq!(value["operation_id"], "upgrade-123");
}

#[tokio::test]
async fn local_jar_import_updates_driver_state() {
    let manager = test_manager("local-import");
    let source = test_path("local-import-source").join("dbx-agent-h2.jar");
    std::fs::create_dir_all(source.parent().unwrap()).unwrap();
    write_test_agent_jar(&source);

    import_agent_jar(&manager, "h2", &source).await.unwrap();

    assert_eq!(std::fs::read(manager.driver_jar_path("h2")).unwrap(), std::fs::read(&source).unwrap());
    let state = manager.load_state();
    let installed = state.installed_drivers.get("h2").unwrap();
    assert_eq!(installed.version, "0.1.0-local");
    assert_eq!(installed.jre, DEFAULT_JRE_KEY);
}

#[tokio::test]
async fn local_jar_import_rejects_corrupt_jar() {
    let manager = test_manager("local-import-corrupt");
    let source = test_path("local-import-corrupt-source").join("dbx-agent-h2.jar");
    std::fs::create_dir_all(source.parent().unwrap()).unwrap();
    std::fs::write(&source, b"jar").unwrap();

    let err = import_agent_jar(&manager, "h2", &source).await.unwrap_err();

    assert!(err.contains("invalid or corrupt"));
    assert!(!manager.driver_jar_path("h2").exists());
    assert!(!manager.load_state().installed_drivers.contains_key("h2"));
}

#[tokio::test]
async fn local_native_import_installs_current_platform_executable() {
    let manager = test_manager("local-native-import");
    let source = test_path("local-native-import-source").join(if cfg!(windows) {
        "dbx-agent-kingbase-windows.exe"
    } else {
        "dbx-agent-kingbase"
    });
    std::fs::create_dir_all(source.parent().unwrap()).unwrap();
    std::fs::write(&source, current_platform_native_binary()).unwrap();

    import_agent_driver(&manager, "kingbase", &source).await.unwrap();

    assert_eq!(std::fs::read(manager.driver_native_path("kingbase")).unwrap(), std::fs::read(&source).unwrap());
    assert!(!manager.driver_jar_path("kingbase").exists());
    assert_eq!(manager.load_state().installed_drivers["kingbase"].version, "0.1.0-local");
}

#[tokio::test]
async fn local_native_import_rejects_wrong_platform_binary() {
    let manager = test_manager("local-native-import-invalid");
    let source = test_path("local-native-import-invalid-source").join("dbx-agent-kingbase");
    std::fs::create_dir_all(source.parent().unwrap()).unwrap();
    std::fs::write(&source, b"not-an-executable").unwrap();

    let err = import_agent_driver(&manager, "kingbase", &source).await.unwrap_err();

    assert!(err.contains(AgentManager::current_platform()));
    assert!(!manager.driver_native_path("kingbase").exists());
    assert!(!manager.load_state().installed_drivers.contains_key("kingbase"));
}

#[tokio::test]
async fn local_native_import_rejects_wrong_arch_binary() {
    let manager = test_manager("local-native-wrong-arch");
    let native_path = test_path("local-native-wrong-arch-file").join("agent");
    std::fs::create_dir_all(native_path.parent().unwrap()).unwrap();
    std::fs::write(&native_path, native_binary_for_arch(!cfg!(target_arch = "aarch64"))).unwrap();

    let err = import_agent_driver(&manager, "kingbase", &native_path).await.unwrap_err();

    assert!(err.contains("not a"));
    assert!(!manager.driver_native_path("kingbase").exists());
}

#[tokio::test]
async fn uninstall_driver_removes_artifact_and_state() {
    let manager = test_manager("uninstall");
    let jar_path = manager.driver_jar_path("h2");
    std::fs::create_dir_all(jar_path.parent().unwrap()).unwrap();
    std::fs::write(&jar_path, b"jar").unwrap();
    let cache_dir = manager.download_cache_dir();
    std::fs::create_dir_all(&cache_dir).unwrap();
    let h2_cache = cache_dir.join("driver-h2-0.1.0-abc-agent.jar");
    let dameng_cache = cache_dir.join("driver-dameng-0.1.0-abc-agent.jar");
    let jre_cache = cache_dir.join("jre-21-21.0.11-abc-jre-download.tar.gz");
    std::fs::write(&h2_cache, b"h2").unwrap();
    std::fs::write(&dameng_cache, b"dameng").unwrap();
    std::fs::write(&jre_cache, b"jre").unwrap();
    manager
        .save_state(&dbx_core::agent_manager::AgentState {
            installed_drivers: [(
                "h2".to_string(),
                InstalledDriver {
                    version: "0.1.0".to_string(),
                    installed_at: "2026-05-18T00:00:00Z".to_string(),
                    jre: DEFAULT_JRE_KEY.to_string(),
                },
            )]
            .into_iter()
            .collect(),
            ..Default::default()
        })
        .unwrap();

    uninstall_agent_driver(&manager, "h2").await.unwrap();

    assert!(!jar_path.exists());
    assert!(!h2_cache.exists());
    assert!(dameng_cache.exists());
    assert!(jre_cache.exists());
    assert!(!manager.load_state().installed_drivers.contains_key("h2"));
}

#[test]
fn clear_download_cache_removes_only_cache_entries() {
    let manager = test_manager("clear-download-cache");
    let cache_dir = manager.download_cache_dir();
    let driver_dir = manager.driver_dir("h2");
    std::fs::create_dir_all(&cache_dir).unwrap();
    std::fs::create_dir_all(&driver_dir).unwrap();
    let driver_cache = cache_dir.join("driver-h2-0.1.0-abc-agent.jar");
    let jre_cache = cache_dir.join("jre-21-21.0.11-abc-jre-download.tar.gz");
    let nested_cache = cache_dir.join("stale-dir");
    let installed_driver = driver_dir.join("agent.jar");
    std::fs::write(&driver_cache, b"h2").unwrap();
    std::fs::write(&jre_cache, b"jre").unwrap();
    std::fs::create_dir_all(&nested_cache).unwrap();
    std::fs::write(nested_cache.join("artifact"), b"x").unwrap();
    std::fs::write(&installed_driver, b"driver").unwrap();

    clear_agent_download_cache(&manager).unwrap();

    assert!(!driver_cache.exists());
    assert!(!jre_cache.exists());
    assert!(!nested_cache.exists());
    assert!(installed_driver.exists());
}

#[tokio::test]
async fn offline_zip_import_emits_progress_and_updates_state() {
    let manager = test_manager("offline-progress");
    let zip_path = test_path("offline-progress-zip").join("agents.zip");
    std::fs::create_dir_all(zip_path.parent().unwrap()).unwrap();
    write_offline_driver_zip(&zip_path, "h2", "0.2.0");
    let events = std::sync::Mutex::new(Vec::new());

    let result = import_agents_from_zip(&manager, &zip_path, |event| {
        events.lock().unwrap().push(event);
    })
    .await
    .unwrap();

    assert_eq!(result.drivers_installed, vec!["h2"]);
    let installed_jar = std::fs::read(manager.driver_jar_path("h2")).unwrap();
    assert!(installed_jar.windows(b"Main-Class:".len()).any(|window| window == b"Main-Class:"));
    assert_eq!(manager.load_state().installed_drivers.get("h2").unwrap().version, "0.2.0");
    let events = events.lock().unwrap();
    // db_type carries the real database key, not the display label.
    assert!(events.iter().any(|event| event.step == "driver" && event.db_type.as_deref() == Some("h2")));
}

#[tokio::test]
async fn offline_zip_import_installs_release_named_jre() {
    let manager = test_manager("offline-release-jre");
    let zip_path = test_path("offline-release-jre-zip").join("agents.zip");
    std::fs::create_dir_all(zip_path.parent().unwrap()).unwrap();
    write_offline_driver_zip_with_jre(&zip_path, "h2", "0.2.0", "21.0.12");
    let events = std::sync::Mutex::new(Vec::new());

    let result = import_agents_from_zip(&manager, &zip_path, |event| {
        events.lock().unwrap().push(event);
    })
    .await
    .unwrap();

    assert_eq!(result.jre_installed, vec![DEFAULT_JRE_KEY]);
    assert_eq!(result.drivers_installed, vec!["h2"]);
    assert!(manager.is_jre_installed(DEFAULT_JRE_KEY));
    assert_eq!(manager.load_state().jre_versions.get(DEFAULT_JRE_KEY).map(String::as_str), Some("21.0.12"));
    assert!(events.lock().unwrap().iter().any(|event| event.step == "jre-extract"));
}

#[tokio::test]
async fn offline_zip_import_installs_tar_zstd_jre() {
    let manager = test_manager("offline-zstd-jre");
    let zip_path = test_path("offline-zstd-jre-zip").join("agents.zip");
    std::fs::create_dir_all(zip_path.parent().unwrap()).unwrap();
    write_offline_driver_zip_with_zstd_jre(&zip_path, "h2", "0.2.0", "21.0.12");

    let result = import_agents_from_zip(&manager, &zip_path, |_| {}).await.unwrap();

    assert_eq!(result.jre_installed, vec![DEFAULT_JRE_KEY]);
    assert_eq!(result.drivers_installed, vec!["h2"]);
    assert!(manager.is_jre_installed(DEFAULT_JRE_KEY));
    assert_eq!(manager.load_state().jre_versions.get(DEFAULT_JRE_KEY).map(String::as_str), Some("21.0.12"));
}

#[tokio::test]
async fn offline_zip_import_preserves_existing_jre_when_archive_is_corrupt() {
    let manager = test_manager("offline-corrupt-jre-preserves-existing");
    let root = test_path("offline-corrupt-jre-preserves-existing-zip");
    let valid_zip = root.join("valid.zip");
    let corrupt_zip = root.join("corrupt.zip");
    std::fs::create_dir_all(&root).unwrap();
    write_offline_driver_zip_with_jre(&valid_zip, "h2", "0.2.0", "21.0.12");
    import_agents_from_zip(&manager, &valid_zip, |_| {}).await.unwrap();
    let java_path = manager.jre_java_path(DEFAULT_JRE_KEY);
    let original_java = std::fs::read(&java_path).unwrap();

    write_offline_driver_zip_with_jre_bytes(&corrupt_zip, "h2", "0.3.0", "21.0.13", b"not-a-tar-gz".to_vec());
    let result = import_agents_from_zip(&manager, &corrupt_zip, |_| {}).await.unwrap();

    assert!(result.jre_installed.is_empty());
    // The unusable JRE must not stop the drivers that do work.
    assert_eq!(result.drivers_installed, vec!["h2"]);
    assert_eq!(result.failures.len(), 1);
    assert!(result.failures[0].is_jre);
    assert_eq!(result.failures[0].key, DEFAULT_JRE_KEY);
    assert!(
        result.failures[0].error.contains("Failed to extract JRE archive"),
        "unexpected error: {}",
        result.failures[0].error
    );
    assert_eq!(std::fs::read(java_path).unwrap(), original_java);
    assert_eq!(manager.load_state().jre_versions.get(DEFAULT_JRE_KEY).map(String::as_str), Some("21.0.12"));
}

#[tokio::test]
async fn offline_zip_import_installs_jre_and_reports_corrupt_driver() {
    let manager = test_manager("offline-corrupt-driver-reports-failure");
    let root = test_path("offline-corrupt-driver-reports-failure-zip");
    let valid_zip = root.join("valid.zip");
    let corrupt_zip = root.join("corrupt.zip");
    std::fs::create_dir_all(&root).unwrap();
    write_offline_driver_zip_with_jre(&valid_zip, "h2", "0.2.0", "21.0.12");
    import_agents_from_zip(&manager, &valid_zip, |_| {}).await.unwrap();
    let original_jar = std::fs::read(manager.driver_jar_path("h2")).unwrap();

    write_offline_driver_zip_with_jre_and_jar_bytes(
        &corrupt_zip,
        "h2",
        "0.3.0",
        "21.0.13",
        test_jre_archive_bytes(),
        b"jar".to_vec(),
    );
    let result = import_agents_from_zip(&manager, &corrupt_zip, |_| {}).await.unwrap();

    assert_eq!(result.jre_installed, vec![DEFAULT_JRE_KEY]);
    assert!(result.drivers_installed.is_empty());
    assert_eq!(result.failures.len(), 1);
    assert!(!result.failures[0].is_jre);
    assert_eq!(result.failures[0].key, "h2");
    assert!(result.failures[0].error.contains("invalid or corrupt"), "unexpected error: {}", result.failures[0].error);
    // A corrupt driver artifact must not replace the working installation.
    assert_eq!(std::fs::read(manager.driver_jar_path("h2")).unwrap(), original_jar);
    assert_eq!(manager.load_state().installed_drivers["h2"].version, "0.2.0");
    assert_eq!(manager.load_state().jre_versions.get(DEFAULT_JRE_KEY).map(String::as_str), Some("21.0.13"));
}

#[tokio::test]
async fn offline_zip_import_reports_corrupt_jar_without_installing_it() {
    let manager = test_manager("offline-corrupt-driver");
    let zip_path = test_path("offline-corrupt-driver-zip").join("agents.zip");
    std::fs::create_dir_all(zip_path.parent().unwrap()).unwrap();
    write_offline_driver_zip_with_jar(&zip_path, "h2", "0.2.0", b"jar".to_vec());

    let result = import_agents_from_zip(&manager, &zip_path, |_| {}).await.unwrap();

    assert!(result.drivers_installed.is_empty());
    assert_eq!(result.failures.len(), 1);
    assert_eq!(result.failures[0].key, "h2");
    assert!(result.failures[0].error.contains("invalid or corrupt"), "unexpected error: {}", result.failures[0].error);
    assert!(!manager.driver_jar_path("h2").exists());
    assert!(!manager.load_state().installed_drivers.contains_key("h2"));
}

#[tokio::test]
async fn offline_zip_import_preserves_existing_driver_when_jar_is_corrupt() {
    let manager = test_manager("offline-corrupt-driver-preserves-existing");
    let root = test_path("offline-corrupt-driver-preserves-existing-zip");
    let valid_zip = root.join("valid.zip");
    let corrupt_zip = root.join("corrupt.zip");
    std::fs::create_dir_all(&root).unwrap();
    write_offline_driver_zip(&valid_zip, "h2", "0.2.0");
    import_agents_from_zip(&manager, &valid_zip, |_| {}).await.unwrap();
    let original = std::fs::read(manager.driver_jar_path("h2")).unwrap();

    write_offline_driver_zip_with_jar(&corrupt_zip, "h2", "0.3.0", b"jar".to_vec());
    let result = import_agents_from_zip(&manager, &corrupt_zip, |_| {}).await.unwrap();

    assert_eq!(result.failures.len(), 1);
    assert_eq!(result.failures[0].key, "h2");
    assert!(result.failures[0].error.contains("invalid or corrupt"), "unexpected error: {}", result.failures[0].error);
    assert_eq!(std::fs::read(manager.driver_jar_path("h2")).unwrap(), original);
    assert_eq!(manager.load_state().installed_drivers["h2"].version, "0.2.0");
}

#[tokio::test]
async fn offline_zip_import_installs_the_remaining_drivers_when_one_item_is_broken() {
    let manager = test_manager("offline-partial-driver-package");
    let zip_path = test_path("offline-partial-driver-package-zip").join("agents.zip");
    std::fs::create_dir_all(zip_path.parent().unwrap()).unwrap();
    let valid_jar = test_agent_jar_bytes();
    write_offline_java_driver_zip(&zip_path, &[("h2", "0.2.0", &valid_jar), ("duckdb", "0.1.0", b"not-a-jar")]);

    let result = import_agents_from_zip(&manager, &zip_path, |_| {}).await.unwrap();

    assert_eq!(result.drivers_installed, vec!["h2"]);
    assert_eq!(manager.load_state().installed_drivers["h2"].version, "0.2.0");
    assert_eq!(result.failures.len(), 1);
    assert!(!result.failures[0].is_jre);
    assert_eq!(result.failures[0].key, "duckdb");
    assert!(result.failures[0].error.contains("invalid or corrupt"), "unexpected error: {}", result.failures[0].error);
    assert!(!manager.is_driver_installed("duckdb"));
}

#[tokio::test]
async fn offline_zip_import_keeps_legacy_unversioned_jar_compatibility() {
    let manager = test_manager("offline-legacy-jar-zip");
    let zip_path = test_path("offline-legacy-jar-zip").join("h2.zip");
    std::fs::create_dir_all(zip_path.parent().unwrap()).unwrap();
    let file = std::fs::File::create(&zip_path).unwrap();
    let mut zip = zip::ZipWriter::new(file);
    let options = zip::write::SimpleFileOptions::default().compression_method(zip::CompressionMethod::Stored);
    let jar = test_agent_jar_bytes();
    let registry = serde_json::json!({
        "drivers": {
            "h2": {
                "version": "0.1.9",
                "label": "H2",
                "min_app_version": "0.1.0",
                "jre": DEFAULT_JRE_KEY,
                "jar": { "url": "https://example.com/dbx-agent-h2.jar", "size": jar.len() }
            }
        }
    });
    zip.start_file("agent-registry.json", options).unwrap();
    std::io::Write::write_all(&mut zip, registry.to_string().as_bytes()).unwrap();
    zip.start_file("drivers/dbx-agent-h2.jar", options).unwrap();
    std::io::Write::write_all(&mut zip, &jar).unwrap();
    zip.finish().unwrap();

    import_agents_from_zip(&manager, &zip_path, |_| {}).await.unwrap();

    assert_eq!(manager.load_state().installed_drivers["h2"].version, "0.1.9");
}

#[tokio::test]
async fn offline_zip_import_installs_versioned_native_driver_package() {
    let manager = test_manager("offline-native-driver-zip");
    let zip_path = test_path("offline-native-driver-zip").join("kingbase.zip");
    std::fs::create_dir_all(zip_path.parent().unwrap()).unwrap();
    write_offline_native_driver_zip(&zip_path, "kingbase", "0.1.34");

    let result = import_agents_from_zip(&manager, &zip_path, |_| {}).await.unwrap();

    assert_eq!(result.drivers_installed, vec!["kingbase"]);
    assert_eq!(manager.load_state().installed_drivers["kingbase"].version, "0.1.34");
    assert_eq!(std::fs::read(manager.driver_native_path("kingbase")).unwrap(), current_platform_native_binary());
    assert!(!manager.driver_jar_path("kingbase").exists());
}

#[tokio::test]
async fn offline_tar_zstd_import_installs_versioned_native_driver_package() {
    let manager = test_manager("offline-tar-zstd-driver-package");
    let package_path = test_path("offline-tar-zstd-driver-package").join("duckdb.tar.zst");
    std::fs::create_dir_all(package_path.parent().unwrap()).unwrap();
    write_offline_tar_zstd_driver_package(&package_path, "duckdb", "0.1.0");

    let plan = inspect_offline_package(&package_path).unwrap();
    let result = import_agents_from_package(&manager, &package_path, |_| {}).await.unwrap();

    assert_eq!(plan.driver_keys, vec!["duckdb"]);
    assert!(!plan.includes_jre);
    assert_eq!(result.drivers_installed, vec!["duckdb"]);
    assert_eq!(manager.load_state().installed_drivers["duckdb"].version, "0.1.0");
    assert_eq!(std::fs::read(manager.driver_native_path("duckdb")).unwrap(), current_platform_native_binary());
}

#[tokio::test]
async fn offline_tar_zstd_import_installs_versioned_java_driver_package() {
    let manager = test_manager("offline-tar-zstd-java-package");
    let package_path = test_path("offline-tar-zstd-java-package").join("dameng.tar.zst");
    std::fs::create_dir_all(package_path.parent().unwrap()).unwrap();
    write_offline_tar_zstd_java_driver_package(&package_path, "dameng", "0.2.0");

    let plan = inspect_offline_package(&package_path).unwrap();
    let result = import_agents_from_package(&manager, &package_path, |_| {}).await.unwrap();

    assert_eq!(plan.driver_keys, vec!["dameng"]);
    assert!(!plan.includes_jre);
    assert_eq!(result.drivers_installed, vec!["dameng"]);
    assert_eq!(manager.load_state().installed_drivers["dameng"].version, "0.2.0");
    assert_eq!(std::fs::read(manager.driver_jar_path("dameng")).unwrap(), test_agent_jar_bytes());
    assert!(!manager.driver_native_path("dameng").exists());
}

#[tokio::test]
async fn offline_zip_import_rejects_native_driver_for_another_platform() {
    let manager = test_manager("offline-wrong-platform-native-driver-zip");
    let zip_path = test_path("offline-wrong-platform-native-driver-zip").join("kingbase.zip");
    std::fs::create_dir_all(zip_path.parent().unwrap()).unwrap();
    let other_platform = if AgentManager::current_platform() == "windows-x64" { "linux-x64" } else { "windows-x64" };
    write_offline_native_driver_zip_for_platform(&zip_path, "kingbase", "0.1.34", other_platform);

    let err = import_agents_from_zip(&manager, &zip_path, |_| {}).await.unwrap_err();

    assert!(err.contains("no drivers compatible"));
    assert!(err.contains(AgentManager::current_platform()));
    assert!(!manager.is_driver_installed("kingbase"));
}

#[tokio::test]
async fn offline_zip_import_preserves_existing_native_driver_when_binary_is_invalid() {
    let manager = test_manager("offline-invalid-native-preserves-existing");
    let root = test_path("offline-invalid-native-preserves-existing-zip");
    let valid_zip = root.join("valid.zip");
    let invalid_zip = root.join("invalid.zip");
    std::fs::create_dir_all(&root).unwrap();
    write_offline_native_driver_zip(&valid_zip, "kingbase", "0.1.34");
    import_agents_from_zip(&manager, &valid_zip, |_| {}).await.unwrap();
    let original = std::fs::read(manager.driver_native_path("kingbase")).unwrap();

    write_offline_native_driver_zip_with_bytes(
        &invalid_zip,
        "kingbase",
        "0.1.35",
        AgentManager::current_platform(),
        b"not-a-native-agent".to_vec(),
    );
    let result = import_agents_from_zip(&manager, &invalid_zip, |_| {}).await.unwrap();

    assert_eq!(result.failures.len(), 1);
    assert_eq!(result.failures[0].key, "kingbase");
    assert!(result.failures[0].error.contains("not a"), "unexpected error: {}", result.failures[0].error);
    assert_eq!(std::fs::read(manager.driver_native_path("kingbase")).unwrap(), original);
    assert_eq!(manager.load_state().installed_drivers["kingbase"].version, "0.1.34");
}

#[test]
fn offline_zip_inspection_reports_drivers_and_jre() {
    let zip_path = test_path("offline-inspection").join("agents.zip");
    std::fs::create_dir_all(zip_path.parent().unwrap()).unwrap();
    write_offline_driver_zip_with_jre(&zip_path, "h2", "0.2.0", "21.0.12");

    let plan = inspect_offline_zip(&zip_path).unwrap();

    assert_eq!(plan.driver_keys, vec!["h2"]);
    assert!(plan.includes_jre);
}

#[test]
fn offline_zip_import_rejects_unknown_driver_type() {
    let zip_path = test_path("offline-unknown-driver").join("agents.zip");
    std::fs::create_dir_all(zip_path.parent().unwrap()).unwrap();
    write_offline_driver_zip_with_jar(&zip_path, "unknown-driver", "0.1.0", test_agent_jar_bytes());

    let err = inspect_offline_zip(&zip_path).unwrap_err();

    assert!(err.contains("unknown driver type"));
}

#[tokio::test]
async fn offline_zip_import_accepts_hidden_legacy_h2_driver() {
    let manager = test_manager("offline-h2-legacy-driver");
    let zip_path = test_path("offline-h2-legacy-driver").join("agents.zip");
    std::fs::create_dir_all(zip_path.parent().unwrap()).unwrap();
    write_offline_driver_zip_with_jar(&zip_path, "h2-legacy", "0.1.18", test_agent_jar_bytes());

    let result = import_agents_from_zip(&manager, &zip_path, |_| {}).await.unwrap();

    assert_eq!(result.drivers_installed, vec!["h2-legacy"]);
    assert!(manager.is_driver_installed("h2-legacy"));
    assert_eq!(manager.load_state().installed_drivers["h2-legacy"].version, "0.1.18");
}

#[test]
fn offline_zip_import_rejects_unsafe_entry_path() {
    let zip_path = test_path("offline-unsafe-entry").join("agents.zip");
    std::fs::create_dir_all(zip_path.parent().unwrap()).unwrap();
    let file = std::fs::File::create(&zip_path).unwrap();
    let mut zip = zip::ZipWriter::new(file);
    let options = zip::write::SimpleFileOptions::default().compression_method(zip::CompressionMethod::Stored);
    zip.start_file("agent-registry.json", options).unwrap();
    std::io::Write::write_all(&mut zip, br#"{"drivers":{}}"#).unwrap();
    zip.start_file("../escape", options).unwrap();
    std::io::Write::write_all(&mut zip, b"escape").unwrap();
    zip.finish().unwrap();

    let err = inspect_offline_zip(&zip_path).unwrap_err();

    assert!(err.contains("unsafe path"));
}

#[tokio::test]
async fn offline_zip_import_prefers_native_artifact_over_java_fallback() {
    let manager = test_manager("offline-native-preferred");
    let zip_path = test_path("offline-native-preferred-zip").join("kingbase.zip");
    std::fs::create_dir_all(zip_path.parent().unwrap()).unwrap();
    write_offline_hybrid_driver_zip(&zip_path, "kingbase", "0.1.34");

    let plan = inspect_offline_zip(&zip_path).unwrap();
    let result = import_agents_from_zip(&manager, &zip_path, |_| {}).await.unwrap();

    assert_eq!(plan.driver_keys, vec!["kingbase"]);
    assert_eq!(result.drivers_installed, vec!["kingbase"]);
    assert!(manager.driver_native_path("kingbase").exists());
    assert!(!manager.driver_jar_path("kingbase").exists());
}

#[tokio::test]
async fn offline_zip_import_progress_carries_real_db_type_not_label() {
    // Verify that the AgentProgressEvent.db_type field carries the real
    // database key (e.g. "kingbase") rather than the display label
    // (e.g. "KingbaseES"), so the frontend per-driver progress routing
    // matches.
    let manager = test_manager("offline-progress-db-type");
    let zip_path = test_path("offline-progress-db-type-zip").join("kingbase.zip");
    std::fs::create_dir_all(zip_path.parent().unwrap()).unwrap();
    write_offline_native_driver_zip(&zip_path, "kingbase", "0.1.34");
    let events = std::sync::Mutex::new(Vec::new());

    import_agents_from_zip(&manager, &zip_path, |event| {
        events.lock().unwrap().push(event);
    })
    .await
    .unwrap();

    let events = events.lock().unwrap();
    let driver_events: Vec<_> = events.iter().filter(|e| e.step == "driver").collect();
    assert!(!driver_events.is_empty(), "expected at least one driver progress event");
    for event in &driver_events {
        assert_eq!(
            event.db_type.as_deref(),
            Some("kingbase"),
            "db_type must be the real key 'kingbase', not the display label"
        );
    }
}

fn write_offline_driver_zip(path: &std::path::Path, db_type: &str, version: &str) {
    write_offline_driver_zip_with_jar(path, db_type, version, test_agent_jar_bytes());
}

fn write_offline_native_driver_zip(path: &std::path::Path, db_type: &str, version: &str) {
    write_offline_native_driver_zip_for_platform(path, db_type, version, AgentManager::current_platform());
}

fn write_offline_tar_zstd_driver_package(path: &std::path::Path, db_type: &str, version: &str) {
    let native = current_platform_native_binary();
    let platform = AgentManager::current_platform();
    let extension = if platform.starts_with("windows-") { ".exe" } else { "" };
    let filename = format!("dbx-agent-{db_type}-{version}-{platform}{extension}");
    let registry = serde_json::json!({
        "jres": {},
        "drivers": {
            db_type: {
                "version": version,
                "label": db_type,
                "min_app_version": "0.6.0",
                "jre": DEFAULT_JRE_KEY,
                "native": {
                    platform: {
                        "url": filename,
                        "size": native.len()
                    }
                }
            }
        }
    });
    let registry_bytes = registry.to_string().into_bytes();
    let file = std::fs::File::create(path).unwrap();
    let encoder = zstd::stream::write::Encoder::new(file, 3).unwrap();
    let mut archive = tar::Builder::new(encoder);

    let mut registry_header = tar::Header::new_gnu();
    registry_header.set_size(registry_bytes.len() as u64);
    registry_header.set_mode(0o644);
    registry_header.set_cksum();
    archive.append_data(&mut registry_header, "agent-registry.json", registry_bytes.as_slice()).unwrap();

    let mut driver_header = tar::Header::new_gnu();
    driver_header.set_size(native.len() as u64);
    driver_header.set_mode(0o755);
    driver_header.set_cksum();
    archive.append_data(&mut driver_header, format!("drivers/{filename}"), native.as_slice()).unwrap();

    archive.into_inner().unwrap().finish().unwrap();
}

fn write_offline_tar_zstd_java_driver_package(path: &std::path::Path, db_type: &str, version: &str) {
    let jar = test_agent_jar_bytes();
    let filename = format!("dbx-agent-{db_type}-{version}.jar");
    let registry = serde_json::json!({
        "jres": {},
        "drivers": {
            db_type: {
                "version": version,
                "label": db_type,
                "min_app_version": "0.6.0",
                "jre": DEFAULT_JRE_KEY,
                "jar": {
                    "url": filename,
                    "size": jar.len()
                }
            }
        }
    });
    let registry_bytes = registry.to_string().into_bytes();
    let file = std::fs::File::create(path).unwrap();
    let encoder = zstd::stream::write::Encoder::new(file, 3).unwrap();
    let mut archive = tar::Builder::new(encoder);

    let mut registry_header = tar::Header::new_gnu();
    registry_header.set_size(registry_bytes.len() as u64);
    registry_header.set_mode(0o644);
    registry_header.set_cksum();
    archive.append_data(&mut registry_header, "agent-registry.json", registry_bytes.as_slice()).unwrap();

    let mut driver_header = tar::Header::new_gnu();
    driver_header.set_size(jar.len() as u64);
    driver_header.set_mode(0o644);
    driver_header.set_cksum();
    archive.append_data(&mut driver_header, format!("drivers/{filename}"), jar.as_slice()).unwrap();

    archive.into_inner().unwrap().finish().unwrap();
}

fn write_offline_native_driver_zip_for_platform(path: &std::path::Path, db_type: &str, version: &str, platform: &str) {
    write_offline_native_driver_zip_with_bytes(path, db_type, version, platform, current_platform_native_binary());
}

fn write_offline_native_driver_zip_with_bytes(
    path: &std::path::Path,
    db_type: &str,
    version: &str,
    platform: &str,
    native: Vec<u8>,
) {
    let file = std::fs::File::create(path).unwrap();
    let mut zip = zip::ZipWriter::new(file);
    let options = zip::write::SimpleFileOptions::default().compression_method(zip::CompressionMethod::Stored);
    let extension = if platform.starts_with("windows-") { ".exe" } else { "" };
    let filename = format!("dbx-agent-{db_type}-{version}-{platform}{extension}");
    let registry = serde_json::json!({
        "jres": {},
        "drivers": {
            db_type: {
                "version": version,
                "label": db_type,
                "min_app_version": "0.6.0",
                "jre": DEFAULT_JRE_KEY,
                "native": {
                    platform: {
                        "url": format!("https://example.com/{filename}"),
                        "size": native.len()
                    }
                }
            }
        }
    });

    zip.start_file("agent-registry.json", options).unwrap();
    std::io::Write::write_all(&mut zip, registry.to_string().as_bytes()).unwrap();
    zip.start_file(format!("drivers/{filename}"), options).unwrap();
    std::io::Write::write_all(&mut zip, &native).unwrap();
    zip.finish().unwrap();
}

fn write_offline_hybrid_driver_zip(path: &std::path::Path, db_type: &str, version: &str) {
    let file = std::fs::File::create(path).unwrap();
    let mut zip = zip::ZipWriter::new(file);
    let options = zip::write::SimpleFileOptions::default().compression_method(zip::CompressionMethod::Stored);
    let jar = test_agent_jar_bytes();
    let native = current_platform_native_binary();
    let platform = AgentManager::current_platform();
    let extension = if platform.starts_with("windows-") { ".exe" } else { "" };
    let jar_filename = format!("dbx-agent-{db_type}-{version}.jar");
    let native_filename = format!("dbx-agent-{db_type}-{version}-{platform}{extension}");
    let registry = serde_json::json!({
        "jres": {},
        "drivers": {
            db_type: {
                "version": version,
                "label": db_type,
                "min_app_version": "0.1.0",
                "jre": DEFAULT_JRE_KEY,
                "jar": { "url": format!("https://example.com/{jar_filename}"), "size": jar.len() },
                "native": {
                    platform: { "url": format!("https://example.com/{native_filename}"), "size": native.len() }
                }
            }
        }
    });

    zip.start_file("agent-registry.json", options).unwrap();
    std::io::Write::write_all(&mut zip, registry.to_string().as_bytes()).unwrap();
    zip.start_file(format!("drivers/{jar_filename}"), options).unwrap();
    std::io::Write::write_all(&mut zip, &jar).unwrap();
    zip.start_file(format!("drivers/{native_filename}"), options).unwrap();
    std::io::Write::write_all(&mut zip, &native).unwrap();
    zip.finish().unwrap();
}

fn write_offline_driver_zip_with_jre(path: &std::path::Path, db_type: &str, version: &str, jre_version: &str) {
    write_offline_driver_zip_with_jre_bytes(path, db_type, version, jre_version, test_jre_archive_bytes());
}

fn write_offline_driver_zip_with_zstd_jre(path: &std::path::Path, db_type: &str, version: &str, jre_version: &str) {
    let file = std::fs::File::create(path).unwrap();
    let mut zip = zip::ZipWriter::new(file);
    let options = zip::write::SimpleFileOptions::default().compression_method(zip::CompressionMethod::Stored);
    let jar = test_agent_jar_bytes();
    let jre_archive = test_jre_archive_zstd_bytes();
    let platform = AgentManager::current_platform();
    let registry = serde_json::json!({
        "jres": {
            DEFAULT_JRE_KEY: {
                "version": jre_version,
                "platforms": {
                    platform: {
                        "url": format!("https://example.com/dbx-jre-{DEFAULT_JRE_KEY}-{platform}.tar.zst"),
                        "size": jre_archive.len(),
                        "format": "tar_zstd"
                    }
                }
            }
        },
        "drivers": {
            db_type: {
                "version": version,
                "label": db_type,
                "min_app_version": "0.1.0",
                "jre": DEFAULT_JRE_KEY,
                "jar": { "url": format!("https://example.com/dbx-agent-{db_type}-{version}.jar"), "size": jar.len() }
            }
        }
    });

    zip.start_file("agent-registry.json", options).unwrap();
    std::io::Write::write_all(&mut zip, registry.to_string().as_bytes()).unwrap();
    zip.start_file(format!("jre/dbx-jre-{DEFAULT_JRE_KEY}-{platform}.tar.zst"), options).unwrap();
    std::io::Write::write_all(&mut zip, &jre_archive).unwrap();
    zip.start_file(format!("drivers/dbx-agent-{db_type}-{version}.jar"), options).unwrap();
    std::io::Write::write_all(&mut zip, &jar).unwrap();
    zip.finish().unwrap();
}

fn write_offline_driver_zip_with_jre_bytes(
    path: &std::path::Path,
    db_type: &str,
    version: &str,
    jre_version: &str,
    jre_archive: Vec<u8>,
) {
    write_offline_driver_zip_with_jre_and_jar_bytes(
        path,
        db_type,
        version,
        jre_version,
        jre_archive,
        test_agent_jar_bytes(),
    );
}

fn write_offline_driver_zip_with_jre_and_jar_bytes(
    path: &std::path::Path,
    db_type: &str,
    version: &str,
    jre_version: &str,
    jre_archive: Vec<u8>,
    jar: Vec<u8>,
) {
    let file = std::fs::File::create(path).unwrap();
    let mut zip = zip::ZipWriter::new(file);
    let options = zip::write::SimpleFileOptions::default().compression_method(zip::CompressionMethod::Stored);
    let registry = serde_json::json!({
        "jres": {
            DEFAULT_JRE_KEY: {
                "version": jre_version,
                "platforms": {}
            }
        },
        "drivers": {
            db_type: {
                "version": version,
                "label": db_type,
                "min_app_version": "0.1.0",
                "jre": DEFAULT_JRE_KEY,
                "jar": { "url": format!("https://example.com/dbx-agent-{db_type}-{version}.jar"), "size": jar.len() }
            }
        }
    });

    zip.start_file("agent-registry.json", options).unwrap();
    std::io::Write::write_all(&mut zip, registry.to_string().as_bytes()).unwrap();
    zip.start_file(format!("jre/dbx-jre-{DEFAULT_JRE_KEY}-{}.tar.gz", AgentManager::current_platform()), options)
        .unwrap();
    std::io::Write::write_all(&mut zip, &jre_archive).unwrap();
    zip.start_file(format!("drivers/dbx-agent-{db_type}-{version}.jar"), options).unwrap();
    std::io::Write::write_all(&mut zip, &jar).unwrap();
    zip.finish().unwrap();
}

fn test_jre_archive_bytes() -> Vec<u8> {
    let root = test_path("jre-archive");
    let runtime_root = root.join("dbx-jre");
    let bin_dir = runtime_root.join("bin");
    std::fs::create_dir_all(&bin_dir).unwrap();
    std::fs::write(bin_dir.join("java"), b"java").unwrap();
    std::fs::write(bin_dir.join("java.exe"), b"java").unwrap();

    let encoder = flate2::write::GzEncoder::new(Vec::new(), flate2::Compression::default());
    let mut builder = tar::Builder::new(encoder);
    builder.append_dir_all("dbx-jre", &runtime_root).unwrap();
    let bytes = builder.into_inner().unwrap().finish().unwrap();
    std::fs::remove_dir_all(root).ok();
    bytes
}

fn test_jre_archive_zstd_bytes() -> Vec<u8> {
    let root = test_path("jre-zstd-archive");
    let runtime_root = root.join("dbx-jre");
    let bin_dir = runtime_root.join("bin");
    std::fs::create_dir_all(&bin_dir).unwrap();
    std::fs::write(bin_dir.join("java"), b"java").unwrap();
    std::fs::write(bin_dir.join("java.exe"), b"java").unwrap();

    let encoder = zstd::stream::write::Encoder::new(Vec::new(), 3).unwrap();
    let mut builder = tar::Builder::new(encoder);
    builder.append_dir_all("dbx-jre", &runtime_root).unwrap();
    let bytes = builder.into_inner().unwrap().finish().unwrap();
    std::fs::remove_dir_all(root).ok();
    bytes
}

fn write_offline_driver_zip_with_jar(path: &std::path::Path, db_type: &str, version: &str, jar: Vec<u8>) {
    write_offline_java_driver_zip(path, &[(db_type, version, &jar)]);
}

/// Build a package from `(db_type, version, jar bytes)` tuples so a single
/// package can mix working and broken drivers.
fn write_offline_java_driver_zip(path: &std::path::Path, drivers: &[(&str, &str, &[u8])]) {
    let file = std::fs::File::create(path).unwrap();
    let mut zip = zip::ZipWriter::new(file);
    let options = zip::write::SimpleFileOptions::default().compression_method(zip::CompressionMethod::Stored);
    let registry_drivers = drivers
        .iter()
        .map(|(db_type, version, jar)| {
            (
                (*db_type).to_string(),
                serde_json::json!({
                    "version": version,
                    "label": db_type,
                    "min_app_version": "0.1.0",
                    "jre": DEFAULT_JRE_KEY,
                    "jar": {
                        "url": format!("https://example.com/dbx-agent-{db_type}-{version}.jar"),
                        "size": jar.len()
                    }
                }),
            )
        })
        .collect::<serde_json::Map<String, serde_json::Value>>();
    let registry = serde_json::json!({ "drivers": registry_drivers });

    zip.start_file("agent-registry.json", options).unwrap();
    std::io::Write::write_all(&mut zip, registry.to_string().as_bytes()).unwrap();
    for (db_type, version, jar) in drivers {
        zip.start_file(format!("drivers/dbx-agent-{db_type}-{version}.jar"), options).unwrap();
        std::io::Write::write_all(&mut zip, jar).unwrap();
    }
    zip.finish().unwrap();
}

fn write_test_agent_jar(path: &std::path::Path) {
    std::fs::write(path, test_agent_jar_bytes()).unwrap();
}

#[test]
fn agent_jar_fixture_uses_a_fixed_entry_timestamp() {
    let bytes = test_agent_jar_bytes();
    let mut archive = zip::ZipArchive::new(std::io::Cursor::new(bytes)).unwrap();
    assert_eq!(archive.by_name("META-INF/MANIFEST.MF").unwrap().last_modified(), Some(zip::DateTime::default()));
}

fn test_agent_jar_bytes() -> Vec<u8> {
    let cursor = std::io::Cursor::new(Vec::new());
    let mut zip = zip::ZipWriter::new(cursor);
    let options = zip::write::SimpleFileOptions::default()
        .compression_method(zip::CompressionMethod::Stored)
        .last_modified_time(zip::DateTime::default());
    // The production validator rejects corrupt driver artifacts by requiring a real JAR manifest.
    zip.start_file("META-INF/MANIFEST.MF", options).unwrap();
    std::io::Write::write_all(&mut zip, b"Manifest-Version: 1.0\nMain-Class: com.dbx.agent.TestAgent\n\n").unwrap();
    zip.finish().unwrap().into_inner()
}

fn current_platform_native_binary() -> Vec<u8> {
    native_binary_for_arch(cfg!(target_arch = "aarch64"))
}

fn native_binary_for_arch(aarch64: bool) -> Vec<u8> {
    if cfg!(windows) {
        let mut bytes = vec![0_u8; 0x48];
        bytes[..2].copy_from_slice(b"MZ");
        bytes[0x3c..0x40].copy_from_slice(&(0x40_u32).to_le_bytes());
        bytes[0x40..0x44].copy_from_slice(b"PE\0\0");
        let machine = if aarch64 { 0xaa64_u16 } else { 0x8664_u16 };
        bytes[0x44..0x46].copy_from_slice(&machine.to_le_bytes());
        bytes
    } else if cfg!(target_os = "linux") {
        let mut bytes = vec![0_u8; 20];
        bytes[..4].copy_from_slice(b"\x7fELF");
        bytes[4] = 2;
        bytes[5] = 1;
        let machine = if aarch64 { 183_u16 } else { 62_u16 };
        bytes[18..20].copy_from_slice(&machine.to_le_bytes());
        bytes
    } else if cfg!(target_os = "macos") {
        let mut bytes = vec![0xcf, 0xfa, 0xed, 0xfe];
        let cpu_type = if aarch64 { 0x0100_000c_u32 } else { 0x0100_0007_u32 };
        bytes.extend_from_slice(&cpu_type.to_le_bytes());
        bytes
    } else {
        Vec::new()
    }
}