25 MB lightweight cross-platform database client for 100+ databases, including MySQL, PostgreSQL, SQLite, Redis, MongoDB, DuckDB, SQL Server, and Dameng. Built-in AI, MCP Server, CLI, desktop and Docker. | 轻量级跨平台数据库管理工具,支持 MySQL、PostgreSQL、SQLite、Redis、MongoDB、达梦等 100+ 数据库,提供桌面端、Docker、CLI、内置 AI 助手和 MCP。
TypeScript aicliclickhousedatabasedatabase-clientdatabase-managementdockerguimcpmongodbmysqlpostgresqlredisrustsql-serversqlitetaurivue
fix(sqlserver): drop default constraint before dropping a column
Jeff05a57cbfde64
diff --git a/crates/dbx-sql-schema/src/table_structure_sql/column_alter.rs b/crates/dbx-sql-schema/src/table_structure_sql/column_alter.rsindex fe2f8a5a6f..e42f0a3124 100644--- a/crates/dbx-sql-schema/src/table_structure_sql/column_alter.rs+++ b/crates/dbx-sql-schema/src/table_structure_sql/column_alter.rs@@ -45,7 +45,7 @@ pub fn build_single_column_alter_sql(options: SingleColumnAlterSqlOptions) -> Tawarnings.push("Manticore Search id column cannot be dropped from this editor.".to_string());return TableStructureSqlResult { statements, warnings };}- statements.push(build_drop_column_sql(dialect, &table, &original.name));+ statements.extend(build_drop_column_sql(dialect, &table, original));return TableStructureSqlResult { statements, warnings };}diff --git a/crates/dbx-sql-schema/src/table_structure_sql/columns.rs b/crates/dbx-sql-schema/src/table_structure_sql/columns.rsindex e8390d21a0..00d1860827 100644--- a/crates/dbx-sql-schema/src/table_structure_sql/columns.rs+++ b/crates/dbx-sql-schema/src/table_structure_sql/columns.rs@@ -6,8 +6,9 @@ use super::column_alter::{build_h2_existing_column_sql, build_informix_existing_column_sql, build_iris_existing_column_sql,build_mysql_existing_column_clause, build_oracle_like_existing_column_sql, build_oscar_existing_column_sql,build_postgres_existing_column_sql, build_questdb_existing_column_sql, build_sqlite_existing_column_sql,- build_sqlserver_existing_column_sql, build_xugu_existing_column_sql, dameng_drops_identity,- has_column_extra_change, has_existing_column_attribute_change, validate_dameng_existing_identity_change,+ build_sqlserver_drop_default_constraint_sql, build_sqlserver_existing_column_sql, build_xugu_existing_column_sql,+ dameng_drops_identity, has_column_extra_change, has_existing_column_attribute_change,+ validate_dameng_existing_identity_change,};use super::column_format::{column_definition, has_dameng_identity, is_dameng_identity_compatible_type, is_mysql_character_data_type,@@ -16,7 +17,7 @@ use super::column_format::{use super::comments::build_sqlserver_column_comment_sql_for_profile;use super::dialect::{capabilities_for, database_label, is_oracle_like, StructureDialect};use super::indexes::has_existing_index_change;-use super::types::{EditableStructureColumn, TableStructureSqlOptions};+use super::types::{ColumnInfo, EditableStructureColumn, TableStructureSqlOptions};use super::util::{clean, is_protected_manticore_id_column, normalize_default, original_comment, original_default, qualified_table,quote_ident, quote_string,@@ -112,7 +113,7 @@ pub(super) fn build_column_sql(options: &TableStructureSqlOptions, warnings: &muwarnings.push("Manticore Search id column cannot be dropped from this editor.".to_string());continue;}- statements.push(build_drop_column_sql(dialect, &table, &original.name));+ statements.extend(build_drop_column_sql(dialect, &table, original));continue;}@@ -657,11 +658,18 @@ pub(super) fn build_add_column_sql(statements}-pub(super) fn build_drop_column_sql(dialect: StructureDialect, table: &str, column_name: &str) -> String {+pub(super) fn build_drop_column_sql(dialect: StructureDialect, table: &str, original: &ColumnInfo) -> Vec<String> {+ let column_name = &original.name;if dialect == StructureDialect::Informix {- return format!("ALTER TABLE {table} DROP ({});", quote_ident(dialect, column_name));+ return vec![format!("ALTER TABLE {table} DROP ({});", quote_ident(dialect, column_name))];}- format!("ALTER TABLE {table} DROP COLUMN {};", quote_ident(dialect, column_name))+ let mut statements = Vec::new();+ // SQL Server refuses to drop a column that a default constraint still depends on (error 5074).+ if dialect == StructureDialect::SqlServer && !normalize_default(original.column_default.as_ref()).is_empty() {+ statements.push(build_sqlserver_drop_default_constraint_sql(table, column_name));+ }+ statements.push(format!("ALTER TABLE {table} DROP COLUMN {};", quote_ident(dialect, column_name)));+ statements}pub(super) fn column_position_clause(diff --git a/crates/dbx-sql-schema/src/table_structure_sql/tests.rs b/crates/dbx-sql-schema/src/table_structure_sql/tests.rsindex 9752cd7bb1..8bea751776 100644--- a/crates/dbx-sql-schema/src/table_structure_sql/tests.rs+++ b/crates/dbx-sql-schema/src/table_structure_sql/tests.rs@@ -5006,6 +5006,57 @@ fn sqlserver_uncheck_primary_key_and_drop_column_does_not_emit_drop_column() {assert!(result.warnings.iter().any(|w| w.contains("primary key") || w.contains("Primary key")));}+#[test]+fn sqlserver_drop_column_removes_default_constraint_first() {+ let cases = [+ (Some("dbo"), Some("((0))"), "[dbo].[orders]", true),+ (None, Some("((0))"), "[orders]", true),+ (Some("dbo"), Some("NULL"), "[dbo].[orders]", false),+ (Some("dbo"), None, "[dbo].[orders]", false),+ ];++ for (schema, column_default, table, drops_default) in cases {+ let mut big = column("big");+ big.data_type = "bigint".to_string();+ big.is_nullable = false;+ big.marked_for_drop = true;+ big.original = Some(ColumnInfo {+ name: "big".to_string(),+ data_type: "bigint".to_string(),+ is_nullable: false,+ column_default: column_default.map(str::to_string),+ ..Default::default()+ });++ let mut expected = Vec::new();+ if drops_default {+ let drop_default = build_sqlserver_drop_default_constraint_sql(table, "big");+ assert!(drop_default.contains(&format!("OBJECT_ID(N'{table}')")), "{drop_default}");+ expected.push(drop_default);+ }+ expected.push(format!("ALTER TABLE {table} DROP COLUMN [big];"));++ let batch = build_table_structure_change_sql(structure_change_options(+ DatabaseType::SqlServer,+ schema,+ "orders",+ vec![big.clone()],+ ));+ assert_eq!(batch.warnings, Vec::<String>::new());+ assert_eq!(batch.statements, expected, "schema {schema:?}, default {column_default:?}");++ let single = build_single_column_alter_sql(SingleColumnAlterSqlOptions {+ database_type: Some(DatabaseType::SqlServer),+ driver_profile: None,+ schema: schema.map(str::to_string),+ table_name: "orders".to_string(),+ column: big,+ });+ assert_eq!(single.warnings, Vec::<String>::new());+ assert_eq!(single.statements, expected, "schema {schema:?}, default {column_default:?}");+ }+}+#[test]fn dameng_set_not_null_before_add_primary_key() {// DM8: PK columns must be NOT NULL; DM auto-adds NOT NULL but clients still MODIFY first.