Skip to content

armgit / dbx

Public Imported from GitHub
0

25 MB lightweight cross-platform database client for 100+ databases, including MySQL, PostgreSQL, SQLite, Redis, MongoDB, DuckDB, SQL Server, and Dameng. Built-in AI, MCP Server, CLI, desktop and Docker. | 轻量级跨平台数据库管理工具,支持 MySQL、PostgreSQL、SQLite、Redis、MongoDB、达梦等 100+ 数据库,提供桌面端、Docker、CLI、内置 AI 助手和 MCP。

fix(zookeeper): drop unsupported sql query capability

t8y20b9ddff19c93
diff --git a/apps/desktop/src/lib/__tests__/database/databaseFeatureSupport.spec.ts b/apps/desktop/src/lib/__tests__/database/databaseFeatureSupport.spec.ts
index 0cb0df991a..5ac948ba2e 100644
--- a/apps/desktop/src/lib/__tests__/database/databaseFeatureSupport.spec.ts
+++ b/apps/desktop/src/lib/__tests__/database/databaseFeatureSupport.spec.ts
@@ -5,12 +5,15 @@ import { buildGetDatabaseCommentSql } from "@/lib/database/dbAdminSql";
import {
defaultAutoCommitForDbType,
isSchemaAware,
+ supportsConnectionQueryActions,
supportsConnectionScopedQueryExecution,
supportsConnectionDatabaseBrowser,
supportsDatabaseNameCompletion,
supportsDatabaseSchemaQualifier,
+ supportsDatabaseSearch,
supportsObjectBrowser,
supportsObjectBrowserTreeNode,
+ supportsQueryExecution,
supportsQueryTargetDatabaseListing,
supportsQueryEditorBlockComments,
supportsSqlInListPaste,
@@ -81,6 +84,32 @@ describe("connection-scoped query targets", () => {
});
});
+describe("connection query actions", () => {
+ it("keeps SQL query surfaces available for ordinary databases", () => {
+ expect(supportsConnectionQueryActions("mysql")).toBe(true);
+ expect(supportsConnectionQueryActions("postgres")).toBe(true);
+ expect(supportsConnectionQueryActions("redis")).toBe(true);
+ expect(supportsConnectionQueryActions(undefined)).toBe(true);
+ });
+
+ it("hides the sidebar new-query entry for specialized surfaces without a query engine", () => {
+ expect(supportsConnectionQueryActions("nacos")).toBe(false);
+ expect(supportsConnectionQueryActions("consul")).toBe(false);
+ expect(supportsConnectionQueryActions("hbase")).toBe(false);
+ expect(supportsConnectionQueryActions("zookeeper")).toBe(false);
+ });
+});
+
+describe("zookeeper query capabilities", () => {
+ it("does not advertise query execution or schema search for the kv-only agent", () => {
+ // The ZooKeeper agent exposes only kv_* operations: no list-databases or
+ // query method exists, so the manifest must not claim either capability
+ // (issue #8215: "new query" errored calling list-databases).
+ expect(supportsQueryExecution("zookeeper")).toBe(false);
+ expect(supportsDatabaseSearch("zookeeper")).toBe(false);
+ });
+});
+
describe("database and schema qualifiers", () => {
it.each(["sqlserver", "trino", "prestosql"] as const)("supports three-part object names for %s", (databaseType) => {
expect(supportsDatabaseSchemaQualifier(databaseType)).toBe(true);
diff --git a/apps/desktop/src/lib/database/databaseFeatureSupport.ts b/apps/desktop/src/lib/database/databaseFeatureSupport.ts
index 0a9ca61029..a4e1650c21 100644
--- a/apps/desktop/src/lib/database/databaseFeatureSupport.ts
+++ b/apps/desktop/src/lib/database/databaseFeatureSupport.ts
@@ -112,8 +112,14 @@ export function supportsClearableQuerySchema(dbType?: DatabaseType): boolean {
return !!dbType && CLEARABLE_QUERY_SCHEMA_TYPES.has(dbType);
}
+/**
+ * ZooKeeper has no query surface: its agent implements only kv_* operations,
+ * so the sidebar "new query" flow would call list-databases and fail
+ * (issue #8215). It is excluded alongside the other specialized surfaces
+ * (nacos, consul, hbase) whose connection workbench replaces query tabs.
+ */
export function supportsConnectionQueryActions(dbType?: DatabaseType): boolean {
- return dbType !== "nacos" && dbType !== "consul" && dbType !== "hbase";
+ return dbType !== "nacos" && dbType !== "consul" && dbType !== "hbase" && dbType !== "zookeeper";
}
/**
diff --git a/crates/dbx-core/assets/database-drivers.manifest.json b/crates/dbx-core/assets/database-drivers.manifest.json
index 0266831cf4..87b5454f94 100644
--- a/crates/dbx-core/assets/database-drivers.manifest.json
+++ b/crates/dbx-core/assets/database-drivers.manifest.json
@@ -2446,11 +2446,11 @@
"defaultPort": 2181,
"supportLevel": "connect",
"capabilities": {
- "queryExecution": true,
+ "queryExecution": false,
"metadataBrowse": false,
"objectBrowser": false,
"objectSource": false,
- "schemaSearch": true,
+ "schemaSearch": false,
"diagram": false,
"tableDataEdit": false,
"tableStructureEdit": false,
diff --git a/crates/dbx-core/tests/database_capabilities.rs b/crates/dbx-core/tests/database_capabilities.rs
index 45b05c190a..272bacac56 100644
--- a/crates/dbx-core/tests/database_capabilities.rs
+++ b/crates/dbx-core/tests/database_capabilities.rs
@@ -336,7 +336,11 @@ fn driver_manifest_declares_expected_product_capabilities() {
assert_eq!(zookeeper.runtime_mode, "agent");
assert_eq!(zookeeper.agent_key.as_deref(), Some("zookeeper"));
assert_eq!(zookeeper.support_level, "connect");
- assert!(zookeeper.capabilities.query_execution);
+ // ZooKeeper has no SQL engine and its agent implements only kv_* operations;
+ // claiming query execution or schema search made "new query" call
+ // list-databases on an agent that does not support it (issue #8215).
+ assert!(!zookeeper.capabilities.query_execution);
+ assert!(!zookeeper.capabilities.schema_search);
assert!(zookeeper.capabilities.driver_management);
assert!(!zookeeper.capabilities.metadata_browse);
diff --git a/plugins/connection-types/zookeeper.yaml b/plugins/connection-types/zookeeper.yaml
index af4d347f93..71af844bd5 100644
--- a/plugins/connection-types/zookeeper.yaml
+++ b/plugins/connection-types/zookeeper.yaml
@@ -14,11 +14,15 @@ skipTcpProbe: true
defaultPort: 2181
supportLevel: connect
capabilities:
- queryExecution: true
+ # ZooKeeper has no SQL engine and its agent exposes only kv_* operations:
+ # no list_databases or query method exists, so query execution and schema
+ # search must stay off (issue #8215: "new query" errored calling
+ # list-databases on a ZooKeeper connection).
+ queryExecution: false
metadataBrowse: false
objectBrowser: false
objectSource: false
- schemaSearch: true
+ schemaSearch: false
diagram: false
tableDataEdit: false
tableStructureEdit: false