Skip to content

armgit / dbx

Public Imported from GitHub
0

25 MB lightweight cross-platform database client for 100+ databases, including MySQL, PostgreSQL, SQLite, Redis, MongoDB, DuckDB, SQL Server, and Dameng. Built-in AI, MCP Server, CLI, desktop and Docker. | 轻量级跨平台数据库管理工具,支持 MySQL、PostgreSQL、SQLite、Redis、MongoDB、达梦等 100+ 数据库,提供桌面端、Docker、CLI、内置 AI 助手和 MCP。

fix(oracle): reduce view query page round trips

t8y21663f3633f59
diff --git a/agents/drivers/oracle-go/main.go b/agents/drivers/oracle-go/main.go
index 4176f606c9..618fd17b36 100644
--- a/agents/drivers/oracle-go/main.go
+++ b/agents/drivers/oracle-go/main.go
@@ -30,7 +30,11 @@ import (
const protocolVersion = 1
const multiSessionProtocolVersion = 2
const defaultMaxRows = 1000
-const oracleDefaultPrefetchRows = "100"
+
+// A normal data-grid page contains 100 rows. Prefetching a little more than
+// one page reduces round trips while reading subsequent pages without
+// buffering the much larger export limit.
+const oracleDefaultPrefetchRows = "256"
const oracleCharsetZHS32GB18030 = 854
const legacyAgentSessionID = "__legacy__"
const maxAgentSessions = 256
@@ -3974,6 +3978,13 @@ func readQuerySessionPage(session *querySession, pageSize int) (result queryPage
result.Truncated = true
return result, nil
}
+ // A full page is enough evidence that another page may exist. Do not read
+ // one extra row just to decide has_more: with a prefetch boundary this
+ // forces another Oracle round trip before the first page can be displayed.
+ if len(result.Rows) >= pageSize {
+ result.HasMore = true
+ return result, nil
+ }
if session.rows.Next() {
row, err := scanRow(session.rows, len(session.columns), session.columnTypes)
if err != nil {
diff --git a/agents/drivers/oracle-go/main_test.go b/agents/drivers/oracle-go/main_test.go
index c3f3e1dcef..bb1275dcd8 100644
--- a/agents/drivers/oracle-go/main_test.go
+++ b/agents/drivers/oracle-go/main_test.go
@@ -1183,6 +1183,27 @@ func TestBuildDSNUsesStableDefaultPrefetchRows(t *testing.T) {
}
}
+func TestReadQuerySessionPageDoesNotLookAheadAfterFullPage(t *testing.T) {
+ db, _ := openOracleViewSourceTestDB(t, []oracleViewSourceQueryStep{{
+ queryContains: "SELECT * FROM TEST_VIEW",
+ args: []driver.Value{},
+ columns: []string{"ID"},
+ rows: [][]driver.Value{{int64(1)}, {int64(2)}},
+ }})
+ s := newServer()
+ s.db = db
+ result, err := s.executeQueryPage(queryOptions{SQL: "SELECT * FROM TEST_VIEW"}, 2)
+ if err != nil {
+ t.Fatal(err)
+ }
+ if len(result.Rows) != 2 || !result.HasMore || result.SessionID == nil {
+ t.Fatalf("full page should keep a lazy session without look-ahead: %+v", result)
+ }
+ if !s.closeQuerySession(*result.SessionID) {
+ t.Fatal("expected the query session to close")
+ }
+}
+
func TestBuildDSNPreservesConfiguredPrefetchRows(t *testing.T) {
tests := []connectParams{
{