Skip to content

armgit / dbx

Public Imported from GitHub
0

25 MB lightweight cross-platform database client for 100+ databases, including MySQL, PostgreSQL, SQLite, Redis, MongoDB, DuckDB, SQL Server, and Dameng. Built-in AI, MCP Server, CLI, desktop and Docker. | 轻量级跨平台数据库管理工具,支持 MySQL、PostgreSQL、SQLite、Redis、MongoDB、达梦等 100+ 数据库,提供桌面端、Docker、CLI、内置 AI 助手和 MCP。

feat(hana): enable table data import

t8y237dbaaf730f2
diff --git a/apps/desktop/src/lib/__tests__/database/databaseFeatureSupport.spec.ts b/apps/desktop/src/lib/__tests__/database/databaseFeatureSupport.spec.ts
index cfff383373..f7a5d0289c 100644
--- a/apps/desktop/src/lib/__tests__/database/databaseFeatureSupport.spec.ts
+++ b/apps/desktop/src/lib/__tests__/database/databaseFeatureSupport.spec.ts
@@ -364,6 +364,10 @@ describe("supportsTableImport", () => {
it("enables openGauss table import", () => {
expect(supportsTableImport("opengauss")).toBe(true);
});
+
+ it("enables SAP HANA table import", () => {
+ expect(supportsTableImport("saphana")).toBe(true);
+ });
});
describe("supportsFieldLineage", () => {
diff --git a/crates/dbx-core/assets/database-drivers.manifest.json b/crates/dbx-core/assets/database-drivers.manifest.json
index f7f993ff45..390d2c8ea7 100644
--- a/crates/dbx-core/assets/database-drivers.manifest.json
+++ b/crates/dbx-core/assets/database-drivers.manifest.json
@@ -1469,7 +1469,7 @@
"diagram": true,
"tableDataEdit": true,
"tableStructureEdit": true,
- "tableImport": false,
+ "tableImport": true,
"dataTransfer": false,
"sqlFileExecution": true,
"databaseCreate": false,
diff --git a/crates/dbx-core/src/data/table_import.rs b/crates/dbx-core/src/data/table_import.rs
index 5e4ae28dab..0d6ab17e41 100644
--- a/crates/dbx-core/src/data/table_import.rs
+++ b/crates/dbx-core/src/data/table_import.rs
@@ -5203,6 +5203,7 @@ fn effective_import_batch_size(db_type: &DatabaseType, requested: usize) -> usiz
let max_rows = match db_type {
DatabaseType::Oracle | DatabaseType::OceanbaseOracle => MAX_ORACLE_IMPORT_BATCH_ROWS,
DatabaseType::Iris => 1,
+ DatabaseType::SapHana => 1,
DatabaseType::CloudflareD1 | DatabaseType::Transwarp => 100,
DatabaseType::SqlServer => 1000,
DatabaseType::Sqlite => SQLITE_APPEND_COMMIT_ROWS,
@@ -5521,6 +5522,7 @@ fn infer_column_type(rows: &[Vec<serde_json::Value>], source_index: usize) -> Im
fn text_data_type(db_type: &DatabaseType) -> &'static str {
match db_type {
DatabaseType::SqlServer => "NVARCHAR(MAX)",
+ DatabaseType::SapHana => "NCLOB",
DatabaseType::Oracle | DatabaseType::OceanbaseOracle | DatabaseType::Dameng | DatabaseType::Db2 => "CLOB",
DatabaseType::ClickHouse => "String",
DatabaseType::Hive
@@ -12945,6 +12947,30 @@ mod tests {
assert_eq!(plan.sql, "CREATE TABLE [dbo].[events] (\n [notes] NVARCHAR(MAX)\n)");
}
+ #[test]
+ fn hana_create_table_plan_uses_nclob_for_inferred_text() {
+ let data = ParsedImportFile {
+ columns: vec!["id".to_string(), "notes".to_string()],
+ rows: vec![vec![serde_json::json!(1), serde_json::json!("long text")]],
+ total_rows: 1,
+ effective_encoding: None,
+ };
+ let mappings = data
+ .columns
+ .iter()
+ .map(|column| TableImportColumnMapping {
+ source_column: column.clone(),
+ target_column: column.clone(),
+ target_data_type: None,
+ generator: None,
+ })
+ .collect::<Vec<_>>();
+
+ let plan = build_import_create_table_plan(&data, &mappings, "events", "RACE", &DatabaseType::SapHana).unwrap();
+
+ assert_eq!(plan.sql, "CREATE TABLE \"RACE\".\"events\" (\n \"id\" BIGINT,\n \"notes\" NCLOB\n)");
+ }
+
#[test]
fn db2_create_table_plan_uses_clob_for_inferred_text() {
let data = ParsedImportFile {
@@ -13252,6 +13278,58 @@ mod tests {
]);
}
+ #[test]
+ fn hana_import_uses_schema_qualified_single_row_insert() {
+ let mappings = vec![
+ TableImportColumnMapping {
+ source_column: "id".to_string(),
+ target_column: "ID".to_string(),
+ target_data_type: None,
+ generator: None,
+ },
+ TableImportColumnMapping {
+ source_column: "name".to_string(),
+ target_column: "NAME".to_string(),
+ target_data_type: None,
+ generator: None,
+ },
+ ];
+ let data = ParsedImportFile {
+ columns: vec!["id".to_string(), "name".to_string()],
+ rows: vec![
+ vec![serde_json::json!(1), serde_json::json!("Ada")],
+ vec![serde_json::json!(2), serde_json::json!("Grace")],
+ ],
+ total_rows: 2,
+ effective_encoding: None,
+ };
+
+ let batches = build_import_insert_batches(
+ &data,
+ &mappings,
+ &[("ID".to_string(), "BIGINT".to_string()), ("NAME".to_string(), "NCLOB".to_string())],
+ "USERS",
+ "RACE",
+ &DatabaseType::SapHana,
+ 500,
+ )
+ .unwrap();
+
+ assert_eq!(
+ batches,
+ vec![
+ ImportSqlBatch {
+ sql: "INSERT INTO \"RACE\".\"USERS\" (\"ID\", \"NAME\") VALUES\n(1, 'Ada')".to_string(),
+ row_count: 1,
+ },
+ ImportSqlBatch {
+ sql: "INSERT INTO \"RACE\".\"USERS\" (\"ID\", \"NAME\") VALUES\n(2, 'Grace')".to_string(),
+ row_count: 1,
+ },
+ ]
+ );
+ }
+
#[test]
fn db2_import_uses_schema_qualified_multi_row_insert() {
let mappings = vec![
@@ -13531,6 +13609,7 @@ mod tests {
assert_eq!(effective_import_batch_size(&DatabaseType::OceanbaseOracle, 1000), 500);
assert_eq!(effective_import_batch_size(&DatabaseType::OceanbaseOracle, 1), 1);
assert_eq!(effective_import_batch_size(&DatabaseType::Iris, 1000), 1);
+ assert_eq!(effective_import_batch_size(&DatabaseType::SapHana, 1000), 1);
assert_eq!(effective_import_batch_size(&DatabaseType::CloudflareD1, 1000), 100);
assert_eq!(effective_import_batch_size(&DatabaseType::SqlServer, 1001), 1000);
assert_eq!(effective_import_batch_size(&DatabaseType::Postgres, 1000), 1000);
diff --git a/crates/dbx-core/tests/database_capabilities.rs b/crates/dbx-core/tests/database_capabilities.rs
index b295eb8197..3db2fb04cb 100644
--- a/crates/dbx-core/tests/database_capabilities.rs
+++ b/crates/dbx-core/tests/database_capabilities.rs
@@ -560,3 +560,18 @@ fn opengauss_declares_table_import_support() {
assert!(opengauss.capabilities.sql_file_execution);
assert!(opengauss.capabilities.data_transfer);
}
+
+#[test]
+fn saphana_declares_table_import_support() {
+ let manifest = driver_manifest();
+ let hana = manifest
+ .drivers
+ .iter()
+ .find(|driver| driver.db_type == DatabaseType::SapHana)
+ .expect("SAP HANA manifest entry");
+
+ assert!(hana.capabilities.table_import);
+ // Import into an existing table needs table editing and SQL execution.
+ assert!(hana.capabilities.table_data_edit);
+ assert!(hana.capabilities.sql_file_execution);
+}
diff --git a/plugins/connection-types/saphana.yaml b/plugins/connection-types/saphana.yaml
index 86e13ff56c..139a3f44f7 100644
--- a/plugins/connection-types/saphana.yaml
+++ b/plugins/connection-types/saphana.yaml
@@ -26,7 +26,7 @@ capabilities:
diagram: true
tableDataEdit: true
tableStructureEdit: true
- tableImport: false
+ tableImport: true
dataTransfer: false
sqlFileExecution: true
databaseCreate: false