Skip to content

armgit / dbx

Public Imported from GitHub
0

25 MB lightweight cross-platform database client for 100+ databases, including MySQL, PostgreSQL, SQLite, Redis, MongoDB, DuckDB, SQL Server, and Dameng. Built-in AI, MCP Server, CLI, desktop and Docker. | 轻量级跨平台数据库管理工具,支持 MySQL、PostgreSQL、SQLite、Redis、MongoDB、达梦等 100+ 数据库,提供桌面端、Docker、CLI、内置 AI 助手和 MCP。

fix(duckdb): save grid batch edits without a transaction

lxk9553ef9639dbff1
diff --git a/apps/desktop/src/composables/__tests__/useDataGridEditor.spec.ts b/apps/desktop/src/composables/__tests__/useDataGridEditor.spec.ts
index 6987f6ecac..7e6a9e5678 100644
--- a/apps/desktop/src/composables/__tests__/useDataGridEditor.spec.ts
+++ b/apps/desktop/src/composables/__tests__/useDataGridEditor.spec.ts
@@ -1725,6 +1725,23 @@ describe("useDataGridEditor saveChanges reload", () => {
expect(mocks.prepareDataGridSave.mock.calls[1]![0].dirtyRows).toEqual([[0, [[3, "new title"]]]]);
});
+ it("routes multi-statement edits through executeBatch for non-transactional DuckDB (#12306)", async () => {
+ mocks.prepareDataGridSave.mockResolvedValue({
+ statements: ["UPDATE users SET name='alpha' WHERE id=1", "UPDATE users SET name='beta' WHERE id=2"],
+ rollbackStatements: [],
+ });
+ mocks.executeBatch.mockResolvedValue({ affected_rows: 2 });
+ const { editor } = createSaveTestEditor({ databaseType: "duckdb" });
+ expect(editor.useTransaction.value).toBe(false);
+ editor.dirtyRows.value.set(0, new Map([[1, "alpha"]]));
+ editor.dirtyRows.value.set(1, new Map([[1, "beta"]]));
+ await editor.saveChanges();
+ expect(mocks.executeInTransaction).not.toHaveBeenCalled();
+ expect(mocks.executeBatch).toHaveBeenCalledTimes(1);
+ expect(mocks.executeBatch).toHaveBeenCalledWith("connection-1", "app", ["UPDATE users SET name='alpha' WHERE id=1", "UPDATE users SET name='beta' WHERE id=2"], undefined);
+ expect(editor.saveError.value).toBe("");
+ });
+
it("keeps both joined edits pending if the transaction fails", async () => {
const targets = [
{ tableMeta: { tableName: "users", primaryKeys: ["id"], columns: [] }, sourceColumns: ["id", "name", undefined, undefined] },
diff --git a/apps/desktop/src/lib/__tests__/table/tableEditing.spec.ts b/apps/desktop/src/lib/__tests__/table/tableEditing.spec.ts
index 92dd3a5a77..629263f820 100644
--- a/apps/desktop/src/lib/__tests__/table/tableEditing.spec.ts
+++ b/apps/desktop/src/lib/__tests__/table/tableEditing.spec.ts
@@ -263,4 +263,14 @@ describe("tableEditing", () => {
expect(supportsDataGridTransaction("iris")).toBe(true);
expect(canUseKeylessRowPredicate("iris", [])).toBe(true);
});
+
+ it("edits DuckDB table data row by row without a transaction (#12306)", () => {
+ expect(isTableDataEditable("duckdb", ["id"], "TABLE")).toBe(true);
+ expect(isTableDataEditable("duckdb", [], "TABLE")).toBe(true);
+ expect(isTableDataEditable("duckdb", ["id"], "VIEW")).toBe(false);
+ expect(canInsertTableRows("duckdb")).toBe(true);
+ expect(canEditExistingTableRows("duckdb")).toBe(true);
+ expect(supportsDataGridTransaction("duckdb")).toBe(false);
+ expect(canUseKeylessRowPredicate("duckdb", [])).toBe(true);
+ });
});
diff --git a/apps/desktop/src/lib/database/databaseTableDataCapabilities.ts b/apps/desktop/src/lib/database/databaseTableDataCapabilities.ts
index 94f911584c..8dc8030b6a 100644
--- a/apps/desktop/src/lib/database/databaseTableDataCapabilities.ts
+++ b/apps/desktop/src/lib/database/databaseTableDataCapabilities.ts
@@ -92,6 +92,16 @@ const NAVICAT_STYLE_TABLE_DATA_TYPES = new Set<DatabaseType>([
]);
const DATABASE_CAPABILITY_OVERRIDES: Partial<Record<DatabaseType, Partial<DatabaseCapability>>> = {
+ duckdb: {
+ tableData: {
+ insert: true,
+ updateRequiresPrimaryKey: false,
+ deleteRequiresPrimaryKey: false,
+ keylessRowPredicate: true,
+ requiresTransactionalTableForExistingRows: false,
+ transaction: false,
+ },
+ },
kyuubi: {
tableData: {
insert: false,