Skip to content

armgit / dbx

Public Imported from GitHub
0

25 MB lightweight cross-platform database client for 100+ databases, including MySQL, PostgreSQL, SQLite, Redis, MongoDB, DuckDB, SQL Server, and Dameng. Built-in AI, MCP Server, CLI, desktop and Docker. | 轻量级跨平台数据库管理工具,支持 MySQL、PostgreSQL、SQLite、Redis、MongoDB、达梦等 100+ 数据库,提供桌面端、Docker、CLI、内置 AI 助手和 MCP。

test(oceanbase-oracle): cover cursor final-page audit row limits

efeire510fac6665b1
diff --git a/agents/drivers/oceanbase-oracle/src/main/java/com/dbx/agent/oceanbaseoracle/OceanBaseOracleAgent.java b/agents/drivers/oceanbase-oracle/src/main/java/com/dbx/agent/oceanbaseoracle/OceanBaseOracleAgent.java
index 08b090cd0d..055fa56556 100644
--- a/agents/drivers/oceanbase-oracle/src/main/java/com/dbx/agent/oceanbaseoracle/OceanBaseOracleAgent.java
+++ b/agents/drivers/oceanbase-oracle/src/main/java/com/dbx/agent/oceanbaseoracle/OceanBaseOracleAgent.java
@@ -123,6 +123,9 @@ public final class OceanBaseOracleAgent extends ConfiguredJdbcAgent {
private QueryPageResult withCompletedCursorServerTiming(QueryPageResult result) {
// JdbcExecutor closes the ResultSet and Statement before returning a terminal
// page. Never issue audit SQL while Connector/J still owns an open cursor.
+ // executePage limits rows while reading, without Statement.setMaxRows.
+ // Preserve its JDBC default of 0 here; QueryPageOptions.maxRows is a
+ // client-side cap, not the statement limit used by Connector/J.
if (!result.getHas_more() && !result.getTruncated() && !result.getColumns().isEmpty()) {
result.setServer_execute_time_us(availableServerExecuteTimeUs(result.getCursor_rows_read(), 0));
}
diff --git a/agents/drivers/oceanbase-oracle/src/test/java/com/dbx/agent/oceanbaseoracle/OceanBaseOracleAgentTest.java b/agents/drivers/oceanbase-oracle/src/test/java/com/dbx/agent/oceanbaseoracle/OceanBaseOracleAgentTest.java
index 9eaed4693e..69c5abc163 100644
--- a/agents/drivers/oceanbase-oracle/src/test/java/com/dbx/agent/oceanbaseoracle/OceanBaseOracleAgentTest.java
+++ b/agents/drivers/oceanbase-oracle/src/test/java/com/dbx/agent/oceanbaseoracle/OceanBaseOracleAgentTest.java
@@ -14,6 +14,8 @@ import com.dbx.agent.TableInfo;
import com.dbx.agent.test.TestSupport;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.CsvSource;
import java.lang.reflect.InvocationHandler;
import java.lang.reflect.Method;
@@ -154,6 +156,69 @@ class OceanBaseOracleAgentTest {
}
+ @ParameterizedTest
+ @CsvSource({"10, 1000, false", "1, 1000, false", "1, 1, true", "2, 2, false"})
+ void preservesTheCursorStatementLimitWhenSamplingItsTerminalPage(int pageSize, int maxRows, boolean truncated) {
+ List<Integer> auditLimits = new ArrayList<>();
+ List<String> auditSql = new ArrayList<>();
+ Connection auditConnection = auditTimingConnection(1, 2, false, auditSql, new ArrayList<>(), auditLimits);
+ int[] row = {-1};
+ int[] queryLimit = {0}; // JDBC's default, independent of the client-side cap.
+ boolean[] queryStarted = {false};
+ boolean[] resultClosed = {false};
+ boolean[] statementClosed = {false};
+ ResultSetMetaData meta = proxy(ResultSetMetaData.class, (method, args) -> {
+ if ("getColumnCount".equals(method.getName())) return 1;
+ if ("getColumnLabel".equals(method.getName())) return "N";
+ if ("getColumnType".equals(method.getName())) return Types.INTEGER;
+ if ("getColumnTypeName".equals(method.getName())) return "NUMBER";
+ return defaultValue(method.getReturnType());
+ });
+ ResultSet cursor = proxy(ResultSet.class, (method, args) -> {
+ if ("next".equals(method.getName())) return ++row[0] < 2;
+ if ("getMetaData".equals(method.getName())) return meta;
+ if ("getObject".equals(method.getName()) || "getInt".equals(method.getName())) return row[0] + 1;
+ if ("close".equals(method.getName())) resultClosed[0] = true;
+ return defaultValue(method.getReturnType());
+ });
+ Statement statement = proxy(Statement.class, (method, args) -> {
+ if ("setMaxRows".equals(method.getName())) queryLimit[0] = (Integer) args[0];
+ if ("execute".equals(method.getName())) {
+ queryStarted[0] = !String.valueOf(args[0]).startsWith("ALTER SESSION");
+ statementClosed[0] = false;
+ return queryStarted[0];
+ }
+ if ("getResultSet".equals(method.getName())) return cursor;
+ if ("close".equals(method.getName())) statementClosed[0] = true;
+ return defaultValue(method.getReturnType());
+ });
+ Connection connection = proxy(Connection.class, (method, args) -> {
+ if ("createStatement".equals(method.getName())) {
+ if (!queryStarted[0]) return statement;
+ Assertions.assertTrue(resultClosed[0] && statementClosed[0], "close the cursor before reading its trace");
+ return auditConnection.createStatement();
+ }
+ if ("prepareStatement".equals(method.getName())) return auditConnection.prepareStatement((String) args[0]);
+ return defaultValue(method.getReturnType());
+ });
+ OceanBaseOracleAgent agent = new OceanBaseOracleAgent();
+ TestSupport.setPrivateConnection(agent, connection);
+ QueryPageResult result = agent.executeQueryPage("SELECT N FROM T", null, new QueryPageOptions(pageSize, null, maxRows, 5));
+ List<List<Object>> rows = new ArrayList<>(result.getRows());
+ if (result.getHas_more()) {
+ Assertions.assertNull(result.getServer_execute_time_us());
+ Assertions.assertTrue(auditSql.isEmpty(), "do not sample an open cursor");
+ result = agent.fetchQueryPage(result.getSession_id(), pageSize);
+ rows.addAll(result.getRows());
+ }
+ Assertions.assertFalse(result.getHas_more());
+ Assertions.assertEquals(truncated, result.getTruncated());
+ Assertions.assertEquals(truncated ? List.of(List.of(1)) : List.of(List.of(1), List.of(2)), rows);
+ Assertions.assertEquals(0, queryLimit[0], "the paging cap must not change the JDBC statement limit");
+ Assertions.assertEquals(truncated ? List.of() : List.of(0, 0), auditLimits);
+ Assertions.assertEquals(truncated ? null : Long.valueOf(370), result.getServer_execute_time_us());
+ }
+
@Test
void doesNotAuditAnOpenCursorAfterAnotherSessionMethodCanReplaceItsTrace() {
int[] row = {-1};