Skip to content

armgit / dbx

Public Imported from GitHub
0

25 MB lightweight cross-platform database client for 100+ databases, including MySQL, PostgreSQL, SQLite, Redis, MongoDB, DuckDB, SQL Server, and Dameng. Built-in AI, MCP Server, CLI, desktop and Docker. | 轻量级跨平台数据库管理工具,支持 MySQL、PostgreSQL、SQLite、Redis、MongoDB、达梦等 100+ 数据库,提供桌面端、Docker、CLI、内置 AI 助手和 MCP。

fix(mongo): show refresh toolbar for never-loaded empty collections

Melody Ruch560e1c2c0cd1
diff --git a/apps/desktop/src/components/document/DocumentBrowser.vue b/apps/desktop/src/components/document/DocumentBrowser.vue
index 422aafb3ea..e0e33a13d6 100644
--- a/apps/desktop/src/components/document/DocumentBrowser.vue
+++ b/apps/desktop/src/components/document/DocumentBrowser.vue
@@ -405,14 +405,19 @@ function sameGridColumns(left: string[], right: string[]): boolean {
function commitLoadedDocuments(nextDocuments: JsonRecord[], nextCopyDocuments: JsonRecord[], hasTypePreservingCopyDocuments: boolean, append: boolean, kind: DocumentStoreKind) {
const previousDocumentCount = documents.value.length;
const combinedDocuments = append ? [...documents.value, ...nextDocuments] : nextDocuments;
- const nextColumns = combinedDocuments.length > 0 ? documentGridColumns(combinedDocuments) : lastGridColumns.value;
+ // A collection that has never returned any document (as opposed to one that
+ // returned documents before and is now empty) would otherwise keep
+ // `lastGridColumns` at its initial `[]` forever, which the grid reads as
+ // "no query has completed" and renders without a toolbar/refresh button.
+ const hasEstablishedColumns = lastGridColumns.value.length > 0;
+ const nextColumns = combinedDocuments.length > 0 || !hasEstablishedColumns ? documentGridColumns(combinedDocuments) : lastGridColumns.value;
const canAppendGridRows = append && gridRows.value.length === previousDocumentCount && sameGridColumns(lastGridColumns.value, nextColumns);
documents.value = combinedDocuments;
copyDocuments.value = append ? [...copyDocuments.value, ...nextCopyDocuments] : nextCopyDocuments;
mongoCopyDocumentsAvailable.value = append ? mongoCopyDocumentsAvailable.value && hasTypePreservingCopyDocuments : hasTypePreservingCopyDocuments;
- if (combinedDocuments.length > 0) {
+ if (combinedDocuments.length > 0 || !hasEstablishedColumns) {
lastGridColumns.value = nextColumns;
lastGridColumnTypes.value = kind === "mongodb" ? mongoDocumentGridColumnTypes(combinedDocuments, nextColumns) : [];
}
diff --git a/apps/desktop/src/components/document/__tests__/DocumentBrowserEmptyCollection.spec.ts b/apps/desktop/src/components/document/__tests__/DocumentBrowserEmptyCollection.spec.ts
new file mode 100644
index 0000000000..6cee7b7b64
--- /dev/null
+++ b/apps/desktop/src/components/document/__tests__/DocumentBrowserEmptyCollection.spec.ts
@@ -0,0 +1,257 @@
+// @vitest-environment happy-dom
+
+import { createApp, defineComponent, h, nextTick, type App } from "vue";
+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
+
+const backend = vi.hoisted(() => ({
+ documentFindDocuments: vi.fn(),
+ documentCountDocuments: vi.fn(),
+ cancelQuery: vi.fn(),
+ ensureConnected: vi.fn(),
+ documentInsertDocument: vi.fn(),
+ documentUpdateDocument: vi.fn(),
+ documentDeleteDocument: vi.fn(),
+ documentSaveMeilisearchBatch: vi.fn(),
+}));
+
+const dataGrid = vi.hoisted(() => ({
+ reload: undefined as (() => Promise<void>) | undefined,
+ rows: [] as unknown[],
+ columns: [] as string[],
+}));
+
+const settings = vi.hoisted(() => ({
+ editorSettings: {
+ pageSize: 2,
+ tableOpenPageSize: 5,
+ infiniteScroll: true,
+ mongoViewMode: "table" as "document" | "table",
+ columnWidthDensity: "standard" as "compact" | "standard" | "comfortable",
+ dataGridRenderMode: "canvas" as "canvas" | "dom",
+ tableFontFamily: "system-ui",
+ tableFontSize: 12,
+ numericColumnRightAlign: true,
+ confirmDangerousSqlExecution: true,
+ exportBatchSize: 2,
+ exportRowLimitEnabled: false,
+ exportRowLimit: 100_000,
+ },
+ updateEditorSettings: vi.fn(),
+}));
+
+vi.mock("vue-i18n", async (importOriginal) => ({
+ ...(await importOriginal<typeof import("vue-i18n")>()),
+ useI18n: () => ({ t: (key: string) => key }),
+}));
+
+vi.mock("@/lib/backend/api", () => ({
+ getColumns: vi.fn(),
+ documentFindDocuments: backend.documentFindDocuments,
+ documentCountDocuments: backend.documentCountDocuments,
+ dynamodbDescribeTable: vi.fn(),
+ cancelQuery: backend.cancelQuery,
+ documentInsertDocument: backend.documentInsertDocument,
+ documentUpdateDocument: backend.documentUpdateDocument,
+ documentDeleteDocument: backend.documentDeleteDocument,
+ documentSaveMeilisearchBatch: backend.documentSaveMeilisearchBatch,
+}));
+
+vi.mock("@/stores/connectionStore", () => ({
+ useConnectionStore: () => ({ ensureConnected: backend.ensureConnected }),
+}));
+
+vi.mock("@/stores/settingsStore", () => ({
+ TABLE_FONT_SIZE_MIN: 8,
+ TABLE_FONT_SIZE_MAX: 16,
+ useSettingsStore: () => settings,
+}));
+
+vi.mock("@/components/grid/DataGrid.vue", () => {
+ return {
+ default: defineComponent({
+ name: "DataGridStub",
+ inheritAttrs: false,
+ props: {
+ result: { type: Object, required: true },
+ customSaveHandler: { type: Object, required: false },
+ pageOffset: { type: Number, required: false },
+ pageLimit: { type: Number, required: false },
+ pageSizePreference: { type: String, required: false },
+ },
+ setup(props, { attrs, expose }) {
+ dataGrid.reload = attrs.onReload as typeof dataGrid.reload;
+ expose({
+ visibleColumnCount: 0,
+ displayableColumnCount: 0,
+ hiddenColumnCount: 0,
+ orderedColumnLayoutOptions: [],
+ filteredColumnLayoutOptions: () => [],
+ toggleColumnVisibility: vi.fn(),
+ showAllColumns: vi.fn(),
+ invertColumnVisibility: vi.fn(),
+ hasCustomColumnOrder: false,
+ moveDisplayableColumn: vi.fn(),
+ resetColumnOrder: vi.fn(),
+ nullColumnsHidden: false,
+ canToggleAllNullColumns: false,
+ allNullColumnCount: 0,
+ toggleAllNullColumns: vi.fn(),
+ multiRowTranspose: false,
+ setMultiRowTranspose: vi.fn(),
+ resetInfiniteScrollState: vi.fn(),
+ });
+ return () => {
+ const result = props.result as { rows: unknown[]; columns?: string[] };
+ dataGrid.rows = result.rows;
+ dataGrid.columns = result.columns ?? [];
+ return h("div", { "data-testid": "data-grid" });
+ };
+ },
+ }),
+ };
+});
+
+vi.mock("@/components/redis/RedisJsonEditor.vue", async () => {
+ const { defineComponent, h } = await import("vue");
+ return {
+ default: defineComponent({
+ props: { modelValue: { type: String, required: true } },
+ setup(props) {
+ return () => h("div", {}, props.modelValue);
+ },
+ }),
+ };
+});
+
+vi.mock("@/components/ui/popover", async () => {
+ const { defineComponent, h } = await import("vue");
+ const passthrough = (name: string) =>
+ defineComponent({
+ name,
+ setup(_, { slots }) {
+ return () => h("div", slots.default?.());
+ },
+ });
+ return { Popover: passthrough("PopoverStub"), PopoverTrigger: passthrough("PopoverTriggerStub"), PopoverContent: passthrough("PopoverContentStub") };
+});
+
+vi.mock("@/components/ui/select", async () => {
+ const { defineComponent, h } = await import("vue");
+ const passthrough = (name: string) =>
+ defineComponent({
+ name,
+ setup(_, { slots }) {
+ return () => h("div", slots.default?.());
+ },
+ });
+ return { Select: passthrough("SelectStub"), SelectContent: passthrough("SelectContentStub"), SelectItem: passthrough("SelectItemStub"), SelectTrigger: passthrough("SelectTriggerStub"), SelectValue: passthrough("SelectValueStub") };
+});
+
+import DocumentBrowser from "@/components/document/DocumentBrowser.vue";
+
+let app: App<Element> | null = null;
+let root: HTMLDivElement | null = null;
+
+async function flushUi() {
+ for (let index = 0; index < 4; index++) {
+ await Promise.resolve();
+ await nextTick();
+ }
+}
+
+async function mountBrowser() {
+ app = createApp(DocumentBrowser, {
+ connectionId: "mongo-1",
+ database: "test",
+ collection: "docs",
+ databaseType: "mongodb",
+ });
+ app.mount(root!);
+ await flushUi();
+}
+
+function documentResult(start: number, count: number, total: number) {
+ return {
+ documents: Array.from({ length: count }, (_, index) => {
+ const id = start + index;
+ return { _id: String(id), name: `row_${id}` };
+ }),
+ total,
+ total_is_exact: true,
+ };
+}
+
+beforeEach(async () => {
+ vi.stubGlobal("localStorage", {
+ getItem: () => null,
+ setItem: () => undefined,
+ removeItem: () => undefined,
+ });
+ backend.documentFindDocuments.mockReset();
+ backend.documentCountDocuments.mockReset();
+ backend.cancelQuery.mockReset();
+ backend.ensureConnected.mockReset();
+ backend.documentInsertDocument.mockReset();
+ backend.documentUpdateDocument.mockReset();
+ backend.documentDeleteDocument.mockReset();
+ backend.documentSaveMeilisearchBatch.mockReset();
+ backend.ensureConnected.mockResolvedValue(undefined);
+ backend.documentCountDocuments.mockResolvedValue(0);
+ dataGrid.reload = undefined;
+ dataGrid.rows = [];
+ dataGrid.columns = [];
+
+ root = document.createElement("div");
+ document.body.appendChild(root);
+});
+
+afterEach(() => {
+ app?.unmount();
+ root?.remove();
+ app = null;
+ root = null;
+ vi.unstubAllGlobals();
+});
+
+describe("DocumentBrowser empty collection refresh entry (issue #8093)", () => {
+ it("still reports non-empty columns for a collection that has never returned any document", async () => {
+ backend.documentFindDocuments.mockResolvedValueOnce(documentResult(1, 0, 0));
+
+ await mountBrowser();
+
+ // `DataGrid.vue` only renders its toolbar (and thus the refresh button)
+ // when `result.columns.length > 0`. A collection that was empty from the
+ // very first load must not leave that array empty forever.
+ expect(dataGrid.rows).toHaveLength(0);
+ expect(dataGrid.columns.length).toBeGreaterThan(0);
+ });
+
+ it("keeps reporting non-empty columns across a second empty reload of the same collection", async () => {
+ backend.documentFindDocuments.mockResolvedValueOnce(documentResult(1, 0, 0)).mockResolvedValueOnce(documentResult(1, 0, 0));
+
+ await mountBrowser();
+ expect(dataGrid.columns.length).toBeGreaterThan(0);
+
+ await dataGrid.reload!();
+ await flushUi();
+
+ expect(dataGrid.rows).toHaveLength(0);
+ expect(dataGrid.columns.length).toBeGreaterThan(0);
+ });
+
+ it("keeps the real columns (not the empty-collection fallback) after a collection that had data is emptied and reloaded", async () => {
+ backend.documentFindDocuments.mockResolvedValueOnce(documentResult(1, 2, 2)).mockResolvedValueOnce(documentResult(1, 0, 0));
+
+ await mountBrowser();
+ expect(dataGrid.columns).toEqual(["_id", "name"]);
+
+ await dataGrid.reload!();
+ await flushUi();
+
+ // Reproduces the reported "recovers only after closing and reopening the
+ // tab" case: the columns learned while data existed must survive an
+ // in-place reload that now returns zero rows.
+ expect(dataGrid.rows).toHaveLength(0);
+ expect(dataGrid.columns).toEqual(["_id", "name"]);
+ });
+});