Skip to content

armgit / dbx

Public Imported from GitHub
0

25 MB lightweight cross-platform database client for 100+ databases, including MySQL, PostgreSQL, SQLite, Redis, MongoDB, DuckDB, SQL Server, and Dameng. Built-in AI, MCP Server, CLI, desktop and Docker. | 轻量级跨平台数据库管理工具,支持 MySQL、PostgreSQL、SQLite、Redis、MongoDB、达梦等 100+ 数据库,提供桌面端、Docker、CLI、内置 AI 助手和 MCP。

test(settings): cover result tab click pinning behavior (#10824)

CSXFanMeng5c43ccaac588
diff --git a/apps/desktop/src/components/layout/__tests__/ContentArea.resultTabClickPin.spec.ts b/apps/desktop/src/components/layout/__tests__/ContentArea.resultTabClickPin.spec.ts
new file mode 100644
index 0000000000..175236c42e
--- /dev/null
+++ b/apps/desktop/src/components/layout/__tests__/ContentArea.resultTabClickPin.spec.ts
@@ -0,0 +1,104 @@
+// @vitest-environment happy-dom
+import { createApp, h, nextTick, reactive } from "vue";
+import { createPinia, setActivePinia } from "pinia";
+import { createI18n } from "vue-i18n";
+import { afterEach, describe, expect, it, vi } from "vitest";
+import type { QueryResult, QueryTab } from "@/types/database";
+
+vi.mock("@/components/editor/QueryEditor.vue", () => ({ __esModule: true, default: { render: () => null } }));
+vi.mock("@/composables/useToolbarOverflow", async () => {
+ const { ref } = await import("vue");
+ return { useToolbarOverflow: () => ({ tier: ref(0) }) };
+});
+vi.mock("@/lib/tabs/tabResultCache", async (importOriginal) => ({
+ ...(await importOriginal<typeof import("@/lib/tabs/tabResultCache")>()),
+ writeTabResultSnapshot: vi.fn().mockResolvedValue(false),
+}));
+vi.mock("@/components/grid/DataGrid.vue", () => ({ __esModule: true, default: { render: () => null } }));
+import ContentArea from "../ContentArea.vue";
+import { useQueryStore } from "@/stores/queryStore";
+import { useSettingsStore } from "@/stores/settingsStore";
+
+const cleanups: Array<() => void> = [];
+afterEach(async () => {
+ await vi.dynamicImportSettled();
+ cleanups.splice(0).forEach((cleanup) => cleanup());
+ document.body.replaceChildren();
+ window.localStorage?.clear();
+});
+
+async function mountResults(enabled: boolean, pinned = false) {
+ const pinia = createPinia();
+ setActivePinia(pinia);
+ const settings = useSettingsStore();
+ settings.editorSettings.pinResultTabOnClick = enabled;
+ const result: QueryResult = { columns: ["id"], rows: [[1]], affected_rows: 0, execution_time_ms: 1 };
+ const tab = reactive<QueryTab>({
+ id: "query",
+ title: "Query",
+ connectionId: "sqlite",
+ database: "app",
+ mode: "query",
+ sql: "SELECT 1",
+ isExecuting: false,
+ result,
+ results: [result],
+ activeResultRunId: "first",
+ resultRuns: [
+ { id: "first", title: "First", sequence: 1, sql: "SELECT 1", createdAt: 1, result, results: [result] },
+ { id: "second", title: "Second", sequence: 2, sql: "SELECT 1", createdAt: 2, result, results: [result], pinned },
+ ],
+ });
+ const queries = useQueryStore();
+ queries.tabs.push(tab);
+ const host = document.createElement("div");
+ document.body.append(host);
+ const app = createApp({
+ render: () =>
+ h(ContentArea, {
+ activeTab: tab,
+ activeOutputView: "result",
+ executableSql: "",
+ formatSqlRequest: null,
+ compressSqlRequest: null,
+ selectedSql: "",
+ cursorPos: 0,
+ resultOnly: true,
+ blockDangerousRedisCommands: false,
+ }),
+ });
+ app.use(pinia);
+ app.use(createI18n({ legacy: false, locale: "en", messages: { en: {} }, missingWarn: false, fallbackWarn: false }));
+ app.mount(host);
+ cleanups.push(() => app.unmount());
+ await nextTick();
+ await nextTick();
+ return { host, tab, settings, queries };
+}
+
+describe("result-tab click pinning", () => {
+ it.each([true, false])("selects the clicked run and only pins when enabled=%s", async (enabled) => {
+ const { host, tab } = await mountResults(enabled);
+ host.querySelectorAll<HTMLButtonElement>("[data-result-run-tab]")[1]!.click();
+ await vi.waitFor(() => expect(tab.activeResultRunId).toBe("second"));
+ for (let index = 0; index < 10; index++) await nextTick();
+ expect(tab.resultRuns![1]!.pinned === true).toBe(enabled);
+ });
+
+ it("does not unpin retained results when disabled and still permits explicit pinning", async () => {
+ const { host, tab, queries } = await mountResults(false, true);
+ host.querySelectorAll<HTMLButtonElement>("[data-result-run-tab]")[1]!.click();
+ await vi.waitFor(() => expect(tab.activeResultRunId).toBe("second"));
+ expect(tab.resultRuns![1]!.pinned).toBe(true);
+ queries.toggleResultRunPinned(tab.id, "first");
+ expect(tab.resultRuns![0]!.pinned).toBe(true);
+ });
+
+ it("applies a setting change to already mounted result tabs", async () => {
+ const { host, tab, settings } = await mountResults(false);
+ settings.editorSettings.pinResultTabOnClick = true;
+ await nextTick();
+ host.querySelectorAll<HTMLButtonElement>("[data-result-run-tab]")[1]!.click();
+ await vi.waitFor(() => expect(tab.resultRuns![1]!.pinned).toBe(true));
+ });
+});
diff --git a/apps/desktop/src/lib/settings/__tests__/editorSettingsDraft.spec.ts b/apps/desktop/src/lib/settings/__tests__/editorSettingsDraft.spec.ts
index 5c2d60336f..1a2ea5b0bf 100644
--- a/apps/desktop/src/lib/settings/__tests__/editorSettingsDraft.spec.ts
+++ b/apps/desktop/src/lib/settings/__tests__/editorSettingsDraft.spec.ts
@@ -43,6 +43,16 @@ function makeSettings(overrides: Partial<EditorSettings> = {}): EditorSettings {
}
describe("EDITOR_SETTINGS_DRAFT_KEYS", () => {
+ it("tracks the result-tab click setting in the draft without changing saved settings", () => {
+ const settings = makeSettings({ pinResultTabOnClick: true });
+ const draft = editorSettingsDraftFromSettings(settings);
+ const base = editorSettingsDraftFromSettings(settings);
+ draft.pinResultTabOnClick = false;
+ expect(settings.pinResultTabOnClick).toBe(true);
+ expect(editorSettingsDraftChanged(draft, base)).toBe(true);
+ expect(editorSettingsPatchFromDraft(draft, base)).toMatchObject({ pinResultTabOnClick: false });
+ });
+
it("captures and saves the column comment placement preference", () => {
const base = editorSettingsDraftFromSettings(makeSettings({ dataGridColumnCommentsInInfoArea: false, dataGridTransposeMetadataInInfoColumn: false }));
const draft = editorSettingsDraftFromSettings(makeSettings({ dataGridColumnCommentsInInfoArea: true, dataGridTransposeMetadataInInfoColumn: true }));
diff --git a/docs/screenshots/issue-10680-click-pin-disabled.png b/docs/screenshots/issue-10680-click-pin-disabled.png
new file mode 100644
index 0000000000..196bdda968
Binary files /dev/null and b/docs/screenshots/issue-10680-click-pin-disabled.png differ
diff --git a/docs/screenshots/issue-10680-click-pin-enabled.png b/docs/screenshots/issue-10680-click-pin-enabled.png
new file mode 100644
index 0000000000..22f469bf0c
Binary files /dev/null and b/docs/screenshots/issue-10680-click-pin-enabled.png differ