Skip to content

armgit / dbx

Public Imported from GitHub
0

25 MB lightweight cross-platform database client for 100+ databases, including MySQL, PostgreSQL, SQLite, Redis, MongoDB, DuckDB, SQL Server, and Dameng. Built-in AI, MCP Server, CLI, desktop and Docker. | 轻量级跨平台数据库管理工具,支持 MySQL、PostgreSQL、SQLite、Redis、MongoDB、达梦等 100+ 数据库,提供桌面端、Docker、CLI、内置 AI 助手和 MCP。

feat(starrocks): enable F2 table rename

bamboo5c8c7e019259
diff --git a/apps/desktop/src/lib/__tests__/table/objectRenameSql.spec.ts b/apps/desktop/src/lib/__tests__/table/objectRenameSql.spec.ts
index f5d66ce49e..b27b1a04dc 100644
--- a/apps/desktop/src/lib/__tests__/table/objectRenameSql.spec.ts
+++ b/apps/desktop/src/lib/__tests__/table/objectRenameSql.spec.ts
@@ -12,6 +12,16 @@ describe("Inceptor object rename", () => {
});
});
+describe("StarRocks object rename", () => {
+ it("enables table rename only", () => {
+ expect(supportsObjectRename("starrocks", "TABLE")).toBe(true);
+ for (const objectType of ["VIEW", "MATERIALIZED_VIEW", "PROCEDURE", "FUNCTION", "EVENT"] as const) {
+ expect(supportsObjectRename("starrocks", objectType)).toBe(false);
+ }
+ expect(supportsDatabaseRename("starrocks")).toBe(false);
+ });
+});
+
describe("database rename", () => {
it("chooses a maintenance database outside the rename target", () => {
expect(databaseRenameMaintenanceDatabase("admin", "application")).toBe("admin");
diff --git a/apps/desktop/src/lib/table/objectRenameSql.ts b/apps/desktop/src/lib/table/objectRenameSql.ts
index b34243d168..86e575d11e 100644
--- a/apps/desktop/src/lib/table/objectRenameSql.ts
+++ b/apps/desktop/src/lib/table/objectRenameSql.ts
@@ -23,7 +23,7 @@ export function supportsObjectRename(databaseType: DatabaseType | undefined, obj
return false;
}
if (databaseType === "sqlite" || databaseType === "rqlite" || databaseType === "turso" || databaseType === "cloudflare-d1" || databaseType === "duckdb") return objectType === "TABLE";
- if (databaseType === "transwarp") return objectType === "TABLE";
+ if (databaseType === "transwarp" || databaseType === "starrocks") return objectType === "TABLE";
if (databaseType === "mysql" || databaseType === "goldendb") return objectType === "TABLE" || objectType === "VIEW";
if (postgresLikeRenameTypes.has(databaseType)) return objectType === "TABLE" || objectType === "VIEW" || objectType === "MATERIALIZED_VIEW";
if (oracleLikeRenameTypes.has(databaseType)) return objectType === "TABLE" || objectType === "VIEW" || objectType === "MATERIALIZED_VIEW";
diff --git a/crates/dbx-sql-schema/src/db_admin_sql.rs b/crates/dbx-sql-schema/src/db_admin_sql.rs
index fdc4801af2..8eb502fa4b 100644
--- a/crates/dbx-sql-schema/src/db_admin_sql.rs
+++ b/crates/dbx-sql-schema/src/db_admin_sql.rs
@@ -932,7 +932,7 @@ pub fn supports_object_rename(database_type: Option<DatabaseType>, object_type:
if database_type == DatabaseType::SqlServer {
return true;
}
- if database_type == DatabaseType::Transwarp {
+ if matches!(database_type, DatabaseType::Transwarp | DatabaseType::StarRocks) {
return object_type == DatabaseObjectType::Table;
}
if matches!(object_type, DatabaseObjectType::Procedure | DatabaseObjectType::Function) {
@@ -978,6 +978,14 @@ pub fn build_rename_object_sql(options: RenameObjectSqlOptions) -> Result<String
));
}
+ if database_type == Some(DatabaseType::StarRocks) {
+ return Ok(format!(
+ "ALTER TABLE {} RENAME {};",
+ qualified_name(database_type, options.schema.as_deref(), &options.old_name),
+ quote_rename_identifier(database_type, &options.new_name)
+ ));
+ }
+
if database_type == Some(DatabaseType::Transwarp) {
return Ok(format!(
"ALTER TABLE {} RENAME TO {};",
@@ -3033,6 +3041,45 @@ mod tests {
);
}
+ #[test]
+ fn builds_starrocks_table_rename_sql() {
+ let database_type = Some(DatabaseType::StarRocks);
+ assert!(supports_object_rename(database_type, DatabaseObjectType::Table));
+ for (old_name, new_name, expected) in [
+ ("users", "app_users", "ALTER TABLE `users` RENAME `app_users`;"),
+ ("user`name", "new`name", "ALTER TABLE `user``name` RENAME `new``name`;"),
+ ] {
+ assert_eq!(
+ build_rename_object_sql(RenameObjectSqlOptions {
+ database_type,
+ object_type: DatabaseObjectType::Table,
+ schema: None,
+ old_name: old_name.to_string(),
+ new_name: new_name.to_string(),
+ })
+ .unwrap(),
+ expected
+ );
+ }
+ for object_type in [
+ DatabaseObjectType::View,
+ DatabaseObjectType::MaterializedView,
+ DatabaseObjectType::Procedure,
+ DatabaseObjectType::Function,
+ DatabaseObjectType::Event,
+ ] {
+ assert!(!supports_object_rename(database_type, object_type));
+ assert!(build_rename_object_sql(RenameObjectSqlOptions {
+ database_type,
+ object_type,
+ schema: None,
+ old_name: "old_name".to_string(),
+ new_name: "new_name".to_string(),
+ })
+ .is_err());
+ }
+ }
+
#[test]
fn builds_mysql_table_and_view_rename_sql() {
assert_eq!(