25 MB lightweight cross-platform database client for 100+ databases, including MySQL, PostgreSQL, SQLite, Redis, MongoDB, DuckDB, SQL Server, and Dameng. Built-in AI, MCP Server, CLI, desktop and Docker. | 轻量级跨平台数据库管理工具,支持 MySQL、PostgreSQL、SQLite、Redis、MongoDB、达梦等 100+ 数据库,提供桌面端、Docker、CLI、内置 AI 助手和 MCP。
TypeScript aicliclickhousedatabasedatabase-clientdatabase-managementdockerguimcpmongodbmysqlpostgresqlredisrustsql-serversqlitetaurivue
fix(sqlserver): enable foreign key editing in table structure editor (#12987) (#12996)
Luis Araya6e550518ee05
diff --git a/apps/desktop/src/components/structure/TableStructureEditor.vue b/apps/desktop/src/components/structure/TableStructureEditor.vueindex 2b05dd2a2a..8218a7261b 100644--- a/apps/desktop/src/components/structure/TableStructureEditor.vue+++ b/apps/desktop/src/components/structure/TableStructureEditor.vue@@ -1983,7 +1983,7 @@ const filteredIndexRowIds = computed(() => {return new Set(indexes.value.filter((index) => indexMatchesSearch(index, query)).map((index) => index.id));});const indexSearchMatchCount = computed(() => (indexSearchText.value.trim() ? filteredIndexRowIds.value.size : 0));-const foreignKeyActionOptions = ["", "CASCADE", "SET NULL", "RESTRICT", "NO ACTION"];+const foreignKeyActionOptions = computed(() => (structureDialect.value === "sqlserver" ? ["", "CASCADE", "SET NULL", "NO ACTION"] : ["", "CASCADE", "SET NULL", "RESTRICT", "NO ACTION"]));const triggerTimingOptions = computed(() => (databaseType.value === "sqlserver" ? ["AFTER", "INSTEAD OF"] : ["BEFORE", "AFTER"]));const triggerEventOptions = ["INSERT", "UPDATE", "DELETE"];const metadataSchema = computed(() => connectionObjectTreeQuerySchema(connection.value, props.database, props.schema));diff --git a/apps/desktop/src/lib/__tests__/table/tableStructureCapabilities.spec.ts b/apps/desktop/src/lib/__tests__/table/tableStructureCapabilities.spec.tsindex 65d711dc74..51837bf478 100644--- a/apps/desktop/src/lib/__tests__/table/tableStructureCapabilities.spec.ts+++ b/apps/desktop/src/lib/__tests__/table/tableStructureCapabilities.spec.ts@@ -105,6 +105,7 @@ describe("tableStructureCapabilities", () => {expect(getTableStructureCapabilities("sqlserver", "sqlserver")).toMatchObject({addPrimaryKey: true,alterPrimaryKey: true,+ foreignKey: true,});expect(getTableStructureCapabilities("oceanbase-oracle", "oceanbase-oracle")).toMatchObject({addPrimaryKey: true,diff --git a/apps/desktop/src/lib/table/tableStructureCapabilities.ts b/apps/desktop/src/lib/table/tableStructureCapabilities.tsindex 864adc8aa4..55d5087075 100644--- a/apps/desktop/src/lib/table/tableStructureCapabilities.ts+++ b/apps/desktop/src/lib/table/tableStructureCapabilities.ts@@ -202,6 +202,7 @@ const sqlserverCapabilities = capabilities({// T-SQL: ALTER TABLE ... DROP CONSTRAINT <name> / ADD [CONSTRAINT name] PRIMARY KEY (...);// the backend drops the persisted constraint by its index-metadata name (issue #10758).alterPrimaryKey: true,+ foreignKey: true,});const oracleCompatibleCapabilities = capabilities({diff --git a/crates/dbx-sql-schema/src/table_structure_sql/dialect.rs b/crates/dbx-sql-schema/src/table_structure_sql/dialect.rsindex 6e712d41e8..fe54980988 100644--- a/crates/dbx-sql-schema/src/table_structure_sql/dialect.rs+++ b/crates/dbx-sql-schema/src/table_structure_sql/dialect.rs@@ -278,6 +278,7 @@ pub(super) fn capabilities_for(// from the index metadata (issue #10758).add_primary_key: true,alter_primary_key: true,+ foreign_key: true,..base},Some(DatabaseType::SapHana) => TableStructureCapabilities {diff --git a/crates/dbx-sql-schema/src/table_structure_sql/foreign_keys.rs b/crates/dbx-sql-schema/src/table_structure_sql/foreign_keys.rsindex 26b24a269b..257d7d718e 100644--- a/crates/dbx-sql-schema/src/table_structure_sql/foreign_keys.rs+++ b/crates/dbx-sql-schema/src/table_structure_sql/foreign_keys.rs@@ -100,7 +100,7 @@ fn has_foreign_key_change(foreign_key: &EditableStructureForeignKey, original: &fn drop_foreign_key_sql(dialect: StructureDialect, table: &str, name: &str) -> String {match dialect {StructureDialect::Mysql => format!("ALTER TABLE {table} DROP FOREIGN KEY {};", quote_ident(dialect, name)),- StructureDialect::Postgres | StructureDialect::Oracle => {+ StructureDialect::Postgres | StructureDialect::Oracle | StructureDialect::SqlServer => {format!("ALTER TABLE {table} DROP CONSTRAINT {};", quote_ident(dialect, name))}_ => unreachable!("foreign key SQL requested for unsupported dialect"),@@ -171,6 +171,9 @@ fn action_clause(dialect: StructureDialect, prefix: &str, value: &str, warnings:if action.is_empty() {return None;}+ if dialect == StructureDialect::SqlServer && action == "RESTRICT" {+ return Some(format!("{prefix} NO ACTION"));+ }if dialect == StructureDialect::Oracle {if prefix == "ON UPDATE" {if action != "NO ACTION" {diff --git a/crates/dbx-sql-schema/src/table_structure_sql/tests.rs b/crates/dbx-sql-schema/src/table_structure_sql/tests.rsindex 753c480527..afc0cdb885 100644--- a/crates/dbx-sql-schema/src/table_structure_sql/tests.rs+++ b/crates/dbx-sql-schema/src/table_structure_sql/tests.rs@@ -4769,9 +4769,11 @@ fn sqlserver_rejects_identity_on_incompatible_type() {}#[test]-fn sqlserver_changed_foreign_key_still_warns_as_unsupported() {+fn sqlserver_foreign_key_edits_generate_alter_statements() {let mut user_fk = foreign_key("fk_orders_user_id", "user_id", "accounts", "id");user_fk.ref_schema = "dbo".to_string();+ user_fk.on_delete = "CASCADE".to_string();+ user_fk.on_update = "RESTRICT".to_string();user_fk.original = Some(ForeignKeyInfo {name: "fk_orders_user_id".to_string(),column: "user_id".to_string(),@@ -4806,8 +4808,14 @@ fn sqlserver_changed_foreign_key_still_warns_as_unsupported() {oracle_foreign_key_changes: None,});- assert_eq!(result.statements, Vec::<String>::new());- assert_eq!(result.warnings, vec!["Editing foreign keys is not supported for sqlserver from this editor."]);+ assert_eq!(result.warnings, Vec::<String>::new());+ assert_eq!(+ result.statements,+ vec![+ "ALTER TABLE [dbo].[orders] DROP CONSTRAINT [fk_orders_user_id];",+ "ALTER TABLE [dbo].[orders] ADD CONSTRAINT [fk_orders_user_id] FOREIGN KEY ([user_id]) REFERENCES [dbo].[accounts] ([id]) ON DELETE CASCADE ON UPDATE NO ACTION;"+ ]+ );}#[test]