Skip to content

armgit / dbx

Public Imported from GitHub
0

25 MB lightweight cross-platform database client for 100+ databases, including MySQL, PostgreSQL, SQLite, Redis, MongoDB, DuckDB, SQL Server, and Dameng. Built-in AI, MCP Server, CLI, desktop and Docker. | 轻量级跨平台数据库管理工具,支持 MySQL、PostgreSQL、SQLite、Redis、MongoDB、达梦等 100+ 数据库,提供桌面端、Docker、CLI、内置 AI 助手和 MCP。

fix(dameng): emit modify syntax for column changes

t8y27835f4c30935
diff --git a/crates/dbx-core/src/schema_diff.rs b/crates/dbx-core/src/schema_diff.rs
index 68a2f75a69..37138e84a8 100644
--- a/crates/dbx-core/src/schema_diff.rs
+++ b/crates/dbx-core/src/schema_diff.rs
@@ -5757,8 +5757,9 @@ fn generate_schema_sync_sql_inner(
}
} else if profile.alter_uses_modify_column {
if column.changes.iter().any(|change| !change.starts_with("order:")) {
+ let modify_keyword = profile.alter_modify_keyword();
parts.push(format!(
- " MODIFY COLUMN {}",
+ " {modify_keyword} {}",
column_def(&mapped, db_type, source_dialect)
));
}
@@ -8145,6 +8146,14 @@ mod tests {
}
}
+ #[test]
+ fn dameng_modify_column_uses_modify_without_column_keyword() {
+ let diffs = make_col_diffs(&[("name", "varchar(64)")], &[("name", "varchar(32)")], false);
+ let sql = gen_sql(wrap_table_diff("tbxx", diffs), DatabaseType::Dameng, None);
+ assert!(sql.contains("MODIFY NAME varchar(64)"), "Dameng modify: {sql}");
+ assert!(!sql.contains("MODIFY COLUMN"), "Dameng must omit COLUMN: {sql}");
+ }
+
// -- 25. Rename with nullable change --
#[test]
fn rename_with_nullable_change() {
diff --git a/crates/dbx-core/src/sql_dialect/ddl_profile.rs b/crates/dbx-core/src/sql_dialect/ddl_profile.rs
index efa125f787..fe72c95a2a 100644
--- a/crates/dbx-core/src/sql_dialect/ddl_profile.rs
+++ b/crates/dbx-core/src/sql_dialect/ddl_profile.rs
@@ -209,6 +209,14 @@ impl DdlDialectProfile {
}
}
+ pub fn alter_modify_keyword(&self) -> &'static str {
+ if self.database_type == DatabaseType::Dameng {
+ "MODIFY"
+ } else {
+ "MODIFY COLUMN"
+ }
+ }
+
/// Replace `{key}` placeholders. Unknown keys are left unchanged.
pub fn render_template(template: &str, vars: &[(&str, &str)]) -> String {
let mut out = template.to_string();
@@ -759,6 +767,12 @@ pub fn profile_for(db_type: DatabaseType) -> DdlDialectProfile {
// MySQL family
Mysql | Doris | StarRocks | Goldendb | Sundb | Databend | Gbase | ManticoreSearch => mysql_family(db_type),
+ Dameng => {
+ let mut profile = oracle_family(db_type);
+ profile.alter_uses_modify_column = true;
+ profile
+ }
+
// PostgreSQL family
Postgres | Redshift | Gaussdb | Kingbase | Highgo | Vastbase | OpenGauss | Kwdb | Uxdb => {
postgres_family(db_type)
@@ -775,7 +789,7 @@ pub fn profile_for(db_type: DatabaseType) -> DdlDialectProfile {
}
// Oracle family
- Oracle | Dameng | OceanbaseOracle | Yashandb | Xugu | Iris => oracle_family(db_type),
+ Oracle | OceanbaseOracle | Yashandb | Xugu | Iris => oracle_family(db_type),
// SQL Server (not Access)
SqlServer => sqlserver_family(db_type),