Skip to content

armgit / dbx

Public Imported from GitHub
0

25 MB lightweight cross-platform database client for 100+ databases, including MySQL, PostgreSQL, SQLite, Redis, MongoDB, DuckDB, SQL Server, and Dameng. Built-in AI, MCP Server, CLI, desktop and Docker. | 轻量级跨平台数据库管理工具,支持 MySQL、PostgreSQL、SQLite、Redis、MongoDB、达梦等 100+ 数据库,提供桌面端、Docker、CLI、内置 AI 助手和 MCP。

fix(sqlserver): handle traditional chinese legacy fallback

t8y27e2b74fb9d6c
diff --git a/agents/drivers/sqlserver-legacy/src/main/java/com/dbx/agent/sqlserverlegacy/SqlServerLegacyAgent.java b/agents/drivers/sqlserver-legacy/src/main/java/com/dbx/agent/sqlserverlegacy/SqlServerLegacyAgent.java
index 79c03bbc3b..bd8c9348f3 100644
--- a/agents/drivers/sqlserver-legacy/src/main/java/com/dbx/agent/sqlserverlegacy/SqlServerLegacyAgent.java
+++ b/agents/drivers/sqlserver-legacy/src/main/java/com/dbx/agent/sqlserverlegacy/SqlServerLegacyAgent.java
@@ -211,10 +211,14 @@ public final class SqlServerLegacyAgent extends ConfiguredJdbcAgent {
String normalized = message.toLowerCase(Locale.ROOT);
// mssql-jdbc rejects SQL Server 2000 (major version 8) during
// prelogin with "SQL Server version 8 is not supported by
- // this driver." — the version word breaks a plain
- // "sql server 8" substring match, so accept both shapes.
- boolean version8Rejection = (normalized.contains("sql server 8") || normalized.contains("sql server version 8"))
- && (normalized.contains("not support") || normalized.contains("不支持"));
+ // this driver." Localized messages can translate the version
+ // and unsupported phrases, so accept those equivalent shapes.
+ boolean version8Rejection = (normalized.contains("sql server 8")
+ || normalized.contains("sql server version 8")
+ || normalized.contains("sql server 版本 8"))
+ && (normalized.contains("not support")
+ || normalized.contains("不支持")
+ || normalized.contains("不支援"));
// Other driver wordings name the supported floor instead. The
// localized mssql-jdbc resource keeps "SQL Server 2005" in
// English while translating the "or later" suffix.
diff --git a/agents/drivers/sqlserver-legacy/src/test/java/com/dbx/agent/sqlserverlegacy/SqlServerLegacyAgentTest.java b/agents/drivers/sqlserver-legacy/src/test/java/com/dbx/agent/sqlserverlegacy/SqlServerLegacyAgentTest.java
index 6f70c164bb..f80564e7c2 100644
--- a/agents/drivers/sqlserver-legacy/src/test/java/com/dbx/agent/sqlserverlegacy/SqlServerLegacyAgentTest.java
+++ b/agents/drivers/sqlserver-legacy/src/test/java/com/dbx/agent/sqlserverlegacy/SqlServerLegacyAgentTest.java
@@ -61,6 +61,30 @@ class SqlServerLegacyAgentTest {
));
}
+ @Test
+ void traditionalChineseSqlServer8RejectionsTriggerTheOldDriverFallback() {
+ Assertions.assertTrue(SqlServerLegacyAgent.shouldFallbackToJtds(
+ new SQLException("此驅動程式不支援 SQL Server 版本 8。")
+ ));
+ Assertions.assertTrue(SqlServerLegacyAgent.shouldFallbackToJtds(
+ new SQLException("此驅動程式不支援 SQL Server 8 版。")
+ ));
+ Assertions.assertTrue(SqlServerLegacyAgent.shouldFallbackToJtds(
+ new SQLException("此驅動程式不支援 SQL Server 版本 8.0。")
+ ));
+
+ SQLException chained = new SQLException("連線失敗");
+ chained.setNextException(new SQLException("此驅動程式不支援 SQL Server 版本 8。"));
+ Assertions.assertTrue(SqlServerLegacyAgent.shouldFallbackToJtds(chained));
+
+ Assertions.assertFalse(SqlServerLegacyAgent.shouldFallbackToJtds(
+ new SQLException("登入失敗:SQL Server 版本 8 的使用者 'sa' 無法登入。")
+ ));
+ Assertions.assertFalse(SqlServerLegacyAgent.shouldFallbackToJtds(
+ new SQLException("TLS 交握失敗:此驅動程式不支援 TLSv1。")
+ ));
+ }
+
@Test
void jtdsUrlUsesLegacySqlServerSyntax() {
ConnectParams params = new ConnectParams(