25 MB lightweight cross-platform database client for 100+ databases, including MySQL, PostgreSQL, SQLite, Redis, MongoDB, DuckDB, SQL Server, and Dameng. Built-in AI, MCP Server, CLI, desktop and Docker. | 轻量级跨平台数据库管理工具,支持 MySQL、PostgreSQL、SQLite、Redis、MongoDB、达梦等 100+ 数据库,提供桌面端、Docker、CLI、内置 AI 助手和 MCP。
TypeScript aicliclickhousedatabasedatabase-clientdatabase-managementdockerguimcpmongodbmysqlpostgresqlredisrustsql-serversqlitetaurivue
fix(jdbc): read oracle execution plan within one transaction
zipg886c30aa3fba
diff --git a/plugins/jdbc/src/main/java/app/dbx/jdbc/DbxJdbcPlugin.java b/plugins/jdbc/src/main/java/app/dbx/jdbc/DbxJdbcPlugin.javaindex ae6baf6332..559cd080cf 100644--- a/plugins/jdbc/src/main/java/app/dbx/jdbc/DbxJdbcPlugin.java+++ b/plugins/jdbc/src/main/java/app/dbx/jdbc/DbxJdbcPlugin.java@@ -1786,6 +1786,12 @@ public final class DbxJdbcPlugin {String statementId = "DBX_" + UUID.randomUUID().toString().replace("-", "").substring(0, 26);String statementSql = trimStatementSql(sql);StringBuilder plan = new StringBuilder();+ // EXPLAIN PLAN and DBMS_XPLAN.DISPLAY are two separately autocommitted statements. A+ // schema that ships its own PLAN_TABLE as GLOBAL TEMPORARY TABLE ... ON COMMIT DELETE+ // ROWS loses the plan rows at the commit in between, so DISPLAY answers with+ // "cannot fetch plan for statement_id '...'". Run both inside one transaction to keep+ // the rows written by EXPLAIN PLAN visible for the read.+ boolean explainTransaction = beginOracleExplainTransaction(connection);try {try (PreparedStatement explain = connection.prepareStatement("EXPLAIN PLAN SET STATEMENT_ID = '" + statementId + "' FOR " + statementSql@@ -1815,6 +1821,46 @@ public final class DbxJdbcPlugin {cleanup.setString(1, statementId);cleanup.executeUpdate();} catch (SQLException ignored) {}+ endOracleExplainTransaction(connection, explainTransaction);+ }+ }++ /**+ * Oracle JDBC commits each statement in auto-commit mode, which is exactly what discards+ * plan rows held by a session plan table created as ON COMMIT DELETE ROWS. Switch the+ * connection into a short-lived transaction so EXPLAIN PLAN and the DBMS_XPLAN read share+ * one commit point. Skipped when the shared connection is already inside a manual+ * transaction or holds an open query session, and when the driver cannot toggle+ * auto-commit at all.+ */+ private static boolean beginOracleExplainTransaction(Connection connection) {+ try {+ if (+ !connection.getAutoCommit()+ || connectionState().manualTransactionActive+ || hasActiveQuerySession(connection)+ ) {+ return false;+ }+ connection.setAutoCommit(false);+ return true;+ } catch (SQLException | AbstractMethodError | UnsupportedOperationException ignored) {+ return false;+ }+ }++ private static void endOracleExplainTransaction(Connection connection, boolean explainTransaction) {+ if (!explainTransaction) {+ return;+ }+ try {+ // Commit instead of rollback so the plan-row cleanup above is not undone.+ connection.commit();+ } catch (SQLException | AbstractMethodError | UnsupportedOperationException ignored) {+ }+ try {+ connection.setAutoCommit(true);+ } catch (SQLException | AbstractMethodError | UnsupportedOperationException ignored) {}}diff --git a/plugins/jdbc/src/test/java/app/dbx/jdbc/DbxJdbcPluginTest.java b/plugins/jdbc/src/test/java/app/dbx/jdbc/DbxJdbcPluginTest.javaindex d4f4e3b256..f289b8ce3f 100644--- a/plugins/jdbc/src/test/java/app/dbx/jdbc/DbxJdbcPluginTest.java+++ b/plugins/jdbc/src/test/java/app/dbx/jdbc/DbxJdbcPluginTest.java@@ -1923,6 +1923,60 @@ final class DbxJdbcPluginTest {}}+ @Test+ void oracleExplainKeepsPlanRowsVisibleWhenThePlanTableDeletesRowsOnCommit() throws Exception {+ // A schema whose PLAN_TABLE is GLOBAL TEMPORARY TABLE ... ON COMMIT DELETE ROWS drops+ // the rows written by EXPLAIN PLAN at the auto-commit Oracle applies between two+ // statements; DBMS_XPLAN.DISPLAY then reports "cannot fetch plan for statement_id".+ // Both statements therefore have to share one transaction, and the cleanup DELETE must+ // be committed rather than rolled back.+ List<String> calls = new ArrayList<>();+ OracleExplainDriver driver = new OracleExplainDriver(calls);+ DriverManager.registerDriver(driver);+ String connection = """+ {+ "connection_string": "jdbc:oracle:dbx-explain:test",+ "username": "system",+ "query_timeout_secs": 30+ }+ """;+ try {+ JsonNode response = request("getExplainInfo", """+ {+ "connection": %s,+ "sql": "SELECT * FROM DUAL",+ "timeoutSecs": 30,+ "mode": "explain"+ }+ """.formatted(connection));++ assertFalse(response.has("error"), response.toString());+ assertEquals("Plan hash value: 123\nTABLE ACCESS FULL DUAL", response.path("result").path("plan").asText());+ int begin = callIndex(calls, call -> call.equals("setAutoCommit:false"));+ int explain = callIndex(calls, call -> call.startsWith("prepare:EXPLAIN PLAN SET STATEMENT_ID = 'DBX_"));+ int display = callIndex(calls, call -> call.startsWith("prepare:SELECT PLAN_TABLE_OUTPUT FROM TABLE(DBMS_XPLAN.DISPLAY"));+ int cleanup = callIndex(calls, call -> call.equals("prepare:DELETE FROM PLAN_TABLE WHERE STATEMENT_ID = ?"));+ int commit = callIndex(calls, call -> call.equals("commit"));+ int restore = callIndex(calls, call -> call.equals("setAutoCommit:true"));+ assertTrue(begin >= 0 && begin < explain, calls.toString());+ assertTrue(display > explain, calls.toString());+ assertTrue(cleanup > display, calls.toString());+ assertTrue(commit > cleanup, calls.toString());+ assertTrue(restore > commit, calls.toString());+ } finally {+ closeAndDeregister(connection, driver);+ }+ }++ private static int callIndex(List<String> calls, java.util.function.Predicate<String> match) {+ for (int index = 0; index < calls.size(); index++) {+ if (match.test(calls.get(index))) {+ return index;+ }+ }+ return -1;+ }+@Testvoid oracleExplainNullsBindPlaceholdersInsteadOfFailingWithMissingParameter() throws Exception {List<String> calls = new ArrayList<>();@@ -4922,6 +4976,7 @@ final class DbxJdbcPluginTest {}private static Connection oracleExplainConnection(List<String> calls, boolean parameterMetadataSupported) {+ boolean[] autoCommit = { true };return (Connection) Proxy.newProxyInstance(DbxJdbcPluginTest.class.getClassLoader(),new Class<?>[] { Connection.class },@@ -4931,6 +4986,20 @@ final class DbxJdbcPluginTest {calls,parameterMetadataSupported);+ case "getAutoCommit" -> autoCommit[0];+ case "setAutoCommit" -> {+ autoCommit[0] = (Boolean) args[0];+ calls.add("setAutoCommit:" + args[0]);+ yield null;+ }+ case "commit" -> {+ calls.add("commit");+ yield null;+ }+ case "rollback" -> {+ calls.add("rollback");+ yield null;+ }case "isClosed" -> false;case "close" -> null;default -> defaultValue(method.getReturnType());