Skip to content

armgit / dbx

Public Imported from GitHub
0

25 MB lightweight cross-platform database client for 100+ databases, including MySQL, PostgreSQL, SQLite, Redis, MongoDB, DuckDB, SQL Server, and Dameng. Built-in AI, MCP Server, CLI, desktop and Docker. | 轻量级跨平台数据库管理工具,支持 MySQL、PostgreSQL、SQLite、Redis、MongoDB、达梦等 100+ 数据库,提供桌面端、Docker、CLI、内置 AI 助手和 MCP。

fix(mysql): collapse storage warning guard and update generated draft expectation

t8y289ed17d645d8
diff --git a/crates/dbx-sql-schema/src/table_structure_sql/columns.rs b/crates/dbx-sql-schema/src/table_structure_sql/columns.rs
index 7aefdcbf85..4729feefe8 100644
--- a/crates/dbx-sql-schema/src/table_structure_sql/columns.rs
+++ b/crates/dbx-sql-schema/src/table_structure_sql/columns.rs
@@ -83,14 +83,15 @@ pub(super) fn build_column_sql(options: &TableStructureSqlOptions, warnings: &mu
}
}
None => {}
- Some((_, original_storage)) => {
- if normalize_mysql_generated_storage(generated.storage.as_deref()) != original_storage {
- warnings.push(format!(
- "Column \"{}\": MySQL cannot switch a generated column between VIRTUAL and STORED in place; the column must be dropped and re-added.",
- column.name
- ));
- }
+ Some((_, original_storage))
+ if normalize_mysql_generated_storage(generated.storage.as_deref()) != original_storage =>
+ {
+ warnings.push(format!(
+ "Column \"{}\": MySQL cannot switch a generated column between VIRTUAL and STORED in place; the column must be dropped and re-added.",
+ column.name
+ ));
}
+ Some(_) => {}
}
}
} else if let Some((_, original_storage)) = original_generated {
diff --git a/packages/app-tests/tableStructureEditorState.test.ts b/packages/app-tests/tableStructureEditorState.test.ts
index 84853bba07..2203ebf702 100644
--- a/packages/app-tests/tableStructureEditorState.test.ts
+++ b/packages/app-tests/tableStructureEditorState.test.ts
@@ -136,7 +136,9 @@ test("preserves MySQL generated expressions in original column metadata", () =>
"mysql",
);
- assert.deepEqual(draft.extra, {});
+ assert.deepEqual(draft.extra, {
+ generated: { expression: "`price` * `quantity`", storage: "STORED" },
+ });
assert.equal(draft.original?.extra, expression);
});