Skip to content

armgit / dbx

Public Imported from GitHub
0

25 MB lightweight cross-platform database client for 100+ databases, including MySQL, PostgreSQL, SQLite, Redis, MongoDB, DuckDB, SQL Server, and Dameng. Built-in AI, MCP Server, CLI, desktop and Docker. | 轻量级跨平台数据库管理工具,支持 MySQL、PostgreSQL、SQLite、Redis、MongoDB、达梦等 100+ 数据库,提供桌面端、Docker、CLI、内置 AI 助手和 MCP。

fix(oceanbase): show materialized views in object browser

t8y2b1fc9b15b996
diff --git a/crates/dbx-core/src/db/oceanbase_mysql.rs b/crates/dbx-core/src/db/oceanbase_mysql.rs
index aebf229421..017afd5953 100644
--- a/crates/dbx-core/src/db/oceanbase_mysql.rs
+++ b/crates/dbx-core/src/db/oceanbase_mysql.rs
@@ -1,7 +1,105 @@
+use mysql_async::prelude::*;
+use std::collections::{HashMap, HashSet};
+
use crate::models::connection::{ConnectionConfig, DatabaseType};
+use crate::types::{ObjectInfo, TableInfo};
+
+use super::mysql::{
+ get_conn_with_timeout, get_str_by_name, list_routine_objects, list_tables_show_with_status, quote_value,
+ table_infos_to_objects, MySqlPool, TableStatusMeta,
+};
pub const DRIVER_PROFILE: &str = "oceanbase";
+fn materialized_views_sql(database: &str) -> String {
+ format!("SELECT MVIEW_NAME FROM oceanbase.DBA_MVIEWS WHERE OWNER = {}", quote_value(database))
+}
+
+async fn list_materialized_view_names(pool: &MySqlPool, database: &str) -> Result<HashSet<String>, String> {
+ let mut conn = get_conn_with_timeout(pool, super::connection_timeout()).await?;
+ let result = conn.query_iter(materialized_views_sql(database)).await.map_err(|error| error.to_string())?;
+ let rows: Vec<mysql_async::Row> = result.collect_and_drop().await.map_err(|error| error.to_string())?;
+ Ok(rows
+ .iter()
+ .filter_map(|row| {
+ let name = get_str_by_name(row, "MVIEW_NAME").trim().to_string();
+ (!name.is_empty()).then_some(name)
+ })
+ .collect())
+}
+
+fn is_materialized_view_type(table_type: &str) -> bool {
+ let normalized = table_type.to_ascii_uppercase().replace('_', " ");
+ normalized.contains("MATERIALIZED") && normalized.contains("VIEW")
+}
+
+fn merge_materialized_views(
+ tables: &mut Vec<TableInfo>,
+ materialized_view_names: Result<HashSet<String>, String>,
+ database: &str,
+) {
+ let materialized_view_names = match materialized_view_names {
+ Ok(names) => names,
+ Err(error) => {
+ log::warn!("Skipping materialized view classification for OceanBase database `{database}`: {error}");
+ HashSet::new()
+ }
+ };
+
+ for table in tables.iter_mut() {
+ if is_materialized_view_type(&table.table_type)
+ || materialized_view_names.iter().any(|name| name.eq_ignore_ascii_case(&table.name))
+ {
+ table.table_type = "VIEW".to_string();
+ }
+ }
+
+ let mut known_names: HashSet<String> = tables.iter().map(|table| table.name.to_ascii_lowercase()).collect();
+ let mut missing_names = materialized_view_names.into_iter().collect::<Vec<_>>();
+ missing_names.sort();
+ for name in missing_names {
+ if known_names.insert(name.to_ascii_lowercase()) {
+ tables.push(TableInfo {
+ name,
+ table_type: "VIEW".to_string(),
+ comment: None,
+ parent_schema: None,
+ parent_name: None,
+ });
+ }
+ }
+ tables.sort_by(|left, right| left.name.cmp(&right.name));
+}
+
+async fn list_tables_with_status(
+ pool: &MySqlPool,
+ database: &str,
+) -> Result<(Vec<TableInfo>, HashMap<String, TableStatusMeta>), String> {
+ let (tables, materialized_view_names) =
+ tokio::join!(list_tables_show_with_status(pool, database), list_materialized_view_names(pool, database));
+ let (mut tables, status) = tables?;
+ merge_materialized_views(&mut tables, materialized_view_names, database);
+ Ok((tables, status))
+}
+
+pub async fn list_tables(pool: &MySqlPool, database: &str) -> Result<Vec<TableInfo>, String> {
+ list_tables_with_status(pool, database).await.map(|(tables, _)| tables)
+}
+
+pub async fn list_objects(pool: &MySqlPool, database: &str) -> Result<Vec<ObjectInfo>, String> {
+ let (tables, routines) =
+ tokio::join!(list_tables_with_status(pool, database), list_routine_objects(pool, database));
+ let (tables, status) = tables?;
+ let mut objects = table_infos_to_objects(tables, &status, database);
+
+ match routines {
+ Ok(routines) => objects.extend(routines),
+ Err(error) => log::warn!("Skipping routines for OceanBase database `{database}` in object browser: {error}"),
+ }
+
+ Ok(objects)
+}
+
pub fn is_config(config: &ConnectionConfig) -> bool {
is_profile(&config.db_type, config.driver_profile.as_deref())
}
@@ -39,6 +137,77 @@ mod tests {
assert_eq!(query_timeout_sql(&config, 30), None);
}
+ #[test]
+ fn materialized_views_are_visible_as_mysql_views_without_retyping_regular_objects() {
+ let mut tables =
+ vec![table("orders", "BASE TABLE"), table("orders_view", "VIEW"), table("orders_mv", "BASE TABLE")];
+
+ merge_materialized_views(
+ &mut tables,
+ Ok(HashSet::from(["orders_mv".to_string(), "daily_orders_mv".to_string()])),
+ "analytics",
+ );
+
+ assert_eq!(
+ tables.iter().map(|table| (table.name.as_str(), table.table_type.as_str())).collect::<Vec<_>>(),
+ vec![("daily_orders_mv", "VIEW"), ("orders", "BASE TABLE"), ("orders_mv", "VIEW"), ("orders_view", "VIEW"),]
+ );
+
+ let objects = table_infos_to_objects(tables, &HashMap::new(), "analytics");
+ assert_eq!(
+ objects.iter().map(|object| (object.name.as_str(), object.object_type.as_str())).collect::<Vec<_>>(),
+ vec![("daily_orders_mv", "VIEW"), ("orders", "TABLE"), ("orders_mv", "VIEW"), ("orders_view", "VIEW"),]
+ );
+ }
+
+ #[test]
+ fn materialized_view_names_are_case_insensitive_and_not_duplicated() {
+ let mut tables = vec![table("Orders_MV", "BASE TABLE")];
+
+ merge_materialized_views(
+ &mut tables,
+ Ok(HashSet::from(["orders_mv".to_string(), "daily_mv".to_string()])),
+ "analytics",
+ );
+
+ assert_eq!(
+ tables.iter().map(|table| (table.name.as_str(), table.table_type.as_str())).collect::<Vec<_>>(),
+ vec![("Orders_MV", "VIEW"), ("daily_mv", "VIEW")]
+ );
+ }
+
+ #[test]
+ fn materialized_view_catalog_failures_preserve_show_rows() {
+ let mut tables = vec![table("orders", "BASE TABLE"), table("orders_mv", "MATERIALIZED VIEW")];
+
+ merge_materialized_views(&mut tables, Err("permission denied".to_string()), "analytics");
+
+ assert_eq!(
+ tables.iter().map(|table| (table.name.as_str(), table.table_type.as_str())).collect::<Vec<_>>(),
+ vec![("orders", "BASE TABLE"), ("orders_mv", "VIEW")]
+ );
+ }
+
+ #[test]
+ fn empty_materialized_view_metadata_does_not_retype_regular_objects() {
+ let mut tables = vec![table("orders", "BASE TABLE"), table("orders_view", "VIEW")];
+
+ merge_materialized_views(&mut tables, Ok(HashSet::new()), "analytics");
+
+ assert_eq!(
+ tables.iter().map(|table| (table.name.as_str(), table.table_type.as_str())).collect::<Vec<_>>(),
+ vec![("orders", "BASE TABLE"), ("orders_view", "VIEW")]
+ );
+ }
+
+ #[test]
+ fn materialized_view_catalog_sql_escapes_database_names() {
+ assert_eq!(
+ materialized_views_sql("tenant's analytics"),
+ "SELECT MVIEW_NAME FROM oceanbase.DBA_MVIEWS WHERE OWNER = 'tenant\\'s analytics'"
+ );
+ }
+
fn test_config() -> ConnectionConfig {
serde_json::from_value(serde_json::json!({
"id": "oceanbase",
@@ -53,4 +222,14 @@ mod tests {
}))
.unwrap()
}
+
+ fn table(name: &str, table_type: &str) -> TableInfo {
+ TableInfo {
+ name: name.to_string(),
+ table_type: table_type.to_string(),
+ comment: None,
+ parent_schema: None,
+ parent_name: None,
+ }
+ }
}
diff --git a/crates/dbx-core/src/schema.rs b/crates/dbx-core/src/schema.rs
index 2e2764ba11..1a23d42236 100644
--- a/crates/dbx-core/src/schema.rs
+++ b/crates/dbx-core/src/schema.rs
@@ -2551,6 +2551,11 @@ async fn list_tables_once(
.await
.map(|tables| filter_table_infos(tables, filter, limit, offset, object_types, table_name_filter))
}
+ PoolKind::Mysql(p, _) if db_config.as_ref().is_some_and(db::oceanbase_mysql::is_config) => {
+ db::oceanbase_mysql::list_tables(p, mysql_table_metadata_catalog(database, schema))
+ .await
+ .map(|tables| filter_table_infos(tables, filter, limit, offset, object_types, table_name_filter))
+ }
PoolKind::Mysql(p, mode) => {
if *mode == MysqlMode::OceanBaseOracle {
let tables = db::ob_oracle::list_tables(p, schema).await?;
@@ -5984,6 +5989,8 @@ async fn list_objects_once(
db::manticoresearch::list_objects(p, database).await.map(unpaged_object_list)
} else if db_config.as_ref().is_some_and(db::starrocks::is_config) {
db::starrocks::list_table_objects(p, database).await.map(unpaged_object_list)
+ } else if db_config.as_ref().is_some_and(db::oceanbase_mysql::is_config) {
+ db::oceanbase_mysql::list_objects(p, database).await.map(unpaged_object_list)
} else if db_config.as_ref().is_some_and(db::mysql_compatible::uses_show_metadata) {
db::mysql::list_table_objects_show(p, database).await.map(unpaged_object_list)
} else if mysql_table_list_source_for_config(db_config.as_ref()) == MysqlTableListSource::ShowFullTables {