Skip to content

armgit / dbx

Public Imported from GitHub
0

25 MB lightweight cross-platform database client for 100+ databases, including MySQL, PostgreSQL, SQLite, Redis, MongoDB, DuckDB, SQL Server, and Dameng. Built-in AI, MCP Server, CLI, desktop and Docker. | 轻量级跨平台数据库管理工具,支持 MySQL、PostgreSQL、SQLite、Redis、MongoDB、达梦等 100+ 数据库,提供桌面端、Docker、CLI、内置 AI 助手和 MCP。

fix(data-grid): guard temporal slices against utf8 boundaries

Woohyuck Jeongba57a3cb4cd3
diff --git a/crates/dbx-sql-data/src/data_grid_sql.rs b/crates/dbx-sql-data/src/data_grid_sql.rs
index b697b0b396..97d2a48bd5 100644
--- a/crates/dbx-sql-data/src/data_grid_sql.rs
+++ b/crates/dbx-sql-data/src/data_grid_sql.rs
@@ -3054,7 +3054,7 @@ fn regex_like_local_datetime(text: &str) -> Option<Rfc3339Parts> {
if bytes.len() < 10 || bytes.get(4) != Some(&b'-') || bytes.get(7) != Some(&b'-') {
return None;
}
- let date = &text[0..10];
+ let date = text.get(0..10)?;
if bytes.len() == 10 {
return Some(Rfc3339Parts {
date: date.to_string(),
@@ -3070,8 +3070,8 @@ fn regex_like_local_datetime(text: &str) -> Option<Rfc3339Parts> {
if bytes.len() < 19 || bytes.get(13) != Some(&b':') || bytes.get(16) != Some(&b':') {
return None;
}
- let time = &text[11..19];
- let rest = &text[19..];
+ let time = text.get(11..19)?;
+ let rest = text.get(19..)?;
let fraction = if let Some(rest) = rest.strip_prefix('.') {
let digit_count = rest.chars().take_while(|ch| ch.is_ascii_digit()).count();
if digit_count == 0 || digit_count > 9 || digit_count != rest.len() {
@@ -3320,8 +3320,8 @@ fn regex_like_rfc3339(text: &str) -> Option<Rfc3339Parts> {
return None;
}
let date = &text[0..10];
- let time = &text[11..19];
- let rest = &text[19..];
+ let time = text.get(11..19)?;
+ let rest = text.get(19..)?;
let (fraction, zone) = if let Some(rest) = rest.strip_prefix('.') {
let digit_count = rest.chars().take_while(|ch| ch.is_ascii_digit()).count();
if digit_count == 0 || digit_count > 9 {
@@ -3395,8 +3395,8 @@ fn parse_tdengine_timestamp(text: &str) -> Option<(String, String, Option<String
return None;
}
let date = text[0..10].to_string();
- let time = text[11..19].to_string();
- let rest = &text[19..];
+ let time = text.get(11..19)?.to_string();
+ let rest = text.get(19..)?;
if rest.is_empty() {
return Some((date, time, None));
}
@@ -7839,6 +7839,34 @@ mod tests {
);
}
+ #[test]
+ fn keeps_temporal_like_text_with_multibyte_seconds_verbatim() {
+ let date = column("event_day", "DATE", true, None);
+ let text = "2026-05-12 00:00:05";
+ for (database_type, column_info) in
+ [(DatabaseType::Mysql, None), (DatabaseType::Tdengine, None), (DatabaseType::Oracle, Some(&date))]
+ {
+ assert_eq!(
+ format_grid_sql_literal(&json!(text), Some(database_type), column_info),
+ format!("'{text}'"),
+ "{database_type:?}"
+ );
+ }
+ }
+
+ #[test]
+ fn keeps_temporal_like_text_with_multibyte_date_field_verbatim() {
+ let date = column("event_day", "DATE", true, None);
+ let text = "2026-05-12 00:00:00";
+ for database_type in [DatabaseType::Oracle, DatabaseType::OceanbaseOracle] {
+ assert_eq!(
+ format_grid_sql_literal(&json!(text), Some(database_type), Some(&date)),
+ format!("'{text}'"),
+ "{database_type:?}"
+ );
+ }
+ }
+
#[test]
fn formats_sqlserver_datetime_copy_literals_with_supported_precision() {
let datetime = column("date1", "datetime", true, None);