25 MB lightweight cross-platform database client for 100+ databases, including MySQL, PostgreSQL, SQLite, Redis, MongoDB, DuckDB, SQL Server, and Dameng. Built-in AI, MCP Server, CLI, desktop and Docker. | 轻量级跨平台数据库管理工具,支持 MySQL、PostgreSQL、SQLite、Redis、MongoDB、达梦等 100+ 数据库,提供桌面端、Docker、CLI、内置 AI 助手和 MCP。
TypeScript aicliclickhousedatabasedatabase-clientdatabase-managementdockerguimcpmongodbmysqlpostgresqlredisrustsql-serversqlitetaurivue
feat(oracle): plan-governed object rename and package save-as
efeirec49864282668
diff --git a/apps/desktop/src/App.vue b/apps/desktop/src/App.vueindex bcb2a0fd1f..59d69d190d 100644--- a/apps/desktop/src/App.vue+++ b/apps/desktop/src/App.vue@@ -91,6 +91,7 @@ import { normalizeSqliteNamespace } from "@/lib/database/sqliteNamespace";import { findTreeNodeById, resolveNewQueryTarget, resolveNewQueryInitialSql, type NewQueryContextSource } from "@/lib/sql/newQueryContext";import { isSqlObjectNavigationRoutineType, normalizeOracleNavigationTarget, sqlObjectNavigationSourceKind, sqlObjectNavigationSourceName, sqlObjectNavigationSourceSchema, sqlObjectNavigationTableType, type SqlObjectNavigationTarget } from "@/lib/sql/sqlNavigation";import { buildEditableObjectSource, buildExecutableObjectSourceStatements, executeObjectSourceSave } from "@/lib/table/objectSourceEditor";+import { assertSourceIdentity, beginSourceSave } from "@/lib/table/objectSourceIdentity";import { loadEditableObjectSourceForEditor } from "@/lib/table/objectSourceLoad";import { schemaAfterConnectionSwitch } from "@/lib/schema/connectionSchemaInitialization";import { resolveHistorySqlRestoreTarget } from "@/lib/history/historyRestoreTarget";@@ -2620,31 +2621,43 @@ async function saveActiveObjectSource(tab: QueryTab): Promise<boolean> {if (!connection || !source) return false;try {+ const identity = queryStore.getObjectSourceIdentitySnapshot(tab)!;+ assertSourceIdentity(identity);+ const { connectionId, database } = tab;+ const schema = source.schema || tab.schema || database;+ const sql = tab.sql;const databaseType = effectiveDatabaseTypeForConnection(connection) ?? connection.db_type;const statements = await buildExecutableObjectSourceStatements({databaseType,objectType: source.objectType,- schema: source.schema || tab.schema || tab.database,+ schema,name: source.name,- source: tab.sql,+ source: sql,});+ const execute = async () => {+ if (!queryStore.tabs.includes(tab) || tab.objectSource !== source || tab.connectionId !== connectionId || tab.database !== database || (source.schema || tab.schema || database) !== schema) return false;+ const release = beginSourceSave(identity);+ try {+ await executeObjectSourceSave(connectionId, database, databaseType, statements, schema);+ return true;+ } finally {+ release();+ }+ };const executableSql = statements.filter((sql) => sql.trim()).join(";\n");if (executableSql.trim()) {const saved = await executeWithProductionSqlGuard({connection,- database: tab.database,+ database,sql: executableSql,source: t("production.sourceObjectSource"),- execute: async () => {- await executeObjectSourceSave(tab.connectionId, tab.database, databaseType, statements, source.schema || tab.schema);- return true;- },+ execute,});if (!saved) return false;} else {- await executeObjectSourceSave(tab.connectionId, tab.database, databaseType, statements, source.schema || tab.schema);+ if (!(await execute())) return false;}- queryStore.markTabClean(tab);+ if (tab.sql === sql) queryStore.markTabClean(tab);toast(t("objects.sourceSaved"), 2000);return true;} catch (e: any) {diff --git a/apps/desktop/src/components/objects/ObjectBrowser.vue b/apps/desktop/src/components/objects/ObjectBrowser.vueindex abcee75d17..e34ea732c3 100644--- a/apps/desktop/src/components/objects/ObjectBrowser.vue+++ b/apps/desktop/src/components/objects/ObjectBrowser.vue@@ -104,7 +104,16 @@ import { executeOceanbaseTableClone, executeOceanbaseTableCloneData, oceanbaseClimport { useOceanbaseCloneDialog } from "@/composables/useOceanbaseCloneDialog";import { useToast } from "@/composables/useToast";import { buildExecutableObjectSourceStatements, buildRoutineRenameObjectSourceStatements, executeObjectSourceSave, formatObjectSourceSaveError, supportsSourceBackedRoutineRename } from "@/lib/table/objectSourceEditor";+import { assertSourceIdentity, beginSourceSave, captureSourceIdentity, freezeSourceIdentities, renewSourceIdentity, type SourceIdentitySnapshot } from "@/lib/table/objectSourceIdentity";import { buildRenameObjectSql, supportsObjectRename } from "@/lib/table/objectRenameSql";+import { prepareOracleViewRename, executeOracleViewRename, OracleViewRenameFailure, type OracleViewRenamePlan } from "@/lib/table/oracleViewRename";+import OracleViewRenamePreview from "@/components/objects/OracleViewRenamePreview.vue";+import { prepareOracleRoutineRename, executeOracleRoutineRename, OracleRoutineRenameFailure, type OracleRoutineRenamePlan } from "@/lib/table/oracleRoutineRename";+import { prepareOracleTableRename, executeOracleTableRename, OracleTableRenameFailure, type OracleTableRenamePlan } from "@/lib/table/oracleTableRename";+import OracleTableRenamePreview from "@/components/objects/OracleTableRenamePreview.vue";+import OracleRoutineRenamePreview from "@/components/objects/OracleRoutineRenamePreview.vue";+import OraclePackageSaveAsDialog from "@/components/objects/OraclePackageSaveAsDialog.vue";+import { executeOraclePackageSaveAs, OraclePackageSaveAsFailure, prepareOraclePackageSaveAs, type OraclePackageSaveAsPlan } from "@/lib/table/oraclePackageSaveAs";import { isTauriRuntime } from "@/lib/backend/tauriRuntime";import { autoRevealExportedPathIfConfigured, promptExportSavePath } from "@/lib/export/exportPath";import { generateDatabaseExportId } from "@/lib/export/databaseExport";@@ -373,6 +382,25 @@ const renameTarget = ref<ObjectBrowserRow | null>(null);const renameInput = ref("");const renameError = ref("");const renamePreviewSqlText = ref("");+const viewRenamePlan = ref<OracleViewRenamePlan>();+const viewRenameDrafts = ref<Record<string, string>>({});+const routineRenamePlan = ref<OracleRoutineRenamePlan>();+const routineRenameDrafts = ref<Record<string, string>>({});+const tableRenamePlan = ref<OracleTableRenamePlan>();+const tableRenameDrafts = ref<Record<string, string>>({});+const packageSaveAsOpen = ref(false);+const packageSaveAsTarget = ref<ObjectBrowserRow | null>(null);+const packageSaveAsName = ref("");+const packageSaveAsPlan = ref<OraclePackageSaveAsPlan>();+const packageSaveAsDrafts = ref<{ spec?: string; body?: string }>({});+const packageSaveAsLoading = ref(false);+const packageSaveAsValidating = ref(false);+const packageSaveAsExecuting = ref(false);+const packageSaveAsError = ref("");+const packageSaveAsDiagnostic = ref("");+const viewRenameLoading = ref(false);+const viewRenameValidating = ref(false);+const viewRenameExecuting = ref(false);const showTruncateConfirm = ref(false);const truncateTarget = ref<ObjectBrowserRow | null>(null);const truncatePreviewSql = ref("");@@ -1041,7 +1069,11 @@ function togglePartitionParent(row: ObjectBrowserRow) {}function canRename(row: ObjectBrowserRow) {- return supportsObjectRename(effectiveDatabaseType.value, row.type) || supportsSourceBackedRoutineRename(effectiveDatabaseType.value, row.type as ObjectSourceKind);+ return (+ supportsObjectRename(effectiveDatabaseType.value, row.type) ||+ ((effectiveDatabaseType.value === "oracle" || effectiveDatabaseType.value === "oceanbase-oracle") && (row.type === "PROCEDURE" || row.type === "FUNCTION")) ||+ supportsSourceBackedRoutineRename(effectiveDatabaseType.value, row.type as ObjectSourceKind)+ );}function sourceTitle(row: ObjectBrowserRow | null) {@@ -1677,6 +1709,8 @@ async function openSource(row: ObjectBrowserRow) {await loadSourcePanel(row);}+let sourceIdentity: SourceIdentitySnapshot | undefined;+async function loadSourcePanel(row: ObjectBrowserRow, options?: { preserveEditing?: boolean }) {// Starting a different object must invalidate slower source requests before// any state is reset, otherwise an old response can populate the new row.@@ -1701,6 +1735,8 @@ async function loadSourcePanel(row: ObjectBrowserRow, options?: { preserveEditinconst connectionId = props.connection.id;const database = props.database;const schema = row.schema || selectedSchema.value || database;+ const identity = captureSourceIdentity({ connectionId, database, schema, objectType: row.type, name: row.name });+ sourceIdentity = undefined;try {const result = await sidePanelGuard.wait(epoch, api.getObjectSource(connectionId, database, schema, row.name, row.type as ObjectSourceKind, row.signature ?? undefined), metadataLoadBudgetMs(props.connection.query_timeout_secs));if (sidePanelGuard.isStale(epoch)) return;@@ -1721,6 +1757,7 @@ async function loadSourcePanel(row: ObjectBrowserRow, options?: { preserveEditinif (sidePanelGuard.isStale(epoch)) return;// Viewing database source must preserve its original whitespace and comments;// formatting remains an explicit editor action instead of altering it on open.+ sourceIdentity = renewSourceIdentity(identity);sourceEditableText.value = editable;sourceContent.value = row.type === "SEQUENCE" ? result.source : editable;sourceDraft.value = editable;@@ -1821,14 +1858,189 @@ function requestDrop(row: ObjectBrowserRow) {}function requestRename(row: ObjectBrowserRow) {+ const nextTargetKey = JSON.stringify([props.connection.id, props.database, effectiveDatabaseType.value, row.schema || selectedSchema.value || props.database, row.type, row.name]);+ const sameTarget = nextTargetKey === currentViewRenameTargetKey;renameTarget.value = row;- renameInput.value = row.name;+ if (!sameTarget) renameInput.value = row.name;renameError.value = "";renamePreviewSqlText.value = "";+ viewRenamePlan.value = undefined;+ routineRenamePlan.value = undefined;+ tableRenamePlan.value = undefined;+ if (!sameTarget) {+ viewRenameDrafts.value = {};+ routineRenameDrafts.value = {};+ tableRenameDrafts.value = {};+ }showRenameDialog.value = true;}+function requestPackageSaveAs(row: ObjectBrowserRow) {+ if ((effectiveDatabaseType.value !== "oracle" && effectiveDatabaseType.value !== "oceanbase-oracle") || (row.type !== "PACKAGE" && row.type !== "PACKAGE_BODY")) return;+ const sourceKey = JSON.stringify([props.connection.id, props.database, effectiveDatabaseType.value, row.schema || selectedSchema.value || props.database, row.name]);+ const sameTarget = sourceKey === currentPackageSaveAsSourceKey;+ currentPackageSaveAsSourceKey = sourceKey;+ packageSaveAsTarget.value = row;+ if (!sameTarget) {+ packageSaveAsName.value = `${row.name}_COPY`;+ packageSaveAsDrafts.value = {};+ }+ packageSaveAsPlan.value = undefined;+ packageSaveAsError.value = "";+ packageSaveAsDiagnostic.value = "";+ packageSaveAsOpen.value = true;+}++let currentPackageSaveAsSourceKey = "";+let packageSaveAsRequestId = 0;+watch([packageSaveAsOpen, packageSaveAsTarget, packageSaveAsName, () => props.connection.id, () => props.database, selectedSchema, effectiveDatabaseType], (_value, _oldValue, onCleanup) => {+ const requestId = ++packageSaveAsRequestId;+ const row = packageSaveAsTarget.value;+ const sourceKey = row ? JSON.stringify([props.connection.id, props.database, effectiveDatabaseType.value, row.schema || selectedSchema.value || props.database, row.name]) : "";+ if (sourceKey && sourceKey !== currentPackageSaveAsSourceKey) {+ currentPackageSaveAsSourceKey = sourceKey;+ packageSaveAsDrafts.value = {};+ }+ const newName = packageSaveAsName.value.trim();+ packageSaveAsPlan.value = undefined;+ packageSaveAsError.value = "";+ packageSaveAsDiagnostic.value = "";+ if (!packageSaveAsOpen.value || !row || !newName || newName === row.name || !props.connection.id || !props.database || (effectiveDatabaseType.value !== "oracle" && effectiveDatabaseType.value !== "oceanbase-oracle")) return;+ const timer = setTimeout(async () => {+ packageSaveAsLoading.value = true;+ try {+ const plan = await prepareOraclePackageSaveAs(+ {+ connectionId: props.connection.id,+ database: props.database,+ databaseType: effectiveDatabaseType.value as "oracle" | "oceanbase-oracle",+ schema: row.schema || selectedSchema.value || props.database,+ oldName: row.name,+ newName,+ },+ { ...packageSaveAsDrafts.value },+ );+ if (requestId === packageSaveAsRequestId) packageSaveAsPlan.value = plan;+ } catch (error) {+ if (requestId === packageSaveAsRequestId) packageSaveAsDiagnostic.value = error instanceof Error ? error.message : String(error);+ } finally {+ if (requestId === packageSaveAsRequestId) packageSaveAsLoading.value = false;+ }+ }, 250);+ onCleanup(() => clearTimeout(timer));+});++async function confirmPackageSaveAs() {+ const row = packageSaveAsTarget.value;+ const plan = packageSaveAsPlan.value;+ if (!row || !plan || !plan.executable || !packageSaveAsOpen.value) return;+ const schema = row.schema || selectedSchema.value || props.database;+ if (plan.target.newName !== packageSaveAsName.value.trim() || plan.target.oldName !== row.name || plan.target.schema !== schema || plan.target.connectionId !== props.connection.id || plan.target.database !== props.database) {+ packageSaveAsError.value = t("objects.packageSaveAsMetadataProblem");+ return;+ }+ packageSaveAsExecuting.value = true;+ packageSaveAsError.value = "";+ packageSaveAsDiagnostic.value = "";+ const isCurrentPlan = () => {+ const currentRow = packageSaveAsTarget.value;+ return (+ packageSaveAsOpen.value &&+ packageSaveAsPlan.value === plan &&+ !!currentRow &&+ currentRow.name === plan.target.oldName &&+ props.connection.id === plan.target.connectionId &&+ props.database === plan.target.database &&+ (currentRow.schema || selectedSchema.value || props.database) === plan.target.schema &&+ effectiveDatabaseType.value === plan.target.databaseType &&+ packageSaveAsName.value.trim() === plan.target.newName+ );+ };+ try {+ const executed = await executeObjectBrowserSqlWithProductionGuard(plan.statements.join("\n\n"), async () => {+ await executeOraclePackageSaveAs(+ plan,+ () =>+ packageSaveAsPlan.value === plan &&+ packageSaveAsOpen.value &&+ packageSaveAsTarget.value?.name === plan.target.oldName &&+ props.connection.id === plan.target.connectionId &&+ props.database === plan.target.database &&+ (row.schema || selectedSchema.value || props.database) === plan.target.schema,+ );+ return true;+ });+ if (!executed) return;+ toast(t("objects.packageSaveAsSuccess", { oldName: row.name, newName: plan.canonicalNewName }));+ packageSaveAsOpen.value = false;+ await reload();+ await connectionStore.refreshObjectListTreeNode(props.connection.id, props.database, schema);+ } catch (error) {+ if (isCurrentPlan()) {+ packageSaveAsError.value = t("objects.packageSaveAsFailed");+ packageSaveAsDiagnostic.value = error instanceof Error ? error.message : String(error);+ packageSaveAsPlan.value = { ...plan, executable: false };+ }+ if (error instanceof OraclePackageSaveAsFailure && error.dispatched) {+ try {+ await connectionStore.refreshObjectListTreeNode(plan.target.connectionId, plan.target.database, plan.target.schema);+ if (props.connection.id === plan.target.connectionId && props.database === plan.target.database && (packageSaveAsTarget.value?.schema || selectedSchema.value || props.database) === plan.target.schema) await reload();+ } catch {+ // Keep the package DDL failure visible when metadata refresh also fails.+ }+ }+ } finally {+ packageSaveAsExecuting.value = false;+ }+}++function editPackageSaveAsDraft(part: "spec" | "body", source: string) {+ packageSaveAsDrafts.value = { ...packageSaveAsDrafts.value, [part]: source };+ ++packageSaveAsRequestId;+ if (packageSaveAsPlan.value) packageSaveAsPlan.value = { ...packageSaveAsPlan.value, executable: false };+}++async function validatePackageSaveAsDrafts() {+ if (packageSaveAsPlan.value) packageSaveAsPlan.value = { ...packageSaveAsPlan.value, executable: false };+ packageSaveAsError.value = "";+ packageSaveAsDiagnostic.value = "";+ packageSaveAsValidating.value = true;+ try {+ const row = packageSaveAsTarget.value;+ const newName = packageSaveAsName.value.trim();+ if (!row || !newName) return;+ const requestId = ++packageSaveAsRequestId;+ const drafts = { ...packageSaveAsDrafts.value };+ const targetKey = JSON.stringify([props.connection.id, props.database, effectiveDatabaseType.value, row.schema || selectedSchema.value || props.database, row.name, newName]);+ const plan = await prepareOraclePackageSaveAs(+ {+ connectionId: props.connection.id,+ database: props.database,+ databaseType: effectiveDatabaseType.value as "oracle" | "oceanbase-oracle",+ schema: row.schema || selectedSchema.value || props.database,+ oldName: row.name,+ newName,+ },+ drafts,+ );+ if (+ requestId === packageSaveAsRequestId &&+ packageSaveAsOpen.value &&+ packageSaveAsTarget.value === row &&+ packageSaveAsName.value.trim() === newName &&+ targetKey === JSON.stringify([props.connection.id, props.database, effectiveDatabaseType.value, row.schema || selectedSchema.value || props.database, row.name, packageSaveAsName.value.trim()]) &&+ JSON.stringify(packageSaveAsDrafts.value) === JSON.stringify(drafts)+ )+ packageSaveAsPlan.value = plan;+ } catch (error) {+ packageSaveAsDiagnostic.value = error instanceof Error ? error.message : String(error);+ } finally {+ packageSaveAsValidating.value = false;+ }+}+let renamePreviewRequestId = 0;+let currentViewRenameTargetKey = "";async function refreshRenamePreviewSql() {const requestId = ++renamePreviewRequestId;@@ -1836,13 +2048,77 @@ async function refreshRenamePreviewSql() {const newName = renameInput.value.trim();if (!showRenameDialog.value || !row || !newName || newName === row.name) {renamePreviewSqlText.value = "";+ viewRenamePlan.value = undefined;+ routineRenamePlan.value = undefined;+ tableRenamePlan.value = undefined;+ return;+ }+ if ((effectiveDatabaseType.value === "oracle" || effectiveDatabaseType.value === "oceanbase-oracle") && (row.type === "PROCEDURE" || row.type === "FUNCTION")) {+ const targetKey = JSON.stringify([props.connection.id, props.database, effectiveDatabaseType.value, row.schema || selectedSchema.value || props.database, row.type, row.name, newName]);+ const drafts = { ...routineRenameDrafts.value };+ viewRenameLoading.value = true;+ try {+ const plan = await prepareOracleRoutineRename(+ {+ connectionId: props.connection.id,+ database: props.database,+ databaseType: effectiveDatabaseType.value as "oracle" | "oceanbase-oracle",+ schema: row.schema || selectedSchema.value || props.database,+ objectType: row.type,+ oldName: row.name,+ newName,+ },+ drafts,+ );+ if (+ requestId === renamePreviewRequestId &&+ showRenameDialog.value &&+ renameTarget.value === row &&+ targetKey === JSON.stringify([props.connection.id, props.database, effectiveDatabaseType.value, row.schema || selectedSchema.value || props.database, row.type, row.name, renameInput.value.trim()]) &&+ JSON.stringify(drafts) === JSON.stringify(routineRenameDrafts.value)+ ) {+ routineRenamePlan.value = plan;+ renameError.value = "";+ renamePreviewSqlText.value = plan.statements.join("\n\n");+ }+ } catch (error) {+ if (requestId === renamePreviewRequestId) renameError.value = error instanceof Error ? error.message : String(error);+ } finally {+ if (requestId === renamePreviewRequestId) viewRenameLoading.value = false;+ }return;}if (supportsSourceBackedRoutineRename(effectiveDatabaseType.value, row.type as ObjectSourceKind)) {- renamePreviewSqlText.value = `-- Recreate ${row.type} from source, then drop the original object.`;+ renamePreviewSqlText.value = t("objects.routineRenamePreview");+ return;+ }+ if ((effectiveDatabaseType.value === "oracle" || effectiveDatabaseType.value === "oceanbase-oracle") && row.type === "TABLE") {+ viewRenameLoading.value = true;+ try {+ const plan = await prepareOracleTableRename({ connectionId: props.connection.id, database: props.database, databaseType: effectiveDatabaseType.value, schema: row.schema || selectedSchema.value || props.database, oldName: row.name, newName }, tableRenameDrafts.value);+ if (requestId === renamePreviewRequestId) {+ tableRenamePlan.value = plan;+ renameError.value = "";+ renamePreviewSqlText.value = `-- ${t("objects.tableRenameCoverage")}\n\n${plan.statements.join("\n\n")}`;+ }+ } catch (error) {+ if (requestId === renamePreviewRequestId) renameError.value = error instanceof Error ? error.message : String(error);+ } finally {+ if (requestId === renamePreviewRequestId) viewRenameLoading.value = false;+ }return;}try {+ if (effectiveDatabaseType.value === "oceanbase-oracle" && row.type === "VIEW") {+ viewRenameLoading.value = true;+ const plan = await prepareOracleViewRename({ connectionId: props.connection.id, database: props.database, schema: row.schema || selectedSchema.value || props.database, oldName: row.name, newName }, viewRenameDrafts.value);+ if (requestId === renamePreviewRequestId) {+ viewRenamePlan.value = plan;+ renameError.value = "";+ renamePreviewSqlText.value = `-- ${t("objects.viewRenameCoverage")}\n\n${plan.statements.join("\n\n")}`;+ }+ return;+ }const sql = await buildRenameObjectSql({databaseType: effectiveDatabaseType.value,objectType: row.type,@@ -1851,26 +2127,145 @@ async function refreshRenamePreviewSql() {newName,});if (requestId === renamePreviewRequestId) renamePreviewSqlText.value = sql;- } catch {- if (requestId === renamePreviewRequestId) renamePreviewSqlText.value = "";+ } catch (error) {+ if (requestId === renamePreviewRequestId) {+ renamePreviewSqlText.value = "";+ if (effectiveDatabaseType.value === "oceanbase-oracle" && row.type === "VIEW") renameError.value = error instanceof Error ? error.message : String(error);+ }+ } finally {+ if (requestId === renamePreviewRequestId) viewRenameLoading.value = false;+ }+}++function editViewRenameDraft(name: string, source: string) {+ viewRenameDrafts.value = { ...viewRenameDrafts.value, [name]: source };+ if (viewRenamePlan.value) viewRenamePlan.value = { ...viewRenamePlan.value, executable: false };+}++function editTableRenameDraft(name: string, source: string) {+ tableRenameDrafts.value = { ...tableRenameDrafts.value, [name]: source };+ if (tableRenamePlan.value) tableRenamePlan.value = { ...tableRenamePlan.value, executable: false };+}++function editRoutineRenameDraft(name: string, source: string) {+ routineRenameDrafts.value = { ...routineRenameDrafts.value, [name]: source };+ ++renamePreviewRequestId;+ if (routineRenamePlan.value) routineRenamePlan.value = { ...routineRenamePlan.value, executable: false };+}++async function validateRoutineRenameDrafts() {+ if (routineRenamePlan.value) routineRenamePlan.value = { ...routineRenamePlan.value, executable: false };+ viewRenameValidating.value = true;+ try {+ await refreshRenamePreviewSql();+ } finally {+ viewRenameValidating.value = false;+ }+}++async function validateTableRenameDrafts(clearDrafts = false) {+ if (clearDrafts) tableRenameDrafts.value = {};+ viewRenameValidating.value = true;+ try {+ await refreshRenamePreviewSql();+ } finally {+ viewRenameValidating.value = false;+ }+}++async function validateViewRenameDrafts(clearDrafts = false) {+ const row = renameTarget.value;+ if (!row) return;+ if (clearDrafts) viewRenameDrafts.value = {};+ viewRenameValidating.value = true;+ try {+ await refreshRenamePreviewSql();+ } finally {+ viewRenameValidating.value = false;}}-watch([showRenameDialog, renameTarget, renameInput, selectedSchema], () => {- void refreshRenamePreviewSql();+watch([showRenameDialog, renameTarget, renameInput, selectedSchema, () => props.connection.id, () => props.database], (_value, _oldValue, onCleanup) => {+ ++renamePreviewRequestId;+ const row = renameTarget.value;+ const targetKey = row && (row.type === "VIEW" || row.type === "PROCEDURE" || row.type === "FUNCTION" || row.type === "TABLE") ? JSON.stringify([props.connection.id, props.database, effectiveDatabaseType.value, row.schema || selectedSchema.value || props.database, row.type, row.name]) : "";+ if (targetKey !== currentViewRenameTargetKey) {+ currentViewRenameTargetKey = targetKey;+ viewRenameDrafts.value = {};+ viewRenamePlan.value = undefined;+ routineRenamePlan.value = undefined;+ tableRenamePlan.value = undefined;+ routineRenameDrafts.value = {};+ tableRenameDrafts.value = {};+ } else if (viewRenamePlan.value) viewRenamePlan.value = { ...viewRenamePlan.value, executable: false };+ if (routineRenamePlan.value) routineRenamePlan.value = { ...routineRenamePlan.value, executable: false };+ if ((effectiveDatabaseType.value !== "oracle" && effectiveDatabaseType.value !== "oceanbase-oracle") || (renameTarget.value?.type !== "VIEW" && renameTarget.value?.type !== "PROCEDURE" && renameTarget.value?.type !== "FUNCTION" && renameTarget.value?.type !== "TABLE")) {+ viewRenamePlan.value = undefined;+ routineRenamePlan.value = undefined;+ tableRenamePlan.value = undefined;+ void refreshRenamePreviewSql();+ return;+ }+ const timer = setTimeout(() => void refreshRenamePreviewSql(), 250);+ onCleanup(() => clearTimeout(timer));});async function confirmRename() {const row = renameTarget.value;- const newName = renameInput.value.trim();+ let newName = renameInput.value.trim();if (!row || !newName || newName === row.name) return;renameError.value = "";const oldPinnedNode = pinnedTreeNodeForObjectBrowserRow(row);const oldLegacyPinnedNodes = legacyPinnedTreeNodesForObjectBrowserRow(row);let renameApplied = false;+ let updatedViewDependencies: number | undefined;+ let updatedTableDependencies: number | undefined;+ let tableRenameFreeze: ReturnType<typeof freezeSourceIdentities> | undefined;try {const schema = row.schema || selectedSchema.value || props.database;- if (supportsSourceBackedRoutineRename(effectiveDatabaseType.value, row.type as ObjectSourceKind)) {+ if (row.type === "TABLE" && effectiveDatabaseType.value === "dameng") {+ tableRenameFreeze = freezeSourceIdentities([{ connectionId: props.connection.id, database: props.database, schema, objectType: "TABLE", name: row.name }]);+ }+ if ((effectiveDatabaseType.value === "oracle" || effectiveDatabaseType.value === "oceanbase-oracle") && row.type === "TABLE") {+ const plan = tableRenamePlan.value;+ if (!plan || plan.target.newName !== newName || plan.target.oldName !== row.name || plan.target.schema !== schema || plan.target.connectionId !== props.connection.id || plan.target.database !== props.database) throw new Error(t("objects.viewRenameRefresh"));+ if (!plan.executable) throw new Error(t("objects.viewRenameValidationPending"));+ viewRenameExecuting.value = true;+ const executed = await executeObjectBrowserSqlWithProductionGuard(plan.statements.join("\n\n"), async () => {+ await executeOracleTableRename(+ plan,+ tableRenameDrafts.value,+ () => tableRenamePlan.value === plan && showRenameDialog.value && props.connection.id === plan.target.connectionId && props.database === plan.target.database && (row.schema || selectedSchema.value || props.database) === plan.target.schema,+ );+ return true;+ });+ if (!executed) return;+ newName = plan.canonicalNewName;+ updatedTableDependencies = plan.dependents.length;+ } else if (effectiveDatabaseType.value === "oceanbase-oracle" && row.type === "VIEW") {+ const plan = viewRenamePlan.value;+ if (!plan || plan.target.newName !== newName || plan.target.oldName !== row.name || plan.target.schema !== schema || plan.target.connectionId !== props.connection.id || plan.target.database !== props.database) throw new Error(t("objects.viewRenameRefresh"));+ if (!plan.executable) throw new Error(t("objects.viewRenameValidationPending"));+ viewRenameExecuting.value = true;+ const executed = await executeObjectBrowserSqlWithProductionGuard(plan.statements.join("\n"), async () => {+ await executeOracleViewRename(plan, () => viewRenamePlan.value === plan && showRenameDialog.value && props.connection.id === plan.target.connectionId && props.database === plan.target.database && (row.schema || selectedSchema.value || props.database) === plan.target.schema);+ return true;+ });+ if (!executed) return;+ newName = plan.canonicalNewName;+ updatedViewDependencies = plan.views.length - 1;+ } else if ((effectiveDatabaseType.value === "oracle" || effectiveDatabaseType.value === "oceanbase-oracle") && (row.type === "PROCEDURE" || row.type === "FUNCTION")) {+ const plan = routineRenamePlan.value;+ if (!plan || plan.target.newName !== newName || plan.target.oldName !== row.name || plan.target.schema !== schema || plan.target.connectionId !== props.connection.id || plan.target.database !== props.database) throw new Error(t("objects.viewRenameRefresh"));+ if (!plan.executable) throw new Error(t("objects.viewRenameValidationPending"));+ viewRenameExecuting.value = true;+ const executed = await executeObjectBrowserSqlWithProductionGuard(plan.statements.join("\n\n"), async () => {+ await executeOracleRoutineRename(plan, () => routineRenamePlan.value === plan && showRenameDialog.value && props.connection.id === plan.target.connectionId && props.database === plan.target.database && (row.schema || selectedSchema.value || props.database) === plan.target.schema);+ return true;+ });+ if (!executed) return;+ newName = plan.canonicalNewName;+ } else if (supportsSourceBackedRoutineRename(effectiveDatabaseType.value, row.type as ObjectSourceKind)) {const source = await api.getObjectSource(props.connection.id, props.database, schema, row.name, row.type as ObjectSourceKind, row.signature ?? undefined);const statements = await buildRoutineRenameObjectSourceStatements({databaseType: effectiveDatabaseType.value,@@ -1895,11 +2290,20 @@ async function confirmRename() {oldName: row.name,newName,});- const executed = await executeObjectBrowserSqlWithProductionGuard(sql, () => api.executeQuery(props.connection.id, props.database, sql, schema));+ const executed = await executeObjectBrowserSqlWithProductionGuard(sql, () => {+ tableRenameFreeze?.markDispatched();+ return api.executeQuery(props.connection.id, props.database, sql, schema);+ });if (!executed) return;}renameApplied = true;- toast(t("contextMenu.renameObjectSuccess", { oldName: row.name, newName }));+ toast(+ updatedTableDependencies !== undefined+ ? t("objects.tableRenameSuccess", { oldName: row.name, newName, count: updatedTableDependencies })+ : updatedViewDependencies === undefined+ ? t("contextMenu.renameObjectSuccess", { oldName: row.name, newName })+ : t("objects.viewRenameSuccess", { oldName: row.name, newName, count: updatedViewDependencies }),+ );showRenameDialog.value = false;if (sourceRow.value?.id === row.id) closeSource();const renamedTarget = { ...oldPinnedNode, label: newName, objectName: newName, tableName: newName };@@ -1919,12 +2323,30 @@ async function confirmRename() {connectionStore.removePinnedTreeNodes([oldPinnedNode, ...oldLegacyPinnedNodes], canonicalizeObjectBrowserPinnedIdentity);}} catch (e: any) {+ if (e instanceof OracleViewRenameFailure) {+ connectionStore.removePinnedTreeNodes([oldPinnedNode, ...oldLegacyPinnedNodes], canonicalizeObjectBrowserPinnedIdentity);+ renamePreviewSqlText.value += `\n\n-- ${t("objects.viewRenameRecovery")}\n${e.plan.views.map((view) => view.source).join("\n\n")}`;+ }+ if (e instanceof OracleRoutineRenameFailure) {+ renameError.value = e.message;+ if (routineRenamePlan.value) routineRenamePlan.value = { ...routineRenamePlan.value, executable: false };+ }+ if (e instanceof OracleTableRenameFailure) {+ renameError.value = e.message;+ if (tableRenamePlan.value) tableRenamePlan.value = { ...tableRenamePlan.value, executable: false };+ if (e.completed.some((step) => step.startsWith("TABLE "))) connectionStore.removePinnedTreeNodes([oldPinnedNode, ...oldLegacyPinnedNodes], canonicalizeObjectBrowserPinnedIdentity);+ }+ if (viewRenamePlan.value) viewRenamePlan.value = { ...viewRenamePlan.value, executable: false, issues: [...viewRenamePlan.value.issues, { code: "metadata_drift", message: e?.message || String(e), repairable: false }] };if (renameApplied) {// The database mutation succeeded even when metadata refresh did not;// remove the old pin instead of allowing it to revive later.connectionStore.removePinnedTreeNodes([oldPinnedNode, ...oldLegacyPinnedNodes], canonicalizeObjectBrowserPinnedIdentity);}renameError.value = e?.message || String(e);+ } finally {+ tableRenameFreeze?.cancel();+ tableRenameFreeze?.finish();+ viewRenameExecuting.value = false;}}@@ -3284,6 +3706,7 @@ function cancelEditSource() {}async function saveSource() {+ if (sourceSaving.value || sourceLoading.value) return;if (!sourceCanEdit.value) {toast(t("objects.sourceReadOnly"), 3000);return;@@ -3294,31 +3717,43 @@ async function saveSource() {const connectionId = props.connection.id;const database = props.database;const schema = row.schema || selectedSchema.value || database;+ const connection = props.connection;+ const databaseType = effectiveDatabaseType.value;sourceSaving.value = true;sourceSaveError.value = "";try {+ if (!sourceIdentity) return;+ const identity = sourceIdentity;+ assertSourceIdentity(identity);const statements = await buildExecutableObjectSourceStatements({- databaseType: effectiveDatabaseType.value,+ databaseType,objectType: row.type as ObjectSourceKind,schema,name: row.name,source: sourceDraft.value,});+ const execute = async () => {+ if (sidePanelGuard.isStale(epoch) || sourceRow.value !== row) return false;+ const release = beginSourceSave(identity);+ try {+ await executeObjectSourceSave(connectionId, database, databaseType, statements, schema);+ return true;+ } finally {+ release();+ }+ };const executableSql = statements.filter((sql) => sql.trim()).join(";\n");if (executableSql.trim()) {const saved = await executeWithProductionSqlGuard({- connection: props.connection,+ connection,database,sql: executableSql,source: t("production.sourceObjectSource"),- execute: async () => {- await executeObjectSourceSave(connectionId, database, effectiveDatabaseType.value, statements, schema);- return true;- },+ execute,});if (!saved || sidePanelGuard.isStale(epoch)) return;} else {- await executeObjectSourceSave(connectionId, database, effectiveDatabaseType.value, statements, schema);+ if (!(await execute())) return;if (sidePanelGuard.isStale(epoch)) return;}toast(t("objects.sourceSaved"));@@ -3327,7 +3762,7 @@ async function saveSource() {await openSource(row);} catch (e: unknown) {if (sidePanelGuard.isStale(epoch)) return;- sourceSaveError.value = formatObjectSourceSaveError(e, effectiveDatabaseType.value, row.type as ObjectSourceKind, t("objects.postgresViewColumnChangeHint"));+ sourceSaveError.value = formatObjectSourceSaveError(e, databaseType, row.type as ObjectSourceKind, t("objects.postgresViewColumnChangeHint"));} finally {if (sidePanelGuard.isFresh(epoch)) sourceSaving.value = false;}@@ -4023,6 +4458,7 @@ function getEventMenuItems(item: ObjectBrowserRow): ContextMenuItem[] {function getPackageMenuItems(item: ObjectBrowserRow): ContextMenuItem[] {return [+ ...((effectiveDatabaseType.value === "oracle" || effectiveDatabaseType.value === "oceanbase-oracle") && (item.type === "PACKAGE" || item.type === "PACKAGE_BODY") ? [{ label: t("objects.packageSaveAsTitle"), action: () => requestPackageSaveAs(item), icon: CopyPlus }] : []),...(effectiveDatabaseType.value === "xugu" && buildXuguCompileSql({ objectType: item.type, schema: item.schema || selectedSchema.value, name: item.name }) ? [{ label: t("contextMenu.compileObject"), action: () => compileXuguObject(item), icon: Wrench }] : []),{ label: t("contextMenu.viewSource"), action: () => openSource(item), icon: Code2 },{ label: "", separator: true },@@ -4851,19 +5287,82 @@ function getObjectBrowserMenuItems(item: ObjectBrowserRow): ContextMenuItem[] {@confirm="confirmBatchEmptyTables"/>+ <OraclePackageSaveAsDialog+ :open="packageSaveAsOpen"+ :old-name="packageSaveAsTarget?.name || ''"+ :new-name="packageSaveAsName"+ :plan="packageSaveAsPlan || null"+ :drafts="packageSaveAsDrafts"+ :error="packageSaveAsError"+ :diagnostic="packageSaveAsDiagnostic"+ :loading="packageSaveAsLoading"+ :validating="packageSaveAsValidating"+ :executing="packageSaveAsExecuting"+ @update:open="packageSaveAsOpen = $event"+ @update:new-name="packageSaveAsName = $event"+ @edit="editPackageSaveAsDraft"+ @validate="validatePackageSaveAsDrafts"+ @reload="validatePackageSaveAsDrafts"+ @confirm="confirmPackageSaveAs"+ /><Dialog v-model:open="showRenameDialog">- <DialogContent class="sm:max-w-[420px]">+ <DialogContent+ :class="(effectiveDatabaseType === 'oracle' || effectiveDatabaseType === 'oceanbase-oracle') && (renameTarget?.type === 'VIEW' || renameTarget?.type === 'PROCEDURE' || renameTarget?.type === 'FUNCTION' || renameTarget?.type === 'TABLE') ? 'sm:max-w-[min(90vw,900px)]' : 'sm:max-w-[420px]'"+ ><DialogHeader><DialogTitle>{{ t("contextMenu.renameObjectTitle") }}</DialogTitle></DialogHeader><div class="grid gap-3"><Input v-model="renameInput" :placeholder="t('contextMenu.renameObjectNamePlaceholder')" @keydown.enter.prevent="confirmRename" />- <pre v-if="renamePreviewSqlText" class="max-h-32 min-w-0 max-w-full overflow-auto rounded bg-muted p-3 text-xs whitespace-pre-wrap" v-html="highlight(renamePreviewSqlText)"></pre>+ <OracleViewRenamePreview+ v-if="effectiveDatabaseType === 'oceanbase-oracle' && renameTarget?.type === 'VIEW'"+ :plan="viewRenamePlan || null"+ :drafts="viewRenameDrafts"+ :loading="viewRenameLoading"+ :validating="viewRenameValidating"+ :executing="viewRenameExecuting"+ @edit="editViewRenameDraft"+ @validate="validateViewRenameDrafts()"+ @reload="validateViewRenameDrafts()"+ />+ <OracleRoutineRenamePreview+ v-else-if="(effectiveDatabaseType === 'oracle' || effectiveDatabaseType === 'oceanbase-oracle') && (renameTarget?.type === 'PROCEDURE' || renameTarget?.type === 'FUNCTION')"+ :plan="routineRenamePlan || null"+ :drafts="routineRenameDrafts"+ :loading="viewRenameLoading"+ :validating="viewRenameValidating"+ :executing="viewRenameExecuting"+ @edit="editRoutineRenameDraft"+ @validate="validateRoutineRenameDrafts"+ @reload="refreshRenamePreviewSql()"+ />+ <OracleTableRenamePreview+ v-else-if="(effectiveDatabaseType === 'oracle' || effectiveDatabaseType === 'oceanbase-oracle') && renameTarget?.type === 'TABLE'"+ :plan="tableRenamePlan || null"+ :drafts="tableRenameDrafts"+ :loading="viewRenameLoading"+ :validating="viewRenameValidating"+ :executing="viewRenameExecuting"+ @edit="editTableRenameDraft"+ @validate="validateTableRenameDrafts()"+ @reload="validateTableRenameDrafts()"+ />+ <pre v-else-if="renamePreviewSqlText" class="max-h-32 min-w-0 max-w-full overflow-auto rounded bg-muted p-3 text-xs whitespace-pre-wrap" v-html="highlight(renamePreviewSqlText)"></pre><p v-if="renameError" class="min-w-0 max-w-full overflow-x-auto text-sm text-destructive">{{ renameError }}</p></div><DialogFooter><Button variant="outline" @click="showRenameDialog = false">{{ t("dangerDialog.cancel") }}</Button>- <Button :disabled="!renameInput.trim() || renameInput.trim() === renameTarget?.name" @click="confirmRename">+ <Button+ :disabled="+ !renameInput.trim() ||+ renameInput.trim() === renameTarget?.name ||+ viewRenameExecuting ||+ ((effectiveDatabaseType === 'oracle' || effectiveDatabaseType === 'oceanbase-oracle') && renameTarget?.type === 'TABLE' && !tableRenamePlan?.executable) ||+ (effectiveDatabaseType === 'oceanbase-oracle' && renameTarget?.type === 'VIEW' && !viewRenamePlan?.executable) ||+ ((effectiveDatabaseType === 'oracle' || effectiveDatabaseType === 'oceanbase-oracle') && (renameTarget?.type === 'PROCEDURE' || renameTarget?.type === 'FUNCTION') && !routineRenamePlan?.executable)+ "+ @click="confirmRename"+ >{{ t("contextMenu.renameObject") }}</Button></DialogFooter>diff --git a/apps/desktop/src/components/objects/ObjectSourceDialog.vue b/apps/desktop/src/components/objects/ObjectSourceDialog.vueindex c954578dff..12c1bb90f7 100644--- a/apps/desktop/src/components/objects/ObjectSourceDialog.vue+++ b/apps/desktop/src/components/objects/ObjectSourceDialog.vue@@ -9,6 +9,7 @@ import { copyToClipboard } from "@/lib/common/clipboard";import { formatSqlForDisplay, type SqlFormatDialect } from "@/lib/sql/sqlFormatter";import { buildEditableObjectSource, buildExecutableObjectSourceStatements, executeObjectSourceSave, formatObjectSourceSaveError, resolveObjectSourceEditDraft } from "@/lib/table/objectSourceEditor";import { loadObjectSourceWithRoutineFallback } from "@/lib/table/objectSourceLoad";+import { assertSourceIdentity, beginSourceSave, captureSourceIdentity, renewSourceIdentity, type SourceIdentitySnapshot } from "@/lib/table/objectSourceIdentity";import { jdbcRoutineMetadata, xuguRoutineMetadataFromDefinition, type RoutineMetadata } from "@/lib/table/routineParameters";import { executeWithProductionSqlGuard } from "@/lib/database/productionExecutionGuard";import * as api from "@/lib/backend/api";@@ -61,6 +62,7 @@ const routineMetadata = ref<RoutineMetadata | null>(null);/** May differ from props.objectType after PROCEDURE/FUNCTION/PACKAGE fallback resolution. */const resolvedObjectType = ref<ObjectSourceKind>(props.objectType);let loadSerial = 0;+let sourceIdentity: SourceIdentitySnapshot | undefined;onBeforeUnmount(() => {++loadSerial;});@@ -81,6 +83,8 @@ watch(async function loadSource(nextEditing = props.initialEditing && canEdit.value) {const serial = ++loadSerial;const target = { ...props };+ const identity = captureSourceIdentity({ ...target, schema: target.schema || target.database });+ sourceIdentity = undefined;saving.value = false;content.value = "";editableText.value = "";@@ -117,6 +121,9 @@ async function loadSource(nextEditing = props.initialEditing && canEdit.value) {const displaySource = resolvedType === "SEQUENCE" ? result.source : editable;const formatted = await formatSqlForDisplay(displaySource, target.formatDialect ?? target.dialect, settingsStore.editorSettings.sqlFormatter);if (serial !== loadSerial) return;+ const renewed = renewSourceIdentity(identity);+ sourceIdentity = resolvedType === target.objectType ? renewed : captureSourceIdentity({ ...identity, objectType: resolvedType });+ assertSourceIdentity(sourceIdentity);editableText.value = editable;content.value = formatted;draft.value = nextEditing && canEdit.value ? resolveObjectSourceEditDraft(props.databaseType, resolvedType, formatted, editable) : "";@@ -180,6 +187,9 @@ async function saveSource() {saving.value = true;saveError.value = "";try {+ if (!sourceIdentity) return;+ const identity = sourceIdentity;+ assertSourceIdentity(identity);const statements = await buildExecutableObjectSourceStatements({databaseType,objectType,@@ -189,21 +199,27 @@ async function saveSource() {});if (serial !== loadSerial) return;const executableSql = statements.filter((sql) => sql.trim()).join(";\n");+ const execute = async () => {+ if (serial !== loadSerial || !props.open) return false;+ const release = beginSourceSave(identity);+ try {+ await executeObjectSourceSave(connectionId, database, databaseType, statements, schema);+ return true;+ } finally {+ release();+ }+ };if (executableSql.trim()) {const saved = await executeWithProductionSqlGuard({connection: connectionStore.getConfig(connectionId),database,sql: executableSql,source: t("production.sourceObjectSource"),- execute: async () => {- if (serial !== loadSerial || !props.open) return false;- await executeObjectSourceSave(connectionId, database, databaseType, statements, schema);- return true;- },+ execute,});if (!saved) return;} else {- await executeObjectSourceSave(connectionId, database, databaseType, statements, schema);+ if (!(await execute())) return;}if (serial !== loadSerial) return;toast(t("objects.sourceSaved"));diff --git a/apps/desktop/src/components/objects/OraclePackageSaveAsDialog.vue b/apps/desktop/src/components/objects/OraclePackageSaveAsDialog.vuenew file mode 100644index 0000000000..c368f3cfb0--- /dev/null+++ b/apps/desktop/src/components/objects/OraclePackageSaveAsDialog.vue@@ -0,0 +1,115 @@+<script setup lang="ts">+import { computed } from "vue";+import { useI18n } from "vue-i18n";+import { Button } from "@/components/ui/button";+import { Input } from "@/components/ui/input";+import { Dialog, DialogContent, DialogFooter, DialogHeader, DialogTitle } from "@/components/ui/dialog";+import type { OraclePackageSaveAsPlan } from "@/lib/table/oraclePackageSaveAs";++const props = defineProps<{+ open: boolean;+ oldName: string;+ newName: string;+ plan: OraclePackageSaveAsPlan | null;+ drafts: { spec?: string; body?: string };+ error: string;+ diagnostic: string;+ loading: boolean;+ validating: boolean;+ executing: boolean;+}>();+const emit = defineEmits<{+ "update:open": [value: boolean];+ "update:newName": [value: string];+ edit: [part: "spec" | "body", source: string];+ validate: [];+ reload: [];+ confirm: [];+}>();+const { t } = useI18n();+const busy = computed(() => props.loading || props.validating || props.executing);+const currentSpecDraft = computed(() => (props.drafts.spec ?? props.plan?.specDraft) === props.plan?.specDraft);+const currentBodyDraft = computed(() => (props.drafts.body ?? props.plan?.bodyDraft) === props.plan?.bodyDraft);+function edit(part: "spec" | "body", event: Event) {+ emit("edit", part, (event.target as HTMLTextAreaElement).value);+}+</script>++<template>+ <Dialog :open="open" @update:open="emit('update:open', $event)">+ <DialogContent class="sm:max-w-[min(90vw,900px)]">+ <DialogHeader>+ <DialogTitle>{{ t("objects.packageSaveAsTitle") }}</DialogTitle>+ </DialogHeader>+ <div class="grid gap-3">+ <p class="text-sm text-muted-foreground">{{ t("objects.packageSaveAsHint", { name: oldName }) }}</p>+ <Input :model-value="newName" :placeholder="t('contextMenu.renameObjectNamePlaceholder')" :disabled="busy" @update:model-value="emit('update:newName', $event)" />+ <p v-if="loading || validating" role="status" class="text-sm text-muted-foreground">{{ t("common.loading") }}</p>+ <div v-if="plan" class="grid gap-2">+ <p v-if="!plan.metadataComplete" class="text-sm text-destructive">{{ t("objects.packageSaveAsMetadataProblem") }}</p>+ <ul v-if="plan.issues.length" class="list-disc space-y-1 pl-5 text-sm text-destructive" aria-live="polite">+ <li v-for="(issue, index) in plan.issues" :key="index">+ {{ issue.objectName || t("objects.packageSaveAsMetadataProblem") }} · {{ issue.repairable ? t("objects.viewRenameNeedsRepair") : t("objects.packageSaveAsMetadataProblem") }}+ <details class="mt-1 text-xs text-muted-foreground">+ <summary class="cursor-pointer">{{ t("objects.viewRenameDiagnostics") }}</summary>+ <pre class="mt-1 whitespace-pre-wrap break-all">{{ issue.message }}</pre>+ </details>+ </li>+ </ul>+ <p v-if="plan.snapshot" class="text-xs text-muted-foreground">+ {{ t("objects.package") }} · {{ plan.target.schema }}.{{ plan.target.oldName }}+ <span v-if="plan.bodySource !== null"> · {{ t("objects.packageBody") }}</span>+ </p>+ <label v-if="plan.snapshot" class="grid gap-1 text-xs text-muted-foreground">+ <span>{{ t("objects.package") }} · {{ plan.target.schema }}.{{ plan.target.oldName }}</span>+ <textarea+ :value="drafts.spec ?? plan.specDraft"+ :disabled="busy"+ spellcheck="false"+ rows="8"+ class="w-full resize-y rounded border border-input bg-background p-2 font-mono text-xs leading-relaxed text-foreground focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring disabled:cursor-not-allowed disabled:opacity-50"+ data-source-draft="spec"+ @input="edit('spec', $event)"+ />+ </label>+ <label v-if="plan.bodyDraft !== null" class="grid gap-1 text-xs text-muted-foreground">+ <span>{{ t("objects.packageBody") }} · {{ plan.target.schema }}.{{ plan.target.oldName }}</span>+ <textarea+ :value="drafts.body ?? plan.bodyDraft"+ :disabled="busy"+ spellcheck="false"+ rows="10"+ class="w-full resize-y rounded border border-input bg-background p-2 font-mono text-xs leading-relaxed text-foreground focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring disabled:cursor-not-allowed disabled:opacity-50"+ data-source-draft="body"+ @input="edit('body', $event)"+ />+ </label>+ <div v-if="plan.specSource && currentSpecDraft" class="grid gap-1">+ <p class="text-xs text-muted-foreground">{{ t("objects.viewRenameFinalSql") }} · {{ t("objects.package") }}</p>+ <pre class="max-h-48 overflow-auto whitespace-pre-wrap break-all rounded bg-muted p-2 font-mono text-xs">{{ plan.specSource }}</pre>+ </div>+ <div v-if="plan.bodySource && currentBodyDraft" class="grid gap-1">+ <p class="text-xs text-muted-foreground">{{ t("objects.viewRenameFinalSql") }} · {{ t("objects.packageBody") }}</p>+ <pre class="max-h-48 overflow-auto whitespace-pre-wrap break-all rounded bg-muted p-2 font-mono text-xs">{{ plan.bodySource }}</pre>+ </div>+ <div class="flex flex-wrap gap-2">+ <Button type="button" variant="outline" size="sm" :disabled="busy || !plan.snapshot" data-validate @click="emit('validate')">{{ t("objects.viewRenameValidate") }}</Button>+ <Button type="button" variant="outline" size="sm" :disabled="busy" data-reload @click="emit('reload')">{{ t("objects.viewRenameReload") }}</Button>+ </div>+ <pre v-if="plan.executable && currentSpecDraft && currentBodyDraft && plan.statements.length" class="max-h-72 overflow-auto whitespace-pre-wrap break-all rounded bg-muted p-3 font-mono text-xs">{{ plan.statements.join("\n\n") }}</pre>+ </div>+ <p v-if="error" class="break-words text-sm text-destructive">{{ error }}</p>+ <details v-if="diagnostic" class="text-xs text-muted-foreground">+ <summary class="cursor-pointer">{{ t("objects.viewRenameDiagnostics") }}</summary>+ <pre class="mt-1 whitespace-pre-wrap break-all">{{ diagnostic }}</pre>+ </details>+ </div>+ <DialogFooter>+ <Button variant="outline" :disabled="executing" @click="emit('update:open', false)">{{ t("dangerDialog.cancel") }}</Button>+ <Button data-confirm :disabled="busy || !plan?.executable || !newName.trim() || newName.trim() === oldName" @click="emit('confirm')">+ {{ t("objects.packageSaveAsTitle") }}+ </Button>+ </DialogFooter>+ </DialogContent>+ </Dialog>+</template>diff --git a/apps/desktop/src/components/objects/OracleRoutineRenamePreview.vue b/apps/desktop/src/components/objects/OracleRoutineRenamePreview.vuenew file mode 100644index 0000000000..6a60798ecc--- /dev/null+++ b/apps/desktop/src/components/objects/OracleRoutineRenamePreview.vue@@ -0,0 +1,97 @@+<script setup lang="ts">+import { computed } from "vue";+import { useI18n } from "vue-i18n";+import { Button } from "@/components/ui/button";+import type { OracleRoutineRenamePlan } from "@/lib/table/oracleRoutineRename";++const props = defineProps<{ plan: OracleRoutineRenamePlan | null; drafts: Record<string, string>; loading: boolean; validating: boolean; executing: boolean }>();+const emit = defineEmits<{ edit: [key: string, source: string]; validate: []; reload: [] }>();+const { t } = useI18n();+const busy = computed(() => props.loading || props.validating || props.executing);+const entries = computed(() => {+ const plan = props.plan;+ if (!plan) return [];+ const root = plan.root ? [{ key: `${plan.root.objectType}:${plan.root.name}`, name: plan.root.name, objectType: plan.root.objectType, source: plan.root.source, draft: plan.rootDraft, generated: plan.rootCreateSource, rewriteRequired: true }] : [];+ return [+ ...root,+ ...plan.callers.map((caller) => ({ key: `${caller.objectType}:${caller.name}`, name: caller.name, objectType: caller.objectType, source: caller.source, draft: caller.draft, generated: caller.rewriteRequired ? caller.rewrittenSource : "", rewriteRequired: caller.rewriteRequired })),+ ];+});+const assignedIssues = computed(() => new Set(entries.value.map((entry) => entry.name)));+const statementsCurrent = computed(() => !!props.plan && entries.value.every((entry) => isCurrentDraft(entry.key, entry.draft)));+function isCurrentDraft(key: string, validatedDraft: string) {+ return (props.drafts[key] ?? validatedDraft) === validatedDraft;+}+function edit(key: string, event: Event) {+ emit("edit", key, (event.target as HTMLTextAreaElement).value);+}+</script>++<template>+ <section class="space-y-3 text-sm" :aria-busy="busy">+ <p class="text-xs leading-relaxed text-muted-foreground">{{ t("objects.routineRenameCoverage") }}</p>+ <p v-if="loading || validating" role="status" class="text-muted-foreground">{{ t("common.loading") }}</p>+ <p v-else-if="!plan?.executable" role="status" class="text-destructive">{{ t("objects.viewRenameValidationPending") }}</p>+ <div v-if="plan?.root" class="rounded border border-border p-3">+ <p class="mb-2 font-medium">{{ t("objects.routineRenameObjects") }}</p>+ <ul class="space-y-1 text-xs text-muted-foreground">+ <li>{{ plan.target.objectType }} · {{ plan.target.schema }}.{{ plan.target.oldName }} → {{ plan.target.schema }}.{{ plan.canonicalNewName }}</li>+ <li v-for="caller in plan.callers" :key="`${caller.objectType}:${caller.name}`">{{ caller.objectType }} · {{ plan.target.schema }}.{{ caller.name }} · {{ t(caller.rewriteRequired ? "objects.routineRenameRewrite" : "objects.routineRenameCompile") }}</li>+ </ul>+ </div>+ <ul v-if="plan?.issues.some((issue) => !issue.objectName || !assignedIssues.has(issue.objectName))" class="space-y-2" aria-live="polite">+ <li v-for="(issue, index) in plan.issues.filter((item) => !item.objectName || !assignedIssues.has(item.objectName))" :key="index" class="rounded border border-destructive/40 p-2">+ <p class="font-medium text-destructive">{{ issue.objectName || plan.target.oldName }} · {{ t("objects.viewRenameNeedsRepair") }}</p>+ <p v-if="!issue.repairable" class="text-xs text-destructive">{{ t("objects.viewRenameMetadataProblem") }}</p>+ <details class="mt-1 text-xs text-muted-foreground" data-diagnostics>+ <summary class="cursor-pointer">{{ t("objects.viewRenameDiagnostics") }}</summary>+ <pre class="mt-1 whitespace-pre-wrap break-all">{{ issue.message }}</pre>+ </details>+ </li>+ </ul>+ <details v-for="entry in entries" :key="entry.key" :open="plan?.issues.some((issue) => issue.objectName === entry.name)" class="rounded border border-border" :data-source-name="entry.key">+ <summary class="flex cursor-pointer items-center justify-between gap-3 px-3 py-2 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring">+ <span class="min-w-0 break-all font-medium">{{ entry.objectType }} · {{ entry.name }}</span>+ <span class="shrink-0 rounded bg-muted px-2 py-0.5 text-xs" :class="plan?.issues.some((issue) => issue.objectName === entry.name) ? 'text-destructive' : 'text-muted-foreground'">+ {{ t(plan?.issues.some((issue) => issue.objectName === entry.name) ? "objects.viewRenameNeedsRepair" : "objects.viewRenameDefinitionReady") }}+ </span>+ </summary>+ <div class="space-y-3 border-t border-border p-3">+ <ul v-if="plan?.issues.some((issue) => issue.objectName === entry.name)" class="space-y-2" aria-live="polite">+ <li v-for="(issue, index) in plan.issues.filter((item) => item.objectName === entry.name)" :key="index" class="space-y-1">+ <p class="font-medium text-destructive">{{ entry.name }} · {{ t("objects.viewRenameNeedsRepair") }}</p>+ <p v-if="!issue.repairable" class="text-xs text-destructive">{{ t("objects.viewRenameMetadataProblem") }}</p>+ <details class="text-xs text-muted-foreground" data-diagnostics>+ <summary class="cursor-pointer">{{ t("objects.viewRenameDiagnostics") }}</summary>+ <pre class="mt-1 whitespace-pre-wrap break-all">{{ issue.message }}</pre>+ </details>+ </li>+ </ul>+ <label v-if="entry.rewriteRequired" class="block space-y-1">+ <span class="block text-xs text-muted-foreground">{{ t("objects.viewRenameDraft") }} · {{ plan?.target.schema }}.{{ entry.name }}</span>+ <textarea+ :value="drafts[entry.key] ?? entry.draft"+ :disabled="busy || !entry.source.trim()"+ spellcheck="false"+ rows="10"+ class="w-full resize-y rounded border border-input bg-background p-2 font-mono text-xs leading-relaxed focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring disabled:cursor-not-allowed disabled:opacity-50"+ :data-source-draft="entry.key"+ @input="edit(entry.key, $event)"+ />+ </label>+ <div v-if="entry.generated && isCurrentDraft(entry.key, entry.draft)" class="space-y-1">+ <p class="text-xs text-muted-foreground">{{ t("objects.viewRenameFinalSql") }}</p>+ <pre class="max-h-48 overflow-auto whitespace-pre-wrap break-all rounded bg-muted p-2 font-mono text-xs">{{ entry.generated }}</pre>+ </div>+ </div>+ </details>+ <details v-if="statementsCurrent && plan?.statements.length" class="rounded border border-border" open>+ <summary class="cursor-pointer px-3 py-2 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring">{{ t("objects.viewRenameFinalSql") }}</summary>+ <pre class="max-h-64 overflow-auto whitespace-pre-wrap break-all border-t border-border p-3 font-mono text-xs">{{ plan.statements.join("\n\n") }}</pre>+ </details>+ <div class="flex flex-wrap gap-2">+ <Button type="button" variant="outline" size="sm" :disabled="busy || !plan" data-validate @click="emit('validate')">{{ t("objects.viewRenameValidate") }}</Button>+ <Button type="button" variant="outline" size="sm" :disabled="busy" data-reload @click="emit('reload')">{{ t("objects.viewRenameReload") }}</Button>+ </div>+ </section>+</template>diff --git a/apps/desktop/src/components/objects/OracleTableRenamePreview.vue b/apps/desktop/src/components/objects/OracleTableRenamePreview.vuenew file mode 100644index 0000000000..5e2c5b818c--- /dev/null+++ b/apps/desktop/src/components/objects/OracleTableRenamePreview.vue@@ -0,0 +1,91 @@+<script setup lang="ts">+import { computed } from "vue";+import { useI18n } from "vue-i18n";+import { Button } from "@/components/ui/button";+import type { OracleTableRenamePlan } from "@/lib/table/oracleTableRename";++const props = defineProps<{ plan: OracleTableRenamePlan | null; drafts: Record<string, string>; loading: boolean; validating: boolean; executing: boolean }>();+const emit = defineEmits<{ edit: [name: string, source: string]; validate: []; reload: [] }>();+const { t } = useI18n();+const busy = computed(() => props.loading || props.validating || props.executing);+const entries = computed(+ () =>+ props.plan?.dependents.map((dependent) => ({+ name: dependent.name,+ dependent,+ issues: props.plan!.issues.filter((issue) => issue.objectName === dependent.name),+ })) ?? [],+);+function edit(name: string, event: Event) {+ emit("edit", name, (event.target as HTMLTextAreaElement).value);+}+</script>++<template>+ <section class="space-y-3 text-sm" :aria-busy="busy">+ <p class="text-xs leading-relaxed text-muted-foreground">{{ t("objects.tableRenameCoverage") }}</p>+ <p v-if="loading || validating" role="status" class="text-muted-foreground">{{ t("common.loading") }}</p>+ <p v-else-if="!plan || !plan.executable" role="status" class="text-muted-foreground">{{ t("objects.viewRenameValidationPending") }}</p>+ <p v-if="plan && !plan.metadataComplete" class="text-destructive">{{ t("objects.viewRenameMetadataProblem") }}</p>+ <div v-if="plan" class="rounded border border-border p-3">+ <p class="mb-2 font-medium">{{ t("objects.tableRenameObjects") }}</p>+ <ul class="space-y-1 text-xs text-muted-foreground">+ <li>TABLE · {{ plan.target.schema }}.{{ plan.target.oldName }} → {{ plan.target.schema }}.{{ plan.canonicalNewName }}</li>+ <li v-for="dependent in plan.dependents" :key="`${dependent.objectType}:${dependent.name}`">{{ dependent.objectType }} · {{ plan.target.schema }}.{{ dependent.name }}</li>+ </ul>+ </div>+ <ul v-if="plan?.issues.some((issue) => !issue.objectName || !entries.some((entry) => entry.name === issue.objectName))" class="space-y-2" aria-live="polite">+ <li v-for="(issue, index) in plan.issues.filter((item) => !item.objectName || !entries.some((entry) => entry.name === item.objectName))" :key="index" class="rounded border border-destructive/40 p-2">+ <p class="font-medium text-destructive">{{ issue.objectName || plan.target.oldName }} · {{ t("objects.viewRenameNeedsRepair") }}</p>+ <p v-if="issue.location" class="text-xs text-muted-foreground">{{ t("objects.viewRenameIssueLocation", issue.location) }}</p>+ <details class="mt-1 text-xs text-muted-foreground" data-diagnostics>+ <summary class="cursor-pointer">{{ t("objects.viewRenameDiagnostics") }}</summary>+ <pre class="mt-1 whitespace-pre-wrap break-all">{{ issue.message }}</pre>+ </details>+ </li>+ </ul>+ <details v-for="entry in entries" :key="`${entry.dependent.objectType}:${entry.name}`" :open="entry.issues.length > 0" class="rounded border border-border" :data-object-name="entry.name">+ <summary class="flex cursor-pointer items-center justify-between gap-3 px-3 py-2 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring">+ <span class="min-w-0 break-all font-medium">{{ entry.dependent.objectType }} · {{ entry.name }}</span>+ <span class="shrink-0 rounded bg-muted px-2 py-0.5 text-xs" :class="entry.issues.length ? 'text-destructive' : 'text-muted-foreground'">+ {{ t(entry.issues.length ? "objects.viewRenameNeedsRepair" : "objects.viewRenameDefinitionReady") }}+ </span>+ </summary>+ <div class="space-y-3 border-t border-border p-3">+ <ul v-if="entry.issues.length" class="space-y-2" aria-live="polite">+ <li v-for="(issue, index) in entry.issues" :key="index" class="space-y-1">+ <p class="font-medium text-destructive">{{ issue.objectName }} · {{ t("objects.viewRenameNeedsRepair") }}</p>+ <p v-if="issue.location" class="text-xs text-muted-foreground">{{ t("objects.viewRenameIssueLocation", issue.location) }}</p>+ <details class="text-xs text-muted-foreground" data-diagnostics>+ <summary class="cursor-pointer">{{ t("objects.viewRenameDiagnostics") }}</summary>+ <pre class="mt-1 whitespace-pre-wrap break-all">{{ issue.message }}</pre>+ </details>+ </li>+ </ul>+ <label class="block space-y-1">+ <span class="block text-xs text-muted-foreground">{{ t("objects.tableRenameDraft", { schema: plan?.target.schema, name: entry.name }) }}</span>+ <textarea+ :value="drafts[entry.name] ?? entry.dependent.draft"+ :disabled="busy"+ spellcheck="false"+ rows="10"+ class="w-full resize-y rounded border border-input bg-background p-2 font-mono text-xs leading-relaxed focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring disabled:cursor-not-allowed disabled:opacity-50"+ @input="edit(entry.name, $event)"+ />+ </label>+ <div v-if="entry.dependent.rewrittenSource" class="space-y-1">+ <p class="text-xs text-muted-foreground">{{ t("objects.viewRenameFinalSql") }}</p>+ <pre class="max-h-48 overflow-auto whitespace-pre-wrap break-all rounded bg-muted p-2 font-mono text-xs">{{ entry.dependent.rewrittenSource }}</pre>+ </div>+ </div>+ </details>+ <details v-if="plan?.executable && plan.statements.length" class="rounded border border-border">+ <summary class="cursor-pointer px-3 py-2 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring">{{ t("objects.viewRenameFinalSql") }}</summary>+ <pre class="max-h-64 overflow-auto whitespace-pre-wrap break-all border-t border-border p-3 font-mono text-xs">{{ plan.statements.join("\n\n") }}</pre>+ </details>+ <div class="flex flex-wrap gap-2">+ <Button type="button" variant="outline" size="sm" :disabled="busy || !plan" data-validate @click="emit('validate')">{{ t("objects.viewRenameValidate") }}</Button>+ <Button type="button" variant="outline" size="sm" :disabled="busy" data-reload @click="emit('reload')">{{ t("objects.viewRenameReload") }}</Button>+ </div>+ </section>+</template>diff --git a/apps/desktop/src/components/objects/OracleViewRenamePreview.vue b/apps/desktop/src/components/objects/OracleViewRenamePreview.vuenew file mode 100644index 0000000000..86618ecf7a--- /dev/null+++ b/apps/desktop/src/components/objects/OracleViewRenamePreview.vue@@ -0,0 +1,104 @@+<script setup lang="ts">+import { computed } from "vue";+import { useI18n } from "vue-i18n";+import { Button } from "@/components/ui/button";+import type { OracleViewRenamePlan } from "@/lib/table/oracleViewRename";+import type { OracleViewRenameIssue } from "@/types/database";++const props = defineProps<{ plan: OracleViewRenamePlan | null; drafts: Record<string, string>; loading: boolean; validating: boolean; executing: boolean }>();+const emit = defineEmits<{ edit: [name: string, source: string]; validate: []; reload: [] }>();+const { t } = useI18n();+const busy = computed(() => props.loading || props.validating || props.executing);+const entries = computed(() => {+ if (!props.plan) return [];+ const names = new Set(props.plan.views.map((view) => view.name));+ const unassigned = props.plan.issues.filter((issue) => !issue.viewName || !names.has(issue.viewName));+ return [...(unassigned.length ? [{ name: "", view: null, issues: unassigned }] : []), ...props.plan.views.map((view) => ({ name: view.name, view, issues: props.plan!.issues.filter((issue) => issue.viewName === view.name) }))];+});+const issueLabels: Record<string, string> = {+ unsupported_hint: "viewRenameIssueHint",+ hint_capture: "viewRenameIssueBinding",+ ambiguous_binding: "viewRenameIssueBinding",+ invalid_definition: "viewRenameNeedsRepair",+ invalid_declaration: "viewRenameIssueDeclaration",+ manual_graph: "viewRenameIssueGraph",+ manual_new_name: "viewRenameIssueGraph",+ invalid_name: "viewRenameIssueName",+ target_conflict: "viewRenameIssueName",+ owner_mismatch: "viewRenameIssueState",+ invalid_object: "viewRenameIssueState",+ source_read_failed: "viewRenameIssueSource",+ grants_read_failed: "viewRenameIssueSource",+ metadata_incomplete: "viewRenameIssueSource",+ invalid_metadata: "viewRenameIssueState",+ dependency_scope: "viewRenameIssueDependency",+ dependency_cycle: "viewRenameIssueDependency",+ dependency_read_failed: "viewRenameIssueDependency",+ metadata_drift: "viewRenameIssueDrift",+};+function issueLabel(issue: OracleViewRenameIssue) {+ return t(`objects.${issueLabels[issue.code] || "viewRenameNeedsRepair"}`);+}+function edit(name: string, event: Event) {+ emit("edit", name, (event.target as HTMLTextAreaElement).value);+}+function isCurrentDraft(name: string, validatedDraft: string) {+ return (props.drafts[name] ?? validatedDraft) === validatedDraft;+}+</script>++<template>+ <section class="space-y-3 text-sm" :aria-busy="busy">+ <p class="text-xs leading-relaxed text-muted-foreground">{{ t("objects.viewRenameCoverage") }}</p>+ <p v-if="loading || validating" role="status" class="text-muted-foreground">{{ t("common.loading") }}</p>+ <p v-else-if="!plan || !plan.executable" role="status" class="text-muted-foreground">{{ t("objects.viewRenameValidationPending") }}</p>+ <p v-if="plan && !plan.metadataComplete" class="text-destructive">{{ t("objects.viewRenameMetadataProblem") }}</p>+ <details v-for="entry in entries" :key="entry.name" :open="entry.issues.length > 0" class="rounded border border-border" :data-view-name="entry.name">+ <summary class="flex cursor-pointer items-center justify-between gap-3 px-3 py-2 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring">+ <span class="min-w-0 break-all font-medium">{{ entry.name || t("objects.viewRenameMetadataProblem") }}</span>+ <span class="shrink-0 rounded bg-muted px-2 py-0.5 text-xs" :class="entry.issues.length ? 'text-destructive' : 'text-muted-foreground'">+ {{ t(entry.issues.length ? "objects.viewRenameNeedsRepair" : "objects.viewRenameDefinitionReady") }}+ </span>+ </summary>+ <div class="space-y-3 border-t border-border p-3">+ <ul v-if="entry.issues.length" class="space-y-3" aria-live="polite">+ <li v-for="(issue, index) in entry.issues" :key="index" class="space-y-1">+ <p class="font-medium text-destructive">+ {{ issueLabel(issue) }}<span v-if="issue.viewName"> · {{ issue.viewName }}</span>+ </p>+ <code v-if="issue.hintText" class="block whitespace-pre-wrap break-all rounded bg-muted px-2 py-1 text-xs">{{ issue.hintText }}</code>+ <p v-if="issue.location" class="text-xs text-muted-foreground">{{ t("objects.viewRenameIssueLocation", { line: issue.location.line, column: issue.location.column }) }}</p>+ <p v-if="!issue.repairable" class="text-xs text-destructive">{{ t("objects.viewRenameMetadataProblem") }}</p>+ <details class="text-xs text-muted-foreground" data-diagnostics>+ <summary class="cursor-pointer focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring">{{ t("objects.viewRenameDiagnostics") }}</summary>+ <pre class="mt-1 whitespace-pre-wrap break-all">{{ issue.message }}</pre>+ </details>+ </li>+ </ul>+ <label v-if="entry.view" class="block space-y-1">+ <span class="block text-xs text-muted-foreground">{{ t("objects.viewRenameDraft") }} · {{ plan?.target.schema }}.{{ entry.name }}</span>+ <textarea+ :value="drafts[entry.name] ?? entry.view.source"+ :disabled="busy || (!entry.view.source.trim() && drafts[entry.name] === undefined)"+ spellcheck="false"+ rows="10"+ class="w-full resize-y rounded border border-input bg-background p-2 font-mono text-xs leading-relaxed focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring disabled:cursor-not-allowed disabled:opacity-50"+ @input="edit(entry.name, $event)"+ />+ </label>+ <div v-if="entry.view?.rewrittenSource && isCurrentDraft(entry.name, entry.view.draft)" class="space-y-1">+ <p class="text-xs text-muted-foreground">{{ t("objects.viewRenameFinalSql") }}</p>+ <pre class="max-h-48 overflow-auto whitespace-pre-wrap break-all rounded bg-muted p-2 font-mono text-xs">{{ entry.view.rewrittenSource }}</pre>+ </div>+ </div>+ </details>+ <details v-if="plan?.executable && plan.statements.length" class="rounded border border-border">+ <summary class="cursor-pointer px-3 py-2 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring">{{ t("objects.viewRenameFinalSql") }}</summary>+ <pre class="max-h-64 overflow-auto whitespace-pre-wrap break-all border-t border-border p-3 font-mono text-xs">{{ plan.statements.join("\n\n") }}</pre>+ </details>+ <div class="flex flex-wrap gap-2">+ <Button type="button" variant="outline" size="sm" :disabled="busy || !plan" data-validate @click="emit('validate')">{{ t("objects.viewRenameValidate") }}</Button>+ <Button type="button" variant="outline" size="sm" :disabled="busy" data-reload @click="emit('reload')">{{ t("objects.viewRenameReload") }}</Button>+ </div>+ </section>+</template>diff --git a/apps/desktop/src/components/objects/__tests__/ObjectBrowser.viewSourceSave.spec.ts b/apps/desktop/src/components/objects/__tests__/ObjectBrowser.viewSourceSave.spec.tsindex 7508514eb3..fcd95bf93a 100644--- a/apps/desktop/src/components/objects/__tests__/ObjectBrowser.viewSourceSave.spec.ts+++ b/apps/desktop/src/components/objects/__tests__/ObjectBrowser.viewSourceSave.spec.ts@@ -4,6 +4,7 @@ import { createApp, defineComponent, h, ref, nextTick, type App } from "vue";import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";import ObjectBrowser from "@/components/objects/ObjectBrowser.vue";import { invalidateObjectBrowserRowsCache } from "@/lib/table/objectBrowserRowsCache";+import { freezeSourceIdentities } from "@/lib/table/objectSourceIdentity";import type { ConnectionConfig } from "@/types/database";const mocks = vi.hoisted(() => ({@@ -51,7 +52,10 @@ vi.mock("@/stores/settingsStore", () => ({}),}));vi.mock("vue-i18n", () => ({ useI18n: () => ({ t: (key: string) => key, locale: ref("en-US") }) }));-vi.mock("@/i18n", () => ({ default: { install: () => undefined } }));+vi.mock("@/i18n", async () => {+ const { default: en } = await import("@/i18n/locales/en");+ return { default: { install: () => undefined, global: { t: (key: string) => en.objects[key.split(".")[1] as keyof typeof en.objects] || key } } };+});vi.mock("@/composables/useSqlHighlighter", () => ({ useSqlHighlighter: () => ({ highlight: (sql: string) => sql }) }));vi.mock("@/composables/useToast", () => ({ useToast: () => ({ toast: mocks.toast }) }));vi.mock("vue-virtual-scroller", () => ({@@ -159,6 +163,27 @@ async function clickRow(host: HTMLElement, name: string) {}describe("ObjectBrowser view source save", () => {+ it("does not dispatch a save whose source identity changed during SQL construction", async () => {+ const host = await mountBrowser();+ vi.useFakeTimers();+ await clickRow(host, VIEW_NAME);+ let complete!: (value: string[]) => void;+ mocks.buildExecutableObjectSourceStatements.mockReturnValueOnce(+ new Promise<string[]>((resolve) => {+ complete = resolve;+ }),+ );+ click(saveButton(host)!);+ await settle();+ const migration = freezeSourceIdentities([{ connectionId: connection.id, database: "app", schema: "app", objectType: "VIEW", name: VIEW_NAME }]);+ migration.markDispatched();+ migration.finish();+ complete([ALTER_SQL]);+ await settle();+ expect(mocks.executeQuery).not.toHaveBeenCalled();+ expect(host.textContent).toContain("reload");+ expect(saveButton(host)).toBeDefined();+ });it("keeps the Save button idle and usable after a successful view-source save", async () => {const host = await mountBrowser();vi.useFakeTimers();diff --git a/apps/desktop/src/components/objects/__tests__/ObjectSourceDialog.oceanbaseSequence.spec.ts b/apps/desktop/src/components/objects/__tests__/ObjectSourceDialog.oceanbaseSequence.spec.tsindex 6c1d86d59a..bc9e78ecb1 100644--- a/apps/desktop/src/components/objects/__tests__/ObjectSourceDialog.oceanbaseSequence.spec.ts+++ b/apps/desktop/src/components/objects/__tests__/ObjectSourceDialog.oceanbaseSequence.spec.ts@@ -6,8 +6,10 @@ import { EditorState } from "@codemirror/state";import { EditorView } from "@codemirror/view";import { afterEach, describe, expect, it, vi } from "vitest";import { useConnectionStore } from "@/stores/connectionStore";+import { useProductionSafetyStore } from "@/stores/productionSafetyStore";import type { ConnectionConfig, DatabaseType, ObjectSourceKind } from "@/types/database";import ObjectSourceDialog from "../ObjectSourceDialog.vue";+import { freezeSourceIdentities } from "@/lib/table/objectSourceIdentity";const ddl = 'CREATE SEQUENCE "APP"."SEQ" START WITH 40 INCREMENT BY 1 NOCACHE;';const alter = 'ALTER SEQUENCE "APP"."SEQ" INCREMENT BY 1 NOCACHE;';@@ -28,7 +30,7 @@ function editor() {const root = document.querySelector<HTMLElement>('[role="dialog"] .cm-editor');return root ? EditorView.findFromDOM(root) : null;}-async function mount(options: { databaseType?: DatabaseType; initialEditing?: boolean; editable?: boolean; type?: ObjectSourceKind; source?: string } = {}) {+async function mount(options: { databaseType?: DatabaseType; initialEditing?: boolean; editable?: boolean; type?: ObjectSourceKind; source?: string; production?: boolean } = {}) {const databaseType = options.databaseType ?? "oceanbase-oracle",objectType = options.type ?? "SEQUENCE",source = options.source ?? ddl;@@ -36,7 +38,7 @@ async function mount(options: { databaseType?: DatabaseType; initialEditing?: bosetActivePinia(pinia);const store = useConnectionStore();vi.spyOn(store, "ensureConnected").mockResolvedValue(undefined);- vi.spyOn(store, "getConfig").mockReturnValue({ id: "ob", name: "test", db_type: databaseType } as ConnectionConfig);+ vi.spyOn(store, "getConfig").mockReturnValue({ id: "ob", name: "test", db_type: databaseType, is_production: options.production } as ConnectionConfig);mocks.getObjectSource.mockResolvedValue({ name: "SEQ", schema: "APP", object_type: objectType, source, editable: options.editable !== false });mocks.buildEditableObjectSource.mockResolvedValue(objectType === "SEQUENCE" && databaseType === "oceanbase-oracle" ? alter : source);mocks.buildExecutableObjectSourceStatements.mockResolvedValue([objectType === "SEQUENCE" ? alter : source]);@@ -58,6 +60,60 @@ async function mount(options: { databaseType?: DatabaseType; initialEditing?: bo}describe("OceanBase sequence source through the shared Oracle object dialog", () => {+ it("rechecks identity after the real production confirmation waits", async () => {+ const source = 'CREATE OR REPLACE VIEW "APP"."SEQ" AS SELECT 3 FROM DUAL';+ const { saved } = await mount({ type: "VIEW", source, initialEditing: true, production: true });+ const safety = useProductionSafetyStore();+ button("objects.saveSource")!.click();+ await vi.waitFor(() => expect(safety.pending).toBeDefined());+ const migration = freezeSourceIdentities([{ connectionId: "ob", database: "service", schema: "APP", objectType: "VIEW", name: "SEQ" }]);+ migration.markDispatched();+ migration.finish();+ safety.confirm();+ await vi.waitFor(() => expect(document.body.textContent).toContain("reload"));+ expect(mocks.executeQuery).not.toHaveBeenCalled();+ expect(saved).not.toHaveBeenCalled();+ expect(editor()!.state.doc.toString()).toBe(source);+ });+ it("blocks migration while a real save is in flight and releases it afterwards", async () => {+ const source = 'CREATE OR REPLACE VIEW "APP"."SEQ" AS SELECT 4 FROM DUAL';+ const { saved } = await mount({ type: "VIEW", source, initialEditing: true });+ let complete!: (value: unknown) => void;+ mocks.executeQuery.mockReturnValueOnce(+ new Promise((resolve) => {+ complete = resolve;+ }),+ );+ button("objects.saveSource")!.click();+ await vi.waitFor(() => expect(mocks.executeQuery).toHaveBeenCalledOnce());+ const identity = { connectionId: "ob", database: "service", schema: "APP", objectType: "VIEW", name: "SEQ" };+ expect(() => freezeSourceIdentities([identity])).toThrow("saved");+ complete({ columns: [], rows: [], affected_rows: 0 });+ await vi.waitFor(() => expect(saved).toHaveBeenCalledOnce());+ const migration = freezeSourceIdentities([identity]);+ migration.cancel();+ });+ it("keeps the draft and refuses a late save after its view is renamed", async () => {+ const source = 'CREATE OR REPLACE VIEW "APP"."SEQ" AS SELECT 1 FROM DUAL';+ const { saved } = await mount({ type: "VIEW", source, initialEditing: true });+ let complete!: (value: string[]) => void;+ mocks.buildExecutableObjectSourceStatements.mockReturnValueOnce(+ new Promise<string[]>((resolve) => {+ complete = resolve;+ }),+ );+ button("objects.saveSource")!.click();+ await vi.waitFor(() => expect(mocks.buildExecutableObjectSourceStatements).toHaveBeenCalledOnce());+ const migration = freezeSourceIdentities([{ connectionId: "ob", database: "service", schema: "APP", objectType: "VIEW", name: "SEQ" }]);+ migration.markDispatched();+ migration.finish();+ complete([source]);+ await new Promise((resolve) => setTimeout(resolve, 30));+ expect(mocks.executeQuery).not.toHaveBeenCalled();+ expect(saved).not.toHaveBeenCalled();+ expect(editor()!.state.doc.toString()).toBe(source);+ expect(document.body.textContent).toContain("reload");+ });it("previews the CREATE DDL read-only and switches to the backend ALTER draft only on edit", async () => {await mount();expect(editor()!.state.facet(EditorState.readOnly)).toBe(true);diff --git a/apps/desktop/src/components/objects/__tests__/OceanbaseClone.entrypoints.spec.ts b/apps/desktop/src/components/objects/__tests__/OceanbaseClone.entrypoints.spec.tsindex 3d2cfd3544..1b3f2f8737 100644--- a/apps/desktop/src/components/objects/__tests__/OceanbaseClone.entrypoints.spec.ts+++ b/apps/desktop/src/components/objects/__tests__/OceanbaseClone.entrypoints.spec.ts@@ -10,8 +10,10 @@ import { useProductionSafetyStore } from "@/stores/productionSafetyStore";import { invalidateObjectBrowserRowsCache } from "@/lib/table/objectBrowserRowsCache";import type { ConnectionConfig, TreeNode } from "@/types/database";import * as api from "@/lib/backend/api";+import { OraclePackageSaveAsFailure, type OraclePackageSaveAsPlan } from "@/lib/table/oraclePackageSaveAs";const backend = vi.hoisted(() => ({ executeQuery: vi.fn(), buildCreateTableSql: vi.fn(), buildCopyTableDataSql: vi.fn() }));+const packageSaveAs = vi.hoisted(() => ({ prepare: vi.fn(), execute: vi.fn() }));vi.mock("@/lib/backend/api", async (importOriginal) => ({...(await importOriginal<typeof import("@/lib/backend/api")>()),...backend,@@ -29,6 +31,10 @@ vi.mock("@/lib/backend/api", async (importOriginal) => ({listIndexes: vi.fn().mockResolvedValue([]),listTriggers: vi.fn().mockResolvedValue([]),}));+vi.mock("@/lib/table/oraclePackageSaveAs", async (importOriginal) => {+ const actual = await importOriginal<typeof import("@/lib/table/oraclePackageSaveAs")>();+ return { ...actual, prepareOraclePackageSaveAs: (...args: unknown[]) => packageSaveAs.prepare(...args), executeOraclePackageSaveAs: (...args: unknown[]) => packageSaveAs.execute(...args) };+});const result = (rows: unknown[][] = []) => ({ columns: [], rows, affected_rows: 0, execution_time_ms: 0 });const connection = { id: "ob-entry", name: "OB", db_type: "oceanbase-oracle", driver_profile: "oceanbase-oracle", host: "test", port: 2881, username: "APP", database: "APP" } as ConnectionConfig;@@ -54,6 +60,8 @@ beforeEach(() => {);backend.buildCreateTableSql.mockImplementation(async ({ schema, tableName }) => ({ statements: [`CREATE TABLE "${schema}"."${tableName}" ("ID" NUMBER);`], warnings: [] }));backend.buildCopyTableDataSql.mockResolvedValue('INSERT INTO "APP"."MixedCopy" SELECT * FROM "APP"."SOURCE"');+ packageSaveAs.prepare.mockReset();+ packageSaveAs.execute.mockReset();backend.executeQuery.mockImplementation(async (_id, _db, sql: string) => {if (sql.includes("ALL_TAB_COMMENTS")) return result([["source comment"]]);if (sql.includes("ALL_TABLES")) return result([["NO", "N"]]);@@ -77,6 +85,7 @@ async function mountEntry(surface: "sidebar" | "objects") {const store = useConnectionStore();store.connections = [{ ...connection }];store.connectedIds.add(connection.id);+ vi.spyOn(store, "ensureConnected").mockResolvedValue(undefined);store.treeNodes = [{ id: `${connection.id}:APP:APP`, type: "schema", label: "APP", connectionId: connection.id, database: "APP", schema: "APP", children: [], isExpanded: false }];const refresh = vi.spyOn(store, "refreshObjectListTreeNode");const component = ref<any>(null);@@ -110,7 +119,7 @@ async function mountEntry(surface: "sidebar" | "objects") {if (surface === "objects") controller.duplicateTarget = { name: "SOURCE", schema: "APP", object_type: "TABLE" };controller.pasteTableEntries = [{ sourceName: "SOURCE", targetName: '"MixedCopy"', connectionId: connection.id, database: "APP", schema: "APP" }];controller.pasteTableMode = "structure-and-data";- return { controller, refresh, context, app };+ return { controller, refresh, context, app, runtime: component.value.$.setupState };}async function acceptClone() {@@ -494,3 +503,106 @@ describe("ObjectBrowser clone confirmation identity", () => {expect(ddlCalls()).toEqual([]);});});++async function beginPackageSaveAs(surface: "sidebar" | "objects") {+ const { controller, refresh, context, runtime } = await mountEntry(surface);+ const packageTarget = surface === "sidebar" ? ({ id: `${connection.id}:APP:APP:package:P_OLD`, type: "package", label: "P_OLD", objectName: "P_OLD", connectionId: connection.id, database: "APP", schema: "APP" } as TreeNode) : { name: "P_OLD", type: "PACKAGE", schema: "APP" };+ const plan = {+ target: { connectionId: connection.id, database: "APP", databaseType: "oceanbase-oracle", schema: "APP", oldName: "P_OLD", newName: "P_NEW" },+ canonicalNewName: "P_NEW",+ snapshot: null,+ specDraft: "PACKAGE P_OLD AS END P_OLD;",+ bodyDraft: null,+ specSource: 'CREATE PACKAGE "P_NEW" AS END "P_NEW";',+ bodySource: null,+ statements: ["CREATE PACKAGE"],+ issues: [],+ metadataComplete: true,+ executable: true,+ } as OraclePackageSaveAsPlan;+ packageSaveAs.prepare.mockResolvedValue(plan);+ if (surface === "sidebar") {+ const action = runtime.buildContextMenu(packageTarget).find((item: { label: string }) => item.label === i18n.global.t("objects.packageSaveAsTitle")) as { action?: () => void } | undefined;+ expect(action?.action).toBeDefined();+ action!.action!();+ } else controller.requestPackageSaveAs(packageTarget);+ controller.packageSaveAsName = "P_NEW";+ await vi.waitFor(() => expect(controller.packageSaveAsPlan).toBeDefined());+ return { controller, refresh, context, plan };+}++describe.each(["sidebar", "objects"] as const)("%s Oracle package Save As failure refresh", (surface) => {+ it("refreshes the target tree and keeps the failed plan editable for recovery", async () => {+ const { controller, refresh, plan } = await beginPackageSaveAs(surface);+ packageSaveAs.execute.mockRejectedValue(new OraclePackageSaveAsFailure(plan, ["PACKAGE P_NEW"], "PACKAGE BODY P_NEW", new Error("body failed"), true));++ await controller.confirmPackageSaveAs();++ expect(refresh).toHaveBeenCalledWith(connection.id, "APP", "APP");+ expect(controller.packageSaveAsOpen).toBe(true);+ expect(controller.packageSaveAsError).not.toBe("");+ expect(controller.packageSaveAsPlan).toMatchObject({ executable: false });+ });++ it("keeps the DDL failure and disabled plan when the metadata refresh also fails", async () => {+ const { controller, refresh, plan } = await beginPackageSaveAs(surface);+ const drafts = { ...controller.packageSaveAsDrafts };+ refresh.mockRejectedValue(new Error("refresh unavailable"));+ packageSaveAs.execute.mockRejectedValue(new OraclePackageSaveAsFailure(plan, ["PACKAGE P_NEW"], "PACKAGE BODY P_NEW", new Error("body failed"), true));++ await controller.confirmPackageSaveAs();++ expect(refresh).toHaveBeenCalledWith(connection.id, "APP", "APP");+ expect(controller.packageSaveAsDiagnostic).toContain("body failed");+ expect(controller.packageSaveAsPlan).toMatchObject({ executable: false });+ expect(controller.packageSaveAsDrafts).toEqual(drafts);+ });++ it("does not apply a late failure to a different target or draft", async () => {+ const { controller, refresh, context, plan } = await beginPackageSaveAs(surface);+ let rejectExecution!: (error: unknown) => void;+ packageSaveAs.execute.mockReturnValue(+ new Promise<void>((_resolve, reject) => {+ rejectExecution = reject;+ }),+ );+ const pending = controller.confirmPackageSaveAs();+ await vi.waitFor(() => expect(packageSaveAs.execute).toHaveBeenCalled());++ if (surface === "sidebar") {+ controller.packageSaveAsTarget = { id: "other:APP:APP:package:P_OTHER", type: "package", label: "P_OTHER", objectName: "P_OTHER", connectionId: "other", database: "APP", schema: "APP" };+ } else {+ context.value = { connection: { ...connection, id: "other" }, database: "OTHER", schema: "OTHER" };+ }+ await nextTick();+ controller.packageSaveAsDrafts = { body: "P_OTHER draft" };+ rejectExecution(new OraclePackageSaveAsFailure(plan, ["PACKAGE P_NEW"], "PACKAGE BODY P_NEW", new Error("body failed"), true));+ await pending;++ expect(refresh).toHaveBeenCalledWith(connection.id, "APP", "APP");+ expect(controller.packageSaveAsDrafts).toEqual({ body: "P_OTHER draft" });+ expect(controller.packageSaveAsError).toBe("");+ });++ it("preserves a same-scope replacement draft when the previous target fails late", async () => {+ const { controller, refresh, plan } = await beginPackageSaveAs(surface);+ let rejectExecution!: (error: unknown) => void;+ packageSaveAs.execute.mockReturnValue(+ new Promise<void>((_resolve, reject) => {+ rejectExecution = reject;+ }),+ );+ const pending = controller.confirmPackageSaveAs();+ await vi.waitFor(() => expect(packageSaveAs.execute).toHaveBeenCalled());++ controller.packageSaveAsTarget = surface === "sidebar" ? { id: `${connection.id}:APP:APP:package:P_OTHER`, type: "package", label: "P_OTHER", objectName: "P_OTHER", connectionId: connection.id, database: "APP", schema: "APP" } : { name: "P_OTHER", type: "PACKAGE", schema: "APP" };+ await nextTick();+ controller.packageSaveAsDrafts = { body: "P_OTHER draft" };+ rejectExecution(new OraclePackageSaveAsFailure(plan, ["PACKAGE P_NEW"], "PACKAGE BODY P_NEW", new Error("body failed"), true));+ await pending;++ expect(refresh).toHaveBeenCalledWith(connection.id, "APP", "APP");+ expect(controller.packageSaveAsDrafts).toEqual({ body: "P_OTHER draft" });+ expect(controller.packageSaveAsError).toBe("");+ });+});diff --git a/apps/desktop/src/components/objects/__tests__/OraclePackageSaveAsDialog.spec.ts b/apps/desktop/src/components/objects/__tests__/OraclePackageSaveAsDialog.spec.tsnew file mode 100644index 0000000000..8ef999d2c7--- /dev/null+++ b/apps/desktop/src/components/objects/__tests__/OraclePackageSaveAsDialog.spec.ts@@ -0,0 +1,109 @@+// @vitest-environment happy-dom+import { createApp, h, nextTick } from "vue";+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";+import i18n, { setLocale } from "@/i18n";+import OraclePackageSaveAsDialog from "../OraclePackageSaveAsDialog.vue";+import type { OraclePackageSaveAsPlan } from "@/lib/table/oraclePackageSaveAs";++const cleanups: Array<() => void> = [];+async function flush() {+ for (let turn = 0; turn < 5; turn += 1) {+ await nextTick();+ await new Promise((resolve) => setTimeout(resolve));+ await nextTick();+ }+}+function fixture(executable: boolean): OraclePackageSaveAsPlan {+ return {+ target: { connectionId: "c", database: "APP", databaseType: "oracle", schema: "APP", oldName: "P_OLD", newName: "P_NEW" },+ canonicalNewName: "P_NEW",+ snapshot: null,+ specDraft: "PACKAGE P_OLD AS END P_OLD;",+ bodyDraft: null,+ specSource: 'CREATE PACKAGE "P_NEW" AS END "P_NEW";',+ bodySource: null,+ statements: ['CREATE PACKAGE "P_NEW" AS END "P_NEW";'],+ issues: executable ? [] : [{ code: "source_rewrite_failed", message: "An uncertain member reference.", objectName: "PACKAGE", repairable: true }],+ metadataComplete: true,+ executable,+ };+}++function mount(plan: OraclePackageSaveAsPlan, drafts: { spec?: string; body?: string } = { spec: plan.specDraft, ...(plan.bodyDraft === null ? {} : { body: plan.bodyDraft }) }) {+ const confirm = vi.fn();+ const updateName = vi.fn();+ const updateOpen = vi.fn();+ const edit = vi.fn();+ const validate = vi.fn();+ const reload = vi.fn();+ const container = document.createElement("div");+ document.body.appendChild(container);+ const app = createApp({+ render: () =>+ h(OraclePackageSaveAsDialog, {+ open: true,+ oldName: "P_OLD",+ newName: "P_NEW",+ plan,+ drafts,+ error: "",+ diagnostic: "",+ loading: false,+ validating: false,+ executing: false,+ onConfirm: confirm,+ "onUpdate:newName": updateName,+ "onUpdate:open": updateOpen,+ onEdit: edit,+ onValidate: validate,+ onReload: reload,+ }),+ }).use(i18n);+ app.mount(container);+ cleanups.push(() => {+ app.unmount();+ container.remove();+ });+ return { container: document.body, confirm, updateName, updateOpen, edit, validate, reload };+}++describe("Oracle package Save As dialog", () => {+ beforeEach(async () => {+ await setLocale("zh-CN");+ });+ afterEach(() => cleanups.splice(0).forEach((cleanup) => cleanup()));++ it("keeps confirmation disabled when a source issue needs resolution and localizes the prompt", async () => {+ const { container } = mount(fixture(false));+ await flush();+ expect(container.textContent).toContain(i18n.global.t("objects.packageSaveAsTitle"));+ expect(container.textContent).toContain(i18n.global.t("objects.packageSaveAsHint", { name: "P_OLD" }));+ expect(container.textContent).toContain(i18n.global.t("objects.viewRenameNeedsRepair"));+ expect(container.querySelector<HTMLButtonElement>("button[data-confirm]")?.disabled).toBe(true);+ expect(container.querySelector<HTMLDetailsElement>("li details")?.open).toBe(false);+ });++ it("shows the validated CREATE preview and emits the save action", async () => {+ const { container, confirm } = mount(fixture(true));+ await flush();+ expect(container.textContent).toContain('CREATE PACKAGE "P_NEW"');+ container.querySelector<HTMLButtonElement>("button[data-confirm]")?.click();+ expect(confirm).toHaveBeenCalledOnce();+ });++ it("keeps a package source draft editable and exposes revalidation", async () => {+ const original = "PACKAGE BODY P_OLD AS BEGIN NULL; END P_OLD;";+ const plan = { ...fixture(false), snapshot: { specSource: "PACKAGE P_OLD AS END P_OLD;", bodySource: original }, bodyDraft: original } as unknown as OraclePackageSaveAsPlan;+ const { container, edit, validate, reload } = mount(plan, { spec: plan.specDraft, body: original });+ await flush();+ const editor = container.querySelector<HTMLTextAreaElement>('[data-source-draft="body"]');+ expect(editor?.value).toBe(original);+ editor!.value = original.replace("P_OLD", "P_NEW");+ editor!.dispatchEvent(new Event("input", { bubbles: true }));+ expect(edit).toHaveBeenCalledWith("body", expect.stringContaining("P_NEW"));+ container.querySelector<HTMLButtonElement>("[data-validate]")!.click();+ container.querySelector<HTMLButtonElement>("[data-reload]")!.click();+ expect(validate).toHaveBeenCalledOnce();+ expect(reload).toHaveBeenCalledOnce();+ });+});diff --git a/apps/desktop/src/components/objects/__tests__/OracleRoutineRenamePreview.spec.ts b/apps/desktop/src/components/objects/__tests__/OracleRoutineRenamePreview.spec.tsnew file mode 100644index 0000000000..ec2269f4ec--- /dev/null+++ b/apps/desktop/src/components/objects/__tests__/OracleRoutineRenamePreview.spec.ts@@ -0,0 +1,97 @@+// @vitest-environment happy-dom+import { createApp, h, nextTick, reactive } from "vue";+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";+import i18n, { setLocale } from "@/i18n";+import OracleRoutineRenamePreview from "../OracleRoutineRenamePreview.vue";+import type { OracleRoutineRenamePlan } from "@/lib/table/oracleRoutineRename";++function fixture(): OracleRoutineRenamePlan {+ const target = { connectionId: "routine-preview", database: "APP", databaseType: "oceanbase-oracle" as const, schema: "APP", objectType: "PROCEDURE" as const, oldName: "P_OLD", newName: "P_NEW" };+ const root = { name: "P_OLD", objectType: "PROCEDURE", objectId: "101", status: "VALID", source: "CREATE OR REPLACE PROCEDURE APP.P_OLD AS BEGIN NULL; END;", signature: "[]", grants: "[]", errors: "[]" };+ return {+ target,+ canonicalNewName: "P_NEW",+ root,+ rootDraft: root.source,+ rootCreateSource: "CREATE PROCEDURE APP.P_NEW AS BEGIN NULL; END;",+ callers: [],+ dependencyEdges: [],+ statements: ["CREATE PROCEDURE APP.P_NEW AS BEGIN NULL; END;", "DROP PROCEDURE APP.P_OLD"],+ steps: [+ { kind: "create", objectName: "P_NEW", objectType: "PROCEDURE", sql: "CREATE PROCEDURE APP.P_NEW AS BEGIN NULL; END;" },+ { kind: "drop", objectName: "P_OLD", objectType: "PROCEDURE", sql: "DROP PROCEDURE APP.P_OLD" },+ ],+ issues: [{ code: "unsupported_dependency", message: "Cannot update dependent OTHER.P_CALLER (PACKAGE).", objectName: "P_CALLER", repairable: false }],+ metadataComplete: true,+ executable: false,+ };+}++const cleanups: Array<() => void> = [];+function mount(options: Partial<{ plan: OracleRoutineRenamePlan | null; drafts: Record<string, string>; loading: boolean; validating: boolean; executing: boolean }> = {}) {+ const state = reactive({ plan: fixture() as OracleRoutineRenamePlan | null, drafts: {} as Record<string, string>, loading: false, validating: false, executing: false, ...options });+ const reload = vi.fn();+ const edit = vi.fn();+ const validate = vi.fn();+ const container = document.createElement("div");+ document.body.appendChild(container);+ const app = createApp({ render: () => h(OracleRoutineRenamePreview, { ...state, onEdit: edit, onValidate: validate, onReload: reload }) }).use(i18n);+ app.mount(container);+ cleanups.push(() => {+ app.unmount();+ container.remove();+ });+ return { container, state, reload, edit, validate };+}++describe("Oracle routine rename preview", () => {+ beforeEach(async () => {+ await setLocale("zh-CN");+ });+ afterEach(() => cleanups.splice(0).forEach((cleanup) => cleanup()));++ it("shows the blocking dependent and the exact SQL sequence without enabling execution", () => {+ const { container } = mount();++ expect(container.textContent).toContain("P_CALLER");+ expect(container.textContent).toContain("PACKAGE");+ expect(container.textContent).toContain("CREATE PROCEDURE APP.P_NEW AS BEGIN NULL; END;");+ expect(container.textContent).toContain("DROP PROCEDURE APP.P_OLD");+ expect(container.querySelector('[role="status"]')!.textContent).toBe(i18n.global.t("objects.viewRenameValidationPending"));+ });++ it("hides plan SQL after an unvalidated source edit", async () => {+ const { container, state } = mount();+ state.drafts["PROCEDURE:P_OLD"] = "CREATE OR REPLACE PROCEDURE APP.P_OLD AS BEGIN NULL; END; -- edited";+ await nextTick();+ expect(container.textContent).not.toContain("DROP PROCEDURE APP.P_OLD");+ });++ it("offers a localized refresh control and disables it while execution is active", async () => {+ const { container, state, reload } = mount();+ const button = container.querySelector<HTMLButtonElement>("[data-reload]")!;+ button.click();+ expect(reload).toHaveBeenCalledOnce();+ state.executing = true;+ await nextTick();+ expect(button.disabled).toBe(true);+ });++ it("keeps a failed caller editable and emits edits for revalidation", async () => {+ const original = "CREATE PROCEDURE APP.CALLER_1 AS BEGIN EXECUTE IMMEDIATE 'BEGIN APP.P_OLD; END;'; END;";+ const plan = {+ ...fixture(),+ callers: [{ name: "CALLER_1", objectType: "PROCEDURE", objectId: "102", status: "VALID", source: original, signature: "[]", grants: "[]", errors: "[]", rewrittenSource: "", rewrittenFingerprint: "", rewriteRequired: true, depth: 1, draft: original }],+ issues: [{ code: "caller_rewrite_failed", message: "Dynamic routine references cannot be rewritten automatically.", objectName: "CALLER_1", repairable: true }],+ } as unknown as OracleRoutineRenamePlan;+ const { container, edit, validate } = mount({ plan, drafts: {} });++ const editor = container.querySelector<HTMLTextAreaElement>('[data-source-draft="PROCEDURE:CALLER_1"]');+ expect(editor?.value).toBe(original);+ editor!.value = original.replace("P_OLD", "P_NEW");+ editor!.dispatchEvent(new Event("input", { bubbles: true }));+ expect(edit).toHaveBeenCalledWith("PROCEDURE:CALLER_1", expect.stringContaining("P_NEW"));+ container.querySelector<HTMLButtonElement>("[data-validate]")!.click();+ expect(validate).toHaveBeenCalledOnce();+ });+});diff --git a/apps/desktop/src/components/objects/__tests__/OracleTableRenamePreview.spec.ts b/apps/desktop/src/components/objects/__tests__/OracleTableRenamePreview.spec.tsnew file mode 100644index 0000000000..7c101e583d--- /dev/null+++ b/apps/desktop/src/components/objects/__tests__/OracleTableRenamePreview.spec.ts@@ -0,0 +1,63 @@+// @vitest-environment happy-dom+import { createApp, h, reactive } from "vue";+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";+import i18n, { setLocale } from "@/i18n";+import OracleTableRenamePreview from "../OracleTableRenamePreview.vue";+import type { OracleTableRenamePlan } from "@/lib/table/oracleTableRename";++const plan: OracleTableRenamePlan = {+ target: { connectionId: "table-preview", database: "APP", databaseType: "oceanbase-oracle", schema: "APP", oldName: "T_OLD", newName: "T_NEW" },+ canonicalNewName: "T_NEW",+ tableObjectId: "1",+ dependents: [{ name: "P_READ", objectType: "PROCEDURE", objectId: "2", source: "ORIGINAL", executionSource: "ORIGINAL", status: "VALID", grants: "[]", errors: "[]", draft: "EDIT ME", rewrittenSource: "", fingerprint: "", originalFingerprint: "", rewriteRequired: true }],+ dependencyEdges: [],+ issues: [{ code: "source_rewrite_failed", message: "Dynamic SQL at line 3, column 5.", objectName: "P_READ", location: { line: 3, column: 5 }, repairable: true }],+ metadataComplete: true,+ executable: false,+ steps: [],+ statements: [],+};++const cleanups: Array<() => void> = [];+function mount() {+ const state = reactive({ plan, drafts: {} as Record<string, string>, loading: false, validating: false, executing: false });+ const edit = vi.fn();+ const validate = vi.fn();+ const reload = vi.fn();+ const container = document.createElement("div");+ document.body.appendChild(container);+ const app = createApp({ render: () => h(OracleTableRenamePreview, { ...state, onEdit: edit, onValidate: validate, onReload: reload }) }).use(i18n);+ app.mount(container);+ cleanups.push(() => {+ app.unmount();+ container.remove();+ });+ return { container, edit, validate, reload };+}++describe("Oracle table rename preview", () => {+ beforeEach(async () => {+ await setLocale("zh-CN");+ });+ afterEach(() => cleanups.splice(0).forEach((cleanup) => cleanup()));++ it("shows the issue location and keeps the source editable for manual repair", () => {+ const { container } = mount();+ expect(container.textContent).toContain("P_READ");+ expect(container.textContent).toContain("第 3 行,第 5 列");+ expect(container.querySelector<HTMLTextAreaElement>("textarea")?.value).toBe("EDIT ME");+ expect(container.querySelector("[data-validate]")).not.toBeNull();+ });++ it("emits draft edits and explicit revalidation", () => {+ const { container, edit, validate, reload } = mount();+ const editor = container.querySelector<HTMLTextAreaElement>("textarea")!;+ editor.value = "corrected source";+ editor.dispatchEvent(new Event("input", { bubbles: true }));+ expect(edit).toHaveBeenCalledWith("P_READ", "corrected source");+ container.querySelector<HTMLButtonElement>("[data-validate]")!.click();+ expect(validate).toHaveBeenCalledOnce();+ container.querySelector<HTMLButtonElement>("[data-reload]")!.click();+ expect(reload).toHaveBeenCalledOnce();+ });+});diff --git a/apps/desktop/src/components/objects/__tests__/OracleViewRenamePreview.spec.ts b/apps/desktop/src/components/objects/__tests__/OracleViewRenamePreview.spec.tsnew file mode 100644index 0000000000..d25ea0c581--- /dev/null+++ b/apps/desktop/src/components/objects/__tests__/OracleViewRenamePreview.spec.ts@@ -0,0 +1,148 @@+// @vitest-environment happy-dom+import { createApp, h, nextTick, reactive } from "vue";+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";+import i18n, { setLocale } from "@/i18n";+import OracleViewRenamePreview from "../OracleViewRenamePreview.vue";+import type { OracleViewRenamePlan } from "@/lib/table/oracleViewRename";++const api = vi.hoisted(() => ({ executeQuery: vi.fn(), rewriteOracleViewRenameSource: vi.fn() }));+vi.mock("@/lib/backend/api", () => api);++function fixture(): OracleViewRenamePlan {+ return {+ target: { connectionId: "preview-c", database: "OWNER", schema: "OWNER", oldName: "ROOT", newName: "NEW_ROOT" },+ canonicalNewName: "NEW_ROOT",+ coverage: "visible-only",+ metadataComplete: true,+ executable: false,+ issues: [{ code: "unsupported_hint", message: "Unsupported backend hint syntax", viewName: "BROKEN", hintText: "FULL(旧对象@QB)", location: { line: 3, column: 8 }, repairable: true }],+ views: [+ {+ name: "ROOT",+ source: "CREATE VIEW ROOT AS SELECT 1 FROM DUAL",+ grants: "[]",+ draft: "CREATE VIEW ROOT AS SELECT 1 FROM DUAL",+ references: [{ owner: "OWNER", name: "DUAL" }],+ fingerprint: "root",+ rewrittenSource: "CREATE VIEW NEW_ROOT AS SELECT 1 FROM DUAL",+ rewrittenFingerprint: "new-root",+ },+ { name: "BROKEN", source: "CREATE VIEW BROKEN AS SELECT /*+ FULL(旧对象@QB) */ * FROM ROOT", grants: "[]", draft: "CREATE VIEW BROKEN AS SELECT /*+ FULL(旧对象@QB) */ * FROM ROOT", references: [{ owner: "OWNER", name: "ROOT" }], fingerprint: "", rewrittenSource: "", rewrittenFingerprint: "" },+ {+ name: "SAFE",+ source: "CREATE VIEW SAFE AS SELECT * FROM ROOT",+ grants: "[]",+ draft: "CREATE VIEW SAFE AS SELECT * FROM ROOT",+ references: [{ owner: "OWNER", name: "ROOT" }],+ fingerprint: "safe",+ rewrittenSource: "CREATE VIEW SAFE AS SELECT * FROM NEW_ROOT",+ rewrittenFingerprint: "new-safe",+ },+ ],+ dependencyEdges: [],+ statements: ["RENAME ROOT TO NEW_ROOT", "CREATE VIEW SAFE AS SELECT * FROM NEW_ROOT"],+ steps: [],+ };+}++const cleanups: Array<() => void> = [];+function mount(options: Partial<{ plan: OracleViewRenamePlan | null; drafts: Record<string, string>; loading: boolean; validating: boolean; executing: boolean }> = {}) {+ const state = reactive({ plan: fixture() as OracleViewRenamePlan | null, drafts: {} as Record<string, string>, loading: false, validating: false, executing: false, ...options });+ const edit = vi.fn();+ const validate = vi.fn();+ const reload = vi.fn();+ const container = document.createElement("div");+ document.body.appendChild(container);+ const app = createApp({ render: () => h(OracleViewRenamePreview, { ...state, onEdit: edit, onValidate: validate, onReload: reload }) }).use(i18n);+ app.mount(container);+ cleanups.push(() => {+ app.unmount();+ container.remove();+ });+ return { container, state, edit, validate, reload };+}++describe("Oracle view rename repair preview", () => {+ beforeEach(async () => {+ await setLocale("zh-CN");+ vi.clearAllMocks();+ });+ afterEach(() => {+ cleanups.splice(0).forEach((cleanup) => cleanup());+ });++ it("shows the affected object, hint and location while preserving other generated SQL", async () => {+ const { container, edit } = mount({ drafts: { BROKEN: "my edited definition" } });+ const broken = container.querySelector<HTMLDetailsElement>('[data-view-name="BROKEN"]')!;+ const safe = container.querySelector<HTMLDetailsElement>('[data-view-name="SAFE"]')!;+ expect(broken.open).toBe(true);+ expect(safe.open).toBe(false);+ expect(broken.textContent).toContain("FULL(旧对象@QB)");+ expect(i18n.global.t("objects.viewRenameIssueHint")).toContain("已自动改写可确认的引用");+ expect(i18n.global.t("objects.viewRenameIssueHint")).toContain("按上方位置");+ expect(i18n.global.t("objects.viewRenameIssueHint")).toContain("重新校验");+ expect(broken.textContent).toContain(i18n.global.t("objects.viewRenameIssueHint"));+ expect(i18n.global.t("objects.viewRenameIssueHint")).toMatch(/[\u4e00-\u9fff]/);+ expect(broken.textContent).toContain(i18n.global.t("objects.viewRenameIssueLocation", { line: 3, column: 8 }));+ const diagnostics = broken.querySelector<HTMLDetailsElement>("[data-diagnostics]")!;+ expect(diagnostics.open).toBe(false);+ expect(diagnostics.textContent).toContain("Unsupported backend hint syntax");+ expect(broken.querySelector("summary")!.textContent).not.toContain("Unsupported backend");+ expect(safe.textContent).toContain("CREATE VIEW SAFE AS SELECT * FROM NEW_ROOT");+ const draft = broken.querySelector("textarea")!;+ expect(draft.value).toBe("my edited definition");+ expect(draft.closest("label")!.textContent).toContain("OWNER.BROKEN");+ expect(draft.closest("label")!.textContent).toContain(i18n.global.t("objects.viewRenameDraft"));+ draft.value = "CREATE VIEW BROKEN AS SELECT * FROM ROOT";+ draft.dispatchEvent(new Event("input", { bubbles: true }));+ await nextTick();+ expect(edit).toHaveBeenCalledWith("BROKEN", draft.value);+ expect(api.executeQuery).not.toHaveBeenCalled();+ expect(api.rewriteOracleViewRenameSource).not.toHaveBeenCalled();+ });++ it("hides generated SQL for an edited draft until that draft is revalidated", () => {+ const { container } = mount({ drafts: { SAFE: "CREATE VIEW SAFE AS SELECT * FROM OTHER" } });+ const safe = container.querySelector<HTMLDetailsElement>('[data-view-name="SAFE"]')!;+ expect(safe.textContent).not.toContain("CREATE VIEW SAFE AS SELECT * FROM NEW_ROOT");+ expect(container.textContent).not.toContain("RENAME ROOT TO NEW_ROOT");+ });++ it("emits validation and reload actions, and disables editing and actions during execution", async () => {+ const { container, state, validate, reload } = mount();+ container.querySelector<HTMLButtonElement>("[data-validate]")!.click();+ container.querySelector<HTMLButtonElement>("[data-reload]")!.click();+ expect(validate).toHaveBeenCalledOnce();+ expect(reload).toHaveBeenCalledOnce();+ state.executing = true;+ await nextTick();+ expect([...container.querySelectorAll("textarea")].every((input) => input.disabled)).toBe(true);+ expect([...container.querySelectorAll("button")].every((button) => button.disabled)).toBe(true);+ container.querySelector<HTMLButtonElement>("[data-validate]")!.click();+ expect(validate).toHaveBeenCalledOnce();+ });++ it("keeps all objects and safe SQL visible when metadata cannot be repaired by editing", () => {+ const plan = fixture();+ plan.metadataComplete = false;+ plan.issues.push({ code: "dependency_scope", message: "Foreign owner dependency", viewName: "FOREIGN.V", repairable: false });+ plan.views[1]!.source = "";+ const { container } = mount({ plan });+ expect(container.querySelectorAll("[data-view-name]")).toHaveLength(4);+ expect(container.textContent).toContain("FOREIGN.V");+ expect(container.textContent).toContain(i18n.global.t("objects.viewRenameMetadataProblem"));+ expect(container.textContent).toContain("CREATE VIEW SAFE AS SELECT * FROM NEW_ROOT");+ expect(container.querySelector<HTMLTextAreaElement>('[data-view-name="BROKEN"] textarea')!.disabled).toBe(true);+ expect(container.querySelector<HTMLButtonElement>("[data-reload]")!.disabled).toBe(false);+ });++ it("offers a localized loading state and reload when no plan is available", async () => {+ const { container, state, reload } = mount({ plan: null, loading: true });+ expect(container.querySelector('[role="status"]')!.textContent).toBe(i18n.global.t("common.loading"));+ state.loading = false;+ await nextTick();+ expect(container.querySelector<HTMLButtonElement>("[data-validate]")!.disabled).toBe(true);+ container.querySelector<HTMLButtonElement>("[data-reload]")!.click();+ expect(reload).toHaveBeenCalledOnce();+ });+});diff --git a/apps/desktop/src/components/sidebar/SidebarTreeItemDialogs.vue b/apps/desktop/src/components/sidebar/SidebarTreeItemDialogs.vueindex 30c5799fd6..12ee504fa1 100644--- a/apps/desktop/src/components/sidebar/SidebarTreeItemDialogs.vue+++ b/apps/desktop/src/components/sidebar/SidebarTreeItemDialogs.vue@@ -1,5 +1,9 @@<script setup lang="ts">import DdlStorageToggle from "@/components/objects/DdlStorageToggle.vue";+import OracleViewRenamePreview from "@/components/objects/OracleViewRenamePreview.vue";+import OracleRoutineRenamePreview from "@/components/objects/OracleRoutineRenamePreview.vue";+import OracleTableRenamePreview from "@/components/objects/OracleTableRenamePreview.vue";+import OraclePackageSaveAsDialog from "@/components/objects/OraclePackageSaveAsDialog.vue";import { structurePreviewDdlStorageType } from "./sidebarTreeDialogState";import { computed, toRefs, watch } from "vue";import { AlertTriangle, Check, Loader2, Clipboard, Plus, Trash2, Upload } from "@lucide/vue";@@ -36,6 +40,38 @@ const {renameObjectPreviewSql,renameObjectError,confirmRenameObject,+ viewRenamePlan,+ viewRenameDrafts,+ routineRenamePlan,+ routineRenameDrafts,+ tableRenamePlan,+ tableRenameDrafts,+ packageSaveAsOpen,+ packageSaveAsTarget,+ packageSaveAsName,+ packageSaveAsPlan,+ packageSaveAsDrafts,+ packageSaveAsLoading,+ packageSaveAsValidating,+ packageSaveAsExecuting,+ packageSaveAsError,+ packageSaveAsDiagnostic,+ confirmPackageSaveAs,+ editPackageSaveAsDraft,+ validatePackageSaveAsDrafts,+ viewRenameLoading,+ viewRenameValidating,+ viewRenameExecuting,+ isOracleViewRename,+ isOracleRoutineRename,+ isOracleTableRename,+ editSidebarViewRenameDraft,+ editSidebarRoutineRenameDraft,+ editSidebarTableRenameDraft,+ validateSidebarViewRenameDrafts,+ validateSidebarRoutineRenameDrafts,+ validateSidebarTableRenameDrafts,+ refreshRenameObjectPreviewSql,showStructurePreviewDialog,structurePreviewTitle,isLoadingStructurePreview,@@ -285,19 +321,73 @@ watch(</DialogContent></Dialog>+ <OraclePackageSaveAsDialog+ :open="packageSaveAsOpen"+ :old-name="packageSaveAsTarget?.objectName || packageSaveAsTarget?.label || ''"+ :new-name="packageSaveAsName"+ :plan="packageSaveAsPlan || null"+ :drafts="packageSaveAsDrafts"+ :error="packageSaveAsError"+ :diagnostic="packageSaveAsDiagnostic"+ :loading="packageSaveAsLoading"+ :validating="packageSaveAsValidating"+ :executing="packageSaveAsExecuting"+ @update:open="packageSaveAsOpen = $event"+ @update:new-name="packageSaveAsName = $event"+ @edit="editPackageSaveAsDraft"+ @validate="validatePackageSaveAsDrafts"+ @reload="validatePackageSaveAsDrafts"+ @confirm="confirmPackageSaveAs"+ /><Dialog v-model:open="showRenameObjectDialog">- <DialogContent class="sm:max-w-[420px]">+ <DialogContent :class="isOracleViewRename || isOracleRoutineRename || isOracleTableRename ? 'sm:max-w-[min(90vw,900px)]' : 'sm:max-w-[420px]'"><DialogHeader><DialogTitle>{{ renameObjectDialogTitle }}</DialogTitle></DialogHeader><div class="grid gap-3"><Input v-model="renameObjectName" :placeholder="t('contextMenu.renameObjectNamePlaceholder')" @keydown.enter.prevent="confirmRenameObject" />- <pre v-if="renameObjectPreviewSql" class="max-h-32 min-w-0 max-w-full overflow-auto rounded bg-muted p-3 text-xs whitespace-pre-wrap" v-html="highlight(renameObjectPreviewSql)"></pre>+ <OracleViewRenamePreview+ v-if="isOracleViewRename"+ :plan="viewRenamePlan || null"+ :drafts="viewRenameDrafts"+ :loading="viewRenameLoading"+ :validating="viewRenameValidating"+ :executing="viewRenameExecuting"+ @edit="editSidebarViewRenameDraft"+ @validate="validateSidebarViewRenameDrafts()"+ @reload="validateSidebarViewRenameDrafts()"+ />+ <OracleRoutineRenamePreview+ v-else-if="isOracleRoutineRename"+ :plan="routineRenamePlan || null"+ :drafts="routineRenameDrafts"+ :loading="viewRenameLoading"+ :validating="viewRenameValidating"+ :executing="viewRenameExecuting"+ @edit="editSidebarRoutineRenameDraft"+ @validate="validateSidebarRoutineRenameDrafts"+ @reload="refreshRenameObjectPreviewSql()"+ />+ <OracleTableRenamePreview+ v-else-if="isOracleTableRename"+ :plan="tableRenamePlan || null"+ :drafts="tableRenameDrafts"+ :loading="viewRenameLoading"+ :validating="viewRenameValidating"+ :executing="viewRenameExecuting"+ @edit="editSidebarTableRenameDraft"+ @validate="validateSidebarTableRenameDrafts()"+ @reload="validateSidebarTableRenameDrafts()"+ />+ <pre v-else-if="renameObjectPreviewSql" class="max-h-32 min-w-0 max-w-full overflow-auto rounded bg-muted p-3 text-xs whitespace-pre-wrap" v-html="highlight(renameObjectPreviewSql)"></pre><p v-if="renameObjectError" class="min-w-0 max-w-full overflow-x-auto text-sm text-destructive">{{ renameObjectError }}</p></div><DialogFooter><Button variant="outline" @click="showRenameObjectDialog = false">{{ t("dangerDialog.cancel") }}</Button>- <Button :disabled="!renameObjectName.trim() || renameObjectName.trim() === node.label" @click="confirmRenameObject">+ <Button+ :disabled="!renameObjectName.trim() || renameObjectName.trim() === node.label || viewRenameExecuting || (isOracleViewRename && !viewRenamePlan?.executable) || (isOracleRoutineRename && !routineRenamePlan?.executable) || (isOracleTableRename && !tableRenamePlan?.executable)"+ @click="confirmRenameObject"+ >{{ t("contextMenu.renameObject") }}</Button></DialogFooter>diff --git a/apps/desktop/src/components/sidebar/SidebarTreeRuntimeHost.vue b/apps/desktop/src/components/sidebar/SidebarTreeRuntimeHost.vueindex f88bb3365c..7e9f436cdd 100644--- a/apps/desktop/src/components/sidebar/SidebarTreeRuntimeHost.vue+++ b/apps/desktop/src/components/sidebar/SidebarTreeRuntimeHost.vue@@ -199,7 +199,12 @@ import type { DuplicateTableStructurePlan } from "@/lib/database/dbAdminSql";import { useOceanbaseCloneDialog } from "@/composables/useOceanbaseCloneDialog";import DangerConfirmDialog from "@/components/editor/DangerConfirmDialog.vue";import { buildRenameObjectSql, buildRenameDatabaseSql, buildRenameDatabasePreflightSql, databaseRenameMaintenanceDatabase, supportsDatabaseRename, supportsObjectRename, type RenameableObjectType } from "@/lib/table/objectRenameSql";-import { buildRoutineRenameObjectSourceStatements, supportsSourceBackedRoutineRename } from "@/lib/table/objectSourceEditor";+import { prepareOracleViewRename, executeOracleViewRename, OracleViewRenameFailure, type OracleViewRenamePlan } from "@/lib/table/oracleViewRename";+import { prepareOracleRoutineRename, executeOracleRoutineRename, OracleRoutineRenameFailure, type OracleRoutineRenamePlan } from "@/lib/table/oracleRoutineRename";+import { prepareOracleTableRename, executeOracleTableRename, OracleTableRenameFailure, type OracleTableRenamePlan } from "@/lib/table/oracleTableRename";+import { executeOraclePackageSaveAs, OraclePackageSaveAsFailure, prepareOraclePackageSaveAs, type OraclePackageSaveAsPlan } from "@/lib/table/oraclePackageSaveAs";+import { buildRoutineRenameObjectSourceStatements, executeObjectSourceSave, supportsSourceBackedRoutineRename } from "@/lib/table/objectSourceEditor";+import { freezeSourceIdentities } from "@/lib/table/objectSourceIdentity";import { buildViewDdl } from "@/lib/table/viewDdl";import { formatSqlForDisplay, sqlFormatDialectForDbType } from "@/lib/sql/sqlFormatter";import { getTableStructureCapabilities } from "@/lib/table/tableStructureCapabilities";@@ -3424,35 +3429,64 @@ function requestDropSelectedNode(): boolean {return false;}-function nodeRenameObjectType(): RenameableObjectType | null {- if (activeNode.value.type === "table") return "TABLE";- if (activeNode.value.type === "view") return "VIEW";- if (activeNode.value.type === "materialized_view") return "MATERIALIZED_VIEW";- if (activeNode.value.type === "procedure") return "PROCEDURE";- if (activeNode.value.type === "function") return "FUNCTION";+function nodeRenameObjectType(node: TreeNode = activeNode.value): RenameableObjectType | null {+ if (node.type === "table") return "TABLE";+ if (node.type === "view") return "VIEW";+ if (node.type === "materialized_view") return "MATERIALIZED_VIEW";+ if (node.type === "procedure") return "PROCEDURE";+ if (node.type === "function") return "FUNCTION";return null;}const canRenameObject = computed(() => {- const objectType = nodeRenameObjectType();- return !!objectType && (supportsObjectRename(currentDatabaseType(), objectType) || supportsSourceBackedRoutineRename(currentDatabaseType(), objectType as any));+ const node = activeNode.value;+ const objectType = nodeRenameObjectType(node);+ return !!objectType && (supportsObjectRename(currentDatabaseType(), objectType) || (databaseTypeForNode(node) === "oceanbase-oracle" && (objectType === "PROCEDURE" || objectType === "FUNCTION")) || supportsSourceBackedRoutineRename(currentDatabaseType(), objectType as any));});function openRenameObjectDialog() {claimTreeItemDialogOwnership();routeTreeItemDialogController();- renameObjectName.value = activeNode.value.label;+ const node = sidebarFormTarget.value ?? activeNode.value;+ const targetKey = JSON.stringify([node.connectionId, node.database, node.schema || node.database, node.type, node.objectName || node.label, databaseTypeForNode(node)]);+ if (targetKey !== currentSidebarViewRenameTargetKey) renameObjectName.value = node.label;renameObjectError.value = "";renameObjectPreviewSql.value = "";+ viewRenamePlan.value = undefined;+ routineRenamePlan.value = undefined;+ tableRenamePlan.value = undefined;showRenameObjectDialog.value = true;}+let currentPackageSaveAsSourceKey = "";+function openPackageSaveAsDialog(node = activeNode.value) {+ if ((databaseTypeForNode(node) !== "oracle" && databaseTypeForNode(node) !== "oceanbase-oracle") || (node.type !== "package" && node.type !== "package-body")) return;+ const oldName = node.objectName || node.label;+ const sourceKey = JSON.stringify([node.connectionId, node.database, node.schema || node.database, oldName, databaseTypeForNode(node)]);+ const sameTarget = sourceKey === currentPackageSaveAsSourceKey;+ currentPackageSaveAsSourceKey = sourceKey;+ claimTreeItemDialogOwnership();+ routeTreeItemDialogController();+ packageSaveAsTarget.value = node;+ if (!sameTarget) {+ packageSaveAsName.value = `${oldName}_COPY`;+ packageSaveAsDrafts.value = {};+ }+ packageSaveAsPlan.value = undefined;+ packageSaveAsError.value = "";+ packageSaveAsDiagnostic.value = "";+ packageSaveAsOpen.value = true;+}+function openRenameDatabaseDialog() {claimTreeItemDialogOwnership();routeTreeItemDialogController();renameObjectName.value = activeNode.value.label;renameObjectError.value = "";renameObjectPreviewSql.value = "";+ viewRenamePlan.value = undefined;+ viewRenameDrafts.value = {};+ routineRenamePlan.value = undefined;showRenameObjectDialog.value = true;}@@ -3501,13 +3535,36 @@ async function executeTreeNodeSqlWithProductionGuard(}let renameObjectPreviewRequestId = 0;+let currentSidebarViewRenameTargetKey = "";+const viewRenamePlan = ref<OracleViewRenamePlan>();+const viewRenameDrafts = ref<Record<string, string>>({});+const routineRenamePlan = ref<OracleRoutineRenamePlan>();+const routineRenameDrafts = ref<Record<string, string>>({});+const tableRenamePlan = ref<OracleTableRenamePlan>();+const tableRenameDrafts = ref<Record<string, string>>({});+const packageSaveAsOpen = ref(false);+const packageSaveAsTarget = ref<TreeNode | null>(null);+const packageSaveAsName = ref("");+const packageSaveAsPlan = ref<OraclePackageSaveAsPlan>();+const packageSaveAsDrafts = ref<{ spec?: string; body?: string }>({});+const packageSaveAsLoading = ref(false);+const packageSaveAsExecuting = ref(false);+const packageSaveAsError = ref("");+const packageSaveAsDiagnostic = ref("");+const viewRenameLoading = ref(false);+const viewRenameValidating = ref(false);+const packageSaveAsValidating = ref(false);+const viewRenameExecuting = ref(false);async function refreshRenameObjectPreviewSql() {- const node = activeNode.value;+ const node = sidebarFormTarget.value ?? activeNode.value;const requestId = ++renameObjectPreviewRequestId;const newName = renameObjectName.value.trim();if (!showRenameObjectDialog.value || !newName || newName === node.label) {renameObjectPreviewSql.value = "";+ viewRenamePlan.value = undefined;+ routineRenamePlan.value = undefined;+ tableRenamePlan.value = undefined;return;}// Database rename path@@ -3524,16 +3581,63 @@ async function refreshRenameObjectPreviewSql() {}return;}- const objectType = nodeRenameObjectType();+ const objectType = nodeRenameObjectType(node);if (!objectType) {renameObjectPreviewSql.value = "";return;}+ if ((databaseTypeForNode(node) === "oracle" || databaseTypeForNode(node) === "oceanbase-oracle") && (objectType === "PROCEDURE" || objectType === "FUNCTION") && node.connectionId && node.database) {+ const targetKey = JSON.stringify([node.connectionId, node.database, node.schema || node.database, objectType, node.objectName || node.label, newName]);+ const drafts = { ...routineRenameDrafts.value };+ viewRenameLoading.value = true;+ try {+ const plan = await prepareOracleRoutineRename({ connectionId: node.connectionId, database: node.database, databaseType: databaseTypeForNode(node) as "oracle" | "oceanbase-oracle", schema: node.schema || node.database, objectType, oldName: node.objectName || node.label, newName }, drafts);+ const currentNode = sidebarFormTarget.value ?? activeNode.value;+ const currentTargetKey = JSON.stringify([currentNode.connectionId, currentNode.database, currentNode.schema || currentNode.database, nodeRenameObjectType(currentNode), currentNode.objectName || currentNode.label, renameObjectName.value.trim()]);+ if (requestId === renameObjectPreviewRequestId && showRenameObjectDialog.value && targetKey === currentTargetKey && JSON.stringify(drafts) === JSON.stringify(routineRenameDrafts.value)) {+ routineRenamePlan.value = plan;+ renameObjectError.value = "";+ renameObjectPreviewSql.value = plan.statements.join("\n\n");+ }+ } catch (error) {+ if (requestId === renameObjectPreviewRequestId) renameObjectError.value = error instanceof Error ? error.message : String(error);+ } finally {+ if (requestId === renameObjectPreviewRequestId) viewRenameLoading.value = false;+ }+ return;+ }+ if ((databaseTypeForNode(node) === "oracle" || databaseTypeForNode(node) === "oceanbase-oracle") && objectType === "TABLE" && node.connectionId && node.database) {+ viewRenameLoading.value = true;+ try {+ const databaseType = databaseTypeForNode(node) as "oracle" | "oceanbase-oracle";+ const plan = await prepareOracleTableRename({ connectionId: node.connectionId, database: node.database, databaseType, schema: node.schema || node.database, oldName: node.objectName || node.label, newName }, tableRenameDrafts.value);+ if (requestId === renameObjectPreviewRequestId) {+ tableRenamePlan.value = plan;+ renameObjectError.value = "";+ renameObjectPreviewSql.value = `-- ${t("objects.tableRenameCoverage")}\n\n${plan.statements.join("\n\n")}`;+ }+ } catch (error) {+ if (requestId === renameObjectPreviewRequestId) renameObjectError.value = error instanceof Error ? error.message : String(error);+ } finally {+ if (requestId === renameObjectPreviewRequestId) viewRenameLoading.value = false;+ }+ return;+ }if (supportsSourceBackedRoutineRename(currentDatabaseType(), objectType as any)) {- renameObjectPreviewSql.value = `-- Recreate ${objectType} from source, then drop the original object.`;+ renameObjectPreviewSql.value = t("objects.routineRenamePreview");return;}try {+ if (databaseTypeForNode(node) === "oceanbase-oracle" && objectType === "VIEW" && node.connectionId && node.database) {+ viewRenameLoading.value = true;+ const plan = await prepareOracleViewRename({ connectionId: node.connectionId, database: node.database, schema: node.schema || node.database, oldName: node.objectName || node.label, newName }, viewRenameDrafts.value);+ if (requestId === renameObjectPreviewRequestId) {+ viewRenamePlan.value = plan;+ renameObjectError.value = "";+ renameObjectPreviewSql.value = `-- ${t("objects.viewRenameCoverage")}\n\n${plan.statements.join("\n\n")}`;+ }+ return;+ }const sql = await buildRenameObjectSql({databaseType: currentDatabaseType(),objectType,@@ -3542,23 +3646,249 @@ async function refreshRenameObjectPreviewSql() {newName,});if (requestId === renameObjectPreviewRequestId) renameObjectPreviewSql.value = sql;- } catch {- if (requestId === renameObjectPreviewRequestId) renameObjectPreviewSql.value = "";+ } catch (error) {+ if (requestId === renameObjectPreviewRequestId) {+ renameObjectPreviewSql.value = "";+ if (databaseTypeForNode(node) === "oceanbase-oracle" && objectType === "VIEW") renameObjectError.value = error instanceof Error ? error.message : String(error);+ }+ } finally {+ if (requestId === renameObjectPreviewRequestId) viewRenameLoading.value = false;}}-watch([showRenameObjectDialog, renameObjectName, () => activeNode.value.label, () => activeNode.value.schema, () => activeNode.value.type, () => currentDatabaseType()], () => {- void refreshRenameObjectPreviewSql();-});+function editSidebarViewRenameDraft(name: string, source: string) {+ viewRenameDrafts.value = { ...viewRenameDrafts.value, [name]: source };+ if (viewRenamePlan.value) viewRenamePlan.value = { ...viewRenamePlan.value, executable: false };+}++function editSidebarTableRenameDraft(name: string, source: string) {+ tableRenameDrafts.value = { ...tableRenameDrafts.value, [name]: source };+ if (tableRenamePlan.value) tableRenamePlan.value = { ...tableRenamePlan.value, executable: false };+}++function editSidebarRoutineRenameDraft(name: string, source: string) {+ routineRenameDrafts.value = { ...routineRenameDrafts.value, [name]: source };+ ++renameObjectPreviewRequestId;+ if (routineRenamePlan.value) routineRenamePlan.value = { ...routineRenamePlan.value, executable: false };+}++async function validateSidebarRoutineRenameDrafts() {+ if (routineRenamePlan.value) routineRenamePlan.value = { ...routineRenamePlan.value, executable: false };+ viewRenameValidating.value = true;+ try {+ await refreshRenameObjectPreviewSql();+ } finally {+ viewRenameValidating.value = false;+ }+}++async function validateSidebarTableRenameDrafts(clearDrafts = false) {+ if (clearDrafts) tableRenameDrafts.value = {};+ viewRenameValidating.value = true;+ try {+ await refreshRenameObjectPreviewSql();+ } finally {+ viewRenameValidating.value = false;+ }+}++async function validateSidebarViewRenameDrafts(clearDrafts = false) {+ if (clearDrafts) viewRenameDrafts.value = {};+ viewRenameValidating.value = true;+ try {+ await refreshRenameObjectPreviewSql();+ } finally {+ viewRenameValidating.value = false;+ }+}++watch(+ () => {+ const target = sidebarFormTarget.value ?? activeNode.value;+ return [showRenameObjectDialog.value, renameObjectName.value, target.connectionId, target.database, target.schema, target.type, target.objectName, target.label, databaseTypeForNode(target)];+ },+ (_value, _oldValue, onCleanup) => {+ ++renameObjectPreviewRequestId;+ const target = sidebarFormTarget.value ?? activeNode.value;+ const targetKey =+ ((databaseTypeForNode(target) === "oracle" || databaseTypeForNode(target) === "oceanbase-oracle") && ["procedure", "function", "table"].includes(target.type)) || (databaseTypeForNode(target) === "oceanbase-oracle" && target.type === "view")+ ? JSON.stringify([target.connectionId, target.database, target.schema || target.database, target.type, target.objectName || target.label, databaseTypeForNode(target)])+ : "";+ if (targetKey !== currentSidebarViewRenameTargetKey) {+ currentSidebarViewRenameTargetKey = targetKey;+ viewRenameDrafts.value = {};+ viewRenamePlan.value = undefined;+ routineRenamePlan.value = undefined;+ tableRenamePlan.value = undefined;+ routineRenameDrafts.value = {};+ tableRenameDrafts.value = {};+ } else if (viewRenamePlan.value) viewRenamePlan.value = { ...viewRenamePlan.value, executable: false };+ if (routineRenamePlan.value) routineRenamePlan.value = { ...routineRenamePlan.value, executable: false };+ if (tableRenamePlan.value) tableRenamePlan.value = { ...tableRenamePlan.value, executable: false };+ const databaseType = databaseTypeForNode(target);+ const supportedTarget = ((databaseType === "oracle" || databaseType === "oceanbase-oracle") && (target.type === "table" || target.type === "procedure" || target.type === "function")) || (databaseType === "oceanbase-oracle" && target.type === "view");+ if (!supportedTarget) {+ viewRenamePlan.value = undefined;+ routineRenamePlan.value = undefined;+ tableRenamePlan.value = undefined;+ void refreshRenameObjectPreviewSql();+ return;+ }+ const timer = setTimeout(() => void refreshRenameObjectPreviewSql(), 250);+ onCleanup(() => clearTimeout(timer));+ },+);++let packageSaveAsPreviewRequestId = 0;+watch(+ () => {+ const target = packageSaveAsTarget.value;+ return [packageSaveAsOpen.value, packageSaveAsName.value, target?.connectionId, target?.database, target?.schema, target?.type, target?.objectName, target?.label, target ? databaseTypeForNode(target) : undefined];+ },+ (_value, _oldValue, onCleanup) => {+ const requestId = ++packageSaveAsPreviewRequestId;+ const target = packageSaveAsTarget.value;+ const newName = packageSaveAsName.value.trim();+ const oldName = target?.objectName || target?.label || "";+ const sourceKey = target ? JSON.stringify([target.connectionId, target.database, target.schema || target.database, oldName, databaseTypeForNode(target)]) : "";+ if (sourceKey && sourceKey !== currentPackageSaveAsSourceKey) {+ currentPackageSaveAsSourceKey = sourceKey;+ packageSaveAsDrafts.value = {};+ }+ packageSaveAsPlan.value = undefined;+ packageSaveAsError.value = "";+ packageSaveAsDiagnostic.value = "";+ if (!packageSaveAsOpen.value || !target || !target.connectionId || !target.database || !newName) return;+ const databaseType = databaseTypeForNode(target);+ if ((databaseType !== "oracle" && databaseType !== "oceanbase-oracle") || (target.type !== "package" && target.type !== "package-body") || newName === oldName) return;+ const timer = setTimeout(async () => {+ packageSaveAsLoading.value = true;+ const drafts = { ...packageSaveAsDrafts.value };+ try {+ const plan = await prepareOraclePackageSaveAs({ connectionId: target.connectionId!, database: target.database!, databaseType, schema: target.schema || target.database!, oldName, newName }, drafts);+ if (requestId === packageSaveAsPreviewRequestId && packageSaveAsTarget.value === target && packageSaveAsName.value.trim() === newName && JSON.stringify(packageSaveAsDrafts.value) === JSON.stringify(drafts)) packageSaveAsPlan.value = plan;+ } catch (error) {+ if (requestId === packageSaveAsPreviewRequestId) packageSaveAsDiagnostic.value = error instanceof Error ? error.message : String(error);+ } finally {+ if (requestId === packageSaveAsPreviewRequestId) packageSaveAsLoading.value = false;+ }+ }, 250);+ onCleanup(() => clearTimeout(timer));+ },+);++function editPackageSaveAsDraft(part: "spec" | "body", source: string) {+ packageSaveAsDrafts.value = { ...packageSaveAsDrafts.value, [part]: source };+ ++packageSaveAsPreviewRequestId;+ if (packageSaveAsPlan.value) packageSaveAsPlan.value = { ...packageSaveAsPlan.value, executable: false };+}++async function validatePackageSaveAsDrafts() {+ const target = packageSaveAsTarget.value;+ const newName = packageSaveAsName.value.trim();+ if (!target?.connectionId || !target.database || !newName) return;+ const databaseType = databaseTypeForNode(target);+ if (databaseType !== "oracle" && databaseType !== "oceanbase-oracle") return;+ const oldName = target.objectName || target.label;+ if (newName === oldName) return;+ const requestId = ++packageSaveAsPreviewRequestId;+ const drafts = { ...packageSaveAsDrafts.value };+ const targetKey = JSON.stringify([target.connectionId, target.database, target.schema || target.database, oldName, databaseType]);+ packageSaveAsValidating.value = true;+ try {+ const plan = await prepareOraclePackageSaveAs({ connectionId: target.connectionId, database: target.database, databaseType, schema: target.schema || target.database, oldName, newName }, drafts);+ const current = packageSaveAsTarget.value;+ const currentKey = current ? JSON.stringify([current.connectionId, current.database, current.schema || current.database, current.objectName || current.label, databaseTypeForNode(current)]) : "";+ if (requestId === packageSaveAsPreviewRequestId && packageSaveAsTarget.value === target && packageSaveAsOpen.value && packageSaveAsName.value.trim() === newName && targetKey === currentKey && JSON.stringify(packageSaveAsDrafts.value) === JSON.stringify(drafts)) packageSaveAsPlan.value = plan;+ } catch (error) {+ packageSaveAsDiagnostic.value = error instanceof Error ? error.message : String(error);+ } finally {+ packageSaveAsValidating.value = false;+ }+}++async function confirmPackageSaveAs() {+ const target = packageSaveAsTarget.value;+ const plan = packageSaveAsPlan.value;+ if (!target || !target.connectionId || !target.database || !plan?.executable || !packageSaveAsOpen.value) return;+ if (plan.target.connectionId !== target.connectionId || plan.target.database !== target.database || plan.target.schema !== (target.schema || target.database) || plan.target.oldName !== (target.objectName || target.label) || plan.target.newName !== packageSaveAsName.value.trim()) {+ packageSaveAsError.value = t("objects.packageSaveAsMetadataProblem");+ return;+ }+ packageSaveAsExecuting.value = true;+ packageSaveAsError.value = "";+ packageSaveAsDiagnostic.value = "";+ const isCurrentPlan = () => {+ const current = packageSaveAsTarget.value;+ return (+ packageSaveAsOpen.value &&+ packageSaveAsPlan.value === plan &&+ !!current &&+ current.connectionId === plan.target.connectionId &&+ current.database === plan.target.database &&+ (current.schema || current.database) === plan.target.schema &&+ (current.objectName || current.label) === plan.target.oldName &&+ databaseTypeForNode(current) === plan.target.databaseType &&+ packageSaveAsName.value.trim() === plan.target.newName+ );+ };+ try {+ await connectionStore.ensureConnected(target.connectionId);+ const executed = await executeTreeNodeSqlWithProductionGuard(target, plan.statements.join("\n\n"), {+ execute: async () => {+ await executeOraclePackageSaveAs(plan, () => {+ const current = packageSaveAsTarget.value;+ return (+ packageSaveAsPlan.value === plan &&+ packageSaveAsOpen.value &&+ !!current &&+ current.connectionId === plan.target.connectionId &&+ current.database === plan.target.database &&+ (current.schema || current.database) === plan.target.schema &&+ (current.objectName || current.label) === plan.target.oldName &&+ packageSaveAsName.value.trim() === plan.target.newName &&+ databaseTypeForNode(current) === plan.target.databaseType+ );+ });+ return { columns: [], rows: [], affected_rows: 0, execution_time_ms: 0 };+ },+ });+ if (!executed) return;+ toast(t("objects.packageSaveAsSuccess", { oldName: plan.target.oldName, newName: plan.canonicalNewName }));+ packageSaveAsOpen.value = false;+ await connectionStore.refreshObjectListTreeNode(target.connectionId, target.database, target.schema || target.database);+ } catch (error) {+ if (isCurrentPlan()) {+ packageSaveAsError.value = t("objects.packageSaveAsFailed");+ packageSaveAsDiagnostic.value = error instanceof Error ? error.message : String(error);+ packageSaveAsPlan.value = { ...plan, executable: false };+ }+ if (error instanceof OraclePackageSaveAsFailure && error.dispatched) {+ try {+ await connectionStore.refreshObjectListTreeNode(plan.target.connectionId, plan.target.database, plan.target.schema);+ } catch {+ // Keep the package DDL failure visible when metadata refresh also fails.+ }+ }+ } finally {+ packageSaveAsExecuting.value = false;+ }+}async function confirmRenameObject() {const node = sidebarFormTarget.value ?? activeNode.value;- const newName = renameObjectName.value.trim();+ let newName = renameObjectName.value.trim();if (!newName || newName === node.label || !node.connectionId || !node.database) return;renameObjectError.value = "";let renameApplied = false;+ let updatedViewDependencies: number | undefined;+ let updatedTableDependencies: number | undefined;+ let tableRenameFreeze: ReturnType<typeof freezeSourceIdentities> | undefined;try {const dbType = databaseTypeForNode(node);+ if (node.type === "table" && dbType === "dameng") {+ tableRenameFreeze = freezeSourceIdentities([{ connectionId: node.connectionId, database: node.database, schema: node.schema || node.database, objectType: "TABLE", name: node.label }]);+ }await connectionStore.ensureConnected(node.connectionId);// Database rename path@@ -3613,9 +3943,79 @@ async function confirmRenameObject() {return;}- const objectType = node.type === "table" ? "TABLE" : node.type === "view" ? "VIEW" : node.type === "materialized_view" ? "MATERIALIZED_VIEW" : node.type === "procedure" ? "PROCEDURE" : node.type === "function" ? "FUNCTION" : null;+ const objectType = nodeRenameObjectType(node);if (!objectType) return;- if (supportsSourceBackedRoutineRename(dbType, objectType as any)) {+ if ((dbType === "oracle" || dbType === "oceanbase-oracle") && objectType === "TABLE") {+ const plan = tableRenamePlan.value;+ const schema = node.schema || node.database;+ if (!plan || plan.target.newName !== newName || plan.target.oldName !== (node.objectName || node.label) || plan.target.schema !== schema || plan.target.connectionId !== node.connectionId || plan.target.database !== node.database) throw new Error(t("objects.viewRenameRefresh"));+ if (!plan.executable) throw new Error(t("objects.viewRenameValidationPending"));+ viewRenameExecuting.value = true;+ const executed = await executeTreeNodeSqlWithProductionGuard(node, plan.statements.join("\n\n"), {+ database: node.database,+ schema,+ execute: async () => {+ await executeOracleTableRename(plan, tableRenameDrafts.value, () => {+ const current = sidebarFormTarget.value ?? activeNode.value;+ return (+ tableRenamePlan.value === plan &&+ showRenameObjectDialog.value &&+ current.connectionId === plan.target.connectionId &&+ current.database === plan.target.database &&+ (current.schema || current.database) === plan.target.schema &&+ (current.objectName || current.label) === plan.target.oldName+ );+ });+ return { columns: [], rows: [], affected_rows: 0, execution_time_ms: 0 };+ },+ });+ if (executed === undefined) return;+ newName = plan.canonicalNewName;+ updatedTableDependencies = plan.dependents.length;+ } else if (dbType === "oceanbase-oracle" && objectType === "VIEW") {+ const plan = viewRenamePlan.value;+ if (!plan || plan.target.newName !== newName || plan.target.oldName !== (node.objectName || node.label) || plan.target.schema !== (node.schema || node.database) || plan.target.connectionId !== node.connectionId || plan.target.database !== node.database)+ throw new Error(t("objects.viewRenameRefresh"));+ if (!plan.executable) throw new Error(t("objects.viewRenameValidationPending"));+ viewRenameExecuting.value = true;+ const executed = await executeTreeNodeSqlWithProductionGuard(node, plan.statements.join("\n"), {+ execute: async () => {+ await executeOracleViewRename(plan, () => viewRenamePlan.value === plan && showRenameObjectDialog.value && (sidebarFormTarget.value ?? activeNode.value).connectionId === plan.target.connectionId && (sidebarFormTarget.value ?? activeNode.value).database === plan.target.database);+ return { columns: [], rows: [], affected_rows: 0, execution_time_ms: 0 };+ },+ });+ if (executed === undefined) return;+ newName = plan.canonicalNewName;+ updatedViewDependencies = plan.views.length - 1;+ } else if ((dbType === "oracle" || dbType === "oceanbase-oracle") && (objectType === "PROCEDURE" || objectType === "FUNCTION")) {+ const plan = routineRenamePlan.value;+ const schema = node.schema || node.database;+ if (!plan || plan.target.newName !== newName || plan.target.oldName !== (node.objectName || node.label) || plan.target.schema !== schema || plan.target.connectionId !== node.connectionId || plan.target.database !== node.database) throw new Error(t("objects.viewRenameRefresh"));+ if (!plan.executable) throw new Error(t("objects.viewRenameValidationPending"));+ viewRenameExecuting.value = true;+ const executed = await executeTreeNodeSqlWithProductionGuard(node, plan.statements.join("\n\n"), {+ database: node.database,+ schema,+ execute: async () => {+ await executeOracleRoutineRename(plan, () => {+ const current = sidebarFormTarget.value ?? activeNode.value;+ const currentType = nodeRenameObjectType(current);+ return (+ routineRenamePlan.value === plan &&+ showRenameObjectDialog.value &&+ current.connectionId === plan.target.connectionId &&+ current.database === plan.target.database &&+ (current.schema || current.database) === plan.target.schema &&+ (current.objectName || current.label) === plan.target.oldName &&+ currentType === plan.target.objectType+ );+ });+ return { columns: [], rows: [], affected_rows: 0, execution_time_ms: 0 };+ },+ });+ if (executed === undefined) return;+ newName = plan.canonicalNewName;+ } else if (supportsSourceBackedRoutineRename(dbType, objectType as any)) {const schema = node.schema || node.database;const source = await api.getObjectSource(node.connectionId, node.database, schema, node.objectName || node.label, objectType as any, node.signature);const statements = await buildRoutineRenameObjectSourceStatements({@@ -3626,9 +4026,15 @@ async function confirmRenameObject() {newName,source: source.source,});- for (const sql of statements) {- await executeTreeNodeSqlWithProductionGuard(node, sql, { database: node.database, schema });- }+ const executed = await executeTreeNodeSqlWithProductionGuard(node, statements.join(";\n"), {+ database: node.database,+ schema,+ execute: async (timeoutSecs) => {+ await executeObjectSourceSave(node.connectionId!, node.database!, dbType!, statements, schema, timeoutSecs);+ return { columns: [], rows: [], affected_rows: 0, execution_time_ms: 0 };+ },+ });+ if (executed === undefined) return;} else {const sql = await buildRenameObjectSql({databaseType: dbType,@@ -3637,21 +4043,51 @@ async function confirmRenameObject() {oldName: node.label,newName,});- await executeTreeNodeSqlWithProductionGuard(node, sql, { database: node.database, schema: node.schema });+ const executed = await executeTreeNodeSqlWithProductionGuard(node, sql, {+ database: node.database,+ schema: node.schema,+ markDispatched: () => tableRenameFreeze?.markDispatched(),+ });+ if (executed === undefined) return;}renameApplied = true;- toast(t("contextMenu.renameObjectSuccess", { oldName: node.label, newName }), 3000);+ toast(+ updatedTableDependencies !== undefined+ ? t("objects.tableRenameSuccess", { oldName: node.label, newName, count: updatedTableDependencies })+ : updatedViewDependencies !== undefined+ ? t("objects.viewRenameSuccess", { oldName: node.label, newName, count: updatedViewDependencies })+ : t("contextMenu.renameObjectSuccess", { oldName: node.label, newName }),+ 3000,+ );showRenameObjectDialog.value = false;const renamedNode: TreeNode = { ...node, label: newName, objectName: newName, tableName: newName };await refreshTableList(node);connectionStore.replacePinnedTreeNode(node, renamedNode);} catch (e: any) {+ if (e instanceof OracleViewRenameFailure) {+ connectionStore.removePinnedTreeNodes([node]);+ renameObjectPreviewSql.value += `\n\n-- ${t("objects.viewRenameRecovery")}\n${e.plan.views.map((view) => view.source).join("\n\n")}`;+ }+ if (e instanceof OracleRoutineRenameFailure) {+ renameObjectError.value = e.message;+ if (routineRenamePlan.value) routineRenamePlan.value = { ...routineRenamePlan.value, executable: false };+ }+ if (e instanceof OracleTableRenameFailure) {+ renameObjectError.value = e.message;+ if (tableRenamePlan.value) tableRenamePlan.value = { ...tableRenamePlan.value, executable: false };+ if (e.completed.some((step) => step.startsWith("TABLE "))) connectionStore.removePinnedTreeNodes([node]);+ }+ if (viewRenamePlan.value) viewRenamePlan.value = { ...viewRenamePlan.value, executable: false, issues: [...viewRenamePlan.value.issues, { code: "metadata_drift", message: e?.message || String(e), repairable: false }] };if (renameApplied) {// The database mutation succeeded even when metadata refresh did not;// remove the old pin instead of allowing it to revive later.connectionStore.removePinnedTreeNodes([node]);}renameObjectError.value = e?.message || String(e);+ } finally {+ tableRenameFreeze?.cancel();+ tableRenameFreeze?.finish();+ viewRenameExecuting.value = false;}}@@ -5725,12 +6161,51 @@ function connectionDialogCapabilities() {}function objectDialogCapabilities() {+ const renameTarget = computed(() => sidebarFormTarget.value ?? activeNode.value);return {showRenameObjectDialog,renameObjectName,renameObjectDialogTitle,renameObjectPreviewSql,renameObjectError,+ viewRenamePlan,+ viewRenameDrafts,+ routineRenamePlan,+ routineRenameDrafts,+ tableRenamePlan,+ tableRenameDrafts,+ packageSaveAsOpen,+ packageSaveAsTarget,+ packageSaveAsName,+ packageSaveAsPlan,+ packageSaveAsDrafts,+ packageSaveAsLoading,+ packageSaveAsExecuting,+ packageSaveAsValidating,+ packageSaveAsError,+ packageSaveAsDiagnostic,+ confirmPackageSaveAs,+ viewRenameLoading,+ viewRenameValidating,+ viewRenameExecuting,+ isOracleViewRename: computed(() => databaseTypeForNode(renameTarget.value) === "oceanbase-oracle" && renameTarget.value.type === "view"),+ isOracleRoutineRename: computed(() => {+ const target = renameTarget.value;+ return (databaseTypeForNode(target) === "oracle" || databaseTypeForNode(target) === "oceanbase-oracle") && (target.type === "procedure" || target.type === "function");+ }),+ isOracleTableRename: computed(() => {+ const target = renameTarget.value;+ return (databaseTypeForNode(target) === "oracle" || databaseTypeForNode(target) === "oceanbase-oracle") && target.type === "table";+ }),+ editSidebarViewRenameDraft,+ editSidebarTableRenameDraft,+ editSidebarRoutineRenameDraft,+ editPackageSaveAsDraft,+ validateSidebarViewRenameDrafts,+ validateSidebarTableRenameDrafts,+ validateSidebarRoutineRenameDrafts,+ validatePackageSaveAsDrafts,+ refreshRenameObjectPreviewSql,confirmRenameObject,showStructurePreviewDialog,structurePreviewTitle,@@ -7073,6 +7548,9 @@ function buildObjectSidebarMenu(context: SidebarMenuFactoryContext): boolean {}if (node.type === "trigger" || node.type === "package" || node.type === "package-body") {+ if ((databaseTypeForNode(node) === "oracle" || databaseTypeForNode(node) === "oceanbase-oracle") && (node.type === "package" || node.type === "package-body")) {+ items.push({ label: t("objects.packageSaveAsTitle"), action: () => openPackageSaveAsDialog(node), icon: CopyPlus });+ }if (currentDatabaseType() === "xugu" && buildXuguCompileSql({ objectType: node.type, schema: node.schema, name: node.objectName || node.label })) {items.push({ label: t("contextMenu.compileObject"), action: compileXuguObject, icon: Wrench });}diff --git a/apps/desktop/src/components/sidebar/__tests__/SidebarTreeRuntimeHost.renameCancellation.spec.ts b/apps/desktop/src/components/sidebar/__tests__/SidebarTreeRuntimeHost.renameCancellation.spec.tsnew file mode 100644index 0000000000..ffe2fd7102--- /dev/null+++ b/apps/desktop/src/components/sidebar/__tests__/SidebarTreeRuntimeHost.renameCancellation.spec.ts@@ -0,0 +1,246 @@+// @vitest-environment happy-dom+import { createApp, defineComponent, h, nextTick, ref } from "vue";+import { createPinia, setActivePinia } from "pinia";+import { describe, expect, it, vi } from "vitest";+import i18n from "@/i18n";+import type { ContextMenuItem } from "@/components/ui/CustomContextMenu.vue";+import type { TreeNode } from "@/types/database";++const guard = vi.hoisted(() => vi.fn().mockResolvedValue(undefined));+vi.mock("@/lib/database/productionExecutionGuard", async (original) => ({ ...(await original<object>()), executeWithProductionSqlGuard: guard }));+vi.mock("@/lib/backend/api", async (original) => ({+ ...(await original<object>()),+ listPlugins: vi.fn().mockResolvedValue([]),+ getObjectSource: vi.fn().mockResolvedValue({ source: "CREATE PROCEDURE OLD AS BEGIN NULL; END;" }),+ buildRenameObjectSql: vi.fn().mockResolvedValue("ALTER TABLE OLD RENAME TO NEW"),+ buildRoutineRenameObjectSourceStatements: vi.fn().mockResolvedValue(["CREATE PROCEDURE NEW AS BEGIN NULL; END;", "DROP PROCEDURE OLD"]),+}));+vi.mock("@/lib/table/oracleRoutineRename", () => ({+ prepareOracleRoutineRename: vi.fn(async (target: any) => ({+ target,+ canonicalNewName: target.newName,+ root: { name: target.oldName, objectType: target.objectType, objectId: "1", source: "source", signature: "[]", grants: "[]", status: "VALID", errors: "[]" },+ rootDraft: "CREATE OR REPLACE PROCEDURE OWNER.OLD AS BEGIN NULL; END;",+ rootCreateSource: "CREATE PROCEDURE OWNER.NEW AS BEGIN NULL; END;",+ callers: [],+ dependencyEdges: [],+ statements: ["CREATE PROCEDURE NEW AS BEGIN NULL; END;"],+ steps: [],+ issues: [],+ metadataComplete: true,+ executable: true,+ })),+ executeOracleRoutineRename: vi.fn(),+ OracleRoutineRenameFailure: class extends Error {},+}));+import SidebarTreeRuntimeHost from "@/components/sidebar/SidebarTreeRuntimeHost.vue";+import { prepareOracleRoutineRename } from "@/lib/table/oracleRoutineRename";+import { useConnectionStore } from "@/stores/connectionStore";+import { assertSourceIdentity, captureSourceIdentity } from "@/lib/table/objectSourceIdentity";+import { renameObjectName, showRenameObjectDialog } from "../sidebarTreeDialogState";++describe("sidebar rename production cancellation", () => {+ it("updates Oracle rename capabilities when switching tree object types", async () => {+ const pinia = createPinia();+ setActivePinia(pinia);+ const store = useConnectionStore();+ store.connections = [{ id: "rename-switch-c", name: "Owner", db_type: "oceanbase-oracle", host: "localhost", port: 2881, username: "SYS" } as any];+ const host = ref<any>();+ let controller: any;+ const table: TreeNode = { id: "rename-switch-table", type: "table", label: "TABLE_OLD", tableName: "TABLE_OLD", connectionId: "rename-switch-c", database: "SYS", schema: "SYS" };+ const procedure: TreeNode = { id: "rename-switch-procedure", type: "procedure", label: "PROC_OLD", objectName: "PROC_OLD", connectionId: "rename-switch-c", database: "SYS", schema: "SYS" };+ const root = defineComponent({+ setup: () => () =>+ h(SidebarTreeRuntimeHost, {+ ref: host,+ node: table,+ depth: 0,+ onOpenDialogController: (value: unknown) => {+ controller = value;+ },+ }),+ });+ const container = document.createElement("div");+ document.body.appendChild(container);+ const app = createApp(root).use(pinia).use(i18n);+ const openRename = (node: TreeNode) => {+ const items: ContextMenuItem[] = host.value.buildContextMenu(node);+ const rename = items.find((item) => item.label === i18n.global.t("contextMenu.renameObject"));+ expect(rename).toBeDefined();+ rename!.action!();+ };+ try {+ app.mount(container);+ await nextTick();+ openRename(table);+ expect(controller.isOracleTableRename).toBe(true);+ expect(controller.isOracleRoutineRename).toBe(false);+ openRename(procedure);+ expect(controller.isOracleTableRename).toBe(false);+ expect(controller.isOracleRoutineRename).toBe(true);+ expect(controller.routineRenameDrafts).toBeDefined();+ expect(typeof controller.editSidebarRoutineRenameDraft).toBe("function");+ expect(typeof controller.validateSidebarRoutineRenameDrafts).toBe("function");+ expect(controller.packageSaveAsDrafts).toBeDefined();+ expect(controller.packageSaveAsValidating).toBeDefined();+ expect(typeof controller.editPackageSaveAsDraft).toBe("function");+ expect(typeof controller.validatePackageSaveAsDrafts).toBe("function");+ controller.editPackageSaveAsDraft("spec", "PACKAGE P AS END;");+ expect(controller.packageSaveAsDrafts.spec).toBe("PACKAGE P AS END;");+ controller.editSidebarRoutineRenameDraft("PROCEDURE:PROC_OLD", "CREATE OR REPLACE PROCEDURE OWNER.PROC_OLD AS BEGIN NULL; END;");+ expect(controller.routineRenameDrafts["PROCEDURE:PROC_OLD"]).toContain("PROC_OLD");+ } finally {+ app.unmount();+ container.remove();+ showRenameObjectDialog.value = false;+ }+ });++ it("prepares a native Oracle routine through the sidebar dialog host", async () => {+ const pinia = createPinia();+ setActivePinia(pinia);+ const store = useConnectionStore();+ store.connections = [{ id: "native-routine", name: "Owner", db_type: "oracle", host: "localhost", port: 1521, username: "OWNER" } as any];+ const host = ref<any>();+ let controller: any;+ const procedure: TreeNode = { id: "native-procedure", type: "procedure", label: "PROC_OLD", objectName: "PROC_OLD", connectionId: "native-routine", database: "OWNER", schema: "OWNER" };+ const alternateProcedure: TreeNode = { ...procedure, id: "native-procedure-other", schema: "OTHER" };+ const currentNode = ref<TreeNode>(procedure);+ const root = defineComponent({+ setup: () => () =>+ h(SidebarTreeRuntimeHost, {+ ref: host,+ node: currentNode.value,+ depth: 0,+ onOpenDialogController: (value: unknown) => {+ controller = value;+ },+ }),+ });+ const container = document.createElement("div");+ document.body.appendChild(container);+ const app = createApp(root).use(pinia).use(i18n);+ try {+ app.mount(container);+ await nextTick();+ const items: ContextMenuItem[] = host.value.buildContextMenu(procedure);+ items.find((item) => item.label === i18n.global.t("contextMenu.renameObject"))!.action!();+ expect(controller.isOracleRoutineRename).toBe(true);+ renameObjectName.value = "PROC_NEW";+ await nextTick();+ await controller.refreshRenameObjectPreviewSql();+ expect(prepareOracleRoutineRename).toHaveBeenCalled();+ expect(prepareOracleRoutineRename).toHaveBeenCalledWith(expect.objectContaining({ databaseType: "oracle" }), expect.anything());+ expect(controller.routineRenamePlan?.executable).toBe(true);+ controller.editSidebarRoutineRenameDraft("PROCEDURE:PROC_OLD", "CREATE OR REPLACE PROCEDURE OWNER.PROC_OLD AS BEGIN NULL; END;");+ controller.showRenameObjectDialog = false;+ await nextTick();+ const reopenSame = host.value.buildContextMenu(procedure).find((item: ContextMenuItem) => item.label === i18n.global.t("contextMenu.renameObject"));+ reopenSame!.action!();+ await nextTick();+ expect(controller.routineRenameDrafts["PROCEDURE:PROC_OLD"]).toContain("PROC_OLD");+ currentNode.value = alternateProcedure;+ await nextTick();+ const openOther = host.value.buildContextMenu(alternateProcedure).find((item: ContextMenuItem) => item.label === i18n.global.t("contextMenu.renameObject"));+ openOther!.action!();+ await nextTick();+ expect(controller.routineRenameDrafts).toEqual({});+ } finally {+ app.unmount();+ container.remove();+ showRenameObjectDialog.value = false;+ }+ });++ it("stops after the first cancelled statement and keeps the old identity", async () => {+ const pinia = createPinia();+ setActivePinia(pinia);+ const store = useConnectionStore();+ store.connections = [{ id: "rename-c", name: "Owner", db_type: "oracle", host: "localhost", port: 1521, username: "OWNER" } as any];+ vi.spyOn(store, "ensureConnected").mockResolvedValue(undefined);+ const replacePin = vi.spyOn(store, "replacePinnedTreeNode");+ const host = ref<any>();+ let controller: any;+ const node: TreeNode = { id: "rename-procedure", type: "procedure", label: "OLD", objectName: "OLD", connectionId: "rename-c", database: "OWNER", schema: "OWNER" };+ const root = defineComponent({+ setup: () => () =>+ h(SidebarTreeRuntimeHost, {+ ref: host,+ node,+ depth: 0,+ onOpenDialogController: (value: unknown) => {+ controller = value;+ },+ }),+ });+ const container = document.createElement("div");+ document.body.appendChild(container);+ const app = createApp(root).use(pinia).use(i18n);+ try {+ app.mount(container);+ await nextTick();+ const items: ContextMenuItem[] = host.value.buildContextMenu(node);+ const rename = items.find((item) => item.label === i18n.global.t("contextMenu.renameObject"));+ expect(rename).toBeDefined();+ rename!.action!();+ renameObjectName.value = "NEW";+ await nextTick();+ await controller.refreshRenameObjectPreviewSql();+ await controller.confirmRenameObject();+ expect(guard).toHaveBeenCalledTimes(1);+ expect(replacePin).not.toHaveBeenCalled();+ expect(showRenameObjectDialog.value).toBe(true);+ } finally {+ app.unmount();+ container.remove();+ showRenameObjectDialog.value = false;+ }+ });++ it("holds the table source identity during confirmation and releases it when the user cancels", async () => {+ const pinia = createPinia();+ setActivePinia(pinia);+ const store = useConnectionStore();+ store.connections = [{ id: "rename-table-c", name: "Owner", db_type: "oracle", host: "localhost", port: 1521, username: "OWNER" } as any];+ vi.spyOn(store, "ensureConnected").mockResolvedValue(undefined);+ const host = ref<any>();+ let controller: any;+ const node: TreeNode = { id: "rename-table", type: "table", label: "OLD", tableName: "OLD", connectionId: "rename-table-c", database: "OWNER", schema: "OWNER" };+ const root = defineComponent({+ setup: () => () =>+ h(SidebarTreeRuntimeHost, {+ ref: host,+ node,+ depth: 0,+ onOpenDialogController: (value: unknown) => {+ controller = value;+ },+ }),+ });+ const container = document.createElement("div");+ document.body.appendChild(container);+ const app = createApp(root).use(pinia).use(i18n);+ const identity = captureSourceIdentity({ connectionId: "rename-table-c", database: "OWNER", schema: "OWNER", objectType: "TABLE", name: "OLD" });+ try {+ app.mount(container);+ await nextTick();+ const items: ContextMenuItem[] = host.value.buildContextMenu(node);+ const rename = items.find((item) => item.label === i18n.global.t("contextMenu.renameObject"));+ expect(rename).toBeDefined();+ rename!.action!();+ renameObjectName.value = "NEW";+ await nextTick();+ guard.mockImplementationOnce(async () => {+ expect(() => assertSourceIdentity(identity)).toThrow();+ return undefined;+ });+ await controller.confirmRenameObject();+ expect(() => assertSourceIdentity(identity)).not.toThrow();+ expect(showRenameObjectDialog.value).toBe(true);+ } finally {+ app.unmount();+ container.remove();+ showRenameObjectDialog.value = false;+ }+ });+});diff --git a/apps/desktop/src/i18n/__tests__/localePlaceholderParity.spec.ts b/apps/desktop/src/i18n/__tests__/localePlaceholderParity.spec.tsindex 81584fda3b..3a50f21568 100644--- a/apps/desktop/src/i18n/__tests__/localePlaceholderParity.spec.ts+++ b/apps/desktop/src/i18n/__tests__/localePlaceholderParity.spec.ts@@ -80,6 +80,21 @@ function interpolationPlaceholders(message: string): Set<string> {const englishMessages = flattenMessages(en as Record<string, unknown>);describe("locale interpolation placeholder parity", () => {+ it.each(locales)("%s localizes the routine rename preview", (_name, messages) => {+ const key = "objects.routineRenamePreview";+ const localized = flattenMessages(messages).get(key);+ expect(localized).toBeDefined();+ expect(localized).not.toBe(englishMessages.get(key));+ });++ it.each(locales)("%s localizes the table rename repair flow", (_name, messages) => {+ const localizedMessages = flattenMessages(messages);+ for (const key of ["objects.tableRenameCoverage", "objects.tableRenameObjects", "objects.tableRenameDraft", "objects.tableRenameSuccess"]) {+ expect(localizedMessages.get(key), key).toBeDefined();+ expect(localizedMessages.get(key), key).not.toBe(englishMessages.get(key));+ }+ });+it.each(locales)("%s declares no placeholder English does not", (_name, messages) => {const offenders: string[] = [];for (const [key, value] of flattenMessages(messages)) {diff --git a/apps/desktop/src/i18n/locales/az.ts b/apps/desktop/src/i18n/locales/az.tsindex 0a5f30f7c4..39885a0e84 100644--- a/apps/desktop/src/i18n/locales/az.ts+++ b/apps/desktop/src/i18n/locales/az.ts@@ -4502,6 +4502,39 @@ export default withEnglishFallback({anyPrivilegeDisabled: "ANY növlü səlahiyyətlər DM8 tərəfindən deaktiv edilib (ENABLE_DDL_ANY_PRIV=0) və verilə və ya geri alına bilməz",},objects: {+ packageSaveAsTitle: "Paketi başqa adla saxla",+ packageSaveAsHint: "{name} obyektini yeni paket kimi köçürün. İlkin paket, onun çağıranları, saxlanmış elementlər və açıq qaralamalar dəyişməz qalacaq.",+ packageSaveAsMetadataProblem: "Paket metadatası natamamdır və ya təhlükəsiz köçürülə bilmir. Diaqnostikanı yoxlayıb planı yeniləyin.",+ packageSaveAsSuccess: "{oldName} paketi {newName} adı ilə köçürüldü.",+ packageSaveAsFailed: "Paketin köçürülməsi dayandırıldı. Təsdiqlənmiş və nəticəsi qeyri-müəyyən addımları yoxlayın; ilkin paket saxlanılıb.",+ viewRenameDraft: "İcra ediləcək tərif (köhnə obyekt adından istifadə edin)",+ routineRenamePreview: "Prosedur və ya funksiya mənbə kodundan yenidən yaradılacaq, sonra ilkin obyekt silinəcək.",+ tableRenameCoverage: "Cari hesabın görə bildiyi eyni sxemdəki statik view, prosedur və trigger asılılıqları yenilənir. Təhlükəsiz müəyyən edilə bilməyən istinadı qaralamada redaktə edib yenidən yoxlayın; həll olunmamış problemlər DDL icrasını dayandırır.",+ tableRenameObjects: "Bu plandakı obyektlər",+ tableRenameDraft: "{schema}.{name} tərifi (redaktə edib yenidən yoxlayın)",+ tableRenameSuccess: "{oldName} adı {newName} olaraq dəyişdirildi və {count} görünən asılılıq yeniləndi.",+ routineRenameObjects: "Objects in this plan",+ routineRenameRewrite: "source update",+ routineRenameCompile: "recompile",+ routineRenameCoverage: "Yalnız cari hesabın görə bildiyi eyni sxemə aid statik çağırışlar yenilənir. Dinamik SQL və tətbiq istinadları köçürülmür. İlkin obyekt yalnız yeni prosedur və ya funksiya və onun çağırışları yoxlandıqdan sonra silinir.",+ viewRenameValidate: "Yenidən yoxla",+ viewRenameReload: "Planı yenidən yüklə",+ viewRenameValidationPending: "Qaralama yoxlamadan keçməyib. Düzəldin, yenidən yoxlayın və ad dəyişikliyini təsdiqləyin.",+ viewRenameDefinitionReady: "Yoxlanılıb",+ viewRenameNeedsRepair: "Dəyişiklik lazımdır",+ viewRenameIssueLocation: "Sətir {line}, sütun {column}",+ viewRenameDiagnostics: "Diaqnostika təfərrüatları",+ viewRenameFinalSql: "İcra ediləcək SQL",+ viewRenameMetadataProblem: "Metaməlumat və ya asılılıqlar icraya imkan vermir. Göstərişlərə əməl edib planı yenidən yükləyin.",+ viewRenameIssueHint: "Bu hint-i təhlükəsiz şəkildə avtomatik yenidən yazmaq mümkün deyil. İcra ediləcək tərifi düzəldin.",+ viewRenameIssueBinding: "İstinad qeyri-müəyyəndir və ya başqa adı tutur. Bağlantını düzəldin.",+ viewRenameIssueDeclaration: "Cari sahib və köhnə obyekt adı üçün yalnız bir CREATE VIEW olmalıdır.",+ viewRenameIssueGraph: "Dəyişiklik planlaşdırılmış asılılıqları dəyişir və ya dövr yaradır. Mövcud istinadları saxlayın.",+ viewRenameIssueName: "Yeni ad yanlışdır və ya artıq istifadə olunur. Adı dəyişib planı yenidən yükləyin.",+ viewRenameIssueState: "Obyekt yanlışdır və ya icra kimliyi uyğun gəlmir. Obyekti və ya bağlantını düzəldib yenidən yükləyin.",+ viewRenameIssueSource: "Tərif və ya icazələr tam oxunmadı. Girişi yoxlayıb yenidən yükləyin.",+ viewRenameIssueDependency: "Avtomatik olaraq yalnız eyni sahibin adi view-ları yenilənir. Siyahıdakı asılılıqları həll edib yenidən yükləyin.",+ viewRenameIssueDrift: "Verilənlər bazası obyektləri və ya asılılıqları dəyişib. Qaralama saxlanılıb; planı yenidən yükləyib yoxlayın.",all: "Hamısı",tables: "Cədvəllər",collections: "Kolleksiyalar",diff --git a/apps/desktop/src/i18n/locales/en.ts b/apps/desktop/src/i18n/locales/en.tsindex 43fa894fb1..927d8b4aa1 100644--- a/apps/desktop/src/i18n/locales/en.ts+++ b/apps/desktop/src/i18n/locales/en.ts@@ -5561,6 +5561,46 @@ export default {anyPrivilegeDisabled: "ANY-type privileges are disabled by DM8 (ENABLE_DDL_ANY_PRIV=0) and cannot be granted or revoked",},objects: {+ packageSaveAsTitle: "Save Package As",+ packageSaveAsHint: "Copy {name} to a new package. The original package, its callers, saved items, and open drafts remain unchanged.",+ packageSaveAsMetadataProblem: "Package metadata is incomplete or cannot be copied safely. Review diagnostics and refresh the plan.",+ packageSaveAsSuccess: "Package {oldName} was copied as {newName}.",+ packageSaveAsFailed: "Package copy stopped. Review the confirmed and uncertain steps below; the original package was retained.",+ viewRenameSuccess: "Renamed {oldName} to {newName} and updated {count} visible view dependencies.",+ viewRenameCoverage: "Updates visible static view dependencies owned by the same user. Invisible cross-owner dependencies, dynamic SQL and application references are not migrated and may fail after renaming.",+ viewRenameDraft: "Definition to execute (use the old object name)",+ routineRenamePreview: "Recreate this procedure or function from source, then drop the original object.",+ tableRenameCoverage: "Updates visible same-owner static view, routine, and trigger dependencies. If a reference cannot be identified safely, edit the draft and validate again; unresolved issues prevent DDL.",+ tableRenameObjects: "Objects in this plan",+ tableRenameDraft: "Definition for {schema}.{name} (edit, then validate again)",+ tableRenameSuccess: "Renamed {oldName} to {newName} and updated {count} visible dependencies.",+ routineRenameObjects: "Objects in this plan",+ routineRenameRewrite: "source update",+ routineRenameCompile: "recompile",+ routineRenameCoverage: "Only same-owner static callers visible to the current account are updated. Invisible cross-owner references, dynamic SQL, and application references may fail after rename. The original is dropped only after the new routine and callers pass validation.",+ viewRenameValidate: "Validate again",+ viewRenameReload: "Reload plan",+ viewRenameValidationPending: "The draft has not passed validation. Fix it, validate again, then confirm the rename.",+ viewRenameDefinitionReady: "Validated",+ viewRenameNeedsRepair: "Needs changes",+ viewRenameIssueLocation: "Line {line}, column {column}",+ viewRenameDiagnostics: "Diagnostic details",+ viewRenameFinalSql: "SQL to execute",+ viewRenameMetadataProblem: "Metadata or dependencies prevent execution. Follow the guidance, then reload the plan.",+ viewRenameIssueHint: "References that could be identified have been rewritten automatically. This hint could not be rewritten safely; edit this definition at the location above, then validate again.",+ viewRenameIssueBinding: "The reference is ambiguous or captures another name. Correct its binding.",+ viewRenameIssueDeclaration: "Use one CREATE VIEW for this owner and the old object name.",+ viewRenameIssueGraph: "The change alters planned dependencies or creates a cycle. Preserve the existing references.",+ viewRenameIssueName: "The new name is invalid or already in use. Change it and reload the plan.",+ viewRenameIssueState: "The object is invalid or the execution identity does not match. Fix the object or connection, then reload.",+ viewRenameIssueSource: "The definition or grants could not be read completely. Check access, then reload.",+ viewRenameIssueDependency: "Only same-owner ordinary views are updated automatically. Resolve the listed dependencies, then reload.",+ viewRenameIssueDrift: "Database objects or dependencies changed. Your draft is kept; reload and review the plan.",+ viewRenameRefresh: "The name or target changed. Wait for the preview to refresh before confirming.",+ sourceIdentityChanged: "Object source changed or is being renamed. Keep your draft and reload the object before saving.",+ sourceIdentitySaving: "This object source is already being saved.",+ sourceIdentityBusy: "An affected object source is being saved or renamed. Wait for it to finish.",+ viewRenameRecovery: "Original definitions for recovery review. Check the current database state before executing to avoid overwriting concurrent changes.",all: "All",tables: "Tables",collections: "Collections",diff --git a/apps/desktop/src/i18n/locales/es.ts b/apps/desktop/src/i18n/locales/es.tsindex 62da5604c1..9add7c0620 100644--- a/apps/desktop/src/i18n/locales/es.ts+++ b/apps/desktop/src/i18n/locales/es.ts@@ -4868,6 +4868,46 @@ export default withEnglishFallback({anyPrivilegeDisabled: "Los privilegios de tipo ANY están deshabilitados por DM8 (ENABLE_DDL_ANY_PRIV=0) y no se pueden otorgar ni revocar",},objects: {+ packageSaveAsTitle: "Guardar paquete como",+ packageSaveAsHint: "Copia {name} como un paquete nuevo. El paquete original, sus dependencias, elementos guardados y borradores abiertos se conservan.",+ packageSaveAsMetadataProblem: "Los metadatos del paquete están incompletos o no se pueden copiar de forma segura. Revisa el diagnóstico y actualiza el plan.",+ packageSaveAsSuccess: "El paquete {oldName} se copió como {newName}.",+ packageSaveAsFailed: "Se detuvo la copia del paquete. Revisa los pasos confirmados y los de resultado incierto; se conservó el paquete original.",+ viewRenameSuccess: "Se cambió el nombre de {oldName} a {newName} y se actualizaron {count} dependencias de vistas visibles.",+ viewRenameCoverage: "Actualiza las dependencias estáticas de vistas visibles del mismo propietario. Las dependencias no visibles de otros propietarios, el SQL dinámico y las referencias de aplicaciones no se migran y pueden fallar tras el cambio de nombre.",+ viewRenameDraft: "Definición que se ejecutará (usa el nombre anterior del objeto)",+ routineRenamePreview: "Se volverá a crear este procedimiento o función desde el código fuente y después se eliminará el objeto original.",+ tableRenameCoverage: "Actualiza las dependencias estáticas visibles del mismo propietario: vistas, rutinas y desencadenadores. Si no se puede identificar una referencia con seguridad, edita el borrador y vuelve a validarlo; los problemas sin resolver bloquean el DDL.",+ tableRenameObjects: "Objetos de este plan",+ tableRenameDraft: "Definición de {schema}.{name} (edita y vuelve a validar)",+ tableRenameSuccess: "Se cambió el nombre de {oldName} a {newName} y se actualizaron {count} dependencias visibles.",+ routineRenameObjects: "Objects in this plan",+ routineRenameRewrite: "source update",+ routineRenameCompile: "recompile",+ routineRenameCoverage: "Solo se actualizan las llamadas estáticas del mismo propietario visibles para la cuenta actual. No se migran el SQL dinámico ni las referencias de aplicaciones. El objeto original se elimina únicamente después de validar la nueva rutina y sus llamadas.",+ viewRenameValidate: "Validar de nuevo",+ viewRenameReload: "Volver a cargar el plan",+ viewRenameValidationPending: "El borrador aún no ha superado la validación. Corrígelo, vuelve a validarlo y confirma el cambio de nombre.",+ viewRenameDefinitionReady: "Validado",+ viewRenameNeedsRepair: "Necesita cambios",+ viewRenameIssueLocation: "Línea {line}, columna {column}",+ viewRenameDiagnostics: "Detalles del diagnóstico",+ viewRenameFinalSql: "SQL que se ejecutará",+ viewRenameMetadataProblem: "Los metadatos o las dependencias impiden la ejecución. Sigue las indicaciones y vuelve a cargar el plan.",+ viewRenameIssueHint: "Esta sugerencia no se puede reescribir automáticamente de forma segura. Edita la definición que se ejecutará.",+ viewRenameIssueBinding: "La referencia es ambigua o captura otro nombre. Corrige su vinculación.",+ viewRenameIssueDeclaration: "Incluye un único CREATE VIEW para este propietario y el nombre anterior del objeto.",+ viewRenameIssueGraph: "El cambio altera las dependencias previstas o crea un ciclo. Conserva las referencias existentes.",+ viewRenameIssueName: "El nombre nuevo no es válido o ya está en uso. Cámbialo y vuelve a cargar el plan.",+ viewRenameIssueState: "El objeto no es válido o la identidad de ejecución no coincide. Corrige el objeto o la conexión y vuelve a cargar.",+ viewRenameIssueSource: "No se pudo leer por completo la definición o los permisos. Comprueba el acceso y vuelve a cargar.",+ viewRenameIssueDependency: "Solo se actualizan automáticamente las vistas normales del mismo propietario. Resuelve las dependencias indicadas y vuelve a cargar.",+ viewRenameIssueDrift: "Los objetos o dependencias de la base de datos han cambiado. Se conserva el borrador; vuelve a cargar y revisa el plan.",+ viewRenameRefresh: "El nombre o el destino ha cambiado. Espere a que se actualice la vista previa antes de confirmar.",+ sourceIdentityChanged: "El código del objeto cambió o se está renombrando. Conserve el borrador y vuelva a cargar el objeto antes de guardar.",+ sourceIdentitySaving: "El código de este objeto ya se está guardando.",+ sourceIdentityBusy: "El código de un objeto afectado se está guardando o renombrando. Espere a que termine.",+ viewRenameRecovery: "Definiciones originales para revisar la recuperación. Compruebe el estado actual de la base de datos antes de ejecutar para evitar sobrescribir cambios simultáneos.",validStatus: "VALID",invalidStatus: "INVALID",all: "Todos",diff --git a/apps/desktop/src/i18n/locales/id.ts b/apps/desktop/src/i18n/locales/id.tsindex 36fcc4220a..4a83f5bddd 100644--- a/apps/desktop/src/i18n/locales/id.ts+++ b/apps/desktop/src/i18n/locales/id.ts@@ -5110,6 +5110,34 @@ export default withEnglishFallback({anyPrivilegeDisabled: "Hak akses tipe ANY dinonaktifkan oleh DM8 (ENABLE_DDL_ANY_PRIV=0) dan tidak dapat diberikan atau dicabut",},objects: {+ viewRenameDraft: "Definisi yang dijalankan (gunakan nama objek lama)",+ routineRenamePreview: "Prosedur atau fungsi ini akan dibuat ulang dari kode sumber, lalu objek aslinya dihapus.",+ tableRenameCoverage: "Memperbarui dependensi statis yang terlihat dan dimiliki skema yang sama: view, rutin, dan trigger. Jika referensi tidak dapat dikenali dengan aman, edit draf lalu validasi ulang; masalah yang belum selesai akan memblokir DDL.",+ tableRenameObjects: "Objek dalam rencana ini",+ tableRenameDraft: "Definisi {schema}.{name} (edit lalu validasi ulang)",+ tableRenameSuccess: "{oldName} diubah namanya menjadi {newName}; {count} dependensi yang terlihat diperbarui.",+ routineRenameObjects: "Objects in this plan",+ routineRenameRewrite: "source update",+ routineRenameCompile: "recompile",+ routineRenameCoverage: "Hanya pemanggil statis dengan pemilik yang sama dan terlihat oleh akun saat ini yang diperbarui. SQL dinamis dan referensi aplikasi tidak dimigrasikan. Objek asli baru dihapus setelah rutin baru dan pemanggilnya lolos validasi.",+ viewRenameValidate: "Validasi ulang",+ viewRenameReload: "Muat ulang rencana",+ viewRenameValidationPending: "Draf belum lolos validasi. Perbaiki, validasi ulang, lalu konfirmasi penggantian nama.",+ viewRenameDefinitionReady: "Tervalidasi",+ viewRenameNeedsRepair: "Perlu diperbaiki",+ viewRenameIssueLocation: "Baris {line}, kolom {column}",+ viewRenameDiagnostics: "Detail diagnostik",+ viewRenameFinalSql: "SQL yang dijalankan",+ viewRenameMetadataProblem: "Metadata atau dependensi belum memenuhi syarat eksekusi. Ikuti petunjuk lalu muat ulang rencana.",+ viewRenameIssueHint: "Hint ini tidak dapat ditulis ulang dengan aman secara otomatis. Edit definisi yang akan dijalankan.",+ viewRenameIssueBinding: "Referensi ambigu atau menangkap nama lain. Perbaiki pengikatannya.",+ viewRenameIssueDeclaration: "Gunakan satu CREATE VIEW untuk pemilik saat ini dan nama objek lama.",+ viewRenameIssueGraph: "Perubahan mengubah dependensi terencana atau membuat siklus. Pertahankan referensi yang ada.",+ viewRenameIssueName: "Nama baru tidak valid atau sudah digunakan. Ubah nama lalu muat ulang rencana.",+ viewRenameIssueState: "Objek tidak valid atau identitas eksekusi tidak cocok. Perbaiki objek atau koneksi lalu muat ulang.",+ viewRenameIssueSource: "Definisi atau hak akses tidak terbaca sepenuhnya. Periksa akses lalu muat ulang.",+ viewRenameIssueDependency: "Hanya view biasa milik pemilik yang sama yang diperbarui otomatis. Selesaikan dependensi yang tertera lalu muat ulang.",+ viewRenameIssueDrift: "Objek atau dependensi basis data berubah. Draf disimpan; muat ulang dan tinjau rencana.",all: "Semua",tables: "Tabel",collections: "Koleksi",diff --git a/apps/desktop/src/i18n/locales/it.ts b/apps/desktop/src/i18n/locales/it.tsindex e577463406..b88908779e 100644--- a/apps/desktop/src/i18n/locales/it.ts+++ b/apps/desktop/src/i18n/locales/it.ts@@ -4688,6 +4688,46 @@ export default withEnglishFallback({anyPrivilegeDisabled: "I privilegi di tipo ANY sono disabilitati da DM8 (ENABLE_DDL_ANY_PRIV=0) e non possono essere concessi o revocati",},objects: {+ packageSaveAsTitle: "Salva pacchetto con nome",+ packageSaveAsHint: "Copia {name} come nuovo pacchetto. Il pacchetto originale, le dipendenze, gli elementi salvati e le bozze aperte restano invariati.",+ packageSaveAsMetadataProblem: "I metadati del pacchetto sono incompleti o non possono essere copiati in sicurezza. Controlla la diagnostica e aggiorna il piano.",+ packageSaveAsSuccess: "Il pacchetto {oldName} è stato copiato come {newName}.",+ packageSaveAsFailed: "La copia del pacchetto è stata interrotta. Controlla i passaggi confermati e quelli incerti; il pacchetto originale è stato mantenuto.",+ viewRenameSuccess: "{oldName} rinominato in {newName}; aggiornate {count} dipendenze di viste visibili.",+ viewRenameCoverage: "Aggiorna le dipendenze statiche delle viste visibili dello stesso proprietario. Le dipendenze non visibili di altri proprietari, SQL dinamico e riferimenti delle applicazioni non vengono migrati e potrebbero non funzionare dopo la rinomina.",+ viewRenameDraft: "Definizione da eseguire (usa il nome precedente dell'oggetto)",+ routineRenamePreview: "La procedura o la funzione verrà ricreata dal sorgente, quindi verrà eliminato l'oggetto originale.",+ tableRenameCoverage: "Aggiorna le dipendenze statiche visibili dello stesso proprietario: viste, routine e trigger. Se un riferimento non può essere identificato in sicurezza, modifica la bozza e convalidala di nuovo; i problemi irrisolti bloccano il DDL.",+ tableRenameObjects: "Oggetti inclusi nel piano",+ tableRenameDraft: "Definizione di {schema}.{name} (modifica e convalida di nuovo)",+ tableRenameSuccess: "{oldName} è stato rinominato in {newName}; aggiornate {count} dipendenze visibili.",+ routineRenameObjects: "Objects in this plan",+ routineRenameRewrite: "source update",+ routineRenameCompile: "recompile",+ routineRenameCoverage: "Vengono aggiornati solo i chiamanti statici dello stesso proprietario visibili all'account corrente. SQL dinamico e riferimenti delle applicazioni non vengono migrati. L'oggetto originale viene eliminato solo dopo la convalida della nuova routine e dei chiamanti.",+ viewRenameValidate: "Convalida di nuovo",+ viewRenameReload: "Ricarica il piano",+ viewRenameValidationPending: "La bozza non ha ancora superato la convalida. Correggila, convalidala di nuovo e conferma la rinomina.",+ viewRenameDefinitionReady: "Convalidata",+ viewRenameNeedsRepair: "Richiede modifiche",+ viewRenameIssueLocation: "Riga {line}, colonna {column}",+ viewRenameDiagnostics: "Dettagli diagnostici",+ viewRenameFinalSql: "SQL da eseguire",+ viewRenameMetadataProblem: "I metadati o le dipendenze non consentono l'esecuzione. Segui le indicazioni e ricarica il piano.",+ viewRenameIssueHint: "Questo hint non può essere riscritto automaticamente in modo sicuro. Modifica la definizione da eseguire.",+ viewRenameIssueBinding: "Il riferimento è ambiguo o acquisisce un altro nome. Correggi l'associazione.",+ viewRenameIssueDeclaration: "Includi un solo CREATE VIEW per questo proprietario e il nome precedente dell'oggetto.",+ viewRenameIssueGraph: "La modifica cambia le dipendenze previste o crea un ciclo. Mantieni i riferimenti esistenti.",+ viewRenameIssueName: "Il nuovo nome non è valido o è già in uso. Modificalo e ricarica il piano.",+ viewRenameIssueState: "L'oggetto non è valido o l'identità di esecuzione non corrisponde. Correggi l'oggetto o la connessione e ricarica.",+ viewRenameIssueSource: "Impossibile leggere completamente la definizione o le autorizzazioni. Verifica l'accesso e ricarica.",+ viewRenameIssueDependency: "Si aggiornano automaticamente solo le viste normali dello stesso proprietario. Risolvi le dipendenze indicate e ricarica.",+ viewRenameIssueDrift: "Gli oggetti o le dipendenze del database sono cambiati. La bozza è conservata; ricarica e controlla il piano.",+ viewRenameRefresh: "Il nome o la destinazione è cambiato. Attendere l'aggiornamento dell'anteprima prima di confermare.",+ sourceIdentityChanged: "Il codice dell'oggetto è cambiato o l'oggetto viene rinominato. Conservare la bozza e ricaricare l'oggetto prima di salvare.",+ sourceIdentitySaving: "Il codice di questo oggetto è già in fase di salvataggio.",+ sourceIdentityBusy: "Il codice di un oggetto interessato viene salvato o rinominato. Attendere il completamento.",+ viewRenameRecovery: "Definizioni originali per valutare il ripristino. Controllare lo stato attuale del database prima di eseguire per evitare di sovrascrivere modifiche concorrenti.",validStatus: "VALID",invalidStatus: "INVALID",all: "Tutti",diff --git a/apps/desktop/src/i18n/locales/ja.ts b/apps/desktop/src/i18n/locales/ja.tsindex 26203aff95..fcd7d576b3 100644--- a/apps/desktop/src/i18n/locales/ja.ts+++ b/apps/desktop/src/i18n/locales/ja.ts@@ -4750,6 +4750,46 @@ export default withEnglishFallback({anyPrivilegeDisabled: "ANY系権限はDM8で無効化されています(ENABLE_DDL_ANY_PRIV=0)ため、付与・取り消しはできません",},objects: {+ packageSaveAsTitle: "パッケージを別名で保存",+ packageSaveAsHint: "{name} を新しいパッケージとしてコピーします。元のパッケージ、呼び出し元、保存済み項目、開いている下書きは保持されます。",+ packageSaveAsMetadataProblem: "パッケージのメタデータが不完全か、安全にコピーできません。診断を確認して計画を再読み込みしてください。",+ packageSaveAsSuccess: "パッケージ {oldName} を {newName} としてコピーしました。",+ packageSaveAsFailed: "パッケージのコピーを停止しました。確認済みと結果不明の手順を確認してください。元のパッケージは保持されています。",+ viewRenameSuccess: "{oldName} を {newName} に変更し、見えるビュー依存関係を {count} 件更新しました。",+ viewRenameCoverage: "現在のユーザーに見える同一所有者の静的ビュー依存関係を更新します。見えない別所有者の依存関係、動的 SQL、アプリケーションの参照は移行されず、名前変更後に動作しなくなる可能性があります。",+ viewRenameDraft: "実行する定義(変更前のオブジェクト名を使用)",+ routineRenamePreview: "このプロシージャまたは関数をソースから再作成し、その後、元のオブジェクトを削除します。",+ tableRenameCoverage: "現在のアカウントから見える同一所有者の静的なビュー、ルーチン、トリガー依存関係を更新します。安全に特定できない参照は草稿を編集して再検証できます。未解決の問題がある間は DDL を実行できません。",+ tableRenameObjects: "この計画のオブジェクト",+ tableRenameDraft: "{schema}.{name} の定義(編集後に再検証)",+ tableRenameSuccess: "{oldName} を {newName} に変更し、見える依存関係を {count} 件更新しました。",+ routineRenameObjects: "Objects in this plan",+ routineRenameRewrite: "source update",+ routineRenameCompile: "recompile",+ routineRenameCoverage: "現在のアカウントから確認できる同一所有者の静的な呼び出し元のみを更新します。動的 SQL とアプリケーションの参照は移行されません。新しいルーチンと呼び出し元の検証が完了した後にのみ、元のオブジェクトを削除します。",+ viewRenameValidate: "再検証",+ viewRenameReload: "計画を再読み込み",+ viewRenameValidationPending: "草稿はまだ検証に合格していません。修正して再検証してから、名前変更を確定してください。",+ viewRenameDefinitionReady: "検証済み",+ viewRenameNeedsRepair: "修正が必要",+ viewRenameIssueLocation: "{line} 行 {column} 列",+ viewRenameDiagnostics: "診断の詳細",+ viewRenameFinalSql: "実行する SQL",+ viewRenameMetadataProblem: "メタデータまたは依存関係が実行条件を満たしていません。案内に従ってから計画を再読み込みしてください。",+ viewRenameIssueHint: "このヒントは安全に自動書き換えできません。実行する定義を修正してください。",+ viewRenameIssueBinding: "参照が曖昧か、別の名前を捕捉しています。結び付きを修正してください。",+ viewRenameIssueDeclaration: "現在の所有者と変更前の名前に対応する CREATE VIEW を 1 つだけ指定してください。",+ viewRenameIssueGraph: "変更により依存関係が変わるか循環が発生します。既存の参照を維持してください。",+ viewRenameIssueName: "新しい名前が無効か使用中です。名前を変更して計画を再読み込みしてください。",+ viewRenameIssueState: "オブジェクトが無効か実行接続が一致しません。修正して再読み込みしてください。",+ viewRenameIssueSource: "定義または権限を完全に読み取れませんでした。権限を確認して再読み込みしてください。",+ viewRenameIssueDependency: "自動更新できるのは同じ所有者の通常ビューだけです。表示された依存関係を解決して再読み込みしてください。",+ viewRenameIssueDrift: "データベースのオブジェクトまたは依存関係が変わりました。草稿は保持されています。再読み込みして確認してください。",+ viewRenameRefresh: "名前または対象が変更されました。プレビューの更新後に確認してください。",+ sourceIdentityChanged: "オブジェクトのソースが変更されたか、名前変更中です。下書きを保持し、保存前にオブジェクトを再読み込みしてください。",+ sourceIdentitySaving: "このオブジェクトのソースは保存中です。",+ sourceIdentityBusy: "対象オブジェクトのソースは保存中または名前変更中です。完了するまでお待ちください。",+ viewRenameRecovery: "復旧を検討するための元の定義です。同時変更を上書きしないよう、実行前にデータベースの現在の状態を確認してください。",validStatus: "VALID",invalidStatus: "INVALID",all: "すべて",diff --git a/apps/desktop/src/i18n/locales/ko.ts b/apps/desktop/src/i18n/locales/ko.tsindex fb3f23cd4f..54ce011261 100644--- a/apps/desktop/src/i18n/locales/ko.ts+++ b/apps/desktop/src/i18n/locales/ko.ts@@ -4742,6 +4742,46 @@ export default withEnglishFallback({anyPrivilegeDisabled: "ANY 유형 권한은 DM8에서 비활성화되어(ENABLE_DDL_ANY_PRIV=0) 부여하거나 회수할 수 없습니다",},objects: {+ packageSaveAsTitle: "패키지 다른 이름으로 저장",+ packageSaveAsHint: "{name}을(를) 새 패키지로 복사합니다. 기존 패키지, 호출자, 저장 항목 및 열린 초안은 그대로 유지됩니다.",+ packageSaveAsMetadataProblem: "패키지 메타데이터가 불완전하거나 안전하게 복사할 수 없습니다. 진단을 확인하고 계획을 새로 고치세요.",+ packageSaveAsSuccess: "패키지 {oldName}을(를) {newName}(으)로 복사했습니다.",+ packageSaveAsFailed: "패키지 복사를 중지했습니다. 확인된 단계와 결과가 불확실한 단계를 확인하세요. 기존 패키지는 유지되었습니다.",+ viewRenameSuccess: "{oldName}의 이름을 {newName}(으)로 변경하고 보이는 뷰 종속성 {count}개를 업데이트했습니다.",+ viewRenameCoverage: "현재 계정에 보이는 동일 소유자의 정적 뷰 종속성을 업데이트합니다. 보이지 않는 다른 소유자의 종속성, 동적 SQL 및 애플리케이션 참조는 이전되지 않으며 이름 변경 후 실패할 수 있습니다.",+ viewRenameDraft: "실행할 정의(변경 전 객체 이름 사용)",+ routineRenamePreview: "이 프로시저 또는 함수를 소스에서 다시 만든 다음 원본 객체를 삭제합니다.",+ tableRenameCoverage: "현재 계정에서 확인할 수 있는 동일 소유자의 정적 뷰, 루틴, 트리거 종속성을 업데이트합니다. 안전하게 식별할 수 없는 참조는 초안을 수정하고 다시 검증할 수 있습니다. 해결되지 않은 문제가 있으면 DDL을 실행하지 않습니다.",+ tableRenameObjects: "계획에 포함된 객체",+ tableRenameDraft: "{schema}.{name} 정의(수정 후 다시 검증)",+ tableRenameSuccess: "{oldName}의 이름을 {newName}(으)로 변경하고 보이는 종속성 {count}개를 업데이트했습니다.",+ routineRenameObjects: "Objects in this plan",+ routineRenameRewrite: "source update",+ routineRenameCompile: "recompile",+ routineRenameCoverage: "현재 계정에서 확인할 수 있는 동일 소유자의 정적 호출자만 업데이트합니다. 동적 SQL과 애플리케이션 참조는 이전되지 않습니다. 새 루틴과 호출자의 검증이 끝난 뒤에만 원본 객체를 삭제합니다.",+ viewRenameValidate: "다시 검증",+ viewRenameReload: "계획 다시 읽기",+ viewRenameValidationPending: "초안이 아직 검증을 통과하지 못했습니다. 수정한 후 다시 검증하고 이름 변경을 확인하세요.",+ viewRenameDefinitionReady: "검증됨",+ viewRenameNeedsRepair: "수정 필요",+ viewRenameIssueLocation: "{line}행 {column}열",+ viewRenameDiagnostics: "진단 세부 정보",+ viewRenameFinalSql: "실행할 SQL",+ viewRenameMetadataProblem: "메타데이터 또는 종속성이 실행 조건을 충족하지 않습니다. 안내에 따라 처리한 뒤 계획을 다시 읽으세요.",+ viewRenameIssueHint: "이 힌트는 안전하게 자동 수정할 수 없습니다. 실행할 정의를 직접 수정하세요.",+ viewRenameIssueBinding: "참조가 모호하거나 다른 이름을 가립니다. 바인딩을 수정하세요.",+ viewRenameIssueDeclaration: "현재 소유자와 변경 전 객체 이름에 맞는 CREATE VIEW 하나만 포함해야 합니다.",+ viewRenameIssueGraph: "수정하면 계획된 종속성이 바뀌거나 순환이 생깁니다. 기존 참조를 유지하세요.",+ viewRenameIssueName: "새 이름이 잘못되었거나 이미 사용 중입니다. 이름을 바꾸고 계획을 다시 읽으세요.",+ viewRenameIssueState: "객체가 유효하지 않거나 실행 연결이 일치하지 않습니다. 수정한 뒤 다시 읽으세요.",+ viewRenameIssueSource: "정의 또는 권한을 완전히 읽지 못했습니다. 권한을 확인한 뒤 다시 읽으세요.",+ viewRenameIssueDependency: "같은 소유자의 일반 뷰만 자동으로 처리합니다. 표시된 종속성을 해결한 뒤 다시 읽으세요.",+ viewRenameIssueDrift: "데이터베이스 객체 또는 종속성이 변경되었습니다. 초안은 보존됩니다. 다시 읽고 확인하세요.",+ viewRenameRefresh: "이름 또는 대상이 변경되었습니다. 미리 보기가 새로 고쳐진 후 확인하세요.",+ sourceIdentityChanged: "객체 소스가 변경되었거나 이름 변경 중입니다. 초안을 유지하고 저장하기 전에 객체를 다시 불러오세요.",+ sourceIdentitySaving: "이 객체의 소스를 이미 저장 중입니다.",+ sourceIdentityBusy: "관련 객체의 소스를 저장하거나 이름을 변경 중입니다. 완료될 때까지 기다리세요.",+ viewRenameRecovery: "복구 검토용 원본 정의입니다. 동시 변경 사항을 덮어쓰지 않도록 실행 전에 현재 데이터베이스 상태를 확인하세요.",validStatus: "VALID",invalidStatus: "INVALID",all: "전체",diff --git a/apps/desktop/src/i18n/locales/pt-BR.ts b/apps/desktop/src/i18n/locales/pt-BR.tsindex 0bffe08d61..a9b643bd0c 100644--- a/apps/desktop/src/i18n/locales/pt-BR.ts+++ b/apps/desktop/src/i18n/locales/pt-BR.ts@@ -4688,6 +4688,46 @@ export default withEnglishFallback({anyPrivilegeDisabled: "Privilégios do tipo ANY estão desabilitados pelo DM8 (ENABLE_DDL_ANY_PRIV=0) e não podem ser concedidos ou revogados",},objects: {+ packageSaveAsTitle: "Salvar pacote como",+ packageSaveAsHint: "Copiar {name} como um novo pacote. O pacote original, seus chamadores, itens salvos e rascunhos abertos serão mantidos.",+ packageSaveAsMetadataProblem: "Os metadados do pacote estão incompletos ou não podem ser copiados com segurança. Revise o diagnóstico e atualize o plano.",+ packageSaveAsSuccess: "O pacote {oldName} foi copiado como {newName}.",+ packageSaveAsFailed: "A cópia do pacote foi interrompida. Revise as etapas confirmadas e incertas; o pacote original foi mantido.",+ viewRenameSuccess: "{oldName} foi renomeado para {newName} e {count} dependências de views visíveis foram atualizadas.",+ viewRenameCoverage: "Atualiza as dependências estáticas de views visíveis do mesmo proprietário. Dependências invisíveis de outros proprietários, SQL dinâmico e referências de aplicativos não são migrados e podem falhar após a renomeação.",+ viewRenameDraft: "Definição a executar (use o nome anterior do objeto)",+ routineRenamePreview: "O procedimento ou a função será recriado a partir do código-fonte e, em seguida, o objeto original será removido.",+ tableRenameCoverage: "Atualiza dependências estáticas visíveis do mesmo proprietário: views, rotinas e gatilhos. Se uma referência não puder ser identificada com segurança, edite o rascunho e valide novamente; problemas não resolvidos impedem o DDL.",+ tableRenameObjects: "Objetos deste plano",+ tableRenameDraft: "Definição de {schema}.{name} (edite e valide novamente)",+ tableRenameSuccess: "{oldName} foi renomeado para {newName} e {count} dependências visíveis foram atualizadas.",+ routineRenameObjects: "Objects in this plan",+ routineRenameRewrite: "source update",+ routineRenameCompile: "recompile",+ routineRenameCoverage: "Somente chamadas estáticas do mesmo proprietário visíveis para a conta atual serão atualizadas. SQL dinâmico e referências de aplicativos não serão migrados. O objeto original só será removido após a validação da nova rotina e de suas chamadas.",+ viewRenameValidate: "Validar novamente",+ viewRenameReload: "Recarregar plano",+ viewRenameValidationPending: "O rascunho ainda não passou pela validação. Corrija, valide novamente e confirme a renomeação.",+ viewRenameDefinitionReady: "Validado",+ viewRenameNeedsRepair: "Precisa de ajustes",+ viewRenameIssueLocation: "Linha {line}, coluna {column}",+ viewRenameDiagnostics: "Detalhes do diagnóstico",+ viewRenameFinalSql: "SQL a executar",+ viewRenameMetadataProblem: "Os metadados ou as dependências impedem a execução. Siga as instruções e recarregue o plano.",+ viewRenameIssueHint: "Esta dica não pode ser reescrita automaticamente com segurança. Edite a definição a executar.",+ viewRenameIssueBinding: "A referência é ambígua ou captura outro nome. Corrija o vínculo.",+ viewRenameIssueDeclaration: "Inclua um único CREATE VIEW para este proprietário e o nome anterior do objeto.",+ viewRenameIssueGraph: "A alteração modifica as dependências planejadas ou cria um ciclo. Preserve as referências existentes.",+ viewRenameIssueName: "O novo nome é inválido ou já está em uso. Altere-o e recarregue o plano.",+ viewRenameIssueState: "O objeto é inválido ou a identidade de execução não corresponde. Corrija o objeto ou a conexão e recarregue.",+ viewRenameIssueSource: "Não foi possível ler toda a definição ou as permissões. Verifique o acesso e recarregue.",+ viewRenameIssueDependency: "Somente views comuns do mesmo proprietário são atualizadas automaticamente. Resolva as dependências listadas e recarregue.",+ viewRenameIssueDrift: "Os objetos ou as dependências do banco de dados mudaram. O rascunho foi preservado; recarregue e confira o plano.",+ viewRenameRefresh: "O nome ou o destino mudou. Aguarde a atualização da prévia antes de confirmar.",+ sourceIdentityChanged: "O código do objeto mudou ou está sendo renomeado. Preserve o rascunho e recarregue o objeto antes de salvar.",+ sourceIdentitySaving: "O código deste objeto já está sendo salvo.",+ sourceIdentityBusy: "O código de um objeto afetado está sendo salvo ou renomeado. Aguarde a conclusão.",+ viewRenameRecovery: "Definições originais para avaliar a recuperação. Verifique o estado atual do banco de dados antes de executar para evitar sobrescrever alterações simultâneas.",validStatus: "VALID",invalidStatus: "INVALID",all: "Todos",diff --git a/apps/desktop/src/i18n/locales/ru.ts b/apps/desktop/src/i18n/locales/ru.tsindex 85bb08ce50..eb0896039d 100644--- a/apps/desktop/src/i18n/locales/ru.ts+++ b/apps/desktop/src/i18n/locales/ru.ts@@ -5209,6 +5209,46 @@ export default withEnglishFallback({anyPrivilegeDisabled: "Привилегии типа ANY отключены в DM8 (ENABLE_DDL_ANY_PRIV=0) и не могут быть выданы или отозваны",},objects: {+ packageSaveAsTitle: "Сохранить пакет как",+ packageSaveAsHint: "Скопировать {name} в новый пакет. Исходный пакет, его вызывающие объекты, сохранённые элементы и открытые черновики останутся без изменений.",+ packageSaveAsMetadataProblem: "Метаданные пакета неполны или его нельзя безопасно скопировать. Проверьте диагностику и обновите план.",+ packageSaveAsSuccess: "Пакет {oldName} скопирован как {newName}.",+ packageSaveAsFailed: "Копирование пакета остановлено. Проверьте подтверждённые шаги и шаги с неизвестным результатом; исходный пакет сохранён.",+ viewRenameSuccess: "{oldName} переименован в {newName}, обновлено видимых зависимостей представлений: {count}.",+ viewRenameCoverage: "Обновляет видимые статические зависимости представлений того же владельца. Невидимые зависимости других владельцев, динамический SQL и ссылки приложений не переносятся и могут перестать работать после переименования.",+ viewRenameDraft: "Определение для выполнения (используйте прежнее имя объекта)",+ routineRenamePreview: "Процедура или функция будет пересоздана из исходного кода, затем исходный объект будет удалён.",+ tableRenameCoverage: "Обновляются видимые статические зависимости того же владельца: представления, процедуры и триггеры. Если ссылку нельзя определить безопасно, измените черновик и проверьте его снова; неразрешённые проблемы блокируют DDL.",+ tableRenameObjects: "Объекты в этом плане",+ tableRenameDraft: "Определение {schema}.{name} (измените и проверьте снова)",+ tableRenameSuccess: "{oldName} переименован в {newName}, обновлено видимых зависимостей: {count}.",+ routineRenameObjects: "Objects in this plan",+ routineRenameRewrite: "source update",+ routineRenameCompile: "recompile",+ routineRenameCoverage: "Обновляются только статические вызовы того же владельца, видимые текущей учётной записи. Динамический SQL и ссылки приложений не переносятся. Исходный объект удаляется только после проверки новой процедуры или функции и её вызывающих объектов.",+ viewRenameValidate: "Проверить повторно",+ viewRenameReload: "Обновить план",+ viewRenameValidationPending: "Черновик не прошёл проверку. Исправьте его, проверьте повторно и подтвердите переименование.",+ viewRenameDefinitionReady: "Проверено",+ viewRenameNeedsRepair: "Требуются изменения",+ viewRenameIssueLocation: "Строка {line}, столбец {column}",+ viewRenameDiagnostics: "Подробности диагностики",+ viewRenameFinalSql: "SQL для выполнения",+ viewRenameMetadataProblem: "Метаданные или зависимости не позволяют выполнить операцию. Следуйте подсказкам и обновите план.",+ viewRenameIssueHint: "Эту подсказку нельзя безопасно переписать автоматически. Измените определение для выполнения.",+ viewRenameIssueBinding: "Ссылка неоднозначна или перекрывает другое имя. Исправьте привязку.",+ viewRenameIssueDeclaration: "Укажите один CREATE VIEW для текущего владельца и прежнего имени объекта.",+ viewRenameIssueGraph: "Изменение меняет план зависимостей или создаёт цикл. Сохраните существующие ссылки.",+ viewRenameIssueName: "Новое имя недопустимо или уже занято. Измените его и обновите план.",+ viewRenameIssueState: "Объект недействителен или контекст выполнения не совпадает. Исправьте объект или подключение и обновите план.",+ viewRenameIssueSource: "Не удалось полностью прочитать определение или права. Проверьте доступ и обновите план.",+ viewRenameIssueDependency: "Автоматически обновляются только обычные представления того же владельца. Устраните указанные зависимости и обновите план.",+ viewRenameIssueDrift: "Объекты или зависимости базы данных изменились. Черновик сохранён; обновите и проверьте план.",+ viewRenameRefresh: "Имя или целевой объект изменились. Дождитесь обновления предварительного просмотра перед подтверждением.",+ sourceIdentityChanged: "Исходный код объекта изменился или объект переименовывается. Сохраните черновик и перезагрузите объект перед сохранением.",+ sourceIdentitySaving: "Исходный код этого объекта уже сохраняется.",+ sourceIdentityBusy: "Исходный код затронутого объекта сохраняется или переименовывается. Дождитесь завершения.",+ viewRenameRecovery: "Исходные определения для проверки восстановления. Перед выполнением проверьте текущее состояние базы данных, чтобы не перезаписать параллельные изменения.",all: "Все",tables: "Таблицы",collections: "Коллекции",diff --git a/apps/desktop/src/i18n/locales/th.ts b/apps/desktop/src/i18n/locales/th.tsindex 3cd27ebf7b..636b1447ca 100644--- a/apps/desktop/src/i18n/locales/th.ts+++ b/apps/desktop/src/i18n/locales/th.ts@@ -5543,6 +5543,46 @@ export default withEnglishFallback({anyPrivilegeDisabled: "DM8 ปิดใช้ Privilege ประเภท ANY (ENABLE_DDL_ANY_PRIV=0) จึง Grant หรือ Revoke ไม่ได้",},objects: {+ packageSaveAsTitle: "บันทึก Package เป็น",+ packageSaveAsHint: "คัดลอก {name} เป็น Package ใหม่ โดย Package เดิม ผู้เรียกใช้ รายการที่บันทึก และฉบับร่างที่เปิดอยู่จะยังคงอยู่",+ packageSaveAsMetadataProblem: "Metadata ของ Package ไม่สมบูรณ์หรือไม่สามารถคัดลอกได้อย่างปลอดภัย โปรดตรวจสอบการวินิจฉัยและรีเฟรชแผน",+ packageSaveAsSuccess: "คัดลอก Package {oldName} เป็น {newName} เรียบร้อยแล้ว",+ packageSaveAsFailed: "การคัดลอก Package หยุดลง โปรดตรวจสอบขั้นตอนที่ยืนยันแล้วและผลลัพธ์ที่ไม่แน่นอนด้านล่าง Package เดิมได้รับการเก็บรักษาไว้",+ viewRenameSuccess: "เปลี่ยนชื่อ {oldName} เป็น {newName} และอัปเดตการพึ่งพา View ที่มองเห็นได้ {count} รายการแล้ว",+ viewRenameCoverage: "อัปเดตการพึ่งพา View แบบคงที่ของเจ้าของเดียวกันที่มองเห็นได้โดยบัญชีปัจจุบันโดยอัตโนมัติ การพึ่งพาต่างเจ้าของที่ไม่สามารถมองเห็นได้ Dynamic SQL และการอ้างอิงจากแอปพลิเคชันจะไม่ถูกย้าย และอาจใช้การไม่ได้หลังเปลี่ยนชื่อ",+ viewRenameDraft: "คำจำกัดความที่จะเรียกใช้ (ใช้ชื่อออบเจ็กต์ก่อนเปลี่ยนชื่อ)",+ routineRenamePreview: "จะสร้าง Procedure หรือ Function นี้ใหม่จากซอร์สโค้ด จากนั้นลบออบเจ็กต์เดิมออก",+ tableRenameCoverage: "อัปเดตการพึ่งพา View, Routine และ Trigger แบบคงที่ของเจ้าของเดียวกันที่มองเห็นได้โดยอัตโนมัติ การอ้างอิงที่ไม่สามารถระบุได้อย่างปลอดภัยสามารถแก้ไขในฉบับร่างและตรวจสอบซ้ำได้ ปัญหาที่ยังไม่ได้รับการแก้ไขจะบล็อกการดำเนินการ DDL",+ tableRenameObjects: "ออบเจ็กต์ในแผนนี้",+ tableRenameDraft: "คำจำกัดความสำหรับ {schema}.{name} (โปรดตรวจสอบซ้ำหลังแก้ไข)",+ tableRenameSuccess: "เปลี่ยนชื่อ {oldName} เป็น {newName} และอัปเดตการพึ่งพาที่มองเห็นได้ {count} รายการแล้ว",+ routineRenameObjects: "ออบเจ็กต์ในแผนนี้",+ routineRenameRewrite: "อัปเดตซอร์สโค้ด",+ routineRenameCompile: "คอมไพล์ใหม่",+ routineRenameCoverage: "อัปเดตเฉพาะผู้เรียกใช้แบบคงที่ของเจ้าของเดียวกันที่มองเห็นได้โดยบัญชีปัจจุบันเท่านั้น การอ้างอิงต่างเจ้าของที่ไม่สามารถมองเห็นได้ Dynamic SQL และการอ้างอิงจากแอปพลิเคชันอาจใช้การไม่ได้หลังเปลี่ยนชื่อ ออบเจ็กต์เดิมจะถูกลบออกหลังจากที่ Routine ใหม่และผู้เรียกใช้ผ่านการตรวจสอบแล้วเท่านั้น",+ viewRenameValidate: "ตรวจสอบซ้ำ",+ viewRenameReload: "โหลดแผนใหม่",+ viewRenameValidationPending: "โปรดแก้ไขคำจำกัดความหรือการพึ่งพาตามคำแนะนำเกี่ยวกับปัญหาก่อน แล้วคลิก “ตรวจสอบซ้ำ” หลังผ่านทั้งหมดแล้วจึงจะยืนยันการเปลี่ยนชื่อได้ จะไม่มีการดำเนินการ SQL หากการตรวจสอบไม่ผ่าน",+ viewRenameDefinitionReady: "ตรวจสอบแล้ว",+ viewRenameNeedsRepair: "ต้องมีการแก้ไขเพิ่มเติม",+ viewRenameIssueLocation: "บรรทัดที่ {line}, คอลัมน์ที่ {column}",+ viewRenameDiagnostics: "รายละเอียดการวินิจฉัย",+ viewRenameFinalSql: "SQL ที่จะเรียกใช้",+ viewRenameMetadataProblem: "Metadata หรือการพึ่งพาไม่ตรงตามเงื่อนไขการดำเนินการ โปรดจัดการตามคำแนะนำแล้วโหลดใหม่",+ viewRenameIssueHint: "ระบบได้เขียนการอ้างอิงที่สามารถระบุได้ใหม่โดยอัตโนมัติแล้ว Hint นี้ไม่สามารถเขียนใหม่ได้อย่างปลอดภัย โปรดแก้ไขคำจำกัดความนี้ตามตำแหน่งด้านบน แล้วคลิก “ตรวจสอบซ้ำ”",+ viewRenameIssueBinding: "การอ้างอิงมีความคลุมเครือหรือจับชื่ออื่น โปรดแก้ไข Binding",+ viewRenameIssueDeclaration: "คำจำกัดความต้องตรงกับเจ้าของปัจจุบันและชื่อออบเจ็กต์ก่อนเปลี่ยนชื่อ และต้องมีคำสั่ง CREATE VIEW เพียงคำสั่งเดียวเท่านั้น",+ viewRenameIssueGraph: "การแก้ไขจะเปลี่ยนโทโพโลยีการพึ่งพาภายในแผนหรือสร้างวงจร โปรดรักษาความสัมพันธ์การอ้างอิงเดิมไว้",+ viewRenameIssueName: "ชื่อใหม่ไม่ถูกต้องหรือถูกใช้งานแล้ว โปรดเปลี่ยนชื่อแล้วโหลดแผนใหม่",+ viewRenameIssueState: "ออบเจ็กต์ไม่ถูกต้องหรือข้อมูลระบุตัวตนในการดำเนินการไม่ตรงกัน โปรดแก้ไขออบเจ็กต์หรือการเชื่อมต่อก่อนแล้วโหลดใหม่",+ viewRenameIssueSource: "ไม่สามารถอ่านคำจำกัดความหรือสิทธิ์ได้อย่างสมบูรณ์ โปรดตรวจสอบการเข้าถึงแล้วโหลดใหม่",+ viewRenameIssueDependency: "ขณะนี้ประมวลผลเฉพาะ View ทั่วไปของเจ้าของเดียวกันโดยอัตโนมัติเท่านั้น โปรดจัดการการพึ่งพาอื่นที่ระบุก่อนแล้วโหลดใหม่",+ viewRenameIssueDrift: "ออบเจ็กต์หรือการพึ่งพาในฐานข้อมูลมีการเปลี่ยนแปลง ฉบับร่างของคุณจะยังคงอยู่ โปรดโหลดใหม่และตรวจสอบแผน",+ viewRenameRefresh: "ชื่อหรือเป้าหมายมีการเปลี่ยนแปลง โปรดรอให้การแสดงตัวอย่างรีเฟรชก่อนยืนยัน",+ sourceIdentityChanged: "ซอร์สโค้ดของออบเจ็กต์มีการเปลี่ยนแปลงหรือกำลังเปลี่ยนชื่อ ฉบับร่างของคุณจะยังคงอยู่ โปรดโหลดออบเจ็กต์ใหม่ก่อนบันทึก",+ sourceIdentitySaving: "กำลังบันทึกซอร์สโค้ดของออบเจ็กต์นี้อยู่ โปรดรอให้การบันทึกเสร็จสิ้น",+ sourceIdentityBusy: "ซอร์สโค้ดของออบเจ็กต์ที่เกี่ยวข้องกำลังบันทึกหรือเปลี่ยนชื่อ โปรดรอให้การดำเนินการเสร็จสิ้น",+ viewRenameRecovery: "คำจำกัดความดั้งเดิมสำหรับการตรวจสอบเพื่อกู้คืน โปรดตรวจสอบสถานะปัจจุบันของฐานข้อมูลก่อนเรียกใช้เพื่อหลีกเลี่ยงการเขียนทับการเปลี่ยนแปลงพร้อมกัน",all: "ทั้งหมด",tables: "Tables",collections: "Collections",diff --git a/apps/desktop/src/i18n/locales/tr.ts b/apps/desktop/src/i18n/locales/tr.tsindex 7d43a4d79f..d6b20bad5c 100644--- a/apps/desktop/src/i18n/locales/tr.ts+++ b/apps/desktop/src/i18n/locales/tr.ts@@ -4404,6 +4404,39 @@ export default withEnglishFallback({anyPrivilegeDisabled: "ANY türü yetkiler DM8 tarafından devre dışı bırakılmış (ENABLE_DDL_ANY_PRIV=0); verilemez veya geri alınamaz",},objects: {+ packageSaveAsTitle: "Paketi Farklı Kaydet",+ packageSaveAsHint: "{name} paketini yeni bir paket olarak kopyalayın. Özgün paket, çağıranları, kaydedilmiş öğeler ve açık taslaklar korunur.",+ packageSaveAsMetadataProblem: "Paket meta verileri eksik veya güvenle kopyalanamıyor. Tanılamayı inceleyip planı yenileyin.",+ packageSaveAsSuccess: "{oldName} paketi {newName} olarak kopyalandı.",+ packageSaveAsFailed: "Paket kopyalama durduruldu. Onaylanan ve sonucu belirsiz adımları inceleyin; özgün paket korundu.",+ viewRenameDraft: "Çalıştırılacak tanım (eski nesne adını kullanın)",+ routineRenamePreview: "Yordam veya işlev kaynak kodundan yeniden oluşturulacak, ardından özgün nesne silinecek.",+ tableRenameCoverage: "Geçerli hesabın görebildiği aynı şemadaki statik görünüm, yordam ve tetikleyici bağımlılıkları güncellenir. Güvenle tanımlanamayan başvuruyu taslakta düzenleyip yeniden doğrulayın; çözülmemiş sorunlar DDL işlemini engeller.",+ tableRenameObjects: "Bu plandaki nesneler",+ tableRenameDraft: "{schema}.{name} tanımı (düzenleyip yeniden doğrulayın)",+ tableRenameSuccess: "{oldName}, {newName} olarak yeniden adlandırıldı ve {count} görünür bağımlılık güncellendi.",+ routineRenameObjects: "Objects in this plan",+ routineRenameRewrite: "source update",+ routineRenameCompile: "recompile",+ routineRenameCoverage: "Yalnızca geçerli hesabın görebildiği, aynı şemadaki statik çağrılar güncellenir. Dinamik SQL ve uygulama başvuruları taşınmaz. Özgün nesne, yeni yordam veya işlev ve çağrıları doğrulandıktan sonra silinir.",+ viewRenameValidate: "Yeniden doğrula",+ viewRenameReload: "Planı yeniden yükle",+ viewRenameValidationPending: "Taslak doğrulamadan geçmedi. Düzeltin, yeniden doğrulayın ve yeniden adlandırmayı onaylayın.",+ viewRenameDefinitionReady: "Doğrulandı",+ viewRenameNeedsRepair: "Düzenleme gerekli",+ viewRenameIssueLocation: "Satır {line}, sütun {column}",+ viewRenameDiagnostics: "Tanılama ayrıntıları",+ viewRenameFinalSql: "Çalıştırılacak SQL",+ viewRenameMetadataProblem: "Meta veriler veya bağımlılıklar çalıştırmayı engelliyor. Açıklamaları izleyip planı yeniden yükleyin.",+ viewRenameIssueHint: "Bu ipucu güvenli biçimde otomatik yeniden yazılamıyor. Çalıştırılacak tanımı düzenleyin.",+ viewRenameIssueBinding: "Başvuru belirsiz veya başka bir adı gölgeliyor. Bağlamayı düzeltin.",+ viewRenameIssueDeclaration: "Geçerli sahip ve eski nesne adı için yalnızca bir CREATE VIEW içermelidir.",+ viewRenameIssueGraph: "Değişiklik planlanan bağımlılıkları değiştiriyor veya döngü oluşturuyor. Var olan başvuruları koruyun.",+ viewRenameIssueName: "Yeni ad geçersiz veya kullanımda. Adı değiştirip planı yeniden yükleyin.",+ viewRenameIssueState: "Nesne geçersiz veya yürütme kimliği eşleşmiyor. Nesneyi ya da bağlantıyı düzeltip yeniden yükleyin.",+ viewRenameIssueSource: "Tanım veya izinler tam okunamadı. Erişimi denetleyip yeniden yükleyin.",+ viewRenameIssueDependency: "Yalnızca aynı sahibin normal görünümleri otomatik güncellenir. Listelenen bağımlılıkları çözün ve yeniden yükleyin.",+ viewRenameIssueDrift: "Veritabanı nesneleri veya bağımlılıkları değişti. Taslak korundu; planı yeniden yükleyip inceleyin.",all: "Tümü",tables: "Tablolar",collections: "Koleksiyonlar",diff --git a/apps/desktop/src/i18n/locales/zh-CN.ts b/apps/desktop/src/i18n/locales/zh-CN.tsindex 1801e7ce40..6071c734d2 100644--- a/apps/desktop/src/i18n/locales/zh-CN.ts+++ b/apps/desktop/src/i18n/locales/zh-CN.ts@@ -5551,6 +5551,46 @@ export default withEnglishFallback({anyPrivilegeDisabled: "ANY 类权限已被 DM8 禁用(ENABLE_DDL_ANY_PRIV=0),无法授予或回收",},objects: {+ packageSaveAsTitle: "包另存为",+ packageSaveAsHint: "将 {name} 复制为新包。原包、调用方、收藏项和已打开的草稿都会保留。",+ packageSaveAsMetadataProblem: "包元数据不完整或无法安全复制。请查看诊断并刷新计划。",+ packageSaveAsSuccess: "已将包 {oldName} 复制为 {newName}。",+ packageSaveAsFailed: "包复制已停止。请查看下方已确认和结果未知的步骤;原包已保留。",+ viewRenameSuccess: "已将 {oldName} 更名为 {newName},并更新 {count} 个可见视图依赖。",+ viewRenameCoverage: "自动更新当前账号可见的同属主静态视图依赖。不可见的跨属主依赖、动态 SQL 和应用引用不会迁移,改名后可能失效。",+ viewRenameDraft: "待执行定义(使用改名前的对象名)",+ routineRenamePreview: "将从源码重建此过程或函数,随后删除原对象。",+ tableRenameCoverage: "自动更新当前账号可见的同属主静态视图、例程和触发器依赖。无法安全识别的引用可在草稿中修改并重新校验;仍未解决的问题会阻止执行 DDL。",+ tableRenameObjects: "本次计划对象",+ tableRenameDraft: "{schema}.{name} 的定义(修改后请重新校验)",+ tableRenameSuccess: "已将 {oldName} 更名为 {newName},并更新 {count} 个可见依赖。",+ routineRenameObjects: "本次计划对象",+ routineRenameRewrite: "更新源码",+ routineRenameCompile: "重新编译",+ routineRenameCoverage: "仅更新当前账号可见的同属主静态调用方;不可见的跨属主引用、动态 SQL 和应用引用可能在改名后失效。只有新例程和调用方都通过校验后才会删除原对象。",+ viewRenameValidate: "重新校验",+ viewRenameReload: "重新读取计划",+ viewRenameValidationPending: "先根据问题提示修正定义或依赖,再点击“重新校验”。全部通过后即可确认改名;校验未通过时不会执行 SQL。",+ viewRenameDefinitionReady: "已校验",+ viewRenameNeedsRepair: "需要补充修改",+ viewRenameIssueLocation: "第 {line} 行,第 {column} 列",+ viewRenameDiagnostics: "诊断详情",+ viewRenameFinalSql: "将执行的 SQL",+ viewRenameMetadataProblem: "元数据或依赖未满足执行条件,请按提示处理后重新读取。",+ viewRenameIssueHint: "系统已自动改写可确认的引用。此 hint 无法安全自动改写,请按上方位置补改本定义,再点击“重新校验”。",+ viewRenameIssueBinding: "引用存在歧义或名称捕获,请修正绑定。",+ viewRenameIssueDeclaration: "定义必须对应当前属主和改名前对象名,且只能包含一条 CREATE VIEW。",+ viewRenameIssueGraph: "修改会改变计划内依赖拓扑或形成循环,请保留既有引用关系。",+ viewRenameIssueName: "新名称无效或已被占用,请修改名称后重新读取。",+ viewRenameIssueState: "对象无效或执行身份不匹配,请先修正对象或连接后重新读取。",+ viewRenameIssueSource: "未能完整读取定义或授权,请排查权限后重新读取。",+ viewRenameIssueDependency: "当前只自动处理同属主普通视图,请先处理列出的其他依赖后重新读取。",+ viewRenameIssueDrift: "数据库对象或依赖已变化。草稿保留,请重新读取并核对。",+ viewRenameRefresh: "名称或目标已变化,请等待预览刷新后再确认。",+ sourceIdentityChanged: "对象源码已变化或正在改名。草稿已保留,请重新加载对象后再保存。",+ sourceIdentitySaving: "对象源码正在保存,请等待保存完成。",+ sourceIdentityBusy: "相关对象源码正在保存或改名,请等待操作完成。",+ viewRenameRecovery: "原始定义供核对恢复使用;执行前请先检查数据库现状,避免覆盖并发修改。",all: "全部",tables: "表",collections: "集合",diff --git a/apps/desktop/src/i18n/locales/zh-TW.ts b/apps/desktop/src/i18n/locales/zh-TW.tsindex dc3a9c4746..1f3d82da36 100644--- a/apps/desktop/src/i18n/locales/zh-TW.ts+++ b/apps/desktop/src/i18n/locales/zh-TW.ts@@ -4436,6 +4436,46 @@ export default withEnglishFallback({gridfs: "GridFS",},objects: {+ packageSaveAsTitle: "套件另存為",+ packageSaveAsHint: "將 {name} 複製為新套件。原套件、呼叫端、收藏項目和已開啟的草稿都會保留。",+ packageSaveAsMetadataProblem: "套件中繼資料不完整或無法安全複製。請查看診斷並重新整理計畫。",+ packageSaveAsSuccess: "已將套件 {oldName} 複製為 {newName}。",+ packageSaveAsFailed: "套件複製已停止。請查看下方已確認和結果不明的步驟;原套件已保留。",+ viewRenameSuccess: "已將 {oldName} 更名為 {newName},並更新 {count} 個可見檢視相依性。",+ viewRenameCoverage: "自動更新目前帳號可見的同擁有者靜態檢視相依性。不可見的跨擁有者相依性、動態 SQL 和應用程式參照不會遷移,改名後可能失效。",+ viewRenameDraft: "待執行定義(使用改名前的物件名稱)",+ routineRenamePreview: "將從原始碼重建此程序或函式,接著刪除原物件。",+ tableRenameCoverage: "自動更新目前帳號可見的同擁有者靜態檢視、程序和觸發器相依性。無法安全識別的參照可在草稿中修改並重新驗證;尚未解決的問題會阻止執行 DDL。",+ tableRenameObjects: "本次計畫物件",+ tableRenameDraft: "{schema}.{name} 的定義(修改後請重新驗證)",+ tableRenameSuccess: "已將 {oldName} 更名為 {newName},並更新 {count} 個可見相依性。",+ routineRenameObjects: "本次計畫物件",+ routineRenameRewrite: "更新原始碼",+ routineRenameCompile: "重新編譯",+ routineRenameCoverage: "僅更新目前帳號可見的同屬主靜態呼叫方;不可見的跨屬主參照、動態 SQL 和應用程式參照可能在改名後失效。新程序及呼叫方都通過驗證後才會刪除原物件。",+ viewRenameValidate: "重新驗證",+ viewRenameReload: "重新讀取計畫",+ viewRenameValidationPending: "草稿尚未通過驗證。修正後重新驗證,再確認改名。",+ viewRenameDefinitionReady: "已驗證",+ viewRenameNeedsRepair: "需要補充修改",+ viewRenameIssueLocation: "第 {line} 行,第 {column} 欄",+ viewRenameDiagnostics: "診斷詳細資料",+ viewRenameFinalSql: "將執行的 SQL",+ viewRenameMetadataProblem: "中繼資料或相依性未符合執行條件,請依提示處理後重新讀取計畫。",+ viewRenameIssueHint: "此 hint 無法安全自動改寫,請修改待執行定義。",+ viewRenameIssueBinding: "參照有歧義或名稱擷取,請修正繫結。",+ viewRenameIssueDeclaration: "定義必須對應目前擁有者及改名前物件名稱,且只能包含一個 CREATE VIEW。",+ viewRenameIssueGraph: "修改會改變計畫中的相依拓撲或形成循環,請保留既有參照關係。",+ viewRenameIssueName: "新名稱無效或已被使用,請修改名稱後重新讀取計畫。",+ viewRenameIssueState: "物件無效或執行身分不符,請先修正物件或連線後重新讀取。",+ viewRenameIssueSource: "無法完整讀取定義或授權,請檢查權限後重新讀取。",+ viewRenameIssueDependency: "目前只自動處理同擁有者的一般檢視,請先處理列出的其他相依項目再重新讀取。",+ viewRenameIssueDrift: "資料庫物件或相依性已變更。草稿已保留,請重新讀取並核對。",+ viewRenameRefresh: "名稱或目標已變更,請等待預覽重新整理後再確認。",+ sourceIdentityChanged: "物件原始碼已變更或正在重新命名。草稿已保留,請重新載入物件後再儲存。",+ sourceIdentitySaving: "物件原始碼正在儲存,請等待儲存完成。",+ sourceIdentityBusy: "相關物件原始碼正在儲存或重新命名,請等待操作完成。",+ viewRenameRecovery: "原始定義供核對復原使用;執行前請先檢查資料庫現況,避免覆寫並行修改。",validStatus: "VALID",invalidStatus: "INVALID",all: "全部",diff --git a/apps/desktop/src/lib/__tests__/table/objectRenameSql.spec.ts b/apps/desktop/src/lib/__tests__/table/objectRenameSql.spec.tsindex e0943ebdd0..45a36c8f0c 100644--- a/apps/desktop/src/lib/__tests__/table/objectRenameSql.spec.ts+++ b/apps/desktop/src/lib/__tests__/table/objectRenameSql.spec.ts@@ -23,9 +23,10 @@ describe("StarRocks object rename", () => {});describe("OceanBase Oracle object rename", () => {- it("offers table rename without enabling other object renames", () => {+ it("offers table and ordinary view rename while keeping materialized views deferred", () => {expect(supportsObjectRename("oceanbase-oracle", "TABLE")).toBe(true);- expect(supportsObjectRename("oceanbase-oracle", "VIEW")).toBe(false);+ expect(supportsObjectRename("oceanbase-oracle", "VIEW")).toBe(true);+ expect(supportsObjectRename("oceanbase-oracle", "MATERIALIZED_VIEW")).toBe(false);});});diff --git a/apps/desktop/src/lib/__tests__/table/objectSourceEditor.spec.ts b/apps/desktop/src/lib/__tests__/table/objectSourceEditor.spec.tsindex 9b74def20a..dfb62dcf7d 100644--- a/apps/desktop/src/lib/__tests__/table/objectSourceEditor.spec.ts+++ b/apps/desktop/src/lib/__tests__/table/objectSourceEditor.spec.ts@@ -1,6 +1,6 @@import { beforeEach, describe, expect, it, vi } from "vitest";import * as api from "@/lib/backend/api";-import { executeObjectSourceSave, formatObjectSourceSaveError, resolveObjectSourceEditDraft, supportsSourceBackedRoutineRename } from "@/lib/table/objectSourceEditor";+import { executeObjectSourceSave, fingerprintOracleRoutineObjectSource, formatObjectSourceSaveError, resolveObjectSourceEditDraft, rewriteOracleRoutineReferences, supportsSourceBackedRoutineRename } from "@/lib/table/objectSourceEditor";import { supportsObjectRename } from "@/lib/table/objectRenameSql";import { formatSqlForDisplay } from "@/lib/sql/sqlFormatter";@@ -8,6 +8,8 @@ vi.mock("@/lib/backend/api", () => ({executeInTransaction: vi.fn().mockResolvedValue({}),executeQuery: vi.fn().mockResolvedValue({}),executeScript: vi.fn().mockResolvedValue({}),+ rewriteOracleRoutineReferences: vi.fn().mockResolvedValue("CREATE VIEW v AS SELECT F_NEW(id) FROM t"),+ fingerprintOracleRoutineObjectSource: vi.fn().mockResolvedValue("fingerprint"),}));beforeEach(() => {@@ -22,6 +24,7 @@ describe("openGauss rename capabilities", () => {expect(supportsSourceBackedRoutineRename("opengauss", "FUNCTION")).toBe(false);expect(supportsSourceBackedRoutineRename("opengauss", "PROCEDURE")).toBe(false);expect(supportsSourceBackedRoutineRename("postgres", "FUNCTION")).toBe(true);+ expect(supportsSourceBackedRoutineRename("oceanbase-oracle", "FUNCTION")).toBe(true);});});@@ -44,6 +47,33 @@ describe("executeObjectSourceSave", () => {expect(api.executeQuery).toHaveBeenNthCalledWith(2, "conn-1", "app", "ALTER VIEW v AS SELECT 2", "public");expect(api.executeScript).not.toHaveBeenCalled();});++ it("executes Oracle-family rebuild statements in order and stops at the first failure", async () => {+ vi.mocked(api.executeQuery)+ .mockResolvedValueOnce({} as Awaited<ReturnType<typeof api.executeQuery>>)+ .mockRejectedValueOnce(new Error("CREATE failed"));++ await expect(executeObjectSourceSave("conn-1", "app", "oceanbase-oracle", ["CREATE FUNCTION f_new", "ALTER FUNCTION caller COMPILE", "DROP FUNCTION f_old"], "owner", 45)).rejects.toThrow("CREATE failed");++ expect(api.executeQuery).toHaveBeenCalledTimes(2);+ expect(api.executeQuery).toHaveBeenNthCalledWith(1, "conn-1", "app", "CREATE FUNCTION f_new", "owner", undefined, { timeoutSecs: 45 });+ expect(api.executeQuery).toHaveBeenNthCalledWith(2, "conn-1", "app", "ALTER FUNCTION caller COMPILE", "owner", undefined, { timeoutSecs: 45 });+ expect(api.executeScript).not.toHaveBeenCalled();+ });+});++describe("Oracle routine dependency source rewrite", () => {+ it("routes complete caller source through the shared backend implementation", async () => {+ const input = { databaseType: "oceanbase-oracle" as const, callerType: "VIEW" as const, targetType: "FUNCTION" as const, schema: "APP", oldName: "F_OLD", newName: "F_NEW", source: "CREATE VIEW v AS SELECT F_OLD(id) FROM t" };+ await expect(rewriteOracleRoutineReferences(input)).resolves.toBe("CREATE VIEW v AS SELECT F_NEW(id) FROM t");+ expect(api.rewriteOracleRoutineReferences).toHaveBeenCalledWith(input);+ });++ it("routes Oracle routine source fingerprint requests through the shared backend implementation", async () => {+ const input = { databaseType: "oceanbase-oracle" as const, objectType: "PROCEDURE" as const, schema: "APP", name: "CALLER", source: "CREATE PROCEDURE APP.CALLER IS BEGIN NULL; END;" };+ await expect(fingerprintOracleRoutineObjectSource(input)).resolves.toBe("fingerprint");+ expect(api.fingerprintOracleRoutineObjectSource).toHaveBeenCalledWith(input);+ });});describe("formatObjectSourceSaveError", () => {diff --git a/apps/desktop/src/lib/__tests__/table/objectSourceIdentity.spec.ts b/apps/desktop/src/lib/__tests__/table/objectSourceIdentity.spec.tsnew file mode 100644index 0000000000..db373457dd--- /dev/null+++ b/apps/desktop/src/lib/__tests__/table/objectSourceIdentity.spec.ts@@ -0,0 +1,71 @@+import { describe, expect, it } from "vitest";+import i18n, { loadLocaleMessages } from "@/i18n";+import { assertSourceIdentity, beginSourceSave, captureSourceIdentity, freezeSourceIdentities, renewSourceIdentity } from "@/lib/table/objectSourceIdentity";++const identity = (name: string) => ({ connectionId: "identity-test", database: "ORCL", schema: "APP", objectType: "VIEW", name });++describe("object source identity", () => {+ it("shows source-save protection in the selected Chinese locale", async () => {+ const previous = i18n.global.locale.value;+ await loadLocaleMessages("zh-CN");+ i18n.global.locale.value = "zh-CN";+ try {+ const stale = captureSourceIdentity(identity("localized-stale"));+ const migration = freezeSourceIdentities([stale]);+ migration.markDispatched();+ migration.finish();+ expect(() => beginSourceSave(stale)).toThrow("对象源码已变化或正在改名");+ const saving = captureSourceIdentity(identity("localized-saving"));+ const release = beginSourceSave(saving);+ try {+ expect(() => beginSourceSave(saving)).toThrow("对象源码正在保存");+ expect(() => freezeSourceIdentities([saving])).toThrow("相关对象源码正在保存或改名");+ } finally {+ release();+ }+ } finally {+ i18n.global.locale.value = previous;+ }+ });++ it("atomically excludes saving and migration across all affected identities", () => {+ const first = captureSourceIdentity(identity("first"));+ const second = captureSourceIdentity(identity("second"));+ const release = beginSourceSave(second);+ expect(() => freezeSourceIdentities([first, second])).toThrow();+ expect(() => assertSourceIdentity(first)).not.toThrow();+ release();+ const migration = freezeSourceIdentities([first, second]);+ expect(() => beginSourceSave(first)).toThrow();+ migration.cancel();+ expect(() => assertSourceIdentity(first)).not.toThrow();+ });++ it("keeps dispatched revisions stale while explicit reload creates a fresh version", () => {+ const old = captureSourceIdentity(identity("renamed"));+ const migration = freezeSourceIdentities([old]);+ migration.markDispatched();+ migration.cancel();+ expect(() => assertSourceIdentity(old)).toThrow();+ expect(() => renewSourceIdentity(captureSourceIdentity(old))).toThrow();+ migration.finish();+ expect(() => renewSourceIdentity(old)).toThrow();+ const fresh = renewSourceIdentity(captureSourceIdentity(old));+ expect(() => assertSourceIdentity(fresh)).not.toThrow();+ expect(() => beginSourceSave(old)).toThrow();+ });++ it("does not conflate quoted case, owner, connection, database or object kind", () => {+ const target = identity("Mixed");+ const other = [+ { ...target, name: "MIXED" },+ { ...target, schema: "OTHER" },+ { ...target, connectionId: "other" },+ { ...target, database: "other" },+ { ...target, objectType: "TABLE" },+ ].map(captureSourceIdentity);+ const migration = freezeSourceIdentities([target]);+ for (const snapshot of other) expect(() => assertSourceIdentity(snapshot)).not.toThrow();+ migration.cancel();+ });+});diff --git a/apps/desktop/src/lib/__tests__/table/oraclePackageSaveAs.spec.ts b/apps/desktop/src/lib/__tests__/table/oraclePackageSaveAs.spec.tsnew file mode 100644index 0000000000..cd25bbdc37--- /dev/null+++ b/apps/desktop/src/lib/__tests__/table/oraclePackageSaveAs.spec.ts@@ -0,0 +1,345 @@+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";+import { beginSourceSave, captureSourceIdentity } from "@/lib/table/objectSourceIdentity";+import { executeOraclePackageSaveAs, prepareOraclePackageSaveAs } from "@/lib/table/oraclePackageSaveAs";+import { invalidateObjectDdlCache } from "@/lib/metadata/objectDdlCache";+import { invalidateObjectBrowserRowsCache } from "@/lib/table/objectBrowserRowsCache";++const api = vi.hoisted(() => ({ executeQuery: vi.fn(), parseOracleObjectName: vi.fn(), buildExecutableObjectSourceStatements: vi.fn() }));+vi.mock("@/lib/backend/api", () => api);+vi.mock("@/lib/metadata/objectDdlCache", () => ({ invalidateObjectDdlCache: vi.fn().mockResolvedValue(undefined) }));+vi.mock("@/lib/table/objectBrowserRowsCache", () => ({ invalidateObjectBrowserRowsCache: vi.fn() }));++const target = { connectionId: "package-save-as", database: "APP", databaseType: "oracle" as const, schema: "APP", oldName: "P_OLD", newName: "P_NEW" };+const spec = "PACKAGE P_OLD AS\n PROCEDURE RUN;\nEND P_OLD;";+const body = "PACKAGE BODY P_OLD AS\n PROCEDURE RUN IS BEGIN NULL; END RUN;\nEND P_OLD;";+const result = (rows: unknown[][]) => ({ columns: [], rows, affected_rows: 0, execution_time_ms: 0 });+let sources: Map<string, string>;+let states: Map<string, { id: number; status: string }>;+let failBody: boolean;+let failSpec: boolean;+let failGrant: boolean;+let failFinalReadback: boolean;+let bodyNotCreated: boolean;+let tamperSpecId: boolean;+let operatorTargetConflict: boolean;+let newSpecReads: number;+let grants: Map<string, unknown[][]>;++function key(name: string, type: string) {+ return `${name}:${type}`;+}++function unquote(name: string) {+ return name.startsWith('"') ? name.slice(1, -1).replaceAll('""', '"') : name.toUpperCase();+}++beforeEach(() => {+ vi.clearAllMocks();+ sources = new Map([+ [key("P_OLD", "PACKAGE"), spec],+ [key("P_OLD", "PACKAGE BODY"), body],+ ]);+ states = new Map([+ [key("P_OLD", "PACKAGE"), { id: 11, status: "VALID" }],+ [key("P_OLD", "PACKAGE BODY"), { id: 12, status: "VALID" }],+ ]);+ failBody = false;+ failSpec = false;+ failGrant = false;+ failFinalReadback = false;+ bodyNotCreated = false;+ tamperSpecId = false;+ operatorTargetConflict = false;+ newSpecReads = 0;+ grants = new Map([["P_OLD", []]]);+ api.parseOracleObjectName.mockImplementation(async (name) => name.toUpperCase());+ api.buildExecutableObjectSourceStatements.mockImplementation(async ({ source }: { source: string }) => [source]);+ api.executeQuery.mockImplementation(async (_connection: string, _database: string, sql: string) => {+ if (sql.includes("SYS_CONTEXT")) return result([["APP", "APP"]]);+ if (sql.includes("FROM USER_OBJECTS")) {+ const name = /OBJECT_NAME='((?:''|[^'])*)'/.exec(sql)?.[1]?.replaceAll("''", "'") || "";+ const allowedTypes = [...sql.matchAll(/'((?:''|[^'])*)'/g)].map((match) => match[1]?.replaceAll("''", "'") || "");+ const rows = [...states]+ .filter(([objectKey]) => objectKey.startsWith(`${name}:`))+ .filter(([objectKey]) => !allowedTypes.length || allowedTypes.some((type) => objectKey.endsWith(`:${type}`)))+ .map(([objectKey, value]) => {+ const [objectName, objectType] = objectKey.split(":");+ let id = value.id;+ if (tamperSpecId && objectName === "P_NEW" && objectType === "PACKAGE" && ++newSpecReads >= 2) id++;+ return [objectName, objectType, id, value.status];+ });+ if (operatorTargetConflict && name === "P_NEW" && allowedTypes.includes("OPERATOR")) rows.push(["P_NEW", "OPERATOR", 19, "VALID"]);+ return result(rows);+ }+ if (sql.includes("FROM ALL_SOURCE")) {+ const name = /NAME='((?:''|[^'])*)'/.exec(sql)?.[1]?.replaceAll("''", "'") || "";+ const type = /TYPE='((?:''|[^'])*)'/.exec(sql)?.[1] || "";+ const source = sources.get(key(name, type));+ return result(source ? source.split("\n").map((line, index) => [index + 1, line]) : []);+ }+ if (sql.includes("FROM ALL_PROCEDURES")) return result([["RUN", null]]);+ if (sql.includes("FROM ALL_ARGUMENTS")) return result([]);+ if (sql.includes("FROM ALL_TAB_PRIVS")) {+ const name = /TABLE_NAME='((?:''|[^'])*)'/.exec(sql)?.[1]?.replaceAll("''", "'") || "";+ return result(grants.get(name) || []);+ }+ if (sql.includes("FROM USER_ERRORS")) return failFinalReadback && sql.includes("NAME='P_NEW'") ? result([["ERROR", "1", "1", "forced final readback failure"]]) : result([]);+ if (sql.startsWith('CREATE PACKAGE "P_NEW"') && failSpec) throw new Error("spec create failed");+ if (sql.startsWith("CREATE PACKAGE BODY") && failBody) throw new Error("body create failed");+ const create = /^CREATE PACKAGE( BODY)?\s+("(?:[^"]|"")*"|[A-Za-z_$#][\w$#]*)/i.exec(sql);+ if (create) {+ const objectType = create[1] ? "PACKAGE BODY" : "PACKAGE";+ const name = unquote(create[2]!);+ if (bodyNotCreated && objectType === "PACKAGE BODY") throw new Error("unexpected body creation");+ states.set(key(name, objectType), { id: objectType === "PACKAGE" ? 21 : 22, status: "VALID" });+ sources.set(key(name, objectType), sql.replace(/^CREATE\s+/i, "").replace(/;\s*$/, ""));+ return result([]);+ }+ if (sql.startsWith("GRANT EXECUTE")) {+ if (failGrant) throw new Error("grant create failed");+ const objectName = /ON "APP"\."((?:[^"]|"")*)"/i.exec(sql)?.[1]?.replaceAll('""', '"') || "";+ const grantee = / TO ("(?:[^"]|"")*"|PUBLIC)/i.exec(sql)?.[1];+ const rows = grants.get(objectName) || [];+ rows.push(["APP", grantee === "PUBLIC" ? "PUBLIC" : unquote(grantee || ""), "EXECUTE", sql.includes("WITH GRANT OPTION") ? "YES" : "NO"]);+ grants.set(objectName, rows);+ return result([]);+ }+ throw new Error(`Unexpected SQL: ${sql}`);+ });+});++afterEach(() => vi.clearAllMocks());++describe("Oracle package Save As plan and execution", () => {+ it("validates generated spec and body against the executable Oracle source parser", async () => {+ const plan = await prepareOraclePackageSaveAs(target);++ expect(plan.executable).toBe(true);+ expect(api.buildExecutableObjectSourceStatements).toHaveBeenNthCalledWith(+ 1,+ expect.objectContaining({+ databaseType: "oracle",+ objectType: "PACKAGE",+ schema: "APP",+ name: "P_NEW",+ source: expect.stringContaining('CREATE PACKAGE "P_NEW"'),+ }),+ );+ expect(api.buildExecutableObjectSourceStatements).toHaveBeenNthCalledWith(+ 2,+ expect.objectContaining({+ databaseType: "oracle",+ objectType: "PACKAGE_BODY",+ schema: "APP",+ name: "P_NEW",+ source: expect.stringContaining('CREATE PACKAGE BODY "P_NEW"'),+ }),+ );+ });++ it("reproduces a legal dynamic self-reference that blocks package Save As", async () => {+ const original = "PACKAGE BODY P_OLD AS\n PROCEDURE RUN IS BEGIN EXECUTE IMMEDIATE 'BEGIN P_OLD.RUN; END;'; END RUN;\nEND P_OLD;";+ sources.set(key("P_OLD", "PACKAGE BODY"), original);++ const plan = await prepareOraclePackageSaveAs(target);++ expect(plan.executable).toBe(false);+ expect(plan.issues.some((issue) => issue.code === "source_rewrite_failed")).toBe(true);+ expect(plan.snapshot?.bodySource).toBe(original);+ expect(plan.statements).toEqual([]);+ });++ it("keeps a variable dynamic SQL body editable and allows a corrected complete literal", async () => {+ const original = "PACKAGE BODY P_OLD AS PROCEDURE RUN IS s VARCHAR2(100) := 'BEGIN P_OLD.RUN; END;'; BEGIN EXECUTE IMMEDIATE s; END RUN; END P_OLD;";+ const corrected = "PACKAGE BODY P_OLD AS PROCEDURE RUN IS BEGIN EXECUTE IMMEDIATE 'BEGIN P_NEW.RUN; END;'; END RUN; END P_OLD;";+ sources.set(key("P_OLD", "PACKAGE BODY"), original);++ const initial = await prepareOraclePackageSaveAs(target);+ expect(initial.executable).toBe(false);+ expect(initial.issues.some((issue) => issue.code === "source_rewrite_failed" && issue.repairable)).toBe(true);+ expect(initial.snapshot?.bodySource).toBe(original);++ const repaired = await prepareOraclePackageSaveAs(target, { body: corrected });+ expect(repaired.executable).toBe(true);+ expect(repaired.bodySource).toContain("EXECUTE IMMEDIATE 'BEGIN P_NEW.RUN; END;'");+ });++ it("preserves a package body rewrite failure and revalidates a manual correction", async () => {+ const original = "PACKAGE BODY P_OLD AS\n PROCEDURE RUN IS BEGIN EXECUTE IMMEDIATE 'BEGIN P_OLD.RUN; END;'; END RUN;\nEND P_OLD;";+ const corrected = "PACKAGE BODY P_OLD AS\n PROCEDURE RUN IS BEGIN EXECUTE IMMEDIATE 'BEGIN P_NEW.RUN; END;'; END RUN;\nEND P_OLD;";+ sources.set(key("P_OLD", "PACKAGE BODY"), original);++ const initial = await prepareOraclePackageSaveAs(target);+ expect(initial.executable).toBe(false);+ expect(initial.issues.some((issue) => issue.code === "source_rewrite_failed")).toBe(true);+ expect(initial.snapshot?.bodySource).toBe(original);+ expect(initial.specSource).toContain('CREATE PACKAGE "P_NEW"');++ const repaired = await prepareOraclePackageSaveAs(target, { spec: spec, body: corrected });+ expect(repaired.issues).toEqual([]);+ expect(repaired.executable).toBe(true);+ expect(repaired.bodySource).toContain("P_NEW.RUN");+ expect(repaired.bodySource).toContain('CREATE PACKAGE BODY "P_NEW"');+ });++ it("reads and rewrites package specification and body separately", async () => {+ const plan = await prepareOraclePackageSaveAs(target);+ expect(plan.executable).toBe(true);+ expect(plan.statements).toHaveLength(2);+ expect(plan.statements[0]).toContain('CREATE PACKAGE "P_NEW"');+ expect(plan.statements[1]).toContain('CREATE PACKAGE BODY "P_NEW"');+ expect(plan.statements.join("\n")).not.toMatch(/OR REPLACE/i);+ expect(plan.snapshot?.specSource).toBe(spec);+ expect(plan.snapshot?.bodySource).toBe(body);+ });++ it("rechecks dialog currency after metadata reads and before the first CREATE", async () => {+ const plan = await prepareOraclePackageSaveAs(target);+ const isCurrent = vi.fn().mockReturnValueOnce(true).mockReturnValueOnce(true).mockReturnValueOnce(true).mockReturnValueOnce(true).mockReturnValueOnce(true).mockReturnValue(false);+ await expect(executeOraclePackageSaveAs(plan, isCurrent)).rejects.toThrow("The Save As dialog changed before package body creation.");+ expect(states.has(key("P_NEW", "PACKAGE"))).toBe(true);+ expect(states.has(key("P_NEW", "PACKAGE BODY"))).toBe(false);+ });++ it("copies a genuinely bodyless package only when both catalogs agree", async () => {+ sources.delete(key("P_OLD", "PACKAGE BODY"));+ states.delete(key("P_OLD", "PACKAGE BODY"));+ const plan = await prepareOraclePackageSaveAs(target);+ expect(plan.executable).toBe(true);+ expect(plan.bodySource).toBeNull();+ expect(plan.statements).toHaveLength(1);++ sources.set(key("P_OLD", "PACKAGE BODY"), body);+ const inconsistent = await prepareOraclePackageSaveAs({ ...target, connectionId: "package-save-as-inconsistent" });+ expect(inconsistent.executable).toBe(false);+ expect(inconsistent.issues.some((issue) => issue.code === "source_read_failed")).toBe(true);+ });++ it("accepts catalog readback with or without the final package terminator", async () => {+ const plan = await prepareOraclePackageSaveAs(target);+ await executeOraclePackageSaveAs(plan);+ for (const type of ["PACKAGE", "PACKAGE BODY"]) {+ const source = sources.get(key("P_NEW", type))!;+ sources.set(key("P_NEW", type), source.replace(/;$/, ""));+ }+ const repeatTarget = { ...target, oldName: "P_NEW", newName: "P_NEW_2" };+ const repeat = await prepareOraclePackageSaveAs(repeatTarget);+ expect(repeat.executable).toBe(true);+ await expect(executeOraclePackageSaveAs(repeat)).resolves.toBeUndefined();+ });++ it("blocks a target name already used by an operator", async () => {+ operatorTargetConflict = true;+ const plan = await prepareOraclePackageSaveAs(target);+ expect(plan.executable).toBe(false);+ expect(plan.issues.some((issue) => issue.code === "target_conflict")).toBe(true);+ });++ it("rechecks namespace and executes a manually corrected body with the same draft", async () => {+ const original = "PACKAGE BODY P_OLD AS\n PROCEDURE RUN IS BEGIN EXECUTE IMMEDIATE 'BEGIN P_OLD.RUN; END;'; END RUN;\nEND P_OLD;";+ const corrected = "PACKAGE BODY P_OLD AS\n PROCEDURE RUN IS BEGIN EXECUTE IMMEDIATE 'BEGIN P_NEW.RUN; END;'; END RUN;\nEND P_OLD;";+ sources.set(key("P_OLD", "PACKAGE BODY"), original);+ const plan = await prepareOraclePackageSaveAs(target, { body: corrected });+ expect(plan.executable).toBe(true);+ operatorTargetConflict = true;++ await expect(executeOraclePackageSaveAs(plan)).rejects.toThrow(/changed/i);++ expect(states.has(key("P_NEW", "PACKAGE"))).toBe(false);+ expect(states.has(key("P_NEW", "PACKAGE BODY"))).toBe(false);++ operatorTargetConflict = false;+ await expect(executeOraclePackageSaveAs(plan)).resolves.toBeUndefined();+ expect(sources.get(key("P_NEW", "PACKAGE BODY"))).toContain("P_NEW.RUN");+ });++ it("copies direct EXECUTE grants and verifies the new package", async () => {+ grants.set("P_OLD", [["APP", "PUBLIC", "EXECUTE", "NO"]]);+ const plan = await prepareOraclePackageSaveAs(target);+ const oldSpecIdentity = captureSourceIdentity({ connectionId: target.connectionId, database: target.database, schema: target.schema, objectType: "PACKAGE", name: target.oldName });+ const oldBodyIdentity = captureSourceIdentity({ connectionId: target.connectionId, database: target.database, schema: target.schema, objectType: "PACKAGE_BODY", name: target.oldName });+ expect(plan.statements[plan.statements.length - 1]).toContain('GRANT EXECUTE ON "APP"."P_NEW" TO PUBLIC');+ await executeOraclePackageSaveAs(plan);+ expect(states.get(key("P_OLD", "PACKAGE"))?.id).toBe(11);+ expect(states.has(key("P_NEW", "PACKAGE"))).toBe(true);+ expect(states.has(key("P_NEW", "PACKAGE BODY"))).toBe(true);+ expect(captureSourceIdentity(oldSpecIdentity).revision).toBe(oldSpecIdentity.revision);+ expect(captureSourceIdentity(oldBodyIdentity).revision).toBe(oldBodyIdentity.revision);+ });++ it("uses the canonical target name when reading package compile errors", async () => {+ const plan = await prepareOraclePackageSaveAs({ ...target, newName: "p_new" });+ const implementation = api.executeQuery.getMockImplementation()!;+ const errorQueries: string[] = [];+ api.executeQuery.mockImplementation(async (...args) => {+ if (String(args[2]).includes("FROM USER_ERRORS")) errorQueries.push(String(args[2]));+ return implementation(...args);+ });+ await executeOraclePackageSaveAs(plan);+ expect(errorQueries.length).toBeGreaterThan(0);+ expect(errorQueries.every((sql) => sql.includes("NAME='P_NEW'"))).toBe(true);+ });++ it("keeps a created specification as an explicit partial result when body creation fails and releases both source locks", async () => {+ const plan = await prepareOraclePackageSaveAs(target);+ const oldSpecIdentity = captureSourceIdentity({ connectionId: target.connectionId, database: target.database, schema: target.schema, objectType: "PACKAGE", name: target.oldName });+ const oldBodyIdentity = captureSourceIdentity({ connectionId: target.connectionId, database: target.database, schema: target.schema, objectType: "PACKAGE_BODY", name: target.oldName });+ failBody = true;+ await expect(executeOraclePackageSaveAs(plan)).rejects.toMatchObject({ completed: ["PACKAGE P_NEW"], uncertain: "PACKAGE BODY P_NEW" });+ expect(states.has(key("P_NEW", "PACKAGE"))).toBe(true);+ expect(states.has(key("P_NEW", "PACKAGE BODY"))).toBe(false);+ for (const objectType of ["PACKAGE", "PACKAGE_BODY"]) {+ const snapshot = captureSourceIdentity({ connectionId: target.connectionId, database: target.database, schema: target.schema, objectType, name: target.oldName });+ const release = beginSourceSave(snapshot);+ release();+ }+ expect(captureSourceIdentity(oldSpecIdentity).revision).toBe(oldSpecIdentity.revision);+ expect(captureSourceIdentity(oldBodyIdentity).revision).toBe(oldBodyIdentity.revision);+ expect(invalidateObjectBrowserRowsCache).toHaveBeenCalledWith({ connectionId: target.connectionId, database: target.database, schema: target.schema });+ expect(invalidateObjectDdlCache).toHaveBeenCalledTimes(2);+ });++ it("invalidates both caches when the first specification DDL has an unknown outcome", async () => {+ const plan = await prepareOraclePackageSaveAs(target);+ failSpec = true;+ await expect(executeOraclePackageSaveAs(plan)).rejects.toMatchObject({ completed: [], uncertain: "PACKAGE P_NEW", dispatched: true });+ expect(invalidateObjectBrowserRowsCache).toHaveBeenCalledOnce();+ expect(invalidateObjectDdlCache).toHaveBeenCalledTimes(2);+ });++ it("invalidates both caches after grant or final readback failure", async () => {+ grants.set("P_OLD", [["APP", "PUBLIC", "EXECUTE", "NO"]]);+ const grantPlan = await prepareOraclePackageSaveAs(target);+ failGrant = true;+ await expect(executeOraclePackageSaveAs(grantPlan)).rejects.toMatchObject({ completed: ["PACKAGE P_NEW", "PACKAGE BODY P_NEW"], dispatched: true });+ expect(invalidateObjectBrowserRowsCache).toHaveBeenCalledOnce();+ expect(invalidateObjectDdlCache).toHaveBeenCalledTimes(2);++ failGrant = false;+ states.delete(key("P_NEW", "PACKAGE"));+ states.delete(key("P_NEW", "PACKAGE BODY"));+ sources.delete(key("P_NEW", "PACKAGE"));+ sources.delete(key("P_NEW", "PACKAGE BODY"));+ vi.clearAllMocks();+ const finalPlan = await prepareOraclePackageSaveAs(target);+ failFinalReadback = true;+ await expect(executeOraclePackageSaveAs(finalPlan)).rejects.toMatchObject({ dispatched: true });+ expect(invalidateObjectBrowserRowsCache).toHaveBeenCalledOnce();+ expect(invalidateObjectDdlCache).toHaveBeenCalledTimes(2);+ });++ it("requires preview identity to remain current before dispatch", async () => {+ const plan = await prepareOraclePackageSaveAs(target);+ await expect(executeOraclePackageSaveAs(plan, () => false)).rejects.toThrow(/target changed/i);+ expect(states.has(key("P_NEW", "PACKAGE"))).toBe(false);+ expect(invalidateObjectBrowserRowsCache).not.toHaveBeenCalled();+ expect(invalidateObjectDdlCache).not.toHaveBeenCalled();+ });++ it("does not create the body if the new specification identity changes after its creation", async () => {+ const plan = await prepareOraclePackageSaveAs(target);+ tamperSpecId = true;+ await expect(executeOraclePackageSaveAs(plan)).rejects.toMatchObject({ completed: ["PACKAGE P_NEW"], uncertain: "PACKAGE P_NEW" });+ expect(states.has(key("P_NEW", "PACKAGE BODY"))).toBe(false);+ });+});diff --git a/apps/desktop/src/lib/__tests__/table/oraclePackageSource.spec.ts b/apps/desktop/src/lib/__tests__/table/oraclePackageSource.spec.tsnew file mode 100644index 0000000000..81dea345f0--- /dev/null+++ b/apps/desktop/src/lib/__tests__/table/oraclePackageSource.spec.ts@@ -0,0 +1,126 @@+import { describe, expect, it } from "vitest";+import { oraclePackageCatalogSource, rewriteOraclePackageSource } from "@/lib/table/oraclePackageSource";++describe("Oracle package Save As source rewrite", () => {+ it("preserves a differently cased quoted package reference in a copied body", () => {+ const source = 'PACKAGE BODY "p_old" AS BEGIN P_OLD.RUN; "p_old".RUN; END "p_old";';+ expect(rewriteOraclePackageSource(source, { owner: "APP", oldName: "p_old", newName: "P_NEW", body: true })).toContain('P_OLD.RUN; "P_NEW".RUN;');+ });+ it("adds CREATE and changes the package declaration, outer END and self-qualified member references", () => {+ const source = ["PACKAGE APP.P_OLD AS", " PROCEDURE RUN;", "END P_OLD;"].join("\r\n");+ expect(rewriteOraclePackageSource(source, { owner: "APP", oldName: "P_OLD", newName: "P_NEW", body: false })).toBe('CREATE PACKAGE APP."P_NEW" AS\r\n PROCEDURE RUN;\r\nEND "P_NEW";');+ });++ it("rejects SQL before the package declaration and CREATE OR REPLACE drafts", () => {+ expect(() => rewriteOraclePackageSource("DROP TABLE OTHER; PACKAGE OLD AS PROCEDURE P; END OLD;", { owner: "APP", oldName: "OLD", newName: "NEW", body: false })).toThrow();+ expect(() => rewriteOraclePackageSource("CREATE OR REPLACE PACKAGE OLD AS PROCEDURE P; END OLD;", { owner: "APP", oldName: "OLD", newName: "NEW", body: false })).toThrow();+ });++ it("rewrites a body self-reference but preserves comments, literals, nested END names and other owners", () => {+ const source = ["PACKAGE BODY P_OLD AS", " PROCEDURE RUN IS", " v VARCHAR2(20) := 'P_OLD.RUN'; -- P_OLD.RUN", " BEGIN", " P_OLD.RUN; OTHER.P_OLD.RUN;", " END RUN;", "END P_OLD;"].join("\n");+ expect(rewriteOraclePackageSource(source, { owner: "APP", oldName: "P_OLD", newName: "P_NEW", body: true })).toBe('CREATE PACKAGE BODY "P_NEW" AS\n PROCEDURE RUN IS\n v VARCHAR2(20) := \'P_OLD.RUN\'; -- P_OLD.RUN\n BEGIN\n "P_NEW".RUN; OTHER.P_OLD.RUN;\n END RUN;\nEND "P_NEW";');+ });++ it("preserves a string literal equal to the package name", () => {+ const source = "PACKAGE BODY P_OLD AS v VARCHAR2(20) := 'P_OLD'; BEGIN NULL; END P_OLD;";+ expect(rewriteOraclePackageSource(source, { owner: "APP", oldName: "P_OLD", newName: "P_NEW", body: true })).toContain("'P_OLD'");+ });++ it("rejects a variable dynamic SQL reference that cannot be retargeted", () => {+ const source = `PACKAGE BODY P_OLD AS+ PROCEDURE RUN IS+ s VARCHAR2(100) := 'BEGIN P_OLD.RUN; END;';+ BEGIN+ EXECUTE IMMEDIATE s;+ END RUN;+ END P_OLD;`;+ expect(() => rewriteOraclePackageSource(source, { owner: "APP", oldName: "P_OLD", newName: "P_NEW", body: true })).toThrow();+ });++ it.each([+ ["concatenated expression", "EXECUTE IMMEDIATE 'BEGIN P_OLD.RUN; END;' || suffix;"],+ ["quoted q-literal reference", "EXECUTE IMMEDIATE q'!BEGIN \"P_OLD\".RUN; END;!';"],+ ])("rejects %s dynamic SQL that needs manual correction", (_label, statement) => {+ const source = `PACKAGE BODY P_OLD AS PROCEDURE RUN IS suffix VARCHAR2(10); BEGIN ${statement} END RUN; END P_OLD;`;+ expect(() => rewriteOraclePackageSource(source, { owner: "APP", oldName: "P_OLD", newName: "P_NEW", body: true })).toThrow();+ });++ it("accepts a complete q-literal with no old package reference", () => {+ const source = "PACKAGE BODY P_OLD AS PROCEDURE RUN IS BEGIN EXECUTE IMMEDIATE q'!BEGIN NULL; END;!'; END RUN; END P_OLD;";+ expect(rewriteOraclePackageSource(source, { owner: "APP", oldName: "P_OLD", newName: "P_NEW", body: true })).toContain("q'!BEGIN NULL; END;!'");+ });++ it("rejects nested dynamic SQL hidden inside a complete string literal", () => {+ const source = "PACKAGE BODY P_OLD AS PROCEDURE RUN IS BEGIN EXECUTE IMMEDIATE 'BEGIN EXECUTE IMMEDIATE ''BEGIN P_OLD.RUN; END;''; END;'; END RUN; END P_OLD;";+ expect(() => rewriteOraclePackageSource(source, { owner: "APP", oldName: "P_OLD", newName: "P_NEW", body: true })).toThrow(/dynamic/i);+ });++ it("preserves an unnamed outer END", () => {+ expect(rewriteOraclePackageSource("PACKAGE P_OLD AS PROCEDURE RUN; END;", { owner: "APP", oldName: "P_OLD", newName: "P_NEW", body: false })).toBe('CREATE PACKAGE "P_NEW" AS PROCEDURE RUN; END;');+ });++ it("rejects a package name that would capture a local record in the copied body", () => {+ const source = "PACKAGE BODY P_OLD AS NEW_P RECORD; BEGIN RETURN P_OLD.VALUE; END P_OLD;";+ expect(() => rewriteOraclePackageSource(source, { owner: "APP", oldName: "P_OLD", newName: "NEW_P", body: true })).toThrow("could capture a reference");+ });++ it("rejects a new package name declared in a later package-body member", () => {+ const source = `PACKAGE BODY OLD_P AS+ PROCEDURE helper IS BEGIN NULL; END helper;+ FUNCTION value RETURN NUMBER IS+ TYPE rec IS RECORD (x NUMBER);+ NEW_P rec;+ BEGIN+ NEW_P.x := 2;+ RETURN OLD_P.x;+ END value;+ END OLD_P;`;+ expect(() => rewriteOraclePackageSource(source, { owner: "APP", oldName: "OLD_P", newName: "NEW_P", body: true })).toThrow("could capture a reference");+ });++ it("rejects a new package name declared inside a nested anonymous block", () => {+ const source = `PACKAGE BODY OLD_P AS+ FUNCTION value RETURN NUMBER IS+ BEGIN+ DECLARE+ TYPE rec IS RECORD (x NUMBER);+ NEW_P rec;+ BEGIN+ NEW_P.x := 2;+ RETURN OLD_P.x;+ END;+ END value;+ END OLD_P;`;+ expect(() => rewriteOraclePackageSource(source, { owner: "APP", oldName: "OLD_P", newName: "NEW_P", body: true })).toThrow("could capture a reference");+ });++ it("rejects a new package name used as a later member parameter", () => {+ const source = `PACKAGE BODY OLD_P AS+ PROCEDURE helper IS BEGIN NULL; END helper;+ FUNCTION f(NEW_P rec) RETURN NUMBER IS+ BEGIN+ RETURN OLD_P.x;+ END f;+ END OLD_P;`;+ expect(() => rewriteOraclePackageSource(source, { owner: "APP", oldName: "OLD_P", newName: "NEW_P", body: true })).toThrow("parameter NEW_P");+ });++ it("normalizes the optional final statement terminator from catalog source", () => {+ expect(oraclePackageCatalogSource('CREATE PACKAGE "P_NEW" AS PROCEDURE RUN; END "P_NEW";')).toBe('PACKAGE "P_NEW" AS PROCEDURE RUN; END "P_NEW"');+ expect(oraclePackageCatalogSource('PACKAGE "P_NEW" AS PROCEDURE RUN; END "P_NEW";')).toBe('PACKAGE "P_NEW" AS PROCEDURE RUN; END "P_NEW"');+ expect(oraclePackageCatalogSource('PACKAGE "P_NEW" AS PROCEDURE RUN; END "P_NEW"')).toBe('PACKAGE "P_NEW" AS PROCEDURE RUN; END "P_NEW"');+ });++ it("adds a missing catalog terminator before rewriting the package source", () => {+ expect(rewriteOraclePackageSource("PACKAGE P_OLD AS PROCEDURE RUN; END P_OLD", { owner: "APP", oldName: "P_OLD", newName: "P_NEW", body: false })).toBe('CREATE PACKAGE "P_NEW" AS PROCEDURE RUN; END "P_NEW";');+ });++ it.each([+ ["wrong object type", "PACKAGE BODY P_OLD AS END P_OLD;", false],+ ["wrong declaration", "PACKAGE P_OTHER AS END P_OTHER;", false],+ ["unqualified occurrence", "PACKAGE P_OLD AS PROCEDURE RUN IS BEGIN P_OLD := 1; END RUN; END P_OLD;", false],+ ["dynamic self reference", "PACKAGE BODY P_OLD AS BEGIN EXECUTE IMMEDIATE 'SELECT P_OLD.RUN FROM DUAL'; END P_OLD;", true],+ ])("rejects %s before producing replacement source", (_label, source, body) => {+ expect(() => rewriteOraclePackageSource(source, { owner: "APP", oldName: "P_OLD", newName: "P_NEW", body })).toThrow();+ });+});diff --git a/apps/desktop/src/lib/__tests__/table/oracleRoutineRename.spec.ts b/apps/desktop/src/lib/__tests__/table/oracleRoutineRename.spec.tsnew file mode 100644index 0000000000..d81800e05f--- /dev/null+++ b/apps/desktop/src/lib/__tests__/table/oracleRoutineRename.spec.ts@@ -0,0 +1,529 @@+import { beforeEach, describe, expect, it, vi } from "vitest";+import * as api from "@/lib/backend/api";+import { executeOracleRoutineRename, OracleRoutineRenameFailure, prepareOracleRoutineRename } from "@/lib/table/oracleRoutineRename";++vi.mock("@/lib/backend/api", () => ({+ parseOracleObjectName: vi.fn(async (name: string) => name.toUpperCase()),+ executeQuery: vi.fn(),+ rewriteOracleRoutineReferences: vi.fn(async ({ oldName, newName, source }: { oldName: string; newName: string; source: string }) => source.replaceAll(oldName, newName)),+ buildExecutableObjectSourceStatements: vi.fn(async ({ source }: { source: string }) => [source]),+ reviewOracleViewRenameSource: vi.fn(async ({ source, owner, viewName }: { source: string; owner: string; viewName: string }) => {+ const declaration = source.match(/CREATE(?:\s+OR\s+REPLACE)?\s+VIEW\s+(?:(\w+)\.)?(\w+)\s+AS/i);+ const valid = declaration && declaration[2].toUpperCase() === viewName.toUpperCase() && (!declaration[1] || declaration[1].toUpperCase() === owner.toUpperCase());+ return {+ source: valid ? { source: source.replace(/^\s*CREATE\s+VIEW/i, "CREATE OR REPLACE VIEW"), fingerprint: source, references: [] } : null,+ references: [],+ issues: valid ? [] : [{ code: "invalid_declaration", message: "The view declaration does not match the selected owner and name.", repairable: true }],+ };+ }),+ validateOracleExecutableObjectSource: vi.fn(async ({ source, objectType, schema, name }: { source: string; objectType: string; schema?: string | null; name: string }) => {+ const declaration = source.match(/CREATE(?:\s+OR\s+REPLACE)?\s+(PROCEDURE|FUNCTION)\s+(?:(\w+)\.)?(\w+)\s+(?:AS|IS)/i);+ if (!declaration || declaration[1] !== objectType || declaration[3].toUpperCase() !== name.toUpperCase() || (declaration[2] && declaration[2].toUpperCase() !== schema?.toUpperCase())) {+ throw new Error("Oracle object source declaration does not match the selected owner and name.");+ }+ }),+ fingerprintOracleRoutineObjectSource: vi.fn(async ({ source }: { source: string }) => source.replace(/\s+/g, "").replace(/;$/, "")),+ buildRoutineRenameObjectSourceStatements: vi.fn(async ({ name, newName, source }: { name: string; newName: string; source: string }) => {+ const renamed = source.replaceAll(name, newName);+ return [renamed.startsWith("CREATE OR REPLACE") ? renamed : `CREATE OR REPLACE ${renamed}`, `DROP PROCEDURE APP.${name}`];+ }),+}));++const target = { connectionId: "conn-1", database: "APP", databaseType: "oceanbase-oracle" as const, schema: "APP", objectType: "PROCEDURE" as const, oldName: "P_OLD", newName: "P_NEW" };+const rootSource = "CREATE OR REPLACE PROCEDURE APP.P_OLD AS BEGIN NULL; END;";+const firstCallerSource = "CREATE OR REPLACE PROCEDURE APP.CALLER_1 AS BEGIN APP.P_OLD; END;";+const secondCallerSource = "CREATE OR REPLACE PROCEDURE APP.CALLER_2 AS BEGIN APP.CALLER_1; END;";+const objects = new Map<string, { id: string; source: string; status?: string }>([+ ["PROCEDURE:P_OLD", { id: "101", source: rootSource }],+ ["PROCEDURE:CALLER_1", { id: "102", source: firstCallerSource }],+ ["PROCEDURE:CALLER_2", { id: "103", source: secondCallerSource }],+]);+let dependencyRows = new Map<string, unknown[][]>();+let grants = new Map<string, unknown[][]>();+let namespaceConflict = false;+let operatorNamespaceConflict = false;+let tamperCreatedAfterCaller = false;+let tamperCreatedOnCreate = false;+let dropErrorAfterDelete = false;+let invalidateCallerAAfterCallerZ = false;+let invalidateCreatedRoot = false;+let tamperCreatedDuringCompile = false;+let canonicalizeCallerReadback = false;+let canonicalizeRootReadback = false;+let mutateCallerBeforeDrop: "comment" | "string" | "call" | null = null;++function result(rows: unknown[][] = []) {+ return { rows, execution_error: false, error: null, truncated: false, has_more: false, large_value_cells: [] };+}++function sourceFromSql(sql: string) {+ const [, , name] = sql.match(/DBMS_METADATA\.GET_DDL\('([^']+)','([^']+)','([^']+)'\)/) ?? [];+ const [, type] = sql.match(/DBMS_METADATA\.GET_DDL\('([^']+)'/) ?? [];+ return objects.get(`${type}:${name}`)?.source ?? "";+}++beforeEach(() => {+ vi.clearAllMocks();+ vi.mocked(api.rewriteOracleRoutineReferences).mockImplementation(async ({ oldName, newName, source }) => source.replaceAll(oldName, newName));+ objects.clear();+ objects.set("PROCEDURE:P_OLD", { id: "101", source: rootSource });+ objects.set("PROCEDURE:CALLER_1", { id: "102", source: firstCallerSource });+ objects.set("PROCEDURE:CALLER_2", { id: "103", source: secondCallerSource });+ dependencyRows = new Map([+ ["PROCEDURE:P_OLD", [["APP", "CALLER_1", "PROCEDURE", null]]],+ ["PROCEDURE:CALLER_1", [["APP", "CALLER_2", "PROCEDURE", null]]],+ ["PROCEDURE:CALLER_2", []],+ ]);+ grants = new Map();+ namespaceConflict = false;+ operatorNamespaceConflict = false;+ tamperCreatedAfterCaller = false;+ tamperCreatedOnCreate = false;+ dropErrorAfterDelete = false;+ invalidateCallerAAfterCallerZ = false;+ invalidateCreatedRoot = false;+ tamperCreatedDuringCompile = false;+ canonicalizeCallerReadback = false;+ canonicalizeRootReadback = false;+ mutateCallerBeforeDrop = null;+ vi.mocked(api.executeQuery).mockImplementation(async (_connectionId, _database, sql) => {+ if (sql.startsWith("CREATE PROCEDURE APP.P_NEW")) {+ const source = (objects.get("PROCEDURE:P_OLD")?.source ?? rootSource).replaceAll("P_OLD", "P_NEW");+ const readback = canonicalizeRootReadback ? source.replace(/CREATE OR REPLACE PROCEDURE APP\.P_NEW\s+(?:AS|IS)\s+BEGIN/, "CREATE OR REPLACE PROCEDURE APP.P_NEW\n IS\nBEGIN") : source;+ objects.set("PROCEDURE:P_NEW", { id: "201", source: tamperCreatedOnCreate ? readback.replace("NULL", "RAISE") : readback, status: invalidateCreatedRoot ? "INVALID" : "VALID" });+ if (dependencyRows.get("PROCEDURE:P_OLD")?.some(([, name, type]) => name === "P_OLD" && type === "PROCEDURE")) {+ dependencyRows.set("PROCEDURE:P_NEW", [["APP", "P_NEW", "PROCEDURE", null]]);+ }+ return result() as never;+ }+ if (sql.startsWith("CREATE OR REPLACE PROCEDURE APP.CALLER_1")) {+ const source = canonicalizeCallerReadback ? sql.replace(/CREATE OR REPLACE PROCEDURE APP\.CALLER_1\s+(?:AS|IS)\s+BEGIN/, "CREATE OR REPLACE PROCEDURE APP.CALLER_1\n IS\nBEGIN") : sql;+ objects.set("PROCEDURE:CALLER_1", { id: "102", source });+ dependencyRows.set(+ "PROCEDURE:P_OLD",+ (dependencyRows.get("PROCEDURE:P_OLD") ?? []).filter(([, name, type]) => name === "P_OLD" && type === "PROCEDURE"),+ );+ dependencyRows.set("PROCEDURE:P_NEW", [...(dependencyRows.get("PROCEDURE:P_NEW") ?? []), ["APP", "CALLER_1", "PROCEDURE", null]]);+ if (tamperCreatedAfterCaller) objects.set("PROCEDURE:P_NEW", { id: "201", source: "CREATE OR REPLACE PROCEDURE APP.P_NEW AS BEGIN RAISE; END;" });+ return result() as never;+ }+ if (sql.startsWith("CREATE OR REPLACE VIEW APP.V_CALL")) {+ objects.set("VIEW:V_CALL", { id: "202", source: sql, status: "VALID" });+ dependencyRows.set(+ "PROCEDURE:P_OLD",+ (dependencyRows.get("PROCEDURE:P_OLD") ?? []).filter(([, name]) => name !== "V_CALL"),+ );+ dependencyRows.set("PROCEDURE:P_NEW", [...(dependencyRows.get("PROCEDURE:P_NEW") ?? []), ["APP", "V_CALL", "VIEW", null]]);+ return result() as never;+ }+ if (sql.startsWith("CREATE OR REPLACE PROCEDURE APP.CALLER_Z")) {+ objects.set("PROCEDURE:CALLER_Z", { id: "104", source: sql });+ dependencyRows.set("PROCEDURE:P_NEW", [...(dependencyRows.get("PROCEDURE:P_NEW") ?? []), ["APP", "CALLER_Z", "PROCEDURE", null]]);+ if (invalidateCallerAAfterCallerZ) objects.set("PROCEDURE:CALLER_A", { id: "105", source: objects.get("PROCEDURE:CALLER_A")!.source, status: "INVALID" });+ return result() as never;+ }+ if (sql.startsWith("CREATE OR REPLACE PROCEDURE APP.CALLER_A")) {+ objects.set("PROCEDURE:CALLER_A", { id: "105", source: sql, status: "VALID" });+ dependencyRows.set(+ "PROCEDURE:P_OLD",+ (dependencyRows.get("PROCEDURE:P_OLD") ?? []).filter(([, name, type]) => name === "P_OLD" && type === "PROCEDURE"),+ );+ dependencyRows.set("PROCEDURE:P_NEW", [...(dependencyRows.get("PROCEDURE:P_NEW") ?? []), ["APP", "CALLER_A", "PROCEDURE", null]]);+ return result() as never;+ }+ if (sql.startsWith("GRANT EXECUTE ON")) {+ grants.set("P_NEW", [["APP", "ALICE", "EXECUTE", "NO"]]);+ return result() as never;+ }+ if (sql.startsWith('ALTER PROCEDURE "APP"."P_NEW"')) {+ if (tamperCreatedDuringCompile) objects.set("PROCEDURE:P_NEW", { id: "202", source: "CREATE OR REPLACE PROCEDURE APP.P_NEW AS BEGIN RAISE; END;", status: "VALID" });+ else objects.set("PROCEDURE:P_NEW", { ...objects.get("PROCEDURE:P_NEW")!, status: "VALID" });+ return result() as never;+ }+ if (sql.startsWith('ALTER PROCEDURE "APP"."CALLER_2"') && mutateCallerBeforeDrop) {+ const caller = objects.get("PROCEDURE:CALLER_1")!;+ const source = mutateCallerBeforeDrop === "comment" ? caller.source.replace("APP.P_NEW;", "APP.P_NEW /* changed */;") : mutateCallerBeforeDrop === "string" ? caller.source.replace("'keep'", "'changed'") : caller.source.replace("APP.P_NEW", "APP.P_OTHER");+ objects.set("PROCEDURE:CALLER_1", { ...caller, source });+ }+ if (sql.startsWith("ALTER PROCEDURE")) return result() as never;+ if (sql.startsWith("DROP PROCEDURE APP.P_OLD")) {+ objects.delete("PROCEDURE:P_OLD");+ if (dropErrorAfterDelete) throw new Error("DROP response was lost");+ return result() as never;+ }+ if (sql === "SELECT USER, SYS_CONTEXT('USERENV','CURRENT_SCHEMA') FROM DUAL") return result([["APP", "APP"]]) as never;+ if (sql.includes("FROM USER_OBJECTS")) {+ const names = [...sql.matchAll(/'([^']+)'/g)].map((match) => match[1]);+ const types = [...sql.matchAll(/'([^']+)'/g)].map((match) => match[1]);+ const rows: unknown[][] = [];+ for (const [key, object] of objects) {+ const [type, name] = key.split(":");+ if (names.includes(name) && types.includes(type)) rows.push([name, type, Number(object.id), object.status ?? "VALID"]);+ }+ if (namespaceConflict && names.includes("P_NEW") && types.includes("TABLE")) rows.push(["P_NEW", "TABLE", 999, "VALID"]);+ if (operatorNamespaceConflict && names.includes("P_NEW") && types.includes("OPERATOR")) rows.push(["P_NEW", "OPERATOR", 998, "VALID"]);+ return result(rows) as never;+ }+ if (sql.includes("DBMS_LOB.GETLENGTH")) return result([[sourceFromSql(sql).length]]) as never;+ if (sql.includes("DBMS_LOB.SUBSTR")) {+ const source = sourceFromSql(sql);+ const offsets = [...sql.matchAll(/SELECT (\d+) CHUNK_OFFSET/g)].map((match) => Number(match[1]));+ return result(offsets.map((offset) => [offset, source.slice(offset - 1, offset + 999)])) as never;+ }+ if (sql.includes("FROM ALL_ARGUMENTS")) return result([]) as never;+ if (sql.includes("FROM ALL_TAB_PRIVS")) {+ const [, name] = sql.match(/TABLE_NAME='([^']+)'/) ?? [];+ return result(grants.get(name) ?? []) as never;+ }+ if (sql.includes("FROM USER_ERRORS")) return result([]) as never;+ if (sql.includes("SYS.DBA_DEPENDENCIES") || sql.includes("SYS.ALL_DEPENDENCIES")) {+ const [, referencedName, referencedType] = sql.match(/REFERENCED_NAME='([^']+)' AND REFERENCED_TYPE='([^']+)'/) ?? [];+ return result(dependencyRows.get(`${referencedType}:${referencedName}`) ?? []) as never;+ }+ throw new Error(`Unexpected metadata query: ${sql}`);+ });+});++describe("prepareOracleRoutineRename", () => {+ it("reproduces a legal dynamic caller reference that blocks the routine rename plan", async () => {+ const original = "CREATE OR REPLACE PROCEDURE APP.CALLER_1 AS BEGIN EXECUTE IMMEDIATE 'BEGIN APP.P_OLD; END;'; END;";+ objects.set("PROCEDURE:CALLER_1", { id: "102", source: original });+ vi.mocked(api.rewriteOracleRoutineReferences).mockImplementation(async ({ source }) => {+ if (/APP\.P_OLD/i.test(source)) throw new Error("Dynamic routine references cannot be rewritten automatically.");+ return source;+ });++ const plan = await prepareOracleRoutineRename(target);++ expect(plan.executable).toBe(false);+ expect(plan.issues.some(({ code, objectName }) => code === "caller_rewrite_failed" && objectName === "CALLER_1")).toBe(true);+ expect(plan.steps).toEqual([]);+ expect(objects.get("PROCEDURE:CALLER_1")?.source).toBe(original);+ });++ it("retains a failed caller source and revalidates a manual correction", async () => {+ const original = "CREATE OR REPLACE PROCEDURE APP.CALLER_1 AS BEGIN EXECUTE IMMEDIATE 'BEGIN APP.P_OLD; END;'; END;";+ const corrected = "CREATE OR REPLACE PROCEDURE APP.CALLER_1 AS BEGIN EXECUTE IMMEDIATE 'BEGIN APP.P_NEW; END;'; END;";+ objects.set("PROCEDURE:CALLER_1", { id: "102", source: original });+ vi.mocked(api.rewriteOracleRoutineReferences).mockImplementation(async ({ oldName, newName, source }) => {+ if (/APP\.P_OLD/i.test(source)) throw new Error("Dynamic routine references cannot be rewritten automatically.");+ return source.replaceAll(oldName, newName);+ });++ const initial = await prepareOracleRoutineRename(target);+ expect(initial.executable).toBe(false);+ expect(initial.callers.find((caller) => caller.name === "CALLER_1")).toMatchObject({ draft: original });+ expect(initial.issues.some(({ code, objectName }) => code === "caller_rewrite_failed" && objectName === "CALLER_1")).toBe(true);++ const repaired = await prepareOracleRoutineRename(target, { "PROCEDURE:CALLER_1": corrected });+ expect(repaired.issues).toEqual([]);+ expect(repaired.executable).toBe(true);+ expect(repaired.callers.find((caller) => caller.name === "CALLER_1")).toMatchObject({ draft: corrected, rewrittenSource: corrected });+ });++ it("collects a two-level dependency closure but rewrites only the direct caller", async () => {+ const plan = await prepareOracleRoutineRename(target);++ expect(plan.executable).toBe(true);+ expect(plan.callers.map(({ name, rewriteRequired }) => [name, rewriteRequired])).toEqual([+ ["CALLER_1", true],+ ["CALLER_2", false],+ ]);+ expect(plan.steps.filter((step) => step.kind === "replace-caller").map((step) => step.objectName)).toEqual(["CALLER_1"]);+ expect(plan.dependencyEdges).toContain(JSON.stringify(["CALLER_1", "PROCEDURE", "APP", "CALLER_2", "PROCEDURE", null]));+ expect(api.rewriteOracleRoutineReferences).toHaveBeenCalledTimes(1);+ expect(api.rewriteOracleRoutineReferences).toHaveBeenCalledWith(expect.objectContaining({ oldName: "P_OLD", newName: "P_NEW", source: firstCallerSource }));+ });++ it("blocks a non-self dependency cycle before producing executable steps", async () => {+ dependencyRows.set("PROCEDURE:CALLER_1", [["APP", "P_OLD", "PROCEDURE", null]]);++ const plan = await prepareOracleRoutineRename(target);++ expect(plan.executable).toBe(false);+ expect(plan.issues.some(({ code }) => code === "dependency_cycle")).toBe(true);+ expect(plan.steps).toEqual([]);+ });++ it("keeps a caller self-recursion edge outside the topological cycle check", async () => {+ dependencyRows.set("PROCEDURE:CALLER_1", [+ ["APP", "CALLER_1", "PROCEDURE", null],+ ["APP", "CALLER_2", "PROCEDURE", null],+ ]);++ const plan = await prepareOracleRoutineRename(target);++ expect(plan.executable).toBe(true);+ expect(plan.steps.filter((step) => step.kind === "replace-caller").map((step) => step.objectName)).toEqual(["CALLER_1"]);+ });++ it("maps a recursive root edge to the renamed routine and verifies the new graph", async () => {+ dependencyRows.set("PROCEDURE:P_OLD", [+ ["APP", "P_OLD", "PROCEDURE", null],+ ["APP", "CALLER_1", "PROCEDURE", null],+ ]);+ const plan = await prepareOracleRoutineRename(target);++ await expect(executeOracleRoutineRename(plan)).resolves.toBeUndefined();++ expect(objects.has("PROCEDURE:P_OLD")).toBe(false);+ expect(dependencyRows.get("PROCEDURE:P_NEW")).toContainEqual(["APP", "P_NEW", "PROCEDURE", null]);+ });++ it("uses dependency order and repairs a direct caller invalidated by an earlier planned replacement", async () => {+ const callerASource = "CREATE OR REPLACE PROCEDURE APP.CALLER_A AS BEGIN APP.P_OLD; APP.CALLER_Z; END;";+ const callerZSource = "CREATE OR REPLACE PROCEDURE APP.CALLER_Z AS BEGIN APP.P_OLD; END;";+ objects.set("PROCEDURE:CALLER_A", { id: "105", source: callerASource });+ objects.set("PROCEDURE:CALLER_Z", { id: "104", source: callerZSource });+ dependencyRows = new Map([+ [+ "PROCEDURE:P_OLD",+ [+ ["APP", "CALLER_A", "PROCEDURE", null],+ ["APP", "CALLER_Z", "PROCEDURE", null],+ ],+ ],+ ["PROCEDURE:CALLER_Z", [["APP", "CALLER_A", "PROCEDURE", null]]],+ ["PROCEDURE:CALLER_A", []],+ ]);+ invalidateCallerAAfterCallerZ = true;+ const plan = await prepareOracleRoutineRename(target);++ expect(plan.steps.filter((step) => step.kind === "replace-caller").map((step) => step.objectName)).toEqual(["CALLER_Z", "CALLER_A"]);+ await expect(executeOracleRoutineRename(plan)).resolves.toBeUndefined();++ expect(objects.get("PROCEDURE:CALLER_A")?.status).toBe("VALID");+ });++ it("blocks a conflicting object in the shared schema namespace", async () => {+ namespaceConflict = true;++ const plan = await prepareOracleRoutineRename(target);++ expect(plan.executable).toBe(false);+ expect(plan.issues.some(({ code }) => code === "target_conflict")).toBe(true);+ expect(api.executeQuery).toHaveBeenCalledWith("conn-1", "APP", expect.stringContaining("'TABLE'"), "APP", undefined, { maxRows: 5001 });+ });++ it("blocks a target name already used by an operator", async () => {+ operatorNamespaceConflict = true;++ const plan = await prepareOracleRoutineRename(target);++ expect(plan.executable).toBe(false);+ expect(plan.issues.some(({ code }) => code === "target_conflict")).toBe(true);+ expect(api.executeQuery).toHaveBeenCalledWith("conn-1", "APP", expect.stringContaining("'OPERATOR'"), "APP", undefined, { maxRows: 5001 });+ });++ it("rechecks namespace and executes a manually corrected caller with the same draft", async () => {+ const original = "CREATE OR REPLACE PROCEDURE APP.CALLER_1 AS BEGIN EXECUTE IMMEDIATE 'BEGIN APP.P_OLD; END;'; END;";+ const corrected = "CREATE OR REPLACE PROCEDURE APP.CALLER_1 AS BEGIN EXECUTE IMMEDIATE 'BEGIN APP.P_NEW; END;'; END;";+ objects.set("PROCEDURE:CALLER_1", { id: "102", source: original });+ vi.mocked(api.rewriteOracleRoutineReferences).mockImplementation(async ({ oldName, newName, source }) => {+ if (/APP\.P_OLD/i.test(source)) throw new Error("Dynamic routine references cannot be rewritten automatically.");+ return source.replaceAll(oldName, newName);+ });+ const plan = await prepareOracleRoutineRename(target, { "PROCEDURE:CALLER_1": corrected });+ expect(plan.executable).toBe(true);+ namespaceConflict = true;++ await expect(executeOracleRoutineRename(plan)).rejects.toThrow(/metadata changed/i);++ expect(objects.has("PROCEDURE:P_NEW")).toBe(false);+ expect(vi.mocked(api.executeQuery).mock.calls.some(([, , sql]) => sql.startsWith("CREATE"))).toBe(false);+ expect(vi.mocked(api.executeQuery).mock.calls.some(([, , sql]) => sql.startsWith("DROP"))).toBe(false);++ namespaceConflict = false;+ await expect(executeOracleRoutineRename(plan)).resolves.toBeUndefined();+ expect(objects.get("PROCEDURE:CALLER_1")?.source).toBe(corrected);+ expect(objects.has("PROCEDURE:P_OLD")).toBe(false);+ });++ it("migrates the direct caller, verifies the two-level graph, then drops the old routine", async () => {+ const plan = await prepareOracleRoutineRename(target);++ await expect(executeOracleRoutineRename(plan)).resolves.toBeUndefined();++ expect(objects.has("PROCEDURE:P_OLD")).toBe(false);+ expect(objects.get("PROCEDURE:P_NEW")?.id).toBe("201");+ expect(objects.get("PROCEDURE:CALLER_1")?.source).toContain("P_NEW");+ expect(objects.get("PROCEDURE:CALLER_2")?.source).toBe(secondCallerSource);+ expect(vi.mocked(api.executeQuery).mock.calls.some(([, , sql]) => sql.startsWith("DROP PROCEDURE"))).toBe(true);+ });++ it("accepts a new object identity after a rewritten caller view is verified", async () => {+ objects.clear();+ objects.set("PROCEDURE:P_OLD", { id: "101", source: rootSource });+ objects.set("VIEW:V_CALL", { id: "150", source: "CREATE OR REPLACE VIEW APP.V_CALL AS SELECT APP.P_OLD() AS RESULT FROM DUAL" });+ dependencyRows = new Map([+ ["PROCEDURE:P_OLD", [["APP", "V_CALL", "VIEW", null]]],+ ["VIEW:V_CALL", []],+ ]);+ const plan = await prepareOracleRoutineRename(target);++ await expect(executeOracleRoutineRename(plan)).resolves.toBeUndefined();++ expect(objects.get("VIEW:V_CALL")?.id).toBe("202");+ expect(objects.get("VIEW:V_CALL")?.source).toContain("P_NEW");+ expect(objects.has("PROCEDURE:P_OLD")).toBe(false);+ });++ it("rejects a rewritten caller view whose CREATE OR REPLACE targets another view", async () => {+ objects.clear();+ objects.set("PROCEDURE:P_OLD", { id: "101", source: rootSource });+ objects.set("VIEW:V_CALL", { id: "150", source: "CREATE OR REPLACE VIEW APP.V_OTHER AS SELECT APP.P_OLD() AS RESULT FROM DUAL" });+ dependencyRows = new Map([+ ["PROCEDURE:P_OLD", [["APP", "V_CALL", "VIEW", null]]],+ ["VIEW:V_CALL", []],+ ]);++ const plan = await prepareOracleRoutineRename(target);++ expect(plan.executable).toBe(false);+ expect(plan.issues.some(({ code, message }) => code === "caller_rewrite_failed" && /declaration does not match/i.test(message))).toBe(true);+ expect(api.reviewOracleViewRenameSource).toHaveBeenCalledWith(expect.objectContaining({ owner: "APP", viewName: "V_CALL", oldName: "P_NEW", newName: "P_NEW" }));+ expect(vi.mocked(api.buildExecutableObjectSourceStatements)).not.toHaveBeenCalledWith(expect.objectContaining({ objectType: "VIEW" }));+ });++ it("rejects a routine caller draft declaring a different object before producing steps", async () => {+ objects.set("PROCEDURE:CALLER_1", { id: "102", source: "CREATE OR REPLACE PROCEDURE OTHER.CALLER_1 AS BEGIN APP.P_OLD; END;" });++ const plan = await prepareOracleRoutineRename(target);++ expect(plan.executable).toBe(false);+ expect(plan.issues.some(({ code, message }) => code === "caller_rewrite_failed" && /declaration does not match/i.test(message))).toBe(true);+ expect(api.validateOracleExecutableObjectSource).toHaveBeenCalledWith(expect.objectContaining({ objectType: "PROCEDURE", schema: "APP", name: "CALLER_1" }));+ expect(plan.steps).toEqual([]);+ });++ it("accepts the database's quoted readback of a planned uppercase caller reference", async () => {+ vi.mocked(api.rewriteOracleRoutineReferences).mockImplementation(async ({ oldName, newName, source }) => source.replaceAll(oldName, `"${newName}"`));+ const plan = await prepareOracleRoutineRename(target);++ await expect(executeOracleRoutineRename(plan)).resolves.toBeUndefined();++ expect(objects.get("PROCEDURE:CALLER_1")?.source).toContain('"P_NEW"');+ expect(objects.has("PROCEDURE:P_OLD")).toBe(false);+ });++ it("executes a manually repaired caller draft after canonical database formatting", async () => {+ canonicalizeCallerReadback = true;+ const corrected = "CREATE OR REPLACE PROCEDURE APP.CALLER_1 IS BEGIN DBMS_OUTPUT.PUT_LINE('keep'); APP.P_OLD; APP.P_OLD; END";+ const plan = await prepareOracleRoutineRename(target, { "PROCEDURE:CALLER_1": corrected });++ expect(plan.executable).toBe(true);+ expect(plan.callers.find((caller) => caller.name === "CALLER_1")?.draft).toBe(corrected);+ expect(plan.steps.some((step) => step.kind === "replace-caller")).toBe(true);++ await expect(executeOracleRoutineRename(plan)).resolves.toBeUndefined();++ expect(objects.get("PROCEDURE:CALLER_1")?.source).toContain("CALLER_1\n IS\nBEGIN");+ expect(objects.has("PROCEDURE:P_OLD")).toBe(false);+ expect(vi.mocked(api.executeQuery).mock.calls.some(([, , sql]) => sql.startsWith("DROP PROCEDURE APP.P_OLD"))).toBe(true);+ });++ it("accepts a one-line root draft when the database reformats its readback", async () => {+ canonicalizeRootReadback = true;+ const correctedRoot = "CREATE OR REPLACE PROCEDURE APP.P_OLD IS BEGIN NULL; END";+ objects.set("PROCEDURE:P_OLD", { id: "101", source: correctedRoot });+ dependencyRows = new Map([["PROCEDURE:P_OLD", []]]);+ const plan = await prepareOracleRoutineRename(target, { "PROCEDURE:P_OLD": correctedRoot });++ await expect(executeOracleRoutineRename(plan)).resolves.toBeUndefined();++ expect(objects.has("PROCEDURE:P_OLD")).toBe(false);+ expect(objects.get("PROCEDURE:P_NEW")?.source).toContain("P_NEW\n IS\nBEGIN");+ });++ it.each(["comment", "string", "call"] as const)("does not drop the old routine after the rewritten caller's %s changes", async (mutation) => {+ mutateCallerBeforeDrop = mutation;+ const corrected = "CREATE OR REPLACE PROCEDURE APP.CALLER_1 IS BEGIN DBMS_OUTPUT.PUT_LINE('keep'); APP.P_OLD; APP.P_OLD; END";+ const plan = await prepareOracleRoutineRename(target, { "PROCEDURE:CALLER_1": corrected });++ await expect(executeOracleRoutineRename(plan)).rejects.toThrow(/CALLER_1 no longer matches the planned rewrite/i);++ expect(objects.has("PROCEDURE:P_OLD")).toBe(true);+ expect(vi.mocked(api.executeQuery).mock.calls.some(([, , sql]) => sql.startsWith("DROP PROCEDURE APP.P_OLD"))).toBe(false);+ });++ it("keeps the original caller snapshot exact when only its whitespace changes after validation", async () => {+ const corrected = "CREATE OR REPLACE PROCEDURE APP.CALLER_1 IS BEGIN APP.P_OLD; APP.P_OLD; END";+ const plan = await prepareOracleRoutineRename(target, { "PROCEDURE:CALLER_1": corrected });+ objects.set("PROCEDURE:CALLER_1", { ...objects.get("PROCEDURE:CALLER_1")!, source: firstCallerSource.replace(" AS BEGIN", " AS\n BEGIN") });++ await expect(executeOracleRoutineRename(plan)).rejects.toThrow(/metadata changed/i);++ expect(objects.has("PROCEDURE:P_NEW")).toBe(false);+ expect(objects.has("PROCEDURE:P_OLD")).toBe(true);+ expect(vi.mocked(api.executeQuery).mock.calls.some(([, , sql]) => sql.startsWith("CREATE OR REPLACE PROCEDURE APP.CALLER_1"))).toBe(false);+ expect(vi.mocked(api.executeQuery).mock.calls.some(([, , sql]) => sql.startsWith("DROP PROCEDURE APP.P_OLD"))).toBe(false);+ expect(vi.mocked(api.executeQuery).mock.calls.some(([, , sql]) => sql.startsWith("CREATE PROCEDURE APP.P_NEW"))).toBe(false);+ });++ it("normalizes database source readback before comparing the new routine definition", async () => {+ objects.set("PROCEDURE:P_OLD", { id: "101", source: rootSource.slice(0, -1) });+ const buildRoutineSource = vi.mocked(api.buildRoutineRenameObjectSourceStatements).getMockImplementation()!;+ vi.mocked(api.buildRoutineRenameObjectSourceStatements).mockImplementation(async (input) => {+ const statements = await buildRoutineSource(input);+ return [statements[0].endsWith(";") ? statements[0] : `${statements[0]};`, statements[1]];+ });++ const plan = await prepareOracleRoutineRename(target);+ await expect(executeOracleRoutineRename(plan)).resolves.toBeUndefined();++ expect(objects.has("PROCEDURE:P_OLD")).toBe(false);+ expect(objects.get("PROCEDURE:P_NEW")?.source).toBe(rootSource.slice(0, -1).replaceAll("P_OLD", "P_NEW"));+ });++ it("stops before replacing callers when the new routine body differs from the approved definition", async () => {+ tamperCreatedOnCreate = true;+ const plan = await prepareOracleRoutineRename(target);++ await expect(executeOracleRoutineRename(plan)).rejects.toMatchObject({ completed: [], uncertain: "P_NEW" });++ expect(objects.has("PROCEDURE:P_OLD")).toBe(true);+ expect(objects.get("PROCEDURE:CALLER_1")?.source).toBe(firstCallerSource);+ expect(vi.mocked(api.executeQuery).mock.calls.some(([, , sql]) => sql.startsWith("DROP PROCEDURE"))).toBe(false);+ });++ it("keeps the old routine when the new object changes after creation", async () => {+ tamperCreatedAfterCaller = true;+ const plan = await prepareOracleRoutineRename(target);++ await expect(executeOracleRoutineRename(plan)).rejects.toBeInstanceOf(OracleRoutineRenameFailure);++ expect(objects.has("PROCEDURE:P_OLD")).toBe(true);+ expect(vi.mocked(api.executeQuery).mock.calls.some(([, , sql]) => sql.startsWith("DROP PROCEDURE"))).toBe(false);+ });++ it("keeps the old routine when the new object identity changes during COMPILE", async () => {+ invalidateCreatedRoot = true;+ tamperCreatedDuringCompile = true;+ const plan = await prepareOracleRoutineRename(target);++ await expect(executeOracleRoutineRename(plan)).rejects.toThrow("changed during compilation");++ expect(objects.has("PROCEDURE:P_OLD")).toBe(true);+ expect(objects.get("PROCEDURE:P_NEW")?.id).toBe("202");+ expect(vi.mocked(api.executeQuery).mock.calls.some(([, , sql]) => sql.startsWith("DROP PROCEDURE"))).toBe(false);+ });++ it("confirms a lost DROP response by reading back the old routine identity", async () => {+ dropErrorAfterDelete = true;+ const plan = await prepareOracleRoutineRename(target);++ await expect(executeOracleRoutineRename(plan)).resolves.toBeUndefined();++ expect(objects.has("PROCEDURE:P_OLD")).toBe(false);+ });++ it("copies and verifies direct EXECUTE grants before dropping the old routine", async () => {+ grants.set("P_OLD", [["APP", "ALICE", "EXECUTE", "NO"]]);+ const plan = await prepareOracleRoutineRename(target);++ expect(plan.steps.map((step) => step.kind)).toEqual(["create", "grant", "replace-caller", "compile-caller", "drop"]);+ await expect(executeOracleRoutineRename(plan)).resolves.toBeUndefined();++ expect(grants.get("P_NEW")).toEqual([["APP", "ALICE", "EXECUTE", "NO"]]);+ });+});diff --git a/apps/desktop/src/lib/__tests__/table/oracleTableRename.spec.ts b/apps/desktop/src/lib/__tests__/table/oracleTableRename.spec.tsnew file mode 100644index 0000000000..8b820e0b9f--- /dev/null+++ b/apps/desktop/src/lib/__tests__/table/oracleTableRename.spec.ts@@ -0,0 +1,622 @@+import { beforeEach, describe, expect, it, vi } from "vitest";+import { executeOracleTableRename, OracleTableRenameFailure, prepareOracleTableRename } from "@/lib/table/oracleTableRename";+import { assertSourceIdentity, captureSourceIdentity } from "@/lib/table/objectSourceIdentity";++const api = vi.hoisted(() => ({ executeQuery: vi.fn(), parseOracleObjectName: vi.fn(), rewriteOracleTableReferences: vi.fn(), reviewOracleViewRenameSource: vi.fn() }));+vi.mock("@/lib/backend/api", () => api);++const target = { connectionId: "c", database: "OWNER", databaseType: "oceanbase-oracle" as const, schema: "OWNER", oldName: "OLD", newName: "NEW" };+const result = (rows: unknown[][]) => ({ columns: [], rows, affected_rows: 0, execution_time_ms: 0 });++interface FixtureObject {+ type: string;+ id: string;+ status: string;+ source: string;+ grant: string;+ error: string;+ triggerStatus?: string;+ triggerTable?: string;+}++let objects: Map<string, FixtureObject>;+let edges: unknown[][];+let statements: string[];+let nextId: number;+let targetConflict: string | false;+let loseRenameReply: boolean;+let failRenameReadbackOnRename: boolean;+let unknownRenameReadback: boolean;+let reuseOldNameAfterRename: boolean;+let driftGraphAfterRename: boolean;+let driftGraphAfterFirstRebuild: boolean;+let tamperCompletedViewAfterLaterRebuild: boolean;+let tamperInvalidViewAfterRename: boolean;+let tableIndexRows: unknown[][];+let tableConstraintRows: unknown[][];+let incomingForeignKeyRows: unknown[][];+let boundTriggerRows: unknown[][];+let driftTableMetadataAfterRename: boolean;+let referenceEdges: Map<string, unknown[][]>;+let enforceOracleColumnGrantOwnerColumn: boolean;+let columnGrantRows: unknown[][];++function key(type: string, name: string) {+ return `${type}:${name}`;+}++function fixture() {+ objects = new Map([+ [key("TABLE", "OLD"), { type: "TABLE", id: "1", status: "VALID", source: "", grant: "[]", error: "[]" }],+ [key("VIEW", "DEP"), { type: "VIEW", id: "2", status: "VALID", source: "CREATE VIEW DEP AS SELECT ID FROM OLD", grant: "[]", error: "[]" }],+ [key("PROCEDURE", "P1"), { type: "PROCEDURE", id: "3", status: "VALID", source: "CREATE PROCEDURE P1 AS n NUMBER; BEGIN SELECT COUNT(*) INTO n FROM OLD; END;", grant: "[]", error: "[]" }],+ ]);+ edges = [+ ["OWNER", "DEP", "VIEW", null],+ ["OWNER", "P1", "PROCEDURE", null],+ ];+ statements = [];+ nextId = 10;+ targetConflict = false;+ loseRenameReply = false;+ failRenameReadbackOnRename = false;+ unknownRenameReadback = false;+ reuseOldNameAfterRename = false;+ driftGraphAfterRename = false;+ driftGraphAfterFirstRebuild = false;+ tamperCompletedViewAfterLaterRebuild = false;+ tamperInvalidViewAfterRename = false;+ tableIndexRows = [];+ tableConstraintRows = [];+ incomingForeignKeyRows = [];+ boundTriggerRows = [];+ driftTableMetadataAfterRename = false;+ referenceEdges = new Map();+ enforceOracleColumnGrantOwnerColumn = false;+ columnGrantRows = [];+ api.parseOracleObjectName.mockImplementation(async (name: string) => name.toUpperCase());+ api.reviewOracleViewRenameSource.mockImplementation(async ({ source, owner, viewName, oldName, newName, targetViewName }: { source: string; owner: string; viewName: string; oldName: string; newName: string; targetViewName?: string }) => {+ const output = (oldName === newName ? source : source.replaceAll(new RegExp(`\\b${oldName}\\b`, "g"), `"${newName}"`)).replace(`VIEW ${viewName}`, `VIEW ${targetViewName || viewName}`);+ const references = [...source.matchAll(/\bFROM\s+"?([A-Z][A-Z0-9_$#]*)"?/gi)].map((match) => ({ owner, name: match[1] }));+ return { source: { source: output, fingerprint: output, references }, references, issues: [] };+ });+ api.rewriteOracleTableReferences.mockImplementation(async ({ source, oldName, newName }: { source: string; oldName: string; newName: string }) => {+ if (/EXECUTE\s+IMMEDIATE/i.test(source)) throw new Error("Dynamic SQL is outside the supported table-reference subset.");+ return source.replaceAll(new RegExp(`"?\\b${oldName}\\b"?`, "g"), `"${newName}"`);+ });+ api.executeQuery.mockImplementation(async (_connection: string, _database: string, sql: string) => {+ statements.push(sql);+ if (sql.includes("SYS_CONTEXT")) return result([["OWNER", "OWNER"]]);+ if (sql.includes("DEPENDENCIES")) {+ if (driftGraphAfterRename && sql.includes("REFERENCED_NAME='NEW'")) return result([["OWNER", "LATE", "VIEW", null]]);+ const reference = /REFERENCED_NAME='([^']+)'/.exec(sql)?.[1];+ const type = /REFERENCED_TYPE='([^']+)'/.exec(sql)?.[1];+ if (unknownRenameReadback && (reference === "NEW" || reference === "OLD")) throw new Error("readback unavailable");+ if (reference === "OLD" && type === "TABLE") return result(objects.has(key("TABLE", "OLD")) ? edges : []);+ if (reference === "NEW" && type === "TABLE") return result(objects.has(key("TABLE", "NEW")) ? edges : []);+ return result(referenceEdges.get(key(type || "", reference || "")) || []);+ }+ if (sql.includes("ALL_COL_PRIVS")) {+ if (enforceOracleColumnGrantOwnerColumn && /\bOWNER\s*=/i.test(sql)) return { ...result([]), execution_error: true, error: 'ORA-00904: "OWNER": invalid identifier' };+ return result(/\b(?:OWNER|TABLE_SCHEMA)\s*=/i.test(sql) ? columnGrantRows : []);+ }+ if (sql.includes("ALL_TAB_PRIVS")) return result([]);+ if (sql.includes("USER_ERRORS")) return result([]);+ if (sql.includes("USER_TRIGGERS")) {+ if (sql.includes("TABLE_NAME=")) {+ return result(boundTriggerRows);+ }+ const name = /TRIGGER_NAME='([^']+)'/.exec(sql)?.[1];+ const trigger = objects.get(key("TRIGGER", name || ""));+ return trigger ? result([[trigger.triggerStatus, trigger.triggerTable]]) : result([]);+ }+ if (sql.includes("USER_INDEXES")) return result(tableIndexRows);+ if (sql.includes("USER_CONSTRAINTS")) return result(tableConstraintRows);+ if (sql.includes("ALL_CONSTRAINTS")) return result(incomingForeignKeyRows);+ if (sql.includes("USER_IND_COLUMNS") || sql.includes("USER_CONS_COLUMNS")) return result([]);+ if (sql.includes("USER_OBJECTS")) {+ const name = /OBJECT_NAME='([^']+)'/.exec(sql)?.[1];+ if (unknownRenameReadback && (name === "NEW" || name === "OLD")) throw new Error("readback unavailable");+ const types = [...sql.matchAll(/'([A-Z ]+)'/g)].map((match) => match[1]);+ if (name === "NEW" && targetConflict && types.includes(targetConflict)) return result([[targetConflict, "99", "VALID"]]);+ const found = [...objects.values()].filter((object) => object.type && objects.get(key(object.type, name || "")) === object && (!types.length || types.includes(object.type)));+ return result(found.map((object) => [object.type, object.id, object.status]));+ }+ if (sql.includes("DBMS_LOB.GETLENGTH") || sql.includes("DBMS_LOB.SUBSTR")) {+ const name = /GET_DDL\('[A-Z ]+','([^']+)'/.exec(sql)?.[1];+ const object = [...objects.values()].find((item) => objects.get(key(item.type, name || "")) === item);+ const source = object?.source || `CREATE TABLE ${name} (ID NUMBER)`;+ if (sql.includes("GETLENGTH")) return result([[Array.from(source).length]]);+ const offsets = [...sql.matchAll(/SELECT (\d+) CHUNK_OFFSET/g)].map((match) => Number(match[1]));+ const chars = Array.from(source);+ return result(offsets.map((offset) => [offset, chars.slice(offset - 1, offset - 1 + 1000).join("")]));+ }+ if (sql.startsWith("RENAME")) {+ const oldTable = objects.get(key("TABLE", "OLD"))!;+ objects.delete(key("TABLE", "OLD"));+ objects.set(key("TABLE", "NEW"), oldTable);+ if (reuseOldNameAfterRename) objects.set(key("VIEW", "OLD"), { type: "VIEW", id: "88", status: "VALID", source: "CREATE VIEW OLD AS SELECT 1 ID FROM DUAL", grant: "[]", error: "[]" });+ for (const object of objects.values()) if (object.type === "VIEW") object.status = "INVALID";+ if (tamperInvalidViewAfterRename) {+ objects.get(key("VIEW", "DEP"))!.source = "CREATE VIEW DEP AS SELECT ID FROM OTHER";+ tamperInvalidViewAfterRename = false;+ }+ for (const object of objects.values()) {+ if (object.type !== "TRIGGER") continue;+ object.triggerTable = "NEW";+ object.source = object.source.replace(/\bON\s+OLD\b/i, "ON NEW");+ }+ if (driftGraphAfterRename) edges.push(["OWNER", "LATE", "VIEW", null]);+ if (driftTableMetadataAfterRename) tableIndexRows.push(["IDX_OLD", "NORMAL", "UNIQUE", "UNUSABLE", null]);+ if (failRenameReadbackOnRename) unknownRenameReadback = true;+ if (loseRenameReply) throw new Error("response lost");+ return result([]);+ }+ if (/\bCREATE(?: OR REPLACE)?\s+(?:VIEW|PROCEDURE|FUNCTION|TRIGGER)\b/i.test(sql)) {+ const declarationStart = sql.search(/\bCREATE(?: OR REPLACE)?\s+(?:VIEW|PROCEDURE|FUNCTION|TRIGGER)\b/i);+ const match = declarationStart < 0 ? null : /^CREATE(?: OR REPLACE)? (VIEW|PROCEDURE|FUNCTION|TRIGGER) (?:"OWNER"\.)?"?([A-Z0-9_$#]+)"?/i.exec(sql.slice(declarationStart));+ if (!match) throw new Error(`Unexpected DDL: ${sql}`);+ const [, type, name] = match;+ const prior = objects.get(key(type.toUpperCase(), name));+ const objectType = type.toUpperCase();+ const triggerStatus = prior?.triggerStatus || "ENABLED";+ const triggerTable = objectType === "TRIGGER" ? /\bON\s+"?([A-Z0-9_$#]+)"?/i.exec(sql)?.[1] : undefined;+ const stateClause = triggerStatus === "DISABLED" ? "DISABLE" : "ENABLE";+ const storedSource = objectType === "TRIGGER" ? `${sql}\nALTER TRIGGER OWNER.${name} ${stateClause};` : sql;+ objects.set(key(objectType, name), { type: objectType, id: objectType === "VIEW" ? String(nextId++) : prior?.id || String(nextId++), status: "VALID", source: storedSource, grant: prior?.grant || "[]", error: "[]", ...(objectType === "TRIGGER" ? { triggerStatus, triggerTable } : {}) });+ if (objectType === "VIEW" && tamperCompletedViewAfterLaterRebuild) {+ const procedure = objects.get(key("PROCEDURE", "P1"));+ if (procedure) procedure.source = procedure.source.replace('FROM "NEW"', 'FROM "OTHER"');+ tamperCompletedViewAfterLaterRebuild = false;+ }+ if (driftGraphAfterFirstRebuild) {+ driftGraphAfterFirstRebuild = false;+ edges.push(["OWNER", "LATE", "VIEW", null]);+ }+ return result([]);+ }+ if (sql.startsWith("ALTER PROCEDURE") || sql.startsWith("ALTER FUNCTION") || sql.startsWith("ALTER VIEW")) {+ const name = /"([A-Z0-9_$#]+)"\s+COMPILE/i.exec(sql)?.[1];+ const type = /^ALTER\s+(PROCEDURE|FUNCTION|VIEW)/i.exec(sql)?.[1]?.toUpperCase();+ const object = type && name ? objects.get(key(type, name)) : undefined;+ if (object) object.status = "VALID";+ return result([]);+ }+ throw new Error(`Unexpected query: ${sql}`);+ });+}++function mockInvalidViewSource() {+ api.reviewOracleViewRenameSource.mockImplementation(async ({ source, owner, oldName, newName }: { source: string; owner: string; oldName: string; newName: string }) => {+ if (source.includes("SELECT FROM")) return { source: null, references: [], issues: [{ code: "invalid_definition", message: "invalid view definition", repairable: true }] };+ const references = [...source.matchAll(/\bFROM\s+"?([A-Z][A-Z0-9_$#]*)"?/gi)].map((match) => ({ owner, name: match[1] }));+ const rewritten = oldName === newName ? source : source.replaceAll(new RegExp(`\\b${oldName}\\b`, "g"), `"${newName}"`);+ return { source: { source: rewritten, fingerprint: rewritten, references }, references, issues: [] };+ });+}++beforeEach(() => {+ vi.clearAllMocks();+ fixture();+});++describe("Oracle table rename plan", () => {+ it("reads native Oracle column grants through TABLE_SCHEMA", async () => {+ enforceOracleColumnGrantOwnerColumn = true;+ columnGrantRows = [["OWNER", "ALICE", "ID", "SELECT", "NO"]];++ const plan = await prepareOracleTableRename({ ...target, databaseType: "oracle" });++ expect(plan.executable).toBe(true);+ const grants = JSON.parse(plan.tableSnapshot!.grants) as unknown[][];+ expect(JSON.parse(String(grants[1]![0]))).toEqual(columnGrantRows[0]);+ });++ it("retains the OceanBase Oracle OWNER dictionary column", async () => {+ columnGrantRows = [["OWNER", "ALICE", "ID", "SELECT", "NO"]];++ const plan = await prepareOracleTableRename(target);++ expect(plan.executable).toBe(true);+ const grants = JSON.parse(plan.tableSnapshot!.grants) as unknown[][];+ expect(JSON.parse(String(grants[1]![0]))).toEqual(columnGrantRows[0]);+ expect(api.executeQuery).toHaveBeenCalledWith("c", "OWNER", expect.stringContaining("ALL_COL_PRIVS WHERE OWNER='OWNER'"), "OWNER", undefined, { maxRows: 5001 });+ });++ it("rejects a target namespace conflict before producing executable DDL", async () => {+ targetConflict = "VIEW";+ const plan = await prepareOracleTableRename(target);+ expect(plan.executable).toBe(false);+ expect(plan.issues.some((item) => item.code === "target_conflict")).toBe(true);+ expect(plan.steps).toEqual([]);+ });++ it("rechecks root indexes captured in the preview before renaming", async () => {+ tableIndexRows = [["IDX_OLD", "NORMAL", "UNIQUE", "VALID", null]];+ const plan = await prepareOracleTableRename(target);+ tableIndexRows = [["IDX_OLD", "NORMAL", "UNIQUE", "UNUSABLE", null]];++ await expect(executeOracleTableRename(plan)).rejects.toThrow("Table metadata changed");+ expect(statements.some((sql) => sql.startsWith("RENAME"))).toBe(false);+ });++ it("includes triggers bound to the table even when the dependency view omits them", async () => {+ objects.set(key("TRIGGER", "TR_ONLY"), {+ type: "TRIGGER",+ id: "4",+ status: "VALID",+ triggerStatus: "ENABLED",+ triggerTable: "OLD",+ source: "CREATE OR REPLACE TRIGGER TR_ONLY BEFORE INSERT ON OLD FOR EACH ROW BEGIN NULL; END;\nALTER TRIGGER OWNER.TR_ONLY ENABLE;",+ grant: "[]",+ error: "[]",+ });+ boundTriggerRows = [["TR_ONLY", "ENABLED"]];+ const plan = await prepareOracleTableRename(target);++ expect(plan.executable).toBe(true);+ expect(plan.dependents.some((dependent) => dependent.name === "TR_ONLY" && dependent.objectType === "TRIGGER")).toBe(true);+ });++ it("allows a trigger with the same target name because triggers use a separate namespace", async () => {+ targetConflict = "TRIGGER";+ const plan = await prepareOracleTableRename(target);+ expect(plan.executable).toBe(true);+ expect(plan.issues.some((item) => item.code === "target_conflict")).toBe(false);+ });++ it("lists unsupported dependencies and keeps the rename unexecutable", async () => {+ edges.push(["OWNER", "PKG", "PACKAGE", null]);+ const plan = await prepareOracleTableRename(target);+ expect(plan.executable).toBe(false);+ expect(plan.issues.some((item) => item.code === "unsupported_dependency" && item.objectName === "PKG")).toBe(true);+ expect(statements.some((sql) => sql.startsWith("RENAME"))).toBe(false);+ });++ it("keeps an unsupported source editable and enables execution after a corrected draft is revalidated", async () => {+ edges = [["OWNER", "P1", "PROCEDURE", null]];+ objects.delete(key("VIEW", "DEP"));+ objects.get(key("PROCEDURE", "P1"))!.source = "CREATE PROCEDURE P1 AS BEGIN EXECUTE IMMEDIATE 'SELECT * FROM OLD'; END;";+ const initial = await prepareOracleTableRename(target);+ expect(initial.executable).toBe(false);+ expect(initial.issues.some((item) => item.code === "source_rewrite_failed" && item.objectName === "P1" && item.repairable)).toBe(true);++ const corrected = await prepareOracleTableRename(target, {+ P1: "CREATE PROCEDURE P1 AS n NUMBER; BEGIN SELECT COUNT(*) INTO n FROM OLD; END;",+ });+ expect(corrected.issues).toEqual([]);+ expect(corrected.executable).toBe(true);+ expect(corrected.steps.map((step) => step.objectName)).toEqual(["OLD", "P1"]);+ await expect(executeOracleTableRename(corrected, { P1: corrected.dependents[0].draft })).resolves.toBeUndefined();+ expect(objects.get(key("PROCEDURE", "P1"))?.source).toContain('FROM "NEW"');+ });++ it("allows a manually corrected dependent view when its original definition cannot be parsed", async () => {+ edges = [["OWNER", "DEP", "VIEW", null]];+ objects.delete(key("PROCEDURE", "P1"));+ objects.get(key("VIEW", "DEP"))!.source = "CREATE VIEW DEP AS SELECT FROM OLD";+ mockInvalidViewSource();++ const initial = await prepareOracleTableRename(target);+ expect(initial.executable).toBe(false);+ expect(initial.issues.some((item) => item.code === "source_rewrite_failed" && item.objectName === "DEP")).toBe(true);++ const corrected = await prepareOracleTableRename(target, { DEP: "CREATE VIEW DEP AS SELECT ID FROM OLD" });+ expect(corrected.executable, JSON.stringify(corrected.issues)).toBe(true);+ expect(corrected.issues).toEqual([]);+ expect(corrected.steps.at(-1)?.sql).toContain('FROM "NEW"');+ await expect(executeOracleTableRename(corrected, { DEP: "CREATE VIEW DEP AS SELECT ID FROM OLD" })).resolves.toBeUndefined();+ expect(objects.get(key("VIEW", "DEP"))?.source).toContain('FROM "NEW"');+ });++ it("rejects a corrected view draft that removes a dependency from the planned graph", async () => {+ edges = [["OWNER", "DEP", "VIEW", null]];+ objects.delete(key("PROCEDURE", "P1"));+ objects.get(key("VIEW", "DEP"))!.source = "CREATE VIEW DEP AS SELECT FROM OLD";+ mockInvalidViewSource();++ const plan = await prepareOracleTableRename(target, { DEP: "CREATE VIEW DEP AS SELECT ID FROM DUAL" });+ expect(plan.executable).toBe(false);+ expect(+ plan.issues.some((item) => item.code === "manual_graph" && item.objectName === "DEP"),+ JSON.stringify({ issues: plan.issues, calls: api.reviewOracleViewRenameSource.mock.calls }),+ ).toBe(true);+ expect(plan.steps).toEqual([]);+ });++ it("keeps an incomplete external dependency graph blocking a corrected view draft", async () => {+ edges = [["OWNER", "DEP", "VIEW", null]];+ objects.delete(key("PROCEDURE", "P1"));+ objects.get(key("VIEW", "DEP"))!.source = "CREATE VIEW DEP AS SELECT FROM OLD";+ referenceEdges.set(key("VIEW", "DEP"), [["REMOTE_OWNER", "REMOTE_VIEW", "VIEW", null]]);+ mockInvalidViewSource();++ const plan = await prepareOracleTableRename(target, { DEP: "CREATE VIEW DEP AS SELECT ID FROM OLD" });+ expect(plan.executable).toBe(false);+ expect(plan.issues.some((item) => item.code === "unsupported_dependency")).toBe(true);+ expect(plan.steps).toEqual([]);+ });++ it("requires exact original-source equality when the invalid view has no fingerprint", async () => {+ edges = [["OWNER", "DEP", "VIEW", null]];+ objects.delete(key("PROCEDURE", "P1"));+ objects.get(key("VIEW", "DEP"))!.source = "CREATE VIEW DEP AS SELECT FROM OLD";+ mockInvalidViewSource();+ const plan = await prepareOracleTableRename(target, { DEP: "CREATE VIEW DEP AS SELECT ID FROM OLD" });+ expect(plan.executable).toBe(true);+ tamperInvalidViewAfterRename = true;++ await expect(executeOracleTableRename(plan, { DEP: "CREATE VIEW DEP AS SELECT ID FROM OLD" })).rejects.toBeInstanceOf(OracleTableRenameFailure);+ expect(statements.filter((sql) => sql.startsWith("RENAME"))).toHaveLength(1);+ expect(statements.filter((sql) => sql.startsWith("CREATE VIEW"))).toHaveLength(0);+ });++ it("does not treat a corrected indirect view draft as applied by COMPILE", async () => {+ edges = [["OWNER", "DEP", "VIEW", null]];+ objects.delete(key("PROCEDURE", "P1"));+ objects.get(key("VIEW", "DEP"))!.source = "CREATE VIEW DEP AS SELECT FROM OLD";+ objects.set(key("VIEW", "DEP2"), { type: "VIEW", id: "4", status: "VALID", source: "CREATE VIEW DEP2 AS SELECT FROM", grant: "[]", error: "[]" });+ referenceEdges.set(key("VIEW", "DEP"), [["OWNER", "DEP2", "VIEW", null]]);+ mockInvalidViewSource();++ const plan = await prepareOracleTableRename(target, { DEP: "CREATE VIEW DEP AS SELECT ID FROM OLD", DEP2: "CREATE VIEW DEP2 AS SELECT ID FROM DEP" });++ expect(plan.executable).toBe(false);+ expect(plan.issues.some((item) => item.code === "source_rewrite_failed" && item.objectName === "DEP2")).toBe(true);+ expect(plan.steps).toEqual([]);+ });++ it.each([+ ["another object", "CREATE OR REPLACE PROCEDURE OWNER.P_OTHER AS n NUMBER; BEGIN SELECT COUNT(*) INTO n FROM OLD; END;"],+ ["an appended statement", "CREATE OR REPLACE PROCEDURE P1 AS n NUMBER; BEGIN SELECT COUNT(*) INTO n FROM OLD; END; CREATE OR REPLACE PROCEDURE P_OTHER AS BEGIN NULL; END;"],+ ["a trailing DDL hidden before a second block", "CREATE OR REPLACE PROCEDURE P1 AS n NUMBER; BEGIN SELECT COUNT(*) INTO n FROM OLD; END; DROP TABLE VICTIM; BEGIN NULL; END;"],+ ])("rejects a draft that declares %s before any DDL is sent", async (_label, source) => {+ edges = [["OWNER", "P1", "PROCEDURE", null]];+ objects.delete(key("VIEW", "DEP"));+ const plan = await prepareOracleTableRename(target, { P1: source });++ expect(plan.executable).toBe(false);+ expect(plan.issues.some((item) => item.code === "source_rewrite_failed" && item.objectName === "P1")).toBe(true);+ expect(statements.some((sql) => sql.startsWith("RENAME"))).toBe(false);+ });++ it("rejects a direct routine draft that adds a new table dependency", async () => {+ edges = [["OWNER", "P1", "PROCEDURE", null]];+ objects.delete(key("VIEW", "DEP"));+ const draft = "CREATE OR REPLACE PROCEDURE P1 AS n NUMBER; BEGIN SELECT COUNT(*) INTO n FROM OLD; SELECT COUNT(*) INTO n FROM OTHER_TABLE; END;";+ const plan = await prepareOracleTableRename(target, { P1: draft });++ expect(plan.executable).toBe(false);+ expect(plan.issues.some((item) => item.message.includes("adds U:OTHER_TABLE"))).toBe(true);+ expect(statements.some((sql) => sql.startsWith("RENAME"))).toBe(false);+ });++ it.each([+ ["routine calls", "SELECT Q() INTO n FROM OLD"],+ ["type references", "DECLARE v OTHER_T.col%TYPE; BEGIN SELECT COUNT(*) INTO n FROM OLD"],+ ["case-sensitive quoted tables", 'SELECT COUNT(*) INTO n FROM OLD; SELECT COUNT(*) INTO n FROM "OTHER"'],+ ])("rejects a draft that changes %s", async (_label, additionalSource) => {+ edges = [["OWNER", "P1", "PROCEDURE", null]];+ objects.delete(key("VIEW", "DEP"));+ const original = "CREATE OR REPLACE PROCEDURE P1 AS n NUMBER; BEGIN SELECT COUNT(*) INTO n FROM OLD; END;";+ objects.get(key("PROCEDURE", "P1"))!.source = original;+ const draft = `CREATE OR REPLACE PROCEDURE P1 AS n NUMBER; BEGIN ${additionalSource}; END;`;+ const plan = await prepareOracleTableRename(target, { P1: draft });++ expect(plan.executable).toBe(false);+ expect(plan.issues.some((item) => item.code === "source_rewrite_failed")).toBe(true);+ expect(statements.some((sql) => sql.startsWith("RENAME"))).toBe(false);+ });++ it.each([+ ["qualified calls", "CREATE OR REPLACE PROCEDURE P1 AS n NUMBER; BEGIN S2.Q(); SELECT COUNT(*) INTO n FROM OLD; END;", "CREATE OR REPLACE PROCEDURE P1 AS n NUMBER; BEGIN S1.Q(); SELECT COUNT(*) INTO n FROM OLD; END;"],+ ["no-argument calls", "CREATE OR REPLACE PROCEDURE P1 AS n NUMBER; BEGIN R; SELECT COUNT(*) INTO n FROM OLD; END;", "CREATE OR REPLACE PROCEDURE P1 AS n NUMBER; BEGIN Q; SELECT COUNT(*) INTO n FROM OLD; END;"],+ ["quoted built-in-looking calls", 'CREATE OR REPLACE PROCEDURE P1 AS n NUMBER; BEGIN "SUM"(); SELECT COUNT(*) INTO n FROM OLD; END;', "CREATE OR REPLACE PROCEDURE P1 AS n NUMBER; BEGIN COUNT(); SELECT COUNT(*) INTO n FROM OLD; END;"],+ ["quoted identifiers containing spaces", 'CREATE OR REPLACE PROCEDURE P1 AS n NUMBER; BEGIN SELECT COUNT(*) INTO n FROM OLD; SELECT COUNT(*) INTO n FROM "A B"; END;', 'CREATE OR REPLACE PROCEDURE P1 AS n NUMBER; BEGIN SELECT COUNT(*) INTO n FROM OLD; SELECT COUNT(*) INTO n FROM "AB"; END;'],+ ])("rejects changed %s identities", async (_label, draft, original) => {+ edges = [["OWNER", "P1", "PROCEDURE", null]];+ objects.delete(key("VIEW", "DEP"));+ objects.get(key("PROCEDURE", "P1"))!.source = original;+ const plan = await prepareOracleTableRename(target, { P1: draft });++ expect(plan.executable).toBe(false);+ expect(plan.issues.some((item) => item.code === "source_rewrite_failed")).toBe(true);+ expect(statements.some((sql) => sql.startsWith("RENAME"))).toBe(false);+ });++ it.each([+ ["a cross-owner root-name reference", "CREATE OR REPLACE PROCEDURE P1 AS n NUMBER; BEGIN SELECT COUNT(*) INTO n FROM OLD; SELECT COUNT(*) INTO n FROM OTHER_OWNER.OLD; END;"],+ ["the second lowercase no-argument call", "CREATE OR REPLACE PROCEDURE P1 AS n NUMBER; BEGIN Q1; Q3; SELECT COUNT(*) INTO n FROM OLD; END;"],+ ])("rejects %s in a manual draft", async (_label, draft) => {+ edges = [["OWNER", "P1", "PROCEDURE", null]];+ objects.delete(key("VIEW", "DEP"));+ const original = _label === "the second lowercase no-argument call" ? "CREATE OR REPLACE PROCEDURE P1 AS n NUMBER; BEGIN Q1; Q2; SELECT COUNT(*) INTO n FROM OLD; END;" : "CREATE OR REPLACE PROCEDURE P1 AS n NUMBER; BEGIN SELECT COUNT(*) INTO n FROM OLD; END;";+ objects.get(key("PROCEDURE", "P1"))!.source = original;+ const plan = await prepareOracleTableRename(target, { P1: draft });++ expect(plan.executable).toBe(false);+ expect(plan.issues.some((item) => item.code === "source_rewrite_failed")).toBe(true);+ expect(statements.some((sql) => sql.startsWith("RENAME"))).toBe(false);+ });++ it("stops after rename if the dependency graph drifts and never sends a rebuild", async () => {+ const plan = await prepareOracleTableRename(target);+ driftGraphAfterRename = true;+ await expect(executeOracleTableRename(plan)).rejects.toBeInstanceOf(OracleTableRenameFailure);+ expect(statements.filter((sql) => sql.startsWith("RENAME"))).toHaveLength(1);+ expect(statements.filter((sql) => sql.startsWith("CREATE"))).toHaveLength(0);+ });++ it("reconciles a lost rename reply by readback but sends no later DDL", async () => {+ const plan = await prepareOracleTableRename(target);+ loseRenameReply = true;+ await expect(executeOracleTableRename(plan)).rejects.toMatchObject({ reconciliation: "confirmed", completed: [], uncertain: "TABLE OLD" });+ expect(objects.has(key("TABLE", "NEW"))).toBe(true);+ expect(statements.filter((sql) => sql.startsWith("CREATE"))).toHaveLength(0);+ });++ it("reports unknown and sends no later DDL when rename readback fails", async () => {+ const isolatedTarget = { ...target, connectionId: "unknown-outcome-c" };+ const identity = captureSourceIdentity({ connectionId: isolatedTarget.connectionId, database: isolatedTarget.database, schema: isolatedTarget.schema, objectType: "TABLE", name: "OLD" });+ const plan = await prepareOracleTableRename(isolatedTarget);+ loseRenameReply = true;+ failRenameReadbackOnRename = true;+ await expect(executeOracleTableRename(plan)).rejects.toMatchObject({ reconciliation: "unknown", completed: [], uncertain: "TABLE OLD" });+ expect(statements.filter((sql) => sql.startsWith("CREATE"))).toHaveLength(0);+ expect(() => assertSourceIdentity(identity)).toThrow();+ expect(plan.dependents.every((dependent) => typeof dependent.draft === "string")).toBe(true);+ });++ it("stops after a dependent rebuild when the graph changes before the next step", async () => {+ const plan = await prepareOracleTableRename(target);+ driftGraphAfterFirstRebuild = true;+ await expect(executeOracleTableRename(plan)).rejects.toBeInstanceOf(OracleTableRenameFailure);+ expect(statements.filter((sql) => sql.startsWith("RENAME"))).toHaveLength(1);+ expect(statements.filter((sql) => sql.startsWith("CREATE"))).toHaveLength(1);+ });++ it("rechecks all rebuilt dependents together before reporting success", async () => {+ const plan = await prepareOracleTableRename(target);+ tamperCompletedViewAfterLaterRebuild = true;++ await expect(executeOracleTableRename(plan)).rejects.toBeInstanceOf(OracleTableRenameFailure);+ expect(objects.get(key("PROCEDURE", "P1"))?.source).toContain('FROM "OTHER"');+ expect(objects.has(key("TABLE", "NEW"))).toBe(true);+ });++ it("rechecks the root table indexes after all dependent rebuilds", async () => {+ tableIndexRows = [["IDX_OLD", "NORMAL", "UNIQUE", "VALID", null]];+ const plan = await prepareOracleTableRename(target);+ driftTableMetadataAfterRename = true;++ await expect(executeOracleTableRename(plan)).rejects.toBeInstanceOf(OracleTableRenameFailure);+ expect(objects.has(key("TABLE", "NEW"))).toBe(true);+ });++ it("stops before rebuilding dependents if another object reuses the old name", async () => {+ const plan = await prepareOracleTableRename(target);+ reuseOldNameAfterRename = true;+ await expect(executeOracleTableRename(plan)).rejects.toBeInstanceOf(OracleTableRenameFailure);+ expect(objects.get(key("TABLE", "NEW"))?.id).toBe("1");+ expect(objects.get(key("VIEW", "OLD"))?.id).toBe("88");+ expect(statements.filter((sql) => sql.startsWith("CREATE"))).toHaveLength(0);+ });++ it("allows a dependent view to receive a new identity after rebuild", async () => {+ edges = [["OWNER", "DEP", "VIEW", null]];+ objects.delete(key("PROCEDURE", "P1"));+ const plan = await prepareOracleTableRename(target);+ const priorId = plan.dependents[0].objectId;+ await expect(executeOracleTableRename(plan)).resolves.toBeUndefined();+ expect(plan.dependents[0].objectId).not.toBe(priorId);+ expect(objects.get(key("TABLE", "NEW"))?.id).toBe("1");+ expect(objects.has(key("TABLE", "OLD"))).toBe(false);+ });++ it("orders mixed view and routine dependents by graph edges rather than object type", async () => {+ edges = [+ ["OWNER", "P1", "PROCEDURE", null],+ ["OWNER", "DEP", "VIEW", null],+ ];+ referenceEdges.set(key("VIEW", "DEP"), [["OWNER", "P1", "PROCEDURE", null]]);+ const plan = await prepareOracleTableRename(target);+ expect(plan.executable).toBe(true);+ expect(plan.steps.map((step) => step.objectName)).toEqual(["OLD", "DEP", "P1"]);+ });++ it("rebuilds transitive views without requiring them to reference the renamed table directly", async () => {+ edges = [["OWNER", "DEP", "VIEW", null]];+ objects.delete(key("PROCEDURE", "P1"));+ objects.set(key("VIEW", "DEP2"), { type: "VIEW", id: "4", status: "VALID", source: "CREATE VIEW DEP2 AS SELECT ID FROM DEP", grant: "[]", error: "[]" });+ referenceEdges.set(key("VIEW", "DEP"), [["OWNER", "DEP2", "VIEW", null]]);+ const plan = await prepareOracleTableRename(target);++ expect(plan.executable).toBe(true);+ expect(plan.dependents.map(({ name, rewrittenSource }) => [name, rewrittenSource])).toEqual([+ ["DEP", 'CREATE VIEW DEP AS SELECT ID FROM "NEW"'],+ ["DEP2", "CREATE VIEW DEP2 AS SELECT ID FROM DEP"],+ ]);+ expect(plan.steps.at(-1)?.kind).toBe("compile");+ await expect(executeOracleTableRename(plan)).resolves.toBeUndefined();+ });++ it("rewrites only direct routine dependencies and compiles transitive callers", async () => {+ edges = [["OWNER", "P1", "PROCEDURE", null]];+ objects.delete(key("VIEW", "DEP"));+ objects.set(key("PROCEDURE", "P2"), { type: "PROCEDURE", id: "4", status: "VALID", source: "CREATE PROCEDURE P2 AS BEGIN P1; END;", grant: "[]", error: "[]" });+ referenceEdges.set(key("PROCEDURE", "P1"), [["OWNER", "P2", "PROCEDURE", null]]);+ const plan = await prepareOracleTableRename(target);++ expect(plan.executable).toBe(true);+ expect(plan.dependents.map(({ name, rewriteRequired }) => [name, rewriteRequired])).toEqual([+ ["P1", true],+ ["P2", false],+ ]);+ await expect(executeOracleTableRename(plan)).resolves.toBeUndefined();+ expect(objects.get(key("PROCEDURE", "P2"))?.source).toBe("CREATE PROCEDURE P2 AS BEGIN P1; END;");+ expect(statements).toContain('ALTER PROCEDURE "OWNER"."P2" COMPILE;');+ });++ it("preserves enabled and disabled trigger states through the confirmed rename steps", async () => {+ edges = [+ ["OWNER", "TR_ENABLED", "TRIGGER", null],+ ["OWNER", "TR_DISABLED", "TRIGGER", null],+ ];+ objects.delete(key("VIEW", "DEP"));+ objects.delete(key("PROCEDURE", "P1"));+ objects.set(key("TRIGGER", "TR_ENABLED"), {+ type: "TRIGGER",+ id: "4",+ status: "VALID",+ triggerStatus: "ENABLED",+ triggerTable: "OLD",+ source: "CREATE OR REPLACE TRIGGER TR_ENABLED BEFORE INSERT ON OLD FOR EACH ROW BEGIN NULL; END;\nALTER TRIGGER OWNER.TR_ENABLED ENABLE;",+ grant: "[]",+ error: "[]",+ });+ objects.set(key("TRIGGER", "TR_DISABLED"), {+ type: "TRIGGER",+ id: "5",+ status: "VALID",+ triggerStatus: "DISABLED",+ triggerTable: "OLD",+ source: "CREATE OR REPLACE TRIGGER TR_DISABLED BEFORE INSERT ON OLD FOR EACH ROW -- DISABLE\nDECLARE note VARCHAR2(10) := 'DISABLE'; BEGIN NULL; END;\nALTER TRIGGER OWNER.TR_DISABLED DISABLE;",+ grant: "[]",+ error: "[]",+ });++ const plan = await prepareOracleTableRename(target);+ expect(plan.executable).toBe(true);+ await expect(executeOracleTableRename(plan)).resolves.toBeUndefined();++ expect(objects.get(key("TRIGGER", "TR_ENABLED"))?.triggerStatus).toBe("ENABLED");+ expect(objects.get(key("TRIGGER", "TR_DISABLED"))?.triggerStatus).toBe("DISABLED");+ expect(objects.get(key("TRIGGER", "TR_ENABLED"))?.triggerTable).toBe("NEW");+ expect(objects.get(key("TRIGGER", "TR_DISABLED"))?.triggerTable).toBe("NEW");+ expect(objects.get(key("TRIGGER", "TR_DISABLED"))?.source).toContain("FOR EACH ROW DISABLE");+ expect(statements.filter((sql) => sql.startsWith("CREATE OR REPLACE TRIGGER"))).toHaveLength(2);+ expect(statements.filter((sql) => sql.startsWith("ALTER TRIGGER"))).toHaveLength(0);+ });++ it("inserts DISABLE after the trigger header even when a leading comment contains FOR EACH ROW", async () => {+ edges = [["OWNER", "TR_DISABLED", "TRIGGER", null]];+ objects.delete(key("VIEW", "DEP"));+ objects.delete(key("PROCEDURE", "P1"));+ objects.set(key("TRIGGER", "TR_DISABLED"), {+ type: "TRIGGER",+ id: "5",+ status: "VALID",+ triggerStatus: "DISABLED",+ triggerTable: "OLD",+ source: "-- FOR EACH ROW is mentioned here\nCREATE OR REPLACE TRIGGER TR_DISABLED BEFORE INSERT ON OLD FOR EACH ROW BEGIN NULL; END;\nALTER TRIGGER OWNER.TR_DISABLED DISABLE;",+ grant: "[]",+ error: "[]",+ });++ const plan = await prepareOracleTableRename(target);+ expect(plan.executable, JSON.stringify(plan.issues)).toBe(true);+ const triggerStep = plan.steps.find((step) => step.objectName === "TR_DISABLED")!;+ expect(triggerStep.sql).toContain('-- FOR EACH ROW is mentioned here\nCREATE OR REPLACE TRIGGER TR_DISABLED BEFORE INSERT ON "NEW" FOR EACH ROW DISABLE');+ await expect(executeOracleTableRename(plan)).resolves.toBeUndefined();+ });+});diff --git a/apps/desktop/src/lib/__tests__/table/oracleViewRename.spec.ts b/apps/desktop/src/lib/__tests__/table/oracleViewRename.spec.tsnew file mode 100644index 0000000000..7133c1cfbe--- /dev/null+++ b/apps/desktop/src/lib/__tests__/table/oracleViewRename.spec.ts@@ -0,0 +1,396 @@+import { beforeEach, describe, expect, it, vi } from "vitest";+import { prepareOracleViewRename, executeOracleViewRename } from "@/lib/table/oracleViewRename";++const api = vi.hoisted(() => ({ executeQuery: vi.fn(), parseOracleObjectName: vi.fn(), buildOracleViewRenameSource: vi.fn(), reviewOracleViewRenameSource: vi.fn(), deleteSchemaCachePrefix: vi.fn().mockResolvedValue(undefined) }));+vi.mock("@/lib/backend/api", () => api);++const target = { connectionId: "c", database: "OWNER", schema: "OWNER", oldName: "OLD", newName: "NEW" };+const result = (rows: unknown[][]) => ({ columns: [], rows, affected_rows: 0, execution_time_ms: 0 });+let graph: unknown[][];+let statements: string[];+let renamed: boolean;++beforeEach(() => {+ graph = [];+ statements = [];+ renamed = false;+ vi.clearAllMocks();+ api.parseOracleObjectName.mockImplementation(async (name) => name.toUpperCase());+ api.buildOracleViewRenameSource.mockImplementation(async ({ source, targetViewName }) => ({ source, fingerprint: targetViewName || source }));+ api.reviewOracleViewRenameSource.mockImplementation(async ({ source, viewName, oldName, newName, targetViewName }) => {+ const rewrittenSource = source.replaceAll(oldName, newName).replace(`VIEW ${viewName}`, `VIEW ${targetViewName || viewName}`);+ const references = [...source.matchAll(/\bFROM\s+([A-Z][A-Z0-9_$#]*)/gi)].map((match) => ({ owner: "OWNER", name: match[1] }));+ const fingerprint = rewrittenSource.replace(/\bVIEW\s+[^\s]+/i, "VIEW <NAME>");+ return { source: { source: rewrittenSource, fingerprint, references }, references, issues: [] };+ });+ api.executeQuery.mockImplementation(async (_connection, _database, sql: string) => {+ statements.push(sql);+ if (sql.includes("SYS_CONTEXT")) return result([["OWNER", "OWNER"]]);+ if (sql.includes("DEPENDENCIES")) return result(graph);+ if (sql.includes("ALL_TAB_PRIVS") || sql.includes("ALL_COL_PRIVS")) return result([]);+ if (sql.includes("USER_OBJECTS")) {+ if (sql.includes("OBJECT_NAME='NEW'")) return result(renamed ? [["VIEW", "VALID"]] : []);+ return result(renamed ? [] : [["VIEW", "VALID"]]);+ }+ if (sql.includes("DBMS_LOB.GETLENGTH")) return result([[3]]);+ if (sql.includes("DBMS_LOB.SUBSTR")) return result([[1, renamed ? "NEW" : "OLD"]]);+ if (sql.startsWith("RENAME")) {+ renamed = true;+ return result([]);+ }+ throw new Error(`Unexpected query: ${sql}`);+ });+});++describe("OceanBase view rename plan", () => {+ it("keeps the visible-scope limitation even when there are no visible dependencies", async () => {+ const plan = await prepareOracleViewRename(target);+ expect(plan.statements).toEqual(['RENAME "OLD" TO "NEW";']);+ expect(plan.coverage).toBe("visible-only");+ expect(statements.some((sql) => sql.startsWith("RENAME"))).toBe(false);+ });++ it("blocks a visible foreign dependency before any mutation", async () => {+ graph = [["OTHER", "DEP", "VIEW", null]];+ const plan = await prepareOracleViewRename(target);+ expect(plan.executable).toBe(false);+ expect(plan.issues[0].message).toContain("OTHER");+ expect(renamed).toBe(false);+ });++ it("rejects truncated metadata instead of treating it as a complete graph", async () => {+ api.executeQuery.mockResolvedValue({ ...result([]), truncated: true });+ const plan = await prepareOracleViewRename(target);+ expect(plan.metadataComplete).toBe(false);+ expect(plan.executable).toBe(false);+ expect(renamed).toBe(false);+ });++ it("invalidates the preview if a dependency appears before dispatch", async () => {+ const plan = await prepareOracleViewRename(target);+ graph = [["OTHER", "DEP", "VIEW", null]];+ await expect(executeOracleViewRename(plan)).rejects.toThrow(/OTHER|changed/i);+ expect(renamed).toBe(false);+ });++ it("checks metadata identity before using an unqualified RENAME", async () => {+ api.executeQuery.mockResolvedValue(result([["SOMEONE_ELSE", "OWNER"]]));+ const plan = await prepareOracleViewRename(target);+ expect(plan.executable).toBe(false);+ expect(plan.issues.length).toBeGreaterThan(0);+ expect(renamed).toBe(false);+ });++ it("does not dispatch when the UI target changes during preflight", async () => {+ const plan = await prepareOracleViewRename(target);+ const isCurrent = vi.fn().mockReturnValueOnce(true).mockReturnValue(false);+ await expect(executeOracleViewRename(plan, isCurrent)).rejects.toThrow(/changed/i);+ expect(renamed).toBe(false);+ });++ it("reads back the new definition, validity, grants and disappearance of the old name", async () => {+ const plan = await prepareOracleViewRename({ ...target, connectionId: "success" });+ await executeOracleViewRename(plan);+ expect(renamed).toBe(true);+ expect(statements.filter((sql) => sql.startsWith("RENAME"))).toHaveLength(1);+ expect(statements.at(-1)).toContain("OBJECT_NAME='OLD'");+ });++ it("keeps a dispatched failure distinct from a preflight rejection", async () => {+ const plan = await prepareOracleViewRename({ ...target, connectionId: "unknown" });+ const implementation = api.executeQuery.getMockImplementation()!;+ api.executeQuery.mockImplementation(async (...args) => {+ if (String(args[2]).startsWith("RENAME")) throw new Error("Connection closed before the reply");+ return implementation(...args);+ });+ await expect(executeOracleViewRename(plan)).rejects.toMatchObject({ completed: [], uncertain: "NEW", plan });+ expect(renamed).toBe(false);+ });++ it("falls back only for a denied dictionary and retains the visible-scope limitation", async () => {+ const implementation = api.executeQuery.getMockImplementation()!;+ api.executeQuery.mockImplementation(async (...args) => {+ if (String(args[2]).includes("SYS.DBA_DEPENDENCIES")) throw new Error("ORA-00942: table or view does not exist");+ return implementation(...args);+ });+ const plan = await prepareOracleViewRename(target);+ expect(plan.coverage).toBe("visible-only");+ expect(statements.some((sql) => sql.includes("SYS.ALL_DEPENDENCIES"))).toBe(true);+ });++ it("does not hide a known foreign dependency behind a fallback query", async () => {+ graph = [["OTHER", "DEP", "VIEW", null]];+ const plan = await prepareOracleViewRename(target);+ expect(plan.executable).toBe(false);+ expect(plan.issues.some((item) => item.message.includes("OTHER"))).toBe(true);+ expect(statements.some((sql) => sql.includes("SYS.ALL_DEPENDENCIES"))).toBe(false);+ });++ it("rejects a smaller dependency graph after preview", async () => {+ let visible = true;+ const implementation = api.executeQuery.getMockImplementation()!;+ api.executeQuery.mockImplementation(async (...args) => {+ const sql = String(args[2]);+ if (sql.includes("DEPENDENCIES")) return result(visible && sql.includes("REFERENCED_NAME='OLD'") ? [["OWNER", "DEP", "VIEW", null]] : []);+ return implementation(...args);+ });+ const plan = await prepareOracleViewRename(target);+ expect(plan.views.map((view) => view.name)).toEqual(["OLD", "DEP"]);+ visible = false;+ await expect(executeOracleViewRename(plan)).rejects.toThrow(/changed/i);+ expect(renamed).toBe(false);+ });++ it("refuses dependency cycles", async () => {+ graph = [["OWNER", "OLD", "VIEW", null]];+ const plan = await prepareOracleViewRename(target);+ expect(plan.executable).toBe(false);+ expect(plan.issues.some((item) => item.code === "dependency_cycle")).toBe(true);+ expect(renamed).toBe(false);+ });++ it("uses the actual column-permission dictionary owner column", async () => {+ const implementation = api.executeQuery.getMockImplementation()!;+ api.executeQuery.mockImplementation(async (...args) => {+ if (String(args[2]).includes("ALL_COL_PRIVS") && String(args[2]).includes("TABLE_SCHEMA")) throw new Error("ORA-00904: invalid identifier 'TABLE_SCHEMA'");+ return implementation(...args);+ });+ await expect(prepareOracleViewRename(target)).resolves.toMatchObject({ canonicalNewName: "NEW" });+ });+});++function dependencyFixture(options: { drift?: boolean; failSecond?: boolean } = {}) {+ const sources = new Map([+ ["OLD", "CREATE VIEW OLD AS SELECT 42 X FROM DUAL"],+ ["DEP", "CREATE VIEW DEP AS SELECT /*+ FULL(X) */ * FROM OLD X"],+ ["DEP2", "CREATE VIEW DEP2 AS SELECT * FROM DEP"],+ ]);+ const writes: string[] = [];+ const valid = new Set(["OLD", "DEP", "DEP2"]);+ api.buildOracleViewRenameSource.mockImplementation(async ({ source, oldName, newName, targetViewName }) => {+ let rewritten = source.replaceAll(new RegExp(`\\b${oldName}\\b`, "g"), newName);+ if (targetViewName) rewritten = rewritten.replace(/^CREATE VIEW \w+/, `CREATE VIEW ${targetViewName}`);+ return { source: rewritten, fingerprint: rewritten.replace(/\/\*.*?\*\//g, "") };+ });+ api.executeQuery.mockImplementation(async (_connection, _database, sql: string) => {+ if (sql.includes("SYS_CONTEXT")) return result([["OWNER", "OWNER"]]);+ if (sql.includes("DEPENDENCIES")) return result(sql.includes("REFERENCED_NAME='OLD'") ? [["OWNER", "DEP", "VIEW", null]] : sql.includes("REFERENCED_NAME='DEP'") ? [["OWNER", "DEP2", "VIEW", null]] : []);+ if (sql.includes("ALL_TAB_PRIVS") || sql.includes("ALL_COL_PRIVS")) return result([]);+ if (sql.includes("USER_OBJECTS")) {+ const name = /OBJECT_NAME='([^']+)'/.exec(sql)![1];+ return result(sources.has(name) ? [["VIEW", valid.has(name) ? "VALID" : "INVALID"]] : []);+ }+ if (sql.includes("DBMS_LOB")) {+ const name = /GET_DDL\('VIEW','([^']+)'/.exec(sql)![1];+ const source = sources.get(name)!;+ return sql.includes("GETLENGTH") ? result([[source.length]]) : result([[1, source]]);+ }+ writes.push(sql);+ if (sql.startsWith("RENAME")) {+ sources.set("NEW", sources.get("OLD")!.replace("VIEW OLD", "VIEW NEW"));+ sources.delete("OLD");+ valid.clear();+ valid.add("NEW");+ if (options.drift) sources.set("DEP", sources.get("DEP")!.replace("FULL(X)", "INDEX(X)"));+ return result([]);+ }+ if (sql.startsWith("CREATE VIEW")) {+ const name = /^CREATE VIEW (\w+)/.exec(sql)![1];+ if (name === "DEP2" && options.failSecond) throw new Error("DDL reply lost");+ sources.set(name, sql);+ valid.add(name);+ return result([]);+ }+ throw new Error(`Unexpected query: ${sql}`);+ });+ return { sources, writes, valid };+}++describe("view dependency execution", () => {+ it("keeps safe dependent SQL visible when one hint needs a manual repair, then executes the revalidated draft", async () => {+ const fixture = dependencyFixture();+ const review = api.reviewOracleViewRenameSource.getMockImplementation()!;+ api.reviewOracleViewRenameSource.mockImplementation(async (input) => {+ if (input.viewName === "DEP" && String(input.source).includes("FULL(X)")) {+ return { source: null, references: [{ owner: "OWNER", name: "OLD" }], issues: [{ code: "unsupported_hint", message: "Needs a manual hint edit", viewName: "DEP", hintText: "FULL(X)", location: { line: 1, column: 31 }, repairable: true }] };+ }+ return review(input);+ });+ const blocked = await prepareOracleViewRename({ ...target, connectionId: "manual-hint" });+ expect(blocked.executable).toBe(false);+ expect(blocked.views.find((view) => view.name === "DEP")?.source).toContain("FULL(X)");+ expect(blocked.views.find((view) => view.name === "DEP2")?.rewrittenSource).toContain("FROM DEP");+ expect(blocked.issues[0]).toMatchObject({ viewName: "DEP", hintText: "FULL(X)", location: { line: 1, column: 31 } });++ const repaired = await prepareOracleViewRename({ ...target, connectionId: "manual-hint" }, { DEP: "CREATE VIEW DEP AS SELECT * FROM OLD" });+ expect(repaired.executable).toBe(true);+ expect(repaired.steps.map((step) => step.kind)).toEqual(["rename", "replace", "replace"]);+ await expect(executeOracleViewRename(repaired)).resolves.toBeUndefined();+ expect(fixture.writes.map((sql) => (sql.startsWith("RENAME") ? "RENAME" : /^CREATE VIEW (\w+)/.exec(sql)?.[1]))).toEqual(["RENAME", "DEP", "DEP2"]);+ });++ it("replaces a manually corrected root before renaming it", async () => {+ const fixture = dependencyFixture();+ const plan = await prepareOracleViewRename({ ...target, connectionId: "manual-root" }, { OLD: "CREATE VIEW OLD AS SELECT 43 X FROM DUAL" });+ expect(plan.executable).toBe(true);+ expect(plan.steps.map((step) => step.kind)).toEqual(["replace", "rename", "replace", "replace"]);+ await executeOracleViewRename(plan);+ expect(fixture.writes[0]).toContain("43 X");+ expect(fixture.writes[1]).toMatch(/^RENAME/);+ });++ it("allows a parser failure to be corrected when the database dependency edge stays unchanged", async () => {+ dependencyFixture();+ const review = api.reviewOracleViewRenameSource.getMockImplementation()!;+ api.reviewOracleViewRenameSource.mockImplementation(async (input) => {+ if (input.viewName === "DEP" && input.source.includes("FULL(X)")) {+ return { source: null, references: [], issues: [{ code: "invalid_definition", message: "Unsupported query form", viewName: "DEP", repairable: true }] };+ }+ return review(input);+ });+ const blocked = await prepareOracleViewRename({ ...target, connectionId: "manual-parser" });+ expect(blocked.executable).toBe(false);+ const repaired = await prepareOracleViewRename({ ...target, connectionId: "manual-parser" }, { DEP: "CREATE VIEW DEP AS SELECT * FROM OLD" });+ expect(repaired.executable).toBe(true);+ expect(repaired.issues).toEqual([]);+ });++ it("keeps a definition draft visible but blocks changed dependency relationships", async () => {+ const fixture = dependencyFixture();+ const plan = await prepareOracleViewRename({ ...target, connectionId: "manual-graph" }, { DEP: "CREATE VIEW DEP AS SELECT * FROM DEP2" });+ expect(plan.executable).toBe(false);+ expect(plan.issues.some((item) => item.code === "manual_graph" && item.viewName === "DEP")).toBe(true);+ expect(plan.views.find((view) => view.name === "DEP")?.draft).toBe("CREATE VIEW DEP AS SELECT * FROM DEP2");+ expect(plan.views.find((view) => view.name === "DEP2")?.rewrittenSource).toContain("CREATE VIEW DEP2");+ expect(fixture.writes).toEqual([]);+ });++ it("reports a completed root repair when the following rename fails", async () => {+ const fixture = dependencyFixture();+ const plan = await prepareOracleViewRename({ ...target, connectionId: "manual-root-partial" }, { OLD: "CREATE VIEW OLD AS SELECT 43 X FROM DUAL" });+ const execute = api.executeQuery.getMockImplementation()!;+ api.executeQuery.mockImplementation(async (...args) => {+ if (String(args[2]).startsWith("RENAME")) throw new Error("rename rejected");+ return execute(...args);+ });+ await expect(executeOracleViewRename(plan)).rejects.toMatchObject({ completed: ["OLD (definition replaced)"], uncertain: "NEW" });+ expect(fixture.sources.get("OLD")).toContain("43 X");+ expect(fixture.sources.has("NEW")).toBe(false);+ });++ it("accepts unchanged sibling dependencies returned in a different order", async () => {+ const fixture = dependencyFixture();+ fixture.sources.set("DEP2", "CREATE VIEW DEP2 AS SELECT * FROM OLD");+ const implementation = api.executeQuery.getMockImplementation()!;+ let reverse = false;+ api.executeQuery.mockImplementation(async (...args) => {+ const sql = String(args[2]);+ if (sql.includes("DEPENDENCIES") && sql.includes("REFERENCED_NAME='OLD'")) {+ const rows = [+ ["OWNER", "DEP", "VIEW", null],+ ["OWNER", "DEP2", "VIEW", null],+ ];+ return result(reverse ? rows.reverse() : rows);+ }+ if (sql.includes("DEPENDENCIES")) return result([]);+ return implementation(...args);+ });+ const plan = await prepareOracleViewRename({ ...target, connectionId: "sibling-order" });+ reverse = true;+ await expect(executeOracleViewRename(plan)).resolves.toBeUndefined();+ });++ it("allows a view and its legal new name to share the separate index namespace", async () => {+ dependencyFixture();+ const implementation = api.executeQuery.getMockImplementation()!;+ api.executeQuery.mockImplementation(async (...args) => {+ const response = await implementation(...args);+ if (String(args[2]).includes("USER_OBJECTS") && !String(args[2]).includes("OBJECT_TYPE IN")) return result([...response.rows, ["INDEX", "VALID"]]);+ return response;+ });+ const plan = await prepareOracleViewRename({ ...target, connectionId: "index-namespace" });+ await expect(executeOracleViewRename(plan)).resolves.toBeUndefined();+ });++ it("blocks a target name that already belongs to an operator", async () => {+ const implementation = api.executeQuery.getMockImplementation()!;+ api.executeQuery.mockImplementation(async (...args) => {+ const response = await implementation(...args);+ if (String(args[2]).includes("OBJECT_NAME='NEW'") && String(args[2]).includes("OBJECT_TYPE IN")) return result([["OPERATOR", "VALID"]]);+ return response;+ });+ const plan = await prepareOracleViewRename({ ...target, connectionId: "operator-namespace" });+ expect(plan.executable).toBe(false);+ expect(plan.issues.some((item) => item.code === "target_conflict")).toBe(true);+ expect(renamed).toBe(false);+ expect(statements.some((sql) => sql.startsWith("RENAME"))).toBe(false);+ });++ it("reads a large definition in bounded batches and reconstructs out-of-order chunks", async () => {+ const source = `CREATE VIEW OLD AS SELECT /*${"文".repeat(65_000)}*/ 42 FROM DUAL`;+ const codepoints = Array.from(source);+ const implementation = api.executeQuery.getMockImplementation()!;+ let chunkQueries = 0;+ api.executeQuery.mockImplementation(async (...args) => {+ const sql = String(args[2]);+ if (sql.includes("DBMS_LOB.GETLENGTH")) return result([[codepoints.length]]);+ if (sql.includes("DBMS_LOB.SUBSTR")) {+ chunkQueries++;+ const offsets = [...sql.matchAll(/,1000,(\d+)\)/g)].map((match) => Number(match[1]));+ return result(offsets.reverse().map((offset) => (sql.includes("CHUNK_OFFSET") ? [offset, codepoints.slice(offset - 1, offset - 1 + 1000).join("")] : [codepoints.slice(offset - 1, offset - 1 + 1000).join("")])));+ }+ return implementation(...args);+ });+ const plan = await prepareOracleViewRename(target);+ expect(plan.views[0].source).toBe(source);+ expect(chunkQueries).toBeLessThanOrEqual(3);+ });++ it.each(["missing", "duplicate", "unexpected"])("rejects %s chunks before dispatch", async (problem) => {+ const implementation = api.executeQuery.getMockImplementation()!;+ api.executeQuery.mockImplementation(async (...args) => {+ const sql = String(args[2]);+ if (sql.includes("DBMS_LOB.GETLENGTH")) return result([[1500]]);+ if (sql.includes("DBMS_LOB.SUBSTR")) {+ const rows: unknown[][] = [+ [1, "x".repeat(1000)],+ [1001, "x".repeat(500)],+ ];+ if (problem === "missing") rows.pop();+ if (problem === "duplicate") rows[1][0] = 1;+ if (problem === "unexpected") rows[1][0] = 1000;+ return result(rows);+ }+ return implementation(...args);+ });+ const plan = await prepareOracleViewRename(target);+ expect(plan.metadataComplete).toBe(false);+ expect(plan.issues.some((item) => item.code === "source_read_failed")).toBe(true);+ expect(renamed).toBe(false);+ });++ it("rebuilds two levels in order and verifies their final state", async () => {+ const fixture = dependencyFixture();+ const plan = await prepareOracleViewRename({ ...target, connectionId: "two-level-success" });+ await executeOracleViewRename(plan);+ expect(fixture.writes).toEqual(plan.statements);+ expect([...fixture.valid]).toEqual(["NEW", "DEP", "DEP2"]);+ expect(fixture.sources.get("DEP")).toContain("FROM NEW");+ });++ it("reports confirmed steps and stops after an uncertain dependent rebuild", async () => {+ const fixture = dependencyFixture({ failSecond: true });+ const plan = await prepareOracleViewRename({ ...target, connectionId: "two-level-failure" });+ await expect(executeOracleViewRename(plan)).rejects.toMatchObject({ completed: ["NEW", "DEP"], uncertain: "DEP2", plan });+ expect(fixture.writes).toHaveLength(3);+ expect(fixture.valid.has("DEP2")).toBe(false);+ });++ it("preserves a concurrent hint-only edit before overwriting a dependent", async () => {+ const fixture = dependencyFixture({ drift: true });+ const plan = await prepareOracleViewRename({ ...target, connectionId: "hint-drift" });+ await expect(executeOracleViewRename(plan)).rejects.toMatchObject({ completed: ["NEW"], uncertain: "DEP" });+ expect(fixture.writes).toHaveLength(1);+ expect(fixture.sources.get("DEP")).toContain("INDEX(X)");+ });+});diff --git a/apps/desktop/src/lib/backend/api.ts b/apps/desktop/src/lib/backend/api.tsindex 09b4ae8bcd..25ad3c7ca1 100644--- a/apps/desktop/src/lib/backend/api.ts+++ b/apps/desktop/src/lib/backend/api.ts@@ -325,9 +325,16 @@ export const buildDropSchemaSql = forward("buildDropSchemaSql");export const buildDuplicateTableStructureSql = forward("buildDuplicateTableStructureSql");export const buildCopyTableDataSql = forward("buildCopyTableDataSql");export const buildExecutableObjectSourceStatements = forward("buildExecutableObjectSourceStatements");+export const validateOracleExecutableObjectSource = forward("validateOracleExecutableObjectSource");+export const fingerprintOracleRoutineObjectSource = forward("fingerprintOracleRoutineObjectSource");export const buildExecutableObjectSourceSql = forward("buildExecutableObjectSourceSql");export const buildEditableObjectSource = forward("buildEditableObjectSource");export const buildRoutineRenameObjectSourceStatements = forward("buildRoutineRenameObjectSourceStatements");+export const rewriteOracleRoutineReferences = forward("rewriteOracleRoutineReferences");+export const rewriteOracleTableReferences = forward("rewriteOracleTableReferences");+export const parseOracleObjectName = forward("parseOracleObjectName");+export const buildOracleViewRenameSource = forward("buildOracleViewRenameSource");+export const reviewOracleViewRenameSource = forward("reviewOracleViewRenameSource");export const buildViewDdlSql = forward("buildViewDdlSql");export const buildTableStructureChangeSql = forward("buildTableStructureChangeSql");export const buildTableOwnerChangeSql = forward("buildTableOwnerChangeSql");diff --git a/apps/desktop/src/lib/backend/http.ts b/apps/desktop/src/lib/backend/http.tsindex 7602468ef4..40f08f0c7a 100644--- a/apps/desktop/src/lib/backend/http.ts+++ b/apps/desktop/src/lib/backend/http.ts@@ -238,7 +238,8 @@ import type { BuildCreatePartitionedTableSqlOptions, BuildTableOwnerChangeSqlOptimport type { BuildTableSelectSqlOptions } from "@/lib/table/tableSelectSql";import type { DatabaseSearchSql, DatabaseSearchSqlOptions, SearchResultWhereOptions } from "@/lib/database/databaseSearch";import type { DatabaseStructureSearchSql, DatabaseStructureSearchSqlOptions } from "@/lib/database/databaseStructureSearch";-import type { BuildEditableObjectSourceSqlInput, BuildRoutineRenameObjectSourceInput } from "@/lib/table/objectSourceEditor";+import type { BuildEditableObjectSourceSqlInput, BuildRoutineRenameObjectSourceInput, FingerprintOracleRoutineObjectSourceInput, RewriteOracleRoutineReferencesInput, ValidateOracleExecutableObjectSourceInput } from "@/lib/table/objectSourceEditor";+import type { OracleTableReferenceRewriteInput, OracleViewRenameSource, OracleViewRenameSourceInput, OracleViewRenameSourceReview } from "@/types/database";import type { BuildViewDdlInput } from "@/lib/table/viewDdl";import type { BuildRenameObjectSqlOptions } from "@/lib/table/objectRenameSql";import type { CreateDatabaseSqlOptions } from "@/lib/database/createDatabaseSql";@@ -1951,6 +1952,14 @@ export async function buildExecutableObjectSourceStatements(input: BuildEditable});}+export async function validateOracleExecutableObjectSource(input: ValidateOracleExecutableObjectSourceInput): Promise<void> {+ return post("/api/query/validate-oracle-executable-object-source", { input });+}++export async function fingerprintOracleRoutineObjectSource(input: FingerprintOracleRoutineObjectSourceInput): Promise<string> {+ return post("/api/query/fingerprint-oracle-routine-object-source", { input });+}+export async function buildExecutableObjectSourceSql(input: BuildEditableObjectSourceSqlInput): Promise<string> {return post("/api/query/build-executable-object-source-sql", { input });}@@ -1965,10 +1974,30 @@ export async function buildRoutineRenameObjectSourceStatements(input: BuildRouti});}+export async function rewriteOracleRoutineReferences(input: RewriteOracleRoutineReferencesInput): Promise<string> {+ return post("/api/query/rewrite-oracle-routine-references", { input });+}++export async function rewriteOracleTableReferences(input: OracleTableReferenceRewriteInput): Promise<string> {+ return post("/api/query/rewrite-oracle-table-references", { input });+}+export async function buildViewDdlSql(input: BuildViewDdlInput): Promise<string> {return post("/api/query/build-view-ddl-sql", { input });}+export async function parseOracleObjectName(input: string): Promise<string> {+ return post("/api/query/parse-oracle-object-name", { input });+}++export async function buildOracleViewRenameSource(input: OracleViewRenameSourceInput): Promise<OracleViewRenameSource> {+ return post("/api/query/build-oracle-view-rename-source", { input });+}++export async function reviewOracleViewRenameSource(input: OracleViewRenameSourceInput): Promise<OracleViewRenameSourceReview> {+ return post("/api/query/review-oracle-view-rename-source", { input });+}+export async function buildTableStructureChangeSql(options: BuildTableStructureChangeSqlOptions, starrocks?: StarRocksAlterOptions): Promise<TableStructureChangeSql> {return post("/api/query/build-table-structure-change-sql", { options, starrocks });}diff --git a/apps/desktop/src/lib/backend/tauri.ts b/apps/desktop/src/lib/backend/tauri.tsindex fe782022da..660937405a 100644--- a/apps/desktop/src/lib/backend/tauri.ts+++ b/apps/desktop/src/lib/backend/tauri.ts@@ -161,7 +161,8 @@ import type { BuildCreatePartitionedTableSqlOptions, BuildTableOwnerChangeSqlOptimport type { BuildTableSelectSqlOptions } from "@/lib/table/tableSelectSql";import type { DatabaseSearchSql, DatabaseSearchSqlOptions, SearchResultWhereOptions } from "@/lib/database/databaseSearch";import type { DatabaseStructureSearchSql, DatabaseStructureSearchSqlOptions } from "@/lib/database/databaseStructureSearch";-import type { BuildEditableObjectSourceSqlInput, BuildRoutineRenameObjectSourceInput } from "@/lib/table/objectSourceEditor";+import type { BuildEditableObjectSourceSqlInput, BuildRoutineRenameObjectSourceInput, FingerprintOracleRoutineObjectSourceInput, RewriteOracleRoutineReferencesInput, ValidateOracleExecutableObjectSourceInput } from "@/lib/table/objectSourceEditor";+import type { OracleTableReferenceRewriteInput, OracleViewRenameSource, OracleViewRenameSourceInput, OracleViewRenameSourceReview } from "@/types/database";import type { BuildViewDdlInput } from "@/lib/table/viewDdl";import type { BuildRenameObjectSqlOptions } from "@/lib/table/objectRenameSql";import type { CreateDatabaseSqlOptions } from "@/lib/database/createDatabaseSql";@@ -2383,6 +2384,14 @@ export async function buildExecutableObjectSourceStatements(input: BuildEditablereturn invoke("build_executable_object_source_statements", { input });}+export async function validateOracleExecutableObjectSource(input: ValidateOracleExecutableObjectSourceInput): Promise<void> {+ return invoke("validate_oracle_executable_object_source", { input });+}++export async function fingerprintOracleRoutineObjectSource(input: FingerprintOracleRoutineObjectSourceInput): Promise<string> {+ return invoke("fingerprint_oracle_routine_object_source", { input });+}+export async function buildExecutableObjectSourceSql(input: BuildEditableObjectSourceSqlInput): Promise<string> {return invoke("build_executable_object_source_sql", { input });}@@ -2395,10 +2404,30 @@ export async function buildRoutineRenameObjectSourceStatements(input: BuildRoutireturn invoke("build_routine_rename_object_source_statements", { input });}+export async function rewriteOracleRoutineReferences(input: RewriteOracleRoutineReferencesInput): Promise<string> {+ return invoke("rewrite_oracle_routine_references", { input });+}++export async function rewriteOracleTableReferences(input: OracleTableReferenceRewriteInput): Promise<string> {+ return invoke("rewrite_oracle_table_references", { input });+}+export async function buildViewDdlSql(input: BuildViewDdlInput): Promise<string> {return invoke("build_view_ddl_sql", { input });}+export async function parseOracleObjectName(input: string): Promise<string> {+ return invoke("parse_oracle_object_name", { input });+}++export async function buildOracleViewRenameSource(input: OracleViewRenameSourceInput): Promise<OracleViewRenameSource> {+ return invoke("build_oracle_view_rename_source", { input });+}++export async function reviewOracleViewRenameSource(input: OracleViewRenameSourceInput): Promise<OracleViewRenameSourceReview> {+ return invoke("review_oracle_view_rename_source", { input });+}+export async function buildTableStructureChangeSql(options: BuildTableStructureChangeSqlOptions, starrocks?: StarRocksAlterOptions): Promise<TableStructureChangeSql> {return invoke("build_table_structure_change_sql", { options, starrocks });}diff --git a/apps/desktop/src/lib/table/objectRenameSql.ts b/apps/desktop/src/lib/table/objectRenameSql.tsindex 9161e13025..df322e9ba5 100644--- a/apps/desktop/src/lib/table/objectRenameSql.ts+++ b/apps/desktop/src/lib/table/objectRenameSql.ts@@ -24,7 +24,7 @@ export function supportsObjectRename(databaseType: DatabaseType | undefined, obj}if (databaseType === "sqlite" || databaseType === "rqlite" || databaseType === "turso" || databaseType === "cloudflare-d1" || databaseType === "duckdb") return objectType === "TABLE";if (databaseType === "transwarp" || databaseType === "starrocks" || databaseType === "saphana") return objectType === "TABLE";- if (databaseType === "oceanbase-oracle") return objectType === "TABLE";+ if (databaseType === "oceanbase-oracle") return objectType === "TABLE" || objectType === "VIEW";if (databaseType === "mysql" || databaseType === "goldendb") return objectType === "TABLE" || objectType === "VIEW";if (postgresLikeRenameTypes.has(databaseType)) return objectType === "TABLE" || objectType === "VIEW" || objectType === "MATERIALIZED_VIEW";if (oracleLikeRenameTypes.has(databaseType)) return objectType === "TABLE" || objectType === "VIEW" || objectType === "MATERIALIZED_VIEW";diff --git a/apps/desktop/src/lib/table/objectSourceEditor.ts b/apps/desktop/src/lib/table/objectSourceEditor.tsindex 6f936124bc..64f29fdcf6 100644--- a/apps/desktop/src/lib/table/objectSourceEditor.ts+++ b/apps/desktop/src/lib/table/objectSourceEditor.ts@@ -9,16 +9,42 @@ export type BuildEditableObjectSourceSqlInput = {source: string;};+export type ValidateOracleExecutableObjectSourceInput = {+ databaseType: Extract<DatabaseType, "oracle" | "oceanbase-oracle">;+ objectType: Extract<ObjectSourceKind, "PROCEDURE" | "FUNCTION" | "PACKAGE" | "PACKAGE_BODY">;+ schema?: string | null;+ name: string;+ source: string;+};++export type FingerprintOracleRoutineObjectSourceInput = {+ databaseType: Extract<DatabaseType, "oracle" | "oceanbase-oracle">;+ objectType: Extract<ObjectSourceKind, "PROCEDURE" | "FUNCTION">;+ schema?: string | null;+ name: string;+ source: string;+};+export type BuildRoutineRenameObjectSourceInput = BuildEditableObjectSourceSqlInput & {newName: string;};+export type RewriteOracleRoutineReferencesInput = {+ databaseType: DatabaseType;+ callerType: Extract<ObjectSourceKind, "VIEW" | "PROCEDURE" | "FUNCTION">;+ targetType: Extract<ObjectSourceKind, "PROCEDURE" | "FUNCTION">;+ schema?: string | null;+ oldName: string;+ newName: string;+ source: string;+};+export type ObjectSourceSaveExecutionMode = "single" | "script";const postgresLikeRoutineRenameTypes = new Set<DatabaseType>(["postgres", "redshift", "gaussdb", "kwdb", "kingbase", "highgo", "uxdb", "vastbase"]);const postgresLikeViewTypes = new Set<DatabaseType>(["postgres", "redshift", "gaussdb", "kwdb", "opengauss", "questdb", "kingbase", "highgo", "uxdb", "vastbase"]);const mysqlLikeRoutineRenameTypes = new Set<DatabaseType>(["mysql", "goldendb"]);-const oracleLikeRoutineRenameTypes = new Set<DatabaseType>(["oracle", "dameng"]);+const oracleLikeRoutineRenameTypes = new Set<DatabaseType>(["oracle", "dameng", "oceanbase-oracle"]);// SQLSTATE 42P16 covers unrelated invalid table definitions, so only match the// confirmed PostgreSQL view-column errors and their localized equivalents.@@ -52,6 +78,14 @@ export function buildRoutineRenameObjectSourceStatements(input: BuildRoutineRenareturn api.buildRoutineRenameObjectSourceStatements(input);}+export function fingerprintOracleRoutineObjectSource(input: FingerprintOracleRoutineObjectSourceInput): Promise<string> {+ return api.fingerprintOracleRoutineObjectSource(input);+}++export function rewriteOracleRoutineReferences(input: RewriteOracleRoutineReferencesInput): Promise<string> {+ return api.rewriteOracleRoutineReferences(input);+}+export function buildExecutableObjectSourceStatements(input: BuildEditableObjectSourceSqlInput): Promise<string[]> {return api.buildExecutableObjectSourceStatements(input);}@@ -73,7 +107,7 @@ export function objectSourceSaveExecutionMode(_databaseType: DatabaseType): Objereturn "single";}-export async function executeObjectSourceSave(connectionId: string, database: string, databaseType: DatabaseType, statements: string[], schema?: string): Promise<void> {+export async function executeObjectSourceSave(connectionId: string, database: string, databaseType: DatabaseType, statements: string[], schema?: string, timeoutSecs?: number): Promise<void> {const nonEmptyStatements = statements.filter((sql) => sql.trim().length > 0);if (nonEmptyStatements.length === 0) return;@@ -86,7 +120,8 @@ export async function executeObjectSourceSave(connectionId: string, database: stfor (const sql of nonEmptyStatements) {if (objectSourceSaveExecutionMode(databaseType) === "single") {- await api.executeQuery(connectionId, database, sql, schema);+ if (timeoutSecs === undefined) await api.executeQuery(connectionId, database, sql, schema);+ else await api.executeQuery(connectionId, database, sql, schema, undefined, { timeoutSecs });} else {await api.executeScript(connectionId, database, sql, schema);}diff --git a/apps/desktop/src/lib/table/objectSourceIdentity.ts b/apps/desktop/src/lib/table/objectSourceIdentity.tsnew file mode 100644index 0000000000..b09183394a--- /dev/null+++ b/apps/desktop/src/lib/table/objectSourceIdentity.ts@@ -0,0 +1,95 @@+import i18n from "@/i18n";++export interface SourceIdentity {+ connectionId: string;+ database: string;+ schema?: string;+ objectType: string;+ name: string;+}++export interface SourceIdentitySnapshot extends SourceIdentity {+ revision: number;+}++interface SourceState {+ revision: number;+ saving: boolean;+ migrating: boolean;+ frozen: boolean;+}++const states = new Map<string, SourceState>();++function stateFor(identity: SourceIdentity): SourceState {+ const key = JSON.stringify([identity.connectionId, identity.database, identity.schema || identity.database, identity.objectType, identity.name]);+ let state = states.get(key);+ if (!state) {+ state = { revision: 0, saving: false, migrating: false, frozen: false };+ states.set(key, state);+ }+ return state;+}++export function captureSourceIdentity(identity: SourceIdentity): SourceIdentitySnapshot {+ return { ...identity, revision: stateFor(identity).revision };+}++export function assertSourceIdentity(snapshot: SourceIdentitySnapshot): void {+ const state = stateFor(snapshot);+ if (snapshot.revision !== state.revision || state.frozen || state.migrating) throw new Error(i18n.global.t("objects.sourceIdentityChanged"));+}++/** Call only after a user-requested reload succeeds, with the version captured before loading. */+export function renewSourceIdentity(snapshot: SourceIdentitySnapshot): SourceIdentitySnapshot {+ const state = stateFor(snapshot);+ if (snapshot.revision !== state.revision || state.migrating || state.saving) throw new Error(i18n.global.t("objects.sourceIdentityChanged"));+ if (state.frozen) {+ state.revision++;+ state.frozen = false;+ }+ return captureSourceIdentity(snapshot);+}++/** Synchronous with dispatch: no await may occur between this call and starting the save. */+export function beginSourceSave(snapshot: SourceIdentitySnapshot): () => void {+ assertSourceIdentity(snapshot);+ const state = stateFor(snapshot);+ if (state.saving) throw new Error(i18n.global.t("objects.sourceIdentitySaving"));+ state.saving = true;+ let released = false;+ return () => {+ if (released) return;+ released = true;+ state.saving = false;+ };+}++/** All affected objects are checked before any is frozen. */+export function freezeSourceIdentities(identities: SourceIdentity[]) {+ const affected = [...new Set(identities.map(stateFor))];+ if (affected.some((state) => state.saving || state.migrating)) throw new Error(i18n.global.t("objects.sourceIdentityBusy"));+ for (const state of affected) state.migrating = true;+ let dispatched = false;+ let finished = false;+ return {+ markDispatched() {+ if (finished || dispatched) return;+ dispatched = true;+ for (const state of affected) {+ state.revision++;+ state.frozen = true;+ }+ },+ cancel() {+ if (dispatched || finished) return;+ finished = true;+ for (const state of affected) state.migrating = false;+ },+ finish() {+ if (finished) return;+ finished = true;+ for (const state of affected) state.migrating = false;+ },+ };+}diff --git a/apps/desktop/src/lib/table/oraclePackageSaveAs.ts b/apps/desktop/src/lib/table/oraclePackageSaveAs.tsnew file mode 100644index 0000000000..2dab548a85--- /dev/null+++ b/apps/desktop/src/lib/table/oraclePackageSaveAs.ts@@ -0,0 +1,321 @@+import * as api from "@/lib/backend/api";+import { BackendErrorException } from "@/lib/backend/errorUtils";+import { freezeSourceIdentities } from "@/lib/table/objectSourceIdentity";+import { invalidateObjectDdlCache } from "@/lib/metadata/objectDdlCache";+import { invalidateObjectBrowserRowsCache } from "@/lib/table/objectBrowserRowsCache";+import type { DatabaseType, QueryResult } from "@/types/database";+import { oraclePackageCatalogSource, rewriteOraclePackageSource } from "@/lib/table/oraclePackageSource";++export interface OraclePackageSaveAsTarget {+ connectionId: string;+ database: string;+ databaseType: Extract<DatabaseType, "oracle" | "oceanbase-oracle">;+ schema: string;+ oldName: string;+ newName: string;+}++interface PackageSnapshot {+ name: string;+ specId: string;+ specStatus: string;+ specSource: string;+ bodyId: string | null;+ bodyStatus: string | null;+ bodySource: string | null;+ signature: string;+ grants: string;+}++export interface OraclePackageSaveAsPlan {+ target: OraclePackageSaveAsTarget;+ canonicalNewName: string;+ snapshot: PackageSnapshot | null;+ specDraft: string;+ bodyDraft: string | null;+ specSource: string;+ bodySource: string | null;+ statements: string[];+ issues: Array<{ code: string; message: string; objectName?: string; repairable: boolean }>;+ metadataComplete: boolean;+ executable: boolean;+}++export class OraclePackageSaveAsFailure extends Error {+ constructor(+ public readonly plan: OraclePackageSaveAsPlan,+ public readonly completed: string[],+ public readonly uncertain: string,+ cause: unknown,+ public readonly dispatched: boolean,+ ) {+ const message = cause instanceof Error ? cause.message : String(cause);+ super(`Package Save As stopped. Created and verified: ${completed.join(", ") || "none"}. Check ${uncertain} before retrying. ${message}`);+ }+}++const metadataLimit = 5000;+const sourceLimit = 1_000_000;+const namespaceTypes = ["TABLE", "VIEW", "SEQUENCE", "SYNONYM", "PROCEDURE", "FUNCTION", "PACKAGE", "MATERIALIZED VIEW", "TYPE", "OPERATOR"];+const literal = (value: string) => `'${value.replaceAll("'", "''")}'`;+const identifier = (value: string) => `"${value.replaceAll('"', '""')}"`;+const qualified = (schema: string, name: string) => `${identifier(schema)}.${identifier(name)}`;++async function query(target: OraclePackageSaveAsTarget, sql: string): Promise<QueryResult> {+ const result = await api.executeQuery(target.connectionId, target.database, sql, target.schema, undefined, { maxRows: metadataLimit + 1 });+ if (result.execution_error) throw new BackendErrorException(result.error || "Package metadata query failed.");+ if (result.truncated || result.has_more || result.rows.length > metadataLimit || result.large_value_cells?.length) throw new Error("Package metadata is incomplete; refresh the Save As preview.");+ return result;+}++async function checkOwner(target: OraclePackageSaveAsTarget) {+ const result = await query(target, "SELECT USER, SYS_CONTEXT('USERENV','CURRENT_SCHEMA') FROM DUAL");+ if (result.rows.length !== 1 || result.rows[0][0] !== target.schema || result.rows[0][1] !== target.schema) throw new Error("Package Save As requires the package owner and matching current schema.");+}++async function objectStates(target: OraclePackageSaveAsTarget, name: string, types: string[] = namespaceTypes) {+ return (await query(target, `SELECT OBJECT_NAME, OBJECT_TYPE, OBJECT_ID, STATUS FROM USER_OBJECTS WHERE OBJECT_NAME=${literal(name)} AND OBJECT_TYPE IN (${types.map(literal).join(",")}) ORDER BY OBJECT_TYPE`)).rows;+}++async function readSource(target: OraclePackageSaveAsTarget, name: string, type: "PACKAGE" | "PACKAGE BODY"): Promise<string> {+ const result = await query(target, `SELECT LINE, TEXT FROM ALL_SOURCE WHERE OWNER=${literal(target.schema)} AND NAME=${literal(name)} AND TYPE=${literal(type)} ORDER BY LINE`);+ if (result.rows.length > metadataLimit) throw new Error(`Complete ${type} source is unavailable for ${name}.`);+ if (!result.rows.length) return "";+ let expectedLine = 1;+ const lines: string[] = [];+ for (const [line, text] of result.rows) {+ if (Number(line) !== expectedLine++ || typeof text !== "string") throw new Error(`Complete ${type} source is unavailable for ${name}.`);+ lines.push(text.replace(/\r?\n$/, ""));+ }+ const source = lines.join("\n");+ if (!source.trim() || source.length > sourceLimit) throw new Error(`Complete ${type} source is unavailable for ${name}.`);+ return source;+}++function normalizedRows(rows: unknown[][], selfPackage: { owner: string; name: string }, packageTypeColumn?: number) {+ return rows.map((row) =>+ row.map((value, index) => {+ if (packageTypeColumn === index && row[10] === selfPackage.owner && value === selfPackage.name) return "<SELF_PACKAGE>";+ return value === null ? null : String(value);+ }),+ );+}++async function readSignature(target: OraclePackageSaveAsTarget, name: string) {+ const members = (await query(target, `SELECT PROCEDURE_NAME, OVERLOAD FROM ALL_PROCEDURES WHERE OWNER=${literal(target.schema)} AND OBJECT_NAME=${literal(name)} AND OBJECT_TYPE='PACKAGE' ORDER BY PROCEDURE_NAME, OVERLOAD`)).rows;+ const argumentsRows = (+ await query(+ target,+ `SELECT OBJECT_NAME, OVERLOAD, SEQUENCE, POSITION, ARGUMENT_NAME, IN_OUT, DATA_TYPE, DATA_LENGTH, DATA_PRECISION, DATA_SCALE, TYPE_OWNER, TYPE_NAME, TYPE_SUBNAME, DEFAULTED FROM ALL_ARGUMENTS WHERE OWNER=${literal(target.schema)} AND PACKAGE_NAME=${literal(name)} ORDER BY OBJECT_NAME, OVERLOAD, SEQUENCE`,+ )+ ).rows;+ return JSON.stringify([normalizedRows(members, { owner: target.schema, name }), normalizedRows(argumentsRows, { owner: target.schema, name }, 11)]);+}++async function readGrants(target: OraclePackageSaveAsTarget, name: string) {+ const rows = (await query(target, `SELECT GRANTOR, GRANTEE, PRIVILEGE, GRANTABLE FROM ALL_TAB_PRIVS WHERE TABLE_SCHEMA=${literal(target.schema)} AND TABLE_NAME=${literal(name)} ORDER BY GRANTOR, GRANTEE, PRIVILEGE`)).rows;+ return JSON.stringify(rows.map((row) => row.map((value) => (value === null ? null : String(value)))));+}++async function readErrors(target: OraclePackageSaveAsTarget, name: string, type: "PACKAGE" | "PACKAGE BODY") {+ const rows = (await query(target, `SELECT ATTRIBUTE, LINE, POSITION, TEXT FROM USER_ERRORS WHERE NAME=${literal(name)} AND TYPE=${literal(type)} ORDER BY SEQUENCE`)).rows;+ return JSON.stringify(rows.map((row) => row.map((value) => (value === null ? null : String(value)))));+}++async function readSnapshot(target: OraclePackageSaveAsTarget, name: string): Promise<PackageSnapshot> {+ const states = await objectStates(target, name, ["PACKAGE", "PACKAGE BODY"]);+ const spec = states.filter((row) => row[0] === name && row[1] === "PACKAGE");+ const body = states.filter((row) => row[0] === name && row[1] === "PACKAGE BODY");+ if (spec.length !== 1 || (typeof spec[0]![2] !== "number" && typeof spec[0]![2] !== "string")) throw new Error(`Package ${name} specification is missing or has an ambiguous identity.`);+ if (body.length > 1 || (body.length === 1 && typeof body[0]![2] !== "number" && typeof body[0]![2] !== "string")) throw new Error(`Package ${name} body has an ambiguous identity.`);+ const specSource = await readSource(target, name, "PACKAGE");+ const bodySourceRead = await readSource(target, name, "PACKAGE BODY");+ if (!specSource || Boolean(body.length) !== Boolean(bodySourceRead)) throw new Error(`Package ${name} body presence differs between the object dictionary and source catalog.`);+ return {+ name,+ specId: String(spec[0]![2]),+ specStatus: String(spec[0]![3]),+ specSource,+ bodyId: body.length ? String(body[0]![2]) : null,+ bodyStatus: body.length ? String(body[0]![3]) : null,+ bodySource: body.length ? bodySourceRead : null,+ signature: await readSignature(target, name),+ grants: await readGrants(target, name),+ };+}++function grantStatements(target: OraclePackageSaveAsTarget, grants: string) {+ const rows = JSON.parse(grants) as Array<Array<string | null>>;+ return rows.map(([grantor, grantee, privilege, grantable]) => {+ if (grantor !== target.schema || privilege !== "EXECUTE" || !grantee) throw new Error(`Cannot safely copy package grant ${String(privilege)} from ${String(grantor)}.`);+ return `GRANT EXECUTE ON ${qualified(target.schema, target.newName)} TO ${grantee === "PUBLIC" ? "PUBLIC" : identifier(grantee)}${grantable === "YES" ? " WITH GRANT OPTION" : ""};`;+ });+}++function planIdentity(plan: OraclePackageSaveAsPlan) {+ return JSON.stringify([plan.target, plan.canonicalNewName, plan.snapshot, plan.specDraft, plan.bodyDraft, plan.specSource, plan.bodySource, plan.statements, plan.issues, plan.metadataComplete]);+}++function packageDrafts(plan: OraclePackageSaveAsPlan) {+ return { spec: plan.specDraft, ...(plan.bodyDraft === null ? {} : { body: plan.bodyDraft }) };+}++export async function prepareOraclePackageSaveAs(target: OraclePackageSaveAsTarget, drafts: { spec?: string; body?: string } = {}): Promise<OraclePackageSaveAsPlan> {+ target = { ...target };+ const plan: OraclePackageSaveAsPlan = {+ target,+ canonicalNewName: target.newName,+ snapshot: null,+ specDraft: "",+ bodyDraft: null,+ specSource: "",+ bodySource: null,+ statements: [],+ issues: [],+ metadataComplete: true,+ executable: false,+ };+ try {+ plan.canonicalNewName = await api.parseOracleObjectName(target.newName);+ if (plan.canonicalNewName === target.oldName) plan.issues.push({ code: "invalid_name", message: "The new package name matches the existing name.", repairable: false });+ await checkOwner(target);+ const conflicts = await objectStates(target, plan.canonicalNewName);+ if (conflicts.length) plan.issues.push({ code: "target_conflict", message: `An object named ${plan.canonicalNewName} already exists.`, repairable: false });+ } catch (error) {+ plan.metadataComplete = false;+ plan.issues.push({ code: "metadata_incomplete", message: error instanceof Error ? error.message : String(error), repairable: false });+ }++ try {+ plan.snapshot = await readSnapshot(target, target.oldName);+ plan.specDraft = drafts.spec ?? plan.snapshot.specSource;+ plan.bodyDraft = plan.snapshot.bodySource === null ? null : (drafts.body ?? plan.snapshot.bodySource);+ if (plan.snapshot.specStatus !== "VALID" || (plan.snapshot.bodyStatus && plan.snapshot.bodyStatus !== "VALID")) plan.issues.push({ code: "invalid_source", message: `The existing package is ${plan.snapshot.specStatus}/${plan.snapshot.bodyStatus || "no body"}.`, repairable: false });+ } catch (error) {+ plan.metadataComplete = false;+ plan.issues.push({ code: "source_read_failed", message: error instanceof Error ? error.message : String(error), repairable: false });+ }++ if (plan.snapshot) {+ if (plan.snapshot.bodySource === null && drafts.body !== undefined) {+ plan.issues.push({ code: "invalid_draft", message: "A package without a body cannot be given a body draft.", objectName: "PACKAGE BODY", repairable: false });+ }+ try {+ plan.specSource = rewriteOraclePackageSource(plan.specDraft, { owner: target.schema, oldName: target.oldName, newName: plan.canonicalNewName, body: false });+ const statements = await api.buildExecutableObjectSourceStatements({+ databaseType: target.databaseType,+ objectType: "PACKAGE",+ schema: target.schema,+ name: plan.canonicalNewName,+ source: plan.specSource,+ });+ if (statements.length !== 1) throw new Error("Package source must produce exactly one object definition.");+ } catch (error) {+ plan.issues.push({ code: "source_rewrite_failed", message: error instanceof Error ? error.message : String(error), objectName: "PACKAGE", repairable: true });+ }+ if (plan.bodyDraft !== null) {+ try {+ plan.bodySource = rewriteOraclePackageSource(plan.bodyDraft, { owner: target.schema, oldName: target.oldName, newName: plan.canonicalNewName, body: true });+ const statements = await api.buildExecutableObjectSourceStatements({+ databaseType: target.databaseType,+ objectType: "PACKAGE_BODY",+ schema: target.schema,+ name: plan.canonicalNewName,+ source: plan.bodySource,+ });+ if (statements.length !== 1) throw new Error("Package body source must produce exactly one object definition.");+ } catch (error) {+ plan.issues.push({ code: "source_rewrite_failed", message: error instanceof Error ? error.message : String(error), objectName: "PACKAGE BODY", repairable: true });+ }+ }+ if (plan.metadataComplete && plan.issues.length === 0 && plan.specSource && (plan.bodyDraft === null || plan.bodySource)) {+ try {+ const nextTarget = { ...target, newName: plan.canonicalNewName };+ plan.statements = [plan.specSource, ...(plan.bodySource ? [plan.bodySource] : []), ...grantStatements(nextTarget, plan.snapshot.grants)];+ plan.executable = true;+ } catch (error) {+ plan.issues.push({ code: "grant_build_failed", message: error instanceof Error ? error.message : String(error), objectName: "PACKAGE", repairable: false });+ }+ }+ }+ return plan;+}++async function verifyCreatedPackage(target: OraclePackageSaveAsTarget, expected: { specSource: string; bodySource: string | null; signature: string; grants: string }, requireBody: boolean): Promise<PackageSnapshot> {+ const canonicalName = await api.parseOracleObjectName(target.newName);+ const snapshot = await readSnapshot(target, canonicalName);+ if (oraclePackageCatalogSource(snapshot.specSource) !== expected.specSource || snapshot.signature !== expected.signature || snapshot.grants !== expected.grants) throw new Error(`Created package ${target.newName} does not match the validated specification, members, or grants.`);+ if (snapshot.specStatus !== "VALID" || (snapshot.bodyStatus && snapshot.bodyStatus !== "VALID")) throw new Error(`Created package ${target.newName} is invalid.`);+ if ((requireBody && snapshot.bodySource !== null && expected.bodySource !== null && oraclePackageCatalogSource(snapshot.bodySource) !== expected.bodySource) || (!requireBody && snapshot.bodySource !== null)) throw new Error(`Created package ${target.newName} body does not match the preview.`);+ if (JSON.parse(await readErrors(target, canonicalName, "PACKAGE")).length || (snapshot.bodySource && JSON.parse(await readErrors(target, canonicalName, "PACKAGE BODY")).length)) throw new Error(`Created package ${target.newName} has compile errors.`);+ return snapshot;+}++export async function executeOraclePackageSaveAs(plan: OraclePackageSaveAsPlan, isCurrent: () => boolean = () => true): Promise<void> {+ if (!isCurrent()) throw new Error("The package Save As target changed. Refresh the preview.");+ if (!plan.executable || !plan.snapshot) throw new Error("Resolve the package Save As preview issues before execution.");+ const current = await prepareOraclePackageSaveAs(plan.target, packageDrafts(plan));+ if (!current.executable || planIdentity(current) !== planIdentity(plan)) throw new Error("The package or its members changed. Refresh the Save As preview.");++ const lock = freezeSourceIdentities(["PACKAGE", "PACKAGE_BODY"].map((objectType) => ({ connectionId: plan.target.connectionId, database: plan.target.database, schema: plan.target.schema, objectType, name: plan.target.oldName })));+ const completed: string[] = [];+ let dispatched = false;+ let active = `PACKAGE ${plan.canonicalNewName}`;+ try {+ if (!isCurrent()) throw new Error("The Save As dialog changed before execution.");+ const before = await readSnapshot(plan.target, plan.target.oldName);+ if (!isCurrent()) throw new Error("The Save As dialog changed before package creation.");+ if (JSON.stringify(before) !== JSON.stringify(plan.snapshot)) throw new Error("The original package changed before execution.");+ if ((await objectStates(plan.target, plan.canonicalNewName)).length) throw new Error(`Package target ${plan.canonicalNewName} already exists.`);++ if (!isCurrent()) throw new Error("The Save As dialog changed before package creation.");+ active = `PACKAGE ${plan.canonicalNewName}`;+ dispatched = true;+ await query(plan.target, plan.specSource);+ const specState = (await objectStates(plan.target, plan.canonicalNewName, ["PACKAGE"])).filter((row) => row[0] === plan.canonicalNewName && row[1] === "PACKAGE");+ const specSource = await readSource(plan.target, plan.canonicalNewName, "PACKAGE");+ if (specState.length !== 1 || oraclePackageCatalogSource(specSource) !== oraclePackageCatalogSource(plan.specSource)) throw new Error(`Created package ${plan.canonicalNewName} specification did not match the preview.`);+ const createdSpecId = String(specState[0]![2]);+ let createdBodyId: string | null = null;+ completed.push(`PACKAGE ${plan.canonicalNewName}`);++ if (plan.bodySource) {+ if (!isCurrent()) throw new Error("The Save As dialog changed before package body creation.");+ const currentSpec = (await objectStates(plan.target, plan.canonicalNewName, ["PACKAGE"])).filter((row) => row[0] === plan.canonicalNewName && row[1] === "PACKAGE");+ const currentSource = currentSpec.length === 1 ? await readSource(plan.target, plan.canonicalNewName, "PACKAGE") : "";+ if (!isCurrent()) throw new Error("The Save As dialog changed before package body creation.");+ if (currentSpec.length !== 1 || String(currentSpec[0]![2]) !== createdSpecId || oraclePackageCatalogSource(currentSource) !== oraclePackageCatalogSource(plan.specSource)) throw new Error("The new package specification identity or definition changed before body creation.");+ active = `PACKAGE BODY ${plan.canonicalNewName}`;+ await query(plan.target, plan.bodySource);+ const bodyState = (await objectStates(plan.target, plan.canonicalNewName, ["PACKAGE BODY"])).filter((row) => row[0] === plan.canonicalNewName && row[1] === "PACKAGE BODY");+ const bodySource = await readSource(plan.target, plan.canonicalNewName, "PACKAGE BODY");+ if (bodyState.length !== 1 || oraclePackageCatalogSource(bodySource) !== oraclePackageCatalogSource(plan.bodySource)) throw new Error(`Created package body ${plan.canonicalNewName} did not match the preview.`);+ createdBodyId = String(bodyState[0]![2]);+ completed.push(`PACKAGE BODY ${plan.canonicalNewName}`);+ }++ for (const grantSql of grantStatements({ ...plan.target, newName: plan.canonicalNewName }, plan.snapshot.grants)) {+ if (!isCurrent()) throw new Error("The Save As dialog changed before grant creation.");+ active = `grants for ${plan.canonicalNewName}`;+ await query(plan.target, grantSql);+ completed.push(active);+ }++ if (!isCurrent()) throw new Error("The Save As dialog changed before final readback.");+ active = `PACKAGE ${plan.canonicalNewName} final readback`;+ const expectedSignature = JSON.stringify(JSON.parse(plan.snapshot.signature));+ const verified = await verifyCreatedPackage(plan.target, { specSource: oraclePackageCatalogSource(plan.specSource), bodySource: plan.bodySource === null ? null : oraclePackageCatalogSource(plan.bodySource), signature: expectedSignature, grants: plan.snapshot.grants }, plan.bodySource !== null);+ if (verified.specId !== createdSpecId || verified.bodyId !== createdBodyId) throw new Error("The new package identity changed before final verification.");+ const oldFinal = await readSnapshot(plan.target, plan.target.oldName);+ if (JSON.stringify(oldFinal) !== JSON.stringify(plan.snapshot)) throw new Error("The original package changed while the copy was being created.");+ } catch (error) {+ throw new OraclePackageSaveAsFailure(plan, completed, active, error, dispatched);+ } finally {+ // Save As is a temporary read/write exclusion, never a migration freeze.+ lock.cancel();+ if (dispatched) {+ const scope = { connectionId: plan.target.connectionId, database: plan.target.database, schema: plan.target.schema };+ await Promise.allSettled([Promise.resolve().then(() => invalidateObjectBrowserRowsCache(scope)), ...[plan.target.oldName, plan.canonicalNewName].map((name) => Promise.resolve().then(() => invalidateObjectDdlCache({ ...scope, tableName: name })))]);+ }+ }+}diff --git a/apps/desktop/src/lib/table/oraclePackageSource.ts b/apps/desktop/src/lib/table/oraclePackageSource.tsnew file mode 100644index 0000000000..afe8471ba9--- /dev/null+++ b/apps/desktop/src/lib/table/oraclePackageSource.ts@@ -0,0 +1,237 @@+type Token = {+ kind: "identifier" | "string" | "punctuation";+ text: string;+ value: string;+ start: number;+ end: number;+ quoted?: boolean;+};++function tokens(source: string): Token[] {+ const result: Token[] = [];+ for (let index = 0; index < source.length;) {+ const start = index;+ const char = source[index]!;+ if (/\s/.test(char)) {+ index++;+ continue;+ }+ if (source.startsWith("--", index)) {+ const newline = source.indexOf("\n", index + 2);+ index = newline < 0 ? source.length : newline + 1;+ continue;+ }+ if (source.startsWith("/*", index)) {+ const close = source.indexOf("*/", index + 2);+ if (close < 0) throw new Error("Package source contains an unterminated comment.");+ index = close + 2;+ continue;+ }+ if ((char === "q" || char === "Q") && source[index + 1] === "'") {+ const opener = source[index + 2];+ if (!opener) throw new Error("Package source contains an invalid quoted string.");+ const closer = ({ "[": "]", "{": "}", "(": ")", "<": ">" } as Record<string, string>)[opener] || opener;+ const close = source.indexOf(`${closer}'`, index + 3);+ if (close < 0) throw new Error("Package source contains an unterminated quoted string.");+ index = close + 2;+ result.push({ kind: "string", text: source.slice(start, index), value: source.slice(start + 3, close), start, end: index });+ continue;+ }+ if (char === "'") {+ index++;+ let value = "";+ let closed = false;+ while (index < source.length) {+ if (source[index] === "'" && source[index + 1] === "'") {+ value += "'";+ index += 2;+ } else if (source[index] === "'") {+ index++;+ closed = true;+ break;+ } else value += source[index++];+ }+ if (!closed) throw new Error("Package source contains an unterminated string.");+ result.push({ kind: "string", text: source.slice(start, index), value, start, end: index });+ continue;+ }+ if (char === '"') {+ index++;+ let value = "";+ let closed = false;+ while (index < source.length) {+ if (source[index] === '"' && source[index + 1] === '"') {+ value += '"';+ index += 2;+ } else if (source[index] === '"') {+ index++;+ closed = true;+ break;+ } else value += source[index++];+ }+ if (!closed) throw new Error("Package source contains an unterminated quoted identifier.");+ result.push({ kind: "identifier", text: source.slice(start, index), value, quoted: true, start, end: index });+ continue;+ }+ if (/[A-Za-z_$#]/.test(char)) {+ index++;+ while (index < source.length && /[A-Za-z0-9_$#]/.test(source[index]!)) index++;+ const text = source.slice(start, index);+ result.push({ kind: "identifier", text, value: text.toUpperCase(), start, end: index });+ continue;+ }+ index++;+ result.push({ kind: "punctuation", text: char, value: char, start, end: index });+ }+ return result;+}++function matches(token: Token | undefined, name: string): boolean {+ if (!token || token.kind !== "identifier") return false;+ return token.value === name;+}++function quotedIdentifier(name: string): string {+ return `"${name.replaceAll('"', '""')}"`;+}++/**+ * Add CREATE to complete ALL_SOURCE text and retarget the package declaration,+ * its outer END name, and statically recognizable references to its own members.+ * Strings and comments are preserved byte-for-byte. Ambiguous shadowing is rejected.+ */+export function rewriteOraclePackageSource(source: string, options: { owner: string; oldName: string; newName: string; body: boolean }): string {+ const sourceTokens = tokens(source);+ const sourceWithTerminator = sourceTokens[sourceTokens.length - 1]?.text === ";" ? source : `${source};`;+ const list = tokens(sourceWithTerminator);+ const packageIndex = list.findIndex((token) => matches(token, "PACKAGE"));+ if (packageIndex < 0) throw new Error("Package source has no PACKAGE declaration.");+ if (packageIndex !== 0) throw new Error("Package source must contain exactly one package declaration and no preceding SQL.");+ const body = matches(list[packageIndex + 1], "BODY");+ if (body !== options.body) throw new Error("Package source type does not match the selected specification or body.");+ const sameName = (token: Token | undefined) => token?.kind === "identifier" && token.value === options.oldName;+ let nameIndex = packageIndex + (body ? 2 : 1);+ if (list[nameIndex + 1]?.text === ".") {+ if (!matches(list[nameIndex], options.owner)) throw new Error("Package source owner does not match the selected owner.");+ nameIndex += 2;+ }+ if (!sameName(list[nameIndex])) throw new Error("Package declaration does not match the selected object.");++ const declarations = new Set([packageIndex, nameIndex]);+ const edits: Array<{ start: number; end: number; value: string }> = [+ { start: list[packageIndex]!.start, end: list[packageIndex]!.start, value: "CREATE " },+ { start: list[nameIndex]!.start, end: list[nameIndex]!.end, value: quotedIdentifier(options.newName) },+ ];++ // Only the final END can name the package; nested routine and block ENDs are untouched.+ const last = list[list.length - 1];+ if (last?.text !== ";") throw new Error("Package source does not end with a complete semicolon.");+ const outerEnd = list[list.length - 2];+ const preceding = list[list.length - 3];+ if (outerEnd && preceding && matches(preceding, "END") && sameName(outerEnd)) {+ declarations.add(list.length - 2);+ edits.push({ start: outerEnd.start, end: outerEnd.end, value: quotedIdentifier(options.newName) });+ } else if (outerEnd && matches(outerEnd, "END")) {+ // An unnamed outer END is valid and needs no change.+ } else {+ throw new Error("Package source has no verifiable outer END.");+ }++ if (options.body) {+ const declarationStarts = list.flatMap((token, index) => (index > packageIndex && (matches(token, "AS") || matches(token, "IS")) ? [index] : []));+ for (const declarationStart of declarationStarts) {+ const bodyStart = list.findIndex((token, index) => index > declarationStart && matches(token, "BEGIN"));+ if (bodyStart > declarationStart && list.slice(declarationStart + 1, bodyStart).some((token) => token.kind === "identifier" && token.value === options.newName)) {+ throw new Error(`Package body declares ${options.newName}, which could capture a reference after Save As.`);+ }+ let close = -1;+ for (let index = declarationStart - 1; index >= 0; index--) {+ if (list[index]!.text === ")") {+ close = index;+ break;+ }+ }+ if (close >= 0) {+ let nesting = 0;+ let open = -1;+ for (let index = close; index >= 0; index--) {+ if (list[index]!.text === ")") nesting++;+ else if (list[index]!.text === "(" && --nesting === 0) {+ open = index;+ break;+ }+ }+ if (open >= 0 && list.slice(open + 1, close).some((token) => token.kind === "identifier" && token.value === options.newName)) {+ throw new Error(`Package body parameter ${options.newName} could capture a reference after Save As.`);+ }+ }+ }+ for (let declarationStart = 0; declarationStart < list.length; declarationStart++) {+ if (!matches(list[declarationStart], "DECLARE")) continue;+ const bodyStart = list.findIndex((token, index) => index > declarationStart && matches(token, "BEGIN"));+ if (bodyStart > declarationStart && list.slice(declarationStart + 1, bodyStart).some((token) => token.kind === "identifier" && token.value === options.newName)) {+ throw new Error(`Package body declares ${options.newName}, which could capture a reference after Save As.`);+ }+ }+ }++ for (let index = 0; index < list.length; index++) {+ const token = list[index]!;+ const referencedPackage = sameName(token);+ if (declarations.has(index) || !referencedPackage) continue;+ const next = list[index + 1];+ if (next?.text !== ".") {+ // A bare occurrence may be a local variable/member. It is only safe when it+ // is one of the declaration or outer-END names handled above.+ throw new Error(`Package source contains an ambiguous unqualified reference to ${options.oldName}.`);+ }+ if (list[index - 1]?.text === ".") {+ if (matches(list[index - 2], options.owner)) {+ edits.push({ start: token.start, end: token.end, value: quotedIdentifier(options.newName) });+ }+ continue;+ }+ edits.push({ start: token.start, end: token.end, value: quotedIdentifier(options.newName) });+ }++ // Dynamic SQL is safe to copy only when its complete statement text is a literal.+ for (let index = 0; index < list.length; index++) {+ if (!matches(list[index], "EXECUTE") || !matches(list[index + 1], "IMMEDIATE")) continue;+ const token = list[index + 2];+ if (token?.kind !== "string") throw new Error("Dynamic SQL must use a complete string literal; replace the expression with corrected source before Save As.");+ const clause = list[index + 3];+ if (clause && clause.text !== ";" && !(clause.kind === "identifier" && ["INTO", "USING", "RETURNING"].includes(clause.value))) {+ throw new Error("Dynamic SQL must use a complete string literal; replace the expression with corrected source before Save As.");+ }+ const dynamicTokens = tokens(token.value);+ for (let dynamicIndex = 0; dynamicIndex < dynamicTokens.length; dynamicIndex++) {+ if (matches(dynamicTokens[dynamicIndex], "EXECUTE") && matches(dynamicTokens[dynamicIndex + 1], "IMMEDIATE")) {+ throw new Error("Nested dynamic SQL cannot be safely retargeted; replace the expression with a corrected static or single-level statement before Save As.");+ }+ if (sameName(dynamicTokens[dynamicIndex]) && dynamicTokens[dynamicIndex + 1]?.text === ".") {+ throw new Error("Package source contains a dynamic string reference that cannot be safely retargeted.");+ }+ }+ }++ edits.sort((left, right) => right.start - left.start);+ let rewritten = sourceWithTerminator;+ let previousStart = sourceWithTerminator.length + 1;+ for (const edit of edits) {+ if (edit.end > previousStart) throw new Error("Package source contains overlapping rename edits.");+ rewritten = rewritten.slice(0, edit.start) + edit.value + rewritten.slice(edit.end);+ previousStart = edit.start;+ }+ return rewritten;+}++export function oraclePackageCatalogSource(createSql: string): string {+ const list = tokens(createSql);+ const packageIndex = list.findIndex((token) => matches(token, "PACKAGE"));+ const create = list[packageIndex - 1];+ if (packageIndex < 0) throw new Error("Package source has no PACKAGE declaration.");+ const packageSource = matches(create, "CREATE") ? createSql.slice(0, create.start) + createSql.slice(list[packageIndex]!.start) : createSql;+ const sourceTokens = tokens(packageSource);+ const terminator = sourceTokens[sourceTokens.length - 1];+ return (terminator?.text === ";" ? packageSource.slice(0, terminator.start) : packageSource).trimEnd();+}diff --git a/apps/desktop/src/lib/table/oracleRoutineRename.ts b/apps/desktop/src/lib/table/oracleRoutineRename.tsnew file mode 100644index 0000000000..31033266dc--- /dev/null+++ b/apps/desktop/src/lib/table/oracleRoutineRename.ts@@ -0,0 +1,680 @@+import * as api from "@/lib/backend/api";+import { BackendErrorException } from "@/lib/backend/errorUtils";+import { freezeSourceIdentities } from "@/lib/table/objectSourceIdentity";+import { invalidateObjectDdlCache } from "@/lib/metadata/objectDdlCache";+import { invalidateObjectBrowserRowsCache } from "@/lib/table/objectBrowserRowsCache";+import type { DatabaseType, ObjectSourceKind, QueryResult } from "@/types/database";++export interface OracleRoutineRenameTarget {+ connectionId: string;+ database: string;+ databaseType: Extract<DatabaseType, "oracle" | "dameng" | "oceanbase-oracle">;+ schema: string;+ objectType: Extract<ObjectSourceKind, "PROCEDURE" | "FUNCTION">;+ oldName: string;+ newName: string;+}++interface RoutineSnapshot {+ name: string;+ objectType: string;+ objectId: string;+ status: string;+ source: string;+ signature: string;+ grants: string;+ errors: string;+}++interface RoutineCallerSnapshot extends RoutineSnapshot {+ draft: string;+ rewrittenSource: string;+ rewrittenFingerprint: string;+ sourceFingerprint: string;+ rewriteRequired: boolean;+ depth: number;+}++export type OracleRoutineRenameStep = {+ kind: "create" | "grant" | "replace-caller" | "compile-caller" | "drop";+ objectName: string;+ objectType: string;+ sql: string;+};++export interface OracleRoutineRenamePlan {+ target: OracleRoutineRenameTarget;+ canonicalNewName: string;+ root: RoutineSnapshot | null;+ rootDraft: string;+ rootCreateSource: string;+ callers: RoutineCallerSnapshot[];+ dependencyEdges: string[];+ statements: string[];+ steps: OracleRoutineRenameStep[];+ issues: Array<{ code: string; message: string; objectName?: string; repairable: boolean }>;+ metadataComplete: boolean;+ executable: boolean;+}++export class OracleRoutineRenameFailure extends Error {+ constructor(+ public readonly plan: OracleRoutineRenamePlan,+ public readonly completed: string[],+ public readonly uncertain: string,+ cause: unknown,+ ) {+ super(`Routine rename stopped. Confirmed: ${completed.join(", ") || "none"}. Check ${uncertain} before retrying. ${errorMessage(cause)}`);+ }+}++const metadataLimit = 5000;+const maxSourceLength = 1_000_000;+const literal = (value: string) => `'${value.replaceAll("'", "''")}'`;+const identifier = (value: string) => `"${value.replaceAll('"', '""')}"`;+const routineTypes = new Set(["PROCEDURE", "FUNCTION"]);+const acceptedCallerTypes = new Set(["VIEW", "PROCEDURE", "FUNCTION"]);+const namespaceTypes = ["TABLE", "VIEW", "SEQUENCE", "SYNONYM", "PROCEDURE", "FUNCTION", "PACKAGE", "MATERIALIZED VIEW", "TYPE", "OPERATOR"];++function errorMessage(error: unknown): string {+ return error instanceof Error ? error.message : String(error);+}++function qualified(schema: string, name: string) {+ return `${identifier(schema)}.${identifier(name)}`;+}++async function query(target: OracleRoutineRenameTarget, sql: string): Promise<QueryResult> {+ const result = await api.executeQuery(target.connectionId, target.database, sql, target.schema, undefined, { maxRows: metadataLimit + 1 });+ if (result.execution_error) throw new BackendErrorException(result.error || "Metadata query failed.");+ if (result.truncated || result.has_more || result.rows.length > metadataLimit || result.large_value_cells?.length) {+ throw new Error("Metadata is incomplete; refresh the rename plan before execution.");+ }+ return result;+}++async function checkOwner(target: OracleRoutineRenameTarget) {+ const result = await query(target, "SELECT USER, SYS_CONTEXT('USERENV','CURRENT_SCHEMA') FROM DUAL");+ if (result.rows.length !== 1 || result.rows[0][0] !== target.schema || result.rows[0][1] !== target.schema) {+ throw new Error("Routine rename requires the object's owner and matching current schema.");+ }+}++async function objectStates(target: OracleRoutineRenameTarget, names: string[], types = namespaceTypes) {+ if (!names.length) return [] as unknown[][];+ const list = names.map(literal).join(",");+ const objectTypes = types.map(literal).join(",");+ return (await query(target, `SELECT OBJECT_NAME, OBJECT_TYPE, OBJECT_ID, STATUS FROM USER_OBJECTS WHERE OBJECT_NAME IN (${list}) AND OBJECT_TYPE IN (${objectTypes}) ORDER BY OBJECT_NAME, OBJECT_TYPE`)).rows;+}++async function readSource(target: OracleRoutineRenameTarget, objectType: string, name: string): Promise<string> {+ const metadataType = objectType === "PACKAGE BODY" ? "PACKAGE_BODY" : objectType;+ const ddl = `DBMS_METADATA.GET_DDL(${literal(metadataType)},${literal(name)},${literal(target.schema)})`;+ const lengthRows = (await query(target, `SELECT DBMS_LOB.GETLENGTH(${ddl}) FROM DUAL`)).rows;+ const length = Number(lengthRows[0]?.[0]);+ if (lengthRows.length !== 1 || !Number.isSafeInteger(length) || length <= 0 || length > maxSourceLength) {+ throw new Error(`Complete ${objectType} DDL is unavailable for ${name}.`);+ }+ let source = "";+ for (let firstOffset = 1; firstOffset <= length; firstOffset += 32_000) {+ const offsets: number[] = [];+ for (let offset = firstOffset; offset <= length && offsets.length < 32; offset += 1000) offsets.push(offset);+ const sql = offsets.map((offset) => `SELECT ${offset} CHUNK_OFFSET, DBMS_LOB.SUBSTR(${ddl},1000,${offset}) CHUNK_TEXT FROM DUAL`).join(" UNION ALL ");+ const rows = (await query(target, sql)).rows;+ const chunks = new Map(rows.map((row) => [Number(row[0]), row[1]]));+ if (rows.length !== offsets.length || chunks.size !== offsets.length) throw new Error(`Complete ${objectType} DDL is unavailable for ${name}.`);+ for (const offset of offsets) {+ const chunk = chunks.get(offset);+ if (typeof chunk !== "string" || Array.from(chunk).length !== Math.min(1000, length - offset + 1)) {+ throw new Error(`Complete ${objectType} DDL is unavailable for ${name}.`);+ }+ source += chunk;+ }+ }+ return source;+}++async function readSignature(target: OracleRoutineRenameTarget, name: string) {+ const rows = (+ await query(+ target,+ `SELECT POSITION, SEQUENCE, ARGUMENT_NAME, IN_OUT, DATA_TYPE, DATA_LENGTH, DATA_PRECISION, DATA_SCALE, TYPE_OWNER, TYPE_NAME, TYPE_SUBNAME, DEFAULTED FROM ALL_ARGUMENTS WHERE OWNER=${literal(target.schema)} AND OBJECT_NAME=${literal(name)} AND PACKAGE_NAME IS NULL ORDER BY OVERLOAD, SEQUENCE`,+ )+ ).rows;+ return JSON.stringify(rows.map((row) => row.map((value) => (value === null ? null : String(value)))));+}++async function readGrants(target: OracleRoutineRenameTarget, name: string) {+ const rows = (await query(target, `SELECT GRANTOR, GRANTEE, PRIVILEGE, GRANTABLE FROM ALL_TAB_PRIVS WHERE TABLE_SCHEMA=${literal(target.schema)} AND TABLE_NAME=${literal(name)} ORDER BY GRANTOR, GRANTEE, PRIVILEGE`)).rows;+ return JSON.stringify(rows.map((row) => row.map((value) => (value === null ? null : String(value)))));+}++async function readErrors(target: OracleRoutineRenameTarget, objectType: string, name: string) {+ const rows = (await query(target, `SELECT ATTRIBUTE, LINE, POSITION, TEXT FROM USER_ERRORS WHERE NAME=${literal(name)} AND TYPE=${literal(objectType)} ORDER BY SEQUENCE`)).rows;+ return JSON.stringify(rows.map((row) => row.map((value) => (value === null ? null : String(value)))));+}++async function validateCallerSource(target: OracleRoutineRenameTarget, callerType: string, callerName: string, renamedRoutineName: string, source: string) {+ if (callerType === "VIEW") {+ const review = await api.reviewOracleViewRenameSource({+ source,+ owner: target.schema,+ viewName: callerName,+ oldName: renamedRoutineName,+ newName: renamedRoutineName,+ });+ if (!review.source || review.issues.length) {+ throw new Error(review.issues.map(({ message }) => message).join("\n") || `Cannot validate view ${callerName}.`);+ }+ return review.source.source;+ }+ if (target.databaseType === "oracle" || target.databaseType === "oceanbase-oracle") {+ await api.validateOracleExecutableObjectSource({+ databaseType: target.databaseType,+ objectType: callerType as "PROCEDURE" | "FUNCTION",+ schema: target.schema,+ name: callerName,+ source,+ });+ }+ return source;+}++async function readSnapshot(target: OracleRoutineRenameTarget, name: string, objectType: string): Promise<RoutineSnapshot> {+ const rows = await objectStates(target, [name], [objectType]);+ const match = rows.filter((row) => row[0] === name && row[1] === objectType);+ if (match.length !== 1 || (typeof match[0][2] !== "number" && typeof match[0][2] !== "string")) {+ throw new Error(`${objectType} ${name} is missing or has an ambiguous identity.`);+ }+ return {+ name,+ objectType,+ objectId: String(match[0][2]),+ status: String(match[0][3]),+ source: await readSource(target, objectType, name),+ signature: routineTypes.has(objectType) ? await readSignature(target, name) : "",+ grants: await readGrants(target, name),+ errors: routineTypes.has(objectType) ? await readErrors(target, objectType, name) : "[]",+ };+}++async function readDependents(target: OracleRoutineRenameTarget, name: string, objectType: string) {+ const suffix = ` WHERE REFERENCED_OWNER=${literal(target.schema)} AND REFERENCED_NAME=${literal(name)} AND REFERENCED_TYPE=${literal(objectType)}`;+ const columns = "SELECT OWNER, NAME, TYPE, REFERENCED_LINK_NAME FROM ";+ try {+ return (await query(target, `${columns}SYS.DBA_DEPENDENCIES${suffix}`)).rows;+ } catch (error) {+ if (!/ORA-00942|ORA-01031/.test(errorMessage(error))) throw error;+ return (await query(target, `${columns}SYS.ALL_DEPENDENCIES${suffix}`)).rows;+ }+}++function issue(issues: OracleRoutineRenamePlan["issues"], code: string, message: string, objectName?: string, repairable = false) {+ issues.push({ code, message, objectName, repairable });+}++function makeCreateOnly(sql: string) {+ const create = /^(\s*CREATE\s+)OR\s+REPLACE\s+/i;+ if (!create.test(sql)) throw new Error("Routine DDL is not a CREATE OR REPLACE statement.");+ return sql.replace(create, "$1");+}++async function routineSourceFingerprint(target: OracleRoutineRenameTarget, objectType: Extract<ObjectSourceKind, "PROCEDURE" | "FUNCTION">, name: string, source: string) {+ if (target.databaseType !== "oracle" && target.databaseType !== "oceanbase-oracle") return source;+ return api.fingerprintOracleRoutineObjectSource({+ databaseType: target.databaseType,+ objectType,+ schema: target.schema,+ name,+ source,+ });+}++function makeGrantSql(target: OracleRoutineRenameTarget, grantRows: string) {+ const rows = JSON.parse(grantRows) as Array<Array<string | null>>;+ const statements: string[] = [];+ for (const [grantor, grantee, privilege, grantable] of rows) {+ if (grantor !== target.schema || privilege !== "EXECUTE" || !grantee) {+ throw new Error(`Cannot safely copy direct grant ${String(privilege)} from ${String(grantor)} to the new routine.`);+ }+ statements.push(`GRANT EXECUTE ON ${qualified(target.schema, target.newName)} TO ${grantee === "PUBLIC" ? "PUBLIC" : identifier(grantee)}${grantable === "YES" ? " WITH GRANT OPTION" : ""};`);+ }+ return statements;+}++function planIdentity(plan: OracleRoutineRenamePlan) {+ return JSON.stringify([plan.target, plan.canonicalNewName, plan.dependencyEdges, plan.root, plan.rootDraft, plan.rootCreateSource, plan.callers, plan.statements, plan.issues, plan.metadataComplete]);+}++function routineDrafts(plan: OracleRoutineRenamePlan) {+ return Object.fromEntries([[`${plan.target.objectType}:${plan.target.oldName}`, plan.rootDraft], ...plan.callers.map((caller) => [`${caller.objectType}:${caller.name}`, caller.draft])]);+}++export async function prepareOracleRoutineRename(target: OracleRoutineRenameTarget, drafts: Record<string, string> = {}): Promise<OracleRoutineRenamePlan> {+ target = { ...target };+ const plan: OracleRoutineRenamePlan = {+ target,+ canonicalNewName: target.newName,+ root: null,+ rootDraft: "",+ rootCreateSource: "",+ callers: [],+ dependencyEdges: [],+ statements: [],+ steps: [],+ issues: [],+ metadataComplete: true,+ executable: false,+ };+ try {+ plan.canonicalNewName = await api.parseOracleObjectName(target.newName);+ if (plan.canonicalNewName === target.oldName) issue(plan.issues, "invalid_name", "The new name matches the existing routine name.");+ await checkOwner(target);+ const conflicts = await objectStates(target, [plan.canonicalNewName]);+ if (conflicts.some((row) => row[0] === plan.canonicalNewName)) issue(plan.issues, "target_conflict", `A routine-namespace object named ${plan.canonicalNewName} already exists.`);+ } catch (error) {+ plan.metadataComplete = false;+ issue(plan.issues, /owner|current schema/i.test(errorMessage(error)) ? "owner_mismatch" : "metadata_incomplete", errorMessage(error));+ }++ try {+ plan.root = await readSnapshot(target, target.oldName, target.objectType);+ plan.rootDraft = drafts[`${target.objectType}:${target.oldName}`] ?? plan.root.source;+ if (plan.root.status !== "VALID") issue(plan.issues, "invalid_source", `The existing ${target.objectType} is ${plan.root.status}; resolve its compile errors before rename.`, target.oldName);+ } catch (error) {+ plan.metadataComplete = false;+ issue(plan.issues, "source_read_failed", errorMessage(error), target.oldName);+ }++ const callers = new Map<string, { name: string; type: string; depth: number; rewriteRequired: boolean }>();+ const visiting = new Set<string>();+ const visited = new Set<string>();+ const walk = async (referencedName: string, referencedType: string, depth: number): Promise<void> => {+ const referencedKey = `${referencedType}:${referencedName}`;+ if (visited.has(referencedKey)) return;+ if (visiting.has(referencedKey)) {+ issue(plan.issues, "dependency_cycle", `Cyclic dependency reaches ${referencedType} ${referencedName}.`, referencedName);+ return;+ }+ visiting.add(referencedKey);+ let dependents: unknown[][];+ try {+ dependents = await readDependents(target, referencedName, referencedType);+ if (dependents.length > metadataLimit) throw new Error("Dependency metadata is incomplete.");+ } catch (error) {+ plan.metadataComplete = false;+ issue(plan.issues, "dependency_read_failed", errorMessage(error), referencedName);+ visiting.delete(referencedKey);+ visited.add(referencedKey);+ return;+ }+ for (const [owner, name, type, link] of dependents) {+ if (typeof name !== "string" || typeof type !== "string") {+ issue(plan.issues, "invalid_dependency", `Dependency metadata for ${referencedType} ${referencedName} is incomplete.`, referencedName);+ continue;+ }+ const selfRecursive = owner === target.schema && name === referencedName && type === referencedType && !link;+ plan.dependencyEdges.push(JSON.stringify([referencedName, referencedType, owner, name, type, link ?? null]));+ if (selfRecursive) continue;+ if (owner !== target.schema || link || !acceptedCallerTypes.has(type)) {+ issue(plan.issues, "unsupported_dependency", `Cannot update dependent ${String(owner)}.${name} (${type}${link ? `@${String(link)}` : ""}).`, name);+ continue;+ }+ const callerKey = `${type}:${name}`;+ const existing = callers.get(callerKey);+ callers.set(callerKey, {+ name,+ type,+ depth: Math.min(existing?.depth ?? Number.MAX_SAFE_INTEGER, depth + 1),+ rewriteRequired: (existing?.rewriteRequired ?? false) || referencedName === target.oldName,+ });+ const childKey = callerKey;+ if (visiting.has(childKey)) {+ issue(plan.issues, "dependency_cycle", `Cyclic dependency reaches ${type} ${name}.`, name);+ } else if (!visited.has(childKey)) {+ await walk(name, type, depth + 1);+ }+ }+ visiting.delete(referencedKey);+ visited.add(referencedKey);+ };+ if (plan.metadataComplete) await walk(target.oldName, target.objectType, 0);+ plan.dependencyEdges.sort();++ const orderedCallers = topologicalCallers(callers, plan.dependencyEdges);+ if (orderedCallers.length !== callers.size) issue(plan.issues, "dependency_cycle", "The visible caller graph cannot be ordered safely.", target.oldName);+ for (const caller of orderedCallers) {+ let snapshot: RoutineSnapshot;+ try {+ snapshot = await readSnapshot(target, caller.name, caller.type);+ if (snapshot.status !== "VALID") throw new Error(`${caller.type} ${caller.name} is ${snapshot.status}.`);+ } catch (error) {+ plan.metadataComplete = false;+ issue(plan.issues, "source_read_failed", errorMessage(error), caller.name);+ continue;+ }+ const draft = drafts[`${caller.type}:${caller.name}`] ?? snapshot.source;+ let rewrittenSource = "";+ let replacementSql = "";+ let sourceFingerprint = "";+ try {+ if (caller.rewriteRequired) {+ rewrittenSource = await api.rewriteOracleRoutineReferences({+ databaseType: target.databaseType,+ callerType: caller.type as "VIEW" | "PROCEDURE" | "FUNCTION",+ targetType: target.objectType,+ schema: target.schema,+ oldName: target.oldName,+ newName: plan.canonicalNewName,+ source: draft,+ });+ rewrittenSource = await validateCallerSource(target, caller.type, caller.name, plan.canonicalNewName, rewrittenSource);+ const statements = await api.buildExecutableObjectSourceStatements({+ databaseType: target.databaseType,+ objectType: caller.type as ObjectSourceKind,+ schema: target.schema,+ name: caller.name,+ source: rewrittenSource,+ });+ if (statements.length !== 1 || !statements[0]?.trim()) throw new Error(`Cannot build one replacement statement for ${caller.type} ${caller.name}.`);+ replacementSql = statements[0];+ if (routineTypes.has(caller.type)) sourceFingerprint = await routineSourceFingerprint(target, caller.type as "PROCEDURE" | "FUNCTION", caller.name, replacementSql);+ } else {+ rewrittenSource = draft;+ replacementSql = draft;+ }+ } catch (error) {+ issue(plan.issues, "caller_rewrite_failed", errorMessage(error), caller.name, true);+ }+ plan.callers.push({ ...snapshot, draft, rewrittenSource, rewrittenFingerprint: replacementSql, sourceFingerprint, rewriteRequired: caller.rewriteRequired, depth: caller.depth });+ }++ let dropSql = "";+ if (plan.metadataComplete && plan.root) {+ try {+ const statements = await api.buildRoutineRenameObjectSourceStatements({+ databaseType: target.databaseType,+ objectType: target.objectType,+ schema: target.schema,+ name: target.oldName,+ newName: plan.canonicalNewName,+ source: plan.rootDraft,+ });+ if (statements.length !== 2) throw new Error("The routine rename builder returned an unexpected statement sequence.");+ plan.rootCreateSource = makeCreateOnly(statements[0]);+ dropSql = statements[1];+ } catch (error) {+ issue(plan.issues, "source_rewrite_failed", errorMessage(error), target.oldName, true);+ }+ try {+ const grants = makeGrantSql({ ...target, newName: plan.canonicalNewName }, plan.root.grants);+ if (plan.issues.length === 0 && plan.callers.every((caller) => !!caller.rewrittenSource && !!caller.rewrittenFingerprint)) {+ plan.steps = [+ { kind: "create", objectName: plan.canonicalNewName, objectType: target.objectType, sql: plan.rootCreateSource },+ ...grants.map((sql) => ({ kind: "grant" as const, objectName: plan.canonicalNewName, objectType: target.objectType, sql })),+ ...plan.callers.map((caller) => ({+ kind: caller.rewriteRequired ? ("replace-caller" as const) : ("compile-caller" as const),+ objectName: caller.name,+ objectType: caller.objectType,+ sql: caller.rewriteRequired ? caller.rewrittenFingerprint : `ALTER ${caller.objectType} ${qualified(target.schema, caller.name)} COMPILE`,+ })),+ { kind: "drop", objectName: target.oldName, objectType: target.objectType, sql: dropSql },+ ];+ plan.statements = plan.steps.map((step) => step.sql);+ plan.executable = true;+ }+ } catch (error) {+ issue(plan.issues, "plan_build_failed", errorMessage(error), target.oldName);+ }+ }+ plan.dependencyEdges.sort();+ return plan;+}++function topologicalCallers(callers: Map<string, { name: string; type: string; depth: number; rewriteRequired: boolean }>, dependencyEdges: string[]) {+ const indegree = new Map([...callers.keys()].map((key) => [key, 0]));+ const outgoing = new Map([...callers.keys()].map((key) => [key, new Set<string>()]));+ for (const edge of dependencyEdges) {+ const [referencedName, referencedType, , dependentName, dependentType, link] = JSON.parse(edge) as [string, string, string, string, string, string | null];+ const from = `${referencedType}:${referencedName}`;+ const to = `${dependentType}:${dependentName}`;+ if (link || from === to) continue;+ if (!callers.has(from) || !callers.has(to) || outgoing.get(from)!.has(to)) continue;+ outgoing.get(from)!.add(to);+ indegree.set(to, indegree.get(to)! + 1);+ }+ const compare = (left: string, right: string) => {+ const a = callers.get(left)!;+ const b = callers.get(right)!;+ return a.depth - b.depth || a.type.localeCompare(b.type) || a.name.localeCompare(b.name);+ };+ const ready = [...indegree]+ .filter(([, degree]) => degree === 0)+ .map(([key]) => key)+ .sort(compare);+ const ordered: Array<{ name: string; type: string; depth: number; rewriteRequired: boolean }> = [];+ while (ready.length) {+ const key = ready.shift()!;+ ordered.push(callers.get(key)!);+ for (const dependent of outgoing.get(key)!) {+ indegree.set(dependent, indegree.get(dependent)! - 1);+ if (indegree.get(dependent) === 0) {+ ready.push(dependent);+ ready.sort(compare);+ }+ }+ }+ return ordered;+}++export async function executeOracleRoutineRename(plan: OracleRoutineRenamePlan, isCurrent: () => boolean = () => true): Promise<void> {+ if (!isCurrent()) throw new Error("The rename target changed. Refresh the preview.");+ if (!plan.executable || !plan.root) throw new Error("Resolve every routine dependency issue before execution.");+ const current = await prepareOracleRoutineRename(plan.target, routineDrafts(plan));+ if (!current.executable || planIdentity(current) !== planIdentity(plan) || !isCurrent()) throw new Error("Routine metadata changed. Refresh the rename preview.");+ const affected = [plan.root, ...plan.callers];+ const frozen = freezeSourceIdentities(+ affected.map((item) => ({+ connectionId: plan.target.connectionId,+ database: plan.target.database,+ schema: plan.target.schema,+ objectType: item.objectType,+ name: item.name,+ })),+ );+ const completed: string[] = [];+ let dispatched = false;+ let activeName = plan.canonicalNewName;+ let createdRoot: RoutineSnapshot | null = null;+ try {+ for (const step of plan.steps) {+ if (!isCurrent()) throw new Error("The rename dialog changed or closed; remaining steps were not sent.");+ activeName = step.objectName;+ if (step.kind === "create") {+ if ((await objectStates(plan.target, [plan.canonicalNewName])).some((row) => row[0] === plan.canonicalNewName)) throw new Error("The new routine name was created by another session.");+ } else if (step.kind === "replace-caller" || step.kind === "compile-caller") {+ const caller = plan.callers.find((item) => item.name === step.objectName && item.objectType === step.objectType)!;+ const latest = await readSnapshot(plan.target, caller.name, caller.objectType);+ if (latest.objectId !== caller.objectId || latest.source !== caller.source || latest.signature !== caller.signature || latest.grants !== caller.grants) {+ throw new Error(`${caller.objectType} ${caller.name} changed after validation.`);+ }+ } else if (step.kind === "drop") {+ await verifyBeforeDrop(plan, createdRoot);+ }+ if (!isCurrent()) throw new Error("The rename dialog changed or closed; remaining steps were not sent.");+ if (!dispatched) {+ frozen.markDispatched();+ dispatched = true;+ }+ try {+ await query(plan.target, step.sql);+ } catch (error) {+ if (step.kind === "drop") {+ try {+ const oldState = await objectStates(plan.target, [plan.target.oldName], [plan.target.objectType]);+ if (!oldState.some((row) => row[0] === plan.target.oldName && row[1] === plan.target.objectType)) {+ completed.push(`DROP ${plan.target.oldName} (confirmed by readback)`);+ return;+ }+ throw new Error(`DROP response failed and ${plan.target.objectType} ${plan.target.oldName} still exists: ${errorMessage(error)}`);+ } catch (readbackError) {+ if (readbackError instanceof Error && readbackError.message.startsWith("DROP response failed")) throw readbackError;+ throw new Error(`DROP response failed and the old object state is unknown: ${errorMessage(readbackError)}`);+ }+ }+ throw error;+ }+ if (step.kind === "create") {+ const created = await readSnapshot(plan.target, plan.canonicalNewName, plan.target.objectType);+ if (created.objectId === plan.root.objectId) throw new Error("The new name resolved to the original routine identity.");+ const actualSource = await api.buildRoutineRenameObjectSourceStatements({+ databaseType: plan.target.databaseType,+ objectType: plan.target.objectType as ObjectSourceKind,+ schema: plan.target.schema,+ name: plan.canonicalNewName,+ newName: plan.target.oldName,+ source: created.source,+ });+ const plannedSource = await api.buildRoutineRenameObjectSourceStatements({+ databaseType: plan.target.databaseType,+ objectType: plan.target.objectType as ObjectSourceKind,+ schema: plan.target.schema,+ name: plan.target.oldName,+ newName: plan.target.oldName,+ source: plan.rootDraft,+ });+ if (actualSource.length !== 2 || plannedSource.length !== 2) throw new Error("The new routine source does not match the approved definition.");+ const actualDefinition = makeCreateOnly(actualSource[0]);+ const plannedDefinition = makeCreateOnly(plannedSource[0]);+ const matchesApprovedDefinition =+ plan.target.databaseType === "oracle" || plan.target.databaseType === "oceanbase-oracle"+ ? (await routineSourceFingerprint(plan.target, plan.target.objectType, plan.target.oldName, actualDefinition)) === (await routineSourceFingerprint(plan.target, plan.target.objectType, plan.target.oldName, plannedDefinition))+ : actualDefinition === plannedDefinition;+ if (!matchesApprovedDefinition) throw new Error("The new routine source does not match the approved definition.");+ if (created.status !== "VALID") {+ await query(plan.target, `ALTER ${plan.target.objectType} ${qualified(plan.target.schema, plan.canonicalNewName)} COMPILE`);+ const compiled = await readSnapshot(plan.target, plan.canonicalNewName, plan.target.objectType);+ if (compiled.objectId !== created.objectId || compiled.source !== created.source || compiled.signature !== created.signature || compiled.grants !== created.grants) throw new Error(`The new routine ${plan.canonicalNewName} changed during compilation.`);+ if (compiled.status !== "VALID" || compiled.errors !== "[]") throw new Error(`The new routine ${plan.canonicalNewName} remains invalid after one compile attempt.`);+ createdRoot = compiled;+ } else {+ createdRoot = created;+ }+ completed.push(`CREATE ${plan.canonicalNewName}`);+ } else if (step.kind === "grant") {+ completed.push(`GRANT ${plan.canonicalNewName}`);+ } else if (step.kind === "replace-caller" || step.kind === "compile-caller") {+ const caller = plan.callers.find((item) => item.name === step.objectName && item.objectType === step.objectType)!;+ const actual = await readSnapshot(plan.target, caller.name, caller.objectType);+ const replacedViewMayHaveNewIdentity = step.kind === "replace-caller" && caller.objectType === "VIEW";+ if (+ (!replacedViewMayHaveNewIdentity && actual.objectId !== caller.objectId) ||+ actual.grants !== caller.grants ||+ (step.kind === "replace-caller" && (actual.status !== "VALID" || actual.errors !== caller.errors)) ||+ (step.kind === "compile-caller" && (actual.status !== "VALID" || actual.errors !== "[]"))+ )+ throw new Error(`${caller.objectType} ${caller.name} did not preserve its identity, validity, errors, and grants.`);+ if (step.kind === "replace-caller") {+ await validateCallerSource(plan.target, caller.objectType, caller.name, plan.canonicalNewName, actual.source);+ const actualStatements = await api.buildExecutableObjectSourceStatements({+ databaseType: plan.target.databaseType,+ objectType: caller.objectType as ObjectSourceKind,+ schema: plan.target.schema,+ name: caller.name,+ source: actual.source,+ });+ const actualFingerprint = routineTypes.has(caller.objectType) ? await routineSourceFingerprint(plan.target, caller.objectType as "PROCEDURE" | "FUNCTION", caller.name, actual.source) : actualStatements[0];+ const expectedFingerprint = routineTypes.has(caller.objectType) ? caller.sourceFingerprint : caller.rewrittenFingerprint;+ if (actualStatements.length !== 1 || actualFingerprint !== expectedFingerprint) {+ throw new Error(`${caller.objectType} ${caller.name} did not match the planned replacement source.`);+ }+ if (replacedViewMayHaveNewIdentity) caller.objectId = actual.objectId;+ } else if (actual.source !== caller.source) {+ throw new Error(`${caller.objectType} ${caller.name} did not retain the planned caller source.`);+ }+ completed.push(`${caller.objectType} ${caller.name}`);+ } else {+ const oldState = await objectStates(plan.target, [plan.target.oldName], [plan.target.objectType]);+ if (oldState.some((row) => row[0] === plan.target.oldName && row[1] === plan.target.objectType)) throw new Error(`The old routine ${plan.target.oldName} still exists after DROP.`);+ completed.push(`DROP ${plan.target.oldName}`);+ }+ }+ } catch (error) {+ if (dispatched) throw new OracleRoutineRenameFailure(plan, completed, activeName, error);+ throw error;+ } finally {+ if (dispatched) {+ invalidateObjectBrowserRowsCache({ connectionId: plan.target.connectionId, database: plan.target.database, schema: plan.target.schema });+ await Promise.allSettled([plan.target.oldName, plan.canonicalNewName, ...plan.callers.map((caller) => caller.name)].map((tableName) => invalidateObjectDdlCache({ connectionId: plan.target.connectionId, database: plan.target.database, schema: plan.target.schema, tableName })));+ frozen.finish();+ } else frozen.cancel();+ }+}++async function verifyBeforeDrop(plan: OracleRoutineRenamePlan, createdRoot: RoutineSnapshot | null) {+ const root = await readSnapshot(plan.target, plan.target.oldName, plan.target.objectType);+ const created = await readSnapshot(plan.target, plan.canonicalNewName, plan.target.objectType);+ if (root.objectId !== plan.root!.objectId || root.source !== plan.root!.source || root.signature !== plan.root!.signature || root.grants !== plan.root!.grants || root.status !== plan.root!.status || root.errors !== plan.root!.errors) {+ throw new Error("The original routine changed before DROP.");+ }+ if (+ !createdRoot ||+ created.objectId !== createdRoot.objectId ||+ created.objectId === root.objectId ||+ created.source !== createdRoot.source ||+ created.status !== "VALID" ||+ created.errors !== "[]" ||+ created.signature !== plan.root!.signature ||+ created.grants !== makeGrantFingerprint(plan.root!.grants, plan.target.schema)+ )+ throw new Error("The new routine identity, source, signature, status, or grants changed before DROP.");+ for (const caller of plan.callers) {+ const actual = await readSnapshot(plan.target, caller.name, caller.objectType);+ if (actual.objectId !== caller.objectId || actual.status !== "VALID" || actual.errors !== caller.errors || actual.grants !== caller.grants) throw new Error(`Dependent ${caller.objectType} ${caller.name} changed before DROP.`);+ if (caller.rewriteRequired) {+ await validateCallerSource(plan.target, caller.objectType, caller.name, plan.canonicalNewName, actual.source);+ const actualStatements = await api.buildExecutableObjectSourceStatements({+ databaseType: plan.target.databaseType,+ objectType: caller.objectType as ObjectSourceKind,+ schema: plan.target.schema,+ name: caller.name,+ source: actual.source,+ });+ const actualFingerprint = routineTypes.has(caller.objectType) ? await routineSourceFingerprint(plan.target, caller.objectType as "PROCEDURE" | "FUNCTION", caller.name, actual.source) : actualStatements[0];+ const expectedFingerprint = routineTypes.has(caller.objectType) ? caller.sourceFingerprint : caller.rewrittenFingerprint;+ if (actualStatements.length !== 1 || actualFingerprint !== expectedFingerprint) {+ throw new Error(`Dependent ${caller.objectType} ${caller.name} no longer matches the planned rewrite.`);+ }+ } else if (actual.source !== caller.source) {+ throw new Error(`Transitive dependent ${caller.objectType} ${caller.name} changed before DROP.`);+ }+ }+ const selfEdge = JSON.stringify([plan.target.oldName, plan.target.objectType, plan.target.schema, plan.target.oldName, plan.target.objectType, null]);+ const expectedEdges = plan.dependencyEdges+ .map((edge) => {+ const [referencedName, referencedType, owner, name, type, link] = JSON.parse(edge) as [string, string, string, string, string, string | null];+ const isRootSelfEdge = referencedName === plan.target.oldName && referencedType === plan.target.objectType && owner === plan.target.schema && name === plan.target.oldName && type === plan.target.objectType;+ return JSON.stringify([referencedName === plan.target.oldName ? plan.canonicalNewName : referencedName, referencedType, owner, isRootSelfEdge ? plan.canonicalNewName : name, type, link]);+ })+ .sort();+ const references = new Map<string, { name: string; type: string }>();+ references.set(`${plan.canonicalNewName}:${plan.target.objectType}`, { name: plan.canonicalNewName, type: plan.target.objectType });+ for (const caller of plan.callers) references.set(`${caller.name}:${caller.objectType}`, { name: caller.name, type: caller.objectType });+ const actualEdges: string[] = [];+ for (const reference of references.values()) {+ for (const [owner, name, type, link] of await readDependents(plan.target, reference.name, reference.type)) {+ actualEdges.push(JSON.stringify([reference.name, reference.type, owner, name, type, link ?? null]));+ }+ }+ const oldDependencies = await readDependents(plan.target, plan.target.oldName, plan.target.objectType);+ const unplannedOldDependencies = oldDependencies.filter(([owner, name, type]) => !(owner === plan.target.schema && name === plan.target.oldName && type === plan.target.objectType));+ if (unplannedOldDependencies.length || JSON.stringify(actualEdges.sort()) !== JSON.stringify(expectedEdges)) throw new Error("The visible dependency closure changed before DROP.");+ if (plan.dependencyEdges.includes(selfEdge) && !oldDependencies.some(([owner, name, type]) => owner === plan.target.schema && name === plan.target.oldName && type === plan.target.objectType)) {+ throw new Error("The original recursive routine changed before DROP.");+ }+}++function makeGrantFingerprint(sourceFingerprint: string, schema: string) {+ const rows = JSON.parse(sourceFingerprint) as Array<Array<string | null>>;+ return JSON.stringify(rows.map(([, grantee, privilege, grantable]) => [schema, grantee, privilege, grantable]).map((row) => row.map((value) => (value === null ? null : String(value)))));+}diff --git a/apps/desktop/src/lib/table/oracleTableRename.ts b/apps/desktop/src/lib/table/oracleTableRename.tsnew file mode 100644index 0000000000..2f39d52fb1--- /dev/null+++ b/apps/desktop/src/lib/table/oracleTableRename.ts@@ -0,0 +1,932 @@+import * as api from "@/lib/backend/api";+import { BackendErrorException } from "@/lib/backend/errorUtils";+import { freezeSourceIdentities } from "@/lib/table/objectSourceIdentity";+import { invalidateObjectDdlCache } from "@/lib/metadata/objectDdlCache";+import { invalidateObjectBrowserRowsCache } from "@/lib/table/objectBrowserRowsCache";+import type { DatabaseType, OracleViewRenameIssue, QueryResult } from "@/types/database";++type DependentType = "VIEW" | "PROCEDURE" | "FUNCTION" | "TRIGGER";+type RewriteableDependentType = Exclude<DependentType, "VIEW">;+type ObjectType = "TABLE" | "OPERATOR" | "PACKAGE BODY" | "TYPE BODY" | "SEQUENCE" | "SYNONYM" | "PACKAGE" | "MATERIALIZED VIEW" | "TYPE" | DependentType;++export interface OracleTableRenameTarget {+ connectionId: string;+ database: string;+ databaseType: Extract<DatabaseType, "oracle" | "oceanbase-oracle">;+ schema: string;+ oldName: string;+ newName: string;+}++export interface OracleTableRenameIssue {+ code: string;+ message: string;+ objectName?: string;+ location?: { line: number; column: number };+ repairable: boolean;+}++export interface OracleTableRenameDependent {+ name: string;+ objectType: DependentType;+ objectId: string;+ source: string;+ executionSource: string;+ status: string;+ grants: string;+ errors: string;+ triggerStatus?: string;+ triggerTable?: string;+ draft: string;+ rewrittenSource: string;+ fingerprint: string;+ originalFingerprint: string;+ rewriteRequired: boolean;+}++export interface OracleTableRenameStep {+ kind: "rename" | "replace" | "compile";+ objectName: string;+ objectType: ObjectType;+ sql: string;+}++export interface OracleTableRenamePlan {+ target: OracleTableRenameTarget;+ canonicalNewName: string;+ tableObjectId: string;+ tableSnapshot: OracleTableSnapshot | null;+ dependents: OracleTableRenameDependent[];+ dependencyEdges: string[];+ issues: OracleTableRenameIssue[];+ metadataComplete: boolean;+ executable: boolean;+ steps: OracleTableRenameStep[];+ statements: string[];+}++interface OracleTableSnapshot {+ source: string;+ grants: string;+ indexes: string;+ indexColumns: string;+ constraints: string;+ constraintColumns: string;+ incomingForeignKeys: string;+ boundTriggers: string;+}++export class OracleTableRenameFailure extends Error {+ constructor(+ public readonly plan: OracleTableRenamePlan,+ public readonly completed: string[],+ public readonly uncertain: string,+ public readonly reconciliation: "confirmed" | "not-confirmed" | "unknown",+ cause: unknown,+ ) {+ super(`Table rename stopped. Confirmed: ${completed.join(", ") || "none"}. ${uncertain} is ${reconciliation}. ${cause instanceof Error ? cause.message : String(cause)}`);+ }+}++const metadataLimit = 5000;+const sourceLimit = 1_000_000;+const literal = (value: string) => `'${value.replaceAll("'", "''")}'`;+const identifier = (value: string) => `"${value.replaceAll('"', '""')}"`;+const acceptedTypes = new Set<DependentType>(["VIEW", "PROCEDURE", "FUNCTION", "TRIGGER"]);+const tableNamespaceTypes: ObjectType[] = ["TABLE", "VIEW", "PROCEDURE", "FUNCTION", "SEQUENCE", "SYNONYM", "PACKAGE", "MATERIALIZED VIEW", "TYPE", "OPERATOR"];++function errorMessage(error: unknown) {+ return error instanceof Error ? error.message : String(error);+}++async function query(target: OracleTableRenameTarget, sql: string): Promise<QueryResult> {+ const result = await api.executeQuery(target.connectionId, target.database, sql, target.schema, undefined, { maxRows: metadataLimit + 1 });+ if (result.execution_error) throw new BackendErrorException(result.error || "Metadata query failed.");+ if (result.truncated || result.has_more || result.rows.length > metadataLimit || result.large_value_cells?.length) {+ throw new Error("Metadata is incomplete; refresh the table rename plan before execution.");+ }+ return result;+}++async function checkOwner(target: OracleTableRenameTarget) {+ const result = await query(target, "SELECT USER, SYS_CONTEXT('USERENV','CURRENT_SCHEMA') FROM DUAL");+ if (result.rows.length !== 1 || result.rows[0][0] !== target.schema || result.rows[0][1] !== target.schema) {+ throw new Error("Table rename requires the object's owner and matching current schema.");+ }+}++async function objectStates(target: OracleTableRenameTarget, name: string, types: ObjectType[]) {+ if (!types.length) return [] as unknown[][];+ const objectTypes = types.map(literal).join(",");+ return (await query(target, `SELECT OBJECT_TYPE, OBJECT_ID, STATUS FROM USER_OBJECTS WHERE OBJECT_NAME=${literal(name)} AND OBJECT_TYPE IN (${objectTypes}) ORDER BY OBJECT_TYPE`)).rows;+}++async function readSource(target: OracleTableRenameTarget, objectType: ObjectType, name: string) {+ const metadataType = objectType === "TABLE" ? "TABLE" : objectType;+ const ddl = `DBMS_METADATA.GET_DDL(${literal(metadataType)},${literal(name)},${literal(target.schema)})`;+ const lengthRows = (await query(target, `SELECT DBMS_LOB.GETLENGTH(${ddl}) FROM DUAL`)).rows;+ const length = Number(lengthRows[0]?.[0]);+ if (lengthRows.length !== 1 || !Number.isSafeInteger(length) || length <= 0 || length > sourceLimit) throw new Error(`Complete ${objectType} DDL is unavailable for ${name}.`);+ let source = "";+ for (let firstOffset = 1; firstOffset <= length; firstOffset += 32_000) {+ const offsets: number[] = [];+ for (let offset = firstOffset; offset <= length && offsets.length < 32; offset += 1000) offsets.push(offset);+ const rows = (await query(target, offsets.map((offset) => `SELECT ${offset} CHUNK_OFFSET, DBMS_LOB.SUBSTR(${ddl},1000,${offset}) CHUNK_TEXT FROM DUAL`).join(" UNION ALL "))).rows;+ const chunks = new Map(rows.map((row) => [Number(row[0]), row[1]]));+ if (rows.length !== offsets.length || chunks.size !== offsets.length) throw new Error(`Complete DDL is unavailable for ${name}.`);+ for (const offset of offsets) {+ const chunk = chunks.get(offset);+ if (typeof chunk !== "string" || Array.from(chunk).length !== Math.min(1000, length - offset + 1)) throw new Error(`Complete DDL is unavailable for ${name}.`);+ source += chunk;+ }+ }+ return source;+}++async function readGrants(target: OracleTableRenameTarget, name: string) {+ const tables = await query(target, `SELECT GRANTOR, GRANTEE, PRIVILEGE, GRANTABLE FROM ALL_TAB_PRIVS WHERE TABLE_SCHEMA=${literal(target.schema)} AND TABLE_NAME=${literal(name)}`);+ const schemaColumn = target.databaseType === "oracle" ? "TABLE_SCHEMA" : "OWNER";+ const columns = await query(target, `SELECT GRANTOR, GRANTEE, COLUMN_NAME, PRIVILEGE, GRANTABLE FROM ALL_COL_PRIVS WHERE ${schemaColumn}=${literal(target.schema)} AND TABLE_NAME=${literal(name)}`);+ return JSON.stringify([tables.rows.map((row) => JSON.stringify(row)).sort(), columns.rows.map((row) => JSON.stringify(row)).sort()]);+}++async function readErrors(target: OracleTableRenameTarget, name: string, objectType: DependentType) {+ const rows = (await query(target, `SELECT ATTRIBUTE, LINE, POSITION, TEXT FROM USER_ERRORS WHERE NAME=${literal(name)} AND TYPE=${literal(objectType)} ORDER BY SEQUENCE`)).rows;+ return JSON.stringify(rows.map((row) => row.map((value) => (value === null ? null : String(value)))));+}++async function readTrigger(target: OracleTableRenameTarget, name: string) {+ const rows = (await query(target, `SELECT STATUS, TABLE_NAME FROM USER_TRIGGERS WHERE TRIGGER_NAME=${literal(name)}`)).rows;+ if (rows.length !== 1 || typeof rows[0][0] !== "string" || typeof rows[0][1] !== "string") throw new Error(`Trigger metadata for ${name} is incomplete.`);+ return { status: rows[0][0] as string, table: rows[0][1] as string };+}++async function readBoundTriggers(target: OracleTableRenameTarget, tableName: string) {+ const rows = (await query(target, `SELECT TRIGGER_NAME, STATUS FROM USER_TRIGGERS WHERE TABLE_NAME=${literal(tableName)} ORDER BY TRIGGER_NAME`)).rows;+ if (rows.some((row) => typeof row[0] !== "string" || !["ENABLED", "DISABLED"].includes(String(row[1])))) throw new Error(`Bound trigger metadata for ${tableName} is incomplete.`);+ return rows;+}++async function readTableSnapshot(target: OracleTableRenameTarget, name: string): Promise<OracleTableSnapshot> {+ const [source, grants, indexes, indexColumns, constraints, constraintColumns, incomingForeignKeys, boundTriggers] = await Promise.all([+ readSource(target, "TABLE", name),+ readGrants(target, name),+ query(target, `SELECT INDEX_NAME, INDEX_TYPE, UNIQUENESS, STATUS, TABLESPACE_NAME FROM USER_INDEXES WHERE TABLE_NAME=${literal(name)} ORDER BY INDEX_NAME`),+ query(target, `SELECT INDEX_NAME, COLUMN_NAME, COLUMN_POSITION, DESCEND FROM USER_IND_COLUMNS WHERE TABLE_NAME=${literal(name)} ORDER BY INDEX_NAME, COLUMN_POSITION`),+ query(target, `SELECT CONSTRAINT_NAME, CONSTRAINT_TYPE, STATUS, VALIDATED, DEFERRABLE, DEFERRED, DELETE_RULE, R_OWNER, R_CONSTRAINT_NAME FROM USER_CONSTRAINTS WHERE TABLE_NAME=${literal(name)} ORDER BY CONSTRAINT_NAME`),+ query(target, `SELECT CONSTRAINT_NAME, COLUMN_NAME, POSITION FROM USER_CONS_COLUMNS WHERE TABLE_NAME=${literal(name)} ORDER BY CONSTRAINT_NAME, POSITION`),+ query(+ target,+ `SELECT c.OWNER, c.TABLE_NAME, c.CONSTRAINT_NAME, c.STATUS, c.VALIDATED, c.DELETE_RULE, c.R_OWNER, c.R_CONSTRAINT_NAME FROM ALL_CONSTRAINTS c JOIN ALL_CONSTRAINTS r ON r.OWNER=c.R_OWNER AND r.CONSTRAINT_NAME=c.R_CONSTRAINT_NAME WHERE c.CONSTRAINT_TYPE='R' AND r.OWNER=${literal(target.schema)} AND r.TABLE_NAME=${literal(name)} ORDER BY c.OWNER, c.CONSTRAINT_NAME`,+ ),+ readBoundTriggers(target, name),+ ]);+ return {+ source,+ grants,+ indexes: JSON.stringify(indexes.rows),+ indexColumns: JSON.stringify(indexColumns.rows),+ constraints: JSON.stringify(constraints.rows),+ constraintColumns: JSON.stringify(constraintColumns.rows),+ incomingForeignKeys: JSON.stringify(incomingForeignKeys.rows),+ boundTriggers: JSON.stringify(boundTriggers),+ };+}++function maskTriggerCommentsAndStrings(source: string) {+ const output = source.split("");+ const mask = (start: number, end: number) => {+ for (let index = start; index < end; index++) if (source[index] !== "\n" && source[index] !== "\r") output[index] = " ";+ };+ for (let index = 0; index < source.length;) {+ if (source.startsWith("--", index)) {+ const newline = source.indexOf("\n", index + 2);+ const end = newline < 0 ? source.length : newline;+ mask(index, end);+ index = end;+ } else if (source.startsWith("/*", index)) {+ const close = source.indexOf("*/", index + 2);+ if (close < 0) return "";+ mask(index, close + 2);+ index = close + 2;+ } else if ((source[index] === "q" || source[index] === "Q") && source[index + 1] === "'") {+ const opener = source[index + 2];+ if (!opener) return "";+ const closer = ({ "[": "]", "{": "}", "(": ")", "<": ">" } as Record<string, string>)[opener] || opener;+ const end = source.indexOf(`${closer}'`, index + 3);+ if (end < 0) return "";+ mask(index, end + 2);+ index = end + 2;+ } else if (source[index] === "'") {+ const start = index++;+ while (index < source.length) {+ if (source[index] === "'" && source[index + 1] === "'") index += 2;+ else if (source[index++] === "'") break;+ }+ mask(start, index);+ } else index++;+ }+ return output.join("");+}++function executableTriggerSource(source: string, schema: string, name: string, status: string) {+ const escaped = (value: string) => value.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");+ const suffix = new RegExp(`\\s*ALTER\\s+TRIGGER\\s+"?${escaped(schema)}"?\\s*\\.\\s*"?${escaped(name)}"?\\s+(ENABLE|DISABLE)\\s*;?\\s*$`, "i");+ const match = suffix.exec(source);+ if (!match) throw new Error(`Trigger ${name} DDL has an unsupported state clause.`);+ let create = source.slice(0, match.index).trimEnd();+ const disabled = status === "DISABLED";+ if (disabled) {+ const syntax = maskTriggerCommentsAndStrings(create);+ if (!/\bFOR\s+EACH\s+ROW\b/i.test(syntax)) throw new Error(`Disabled trigger ${name} is outside the supported row-trigger subset.`);+ if (!/\bFOR\s+EACH\s+ROW\s+DISABLE\b/i.test(syntax)) {+ const header = /\bFOR\s+EACH\s+ROW\b/i.exec(syntax)!;+ const insertion = header.index + header[0].length;+ create = `${create.slice(0, insertion)} DISABLE${create.slice(insertion)}`;+ }+ } else if (status !== "ENABLED") {+ throw new Error(`Trigger ${name} has an unknown enabled state.`);+ }+ return create;+}++function sourceIdentifier(value: string) {+ return value.startsWith('"') ? value.slice(1, -1).replaceAll('""', '"') : value.toUpperCase();+}++function tableDefinitionFingerprint(source: string, schema: string, name: string) {+ const syntax = maskTriggerCommentsAndStrings(source);+ const identifierToken = '("(?:""|[^"])+"|[A-Za-z_][A-Za-z0-9_$#]*)';+ const declaration = new RegExp(`^(\\s*CREATE\\s+(?:(?:GLOBAL|PRIVATE)\\s+TEMPORARY\\s+)?TABLE\\s+)${identifierToken}(?:\\s*\\.\\s*${identifierToken})?`, "i").exec(syntax);+ if (!declaration) throw new Error(`Table source for ${name} has no verifiable CREATE declaration.`);+ const qualified = declaration[3] !== undefined;+ const declaredOwner = qualified ? sourceIdentifier(declaration[2]!) : schema;+ const declaredName = sourceIdentifier(qualified ? declaration[3]! : declaration[2]!);+ if (declaredOwner !== schema || declaredName !== name) throw new Error(`Table source declares ${declaredOwner}.${declaredName}, not ${schema}.${name}.`);+ return source.slice(0, declaration.index) + `${declaration[1]}<TABLE>` + source.slice(declaration.index + declaration[0].length);+}++function tableSnapshotsMatch(expected: OracleTableSnapshot, actual: OracleTableSnapshot, schema: string, expectedName: string, actualName: string) {+ return (+ tableDefinitionFingerprint(expected.source, schema, expectedName) === tableDefinitionFingerprint(actual.source, schema, actualName) &&+ expected.grants === actual.grants &&+ expected.indexes === actual.indexes &&+ expected.indexColumns === actual.indexColumns &&+ expected.constraints === actual.constraints &&+ expected.constraintColumns === actual.constraintColumns &&+ expected.incomingForeignKeys === actual.incomingForeignKeys &&+ expected.boundTriggers === actual.boundTriggers+ );+}++function validateDependentDeclaration(source: string, schema: string, name: string, objectType: RewriteableDependentType) {+ const syntax = maskTriggerCommentsAndStrings(source);+ const identifierToken = '("(?:""|[^"])+"|[A-Za-z_][A-Za-z0-9_$#]*)';+ const declaration = new RegExp(`^\\s*CREATE\\s+(?:OR\\s+REPLACE\\s+)?(?:(?:FORCE|NOFORCE)\\s+)?(?:(?:NON)?EDITIONABLE\\s+)?${objectType}\\s+${identifierToken}(?:\\s*\\.\\s*${identifierToken})?`, "i").exec(syntax);+ if (!declaration) throw new Error(`${objectType} source has no verifiable CREATE declaration.`);+ const qualified = declaration[2] !== undefined;+ const declaredOwner = qualified ? sourceIdentifier(declaration[1]!) : schema;+ const declaredName = sourceIdentifier(qualified ? declaration[2]! : declaration[1]!);+ if (declaredOwner !== schema || declaredName !== name) throw new Error(`${objectType} source declares ${declaredOwner}.${declaredName}, not ${schema}.${name}.`);+ if ((syntax.match(/\bCREATE\b/gi) || []).length !== 1 || !/\bEND(?:\s+(?:"(?:""|[^"])+"|[A-Za-z_][A-Za-z0-9_$#]*))?\s*;\s*\/?\s*$/i.test(syntax)) {+ throw new Error(`${objectType} source must contain one complete CREATE statement for ${name}.`);+ }+ const bodyStart = objectType === "TRIGGER" ? /\bDECLARE\b|\bBEGIN\b/i.exec(syntax) : /\bAS\b|\bIS\b/i.exec(syntax);+ const firstBegin = bodyStart && objectType === "TRIGGER" && /^BEGIN$/i.test(bodyStart[0]) ? bodyStart : bodyStart ? /\bBEGIN\b/i.exec(syntax.slice(bodyStart.index + bodyStart[0].length)) : null;+ if (!bodyStart || !firstBegin) throw new Error(`${objectType} source has no verifiable PL/SQL body for ${name}.`);+ const tokens = [...syntax.matchAll(/\bBEGIN\b|\bEND\b(?:\s+(?:IF|LOOP|CASE)\b)?|[^\s;]+|;/gi)];+ let depth = 0;+ let bodyClosed = false;+ for (let index = 0; index < tokens.length; index++) {+ const token = tokens[index]![0];+ if (/^BEGIN$/i.test(token)) {+ if (bodyClosed) throw new Error(`${objectType} source contains statements after its CREATE body.`);+ depth++;+ } else if (/^END(?:\s+(?:IF|LOOP|CASE))?$/i.test(token) && !/\s+(?:IF|LOOP|CASE)$/i.test(token)) {+ depth--;+ if (depth < 0) throw new Error(`${objectType} source has an invalid PL/SQL block boundary.`);+ if (depth === 0) {+ bodyClosed = true;+ const tail = tokens+ .slice(index + 1)+ .map((entry) => entry[0])+ .filter((entry) => entry !== ";" && entry !== "/");+ if (tail.length > 1 || (tail.length === 1 && !/^(?:"(?:""|[^"])+"|[A-Za-z_][A-Za-z0-9_$#]*)$/.test(tail[0]!))) {+ throw new Error(`${objectType} source contains statements after its CREATE body.`);+ }+ if (tail.length === 1 && index + 2 < tokens.length && tokens[index + 2]![0] !== ";") {+ throw new Error(`${objectType} source contains statements after its CREATE body.`);+ }+ }+ }+ }+ if (!bodyClosed || depth !== 0) throw new Error(`${objectType} source has an incomplete PL/SQL body.`);+}++function tableRelations(source: string) {+ const syntax = maskTriggerCommentsAndStrings(source);+ const relations = new Set<string>();+ const identifierToken = '((?:"(?:""|[^"])+"|[A-Za-z_][A-Za-z0-9_$#]*)(?:\\s*\\.\\s*(?:"(?:""|[^"])+"|[A-Za-z_][A-Za-z0-9_$#]*))?)';+ const canonical = (reference: string) =>+ reference+ .match(/"(?:""|[^"])+"|[A-Za-z_][A-Za-z0-9_$#]*/g)!+ .map((part) => (part.startsWith('"') ? `Q:${part.slice(1, -1).replaceAll('""', '"')}` : `U:${part.toUpperCase()}`))+ .join(".");+ const pattern = new RegExp(`\\b(?:FROM|JOIN|UPDATE|ON)\\s+${identifierToken}`, "gi");+ for (const match of syntax.matchAll(pattern)) relations.add(canonical(match[1]!));+ const dml = new RegExp(`\\b(?:INSERT|MERGE)\\s+INTO\\s+${identifierToken}`, "gi");+ for (const match of syntax.matchAll(dml)) relations.add(canonical(match[1]!));+ const typeReference = new RegExp(`${identifierToken}\\s*%\\s*(?:TYPE|ROWTYPE)`, "gi");+ for (const match of syntax.matchAll(typeReference)) relations.add(canonical(match[1]!));+ return relations;+}++function validateDraftRelations(original: string, draft: string, schema: string, oldName: string, newName: string) {+ const rootSegments = new Set([`U:${oldName.toUpperCase()}`, `U:${newName.toUpperCase()}`, `Q:${oldName}`, `Q:${newName}`]);+ const ownerSegments = new Set([`U:${schema.toUpperCase()}`, `Q:${schema}`]);+ const normalize = (name: string) => {+ const parts = name.split(".");+ const hasAllowedOwner = parts.length === 1 || (parts.length === 2 && ownerSegments.has(parts[0]!));+ return hasAllowedOwner && rootSegments.has(parts[parts.length - 1]!) ? "ROOT_TABLE" : name;+ };+ const expected = new Set([...tableRelations(original)].map(normalize));+ const actual = new Set([...tableRelations(draft)].map(normalize));+ const unexpected = [...actual].filter((name) => !expected.has(name) && name !== "ROOT_TABLE");+ const removed = [...expected].filter((name) => !actual.has(name) && name !== "ROOT_TABLE");+ const calls = (source: string) => {+ const syntax = maskTriggerCommentsAndStrings(source);+ const ignored = new Set([+ "IF",+ "IN",+ "EXISTS",+ "VALUES",+ "CAST",+ "TABLE",+ "SELECT",+ "FROM",+ "AS",+ "CASE",+ "WHEN",+ "OVER",+ "PARTITION",+ "WITH",+ "PRIOR",+ "COUNT",+ "SUM",+ "AVG",+ "MIN",+ "MAX",+ "NVL",+ "NVL2",+ "COALESCE",+ "DECODE",+ "TO_CHAR",+ "TO_DATE",+ "TO_NUMBER",+ "SUBSTR",+ "TRIM",+ "UPPER",+ "LOWER",+ "ROUND",+ "ABS",+ "LENGTH",+ "INSTR",+ "EXTRACT",+ "JSON_VALUE",+ "JSON_QUERY",+ "LISTAGG",+ "ROW_NUMBER",+ "RANK",+ "DENSE_RANK",+ ]);+ const identifier = '(?:"(?:""|[^"])+"|[A-Za-z_][A-Za-z0-9_$#]*)';+ const canonical = (reference: string) =>+ reference+ .match(/"(?:""|[^"])+"|[A-Za-z_][A-Za-z0-9_$#]*/g)!+ .map((part) => (part.startsWith('"') ? `Q:${part.slice(1, -1).replaceAll('""', '"')}` : `U:${part.toUpperCase()}`))+ .join(".");+ const found = new Set([...syntax.matchAll(new RegExp(`${identifier}(?:\\s*\\.\\s*${identifier})*\\s*\\(`, "g"))].map((match) => canonical(match[0]!.replace(/\s*\($/, ""))));+ const noArgStatement = new Set(+ [...syntax.matchAll(new RegExp(`(?:\\bBEGIN\\b|\\bTHEN\\b|\\bELSE\\b|\\bLOOP\\b|(;))\\s*(${identifier}(?:\\s*\\.\\s*${identifier})*)\\s*(?=;)`, "gi"))]+ .map((match) => canonical(match[2]!))+ .filter((name) => !new Set(["U:END", "U:NULL", "U:RETURN", "U:THEN", "U:ELSE", "U:COMMIT", "U:ROLLBACK"]).has(name)),+ );+ for (const name of noArgStatement) found.add(name);+ return new Set([...found].filter((name) => (!name.includes(".") && name.startsWith("U:") ? !ignored.has(name.slice(2)) : true)));+ };+ const originalCalls = calls(original);+ const draftCalls = calls(draft);+ const changedCalls = [...originalCalls].filter((name) => !draftCalls.has(name)).concat([...draftCalls].filter((name) => !originalCalls.has(name)));+ if (unexpected.length || removed.length || changedCalls.length)+ throw new Error(`The draft changes planned dependencies${unexpected.length ? `; adds ${unexpected.join(", ")}` : ""}${removed.length ? `; removes ${removed.join(", ")}` : ""}${changedCalls.length ? `; changes calls ${changedCalls.join(", ")}` : ""}.`);+}++interface DependentSnapshot extends Omit<OracleTableRenameDependent, "draft" | "rewrittenSource" | "fingerprint" | "originalFingerprint" | "rewriteRequired"> {+ executionSource: string;+}++async function readSnapshot(target: OracleTableRenameTarget, name: string, objectType: DependentType): Promise<DependentSnapshot> {+ const states = await objectStates(target, name, [objectType]);+ if (states.length !== 1 || states[0][0] !== objectType || states[0][1] == null || states[0][2] == null) throw new Error(`${objectType} ${name} is missing or has an ambiguous identity.`);+ const source = await readSource(target, objectType, name);+ const grants = await readGrants(target, name);+ const errors = await readErrors(target, name, objectType);+ const trigger = objectType === "TRIGGER" ? await readTrigger(target, name) : undefined;+ const executionSource = trigger ? executableTriggerSource(source, target.schema, name, trigger.status) : source;+ return {+ name,+ objectType,+ objectId: String(states[0][1]),+ source,+ executionSource,+ status: String(states[0][2]),+ grants,+ errors,+ ...(trigger ? { triggerStatus: trigger.status, triggerTable: trigger.table } : {}),+ };+}++async function readDependents(target: OracleTableRenameTarget, name: string, objectType: ObjectType) {+ const suffix = ` WHERE REFERENCED_OWNER=${literal(target.schema)} AND REFERENCED_NAME=${literal(name)} AND REFERENCED_TYPE=${literal(objectType)}`;+ const columns = "SELECT OWNER, NAME, TYPE, REFERENCED_LINK_NAME FROM ";+ try {+ return (await query(target, `${columns}SYS.DBA_DEPENDENCIES${suffix}`)).rows;+ } catch (error) {+ if (!/ORA-00942|ORA-01031/.test(errorMessage(error))) throw error;+ return (await query(target, `${columns}SYS.ALL_DEPENDENCIES${suffix}`)).rows;+ }+}++function issue(issues: OracleTableRenameIssue[], code: string, message: string, objectName?: string, repairable = false) {+ issues.push({ code, message, objectName, repairable });+}++function objectKey(name: string, type: ObjectType) {+ return `${type}:${name}`;+}++function orderDependents(names: Map<string, { name: string; type: DependentType }>, edges: string[], schema: string) {+ const indegree = new Map([...names.keys()].map((key) => [key, 0]));+ const outgoing = new Map([...names.keys()].map((key) => [key, new Set<string>()]));+ for (const edge of edges) {+ const [referencedName, referencedType, owner, dependentName, dependentType, link] = JSON.parse(edge) as [string, ObjectType, string, string, DependentType, string | null];+ if (owner !== schema || link) continue;+ const from = objectKey(referencedName, referencedType);+ const to = objectKey(dependentName, dependentType);+ if (!indegree.has(to) || !outgoing.has(to)) continue;+ if (indegree.has(from) && from !== to && !outgoing.get(from)!.has(to)) {+ outgoing.get(from)!.add(to);+ indegree.set(to, indegree.get(to)! + 1);+ }+ }+ const compare = (left: string, right: string) => left.localeCompare(right);+ const ready = [...indegree]+ .filter(([, count]) => count === 0)+ .map(([key]) => key)+ .sort(compare);+ const ordered: string[] = [];+ while (ready.length) {+ const key = ready.shift()!;+ ordered.push(key);+ for (const child of outgoing.get(key)!) {+ indegree.set(child, indegree.get(child)! - 1);+ if (indegree.get(child) === 0) {+ ready.push(child);+ ready.sort(compare);+ }+ }+ }+ return ordered;+}++function normalizeEdgesForRenamedTable(edges: string[], oldName: string, newName: string) {+ return edges+ .map((edge) => {+ const [referencedName, referencedType, owner, dependentName, dependentType, link] = JSON.parse(edge) as [string, ObjectType, string, string, DependentType, string | null];+ return JSON.stringify([referencedType === "TABLE" && referencedName === oldName ? newName : referencedName, referencedType, owner, dependentName, dependentType, link]);+ })+ .sort();+}++async function canonicalTableSource(objectType: RewriteableDependentType, source: string, tableName: string, schema: string, databaseType: OracleTableRenameTarget["databaseType"]) {+ const marker = "DBX_TABLE_RENAME_FINGERPRINT_MARKER";+ const marked = await api.rewriteOracleTableReferences({ databaseType, objectType, schema, oldName: tableName, newName: marker, source });+ return api.rewriteOracleTableReferences({ databaseType, objectType, schema, oldName: marker, newName: tableName, source: marked });+}++async function sourceAfterEngineRename(objectType: RewriteableDependentType, source: string, oldName: string, newName: string, schema: string, databaseType: OracleTableRenameTarget["databaseType"]) {+ let withNewName = source;+ try {+ withNewName = await api.rewriteOracleTableReferences({ databaseType, objectType, schema, oldName, newName, source });+ } catch {+ // A trigger may already have its ON binding rewritten by RENAME while+ // remaining source references still use the old table name.+ }+ return canonicalTableSource(objectType, withNewName, newName, schema, databaseType);+}++function planIdentity(plan: OracleTableRenamePlan) {+ return JSON.stringify([+ plan.target,+ plan.canonicalNewName,+ plan.tableObjectId,+ plan.tableSnapshot,+ plan.dependencyEdges,+ plan.issues,+ plan.metadataComplete,+ plan.dependents.map((item) => [item.name, item.objectType, item.objectId, item.source, item.status, item.grants, item.errors, item.triggerStatus, item.triggerTable, item.draft, item.fingerprint, item.originalFingerprint, item.rewriteRequired]),+ plan.steps,+ ]);+}++export async function prepareOracleTableRename(target: OracleTableRenameTarget, drafts: Record<string, string> = {}): Promise<OracleTableRenamePlan> {+ target = { ...target };+ const plan: OracleTableRenamePlan = { target, canonicalNewName: target.newName, tableObjectId: "", tableSnapshot: null, dependents: [], dependencyEdges: [], issues: [], metadataComplete: true, executable: false, steps: [], statements: [] };+ try {+ plan.canonicalNewName = await api.parseOracleObjectName(target.newName);+ if (plan.canonicalNewName === target.oldName) issue(plan.issues, "invalid_name", "The new name matches the existing table name.");+ await checkOwner(target);+ const [oldState, newState] = await Promise.all([objectStates(target, target.oldName, ["TABLE"]), objectStates(target, plan.canonicalNewName, tableNamespaceTypes)]);+ if (oldState.length !== 1 || oldState[0][0] !== "TABLE" || oldState[0][1] == null) throw new Error(`Table ${target.oldName} is missing or has an ambiguous identity.`);+ plan.tableObjectId = String(oldState[0][1]);+ plan.tableSnapshot = await readTableSnapshot(target, target.oldName);+ if (newState.length) issue(plan.issues, "target_conflict", `An object named ${plan.canonicalNewName} already exists.`);+ } catch (error) {+ plan.metadataComplete = false;+ issue(plan.issues, /owner|current schema/i.test(errorMessage(error)) ? "owner_mismatch" : "metadata_incomplete", errorMessage(error));+ }++ const objects = new Map<string, { name: string; type: DependentType }>();+ if (plan.tableSnapshot) {+ for (const [triggerName] of JSON.parse(plan.tableSnapshot.boundTriggers) as unknown[][]) {+ const name = String(triggerName);+ const key = objectKey(name, "TRIGGER");+ if (!objects.has(key)) objects.set(key, { name, type: "TRIGGER" });+ }+ }+ const edges: string[] = [];+ const pending: Array<{ name: string; type: ObjectType }> = [{ name: target.oldName, type: "TABLE" }];+ const visited = new Set<string>();+ while (pending.length && plan.metadataComplete) {+ const reference = pending.shift()!;+ const refKey = objectKey(reference.name, reference.type);+ if (visited.has(refKey)) continue;+ if (visited.size >= metadataLimit) {+ plan.metadataComplete = false;+ issue(plan.issues, "dependency_incomplete", "The visible dependency graph exceeds the safe metadata limit.");+ break;+ }+ visited.add(refKey);+ let rows: unknown[][];+ try {+ rows = await readDependents(target, reference.name, reference.type);+ } catch (error) {+ plan.metadataComplete = false;+ issue(plan.issues, "dependency_read_failed", errorMessage(error), reference.name);+ break;+ }+ for (const row of rows) {+ const [owner, dependentName, dependentType, link] = row;+ if (typeof owner !== "string" || typeof dependentName !== "string" || typeof dependentType !== "string") {+ plan.metadataComplete = false;+ issue(plan.issues, "dependency_incomplete", `Dependency metadata for ${reference.name} is incomplete.`, reference.name);+ continue;+ }+ edges.push(JSON.stringify([reference.name, reference.type, owner, dependentName, dependentType, typeof link === "string" ? link : null]));+ if (owner !== target.schema || link || !acceptedTypes.has(dependentType as DependentType)) {+ issue(plan.issues, "unsupported_dependency", `Cannot automatically update dependent ${owner}.${dependentName} (${dependentType}${link ? `@${String(link)}` : ""}).`, dependentName);+ continue;+ }+ const type = dependentType as DependentType;+ const key = objectKey(dependentName, type);+ if (!objects.has(key)) objects.set(key, { name: dependentName, type });+ pending.push({ name: dependentName, type });+ }+ }+ plan.dependencyEdges = edges.sort();+ const order = orderDependents(objects, plan.dependencyEdges, target.schema);+ if (order.length !== objects.size) issue(plan.issues, "dependency_cycle", "The visible dependent graph contains a cycle that cannot be ordered safely.", target.oldName);++ for (const key of order) {+ const object = objects.get(key)!;+ let snapshot: DependentSnapshot;+ try {+ snapshot = await readSnapshot(target, object.name, object.type);+ if (snapshot.status !== "VALID" || snapshot.errors !== "[]") throw new Error(`${object.type} ${object.name} is not valid or has compilation errors.`);+ if (snapshot.objectType === "TRIGGER" && snapshot.triggerTable !== target.oldName) throw new Error(`Trigger ${object.name} is not bound to ${target.oldName}.`);+ } catch (error) {+ plan.metadataComplete = false;+ issue(plan.issues, "source_read_failed", errorMessage(error), object.name);+ continue;+ }+ const draft = drafts[object.name] ?? snapshot.executionSource;+ let rewrittenSource = "";+ let fingerprint = "";+ let originalFingerprint = "";+ const directDependency = plan.dependencyEdges.some((edge) => {+ const [referencedName, referencedType, owner, name, type] = JSON.parse(edge) as [string, ObjectType, string, string, DependentType];+ return referencedName === target.oldName && referencedType === "TABLE" && owner === target.schema && name === object.name && type === object.type;+ });+ try {+ if (object.type === "VIEW") {+ const originalReview = await api.reviewOracleViewRenameSource({ source: snapshot.source, owner: target.schema, viewName: object.name, oldName: target.oldName, newName: target.oldName });+ const review = await api.reviewOracleViewRenameSource({ source: draft, owner: target.schema, viewName: object.name, oldName: target.oldName, newName: directDependency ? plan.canonicalNewName : target.oldName });+ plan.issues.push(...review.issues.map((entry: OracleViewRenameIssue) => ({ code: entry.code, message: entry.message, objectName: object.name, repairable: entry.repairable })));+ const normalizeReferences = (references: typeof review.references) => references.map((reference) => JSON.stringify([reference.owner, reference.name === plan.canonicalNewName ? target.oldName : reference.name])).sort();+ const originalParseFailed = !originalReview.source && originalReview.issues.some((entry: OracleViewRenameIssue) => entry.code === "invalid_definition" || entry.code === "invalid_declaration");+ if (!review.source) throw new Error(review.issues.map((entry: OracleViewRenameIssue) => entry.message).join("; ") || `Cannot validate ${object.name}.`);+ if (originalReview.source) {+ plan.issues.push(...originalReview.issues.map((entry: OracleViewRenameIssue) => ({ code: entry.code, message: entry.message, objectName: object.name, repairable: entry.repairable })));+ if (JSON.stringify(normalizeReferences(originalReview.references)) !== JSON.stringify(normalizeReferences(review.references))) throw new Error(`The definition of ${object.name} changes its planned dependencies.`);+ } else if (originalParseFailed) {+ if (!directDependency && draft !== snapshot.executionSource) throw new Error(`A manual draft for indirect dependent ${object.name} cannot be applied by the planned compile step.`);+ const plannedNames = new Set([target.oldName, ...order.map((plannedKey) => objects.get(plannedKey)!.name)]);+ const expected = [+ ...new Set(+ edges+ .map((edge) => JSON.parse(edge) as [string, ObjectType, string, string, DependentType, string | null])+ .filter(([, , owner, name]) => owner === target.schema && name === object.name)+ .map(([name, , owner]) => JSON.stringify([owner, name])),+ ),+ ].sort();+ const actual = [+ ...new Set(+ review.references+ .filter((reference) => reference.owner === target.schema && plannedNames.has(reference.name === plan.canonicalNewName ? target.oldName : reference.name))+ .map((reference) => JSON.stringify([reference.owner, reference.name === plan.canonicalNewName ? target.oldName : reference.name])),+ ),+ ].sort();+ if (JSON.stringify(expected) !== JSON.stringify(actual)) issue(plan.issues, "manual_graph", `The proposed definition changes planned dependencies of ${object.name}.`, object.name, true);+ } else {+ plan.issues.push(...originalReview.issues.map((entry: OracleViewRenameIssue) => ({ code: entry.code, message: entry.message, objectName: object.name, repairable: entry.repairable })));+ throw new Error([...originalReview.issues, ...review.issues].map((entry: OracleViewRenameIssue) => entry.message).join("; ") || `Cannot validate ${object.name}.`);+ }+ const bindsOldTable = review.references.some((reference) => reference.owner === target.schema && reference.name === target.oldName);+ if (directDependency !== bindsOldTable) throw new Error(`The definition of ${object.name} does not match its direct table dependency.`);+ rewrittenSource = review.source.source;+ const rewrittenReview = await api.reviewOracleViewRenameSource({ source: rewrittenSource, owner: target.schema, viewName: object.name, oldName: plan.canonicalNewName, newName: plan.canonicalNewName });+ if (!rewrittenReview.source || rewrittenReview.issues.length || JSON.stringify(normalizeReferences(rewrittenReview.references)) !== JSON.stringify(normalizeReferences(review.references))) {+ throw new Error(`The rewritten definition of ${object.name} does not preserve its planned references.`);+ }+ fingerprint = review.source.fingerprint;+ originalFingerprint = originalReview.source?.fingerprint ?? "";+ } else {+ if (directDependency) {+ validateDependentDeclaration(draft, target.schema, object.name, object.type);+ validateDraftRelations(snapshot.executionSource, draft, target.schema, target.oldName, plan.canonicalNewName);+ rewrittenSource = await api.rewriteOracleTableReferences({ databaseType: target.databaseType, objectType: object.type, schema: target.schema, oldName: target.oldName, newName: plan.canonicalNewName, source: draft });+ fingerprint = await canonicalTableSource(object.type, rewrittenSource, plan.canonicalNewName, target.schema, target.databaseType);+ } else {+ rewrittenSource = draft;+ fingerprint = draft;+ }+ }+ } catch (error) {+ const message = errorMessage(error);+ const location = /line (\d+), column (\d+)/i.exec(message);+ plan.issues.push({ code: "source_rewrite_failed", message, objectName: object.name, repairable: true, ...(location ? { location: { line: Number(location[1]), column: Number(location[2]) } } : {}) });+ }+ plan.dependents.push({ ...snapshot, draft, rewrittenSource, fingerprint, originalFingerprint, rewriteRequired: directDependency });+ }++ if (plan.metadataComplete && plan.issues.length === 0) {+ plan.steps = [+ { kind: "rename", objectName: target.oldName, objectType: "TABLE", sql: `RENAME ${identifier(target.oldName)} TO ${identifier(plan.canonicalNewName)};` },+ ...plan.dependents.map((dependent) =>+ dependent.rewriteRequired+ ? { kind: "replace" as const, objectName: dependent.name, objectType: dependent.objectType, sql: dependent.rewrittenSource }+ : { kind: "compile" as const, objectName: dependent.name, objectType: dependent.objectType, sql: `ALTER ${dependent.objectType} ${identifier(target.schema)}.${identifier(dependent.name)} COMPILE;` },+ ),+ ];+ plan.statements = plan.steps.map((step) => step.sql);+ plan.executable = true;+ }+ return plan;+}++async function readTableIdentity(target: OracleTableRenameTarget, name: string) {+ const rows = await objectStates(target, name, ["TABLE"]);+ return rows.length === 1 && rows[0][0] === "TABLE" && rows[0][1] != null ? String(rows[0][1]) : null;+}++async function nameIsOccupied(target: OracleTableRenameTarget, name: string) {+ return (await objectStates(target, name, tableNamespaceTypes)).length > 0;+}++async function verifyGraph(target: OracleTableRenameTarget, plan: OracleTableRenamePlan) {+ const references: Array<{ name: string; type: ObjectType }> = [{ name: plan.canonicalNewName, type: "TABLE" }, ...plan.dependents.map((item) => ({ name: item.name, type: item.objectType }))];+ const actual: string[] = [];+ for (const reference of references) {+ for (const [owner, name, type, link] of await readDependents(target, reference.name, reference.type)) {+ actual.push(JSON.stringify([reference.name, reference.type, owner, name, type, typeof link === "string" ? link : null]));+ }+ }+ const expected = normalizeEdgesForRenamedTable(plan.dependencyEdges, plan.target.oldName, plan.canonicalNewName);+ if (JSON.stringify(actual.sort()) !== JSON.stringify(expected)) throw new Error("The visible dependency graph changed during table rename.");+}++async function verifyOriginalGraph(target: OracleTableRenameTarget, plan: OracleTableRenamePlan) {+ const references: Array<{ name: string; type: ObjectType }> = [{ name: plan.target.oldName, type: "TABLE" }, ...plan.dependents.map((item) => ({ name: item.name, type: item.objectType }))];+ const actual: string[] = [];+ for (const reference of references) {+ for (const [owner, name, type, link] of await readDependents(target, reference.name, reference.type)) {+ actual.push(JSON.stringify([reference.name, reference.type, owner, name, type, typeof link === "string" ? link : null]));+ }+ }+ if (JSON.stringify(actual.sort()) !== JSON.stringify([...plan.dependencyEdges].sort())) throw new Error("The visible dependency graph changed before table rename.");+}++async function verifyOriginalSnapshots(target: OracleTableRenameTarget, plan: OracleTableRenamePlan) {+ if (!plan.tableSnapshot || !tableSnapshotsMatch(plan.tableSnapshot, await readTableSnapshot(target, plan.target.oldName), target.schema, plan.target.oldName, plan.target.oldName)) {+ throw new Error("The original table definition, grants, indexes, constraints, foreign keys, or triggers changed before rename.");+ }+ for (const dependent of plan.dependents) {+ const actual = await readSnapshot(target, dependent.name, dependent.objectType);+ if (+ actual.objectId !== dependent.objectId ||+ actual.source !== dependent.source ||+ actual.status !== dependent.status ||+ actual.grants !== dependent.grants ||+ actual.errors !== dependent.errors ||+ actual.triggerStatus !== dependent.triggerStatus ||+ actual.triggerTable !== dependent.triggerTable+ ) {+ throw new Error(`${dependent.objectType} ${dependent.name} changed before table rename.`);+ }+ }+}++async function verifyFinalSnapshots(target: OracleTableRenameTarget, plan: OracleTableRenamePlan) {+ if (!plan.tableSnapshot || !tableSnapshotsMatch(plan.tableSnapshot, await readTableSnapshot(target, plan.canonicalNewName), target.schema, plan.target.oldName, plan.canonicalNewName)) {+ throw new Error("The renamed table definition, grants, indexes, constraints, foreign keys, or triggers changed before final verification.");+ }+ if ((await readTableIdentity(target, plan.canonicalNewName)) !== plan.tableObjectId || (await readTableIdentity(target, plan.target.oldName)) !== null) {+ throw new Error("The renamed table identity changed before final verification.");+ }+ if (await nameIsOccupied(target, plan.target.oldName)) throw new Error("The old table name was reused before final verification.");+ for (const dependent of plan.dependents) {+ const actual = await readSnapshot(target, dependent.name, dependent.objectType);+ if (actual.objectId !== dependent.objectId || actual.status !== "VALID" || actual.errors !== "[]" || actual.grants !== dependent.grants) {+ throw new Error(`${dependent.objectType} ${dependent.name} changed before final verification.`);+ }+ if (dependent.objectType === "TRIGGER" && (actual.triggerTable !== plan.canonicalNewName || actual.triggerStatus !== dependent.triggerStatus)) {+ throw new Error(`Trigger ${dependent.name} binding or enabled state changed before final verification.`);+ }+ const fingerprint =+ dependent.objectType === "VIEW"+ ? (+ await api.reviewOracleViewRenameSource({+ source: actual.source,+ owner: target.schema,+ viewName: dependent.name,+ oldName: dependent.rewriteRequired ? plan.canonicalNewName : plan.target.oldName,+ newName: dependent.rewriteRequired ? plan.canonicalNewName : plan.target.oldName,+ })+ ).source?.fingerprint+ : dependent.rewriteRequired+ ? await canonicalTableSource(dependent.objectType, actual.executionSource, plan.canonicalNewName, target.schema, target.databaseType)+ : actual.source;+ if (fingerprint !== dependent.fingerprint) throw new Error(`${dependent.objectType} ${dependent.name} definition changed before final verification.`);+ }+ await verifyGraph(target, plan);+}++async function readOnlyReconcile(target: OracleTableRenameTarget, plan: OracleTableRenamePlan, step: OracleTableRenameStep) {+ try {+ if (step.kind === "rename") {+ const newId = await readTableIdentity(target, plan.canonicalNewName);+ const oldId = await readTableIdentity(target, plan.target.oldName);+ if (newId === plan.tableObjectId && oldId === null) return "confirmed" as const;+ if (newId === null && oldId === plan.tableObjectId) return "not-confirmed" as const;+ return "unknown" as const;+ }+ const dependent = plan.dependents.find((item) => item.name === step.objectName && item.objectType === step.objectType)!;+ const actual = await readSnapshot(target, dependent.name, dependent.objectType);+ if (step.kind === "compile") {+ return actual.objectId === dependent.objectId && actual.source === dependent.source && actual.status === "VALID" && actual.errors === "[]" && actual.grants === dependent.grants ? ("confirmed" as const) : ("unknown" as const);+ }+ if (+ actual.status === "VALID" &&+ actual.errors === "[]" &&+ actual.grants === dependent.grants &&+ (dependent.objectType !== "TRIGGER" || (actual.triggerTable === plan.canonicalNewName && actual.triggerStatus === dependent.triggerStatus)) &&+ (dependent.objectType === "VIEW"+ ? (await api.reviewOracleViewRenameSource({ source: actual.source, owner: plan.target.schema, viewName: dependent.name, oldName: plan.canonicalNewName, newName: plan.canonicalNewName })).source?.fingerprint === dependent.fingerprint+ : (await canonicalTableSource(dependent.objectType, actual.executionSource, plan.canonicalNewName, plan.target.schema, plan.target.databaseType)) === dependent.fingerprint)+ )+ return "confirmed" as const;+ if (actual.objectId === dependent.objectId && actual.source === dependent.source) return "not-confirmed" as const;+ return "unknown" as const;+ } catch {+ return "unknown" as const;+ }+}++export async function executeOracleTableRename(plan: OracleTableRenamePlan, drafts: Record<string, string> = {}, isCurrent: () => boolean = () => true): Promise<void> {+ if (!isCurrent()) throw new Error("The table rename target changed. Refresh the preview.");+ if (!plan.executable) throw new Error("Resolve every table dependency issue before execution.");+ const current = await prepareOracleTableRename(plan.target, drafts);+ if (!current.executable || planIdentity(current) !== planIdentity(plan) || !isCurrent()) throw new Error("Table metadata changed. Refresh the rename preview.");+ const frozen = freezeSourceIdentities([+ { connectionId: plan.target.connectionId, database: plan.target.database, schema: plan.target.schema, objectType: "TABLE" as const, name: plan.target.oldName },+ ...plan.dependents.map((item) => ({ connectionId: plan.target.connectionId, database: plan.target.database, schema: plan.target.schema, objectType: item.objectType, name: item.name })),+ ]);+ const completed: string[] = [];+ let dispatched = false;+ let active = plan.steps[0];+ try {+ for (const step of plan.steps) {+ active = step;+ if (!isCurrent()) throw new Error("The rename dialog changed or closed; remaining steps were not sent.");+ const expectedTableId = await readTableIdentity(plan.target, step.kind === "rename" ? plan.target.oldName : plan.canonicalNewName);+ if (expectedTableId !== plan.tableObjectId) throw new Error("The original table identity changed during rename.");+ if (step.kind === "rename") {+ if (await nameIsOccupied(plan.target, plan.canonicalNewName)) throw new Error("The target table name was claimed by another session.");+ await verifyOriginalSnapshots(plan.target, plan);+ await verifyOriginalGraph(plan.target, plan);+ } else {+ if (await nameIsOccupied(plan.target, plan.target.oldName)) throw new Error("The old table name was reused by another object.");+ await verifyGraph(plan.target, plan);+ const dependent = plan.dependents.find((item) => item.name === step.objectName && item.objectType === step.objectType)!;+ const latest = await readSnapshot(plan.target, dependent.name, dependent.objectType);+ const expectedStatus = dependent.objectType === "VIEW" ? "INVALID" : dependent.status;+ if (latest.objectId !== dependent.objectId || latest.grants !== dependent.grants || (step.kind === "replace" && latest.status !== expectedStatus) || (step.kind === "compile" && (!["VALID", "INVALID"].includes(latest.status) || latest.source !== dependent.source)))+ throw new Error(`${dependent.objectType} ${dependent.name} changed after validation.`);+ if (dependent.objectType === "TRIGGER") {+ if (latest.triggerTable !== plan.canonicalNewName || latest.triggerStatus !== dependent.triggerStatus) throw new Error(`Trigger ${dependent.name} binding or enabled state changed after table rename.`);+ }+ const expectedFingerprint = dependent.objectType === "VIEW" ? dependent.originalFingerprint : dependent.fingerprint;+ if (step.kind === "replace" && dependent.objectType === "VIEW" && !expectedFingerprint && latest.source !== dependent.source) throw new Error(`${dependent.objectType} ${dependent.name} source changed after validation.`);+ if (step.kind === "compile") {+ if (latest.source !== dependent.source) throw new Error(`${dependent.objectType} ${dependent.name} source changed after validation.`);+ } else if (dependent.objectType !== "TRIGGER" && latest.source === dependent.source) {+ // RENAME does not rewrite stored routine source. Preserve the exact+ // original snapshot check when its unsupported syntax prevented a+ // canonical reference fingerprint; the validated draft is still+ // the only source sent by the following replace step.+ } else {+ const latestFingerprint =+ dependent.objectType === "VIEW"+ ? ((await api.reviewOracleViewRenameSource({ source: latest.source, owner: plan.target.schema, viewName: dependent.name, oldName: plan.target.oldName, newName: plan.target.oldName })).source?.fingerprint ?? "")+ : await sourceAfterEngineRename(dependent.objectType, latest.executionSource, plan.target.oldName, plan.canonicalNewName, plan.target.schema, plan.target.databaseType);+ if (latestFingerprint !== expectedFingerprint) throw new Error(`${dependent.objectType} ${dependent.name} source changed after validation.`);+ }+ }+ if (!isCurrent()) throw new Error("The rename dialog changed or closed; remaining steps were not sent.");+ if (!dispatched) {+ frozen.markDispatched();+ dispatched = true;+ }+ try {+ await query(plan.target, step.sql);+ } catch (error) {+ const reconciliation = await readOnlyReconcile(plan.target, plan, step);+ throw new OracleTableRenameFailure(plan, completed, `${step.objectType} ${step.objectName}`, reconciliation, error);+ }++ if (step.kind === "rename") {+ const newId = await readTableIdentity(plan.target, plan.canonicalNewName);+ const oldId = await readTableIdentity(plan.target, plan.target.oldName);+ if (newId !== plan.tableObjectId || oldId !== null) throw new Error("The table rename did not preserve the original identity at the new name.");+ await verifyGraph(plan.target, plan);+ completed.push(`TABLE ${plan.canonicalNewName}`);+ continue;+ }++ const dependent = plan.dependents.find((item) => item.name === step.objectName && item.objectType === step.objectType)!;+ const actual = await readSnapshot(plan.target, dependent.name, dependent.objectType);+ if (actual.status !== "VALID" || actual.errors !== "[]" || actual.grants !== dependent.grants) throw new Error(`${dependent.objectType} ${dependent.name} did not preserve validity, errors, and grants.`);+ if (dependent.objectType === "TRIGGER" && (actual.triggerTable !== plan.canonicalNewName || actual.triggerStatus !== dependent.triggerStatus)) throw new Error(`Trigger ${dependent.name} did not preserve table binding and enabled state.`);+ if (step.kind === "compile") {+ if (actual.objectId !== dependent.objectId || actual.source !== dependent.source) throw new Error(`${dependent.objectType} ${dependent.name} did not retain its validated identity and definition after compilation.`);+ await verifyGraph(plan.target, plan);+ completed.push(`${dependent.objectType} ${dependent.name}`);+ continue;+ }+ const actualFingerprint =+ dependent.objectType === "VIEW"+ ? (await api.reviewOracleViewRenameSource({ source: actual.source, owner: plan.target.schema, viewName: dependent.name, oldName: plan.canonicalNewName, newName: plan.canonicalNewName })).source?.fingerprint+ : await canonicalTableSource(dependent.objectType, actual.executionSource, plan.canonicalNewName, plan.target.schema, plan.target.databaseType);+ if (actualFingerprint !== dependent.fingerprint) throw new Error(`${dependent.objectType} ${dependent.name} does not match the approved replacement source.`);+ if (dependent.objectType === "VIEW") dependent.objectId = actual.objectId;+ else if (actual.objectId !== dependent.objectId) throw new Error(`${dependent.objectType} ${dependent.name} identity changed unexpectedly.`);+ await verifyGraph(plan.target, plan);+ completed.push(`${dependent.objectType} ${dependent.name}`);+ }+ await verifyFinalSnapshots(plan.target, plan);+ } catch (error) {+ if (error instanceof OracleTableRenameFailure) throw error;+ if (dispatched) {+ const reconciliation = await readOnlyReconcile(plan.target, plan, active);+ throw new OracleTableRenameFailure(plan, completed, `${active.objectType} ${active.objectName}`, reconciliation, error);+ }+ throw error;+ } finally {+ if (dispatched) {+ const scope = { connectionId: plan.target.connectionId, database: plan.target.database, schema: plan.target.schema };+ invalidateObjectBrowserRowsCache(scope);+ await Promise.allSettled([...new Set([plan.target.oldName, plan.canonicalNewName, ...plan.dependents.map((item) => item.name)])].map((tableName) => invalidateObjectDdlCache({ ...scope, tableName })));+ frozen.finish();+ } else frozen.cancel();+ }+}diff --git a/apps/desktop/src/lib/table/oracleViewRename.ts b/apps/desktop/src/lib/table/oracleViewRename.tsnew file mode 100644index 0000000000..20b81edede--- /dev/null+++ b/apps/desktop/src/lib/table/oracleViewRename.ts@@ -0,0 +1,339 @@+import * as api from "@/lib/backend/api";+import { BackendErrorException } from "@/lib/backend/errorUtils";+import { freezeSourceIdentities } from "@/lib/table/objectSourceIdentity";+import { invalidateObjectDdlCache } from "@/lib/metadata/objectDdlCache";+import { invalidateObjectBrowserRowsCache } from "@/lib/table/objectBrowserRowsCache";+import type { OracleViewRenameIssue, OracleViewRenameSource } from "@/types/database";+import type { QueryResult } from "@/types/database";++export interface OracleViewRenameTarget {+ connectionId: string;+ database: string;+ schema: string;+ oldName: string;+ newName: string;+}++interface ViewSnapshot {+ name: string;+ source: string;+ fingerprint: string;+ rewrittenSource: string;+ rewrittenFingerprint: string;+ grants: string;+ draft: string;+ references: { owner: string; name: string }[];+}++export interface OracleViewRenameStep {+ kind: "replace" | "rename";+ viewName: string;+ sql: string;+ expectedFingerprint?: string;+}++export interface OracleViewRenamePlan {+ target: OracleViewRenameTarget;+ canonicalNewName: string;+ coverage: "visible-only";+ statements: string[];+ views: ViewSnapshot[];+ dependencyEdges: string[];+ issues: OracleViewRenameIssue[];+ metadataComplete: boolean;+ executable: boolean;+ steps: OracleViewRenameStep[];+}++export class OracleViewRenameFailure extends Error {+ constructor(+ public readonly plan: OracleViewRenamePlan,+ public readonly completed: string[],+ public readonly uncertain: string,+ cause: unknown,+ ) {+ super(`View rename stopped. Confirmed: ${completed.join(", ") || "none"}. Check the database state of ${uncertain} before retrying. ${String(cause instanceof Error ? cause.message : cause)}`);+ }+}++const literal = (value: string) => `'${value.replaceAll("'", "''")}'`;+const identifier = (value: string) => `"${value.replaceAll('"', '""')}"`;+const metadataLimit = 5000;++async function query(target: OracleViewRenameTarget, sql: string): Promise<QueryResult> {+ const result = await api.executeQuery(target.connectionId, target.database, sql, target.schema, undefined, { maxRows: metadataLimit + 1 });+ if (result.execution_error) throw new BackendErrorException(result.error || "Metadata query failed.");+ if (result.truncated || result.has_more || result.rows.length > metadataLimit || result.large_value_cells?.length) {+ throw new Error("Metadata is incomplete; refresh with a complete definition before renaming.");+ }+ return result;+}++async function checkOwner(target: OracleViewRenameTarget) {+ const result = await query(target, "SELECT USER, SYS_CONTEXT('USERENV','CURRENT_SCHEMA') FROM DUAL");+ if (result.rows.length !== 1 || result.rows[0][0] !== target.schema || result.rows[0][1] !== target.schema) {+ throw new Error("View rename requires the object's owner and matching current schema.");+ }+}++async function objectState(target: OracleViewRenameTarget, name: string) {+ return (await query(target, `SELECT OBJECT_TYPE, STATUS FROM USER_OBJECTS WHERE OBJECT_NAME=${literal(name)} AND OBJECT_TYPE IN ('TABLE','VIEW','SEQUENCE','SYNONYM','PROCEDURE','FUNCTION','PACKAGE','MATERIALIZED VIEW','TYPE','OPERATOR')`)).rows;+}++async function readSource(target: OracleViewRenameTarget, name: string): Promise<string> {+ const ddl = `DBMS_METADATA.GET_DDL('VIEW',${literal(name)},${literal(target.schema)})`;+ const lengthRows = (await query(target, `SELECT DBMS_LOB.GETLENGTH(${ddl}) FROM DUAL`)).rows;+ const length = Number(lengthRows[0]?.[0]);+ if (lengthRows.length !== 1 || !Number.isSafeInteger(length) || length <= 0 || length > 1_000_000) throw new Error(`Complete DDL is unavailable for ${name}.`);+ let source = "";+ for (let firstOffset = 1; firstOffset <= length; firstOffset += 32_000) {+ const offsets: number[] = [];+ for (let offset = firstOffset; offset <= length && offsets.length < 32; offset += 1000) offsets.push(offset);+ const sql = offsets.map((offset) => `SELECT ${offset} CHUNK_OFFSET, DBMS_LOB.SUBSTR(${ddl},1000,${offset}) CHUNK_TEXT FROM DUAL`).join(" UNION ALL ");+ const rows = (await query(target, sql)).rows;+ const chunks = new Map(rows.map((row) => [Number(row[0]), row[1]]));+ if (rows.length !== offsets.length || chunks.size !== offsets.length) throw new Error(`Complete DDL is unavailable for ${name}.`);+ for (const offset of offsets) {+ const chunk = chunks.get(offset);+ if (typeof chunk !== "string" || Array.from(chunk).length !== Math.min(1000, length - offset + 1)) throw new Error(`Complete DDL is unavailable for ${name}.`);+ source += chunk;+ }+ }+ return source;+}++async function readGrants(target: OracleViewRenameTarget, name: string): Promise<string> {+ const tables = await query(target, `SELECT GRANTOR, GRANTEE, PRIVILEGE, GRANTABLE FROM ALL_TAB_PRIVS WHERE TABLE_SCHEMA=${literal(target.schema)} AND TABLE_NAME=${literal(name)}`);+ const columns = await query(target, `SELECT GRANTOR, GRANTEE, COLUMN_NAME, PRIVILEGE, GRANTABLE FROM ALL_COL_PRIVS WHERE OWNER=${literal(target.schema)} AND TABLE_NAME=${literal(name)}`);+ return JSON.stringify([tables.rows.map((row) => JSON.stringify(row)).sort(), columns.rows.map((row) => JSON.stringify(row)).sort()]);+}++async function readDependents(target: OracleViewRenameTarget, name: string) {+ const suffix = ` WHERE REFERENCED_OWNER=${literal(target.schema)} AND REFERENCED_NAME=${literal(name)} AND REFERENCED_TYPE='VIEW'`;+ const columns = "SELECT OWNER, NAME, TYPE, REFERENCED_LINK_NAME FROM ";+ try {+ return (await query(target, `${columns}SYS.DBA_DEPENDENCIES${suffix}`)).rows;+ } catch (error) {+ // Only a denied dictionary is a fallback. Timeouts and incomplete results+ // must never turn a known dependency graph into an empty successful plan.+ if (!/ORA-00942|ORA-01031/.test(String(error instanceof Error ? error.message : error))) throw error;+ return (await query(target, `${columns}SYS.ALL_DEPENDENCIES${suffix}`)).rows;+ }+}++function issue(code: string, message: string, viewName?: string, repairable = false): OracleViewRenameIssue {+ return { code, message, viewName, repairable };+}++export async function prepareOracleViewRename(target: OracleViewRenameTarget, drafts: Record<string, string> = {}): Promise<OracleViewRenamePlan> {+ target = { ...target };+ const issues: OracleViewRenameIssue[] = [];+ let canonicalNewName = target.newName;+ let metadataComplete = true;+ try {+ canonicalNewName = await api.parseOracleObjectName(target.newName);+ if (canonicalNewName === target.oldName) issues.push(issue("invalid_name", "The new name matches the existing name."));+ await checkOwner(target);+ if ((await objectState(target, canonicalNewName)).length) issues.push(issue("target_conflict", `An object named ${canonicalNewName} already exists.`));+ } catch (error) {+ metadataComplete = false;+ const message = String(error);+ const code = /owner|current schema/i.test(message) ? "owner_mismatch" : /missing or invalid/i.test(message) ? "invalid_object" : "metadata_incomplete";+ issues.push(issue(code, message));+ }+ const ordered: string[] = [];+ const edges: string[] = [];+ const visiting = new Set<string>();+ const visited = new Set<string>();+ const walk = async (name: string) => {+ if (visiting.has(name)) {+ issues.push(issue("dependency_cycle", `Cyclic view dependency: ${name}.`, name));+ return;+ }+ if (visited.has(name)) return;+ if (visited.size + visiting.size >= metadataLimit) throw new Error("Dependency graph is incomplete: too many views.");+ visiting.add(name);+ let dependents: unknown[][];+ try {+ dependents = await readDependents(target, name);+ } catch (error) {+ metadataComplete = false;+ issues.push(issue("dependency_read_failed", String(error), name));+ visiting.delete(name);+ visited.add(name);+ ordered.push(name);+ return;+ }+ for (const row of [...dependents].sort((left, right) => (JSON.stringify(left) < JSON.stringify(right) ? -1 : JSON.stringify(left) > JSON.stringify(right) ? 1 : 0))) {+ const [owner, dependent, kind, link] = row;+ if (owner !== target.schema || kind !== "VIEW" || link || typeof dependent !== "string") {+ issues.push(issue("dependency_scope", `Cannot automatically update dependent ${String(owner)}.${String(dependent)} (${String(kind)}).`, typeof dependent === "string" ? dependent : name));+ continue;+ }+ edges.push(JSON.stringify([name, dependent]));+ await walk(dependent);+ }+ visiting.delete(name);+ visited.add(name);+ ordered.push(name);+ };+ if (metadataComplete) await walk(target.oldName);+ ordered.reverse();++ const views: ViewSnapshot[] = [];+ for (const name of ordered) {+ let source = "";+ let grants = "";+ try {+ const state = await objectState(target, name);+ if (state.length !== 1 || state[0][0] !== "VIEW" || state[0][1] !== "VALID") throw new Error(`View ${name} is missing or invalid.`);+ source = await readSource(target, name);+ grants = await readGrants(target, name);+ } catch (error) {+ metadataComplete = false;+ issues.push(issue("source_read_failed", String(error), name));+ }+ const draft = drafts[name] ?? source;+ const reviewInput = { source: draft, owner: target.schema, viewName: name, oldName: target.oldName, newName: target.oldName };+ let originalReview: Awaited<ReturnType<typeof api.reviewOracleViewRenameSource>> = { source: null, references: [], issues: [] };+ let review: Awaited<ReturnType<typeof api.reviewOracleViewRenameSource>> = { source: null, references: [], issues: [] };+ if (draft) {+ try {+ originalReview = await api.reviewOracleViewRenameSource({ ...reviewInput, source });+ } catch (error) {+ issues.push(issue("metadata_incomplete", String(error), name));+ }+ try {+ review = await api.reviewOracleViewRenameSource({ ...reviewInput, newName: canonicalNewName, ...(name === target.oldName ? { targetViewName: canonicalNewName } : {}) });+ } catch (error) {+ issues.push(issue("metadata_incomplete", String(error), name));+ }+ }+ const draftIssues = review.issues.map((item) => ({ ...item, viewName: name }));+ issues.push(...draftIssues);+ const original: OracleViewRenameSource | null = originalReview.source;+ const rewritten: OracleViewRenameSource | null = review.source;+ const normalize = (refs: OracleViewRenameSource["references"]) => refs.map((ref) => JSON.stringify([ref.owner, ref.name === canonicalNewName ? target.oldName : ref.name])).sort();+ const originalParseFailed = !original && originalReview.issues.some((item) => item.code === "invalid_definition" || item.code === "invalid_declaration");+ if (originalParseFailed) {+ const plannedNames = new Set([target.oldName, ...ordered.filter((plannedName) => plannedName !== target.oldName)]);+ const expected = edges+ .map((edge) => JSON.parse(edge) as [string, string])+ .filter(([, dependent]) => dependent === name)+ .map(([referenced]) => JSON.stringify([target.schema, referenced]))+ .sort();+ const actual = review.references+ .filter((reference) => reference.owner === target.schema && plannedNames.has(reference.name === canonicalNewName ? target.oldName : reference.name))+ .map((reference) => JSON.stringify([reference.owner, reference.name === canonicalNewName ? target.oldName : reference.name]))+ .sort();+ if (JSON.stringify(expected) !== JSON.stringify(actual)) issues.push(issue("manual_graph", `The proposed definition changes planned dependencies of ${name}.`, name, true));+ } else if (JSON.stringify(normalize(originalReview.references)) !== JSON.stringify(normalize(review.references))) {+ issues.push(issue("manual_graph", `The proposed definition changes dependencies of ${name}.`, name, true));+ }+ if (rewritten) {+ views.push({ name, source, fingerprint: original?.fingerprint || "", rewrittenSource: rewritten.source, rewrittenFingerprint: rewritten.fingerprint, grants, draft, references: originalReview.references });+ } else {+ views.push({ name, source, fingerprint: original?.fingerprint || "", rewrittenSource: "", rewrittenFingerprint: "", grants, draft, references: originalReview.references });+ }+ }+ const rootDrafted = Boolean(drafts[target.oldName] && drafts[target.oldName] !== views.find((view) => view.name === target.oldName)?.source);+ const steps: OracleViewRenameStep[] = [];+ if (rootDrafted) {+ const root = views.find((view) => view.name === target.oldName);+ const beforeRename = await api.reviewOracleViewRenameSource({ source: root?.draft || "", owner: target.schema, viewName: target.oldName, oldName: target.oldName, newName: target.oldName, targetViewName: target.oldName });+ issues.push(...beforeRename.issues.map((item) => ({ ...item, viewName: target.oldName })));+ if (beforeRename.source) steps.push({ kind: "replace", viewName: target.oldName, sql: beforeRename.source.source, expectedFingerprint: beforeRename.source.fingerprint });+ }+ steps.push({ kind: "rename", viewName: target.oldName, sql: `RENAME ${identifier(target.oldName)} TO ${identifier(canonicalNewName)};` });+ for (const view of views) if (view.name !== target.oldName && view.rewrittenSource) steps.push({ kind: "replace", viewName: view.name, sql: view.rewrittenSource, expectedFingerprint: view.rewrittenFingerprint });+ const executable = metadataComplete && issues.length === 0 && views.length > 0 && views.every((view) => Boolean(view.rewrittenSource));+ return {+ target,+ canonicalNewName,+ coverage: "visible-only",+ views,+ dependencyEdges: [...new Set(edges)].sort(),+ statements: steps.map((step) => step.sql),+ issues,+ metadataComplete,+ executable,+ steps,+ };+}++function planIdentity(plan: OracleViewRenamePlan) {+ return JSON.stringify([plan.target, plan.canonicalNewName, plan.dependencyEdges, plan.issues, plan.metadataComplete, plan.views.map((view) => [view.name, view.source, view.grants, view.draft, view.rewrittenFingerprint]), plan.steps]);+}++export async function executeOracleViewRename(plan: OracleViewRenamePlan, isCurrent: () => boolean = () => true): Promise<void> {+ if (!isCurrent()) throw new Error("The rename target changed. Refresh the preview.");+ if (!plan.executable) throw new Error("Fix and validate the view definitions before execution.");+ const current = await prepareOracleViewRename(plan.target, Object.fromEntries(plan.views.map((view) => [view.name, view.draft])));+ if (!current.executable) throw new Error("The rename target or its dependencies changed or no longer pass validation. Refresh the preview.");+ if (!isCurrent() || planIdentity(current) !== planIdentity(plan)) throw new Error("The rename target or its dependencies changed. Refresh the preview.");+ const frozen = freezeSourceIdentities(+ plan.views.map((view) => ({+ connectionId: plan.target.connectionId,+ database: plan.target.database,+ schema: plan.target.schema,+ objectType: "VIEW" as const,+ name: view.name,+ })),+ );+ const completed: string[] = [];+ let dispatched = false;+ let activeName = plan.target.oldName;+ try {+ for (let index = 0; index < plan.steps.length; index++) {+ const step = plan.steps[index];+ const view = plan.views.find((item) => item.name === step.viewName)!;+ activeName = step.kind === "rename" ? plan.canonicalNewName : step.viewName;+ if (!isCurrent()) throw new Error("The rename dialog changed or closed; remaining steps were not sent.");+ if (step.kind === "replace") {+ const source = await readSource(plan.target, view.name);+ if (source !== view.source || (await readGrants(plan.target, view.name)) !== view.grants) throw new Error(`View ${view.name} changed during rename; its definition was not overwritten.`);+ if (!isCurrent()) throw new Error("The rename dialog changed or closed; remaining steps were not sent.");+ }+ if (!dispatched) {+ frozen.markDispatched();+ dispatched = true;+ }+ await query(plan.target, step.sql);+ if (step.kind === "replace" && step.viewName === plan.target.oldName) {+ const state = await objectState(plan.target, plan.target.oldName);+ const replaced = await readSource(plan.target, plan.target.oldName);+ const actualBeforeRename = await api.reviewOracleViewRenameSource({ source: replaced, owner: plan.target.schema, viewName: plan.target.oldName, oldName: plan.target.oldName, newName: plan.target.oldName, targetViewName: plan.target.oldName });+ if (state.length !== 1 || actualBeforeRename.source?.fingerprint !== step.expectedFingerprint) throw new Error(`View ${plan.target.oldName} did not match its validated replacement.`);+ completed.push(`${plan.target.oldName} (definition replaced)`);+ continue;+ }+ if (step.kind === "rename") {+ const state = await objectState(plan.target, activeName);+ if (state.length !== 1 || state[0][0] !== "VIEW" || state[0][1] !== "VALID") throw new Error(`View ${activeName} is not valid after the change.`);+ const source = await readSource(plan.target, activeName);+ const actual = await api.reviewOracleViewRenameSource({ source, owner: plan.target.schema, viewName: activeName, oldName: plan.canonicalNewName, newName: plan.canonicalNewName });+ const root = plan.views.find((item) => item.name === plan.target.oldName)!;+ if (actual.source?.fingerprint !== root.rewrittenFingerprint || (await readGrants(plan.target, activeName)) !== root.grants) throw new Error(`Definition or grants did not match the preview for ${activeName}.`);+ if ((await objectState(plan.target, plan.target.oldName)).length) throw new Error("The old view name still exists after rename.");+ completed.push(activeName);+ continue;+ }+ const state = await objectState(plan.target, activeName);+ if (state.length !== 1 || state[0][0] !== "VIEW" || state[0][1] !== "VALID") throw new Error(`View ${activeName} is not valid after the change.`);+ const source = await readSource(plan.target, activeName);+ const actual = await api.reviewOracleViewRenameSource({ source, owner: plan.target.schema, viewName: activeName, oldName: plan.canonicalNewName, newName: plan.canonicalNewName });+ if (actual.source?.fingerprint !== view.rewrittenFingerprint || (await readGrants(plan.target, activeName)) !== view.grants) throw new Error(`Definition or grants did not match the preview for ${activeName}.`);+ completed.push(activeName);+ }+ } catch (error) {+ if (dispatched) throw new OracleViewRenameFailure(plan, completed, activeName, error);+ throw error;+ } finally {+ if (dispatched) {+ const scope = { connectionId: plan.target.connectionId, database: plan.target.database, schema: plan.target.schema };+ invalidateObjectBrowserRowsCache(scope);+ await Promise.allSettled([...new Set([...plan.views.map((view) => view.name), plan.canonicalNewName])].map((tableName) => invalidateObjectDdlCache({ ...scope, tableName })));+ frozen.finish();+ } else frozen.cancel();+ }+}diff --git a/apps/desktop/src/stores/__tests__/queryStore.objectSourcePending.spec.ts b/apps/desktop/src/stores/__tests__/queryStore.objectSourcePending.spec.tsindex 8b1c8c2591..9671373a7e 100644--- a/apps/desktop/src/stores/__tests__/queryStore.objectSourcePending.spec.ts+++ b/apps/desktop/src/stores/__tests__/queryStore.objectSourcePending.spec.ts@@ -1,6 +1,7 @@import { createPinia, setActivePinia } from "pinia";import { beforeEach, describe, expect, it, vi } from "vitest";import { QUERY_EDITOR_FULL_FEATURE_MAX_DOCUMENT_LENGTH } from "@/lib/editor/queryEditorLargeDocument";+import { assertSourceIdentity, freezeSourceIdentities } from "@/lib/table/objectSourceIdentity";// issue #9035:源码 tab 必须先出现再加载。这批用例锁定 pending 占位 tab 的// 行为契约:立即出现、原地填充、就地重试、加载中被关闭则丢弃、重复点击去重。@@ -64,6 +65,134 @@ describe("queryStore pending object source tab", () => {mocks.connectionStore.dbType = "oracle";});+ it("rejects a late source response after migration and preserves a dirty old draft", async () => {+ const { useQueryStore } = await import("@/stores/queryStore");+ const store = useQueryStore();+ let resolveSource!: (value: unknown) => void;+ mocks.getObjectSource.mockReturnValue(new Promise((resolve) => (resolveSource = resolve)));+ const id = store.openObjectSourceTabPending(pendingOptions({ name: "late_migration", objectType: "VIEW" }));+ await settle();+ const migration = freezeSourceIdentities([{ connectionId: CONNECTION_ID, database: DATABASE, schema: SCHEMA, name: "late_migration", objectType: "VIEW" }]);+ migration.markDispatched();+ migration.finish();+ resolveSource(objectSource("CREATE VIEW late_migration AS SELECT 1 FROM dual"));+ await settle();+ expect(store.tabs[0]!.objectSource).toBeUndefined();+ expect(store.tabs[0]!.sourceLoad?.error).toContain("reload");++ mocks.getObjectSource.mockResolvedValue(objectSource("CREATE VIEW late_migration AS SELECT 2 FROM dual"));+ store.retryObjectSourceTab(id);+ await settle();+ const tab = store.tabs[0]!;+ const old = store.getObjectSourceIdentitySnapshot(tab)!;+ store.updateSql(id, "my dirty draft");+ const second = freezeSourceIdentities([old]);+ second.markDispatched();+ second.finish();+ store.openObjectSourceTabPending(pendingOptions({ name: "late_migration", objectType: "VIEW" }));+ await settle();+ expect(tab.sql).toBe("my dirty draft");+ expect(() => assertSourceIdentity(store.getObjectSourceIdentitySnapshot(tab)!)).toThrow();+ expect(store.isTabDirty(tab)).toBe(true);+ });++ it("does not let background revalidation revive a frozen source but allows explicit refresh", async () => {+ const { useQueryStore } = await import("@/stores/queryStore");+ const store = useQueryStore();+ mocks.getObjectSource.mockResolvedValue(objectSource("original source"));+ const options = pendingOptions({ name: "revalidate_migration", objectType: "VIEW" });+ const id = store.openObjectSourceTabPending(options);+ await settle();+ const tab = store.tabs[0]!;+ const old = store.getObjectSourceIdentitySnapshot(tab)!;+ let complete!: (value: unknown) => void;+ mocks.getObjectSource.mockReturnValueOnce(+ new Promise((resolve) => {+ complete = resolve;+ }),+ );+ store.openObjectSourceTabPending(options);+ await settle();+ const migration = freezeSourceIdentities([old]);+ migration.markDispatched();+ migration.finish();+ complete(objectSource("late old source"));+ await settle();+ expect(tab.sql).toBe("original source");+ expect(() => assertSourceIdentity(store.getObjectSourceIdentitySnapshot(tab)!)).toThrow();+ mocks.getObjectSource.mockResolvedValue(objectSource("fresh rebuilt source"));+ expect(store.refreshObjectSourceTab(id)).toBe(true);+ await settle();+ expect(tab.sql).toBe("fresh rebuilt source");+ expect(() => assertSourceIdentity(store.getObjectSourceIdentitySnapshot(tab)!)).not.toThrow();+ expect(() => assertSourceIdentity(old)).toThrow();+ });++ it.each(["connection", "database"])("requires a successful reload after source %s retargeting", async (target) => {+ const { useQueryStore } = await import("@/stores/queryStore");+ const store = useQueryStore();+ mocks.getObjectSource.mockResolvedValue(objectSource("original retarget source"));+ const id = store.openObjectSourceTabPending(pendingOptions({ name: `retarget_${target}`, objectType: "VIEW" }));+ await settle();+ const tab = store.tabs[0]!;+ const original = store.getObjectSourceIdentitySnapshot(tab)!;+ store.updateSql(id, "dirty retarget draft");+ if (target === "connection") store.updateConnection(id, "ora-2", DATABASE);+ else store.updateDatabase(id, "ORCL2");+ expect(() => store.getObjectSourceIdentitySnapshot(tab)).toThrow();+ expect(tab.sql).toBe("dirty retarget draft");+ expect(store.isTabDirty(tab)).toBe(true);+ store.createTab(CONNECTION_ID, DATABASE, "Unrelated query");+ if (target === "connection") store.updateConnection(id, CONNECTION_ID, DATABASE);+ else store.updateDatabase(id, DATABASE);+ expect(store.getObjectSourceIdentitySnapshot(tab)).toBe(original);+ if (target === "connection") store.updateConnection(id, "ora-2", DATABASE);+ else store.updateDatabase(id, "ORCL2");+ mocks.getObjectSource.mockResolvedValue(objectSource("reloaded target source"));+ expect(store.refreshObjectSourceTab(id)).toBe(true);+ await settle();+ const reloaded = store.getObjectSourceIdentitySnapshot(tab)!;+ expect(reloaded.connectionId).toBe(tab.connectionId);+ expect(reloaded.database).toBe(tab.database);+ expect(() => assertSourceIdentity(reloaded)).not.toThrow();+ expect(original.connectionId).toBe(CONNECTION_ID);+ expect(original.database).toBe(DATABASE);+ expect(tab.sql).toBe("reloaded target source");+ });++ it("discards a source load retargeted before its response arrives", async () => {+ const { useQueryStore } = await import("@/stores/queryStore");+ const store = useQueryStore();+ let complete!: (value: unknown) => void;+ mocks.getObjectSource.mockReturnValue(new Promise((resolve) => (complete = resolve)));+ const id = store.openObjectSourceTabPending(pendingOptions({ name: "retarget_pending", objectType: "VIEW" }));+ await settle();+ store.updateDatabase(id, "ORCL2");+ complete(objectSource("late old target source"));+ await settle();+ expect(store.tabs[0]!.objectSource).toBeUndefined();+ expect(store.tabs[0]!.sql).not.toBe("late old target source");+ expect(store.tabs[0]!.sourceLoad?.error).toContain("reload");+ });++ it("keeps loaded source when a background response arrives after retargeting", async () => {+ const { useQueryStore } = await import("@/stores/queryStore");+ const store = useQueryStore();+ const options = pendingOptions({ name: "retarget_background", objectType: "VIEW" });+ mocks.getObjectSource.mockResolvedValue(objectSource("original background source"));+ const id = store.openObjectSourceTabPending(options);+ await settle();+ let complete!: (value: unknown) => void;+ mocks.getObjectSource.mockReturnValueOnce(new Promise((resolve) => (complete = resolve)));+ store.openObjectSourceTabPending(options);+ await settle();+ store.updateConnection(id, "ora-2", DATABASE);+ complete(objectSource("late old background source"));+ await settle();+ expect(store.tabs[0]!.sql).toBe("original background source");+ expect(() => store.getObjectSourceIdentitySnapshot(store.tabs[0]!)).toThrow();+ });+it("creates a visible loading tab before the source arrives", async () => {let resolveSource: ((value: unknown) => void) | undefined;mocks.getObjectSource.mockReturnValue(new Promise((resolve) => (resolveSource = resolve)));diff --git a/apps/desktop/src/stores/__tests__/queryStore.titleSuffix.spec.ts b/apps/desktop/src/stores/__tests__/queryStore.titleSuffix.spec.tsindex b1a51806c5..52550dbaa3 100644--- a/apps/desktop/src/stores/__tests__/queryStore.titleSuffix.spec.ts+++ b/apps/desktop/src/stores/__tests__/queryStore.titleSuffix.spec.ts@@ -25,7 +25,7 @@ describe("queryStore tab title suffix", () => {async function createStoreWithDataTab() {const { useQueryStore } = await import("@/stores/queryStore");const store = useQueryStore();- const id = store.createTab("pg-1", "app", "users", "data", "public");+ const id = store.createTab("pg-1", "app", "scratch", "query");return { store, id };}diff --git a/apps/desktop/src/stores/queryStore.ts b/apps/desktop/src/stores/queryStore.tsindex 33bd60ce0a..5c6bc6926e 100644--- a/apps/desktop/src/stores/queryStore.ts+++ b/apps/desktop/src/stores/queryStore.ts@@ -140,6 +140,7 @@ import { resolveSavedSqlExecutionTarget, savedSqlExecutionTargetFromFile, savedSimport { safeLocalStorageGet, safeLocalStorageRemove } from "@/lib/backend/safeStorage";import { sqlTextFingerprint } from "@/lib/sql/sqlTextFingerprint";import { loadEditableObjectSourceForEditor } from "@/lib/table/objectSourceLoad";+import { assertSourceIdentity, captureSourceIdentity, renewSourceIdentity, type SourceIdentitySnapshot } from "@/lib/table/objectSourceIdentity";import { buildEditableObjectSource } from "@/lib/table/objectSourceEditor";import { disposeAllSqlServerActivityTraces, disposeSqlServerActivityTrace } from "@/lib/sqlserver/sqlServerActivityTraceRuntime";import type { SavedSqlFile } from "@/types/database";@@ -1131,6 +1132,27 @@ export const useQueryStore = defineStore("query", () => {const t = getI18nT();const settingsStore = useSettingsStore();const tabs = ref<QueryTab[]>([]);+ const sourceIdentities = new WeakMap<NonNullable<QueryTab["objectSource"]>, SourceIdentitySnapshot>();+ function getObjectSourceIdentitySnapshot(tab: QueryTab): SourceIdentitySnapshot | undefined {+ if (!tab.objectSource) return undefined;+ let snapshot = sourceIdentities.get(tab.objectSource);+ if (!snapshot) {+ snapshot = captureSourceIdentity({ connectionId: tab.connectionId, database: tab.database, schema: tab.objectSource.schema || tab.schema || tab.database, objectType: tab.objectSource.objectType, name: tab.objectSource.name });+ sourceIdentities.set(tab.objectSource, snapshot);+ }+ if (snapshot.connectionId !== tab.connectionId || snapshot.database !== tab.database || (snapshot.schema || snapshot.database) !== (tab.objectSource.schema || tab.schema || tab.database) || snapshot.objectType !== tab.objectSource.objectType || snapshot.name !== tab.objectSource.name)+ throw new Error(i18n.global.t("objects.sourceIdentityChanged"));+ return snapshot;+ }+ watch(+ () => tabs.value.map((tab) => tab.objectSource),+ () => {+ for (const tab of tabs.value) {+ if (tab.objectSource && !sourceIdentities.has(tab.objectSource)) getObjectSourceIdentitySnapshot(tab);+ }+ },+ { flush: "sync" },+ );// New tabs are created by many feature-specific entry points. Tracking id// changes here gives every one a stable timestamp without duplicating the// field at each call site; restored legacy tabs retain their saved order.@@ -3044,6 +3066,8 @@ export const useQueryStore = defineStore("query", () => {existing.sourceView = true;switchTab(existing.id);if (!isTabDirty(existing)) {+ const snapshot = getObjectSourceIdentitySnapshot(existing);+ if (snapshot) assertSourceIdentity(snapshot);updateSql(existing.id, options.sql);markTabClean(existing);}@@ -3135,6 +3159,8 @@ export const useQueryStore = defineStore("query", () => {const schema = objectSource.schema || tab.schema || database;sourceRevalidateInFlight.add(id);try {+ const identity = getObjectSourceIdentitySnapshot(tab)!;+ assertSourceIdentity(identity);const connectionStore = useConnectionStore();await connectionStore.ensureConnected(connectionId);const databaseType = effectiveDatabaseTypeForConnection(connectionStore.getConfig(connectionId));@@ -3154,7 +3180,9 @@ export const useQueryStore = defineStore("query", () => {});// 期间 tab 可能被关闭、被复用或已被编辑:身份没变且用户没改过内容时才回填const current = tabs.value.find((candidate) => candidate.id === id);+ assertSourceIdentity(identity);if (current?.objectSource !== objectSource || resolvedType !== objectSource.objectType) return;+ if (current.connectionId !== connectionId || current.database !== database || (current.objectSource.schema || current.schema || current.database) !== schema) return;if (raw.editable === false || (OBJECT_SOURCE_READ_ONLY_TYPES.includes(resolvedType) && !(databaseType === "oceanbase-oracle" && resolvedType === "SEQUENCE"))) return;if (isTabDirty(current)) return;updateSql(id, editableSource);@@ -3205,6 +3233,8 @@ export const useQueryStore = defineStore("query", () => {const { database } = tab;const schema = tab.schema || database;const { request, initialEditing } = tab.sourceLoad;+ const sourceLoad = tab.sourceLoad;+ const identity = captureSourceIdentity({ connectionId, database, schema, name: request.name, objectType: request.objectType });try {const connectionStore = useConnectionStore();await connectionStore.ensureConnected(connectionId);@@ -3224,11 +3254,19 @@ export const useQueryStore = defineStore("query", () => {databaseType,signature: request.signature,});+ if (tabs.value.find((candidate) => candidate.id === id)?.sourceLoad !== sourceLoad) return;+ if (tab.connectionId !== connectionId || tab.database !== database || (tab.schema || tab.database) !== schema) throw new Error(i18n.global.t("objects.sourceIdentityChanged"));+ const renewedIdentity = renewSourceIdentity(identity);+ // Fallback can resolve another kind; never activate a frozen resolved object.+ const resolvedIdentity = resolvedType === request.objectType ? renewedIdentity : captureSourceIdentity({ ...identity, objectType: resolvedType });+ assertSourceIdentity(resolvedIdentity);applyLoadedObjectSource(id, { connectionId, database, schema, catalog: tab.catalog, title: tab.title, request, initialEditing, databaseType, editableSource, raw, resolvedType });+ const loadedTab = tabs.value.find((candidate) => candidate.id === id);+ if (loadedTab?.objectSource) sourceIdentities.set(loadedTab.objectSource, resolvedIdentity);} catch (e: any) {// 就地显示错误 + Retry:用户此刻正看着这个 tab,比 toast 更可发现const failed = tabs.value.find((candidate) => candidate.id === id);- if (failed?.sourceLoad) failed.sourceLoad.error = e?.message || String(e);+ if (failed?.sourceLoad === sourceLoad) failed.sourceLoad.error = e?.message || String(e);}}@@ -3266,6 +3304,8 @@ export const useQueryStore = defineStore("query", () => {// 有则交接给它并关掉 pending 占位,避免同一个对象出现两个 tab。const existing = findMatchingObjectSourceTab(options, id);if (existing) {+ const snapshot = getObjectSourceIdentitySnapshot(existing);+ if (snapshot) assertSourceIdentity(snapshot);clearObjectSourceLoad(tab);closeTab(id);existing.sourceView = true;@@ -10400,6 +10440,7 @@ export const useQueryStore = defineStore("query", () => {invalidateTableStructure,tableStructureRefreshVersion,setObjectSource,+ getObjectSourceIdentitySnapshot,setExecuting,setExecutingWithId,setErrorResult,diff --git a/apps/desktop/src/types/database.ts b/apps/desktop/src/types/database.tsindex 7eb6aac07d..cc4c6be61b 100644--- a/apps/desktop/src/types/database.ts+++ b/apps/desktop/src/types/database.ts@@ -8,6 +8,50 @@ import type { GraphResult } from "@/lib/graph/graphResult";export type { DatabaseType } from "@/types/generated/databaseTypes";+export interface OracleViewRenameSourceInput {+ source: string;+ owner: string;+ viewName: string;+ oldName: string;+ newName: string;+ targetViewName?: string;+}++export interface OracleViewRenameSource {+ source: string;+ fingerprint: string;+ references: OracleViewRenameReference[];+}++export interface OracleViewRenameReference {+ owner: string;+ name: string;+}++export interface OracleViewRenameIssue {+ code: string;+ message: string;+ viewName?: string;+ hintText?: string | null;+ location?: { line: number; column: number; endLine?: number; endColumn?: number } | null;+ repairable: boolean;+}++export interface OracleViewRenameSourceReview {+ source: OracleViewRenameSource | null;+ references: OracleViewRenameReference[];+ issues: OracleViewRenameIssue[];+}++export interface OracleTableReferenceRewriteInput {+ databaseType: Extract<DatabaseType, "oracle" | "oceanbase-oracle">;+ objectType: "PROCEDURE" | "FUNCTION" | "TRIGGER";+ schema: string;+ oldName: string;+ newName: string;+ source: string;+}+export function isElasticsearchCompatibleDatabaseType(dbType?: DatabaseType): boolean {return dbType === "elasticsearch" || dbType === "easysearch";}diff --git a/crates/dbx-core/src/lib.rs b/crates/dbx-core/src/lib.rsindex 944f7fee71..718c2c9b15 100644--- a/crates/dbx-core/src/lib.rs+++ b/crates/dbx-core/src/lib.rs@@ -72,6 +72,7 @@ pub use dbx_sql::dml_preview_sql;pub(crate) use dbx_sql::mysql_ddl_normalize;pub use dbx_sql::mysql_event_sql;pub use dbx_sql::object_source_sql;+pub use dbx_sql::oracle_view_rename;pub use dbx_types::models;pub use host::external;pub use persistence::history;diff --git a/crates/dbx-sql-core/src/lib.rs b/crates/dbx-sql-core/src/lib.rsindex 027049fae1..c08943fab1 100644--- a/crates/dbx-sql-core/src/lib.rs+++ b/crates/dbx-sql-core/src/lib.rs@@ -8,6 +8,7 @@ pub mod dml_preview_sql;pub mod mysql_ddl_normalize;pub mod mysql_event_sql;pub mod object_source_sql;+pub mod oracle_view_rename;pub mod query_execution_sql;pub mod sql;pub mod sql_analysis;diff --git a/crates/dbx-sql-core/src/object_source_sql.rs b/crates/dbx-sql-core/src/object_source_sql.rsindex dd663bc826..4177090567 100644--- a/crates/dbx-sql-core/src/object_source_sql.rs+++ b/crates/dbx-sql-core/src/object_source_sql.rs@@ -1,9 +1,11 @@use regex::Regex;use serde::{Deserialize, Serialize};use sqlparser::dialect::OracleDialect;+use sqlparser::keywords::Keyword;use sqlparser::tokenizer::{Token, Tokenizer, Whitespace};use crate::models::connection::DatabaseType;+use crate::sql::split_sql_statements_for_database;use crate::types::ObjectSourceKind;#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]@@ -17,6 +19,17 @@ pub struct EditableObjectSourceSqlInput {pub source: String,}+#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]+#[serde(rename_all = "camelCase")]+pub struct OracleObjectSourceValidationInput {+ pub database_type: DatabaseType,+ pub object_type: ObjectSourceKind,+ #[serde(default, skip_serializing_if = "Option::is_none")]+ pub schema: Option<String>,+ pub name: String,+ pub source: String,+}+#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]#[serde(rename_all = "camelCase")]pub struct RoutineRenameObjectSourceInput {@@ -29,6 +42,31 @@ pub struct RoutineRenameObjectSourceInput {pub source: String,}+#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]+#[serde(rename_all = "camelCase")]+pub struct OracleRoutineReferenceRewriteInput {+ pub database_type: DatabaseType,+ pub caller_type: ObjectSourceKind,+ pub target_type: ObjectSourceKind,+ #[serde(default, skip_serializing_if = "Option::is_none")]+ pub schema: Option<String>,+ pub old_name: String,+ pub new_name: String,+ pub source: String,+}++#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]+#[serde(rename_all = "camelCase")]+pub struct OracleTableReferenceRewriteInput {+ pub database_type: DatabaseType,+ pub object_type: ObjectSourceKind,+ #[serde(default, skip_serializing_if = "Option::is_none")]+ pub schema: Option<String>,+ pub old_name: String,+ pub new_name: String,+ pub source: String,+}+#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]#[serde(rename_all = "camelCase")]pub struct BuildViewDdlInput {@@ -71,7 +109,10 @@ pub fn supports_source_backed_routine_rename(return false;};database_type != DatabaseType::SqlServer- && (is_mysql_like(database_type) || is_postgres_like(database_type) || is_oracle_like(database_type))+ && (is_mysql_like(database_type)+ || is_postgres_like(database_type)+ || is_oracle_like(database_type)+ || database_type == DatabaseType::OceanbaseOracle)}pub fn build_routine_rename_object_source_statements(@@ -85,6 +126,15 @@ pub fn build_routine_rename_object_source_statements(}let source = input.source.trim();+ if input.database_type == DatabaseType::Oracle || input.database_type == DatabaseType::OceanbaseOracle {+ validate_oracle_object_source(+ input.database_type,+ &input.object_type,+ input.schema.as_deref(),+ &input.name,+ source,+ )?;+ }let declaration = if is_mysql_like(input.database_type) {mysql_routine_declaration(source)} else {@@ -106,7 +156,14 @@ pub fn build_routine_rename_object_source_statements(return Err(format!("Cannot rewrite the {:?} name in the object source.", input.object_type));};- if is_oracle_like(input.database_type) {+ if is_oracle_like(input.database_type) || input.database_type == DatabaseType::OceanbaseOracle {+ let renamed_source = rewrite_oracle_routine_self_references(+ &renamed_source,+ &input.name,+ &input.new_name,+ input.schema.as_deref(),+ input.object_type.clone(),+ )?;return Ok(vec![ensure_semicolon(&renamed_source),format!(@@ -126,6 +183,293 @@ pub fn build_routine_rename_object_source_statements(})}+pub fn rewrite_oracle_routine_references(input: OracleRoutineReferenceRewriteInput) -> Result<String, String> {+ if !(is_oracle_like(input.database_type) || input.database_type == DatabaseType::OceanbaseOracle)+ || !matches!(+ input.caller_type,+ ObjectSourceKind::View | ObjectSourceKind::Procedure | ObjectSourceKind::Function+ )+ {+ return Err("Static routine reference rewriting is supported only for Oracle-family views and routines.".into());+ }+ if input.old_name == input.new_name {+ return Ok(input.source);+ }+ let tokens = Tokenizer::new(&OracleDialect {}, &input.source)+ .tokenize_with_location()+ .map_err(|error| format!("Cannot safely tokenize the dependent source: {error}"))?;+ let significant = tokens+ .iter()+ .enumerate()+ .filter_map(|(index, token)| (!matches!(token.token, Token::Whitespace(_))).then_some(index))+ .collect::<Vec<_>>();+ if matches!(input.caller_type, ObjectSourceKind::Procedure | ObjectSourceKind::Function) {+ if let Some(execute_index) =+ find_oracle_execute_immediate(significant.iter().copied().map(|index| (index, &tokens[index].token)))+ {+ let location = tokens[execute_index].span.start;+ return Err(format!(+ "Dynamic SQL must be rewritten as a verifiable static call at line {}, column {}.",+ location.line, location.column+ ));+ }+ }+ if significant.windows(2).any(|pair| {+ (token_word_is(&tokens[pair[0]].token, "FUNCTION") || token_word_is(&tokens[pair[0]].token, "PROCEDURE"))+ && (token_matches_identifier(&tokens[pair[1]].token, &input.old_name)+ || token_matches_identifier(&tokens[pair[1]].token, &input.new_name))+ }) {+ return Err(format!(+ "A local routine named {} or {} may shadow the dependent reference.",+ input.old_name, input.new_name+ ));+ }+ let mut local_bindings = Vec::new();+ if matches!(input.caller_type, ObjectSourceKind::Procedure | ObjectSourceKind::Function) {+ for body_start in 0..significant.len() {+ if !token_word_is(&tokens[significant[body_start]].token, "AS")+ && !token_word_is(&tokens[significant[body_start]].token, "IS")+ {+ continue;+ }+ if let Some(body_end) = (body_start + 1..significant.len())+ .find(|position| token_word_is(&tokens[significant[*position]].token, "BEGIN"))+ {+ local_bindings.extend(significant[body_start + 1..body_end].iter().map(|index| &tokens[*index].token));+ }++ // Formal parameters are declared before AS/IS and can shadow the+ // dependent name just like declarations in the block body.+ if let Some(close) =+ (0..body_start).rev().find(|position| tokens[significant[*position]].token == Token::RParen)+ {+ let mut nesting = 0usize;+ let mut open = None;+ for position in (0..=close).rev() {+ match tokens[significant[position]].token {+ Token::RParen => nesting += 1,+ Token::LParen => {+ nesting -= 1;+ if nesting == 0 {+ open = Some(position);+ break;+ }+ }+ _ => {}+ }+ }+ if let Some(open) = open {+ local_bindings.extend(significant[open + 1..close].iter().map(|index| &tokens[*index].token));+ }+ }+ }++ // Nested anonymous blocks can declare a collection or record after+ // the outer BEGIN. Reject a possibly shadowed rewrite there too.+ for declaration in 0..significant.len() {+ if !token_word_is(&tokens[significant[declaration]].token, "DECLARE") {+ continue;+ }+ if let Some(block_start) = (declaration + 1..significant.len())+ .find(|position| token_word_is(&tokens[significant[*position]].token, "BEGIN"))+ {+ local_bindings+ .extend(significant[declaration + 1..block_start].iter().map(|index| &tokens[*index].token));+ }+ }+ }+ let mut edits = Vec::new();+ for (position, token_index) in significant.iter().copied().enumerate() {+ let token = &tokens[token_index];+ if !token_matches_identifier(&token.token, &input.old_name) {+ continue;+ }+ let previous = position.checked_sub(1).map(|index| &tokens[significant[index]].token);+ let previous_previous = position.checked_sub(2).map(|index| &tokens[significant[index]].token);+ if previous == Some(&Token::Period) {+ let Some(Token::Word(owner)) = previous_previous else {+ return Err(format!("Cannot determine which routine reference to rename: {}.", input.old_name));+ };+ if !input.schema.as_deref().is_some_and(|schema| identifier_matches(owner, schema)) {+ continue;+ }+ if local_bindings+ .iter()+ .any(|binding| token_matches_identifier(binding, input.schema.as_deref().unwrap_or_default()))+ {+ return Err(format!(+ "The schema qualifier may be shadowed by a local declaration while rewriting {}.",+ input.old_name+ ));+ }+ } else if local_bindings.iter().any(|binding| {+ token_matches_identifier(binding, &input.old_name) || token_matches_identifier(binding, &input.new_name)+ }) {+ return Err(format!(+ "A local declaration may shadow the {} or {} reference.",+ input.old_name, input.new_name+ ));+ }+ let next = significant.get(position + 1).map(|index| &tokens[*index].token);+ let routine_caller = matches!(input.caller_type, ObjectSourceKind::Procedure | ObjectSourceKind::Function);+ let parenthesized_call = (input.target_type == ObjectSourceKind::Function+ || (input.target_type == ObjectSourceKind::Procedure && routine_caller))+ && matches!(next, Some(Token::LParen));+ let procedure_call = input.target_type == ObjectSourceKind::Procedure+ && matches!(input.caller_type, ObjectSourceKind::Procedure | ObjectSourceKind::Function)+ && matches!(next, Some(Token::SemiColon));+ if parenthesized_call || procedure_call {+ edits.push((token.span, quote_postgres_identifier(&input.new_name)));+ } else if matches!(next, Some(Token::Period)) {+ return Err(format!("The dependent reference {} is qualified in an unsupported form.", input.old_name));+ }+ }+ if edits.is_empty() {+ return Err(format!("The dependent source does not contain a verifiable static call to {}.", input.old_name));+ }+ let mut result = input.source;+ for (span, replacement) in edits.into_iter().rev() {+ let start = routine_location_to_byte_offset(&result, span.start)+ .ok_or_else(|| "Cannot map routine token positions to the dependent source text.".to_string())?;+ let end = routine_location_to_byte_offset(&result, span.end)+ .ok_or_else(|| "Cannot map routine token positions to the dependent source text.".to_string())?;+ if start >= end || end > result.len() {+ return Err("Routine token positions overlap or exceed the dependent source text.".into());+ }+ result.replace_range(start..end, &replacement);+ }+ Ok(result)+}++pub fn rewrite_oracle_table_references(input: OracleTableReferenceRewriteInput) -> Result<String, String> {+ if !(is_oracle_like(input.database_type) || input.database_type == DatabaseType::OceanbaseOracle)+ || !matches!(+ input.object_type,+ ObjectSourceKind::Procedure | ObjectSourceKind::Function | ObjectSourceKind::Trigger+ )+ {+ return Err(+ "Static table reference rewriting supports only Oracle-family procedures, functions, and triggers.".into(),+ );+ }+ let tokens = Tokenizer::new(&OracleDialect {}, &input.source)+ .tokenize_with_location()+ .map_err(|error| format!("Cannot safely tokenize the dependent source: {error}"))?;+ let significant = tokens+ .iter()+ .enumerate()+ .filter_map(|(index, token)| (!matches!(token.token, Token::Whitespace(_))).then_some(index))+ .collect::<Vec<_>>();+ if let Some(execute_index) =+ find_oracle_execute_immediate(significant.iter().copied().map(|index| (index, &tokens[index].token)))+ {+ let location = tokens[execute_index].span.start;+ return Err(format!(+ "Dynamic SQL is outside the supported table-reference subset at line {}, column {}.",+ location.line, location.column+ ));+ }++ let mut edits = Vec::new();+ for (position, token_index) in significant.iter().copied().enumerate() {+ let token = &tokens[token_index];+ if !token_matches_identifier(&token.token, &input.old_name) {+ continue;+ }+ let previous = position.checked_sub(1).map(|index| &tokens[significant[index]].token);+ let previous_previous = position.checked_sub(2).map(|index| &tokens[significant[index]].token);+ let next = significant.get(position + 1).map(|index| &tokens[*index].token);+ let next_next = significant.get(position + 2).map(|index| &tokens[*index].token);++ let owner_qualified = previous == Some(&Token::Period);+ if owner_qualified {+ let Some(Token::Word(owner)) = previous_previous else {+ return Err(format!("Cannot determine which table reference to rename: {}.", input.old_name));+ };+ if !input.schema.as_deref().is_some_and(|schema| identifier_matches(owner, schema)) {+ continue;+ }+ if position >= 3 && matches!(tokens[significant[position - 3]].token, Token::Period) {+ return Err(format!("Three-part table reference {} is outside the supported subset.", input.old_name));+ }+ }+ let context_position = if owner_qualified { position - 2 } else { position };+ let context_previous = context_position.checked_sub(1).map(|index| &tokens[significant[index]].token);+ let context_previous_previous = context_position.checked_sub(2).map(|index| &tokens[significant[index]].token);++ let type_reference = next == Some(&Token::Period)+ && next_next.is_some_and(|column| matches!(column, Token::Word(_)))+ && significant+ .get(position + 3)+ .is_some_and(|index| matches!(tokens[*index].token, Token::Mod | Token::Char('%')))+ && significant.get(position + 4).is_some_and(|index| token_word_is(&tokens[*index].token, "TYPE"));+ let rowtype_reference = next.is_some_and(|value| matches!(value, Token::Mod | Token::Char('%')))+ && next_next.is_some_and(|value| token_word_is(value, "ROWTYPE"));+ let relation_reference = context_previous.is_some_and(|value| {+ token_word_is(value, "FROM")+ || token_word_is(value, "UPDATE")+ || (input.object_type == ObjectSourceKind::Trigger && token_word_is(value, "ON"))+ }) || (context_previous.is_some_and(|value| token_word_is(value, "INTO"))+ && context_previous_previous+ .is_some_and(|value| token_word_is(value, "INSERT") || token_word_is(value, "MERGE")));++ if relation_reference && context_previous.is_some_and(|value| token_word_is(value, "FROM")) {+ let multiple_relations = significant+ .iter()+ .skip(position + 1)+ .map(|index| &tokens[*index].token)+ .take_while(|candidate| {+ ![+ "WHERE",+ "GROUP",+ "ORDER",+ "HAVING",+ "CONNECT",+ "START",+ "UNION",+ "MINUS",+ "INTERSECT",+ "FETCH",+ "FOR",+ ]+ .iter()+ .any(|clause| token_word_is(candidate, clause))+ && !matches!(candidate, Token::SemiColon)+ })+ .any(|candidate| matches!(candidate, Token::Comma) || token_word_is(candidate, "JOIN"));+ if multiple_relations {+ return Err(format!(+ "Multiple relations in one FROM clause are outside the supported subset at line {}, column {}.",+ token.span.start.line, token.span.start.column+ ));+ }+ }++ if !(type_reference || rowtype_reference || relation_reference) {+ return Err(format!(+ "Cannot safely identify the table reference at line {}, column {}.",+ token.span.start.line, token.span.start.column+ ));+ }+ edits.push((token.span, quote_postgres_identifier(&input.new_name)));+ }+ if edits.is_empty() {+ return Err(format!("The dependent source has no verifiable static reference to table {}.", input.old_name));+ }+ let mut result = input.source;+ for (span, replacement) in edits.into_iter().rev() {+ let start = routine_location_to_byte_offset(&result, span.start)+ .ok_or_else(|| "Cannot map table-reference token positions to the dependent source text.".to_string())?;+ let end = routine_location_to_byte_offset(&result, span.end)+ .ok_or_else(|| "Cannot map table-reference token positions to the dependent source text.".to_string())?;+ if start >= end || end > result.len() {+ return Err("Table-reference token positions overlap or exceed the dependent source text.".into());+ }+ result.replace_range(start..end, &replacement);+ }+ Ok(result)+}+pub fn build_executable_object_source_statements(input: EditableObjectSourceSqlInput) -> Result<Vec<String>, String> {if input.database_type == DatabaseType::OceanbaseOracle && input.object_type == ObjectSourceKind::Sequence {return Ok(vec![oceanbase_sequence_edit_sql(&input)?]);@@ -136,6 +480,24 @@ pub fn build_executable_object_source_statements(input: EditableObjectSourceSqlI} else {source};+ if (input.database_type == DatabaseType::Oracle || input.database_type == DatabaseType::OceanbaseOracle)+ && matches!(+ input.object_type,+ ObjectSourceKind::Procedure+ | ObjectSourceKind::Function+ | ObjectSourceKind::Package+ | ObjectSourceKind::PackageBody+ )+ && source_starts_with_create(source)+ {+ validate_oracle_object_source(+ input.database_type,+ &input.object_type,+ input.schema.as_deref(),+ &input.name,+ source,+ )?;+ }if input.database_type == DatabaseType::SqlServer {if input.object_type == ObjectSourceKind::View {return Ok(vec![build_sqlserver_alter_view_sql(input.schema.as_deref(), &input.name, source)]);@@ -190,10 +552,179 @@ pub fn build_executable_object_source_statements(input: EditableObjectSourceSqlIOk(if let Some(cleanup) = cleanup { vec![create_statement, cleanup] } else { vec![create_statement] })}+pub fn validate_oracle_executable_object_source(input: OracleObjectSourceValidationInput) -> Result<(), String> {+ if !matches!(input.database_type, DatabaseType::Oracle | DatabaseType::OceanbaseOracle)+ || !matches!(+ input.object_type,+ ObjectSourceKind::Procedure+ | ObjectSourceKind::Function+ | ObjectSourceKind::Package+ | ObjectSourceKind::PackageBody+ )+ {+ return Err("Strict object-source validation is supported only for Oracle routines and packages.".to_string());+ }+ validate_oracle_object_source(+ input.database_type,+ &input.object_type,+ input.schema.as_deref(),+ &input.name,+ &input.source,+ )+}++pub fn fingerprint_oracle_routine_object_source(input: EditableObjectSourceSqlInput) -> Result<String, String> {+ if !matches!(input.database_type, DatabaseType::Oracle | DatabaseType::OceanbaseOracle)+ || !matches!(input.object_type, ObjectSourceKind::Procedure | ObjectSourceKind::Function)+ {+ return Err("Routine source fingerprinting is supported only for Oracle procedures and functions.".into());+ }+ validate_oracle_object_source(+ input.database_type,+ &input.object_type,+ input.schema.as_deref(),+ &input.name,+ &input.source,+ )?;++ let tokens = Tokenizer::new(&OracleDialect {}, &input.source)+ .tokenize_with_location()+ .map_err(|error| format!("Cannot tokenize Oracle routine source: {error}"))?;+ let mut tokens = tokens+ .iter()+ .filter(|token| {+ !matches!(+ &token.token,+ Token::Whitespace(Whitespace::Space | Whitespace::Tab | Whitespace::Newline) | Token::EOF+ )+ })+ .collect::<Vec<_>>();+ let last_statement_token = tokens.iter().rposition(|token| {+ !matches!(+ token.token,+ Token::Whitespace(Whitespace::SingleLineComment { .. } | Whitespace::MultiLineComment(_))+ )+ });+ if last_statement_token.is_some_and(|index| tokens[index].token == Token::SemiColon) {+ tokens.remove(last_statement_token.unwrap());+ }+ let token_fingerprints = tokens+ .iter()+ .map(|token| {+ let start = routine_location_to_byte_offset(&input.source, token.span.start)+ .ok_or_else(|| "Cannot map Oracle routine token positions to the source text.".to_string())?;+ let end = routine_location_to_byte_offset(&input.source, token.span.end)+ .ok_or_else(|| "Cannot map Oracle routine token positions to the source text.".to_string())?;+ if start >= end || end > input.source.len() {+ return Err("Oracle routine token positions overlap or exceed the source text.".to_string());+ }+ Ok(input.source[start..end].to_string())+ })+ .collect::<Result<Vec<_>, String>>()?;+ serde_json::to_string(&token_fingerprints)+ .map_err(|error| format!("Cannot encode Oracle routine fingerprint: {error}"))+}+pub fn build_executable_object_source_sql(input: EditableObjectSourceSqlInput) -> Result<String, String> {Ok(build_executable_object_source_statements(input)?.join("\n"))}+fn validate_oracle_object_source(+ database_type: DatabaseType,+ object_type: &ObjectSourceKind,+ schema: Option<&str>,+ name: &str,+ source: &str,+) -> Result<(), String> {+ let initial_tokens =+ Tokenizer::new(&OracleDialect {}, source).tokenize_with_location().map_err(|error| error.to_string())?;+ let first_significant = initial_tokens.iter().find(|token| !matches!(token.token, Token::Whitespace(_)));+ let source = if first_significant.is_some_and(|token| token_word_is(&token.token, "CREATE")) {+ source.to_string()+ } else if matches!(object_type, ObjectSourceKind::Procedure | ObjectSourceKind::Function) {+ format!("CREATE OR REPLACE {}", source.trim())+ } else {+ format!("CREATE {}", source.trim())+ };+ let statements = split_sql_statements_for_database(&source, database_type);+ if statements.len() != 1 {+ return Err("Oracle object source must contain exactly one complete object definition.".to_string());+ }++ let tokens =+ Tokenizer::new(&OracleDialect {}, &source).tokenize_with_location().map_err(|error| error.to_string())?;+ let significant = tokens+ .iter()+ .enumerate()+ .filter_map(|(index, token)| (!matches!(token.token, Token::Whitespace(_))).then_some(index))+ .collect::<Vec<_>>();+ let token_at = |position: usize| significant.get(position).map(|index| &tokens[*index].token);+ let mut position = 0;+ if !token_at(position).is_some_and(|token| token_word_is(token, "CREATE")) {+ return Err("Oracle object source must begin with CREATE.".to_string());+ }+ position += 1;+ if token_at(position).is_some_and(|token| token_word_is(token, "OR")) {+ if !token_at(position + 1).is_some_and(|token| token_word_is(token, "REPLACE")) {+ return Err("Oracle object source has an invalid CREATE prefix.".to_string());+ }+ position += 2;+ }+ if token_at(position)+ .is_some_and(|token| token_word_is(token, "EDITIONABLE") || token_word_is(token, "NONEDITIONABLE"))+ {+ position += 1;+ }++ let kind_matches = match object_type {+ ObjectSourceKind::Procedure => token_at(position).is_some_and(|token| token_word_is(token, "PROCEDURE")),+ ObjectSourceKind::Function => token_at(position).is_some_and(|token| token_word_is(token, "FUNCTION")),+ ObjectSourceKind::Package => {+ token_at(position).is_some_and(|token| token_word_is(token, "PACKAGE"))+ && !token_at(position + 1).is_some_and(|token| token_word_is(token, "BODY"))+ }+ ObjectSourceKind::PackageBody => {+ token_at(position).is_some_and(|token| token_word_is(token, "PACKAGE"))+ && token_at(position + 1).is_some_and(|token| token_word_is(token, "BODY"))+ }+ _ => false,+ };+ if !kind_matches {+ return Err(format!("Oracle object source declaration does not match {object_type:?}."));+ }+ position += 1;+ if *object_type == ObjectSourceKind::PackageBody {+ position += 1;+ }++ let first_name = token_at(position).ok_or_else(|| "Oracle object source has no declaration name.".to_string())?;+ let (owner, declared_name, consumed) = if token_at(position + 1) == Some(&Token::Period) {+ let declared_name = token_at(position + 2)+ .ok_or_else(|| "Oracle object source has an incomplete qualified name.".to_string())?;+ (Some(first_name), declared_name, 3)+ } else {+ (None, first_name, 1)+ };+ if !oracle_identifier_matches(declared_name, name) {+ return Err(format!("Oracle source declares a different object than {name}."));+ }+ if let Some(Token::Word(owner)) = owner {+ if schema.is_some_and(|schema| !oracle_identifier_matches(&Token::Word(owner.clone()), schema)) {+ return Err("Oracle object source owner does not match the selected schema.".to_string());+ }+ } else if owner.is_some() {+ return Err("Oracle object source has an invalid owner identifier.".to_string());+ }+ if token_at(position + consumed).is_some_and(|token| token == &Token::Period) {+ return Err("Three-part Oracle object names are not supported.".to_string());+ }+ Ok(())+}++fn oracle_identifier_matches(token: &Token, expected: &str) -> bool {+ matches!(token, Token::Word(word) if identifier_matches(word, expected))+}+/// Convert a raw database object source into a form suitable for the source editor.////// This is the *editable* presentation shown to the user when they open a view,@@ -540,6 +1071,11 @@ fn source_starts_with_create_or_alter(source: &str) -> bool {Regex::new(r"(?i)^(?:CREATE|ALTER)\s+").unwrap().is_match(executable)}+fn source_starts_with_create(source: &str) -> bool {+ let executable = &source[leading_sql_statement_start(source)..];+ Regex::new(r"(?i)^CREATE\s+").unwrap().is_match(executable)+}+fn source_starts_with_alter(source: &str) -> bool {let executable = &source[leading_sql_statement_start(source)..];Regex::new(r"(?i)^ALTER\s+").unwrap().is_match(executable)@@ -1070,6 +1606,185 @@ fn replace_sql_routine_declaration_name(source: &str, schema: Option<&str>, new_Some(format!("{}{}{}{}", &source[..full.start()], prefix, replacement, &source[full.end()..]))}+fn rewrite_oracle_routine_self_references(+ source: &str,+ old_name: &str,+ new_name: &str,+ schema: Option<&str>,+ object_type: ObjectSourceKind,+) -> Result<String, String> {+ let tokens = Tokenizer::new(&OracleDialect {}, source)+ .tokenize_with_location()+ .map_err(|error| format!("Cannot safely tokenize the routine source: {error}"))?;+ let significant = tokens+ .iter()+ .enumerate()+ .filter_map(|(index, token)| (!matches!(token.token, Token::Whitespace(_))).then_some(index))+ .collect::<Vec<_>>();+ if old_name != new_name {+ if let Some(execute_index) =+ find_oracle_execute_immediate(significant.iter().copied().map(|index| (index, &tokens[index].token)))+ {+ let location = tokens[execute_index].span.start;+ return Err(format!(+ "Dynamic SQL must be rewritten as a verifiable static call at line {}, column {}.",+ location.line, location.column+ ));+ }+ }+ let routine_kind_position = significant+ .iter()+ .position(|index| {+ token_word_is(&tokens[*index].token, "FUNCTION") || token_word_is(&tokens[*index].token, "PROCEDURE")+ })+ .ok_or_else(|| "Cannot locate the routine declaration.".to_string())?;+ let mut declaration_name_position = routine_kind_position + 1;+ if significant.get(declaration_name_position + 1).is_some_and(|index| tokens[*index].token == Token::Period) {+ declaration_name_position += 2;+ }+ let body_start = (declaration_name_position + 1..significant.len())+ .find(|position| {+ token_word_is(&tokens[significant[*position]].token, "AS")+ || token_word_is(&tokens[significant[*position]].token, "IS")+ })+ .ok_or_else(|| "Cannot locate the routine body.".to_string())?;+ let declaration_end = (body_start + 1..significant.len())+ .find(|position| token_word_is(&tokens[significant[*position]].token, "BEGIN"))+ .unwrap_or(significant.len());+ if significant[body_start + 1..declaration_end]+ .iter()+ .any(|index| token_matches_identifier(&tokens[*index].token, old_name))+ {+ return Err(format!("A local declaration named {old_name} may shadow self-recursive calls."));+ }+ if (body_start + 1..significant.len()).any(|position| {+ (token_word_is(&tokens[significant[position]].token, "FUNCTION")+ || token_word_is(&tokens[significant[position]].token, "PROCEDURE"))+ && significant+ .get(position + 1)+ .is_some_and(|index| token_matches_identifier(&tokens[*index].token, old_name))+ }) {+ return Err(format!("A local routine named {old_name} may shadow self-recursive calls."));+ }+ if old_name != new_name+ && significant[body_start + 1..].iter().any(|index| token_matches_identifier(&tokens[*index].token, new_name))+ {+ return Err(format!(+ "The new routine name {new_name} already occurs in the body and could capture an existing reference."+ ));+ }+ let mut end = significant.len();+ if significant.last().is_some_and(|index| tokens[*index].token == Token::SemiColon) {+ end -= 1;+ }+ let outer_end = (end >= body_start + 2+ && token_word_is(&tokens[significant[end - 2]].token, "END")+ && token_matches_identifier(&tokens[significant[end - 1]].token, old_name))+ .then_some(significant[end - 1]);++ let mut edits = Vec::new();+ for position in body_start..significant.len() {+ let token_index = significant[position];+ let token = &tokens[token_index];+ if !token_matches_identifier(&token.token, old_name) {+ continue;+ }+ if Some(token_index) == outer_end {+ edits.push((token.span, quote_postgres_identifier(new_name)));+ continue;+ }+ let previous = position.checked_sub(1).map(|index| &tokens[significant[index]].token);+ let previous_previous = position.checked_sub(2).map(|index| &tokens[significant[index]].token);+ let qualified_owner = if previous == Some(&Token::Period) {+ let Some(Token::Word(owner)) = previous_previous else {+ return Err(format!("Cannot determine which routine reference to rename: {old_name}."));+ };+ if schema.is_some_and(|schema| identifier_matches(owner, schema)) {+ true+ } else {+ continue;+ }+ } else {+ false+ };+ let next = significant.get(position + 1).map(|index| &tokens[*index].token);+ let is_call = matches!(next, Some(Token::LParen))+ || (object_type == ObjectSourceKind::Procedure && matches!(next, Some(Token::SemiColon)));+ if is_call && (!matches!(previous, Some(Token::Period)) || qualified_owner) {+ edits.push((token.span, quote_postgres_identifier(new_name)));+ } else {+ return Err(format!(+ "Cannot safely determine whether {old_name} is a self-reference or another identifier."+ ));+ }+ }++ let mut result = source.to_string();+ for (span, replacement) in edits.into_iter().rev() {+ let start = routine_location_to_byte_offset(source, span.start)+ .ok_or_else(|| "Cannot map routine token positions to the source text.".to_string())?;+ let end = routine_location_to_byte_offset(source, span.end)+ .ok_or_else(|| "Cannot map routine token positions to the source text.".to_string())?;+ if start >= end || end > result.len() {+ return Err("Routine token positions overlap or exceed the source text.".to_string());+ }+ result.replace_range(start..end, &replacement);+ }+ Ok(result)+}++fn routine_location_to_byte_offset(source: &str, location: sqlparser::tokenizer::Location) -> Option<usize> {+ let mut line = 1;+ let mut column = 1;+ for (offset, character) in source.char_indices() {+ if line == location.line && column == location.column {+ return Some(offset);+ }+ if character == '\n' {+ line += 1;+ column = 1;+ } else {+ column += 1;+ }+ }+ (line == location.line && column == location.column).then_some(source.len())+}++fn token_word_is(token: &Token, expected: &str) -> bool {+ matches!(token, Token::Word(word) if word.value.eq_ignore_ascii_case(expected))+}++fn find_oracle_execute_immediate<'a>(tokens: impl IntoIterator<Item = (usize, &'a Token)>) -> Option<usize> {+ let mut previous: Option<(usize, &'a Token)> = None;+ for (index, token) in tokens {+ if let Some((previous_index, previous_token)) = previous {+ if token_unquoted_word_is(previous_token, "EXECUTE") && token_unquoted_word_is(token, "IMMEDIATE") {+ return Some(previous_index);+ }+ }+ previous = Some((index, token));+ }+ None+}++fn token_unquoted_word_is(token: &Token, expected: &str) -> bool {+ matches!(token, Token::Word(word) if word.quote_style.is_none() && word.value.eq_ignore_ascii_case(expected))+}++fn token_matches_identifier(token: &Token, expected: &str) -> bool {+ matches!(token, Token::Word(word) if identifier_matches(word, expected))+}++fn identifier_matches(identifier: &sqlparser::tokenizer::Word, expected: &str) -> bool {+ if identifier.quote_style.is_some() {+ identifier.value == expected+ } else if identifier.keyword != Keyword::NoKeyword {+ false+ } else {+ identifier.value.to_ascii_uppercase() == expected+ }+}+fn mysql_routine_declaration(source: &str) -> Option<RoutineDeclaration> {let re = Regex::new(r"(?is)^\s*CREATE\s+(?:DEFINER\s*=\s*(?:(?:`(?:``|[^`])+`|'(?:''|[^'])+'|[^\s]+)\s*@\s*(?:`(?:``|[^`])+`|'(?:''|[^'])+'|[^\s]+)|CURRENT_USER(?:\(\))?)\s+)?(FUNCTION|PROCEDURE)\s+(?:IF\s+NOT\s+EXISTS\s+)?((?:`(?:``|[^`])+`|[A-Za-z_][\w$]*)(?:\s*\.\s*(?:`(?:``|[^`])+`|[A-Za-z_][\w$]*))?)",@@ -1157,6 +1872,64 @@ fn parse_object_source_kind(value: &str) -> Option<ObjectSourceKind> {mod tests {use super::*;+ fn oracle_routine_fingerprint(source: &str) -> Result<String, String> {+ fingerprint_oracle_routine_object_source(EditableObjectSourceSqlInput {+ database_type: DatabaseType::OceanbaseOracle,+ object_type: ObjectSourceKind::Procedure,+ schema: Some("APP".into()),+ name: "CALLER_1".into(),+ source: source.into(),+ })+ }++ #[test]+ fn oracle_routine_source_fingerprint_ignores_only_whitespace_and_one_final_semicolon() {+ let submitted = "CREATE OR REPLACE PROCEDURE APP.CALLER_1 IS BEGIN APP.P_NEW; APP.P_NEW; END;";+ let readback = "CREATE OR REPLACE PROCEDURE APP.CALLER_1\n IS\nBEGIN APP.P_NEW; APP.P_NEW; END";++ assert_eq!(oracle_routine_fingerprint(submitted).unwrap(), oracle_routine_fingerprint(readback).unwrap());+ }++ #[test]+ fn oracle_routine_source_fingerprint_preserves_literals_comments_hints_and_identifiers() {+ let base = "CREATE OR REPLACE PROCEDURE APP.CALLER_1 IS BEGIN DBMS_OUTPUT.PUT_LINE('a b'); APP.P_NEW; END;";+ for changed in [+ "CREATE OR REPLACE PROCEDURE APP.CALLER_1 IS BEGIN DBMS_OUTPUT.PUT_LINE('a b'); APP.P_NEW; END;",+ "CREATE OR REPLACE PROCEDURE APP.CALLER_1 IS BEGIN /* changed */ DBMS_OUTPUT.PUT_LINE('a b'); APP.P_NEW; END;",+ "CREATE OR REPLACE PROCEDURE APP.CALLER_1 IS BEGIN /*+ changed */ DBMS_OUTPUT.PUT_LINE('a b'); APP.P_NEW; END;",+ "CREATE OR REPLACE PROCEDURE APP.CALLER_1 IS BEGIN DBMS_OUTPUT.PUT_LINE(q'{a b}'); APP.P_NEW; END;",+ "CREATE OR REPLACE PROCEDURE APP.CALLER_1 IS BEGIN DBMS_OUTPUT.PUT_LINE(q'{a b}'); \"APP\".P_NEW; END;",+ "CREATE OR REPLACE PROCEDURE APP.CALLER_1 IS BEGIN DBMS_OUTPUT.PUT_LINE('a b'); APP.P_OTHER; END;",+ ] {+ assert_ne!(oracle_routine_fingerprint(base).unwrap(), oracle_routine_fingerprint(changed).unwrap());+ }+ let q_literal = "CREATE OR REPLACE PROCEDURE APP.CALLER_1 IS BEGIN DBMS_OUTPUT.PUT_LINE(q'{a b}'); END;";+ let changed_q_literal =+ "CREATE OR REPLACE PROCEDURE APP.CALLER_1 IS BEGIN DBMS_OUTPUT.PUT_LINE(q'{a b}'); END;";+ let nq_literal = "CREATE OR REPLACE PROCEDURE APP.CALLER_1 IS BEGIN DBMS_OUTPUT.PUT_LINE(nq'{a b}'); END;";+ let changed_nq_literal =+ "CREATE OR REPLACE PROCEDURE APP.CALLER_1 IS BEGIN DBMS_OUTPUT.PUT_LINE(nq'{a b}'); END;";+ assert_ne!(+ oracle_routine_fingerprint(q_literal).unwrap(),+ oracle_routine_fingerprint(changed_q_literal).unwrap()+ );+ assert_ne!(+ oracle_routine_fingerprint(nq_literal).unwrap(),+ oracle_routine_fingerprint(changed_nq_literal).unwrap()+ );+ }++ #[test]+ fn oracle_routine_source_fingerprint_rejects_wrong_identity_and_multiple_statements() {+ for source in [+ "CREATE OR REPLACE PROCEDURE OTHER.CALLER_1 IS BEGIN APP.P_NEW; END;",+ "CREATE OR REPLACE PROCEDURE APP.OTHER IS BEGIN APP.P_NEW; END;",+ "CREATE OR REPLACE PROCEDURE APP.CALLER_1 IS BEGIN APP.P_NEW; END; SELECT 1",+ ] {+ assert!(oracle_routine_fingerprint(source).is_err(), "accepted invalid source: {source}");+ }+ }+fn ob_sequence(source: &str, schema: Option<&str>, name: &str) -> EditableObjectSourceSqlInput {EditableObjectSourceSqlInput {database_type: DatabaseType::OceanbaseOracle,@@ -2033,7 +2806,9 @@ mod tests {assert_eq!(statements,- vec!["CREATE OR REPLACE PROCEDURE refresh_cache AS\nBEGIN\n DELETE FROM cache_entries;\n COMMIT;\nEND;"]+ vec![+ "CREATE OR REPLACE PROCEDURE refresh_cache AS\nBEGIN\n DELETE FROM cache_entries;\n COMMIT;\nEND;"+ ]);}}@@ -2061,11 +2836,13 @@ mod tests {"CREATE PROCEDURE refresh_cache AS BEGIN NULL; END;","CREATE OR REPLACE PROCEDURE refresh_cache AS BEGIN NULL; END;",] {- let statements = build_executable_object_source_statements(input(- DatabaseType::Oracle,- ObjectSourceKind::Procedure,- source,- ))+ let statements = build_executable_object_source_statements(EditableObjectSourceSqlInput {+ database_type: DatabaseType::Oracle,+ object_type: ObjectSourceKind::Procedure,+ schema: Some("public".to_string()),+ name: "REFRESH_CACHE".to_string(),+ source: source.to_string(),+ }).unwrap();assert_eq!(statements, vec![source]);@@ -2417,4 +3194,565 @@ mod tests {]);}++ #[test]+ fn oceanbase_routine_source_builder_rewrites_self_reference_for_planned_migration() {+ let statements = build_routine_rename_object_source_statements(RoutineRenameObjectSourceInput {+ database_type: DatabaseType::OceanbaseOracle,+ object_type: ObjectSourceKind::Procedure,+ schema: Some("APP".into()),+ name: "P_OLD".into(),+ new_name: "P_NEW".into(),+ source: "CREATE OR REPLACE PROCEDURE APP.P_OLD AS BEGIN P_OLD; END P_OLD;".into(),+ })+ .unwrap();++ assert_eq!(statements[0], "CREATE OR REPLACE PROCEDURE \"APP\".\"P_NEW\" AS BEGIN \"P_NEW\"; END \"P_NEW\";");+ assert_eq!(statements[1], "DROP PROCEDURE \"APP\".\"P_OLD\";");+ }++ #[test]+ fn oracle_routine_rename_rejects_mismatched_owner_name_and_extra_sql() {+ for source in [+ "CREATE OR REPLACE PROCEDURE APP.P_OTHER AS BEGIN APP.P_OLD; END;",+ "CREATE OR REPLACE PROCEDURE OTHER.P_OLD AS BEGIN NULL; END;",+ "CREATE OR REPLACE PROCEDURE APP.P_OLD AS BEGIN NULL; END; DROP TABLE T;",+ ] {+ let result = build_routine_rename_object_source_statements(RoutineRenameObjectSourceInput {+ database_type: DatabaseType::Oracle,+ object_type: ObjectSourceKind::Procedure,+ schema: Some("APP".into()),+ name: "P_OLD".into(),+ new_name: "P_NEW".into(),+ source: source.into(),+ });+ assert!(result.is_err(), "accepted unsafe source: {source}");+ }+ }++ #[test]+ fn oracle_executable_routine_rejects_wrong_identity_and_create_or_replace() {+ for source in [+ "CREATE OR REPLACE PROCEDURE APP.P_OTHER AS BEGIN NULL; END;",+ "CREATE PROCEDURE OTHER.P_OLD AS BEGIN NULL; END;",+ "CREATE OR REPLACE PROCEDURE APP.P_OLD AS BEGIN NULL; END; DROP TABLE T;",+ ] {+ let result = build_executable_object_source_statements(EditableObjectSourceSqlInput {+ database_type: DatabaseType::Oracle,+ object_type: ObjectSourceKind::Procedure,+ schema: Some("APP".into()),+ name: "P_OLD".into(),+ source: source.into(),+ });+ assert!(result.is_err(), "accepted unsafe source: {source}");+ }+ }++ #[test]+ fn oracle_executable_package_source_requires_exact_identity_and_one_unit() {+ let valid = build_executable_object_source_statements(EditableObjectSourceSqlInput {+ database_type: DatabaseType::Oracle,+ object_type: ObjectSourceKind::Package,+ schema: Some("APP".into()),+ name: "P_NEW".into(),+ source: "CREATE PACKAGE APP.P_NEW AS PROCEDURE RUN; END P_NEW;".into(),+ })+ .unwrap();+ assert_eq!(valid.len(), 1);++ for source in [+ "CREATE PACKAGE APP.P_OTHER AS PROCEDURE RUN; END P_OTHER;",+ "CREATE PACKAGE OTHER.P_NEW AS PROCEDURE RUN; END P_NEW;",+ "CREATE PACKAGE APP.P_NEW AS PROCEDURE RUN; END P_NEW; BEGIN DROP TABLE T; END;",+ ] {+ let result = build_executable_object_source_statements(EditableObjectSourceSqlInput {+ database_type: DatabaseType::Oracle,+ object_type: ObjectSourceKind::Package,+ schema: Some("APP".into()),+ name: "P_NEW".into(),+ source: source.into(),+ });+ assert!(result.is_err(), "accepted unsafe package source: {source}");+ }+ }++ #[test]+ fn oracle_executable_source_respects_quoted_mixed_case_identity() {+ let input = |source: &str| EditableObjectSourceSqlInput {+ database_type: DatabaseType::Oracle,+ object_type: ObjectSourceKind::Package,+ schema: Some("MiXeD".into()),+ name: "Pkg".into(),+ source: source.into(),+ };++ assert!(build_executable_object_source_statements(input(+ "CREATE PACKAGE \"MiXeD\".\"Pkg\" AS PROCEDURE RUN; END \"Pkg\";"+ ))+ .is_ok());+ for source in [+ "CREATE PACKAGE MIXED.\"Pkg\" AS PROCEDURE RUN; END \"Pkg\";",+ "CREATE PACKAGE \"MiXeD\".PKG AS PROCEDURE RUN; END PKG;",+ ] {+ assert!(+ build_executable_object_source_statements(input(source)).is_err(),+ "accepted identity with incorrect case semantics: {source}"+ );+ }+ }++ #[test]+ fn oracle_strict_source_validation_checks_create_and_bare_definitions() {+ let validate = |source: &str| {+ validate_oracle_executable_object_source(OracleObjectSourceValidationInput {+ database_type: DatabaseType::Oracle,+ object_type: ObjectSourceKind::Procedure,+ schema: Some("APP".into()),+ name: "P_OLD".into(),+ source: source.into(),+ })+ };++ for source in [+ "CREATE OR REPLACE PROCEDURE APP.P_OTHER AS BEGIN APP.P_OLD; END;",+ "PROCEDURE APP.P_OTHER AS BEGIN APP.P_OLD; END;",+ "CREATE PROCEDURE OTHER.P_OLD AS BEGIN NULL; END;",+ "CREATE/*comment*/ OR REPLACE PROCEDURE APP.P_OTHER AS BEGIN NULL; END;",+ "CREATE OR REPLACE FUNCTION APP.P_OLD RETURN NUMBER AS BEGIN RETURN 1; END;",+ "CREATE OR REPLACE PROCEDURE APP.P_OLD AS BEGIN NULL; END; DROP TABLE T;",+ ] {+ assert!(validate(source).is_err(), "accepted unsafe source: {source}");+ }++ assert!(validate(+ "CREATE/*prefix*/OR/*replace*/REPLACE/*kind*/PROCEDURE APP.P_OLD AS BEGIN IF 1 = 1 THEN NULL; END IF; EXECUTE IMMEDIATE 'BEGIN NULL; END;'; END;"+ )+ .is_ok());+ assert!(validate(+ "PROCEDURE APP.P_OLD AS BEGIN IF 1 = 1 THEN NULL; END IF; EXECUTE IMMEDIATE 'BEGIN NULL; END;'; END;"+ )+ .is_ok());+ }++ #[test]+ fn oracle_family_routine_rename_updates_self_recursion_and_outer_end_only() {+ let source = r#"CREATE OR REPLACE FUNCTION "SYSDBA"."F_REC"(N NUMBER) RETURN NUMBER AS+BEGIN+ -- 注释中的 F_REC 必须保持不变。+ IF N <= 1 THEN RETURN 'F_REC'; END IF;+ RETURN "SYSDBA"."F_REC"(N - 1);+END F_REC;"#+ .replace('\n', "\r\n");+ let statements = build_routine_rename_object_source_statements(RoutineRenameObjectSourceInput {+ database_type: DatabaseType::Dameng,+ object_type: ObjectSourceKind::Function,+ schema: Some("SYSDBA".to_string()),+ name: "F_REC".to_string(),+ new_name: "F_REC_2".to_string(),+ source: source.to_string(),+ })+ .unwrap();++ assert_eq!(+ statements[0],+ r#"CREATE OR REPLACE FUNCTION "SYSDBA"."F_REC_2"(N NUMBER) RETURN NUMBER AS+BEGIN+ -- 注释中的 F_REC 必须保持不变。+ IF N <= 1 THEN RETURN 'F_REC'; END IF;+ RETURN "SYSDBA"."F_REC_2"(N - 1);+END "F_REC_2";"#+ .replace('\n', "\r\n")+ );+ }++ #[test]+ fn oracle_family_routine_rename_does_not_treat_matching_schema_as_a_self_reference() {+ let statements = build_routine_rename_object_source_statements(RoutineRenameObjectSourceInput {+ database_type: DatabaseType::Oracle,+ object_type: ObjectSourceKind::Procedure,+ schema: Some("F_REC".to_string()),+ name: "F_REC".to_string(),+ new_name: "F_REC_2".to_string(),+ source: "CREATE OR REPLACE PROCEDURE \"F_REC\".\"F_REC\" AS BEGIN F_REC; END F_REC;".to_string(),+ })+ .unwrap();++ assert_eq!(+ statements[0],+ "CREATE OR REPLACE PROCEDURE \"F_REC\".\"F_REC_2\" AS BEGIN \"F_REC_2\"; END \"F_REC_2\";"+ );+ }++ #[test]+ fn oracle_family_routine_rename_rejects_ambiguous_old_name_use() {+ let result = build_routine_rename_object_source_statements(RoutineRenameObjectSourceInput {+ database_type: DatabaseType::Oracle,+ object_type: ObjectSourceKind::Function,+ schema: Some("APP".to_string()),+ name: "F_REC".to_string(),+ new_name: "F_REC_2".to_string(),+ source: "CREATE FUNCTION APP.F_REC(N NUMBER) RETURN NUMBER AS BEGIN SELECT F_REC INTO N FROM T; RETURN N; END F_REC;".to_string(),+ });++ assert!(result.unwrap_err().contains("Cannot safely determine whether F_REC"));+ }++ #[test]+ fn oracle_family_routine_rename_rejects_new_name_capture() {+ let result = build_routine_rename_object_source_statements(RoutineRenameObjectSourceInput {+ database_type: DatabaseType::Oracle,+ object_type: ObjectSourceKind::Function,+ schema: Some("APP".to_string()),+ name: "F_REC".to_string(),+ new_name: "F_REC_2".to_string(),+ source: "CREATE FUNCTION APP.F_REC(N NUMBER) RETURN NUMBER AS BEGIN RETURN F_REC_2(N - 1); END F_REC;"+ .to_string(),+ });++ assert!(result.unwrap_err().contains("could capture an existing reference"));+ }++ #[test]+ fn oracle_family_routine_rename_rejects_local_routine_shadowing() {+ let result = build_routine_rename_object_source_statements(RoutineRenameObjectSourceInput {+ database_type: DatabaseType::Oracle,+ object_type: ObjectSourceKind::Function,+ schema: Some("APP".to_string()),+ name: "F_REC".to_string(),+ new_name: "F_REC_2".to_string(),+ source: "CREATE FUNCTION APP.F_REC(N NUMBER) RETURN NUMBER AS FUNCTION F_REC(X NUMBER) RETURN NUMBER IS BEGIN RETURN X; END F_REC; BEGIN RETURN F_REC(N - 1); END F_REC;".to_string(),+ });++ assert!(result.unwrap_err().contains("may shadow self-recursive calls"));+ }++ #[test]+ fn oracle_family_routine_rename_does_not_rewrite_keywords_matching_quoted_routine_name() {+ let statements = build_routine_rename_object_source_statements(RoutineRenameObjectSourceInput {+ database_type: DatabaseType::Oracle,+ object_type: ObjectSourceKind::Function,+ schema: Some("APP".to_string()),+ name: "IF".to_string(),+ new_name: "F_IF".to_string(),+ source: "CREATE FUNCTION APP.\"IF\"(N NUMBER) RETURN NUMBER AS BEGIN IF N = 0 THEN RETURN 0; END IF; RETURN \"IF\"(N - 1); END \"IF\";".to_string(),+ })+ .unwrap();++ assert_eq!(+ statements[0],+ "CREATE FUNCTION \"APP\".\"F_IF\"(N NUMBER) RETURN NUMBER AS BEGIN IF N = 0 THEN RETURN 0; END IF; RETURN \"F_IF\"(N - 1); END \"F_IF\";"+ );+ }++ #[test]+ fn oracle_routine_caller_rewrite_changes_only_static_calls() {+ let source = "CREATE OR REPLACE VIEW APP.V_CALL AS\r\nSELECT APP.F_OLD(ID), OTHER.F_OLD(ID), 'F_OLD()' AS NOTE FROM APP.T -- F_OLD()\r\n";+ let rewritten = rewrite_oracle_routine_references(OracleRoutineReferenceRewriteInput {+ database_type: DatabaseType::OceanbaseOracle,+ caller_type: ObjectSourceKind::View,+ target_type: ObjectSourceKind::Function,+ schema: Some("APP".into()),+ old_name: "F_OLD".into(),+ new_name: "F_NEW".into(),+ source: source.into(),+ })+ .unwrap();++ assert_eq!(+ rewritten,+ "CREATE OR REPLACE VIEW APP.V_CALL AS\r\nSELECT APP.\"F_NEW\"(ID), OTHER.F_OLD(ID), 'F_OLD()' AS NOTE FROM APP.T -- F_OLD()\r\n"+ );+ }++ #[test]+ fn oracle_routine_caller_rewrite_preserves_case_sensitive_sibling_calls() {+ let rewritten = rewrite_oracle_routine_references(OracleRoutineReferenceRewriteInput {+ database_type: DatabaseType::OceanbaseOracle,+ caller_type: ObjectSourceKind::Function,+ target_type: ObjectSourceKind::Function,+ schema: Some("APP".into()),+ old_name: "f_old".into(),+ new_name: "f_new".into(),+ source: "CREATE FUNCTION APP.CALLER RETURN NUMBER AS BEGIN RETURN \"f_old\"(1) + F_OLD(1); END;".into(),+ })+ .unwrap();++ assert_eq!(rewritten, "CREATE FUNCTION APP.CALLER RETURN NUMBER AS BEGIN RETURN \"f_new\"(1) + F_OLD(1); END;");+ }++ #[test]+ fn oracle_routine_caller_rewrite_rejects_new_name_capture_before_writing() {+ let result = rewrite_oracle_routine_references(OracleRoutineReferenceRewriteInput {+ database_type: DatabaseType::Oracle,+ caller_type: ObjectSourceKind::Function,+ target_type: ObjectSourceKind::Function,+ schema: Some("APP".into()),+ old_name: "F_OLD".into(),+ new_name: "F_NEW".into(),+ source: "CREATE FUNCTION APP.CALLER RETURN NUMBER AS FUNCTION F_NEW(X NUMBER) RETURN NUMBER IS BEGIN RETURN X; END; BEGIN RETURN F_OLD(1); END;".into(),+ });+ assert!(result.unwrap_err().contains("F_OLD or F_NEW"));+ }++ #[test]+ fn oracle_routine_caller_rewrite_rejects_dynamic_old_name_even_with_static_call() {+ let result = rewrite_oracle_routine_references(OracleRoutineReferenceRewriteInput {+ database_type: DatabaseType::Oracle,+ caller_type: ObjectSourceKind::Procedure,+ target_type: ObjectSourceKind::Procedure,+ schema: Some("SYS".into()),+ old_name: "DBX50_OLD_20261014_8F31".into(),+ new_name: "DBX50_NEW_20261014_8F31".into(),+ source: "CREATE OR REPLACE PROCEDURE \"SYS\".\"DBX50_CALL_20261014_8F31\" IS BEGIN DBX50_OLD_20261014_8F31; EXECUTE IMMEDIATE 'BEGIN DBX50_OLD_20261014_8F31; END;'; END".into(),+ });++ let error = result.unwrap_err();+ assert!(error.contains("Dynamic SQL"));+ assert!(error.contains("line 1") && error.contains("column"));+ }++ #[test]+ fn oracle_routine_caller_rewrite_rejects_dynamic_sql_forms_and_comment_separated_keywords() {+ for dynamic_sql in+ ["'BEGIN DBX50_OLD_20261014_8F31; END;'", "statement_text", "'BEGIN ' || 'DBX50_OLD_20261014_8F31; END;'"]+ {+ let source = format!(+ "CREATE OR REPLACE PROCEDURE SYS.CALLER IS BEGIN DBX50_OLD_20261014_8F31; EXECUTE /* comment */ IMMEDIATE {dynamic_sql}; END;"+ );+ let result = rewrite_oracle_routine_references(OracleRoutineReferenceRewriteInput {+ database_type: DatabaseType::Oracle,+ caller_type: ObjectSourceKind::Procedure,+ target_type: ObjectSourceKind::Procedure,+ schema: Some("SYS".into()),+ old_name: "DBX50_OLD_20261014_8F31".into(),+ new_name: "DBX50_NEW_20261014_8F31".into(),+ source,+ });++ let error = result.unwrap_err();+ assert!(error.contains("Dynamic SQL"), "accepted dynamic SQL: {dynamic_sql}");+ assert!(error.contains("line 1") && error.contains("column"));+ }+ }++ #[test]+ fn oracle_routine_caller_rewrite_ignores_execute_immediate_in_literals_comments_and_quoted_words() {+ let source = "CREATE OR REPLACE PROCEDURE SYS.CALLER IS v VARCHAR2(200); BEGIN DBX50_OLD_20261014_8F31; SELECT \"EXECUTE\" IMMEDIATE INTO v FROM DUAL; v := 'EXECUTE IMMEDIATE DBX50_OLD_20261014_8F31'; v := q'[EXECUTE IMMEDIATE DBX50_OLD_20261014_8F31]'; v := nq'[EXECUTE IMMEDIATE DBX50_OLD_20261014_8F31]'; -- EXECUTE IMMEDIATE DBX50_OLD_20261014_8F31\n DBMS_OUTPUT.PUT_LINE(\"EXECUTE\"); EXECUTE \"IMMEDIATE\"; END;";+ let rewritten = rewrite_oracle_routine_references(OracleRoutineReferenceRewriteInput {+ database_type: DatabaseType::Oracle,+ caller_type: ObjectSourceKind::Procedure,+ target_type: ObjectSourceKind::Procedure,+ schema: Some("SYS".into()),+ old_name: "DBX50_OLD_20261014_8F31".into(),+ new_name: "DBX50_NEW_20261014_8F31".into(),+ source: source.into(),+ })+ .unwrap();++ assert!(rewritten.contains("\"DBX50_NEW_20261014_8F31\";"));+ assert!(rewritten.contains("'EXECUTE IMMEDIATE DBX50_OLD_20261014_8F31'"));+ assert!(rewritten.contains("q'[EXECUTE IMMEDIATE DBX50_OLD_20261014_8F31]'"));+ assert!(rewritten.contains("nq'[EXECUTE IMMEDIATE DBX50_OLD_20261014_8F31]'"));+ }++ #[test]+ fn oracle_routine_self_reference_rewrite_rejects_dynamic_sql() {+ let result = build_routine_rename_object_source_statements(RoutineRenameObjectSourceInput {+ database_type: DatabaseType::Oracle,+ object_type: ObjectSourceKind::Procedure,+ schema: Some("SYS".into()),+ name: "DBX50_OLD_20261014_8F31".into(),+ new_name: "DBX50_NEW_20261014_8F31".into(),+ source: "CREATE OR REPLACE PROCEDURE SYS.DBX50_OLD_20261014_8F31 IS BEGIN DBX50_OLD_20261014_8F31; EXECUTE IMMEDIATE 'BEGIN DBX50_OLD_20261014_8F31; END;'; END;".into(),+ });++ let error = result.unwrap_err();+ assert!(error.contains("Dynamic SQL"));+ assert!(error.contains("line 1") && error.contains("column"));+ }++ #[test]+ fn oracle_routine_caller_rewrite_handles_unqualified_calls_and_rejects_ambiguous_forms() {+ let rewritten = rewrite_oracle_routine_references(OracleRoutineReferenceRewriteInput {+ database_type: DatabaseType::Oracle,+ caller_type: ObjectSourceKind::Procedure,+ target_type: ObjectSourceKind::Procedure,+ schema: Some("APP".into()),+ old_name: "P_OLD".into(),+ new_name: "P_NEW".into(),+ source: "CREATE PROCEDURE APP.CALLER AS BEGIN P_OLD; P_OLD(1); END;".into(),+ })+ .unwrap();+ assert_eq!(rewritten, "CREATE PROCEDURE APP.CALLER AS BEGIN \"P_NEW\"; \"P_NEW\"(1); END;");++ let result = rewrite_oracle_routine_references(OracleRoutineReferenceRewriteInput {+ database_type: DatabaseType::Oracle,+ caller_type: ObjectSourceKind::Function,+ target_type: ObjectSourceKind::Function,+ schema: Some("APP".into()),+ old_name: "F_OLD".into(),+ new_name: "F_NEW".into(),+ source: "CREATE FUNCTION APP.CALLER RETURN NUMBER AS BEGIN RETURN F_OLD.VALUE; END;".into(),+ });+ assert!(result.unwrap_err().contains("unsupported form"));++ let scalar_reference = rewrite_oracle_routine_references(OracleRoutineReferenceRewriteInput {+ database_type: DatabaseType::Oracle,+ caller_type: ObjectSourceKind::Function,+ target_type: ObjectSourceKind::Function,+ schema: Some("APP".into()),+ old_name: "F_OLD".into(),+ new_name: "F_NEW".into(),+ source: "CREATE FUNCTION APP.CALLER RETURN NUMBER AS F_OLD NUMBER; BEGIN RETURN F_OLD; END;".into(),+ });+ assert!(scalar_reference.unwrap_err().contains("local declaration may shadow"));++ let procedure_from_view = rewrite_oracle_routine_references(OracleRoutineReferenceRewriteInput {+ database_type: DatabaseType::Oracle,+ caller_type: ObjectSourceKind::View,+ target_type: ObjectSourceKind::Procedure,+ schema: Some("APP".into()),+ old_name: "P_OLD".into(),+ new_name: "P_NEW".into(),+ source: "CREATE VIEW APP.V_CALL AS SELECT P_OLD(1) FROM DUAL".into(),+ });+ assert!(procedure_from_view.unwrap_err().contains("does not contain a verifiable static call"));+ }++ #[test]+ fn oracle_routine_caller_rewrite_rejects_shadowed_collection_calls() {+ let result = rewrite_oracle_routine_references(OracleRoutineReferenceRewriteInput {+ database_type: DatabaseType::Oracle,+ caller_type: ObjectSourceKind::Function,+ target_type: ObjectSourceKind::Function,+ schema: Some("APP".into()),+ old_name: "F_OLD".into(),+ new_name: "F_NEW".into(),+ source: "CREATE FUNCTION APP.CALLER RETURN NUMBER AS TYPE numbers IS TABLE OF NUMBER; F_OLD numbers; BEGIN RETURN F_OLD(1) + APP.F_OLD(1); END;".into(),+ });++ assert!(result.unwrap_err().contains("local declaration may shadow"));+ }++ #[test]+ fn oracle_routine_caller_rewrite_rejects_shadowed_nested_block_and_parameter_names() {+ for source in [+ "CREATE FUNCTION APP.CALLER RETURN NUMBER AS BEGIN DECLARE TYPE numbers IS TABLE OF NUMBER; F_OLD numbers; BEGIN RETURN F_OLD(1) + APP.F_OLD(1); END; END;",+ "CREATE FUNCTION APP.CALLER(F_OLD NUMBER) RETURN NUMBER AS BEGIN RETURN APP.F_OLD(1); END;",+ "CREATE PROCEDURE APP.CALLER AS PROCEDURE helper IS BEGIN NULL; END; PROCEDURE worker IS TYPE numbers IS TABLE OF NUMBER; F_OLD numbers; BEGIN F_OLD(1) := 1; APP.F_OLD(1); END; BEGIN worker; END;",+ ] {+ let result = rewrite_oracle_routine_references(OracleRoutineReferenceRewriteInput {+ database_type: DatabaseType::Oracle,+ caller_type: ObjectSourceKind::Function,+ target_type: ObjectSourceKind::Function,+ schema: Some("APP".into()),+ old_name: "F_OLD".into(),+ new_name: "F_NEW".into(),+ source: source.into(),+ });++ assert!(result.unwrap_err().contains("local declaration may shadow"));+ }+ }++ #[test]+ fn oracle_routine_caller_rewrite_rejects_shadowed_schema_qualifiers() {+ let result = rewrite_oracle_routine_references(OracleRoutineReferenceRewriteInput {+ database_type: DatabaseType::Oracle,+ caller_type: ObjectSourceKind::Function,+ target_type: ObjectSourceKind::Function,+ schema: Some("APP".into()),+ old_name: "F_OLD".into(),+ new_name: "F_NEW".into(),+ source: "CREATE FUNCTION APP.CALLER RETURN NUMBER AS APP RECORD; BEGIN RETURN APP.F_OLD(1); END;".into(),+ });++ assert!(result.unwrap_err().contains("schema qualifier may be shadowed"));+ }++ #[test]+ fn oracle_table_reference_rewrite_updates_static_sql_and_record_types_only() {+ let source = "CREATE OR REPLACE PROCEDURE APP.P AS r APP.T_OLD%ROWTYPE; v APP.T_OLD.V%TYPE; BEGIN SELECT COUNT(*) INTO v FROM APP.T_OLD; END;";+ let rewritten = rewrite_oracle_table_references(OracleTableReferenceRewriteInput {+ database_type: DatabaseType::OceanbaseOracle,+ object_type: ObjectSourceKind::Procedure,+ schema: Some("APP".into()),+ old_name: "T_OLD".into(),+ new_name: "T_NEW".into(),+ source: source.into(),+ })+ .unwrap();+ assert_eq!(+ rewritten,+ "CREATE OR REPLACE PROCEDURE APP.P AS r APP.\"T_NEW\"%ROWTYPE; v APP.\"T_NEW\".V%TYPE; BEGIN SELECT COUNT(*) INTO v FROM APP.\"T_NEW\"; END;"+ );+ }++ #[test]+ fn oracle_table_reference_rewrite_updates_trigger_binding_without_touching_literals_or_other_owner() {+ let source = "CREATE OR REPLACE TRIGGER APP.TR_OLD BEFORE INSERT ON APP.T_OLD FOR EACH ROW BEGIN :NEW.V := 'T_OLD'; -- T_OLD\n NULL; END;";+ let rewritten = rewrite_oracle_table_references(OracleTableReferenceRewriteInput {+ database_type: DatabaseType::OceanbaseOracle,+ object_type: ObjectSourceKind::Trigger,+ schema: Some("APP".into()),+ old_name: "T_OLD".into(),+ new_name: "T_NEW".into(),+ source: source.into(),+ })+ .unwrap();+ assert_eq!(+ rewritten,+ "CREATE OR REPLACE TRIGGER APP.TR_OLD BEFORE INSERT ON APP.\"T_NEW\" FOR EACH ROW BEGIN :NEW.V := 'T_OLD'; -- T_OLD\n NULL; END;"+ );++ let other_owner = rewrite_oracle_table_references(OracleTableReferenceRewriteInput {+ database_type: DatabaseType::Oracle,+ object_type: ObjectSourceKind::Procedure,+ schema: Some("APP".into()),+ old_name: "T_OLD".into(),+ new_name: "T_NEW".into(),+ source: "CREATE PROCEDURE APP.P AS n NUMBER; BEGIN SELECT COUNT(*) INTO n FROM OTHER.T_OLD; END;".into(),+ });+ assert!(other_owner.unwrap_err().contains("no verifiable static reference"));+ }++ #[test]+ fn oracle_table_reference_rewrite_rejects_ambiguous_and_dynamic_source() {+ let ambiguous = rewrite_oracle_table_references(OracleTableReferenceRewriteInput {+ database_type: DatabaseType::OceanbaseOracle,+ object_type: ObjectSourceKind::Procedure,+ schema: Some("APP".into()),+ old_name: "T_OLD".into(),+ new_name: "T_NEW".into(),+ source: "CREATE PROCEDURE APP.P AS T_OLD NUMBER; BEGIN NULL; END;".into(),+ });+ assert!(ambiguous.unwrap_err().contains("Cannot safely identify"));++ let dynamic = rewrite_oracle_table_references(OracleTableReferenceRewriteInput {+ database_type: DatabaseType::Oracle,+ object_type: ObjectSourceKind::Procedure,+ schema: Some("APP".into()),+ old_name: "T_OLD".into(),+ new_name: "T_NEW".into(),+ source: "CREATE PROCEDURE APP.P AS BEGIN EXECUTE IMMEDIATE 'SELECT * FROM T_OLD'; END;".into(),+ });+ let dynamic_error = dynamic.unwrap_err();+ assert!(dynamic_error.contains("Dynamic SQL"));+ assert!(dynamic_error.contains("line 1, column 33"));++ for source in [+ "CREATE PROCEDURE APP.P AS n NUMBER; BEGIN SELECT COUNT(*) INTO n FROM APP.T_OLD o JOIN APP.T_OTHER x ON x.ID=o.ID; END;",+ "CREATE PROCEDURE APP.P AS n NUMBER; BEGIN SELECT COUNT(*) INTO n FROM APP.T_OLD o, APP.T_OTHER x; END;",+ ] {+ let multiple_relations = rewrite_oracle_table_references(OracleTableReferenceRewriteInput {+ database_type: DatabaseType::OceanbaseOracle,+ object_type: ObjectSourceKind::Procedure,+ schema: Some("APP".into()),+ old_name: "T_OLD".into(),+ new_name: "T_NEW".into(),+ source: source.into(),+ });+ assert!(multiple_relations.is_err());+ }+ }}diff --git a/crates/dbx-sql-core/src/oracle_view_rename.rs b/crates/dbx-sql-core/src/oracle_view_rename.rsnew file mode 100644index 0000000000..a254848b7e--- /dev/null+++ b/crates/dbx-sql-core/src/oracle_view_rename.rs@@ -0,0 +1,1195 @@+use serde::{Deserialize, Serialize};+use sqlparser::ast::{+ CreateView, Expr, FunctionArg, FunctionArgExpr, FunctionArguments, Ident, ObjectName, Query, Select, SelectItem,+ SelectItemQualifiedWildcardKind, SetExpr, Statement, TableFactor, Visit, Visitor,+};+use sqlparser::dialect::OracleDialect;+use sqlparser::keywords::Keyword;+use sqlparser::parser::Parser;+use sqlparser::tokenizer::{Location, Token, TokenWithSpan, Tokenizer};+use std::ops::ControlFlow;++#[derive(Debug, Deserialize)]+#[serde(rename_all = "camelCase")]+pub struct OracleViewRenameSourceInput {+ pub source: String,+ pub owner: String,+ pub view_name: String,+ pub old_name: String,+ pub new_name: String,+ pub target_view_name: Option<String>,+}++#[derive(Debug, Serialize)]+#[serde(rename_all = "camelCase")]+pub struct OracleViewRenameSource {+ pub source: String,+ pub fingerprint: String,+ pub references: Vec<OracleViewRenameReference>,+}++#[derive(Debug, Clone, Serialize, PartialEq, Eq)]+#[serde(rename_all = "camelCase")]+pub struct OracleViewRenameReference {+ pub owner: String,+ pub name: String,+}++#[derive(Debug, Serialize)]+#[serde(rename_all = "camelCase")]+pub struct OracleViewRenameIssueLocation {+ pub line: u64,+ pub column: u64,+ pub end_line: u64,+ pub end_column: u64,+}++#[derive(Debug, Serialize)]+#[serde(rename_all = "camelCase")]+pub struct OracleViewRenameIssue {+ pub code: String,+ pub message: String,+ pub view_name: String,+ pub hint_text: Option<String>,+ pub location: Option<OracleViewRenameIssueLocation>,+ pub repairable: bool,+}++#[derive(Debug, Serialize)]+#[serde(rename_all = "camelCase")]+pub struct OracleViewRenameSourceReview {+ pub source: Option<OracleViewRenameSource>,+ pub references: Vec<OracleViewRenameReference>,+ pub issues: Vec<OracleViewRenameIssue>,+}++pub fn review_oracle_view_rename_source(input: OracleViewRenameSourceInput) -> OracleViewRenameSourceReview {+ let mut issues = Vec::new();+ for name in [+ &input.owner,+ &input.view_name,+ &input.old_name,+ &input.new_name,+ input.target_view_name.as_ref().unwrap_or(&input.view_name),+ ] {+ if let Err(message) = validate_exact_name(name) {+ issues.push(OracleViewRenameIssue {+ code: "invalid_metadata".into(),+ message,+ view_name: input.view_name.clone(),+ hint_text: None,+ location: None,+ repairable: false,+ });+ return OracleViewRenameSourceReview { source: None, references: Vec::new(), issues };+ }+ }+ let result = build_source(&input, &mut issues);+ let references = match &result {+ Ok(source) => source.references.clone(),+ Err(_) => Vec::new(),+ };+ match result {+ Ok(source) => OracleViewRenameSourceReview { source: Some(source), references, issues },+ Err(message) => {+ let code = if message == "The view declaration does not match the selected owner and name." {+ "invalid_declaration"+ } else {+ "invalid_definition"+ };+ let location = issue_location(code, &message, &input.source);+ issues.push(OracleViewRenameIssue {+ code: code.into(),+ message,+ view_name: input.view_name.clone(),+ hint_text: None,+ location,+ repairable: true,+ });+ OracleViewRenameSourceReview { source: None, references, issues }+ }+ }+}++fn issue_location(code: &str, message: &str, source: &str) -> Option<OracleViewRenameIssueLocation> {+ if code == "invalid_declaration" {+ let tokens = Tokenizer::new(&OracleDialect {}, source).tokenize_with_location().ok()?;+ let view_index = tokens+ .iter()+ .position(|token| matches!(&token.token, Token::Word(word) if word.value.eq_ignore_ascii_case("VIEW")))?;+ let declaration = tokens.get(view_index + 1)?;+ return Some(OracleViewRenameIssueLocation {+ line: declaration.span.start.line,+ column: declaration.span.start.column,+ end_line: declaration.span.end.line,+ end_column: declaration.span.end.column,+ });+ }+ let location = message.rsplit_once(" at Line: ")?.1;+ let (line, column) = location.split_once(", Column: ")?;+ let line = line.parse::<u64>().ok()?;+ let column = column.parse::<u64>().ok()?;+ Some(OracleViewRenameIssueLocation { line, column, end_line: line, end_column: column.saturating_add(1) })+}++pub fn parse_oracle_object_name(input: &str) -> Result<String, String> {+ let input = input.trim();+ let tokens = Tokenizer::new(&OracleDialect {}, input).tokenize().map_err(|e| e.to_string())?;+ let [Token::Word(word)] = tokens.as_slice() else {+ return Err("Enter one Oracle object name without a schema or SQL.".into());+ };+ if word.value.is_empty() || word.value.chars().any(char::is_control) {+ return Err("The object name must not be empty or contain control characters.".into());+ }+ match word.quote_style {+ Some('"') => Ok(word.value.clone()),+ None if word.keyword == Keyword::NoKeyword+ && word.value.chars().next().is_some_and(char::is_alphabetic)+ && word.value.chars().all(|c| c.is_alphanumeric() || matches!(c, '_' | '$' | '#')) =>+ {+ Ok(word.value.to_uppercase())+ }+ _ => Err("Use an ordinary Oracle identifier or a double-quoted name.".into()),+ }+}++pub fn build_oracle_view_rename_source(input: OracleViewRenameSourceInput) -> Result<OracleViewRenameSource, String> {+ let review = review_oracle_view_rename_source(input);+ if !review.issues.is_empty() {+ return Err(review.issues.into_iter().map(|issue| issue.message).collect::<Vec<_>>().join("\n"));+ }+ review.source.ok_or_else(|| "Invalid view definition.".into())+}++fn build_source(+ input: &OracleViewRenameSourceInput,+ issues: &mut Vec<OracleViewRenameIssue>,+) -> Result<OracleViewRenameSource, String> {+ for name in [&input.owner, &input.view_name, &input.old_name, &input.new_name] {+ validate_exact_name(name)?;+ }+ let target = input.target_view_name.as_deref().unwrap_or(&input.view_name);+ validate_exact_name(target)?;+ let (view, _, tokens) = parse_view(&input.source)?;+ let declaration = name_parts(&view.name)?;+ if declaration.last().map(|name| canonical(name)) != Some(input.view_name.clone())+ || declaration.len() > 2+ || (declaration.len() == 2 && canonical(declaration[0]) != input.owner)+ {+ return Err("The view declaration does not match the selected owner and name.".into());+ }+ let mut edits = Vec::new();+ if !view.or_replace {+ let create = tokens.first().ok_or("Missing CREATE VIEW declaration.")?;+ let end = offset(&input.source, create.span.end)?;+ edits.push(Edit { start: end, end, value: " OR REPLACE".into() });+ }+ if target != input.view_name {+ add_ident_edit(&input.source, declaration[declaration.len() - 1], target, &mut edits)?;+ }+ let mut references = Vec::new();+ rewrite_query(&view.query, &[], input, &mut edits, issues, &mut references)?;+ let source = apply_edits(&input.source, edits)?;+ let (mut parsed, properties, _) = parse_view(&source)?;+ if issues.is_empty() && hint_bindings(&view.query)? != hint_bindings(&parsed.query)? {+ return Err("Reparsed optimizer hints changed their relation bindings.".into());+ }+ // GET_DDL may omit OR REPLACE and qualify the declaration. Neither changes the view.+ parsed.or_replace = true;+ parsed.name = ObjectName::from(vec![Ident::with_quote('"', &input.owner), Ident::with_quote('"', target)]);+ let mut hints = Vec::new();+ take_hint_fingerprints(&mut parsed.query, &mut hints)?;+ let fingerprint = serde_json::to_string(&(canonical_tokens(&parsed.to_string())?, properties, hints))+ .map_err(|e| e.to_string())?;+ Ok(OracleViewRenameSource { source, fingerprint, references })+}++fn validate_exact_name(name: &str) -> Result<(), String> {+ if name.is_empty() || name.chars().any(char::is_control) {+ Err("Object metadata contains an empty name or control character.".into())+ } else {+ Ok(())+ }+}++fn canonical(ident: &Ident) -> String {+ if ident.quote_style.is_some() {+ ident.value.clone()+ } else {+ ident.value.to_uppercase()+ }+}++fn name_parts(name: &ObjectName) -> Result<Vec<&Ident>, String> {+ name.0.iter().map(|part| part.as_ident().ok_or_else(|| "Unsupported computed object name.".into())).collect()+}++fn significant_tokens(source: &str) -> Result<Vec<TokenWithSpan>, String> {+ Ok(Tokenizer::new(&OracleDialect {}, source)+ .tokenize_with_location()+ .map_err(|e| e.to_string())?+ .into_iter()+ .filter(|t| !matches!(t.token, Token::Whitespace(_)))+ .collect())+}++fn word(token: &TokenWithSpan, expected: &str) -> bool {+ matches!(&token.token, Token::Word(w) if w.quote_style.is_none() && w.value.eq_ignore_ascii_case(expected))+}++// sqlparser does not represent Oracle FORCE/EDITIONABLE or the trailing view restriction.+// Recognize only these exact clauses, mask their tokens without moving spans, and keep them+// in the original DDL. Persistent properties enter the fingerprint; FORCE is only an+// execution modifier. Unknown syntax remains a parser error.+fn parse_view(source: &str) -> Result<(CreateView, Vec<String>, Vec<TokenWithSpan>), String> {+ let mut tokens = significant_tokens(source)?;+ if tokens.last().is_some_and(|t| t.token == Token::SemiColon) {+ tokens.pop();+ }+ if tokens.iter().any(|t| t.token == Token::SemiColon) || !tokens.first().is_some_and(|t| word(t, "CREATE")) {+ return Err("A complete single CREATE VIEW statement is required.".into());+ }+ let mut properties = Vec::new();+ let mut mask = Vec::new();+ let mut pos = 1;+ if tokens.get(pos).is_some_and(|t| word(t, "OR")) && tokens.get(pos + 1).is_some_and(|t| word(t, "REPLACE")) {+ pos += 2;+ }+ for alternatives in [["FORCE", "NOFORCE"], ["EDITIONABLE", "NONEDITIONABLE"]] {+ if let Some(token) = tokens.get(pos) {+ if alternatives.iter().any(|expected| word(token, expected)) {+ if !word(token, "FORCE") && !word(token, "NOFORCE") {+ properties.push(token.token.to_string().to_uppercase());+ }+ mask.push(token.span);+ pos += 1;+ }+ }+ }+ if !tokens.get(pos).is_some_and(|t| word(t, "VIEW")) {+ return Err("Only ordinary Oracle CREATE VIEW declarations are supported.".into());+ }+ let mut tail = tokens.len();+ if tail >= 2 && word(&tokens[tail - 2], "CONSTRAINT") {+ if !matches!(tokens[tail - 1].token, Token::Word(_)) {+ return Err("Invalid view constraint name.".into());+ }+ tail -= 2;+ }+ if tail >= 3+ && word(&tokens[tail - 3], "WITH")+ && ((word(&tokens[tail - 2], "READ") && word(&tokens[tail - 1], "ONLY"))+ || (word(&tokens[tail - 2], "CHECK") && word(&tokens[tail - 1], "OPTION")))+ {+ let restriction = &tokens[tail - 3..];+ properties+ .extend(canonical_tokens(&restriction.iter().map(|t| t.token.to_string()).collect::<Vec<_>>().join(" "))?);+ mask.extend(restriction.iter().map(|t| t.span));+ }+ let mut masked = source.to_string();+ for span in mask.into_iter().rev() {+ let start = offset(source, span.start)?;+ let end = offset(source, span.end)?;+ let spaces: String =+ source[start..end].chars().map(|c| if matches!(c, '\r' | '\n') { c } else { ' ' }).collect();+ masked.replace_range(start..end, &spaces);+ }+ let mut statements = Parser::parse_sql(&OracleDialect {}, &masked)+ .map_err(|e| format!("Cannot safely parse the complete view: {e}"))?;+ if statements.len() != 1 {+ return Err("Exactly one CREATE VIEW statement is required.".into());+ }+ match statements.remove(0) {+ Statement::CreateView(view) if !view.materialized && !view.or_alter && !view.if_not_exists => {+ Ok((view, properties, tokens))+ }+ _ => Err("Only ordinary CREATE VIEW statements can be rebuilt.".into()),+ }+}++fn canonical_tokens(source: &str) -> Result<Vec<String>, String> {+ Ok(significant_tokens(source)?+ .iter()+ .map(|token| match &token.token {+ Token::Word(w) => {+ format!("word:{}", if w.quote_style.is_some() { w.value.clone() } else { w.value.to_uppercase() })+ }+ other => format!("{other:?}"),+ })+ .collect())+}++// Keep each hint attached to its query block, and prevent single-line Display+// output from turning the rest of the formatted statement into a comment.+fn take_hint_fingerprints(query: &mut Query, output: &mut Vec<Vec<String>>) -> Result<(), String> {+ if let Some(with) = &mut query.with {+ for cte in &mut with.cte_tables {+ take_hint_fingerprints(&mut cte.query, output)?;+ }+ }+ let SetExpr::Select(select) = query.body.as_mut() else {+ return Err("Unsupported query block.".into());+ };+ let mut block = Vec::new();+ for hint in &select.optimizer_hints {+ let tokens = significant_tokens(&hint.text)?;+ let known = hint.prefix.is_empty() && hint_arguments(&tokens).is_some();+ block.push(if known {+ let semantic: Vec<_> = tokens+ .iter()+ .map(|token| match &token.token {+ Token::Word(w) if w.quote_style.is_some() => format!("quoted:{}", w.value),+ Token::Word(w) => format!("word:{}", w.value.to_uppercase()),+ other => format!("{other:?}"),+ })+ .collect();+ serde_json::to_string(&semantic).map_err(|e| e.to_string())?+ } else {+ format!("{}+{}", hint.prefix, hint.text)+ });+ }+ output.push(block);+ select.optimizer_hints.clear();+ Ok(())+}++// Return only table-spec tokens, never INDEX's index names or QB_NAME's block name.+fn hint_arguments(tokens: &[TokenWithSpan]) -> Option<Vec<usize>> {+ let mut tables = Vec::new();+ let mut pos = 0;+ while pos < tokens.len() {+ let Token::Word(name) = &tokens[pos].token else {+ return None;+ };+ if name.quote_style.is_some() {+ return None;+ }+ let name = name.value.to_uppercase();+ pos += 1;+ if matches!(name.as_str(), "ALL_ROWS" | "FIRST_ROWS" | "RULE")+ && !tokens.get(pos).is_some_and(|t| t.token == Token::LParen)+ {+ continue;+ }+ if !tokens.get(pos).is_some_and(|t| t.token == Token::LParen) {+ return None;+ }+ pos += 1;+ let start = pos;+ while tokens+ .get(pos)+ .is_some_and(|t| matches!(&t.token, Token::Word(w) if w.quote_style.is_some() || !w.value.contains('@')))+ {+ pos += 1;+ }+ if pos == start || !tokens.get(pos).is_some_and(|t| t.token == Token::RParen) {+ return None;+ }+ match name.as_str() {+ "FULL" | "QB_NAME" if pos - start == 1 => {+ if name == "FULL" {+ tables.push(start);+ }+ }+ "INDEX" | "INDEX_ASC" | "INDEX_DESC" | "INDEX_FFS" | "NO_INDEX" => tables.push(start),+ "LEADING" | "USE_NL" | "USE_HASH" => tables.extend(start..pos),+ _ => return None,+ }+ pos += 1;+ }+ Some(tables)+}++fn hint_name(token: &TokenWithSpan) -> Option<String> {+ match &token.token {+ Token::Word(w) => Some(if w.quote_style.is_some() { w.value.clone() } else { w.value.to_uppercase() }),+ _ => None,+ }+}++fn hint_groups(tokens: &[TokenWithSpan]) -> Vec<&[TokenWithSpan]> {+ let mut groups = Vec::new();+ let mut start = 0;+ while start < tokens.len() {+ let mut end = start + 1;+ if tokens.get(end).is_some_and(|t| t.token == Token::LParen) {+ let mut depth = 0;+ while end < tokens.len() {+ match tokens[end].token {+ Token::LParen => depth += 1,+ Token::RParen => depth -= 1,+ _ => {}+ }+ end += 1;+ if depth == 0 {+ break;+ }+ }+ }+ groups.push(&tokens[start..end]);+ start = end;+ }+ groups+}++fn hint_bindings(query: &Query) -> Result<Vec<Vec<Vec<usize>>>, String> {+ let mut blocks = Vec::new();+ if let Some(with) = &query.with {+ for cte in &with.cte_tables {+ blocks.extend(hint_bindings(&cte.query)?);+ }+ }+ let SetExpr::Select(select) = query.body.as_ref() else {+ return Err("Unsupported query block.".into());+ };+ let mut exposed = Vec::new();+ for from in &select.from {+ for relation in std::iter::once(&from.relation).chain(from.joins.iter().map(|j| &j.relation)) {+ let TableFactor::Table { name, alias, .. } = relation else {+ return Err("Unsupported relation.".into());+ };+ exposed.push(if let Some(alias) = alias {+ canonical(&alias.name)+ } else {+ canonical(name_parts(name)?.last().ok_or("Empty relation name.")?)+ });+ }+ }+ let mut block = Vec::new();+ for hint in &select.optimizer_hints {+ if !hint.prefix.is_empty() {+ continue;+ }+ let tokens = significant_tokens(&hint.text)?;+ for group in hint_groups(&tokens) {+ if let Some(args) = hint_arguments(group) {+ for arg in args {+ let name = hint_name(&group[arg]).ok_or("Invalid hint identifier.")?;+ block.push(+ exposed.iter().enumerate().filter(|(_, value)| **value == name).map(|(i, _)| i).collect(),+ );+ }+ }+ }+ }+ blocks.push(block);+ Ok(blocks)+}++fn rewrite_hints(+ select: &Select,+ bindings: &[Binding],+ input: &OracleViewRenameSourceInput,+ edits: &mut Vec<Edit>,+ issues: &mut Vec<OracleViewRenameIssue>,+) -> Result<(), String> {+ use sqlparser::ast::OptimizerHintStyle;+ use sqlparser::tokenizer::Whitespace;+ if select.optimizer_hints.is_empty() {+ return Ok(());+ }+ let original =+ Tokenizer::new(&OracleDialect {}, &input.source).tokenize_with_location().map_err(|e| e.to_string())?;+ let select_index = original+ .iter()+ .position(|t| t.span == select.select_token.0.span && word(t, "SELECT"))+ .ok_or("Missing original SELECT token.")?;+ let mut comments = Vec::new();+ for token in original.iter().skip(select_index + 1) {+ let Token::Whitespace(whitespace) = &token.token else {+ break;+ };+ let (text, style, marker) = match whitespace {+ Whitespace::MultiLineComment(text) => (text, OptimizerHintStyle::MultiLine, 2),+ Whitespace::SingleLineComment { comment, prefix } => {+ (comment, OptimizerHintStyle::SingleLine { prefix: prefix.clone() }, prefix.len())+ }+ _ => continue,+ };+ if let Some(plus) = text.find('+') {+ if text[..plus].chars().all(|c| c.is_ascii_alphanumeric()) {+ comments.push((token, &text[..plus], &text[plus + 1..], style, marker + plus + 1));+ }+ }+ }+ if comments.len() != select.optimizer_hints.len() {+ return Err("Original hint comments do not match parsed hints.".into());+ }+ for (hint, (comment, prefix, text, style, marker)) in select.optimizer_hints.iter().zip(comments) {+ if hint.prefix != prefix || hint.text != text || hint.style != style {+ return Err("Original hint comment does not match parsed hint.".into());+ }+ let tokens = significant_tokens(text)?;+ let affected = bindings.iter().any(|b| b.renamed) && input.old_name != input.new_name;+ if !affected {+ continue;+ }+ let mut problem = None;+ for group in hint_groups(&tokens) {+ let table_args = if prefix.is_empty() { hint_arguments(group) } else { None };+ let related = group.iter().any(|token| {+ let Token::Word(w) = &token.token else {+ return false;+ };+ if w.quote_style.is_some() {+ return w.value == input.old_name || w.value == input.new_name;+ }+ w.value.split('@').any(|part| {+ let name = part.to_uppercase();+ name == input.old_name || name == input.new_name+ })+ });+ if let Some(args) = table_args {+ for index in args {+ let name = hint_name(&group[index]).ok_or("Invalid hint identifier.")?;+ let before: Vec<_> =+ bindings.iter().enumerate().filter(|(_, b)| b.exposed == name).map(|(i, _)| i).collect();+ if before.is_empty() && name == input.old_name {+ problem = Some((+ "unsupported_hint",+ "This hint names the renamed relation instead of its visible query alias.",+ ));+ break;+ }+ let replacement =+ if before.len() == 1 && bindings[before[0]].renamed && !bindings[before[0]].aliased {+ input.new_name.as_str()+ } else {+ name.as_str()+ };+ let after: Vec<_> = bindings+ .iter()+ .enumerate()+ .filter(|(_, b)| {+ (if b.renamed && !b.aliased { &input.new_name } else { &b.exposed }) == replacement+ })+ .map(|(i, _)| i)+ .collect();+ if before.len() > 1 && before.iter().any(|i| bindings[*i].renamed && !bindings[*i].aliased) {+ problem = Some((+ "ambiguous_binding",+ "An optimizer hint table-spec has ambiguous relation bindings.",+ ));+ break;+ }+ if before != after {+ problem = Some(("hint_capture", "Renaming would change an optimizer hint's relation binding."));+ break;+ }+ if replacement != name {+ let base = offset(&input.source, comment.span.start)? + marker;+ edits.push(Edit {+ start: base + offset(text, group[index].span.start)?,+ end: base + offset(text, group[index].span.end)?,+ value: format!("\"{}\"", replacement.replace('"', "\"\"")),+ });+ }+ }+ } else if related {+ problem = Some((+ "unsupported_hint",+ "This optimizer hint may refer to the renamed relation but its table-spec cannot be safely bound.",+ ));+ }+ if problem.is_some() {+ break;+ }+ }+ if let Some((code, message)) = problem {+ issues.push(OracleViewRenameIssue {+ code: code.into(),+ message: format!("{} [{}]", message, text),+ view_name: input.view_name.clone(),+ hint_text: Some(text.into()),+ location: Some(OracleViewRenameIssueLocation {+ line: comment.span.start.line,+ column: comment.span.start.column,+ end_line: comment.span.end.line,+ end_column: comment.span.end.column,+ }),+ repairable: true,+ });+ }+ }+ Ok(())+}++#[derive(Debug)]+struct Edit {+ start: usize,+ end: usize,+ value: String,+}++fn offset(source: &str, target: Location) -> Result<usize, String> {+ let (mut line, mut column) = (1, 1);+ for (index, ch) in source.char_indices() {+ if (line, column) == (target.line, target.column) {+ return Ok(index);+ }+ if ch == '\n' {+ line += 1;+ column = 1;+ } else {+ column += 1;+ }+ }+ if (line, column) == (target.line, target.column) {+ Ok(source.len())+ } else {+ Err("Invalid SQL identifier span.".into())+ }+}++fn add_ident_edit(source: &str, ident: &Ident, replacement: &str, edits: &mut Vec<Edit>) -> Result<(), String> {+ if canonical(ident) == replacement {+ return Ok(());+ }+ let start = offset(source, ident.span.start)?;+ let end = offset(source, ident.span.end)?;+ let original = source.get(start..end).ok_or("Invalid SQL identifier range.")?;+ let tokens = significant_tokens(original)?;+ if !matches!(tokens.as_slice(), [TokenWithSpan { token: Token::Word(w), .. }] if w.value == ident.value && w.quote_style == ident.quote_style)+ {+ return Err("The parsed identifier does not match its original SQL token.".into());+ }+ edits.push(Edit { start, end, value: format!("\"{}\"", replacement.replace('"', "\"\"")) });+ Ok(())+}++fn apply_edits(source: &str, mut edits: Vec<Edit>) -> Result<String, String> {+ edits.sort_by_key(|e| (e.start, e.end));+ edits.dedup_by(|a, b| a.start == b.start && a.end == b.end && a.value == b.value);+ if edits.windows(2).any(|pair| pair[0].end > pair[1].start) {+ return Err("Overlapping SQL identifier edits.".into());+ }+ let mut result = source.to_string();+ for edit in edits.into_iter().rev() {+ result.replace_range(edit.start..edit.end, &edit.value);+ }+ Ok(result)+}++#[derive(Clone)]+struct Binding {+ exposed: String,+ owner: String,+ name: String,+ renamed: bool,+ aliased: bool,+}++fn rewrite_query(+ query: &Query,+ inherited_ctes: &[String],+ input: &OracleViewRenameSourceInput,+ edits: &mut Vec<Edit>,+ issues: &mut Vec<OracleViewRenameIssue>,+ references: &mut Vec<OracleViewRenameReference>,+) -> Result<(), String> {+ let mut ctes = inherited_ctes.to_vec();+ if let Some(with) = &query.with {+ if with.recursive {+ return Err("Recursive CTE references cannot be safely renamed automatically.".into());+ }+ for cte in &with.cte_tables {+ let name = canonical(&cte.alias.name);+ if ctes.contains(&name) {+ return Err("Shadowed CTE names require manual review.".into());+ }+ let mut body_ctes = ctes.clone();+ // Prevent new self/forward CTE references without hiding old physical relations.+ if input.new_name != input.old_name+ && !body_ctes.contains(&input.new_name)+ && with.cte_tables.iter().any(|candidate| canonical(&candidate.alias.name) == input.new_name)+ {+ body_ctes.push(input.new_name.clone());+ }+ rewrite_query(&cte.query, &body_ctes, input, edits, issues, references)?;+ ctes.push(name);+ }+ }+ let SetExpr::Select(select) = query.body.as_ref() else {+ return Err("Set operations and nested query blocks require manual dependency review.".into());+ };+ if !query.locks.is_empty()+ || query.for_clause.is_some()+ || query.settings.is_some()+ || query.format_clause.is_some()+ || !query.pipe_operators.is_empty()+ {+ return Err("Unsupported view query clause.".into());+ }+ let mut bindings = Vec::new();+ for from in &select.from {+ add_binding(&from.relation, &ctes, input, &mut bindings, edits, references)?;+ for join in &from.joins {+ add_binding(&join.relation, &ctes, input, &mut bindings, edits, references)?;+ }+ }+ if bindings.iter().any(|b| b.renamed && !b.aliased)+ && bindings.iter().any(|b| (!b.renamed || b.aliased) && b.exposed == input.new_name)+ {+ return Err("The new name would collide with an existing query alias or relation.".into());+ }+ rewrite_hints(select, &bindings, input, edits, issues)?;+ let mut visitor = References { input, bindings: &bindings, edits };+ visit_result(select.visit(&mut visitor))?;+ visit_result(query.order_by.visit(&mut visitor))?;+ visit_result(query.limit_clause.visit(&mut visitor))?;+ visit_result(query.fetch.visit(&mut visitor))?;+ Ok(())+}++fn add_binding(+ table: &TableFactor,+ ctes: &[String],+ input: &OracleViewRenameSourceInput,+ bindings: &mut Vec<Binding>,+ edits: &mut Vec<Edit>,+ references: &mut Vec<OracleViewRenameReference>,+) -> Result<(), String> {+ let TableFactor::Table {+ name,+ alias,+ args,+ with_hints,+ version,+ with_ordinality,+ partitions,+ json_path,+ sample,+ index_hints,+ } = table+ else {+ return Err("Derived tables, table functions and special table sources require manual review.".into());+ };+ if args.is_some()+ || !with_hints.is_empty()+ || version.is_some()+ || *with_ordinality+ || !partitions.is_empty()+ || json_path.is_some()+ || sample.is_some()+ || !index_hints.is_empty()+ {+ return Err("Unsupported qualified table source.".into());+ }+ let parts = name_parts(name)?;+ if parts.iter().any(|part| part.quote_style.is_none() && part.value.contains('@')) {+ return Err("Database links require manual dependency review.".into());+ }+ if parts.is_empty() || parts.len() > 2 {+ return Err("Database links and multi-part relation names require manual review.".into());+ }+ let relation_name = canonical(parts[parts.len() - 1]);+ let owner = if parts.len() == 2 { canonical(parts[0]) } else { input.owner.clone() };+ let is_cte = parts.len() == 1 && ctes.contains(&relation_name);+ if !is_cte {+ let reference = OracleViewRenameReference { owner: owner.clone(), name: relation_name.clone() };+ if !references.contains(&reference) {+ references.push(reference);+ }+ }+ let renamed = !is_cte && owner == input.owner && relation_name == input.old_name;+ if renamed {+ if parts.len() == 1 && ctes.contains(&input.new_name) {+ return Err("The new view name would bind to a CTE.".into());+ }+ add_ident_edit(&input.source, parts[parts.len() - 1], &input.new_name, edits)?;+ }+ bindings.push(Binding {+ exposed: alias.as_ref().map(|a| canonical(&a.name)).unwrap_or_else(|| relation_name.clone()),+ owner,+ name: relation_name,+ renamed,+ aliased: alias.is_some(),+ });+ Ok(())+}++struct References<'a> {+ input: &'a OracleViewRenameSourceInput,+ bindings: &'a [Binding],+ edits: &'a mut Vec<Edit>,+}++impl References<'_> {+ fn qualifier(&mut self, parts: &[&Ident]) -> Result<(), String> {+ if parts.is_empty() {+ return Ok(());+ }+ if parts.len() > 2 {+ return Err("Multi-part expression qualifiers require manual review.".into());+ }+ let name = canonical(parts[parts.len() - 1]);+ let matches: Vec<_> = self+ .bindings+ .iter()+ .filter(|binding| {+ if parts.len() == 1 {+ binding.exposed == name+ } else {+ !binding.aliased && binding.owner == canonical(parts[0]) && binding.name == name+ }+ })+ .collect();+ if matches.iter().any(|b| b.renamed && !b.aliased) {+ if matches.len() != 1 {+ return Err("An ambiguous relation qualifier cannot be renamed safely.".into());+ }+ add_ident_edit(&self.input.source, parts[parts.len() - 1], &self.input.new_name, self.edits)?;+ }+ Ok(())+ }++ fn function_arguments(&mut self, args: &FunctionArguments) -> Result<(), String> {+ if let FunctionArguments::List(list) = args {+ for arg in &list.args {+ let arg = match arg {+ FunctionArg::Named { arg, .. } | FunctionArg::ExprNamed { arg, .. } | FunctionArg::Unnamed(arg) => {+ arg+ }+ };+ if let FunctionArgExpr::QualifiedWildcard(name) = arg {+ self.qualifier(&name_parts(name)?)?;+ }+ }+ }+ Ok(())+ }+}++fn visit_result(flow: ControlFlow<String>) -> Result<(), String> {+ match flow {+ ControlFlow::Continue(()) => Ok(()),+ ControlFlow::Break(error) => Err(error),+ }+}++impl Visitor for References<'_> {+ type Break = String;++ fn pre_visit_query(&mut self, _: &Query) -> ControlFlow<Self::Break> {+ ControlFlow::Break("Subqueries may contain correlated references and require manual review.".into())+ }++ fn pre_visit_select(&mut self, select: &Select) -> ControlFlow<Self::Break> {+ if !select.lateral_views.is_empty() || !select.connect_by.is_empty() || select.into.is_some() {+ return ControlFlow::Break("Special Oracle query scopes require manual review.".into());+ }+ for item in &select.projection {+ if matches!(item, SelectItem::QualifiedWildcard(SelectItemQualifiedWildcardKind::Expr(_), _)) {+ return ControlFlow::Break("Expression-qualified wildcards require manual review.".into());+ }+ if let SelectItem::QualifiedWildcard(SelectItemQualifiedWildcardKind::ObjectName(name), _) = item {+ match name_parts(name).and_then(|parts| self.qualifier(&parts)) {+ Ok(()) => {}+ Err(e) => return ControlFlow::Break(e),+ }+ }+ }+ ControlFlow::Continue(())+ }++ fn pre_visit_expr(&mut self, expr: &Expr) -> ControlFlow<Self::Break> {+ let result = match expr {+ Expr::CompoundIdentifier(parts) => self.qualifier(&parts[..parts.len() - 1].iter().collect::<Vec<_>>()),+ Expr::QualifiedWildcard(name, _) => name_parts(name).and_then(|parts| self.qualifier(&parts)),+ Expr::Function(function) => {+ self.function_arguments(&function.args).and_then(|_| self.function_arguments(&function.parameters))+ }+ _ => Ok(()),+ };+ match result {+ Ok(()) => ControlFlow::Continue(()),+ Err(e) => ControlFlow::Break(e),+ }+ }+}++#[cfg(test)]+mod tests {+ use super::*;++ fn input(source: &str) -> OracleViewRenameSourceInput {+ OracleViewRenameSourceInput {+ source: source.into(),+ owner: "APP".into(),+ view_name: "DEP".into(),+ old_name: "OLD".into(),+ new_name: "New View".into(),+ target_view_name: None,+ }+ }++ #[test]+ fn accepts_one_oracle_identifier_and_rejects_extra_sql() {+ assert_eq!(parse_oracle_object_name(" new_view ").unwrap(), "NEW_VIEW");+ assert_eq!(parse_oracle_object_name("\"New View\"").unwrap(), "New View");+ for value in ["", "a.b", "a; DROP VIEW b", "a -- comment", "\"\"", "1abc", "SELECT", "`name`"] {+ assert!(parse_oracle_object_name(value).is_err(), "{value}");+ }+ }++ #[test]+ fn preserves_source_and_changes_bound_relations_and_qualifiers() {+ let source = "CREATE VIEW \"APP\".\"DEP\" (\"列\") AS\r\nSELECT /*+ ALL_ROWS */ OLD.N FROM APP.OLD -- OLD\r\nWHERE OLD.N > 1 AND 'OLD' = 'OLD' WITH READ ONLY";+ let result = build_oracle_view_rename_source(input(source)).unwrap();+ assert_eq!(result.source, "CREATE OR REPLACE VIEW \"APP\".\"DEP\" (\"列\") AS\r\nSELECT /*+ ALL_ROWS */ \"New View\".N FROM APP.\"New View\" -- OLD\r\nWHERE \"New View\".N > 1 AND 'OLD' = 'OLD' WITH READ ONLY");+ }++ #[test]+ fn rewrites_hints_whose_relation_spec_would_become_stale() {+ for source in [+ "CREATE VIEW DEP AS SELECT /*+ FULL(OLD) */ OLD.N FROM OLD",+ "CREATE VIEW DEP AS SELECT --+ INDEX(OLD IDX)\n OLD.N FROM OLD",+ "CREATE VIEW DEP AS SELECT /*+ LEADING(\"OLD\") */ * FROM APP.OLD",+ ] {+ assert!(build_oracle_view_rename_source(input(source)).is_ok(), "{source}");+ }+ for source in [+ "CREATE VIEW DEP AS SELECT /*+ FULL(X) */ X.N FROM OLD X",+ "CREATE VIEW DEP AS SELECT /*+ FULL(OLD) */ OLD.N FROM OLD OLD",+ "CREATE VIEW DEP AS SELECT /*+ FULL(OLD) */ OLD.N FROM OTHER.OLD",+ "CREATE VIEW DEP AS SELECT /* FULL(OLD) */ OLD.N FROM OLD",+ ] {+ assert!(build_oracle_view_rename_source(input(source)).is_ok(), "{source}");+ }+ }++ #[test]+ fn preserves_aliases_ctes_other_owners_and_literals() {+ let source = "CREATE VIEW DEP AS WITH OLD AS (SELECT * FROM OTHER.OLD) SELECT OLD.N, X.N FROM OLD JOIN APP.OLD X ON OLD.N = X.N";+ let result = build_oracle_view_rename_source(input(source)).unwrap();+ assert_eq!(result.source, "CREATE OR REPLACE VIEW DEP AS WITH OLD AS (SELECT * FROM OTHER.OLD) SELECT OLD.N, X.N FROM OLD JOIN APP.\"New View\" X ON OLD.N = X.N");+ }++ #[test]+ fn indirect_dependencies_keep_their_query_and_properties() {+ let source = "CREATE OR REPLACE FORCE VIEW DEP (N) AS SELECT N FROM INTERMEDIATE WITH CHECK OPTION";+ assert_eq!(build_oracle_view_rename_source(input(source)).unwrap().source, source);+ }++ #[test]+ fn refuses_wrong_declaration_multiple_statements_and_uncertain_bindings() {+ for source in [+ "SELECT N FROM OLD",+ "CREATE VIEW OTHER.DEP AS SELECT N FROM OLD",+ "CREATE VIEW WRONG AS SELECT N FROM OLD",+ "CREATE VIEW DEP AS SELECT N FROM OLD; DROP VIEW OLD",+ "CREATE VIEW DEP AS SELECT OLD.N FROM OLD, OTHER.OLD",+ "CREATE VIEW DEP AS SELECT (SELECT OLD.N FROM DUAL) FROM OLD",+ "CREATE VIEW DEP AS SELECT * FROM OLD@REMOTE",+ ] {+ assert!(build_oracle_view_rename_source(input(source)).is_err(), "{source}");+ }+ }++ #[test]+ fn fingerprint_ignores_format_but_preserves_literal_and_view_properties() {+ let a = build_oracle_view_rename_source(input("CREATE VIEW DEP AS SELECT 'a b' N FROM OLD WITH READ ONLY"))+ .unwrap();+ let b = build_oracle_view_rename_source(input("create view DEP as\n select 'a b' N from OLD with read only;"))+ .unwrap();+ let c =+ build_oracle_view_rename_source(input("CREATE VIEW DEP AS SELECT 'ab' N FROM OLD WITH READ ONLY")).unwrap();+ let d = build_oracle_view_rename_source(input("CREATE VIEW DEP AS SELECT 'a b' N FROM OLD")).unwrap();+ assert_eq!(a.fingerprint, b.fingerprint);+ assert_ne!(a.fingerprint, c.fingerprint);+ assert_ne!(a.fingerprint, d.fingerprint);+ }++ #[test]+ fn rewrites_quoted_names_stars_and_order_by_without_touching_aliases() {+ let mut request = input("CREATE VIEW DEP AS SELECT \"old\".*, X.N FROM \"old\" JOIN OTHER.\"old\" X ON \"old\".N = X.N ORDER BY \"old\".N");+ request.old_name = "old".into();+ let result = build_oracle_view_rename_source(request).unwrap();+ assert_eq!(result.source, "CREATE OR REPLACE VIEW DEP AS SELECT \"New View\".*, X.N FROM \"New View\" JOIN OTHER.\"old\" X ON \"New View\".N = X.N ORDER BY \"New View\".N");+ let result =+ build_oracle_view_rename_source(input("CREATE VIEW DEP AS SELECT OLD.N FROM APP.OLD OLD")).unwrap();+ assert_eq!(result.source, "CREATE OR REPLACE VIEW DEP AS SELECT OLD.N FROM APP.\"New View\" OLD");+ }++ #[test]+ fn matches_schema_qualified_columns_and_respects_case_sensitive_names() {+ let result = build_oracle_view_rename_source(input(+ "CREATE VIEW DEP AS SELECT APP.OLD.N, OTHER.OLD.N FROM APP.OLD JOIN OTHER.OLD ON APP.OLD.N = OTHER.OLD.N",+ ))+ .unwrap();+ assert_eq!(result.source, "CREATE OR REPLACE VIEW DEP AS SELECT APP.\"New View\".N, OTHER.OLD.N FROM APP.\"New View\" JOIN OTHER.OLD ON APP.\"New View\".N = OTHER.OLD.N");+ let source = "CREATE OR REPLACE VIEW DEP AS SELECT \"old\".N FROM \"old\"";+ assert_eq!(build_oracle_view_rename_source(input(source)).unwrap().source, source);+ }++ #[test]+ fn fingerprints_renamed_declaration_like_database_readback() {+ let mut request = input("CREATE OR REPLACE FORCE VIEW APP.DEP (N) AS SELECT 42 FROM DUAL WITH READ ONLY");+ request.target_view_name = Some("Renamed".into());+ let expected = build_oracle_view_rename_source(request).unwrap();+ let mut readback = input("CREATE VIEW \"Renamed\" (N) AS\n SELECT 42 FROM DUAL WITH READ ONLY;");+ readback.view_name = "Renamed".into();+ assert_eq!(expected.fingerprint, build_oracle_view_rename_source(readback).unwrap().fingerprint);+ }++ #[test]+ fn rejects_new_name_capture_and_preserves_previous_cte_bindings() {+ for source in [+ "CREATE VIEW DEP AS WITH \"New View\" AS (SELECT 1 FROM DUAL) SELECT * FROM OLD",+ "CREATE VIEW DEP AS SELECT OLD.N FROM OLD, OTHER.T \"New View\"",+ "CREATE VIEW DEP AS SELECT OLD.N FROM OLD, OLD \"New View\"",+ "CREATE VIEW DEP AS SELECT * FROM (SELECT * FROM OLD)",+ "CREATE VIEW DEP AS SELECT * FROM OLD UNION SELECT * FROM OLD",+ ] {+ assert!(build_oracle_view_rename_source(input(source)).is_err(), "{source}");+ }+ let result = build_oracle_view_rename_source(input(+ "CREATE VIEW DEP AS WITH X AS (SELECT * FROM OLD), Y AS (SELECT * FROM X) SELECT * FROM Y",+ ))+ .unwrap();+ assert_eq!(result.source, "CREATE OR REPLACE VIEW DEP AS WITH X AS (SELECT * FROM \"New View\"), Y AS (SELECT * FROM X) SELECT * FROM Y");+ }++ #[test]+ fn rejects_current_cte_capture_but_keeps_qualified_references() {+ let mut request = input("CREATE VIEW DEP AS WITH \"NEW\" AS (SELECT * FROM OLD) SELECT * FROM \"NEW\"");+ request.new_name = "NEW".into();+ assert!(build_oracle_view_rename_source(request).is_err());++ let mut request = input("CREATE VIEW DEP AS WITH \"NEW\" AS (SELECT * FROM APP.OLD) SELECT * FROM \"NEW\"");+ request.new_name = "NEW".into();+ assert_eq!(+ build_oracle_view_rename_source(request).unwrap().source,+ "CREATE OR REPLACE VIEW DEP AS WITH \"NEW\" AS (SELECT * FROM APP.\"NEW\") SELECT * FROM \"NEW\""+ );++ let mut request = input("CREATE VIEW DEP AS WITH \"new\" AS (SELECT * FROM OLD) SELECT * FROM \"new\"");+ request.new_name = "NEW".into();+ assert_eq!(+ build_oracle_view_rename_source(request).unwrap().source,+ "CREATE OR REPLACE VIEW DEP AS WITH \"new\" AS (SELECT * FROM \"NEW\") SELECT * FROM \"new\""+ );+ }++ #[test]+ fn rejects_capture_by_a_later_cte() {+ let mut request = input(+ "CREATE VIEW DEP AS WITH X AS (SELECT * FROM OLD), \"NEW\" AS (SELECT 1 N FROM DUAL) SELECT * FROM X",+ );+ request.new_name = "NEW".into();+ assert!(build_oracle_view_rename_source(request).is_err());+ let mut request = input(+ "CREATE VIEW DEP AS WITH X AS (SELECT * FROM APP.OLD), \"NEW\" AS (SELECT 1 N FROM DUAL) SELECT * FROM X",+ );+ request.new_name = "NEW".into();+ assert_eq!(build_oracle_view_rename_source(request).unwrap().source,+ "CREATE OR REPLACE VIEW DEP AS WITH X AS (SELECT * FROM APP.\"NEW\"), \"NEW\" AS (SELECT 1 N FROM DUAL) SELECT * FROM X");+ }++ #[test]+ fn preserves_escaped_identifiers_comments_and_constraint_names() {+ let mut request = input("CREATE /* 保留 */ VIEW DEP AS SELECT \"old\"\"name\".N FROM \"old\"\"name\" WITH CHECK OPTION CONSTRAINT \"中文约束\"");+ request.old_name = "old\"name".into();+ request.new_name = "新\"名".into();+ assert_eq!(build_oracle_view_rename_source(request).unwrap().source, "CREATE OR REPLACE /* 保留 */ VIEW DEP AS SELECT \"新\"\"名\".N FROM \"新\"\"名\" WITH CHECK OPTION CONSTRAINT \"中文约束\"");+ }++ #[test]+ fn rewrites_hint_table_roles_and_preserves_other_parameters() {+ let source = "CREATE VIEW DEP AS\r\nSELECT /*+ FULL(OLD) INDEX(OLD OLD IDX) QB_NAME(OLD) LEADING(OLD X) USE_NL(OLD X) USE_HASH(X OLD) MYSTERY(X) */ 'OLD' N FROM APP.OLD JOIN OTHER.T X ON 1=1";+ let result = build_oracle_view_rename_source(input(source)).unwrap();+ assert!(result.source.contains("FULL(\"New View\") INDEX(\"New View\" OLD IDX) QB_NAME(OLD) LEADING(\"New View\" X) USE_NL(\"New View\" X) USE_HASH(X \"New View\") MYSTERY(X)"));+ for name in ["INDEX_ASC", "INDEX_DESC", "INDEX_FFS", "NO_INDEX"] {+ let result = build_oracle_view_rename_source(input(&format!(+ "CREATE VIEW DEP AS SELECT --+ {name}(OLD IDX)\r\n OLD.N FROM OLD"+ )))+ .unwrap();+ assert!(result.source.contains(&format!("--+ {name}(\"New View\" IDX)\r\n")));+ }+ let result =+ build_oracle_view_rename_source(input("CREATE VIEW DEP AS SELECT /*+ INDEX(T OLD) */ * FROM OLD T"))+ .unwrap();+ assert!(result.source.contains("INDEX(T OLD)"));+ }++ #[test]+ fn reports_related_unsupported_hints_and_binding_capture_with_locations() {+ for hint in ["FULL(OLD@Q)", "FULL(APP.OLD)", "LEADING((OLD X))", "UNKNOWN(OLD)"] {+ let source = format!("CREATE VIEW DEP AS\r\nSELECT /*+ {hint} */ * FROM OLD");+ let review = review_oracle_view_rename_source(input(&source));+ assert!(review.source.is_some(), "{hint}");+ assert_eq!(review.issues[0].code, "unsupported_hint");+ assert_eq!(review.issues[0].location.as_ref().unwrap().line, 2);+ assert_eq!(review.issues[0].location.as_ref().unwrap().column, 8);+ assert!(review.issues[0].hint_text.as_ref().unwrap().contains(hint));+ let proposed = review.source.unwrap().source;+ assert!(proposed.contains(hint), "unsupported hint must remain visible for manual repair: {proposed}");+ assert!(+ proposed.contains("FROM \"New View\""),+ "safe relation rewrite should remain available: {proposed}"+ );+ }+ let review =+ review_oracle_view_rename_source(input("CREATE VIEW DEP AS SELECT /*+ FULL(\"New View\") */ * FROM OLD"));+ assert_eq!(review.issues[0].code, "hint_capture");+ let review =+ review_oracle_view_rename_source(input("CREATE VIEW DEP AS SELECT /*+ FULL(OLD) */ * FROM OLD, OTHER.OLD"));+ assert_eq!(review.issues[0].code, "ambiguous_binding");+ assert_eq!(review.references.len(), 2);+ assert!(build_oracle_view_rename_source(input("CREATE VIEW DEP AS SELECT /*+ UNKNOWN(X@Q) */ * FROM OLD X"))+ .is_ok());++ let source = "CREATE VIEW \"DBX_G8_HINT\" (\"Value X\") AS SELECT /*+ FULL(DBX_G8_BASE@Q) */ \"Value X\" FROM DBX_G8_BASE B";+ let mut request = input(source);+ request.owner = "DBX_G8_UI_261013".into();+ request.view_name = "DBX_G8_HINT".into();+ request.old_name = "DBX_G8_BASE".into();+ request.new_name = "DBX_G8_BASE_NEW".into();+ let review = review_oracle_view_rename_source(request);+ assert!(review.issues.iter().any(|issue| issue.code == "unsupported_hint"));+ assert!(review.source.unwrap().source.contains("FROM \"DBX_G8_BASE_NEW\" B"));+ }++ #[test]+ fn keeps_hint_bindings_separate_across_repeated_cte_comments() {+ let source = "CREATE VIEW DEP AS WITH X AS (SELECT /*+ FULL(OLD) */ * FROM OTHER.OLD), Y AS (SELECT /*+ FULL(OLD) */ * FROM APP.OLD) SELECT /*+ FULL(X) */ * FROM X, Y";+ let result = build_oracle_view_rename_source(input(source)).unwrap();+ assert!(result.source.contains("SELECT /*+ FULL(OLD) */ * FROM OTHER.OLD"));+ assert!(result.source.contains("SELECT /*+ FULL(\"New View\") */ * FROM APP.\"New View\""));+ assert_eq!(+ result.references,+ vec![+ OracleViewRenameReference { owner: "OTHER".into(), name: "OLD".into() },+ OracleViewRenameReference { owner: "APP".into(), name: "OLD".into() }+ ]+ );+ }++ #[test]+ fn fingerprints_hint_semantics_and_single_line_sql_body() {+ let fingerprint = |sql: &str| build_oracle_view_rename_source(input(sql)).unwrap().fingerprint;+ let a = fingerprint("CREATE VIEW DEP AS SELECT --+ FULL(OLD)\n N FROM OLD WHERE N=1");+ assert_eq!(a, fingerprint("create view DEP as SELECT /*+ full( old ) */ N from OLD -- ordinary\n where N = 1"));+ assert_ne!(a, fingerprint("CREATE VIEW DEP AS SELECT --+ FULL(OLD)\n N FROM OLD WHERE N=2"));+ assert_ne!(a, fingerprint("CREATE VIEW DEP AS SELECT /*+ INDEX(OLD IDX) */ N FROM OLD WHERE N=1"));+ assert_ne!(+ fingerprint("CREATE VIEW DEP AS SELECT /*+ UNKNOWN('a') */ N FROM OLD"),+ fingerprint("CREATE VIEW DEP AS SELECT /*+ UNKNOWN('b') */ N FROM OLD")+ );+ let source =+ build_oracle_view_rename_source(input("CREATE VIEW DEP AS SELECT --+ INDEX(OLD IDX)\n OLD.N FROM OLD"))+ .unwrap();+ assert_eq!(source.fingerprint, build_oracle_view_rename_source(input(&source.source)).unwrap().fingerprint);+ }++ #[test]+ fn review_returns_parse_problem_without_a_source() {+ let review = review_oracle_view_rename_source(input("CREATE VIEW DEP AS unsupported original"));+ assert!(review.source.is_none());+ assert_eq!(review.issues[0].code, "invalid_definition");+ assert!(review.issues[0].location.is_some());+ let declaration = review_oracle_view_rename_source(input("CREATE VIEW WRONG AS SELECT 1 FROM OLD"));+ assert_eq!(declaration.issues[0].code, "invalid_declaration");+ assert!(declaration.issues[0].location.is_some());+ }+}diff --git a/crates/dbx-sql/src/lib.rs b/crates/dbx-sql/src/lib.rsindex ba735ce321..f37c4f06e3 100644--- a/crates/dbx-sql/src/lib.rs+++ b/crates/dbx-sql/src/lib.rs@@ -1,8 +1,9 @@#![recursion_limit = "256"]pub use dbx_sql_core::{- dml_preview_sql, mysql_ddl_normalize, mysql_event_sql, object_source_sql, query_execution_sql, sql, sql_analysis,- sql_diagnostics, sql_editability, sql_error_position, sql_risk, sqlserver_temporal, tdsql_mysql, value_literals,+ dml_preview_sql, mysql_ddl_normalize, mysql_event_sql, object_source_sql, oracle_view_rename, query_execution_sql,+ sql, sql_analysis, sql_diagnostics, sql_editability, sql_error_position, sql_risk, sqlserver_temporal, tdsql_mysql,+ value_literals,};pub use dbx_sql_data::{data_grid_extractors, data_grid_sql, database_search_sql, database_structure_search_sql, query_result_sql,diff --git a/crates/dbx-web/src/main.rs b/crates/dbx-web/src/main.rsindex 882f2c6294..7b700e49eb 100644--- a/crates/dbx-web/src/main.rs+++ b/crates/dbx-web/src/main.rs@@ -857,13 +857,26 @@ async fn serve() -> Result<(), String> {"/query/build-executable-object-source-statements",post(routes::query::build_executable_object_source_statements),)+ .route(+ "/query/validate-oracle-executable-object-source",+ post(routes::query::validate_oracle_executable_object_source),+ )+ .route(+ "/query/fingerprint-oracle-routine-object-source",+ post(routes::query::fingerprint_oracle_routine_object_source),+ ).route("/query/build-executable-object-source-sql", post(routes::query::build_executable_object_source_sql)).route("/query/build-editable-object-source", post(routes::query::build_editable_object_source)).route("/query/build-routine-rename-object-source-statements",post(routes::query::build_routine_rename_object_source_statements),)+ .route("/query/rewrite-oracle-routine-references", post(routes::query::rewrite_oracle_routine_references))+ .route("/query/rewrite-oracle-table-references", post(routes::query::rewrite_oracle_table_references)).route("/query/build-view-ddl-sql", post(routes::query::build_view_ddl_sql))+ .route("/query/parse-oracle-object-name", post(routes::query::parse_oracle_object_name))+ .route("/query/build-oracle-view-rename-source", post(routes::query::build_oracle_view_rename_source))+ .route("/query/review-oracle-view-rename-source", post(routes::query::review_oracle_view_rename_source)).route("/query/build-table-structure-change-sql", post(routes::query::build_table_structure_change_sql)).route("/query/build-table-owner-change-sql", post(routes::query::build_table_owner_change_sql)).route("/query/build-table-partition-operation-sql", post(routes::query::build_table_partition_operation_sql))diff --git a/crates/dbx-web/src/routes/query.rs b/crates/dbx-web/src/routes/query.rsindex a93ef93266..e048dba300 100644--- a/crates/dbx-web/src/routes/query.rs+++ b/crates/dbx-web/src/routes/query.rs@@ -272,12 +272,40 @@ pub struct BuildExecutableObjectSourceRequest {pub input: dbx_core::object_source_sql::EditableObjectSourceSqlInput,}+#[derive(Deserialize)]+#[serde(rename_all = "camelCase")]+pub struct ValidateOracleExecutableObjectSourceRequest {+ pub input: dbx_core::object_source_sql::OracleObjectSourceValidationInput,+}+#[derive(Deserialize)]#[serde(rename_all = "camelCase")]pub struct BuildRoutineRenameObjectSourceRequest {pub input: dbx_core::object_source_sql::RoutineRenameObjectSourceInput,}+#[derive(Deserialize)]+#[serde(rename_all = "camelCase")]+pub struct RewriteOracleRoutineReferencesRequest {+ pub input: dbx_core::object_source_sql::OracleRoutineReferenceRewriteInput,+}++#[derive(Deserialize)]+#[serde(rename_all = "camelCase")]+pub struct RewriteOracleTableReferencesRequest {+ pub input: dbx_core::object_source_sql::OracleTableReferenceRewriteInput,+}++#[derive(Deserialize)]+pub struct ParseOracleObjectNameRequest {+ pub input: String,+}++#[derive(Deserialize)]+pub struct BuildOracleViewRenameSourceRequest {+ pub input: dbx_core::oracle_view_rename::OracleViewRenameSourceInput,+}+#[derive(Deserialize)]#[serde(rename_all = "camelCase")]pub struct BuildViewDdlRequest {@@ -1243,6 +1271,20 @@ pub async fn build_executable_object_source_statements(dbx_core::object_source_sql::build_executable_object_source_statements(req.input).map(Json).map_err(AppError::from)}+pub async fn validate_oracle_executable_object_source(+ Json(req): Json<ValidateOracleExecutableObjectSourceRequest>,+) -> Result<Json<()>, AppError> {+ dbx_core::object_source_sql::validate_oracle_executable_object_source(req.input)+ .map(|()| Json(()))+ .map_err(AppError::from)+}++pub async fn fingerprint_oracle_routine_object_source(+ Json(req): Json<BuildExecutableObjectSourceRequest>,+) -> Result<Json<String>, AppError> {+ dbx_core::object_source_sql::fingerprint_oracle_routine_object_source(req.input).map(Json).map_err(AppError::from)+}+pub async fn build_executable_object_source_sql(Json(req): Json<BuildExecutableObjectSourceRequest>,) -> Result<Json<String>, AppError> {@@ -1261,10 +1303,38 @@ pub async fn build_routine_rename_object_source_statements(.map_err(AppError::from)}+pub async fn rewrite_oracle_routine_references(+ Json(req): Json<RewriteOracleRoutineReferencesRequest>,+) -> Result<Json<String>, AppError> {+ dbx_core::object_source_sql::rewrite_oracle_routine_references(req.input).map(Json).map_err(AppError::from)+}++pub async fn rewrite_oracle_table_references(+ Json(req): Json<RewriteOracleTableReferencesRequest>,+) -> Result<Json<String>, AppError> {+ dbx_core::object_source_sql::rewrite_oracle_table_references(req.input).map(Json).map_err(AppError::from)+}+pub async fn build_view_ddl_sql(Json(req): Json<BuildViewDdlRequest>) -> Json<String> {Json(dbx_core::object_source_sql::build_view_ddl_sql(req.input))}+pub async fn parse_oracle_object_name(Json(req): Json<ParseOracleObjectNameRequest>) -> Result<Json<String>, AppError> {+ dbx_core::oracle_view_rename::parse_oracle_object_name(&req.input).map(Json).map_err(AppError::from)+}++pub async fn build_oracle_view_rename_source(+ Json(req): Json<BuildOracleViewRenameSourceRequest>,+) -> Result<Json<dbx_core::oracle_view_rename::OracleViewRenameSource>, AppError> {+ dbx_core::oracle_view_rename::build_oracle_view_rename_source(req.input).map(Json).map_err(AppError::from)+}++pub async fn review_oracle_view_rename_source(+ Json(req): Json<BuildOracleViewRenameSourceRequest>,+) -> Json<dbx_core::oracle_view_rename::OracleViewRenameSourceReview> {+ Json(dbx_core::oracle_view_rename::review_oracle_view_rename_source(req.input))+}+pub async fn build_table_structure_change_sql(Json(req): Json<BuildTableStructureSqlRequest>,) -> Json<dbx_core::table_structure_sql::TableStructureSqlResult> {diff --git a/docs/testing/oceanbase-view-rename-draft-guard.png b/docs/testing/oceanbase-view-rename-draft-guard.pngnew file mode 100644index 0000000000..4b1546344aBinary files /dev/null and b/docs/testing/oceanbase-view-rename-draft-guard.png differdiff --git a/docs/testing/oceanbase-view-rename-entry.png b/docs/testing/oceanbase-view-rename-entry.pngnew file mode 100644index 0000000000..dc430703bcBinary files /dev/null and b/docs/testing/oceanbase-view-rename-entry.png differdiff --git a/docs/testing/oceanbase-view-rename.md b/docs/testing/oceanbase-view-rename.mdnew file mode 100644index 0000000000..47719f2462--- /dev/null+++ b/docs/testing/oceanbase-view-rename.md@@ -0,0 +1,90 @@+# OceanBase Oracle 普通视图改名验收++本次验收覆盖侧栏和对象浏览器的普通视图改名、同属主静态视图依赖同步,以及打开的源码草稿保护。基线为 `188b94ece23c44a40515915bbf2048cf211a98dd`。数据库为 OceanBase 4.2.5.7 Oracle 模式,产品入口使用 OceanBase Connector/J 2.4.19;验收于 2026-10-13 完成。++## 问题现象++原入口仅开放 OceanBase Oracle 表改名。普通视图可以执行不带属主的 `RENAME`,但直接改名会让原名称引用的依赖视图失效。旧源码编辑上下文还可能按原名称保存,重新创建旧对象。++## 复现与修复验证++操作入口:在侧栏或对象浏览器的普通视图上右键,选择「结构工具 → 重命名」。侧栏选中视图后也可按 F2。填写新名,核对依赖 SQL 预览后确认。++++在隔离属主下创建根视图和两级依赖,根视图包含带引号的列别名与 `WITH READ ONLY`,三个视图均授予另一隔离账号 `SELECT WITH GRANT OPTION`。++1. 从侧栏的「结构工具 → 重命名」将根视图改为带空格和混合大小写的引号名称。预览列出根视图 `RENAME`、直接依赖引用改写和间接依赖原定义重建。+2. 从对象浏览器将根视图再次改名,并保留一个未保存的旧名称源码草稿。+3. 通过产品 Agent 读回:旧名称消失,三个视图均为 `VALID`,列别名、只读属性和三项 `SELECT WITH GRANT OPTION` 保留,隔离视图查询结果均为 42。+4. 保存旧草稿被身份检查阻断;草稿内容保留,数据库中的定义及值不变。++++生产函数及组件测试覆盖取消、目标切换、依赖图变化、截断元数据、权限降级、两级重建、部分失败、响应未知、并发 hint 修改及迟到源码加载。Rust 改写测试覆盖引号名称、属主、alias、CTE、文本保真,以及当前或后续 CTE 捕获新名称的前置拒绝。++## 执行边界++自动处理范围为当前账号可见、同属主、可安全解析的普通视图依赖。预览明确披露:不可见的跨属主依赖、动态 SQL 和应用引用不会迁移,改名后可能失效。查询成功或零行不证明全库无依赖,也不要求所有用户具有 DBA 权限。++可确认的引用由系统自动改写。某个 hint 或定义无法安全改写时,改名弹框仍保留其余对象的预览,并显示问题对象、hint 原文及可得行列;用户可在同一弹框修正改名前定义并点击“重新校验”。校验会重新检查声明、引用绑定、依赖拓扑和目标身份,通过后才启用原确认按钮。问题未修正时按钮保持禁用,不会派发 DDL。跨属主、非视图、循环或定义/依赖元数据不完整属于当前不可由编辑 SQL 解除的问题,界面会说明原因并要求处理对象或重新读取计划。执行前重新核对目标、定义、依赖及授权;每个依赖覆盖前再比较完整原定义和授权。首错停止并保留原定义和已确认步骤,不执行自动回滚。++源码冻结和保存互斥作用于同一前端实例。其他实例的修改通过元数据复核检测,DDL 执行不具备跨实例原子性。旧只读数据标签保留原名称和结果,需要刷新或重新打开。++## 检查结果与缺口++- 7 个前端测试文件的 53 项测试、类型检查、改动文件格式与 lint 通过;包含中文旧稿保护提示回归。+- Rust 改写 13 项定向测试、SQL Core 全库测试和 Clippy 通过;Web 前后端构建通过。+- 9 个要求的语言包新增键齐备;离线 i18n dry-run 无待补译文件。+- 架构检查在临时将 DuckDB 锁文件换行规范为 LF 后 28 项通过,随后恢复原文件。原 Windows CRLF 工作副本触发既有检查脚本的分隔符解析失败,未计为原命令通过;连接类型生成检查通过。+- 两处 Web GUI 入口和产品 Agent 实库读回通过,隔离对象完成精确清理和读回。+- 原生 Oracle 实库测试获准暂缓;本次结果不能作为原生 Oracle 验收证据。+- Windows 原生桌面构建未执行;Web GUI 不替代原生桌面验收。+- 本文原验收对应的普通视图改名保持上述基线范围。PR50 在 2026-10-14 增加表、例程改名和包另存为修复:Oracle 表列级授权按 `TABLE_SCHEMA` 查询,OceanBase Oracle 保留 `OWNER`;例程和包来源改写失败时保留源草稿并允许重新校验。+- PR50 本轮定向前端测试 7 个文件 96 项通过。SidebarTreeRuntimeHost 组件宿主测试 4 项验证 routine/package 草稿与校验入口透传、原生 Oracle routine prepare 路径、同目标取消后重开保留草稿及目标切换清稿;routine/package 人工修正后重新 prepare 并成功 execute 的 2 项定向测试通过。Rust `oracle_` 测试 103 项通过,包含 strict validator 对 owner/name/type、单 PL/SQL 单元、裸声明和 quoted mixed-case identity 的检查。定向 oxlint 退出码为 0,只有 ObjectBrowser.vue:3387 与 SidebarTreeRuntimeHost.vue:5426 的既有 `no-ex-assign` 告警;`git diff --check` 通过。+- Oracle package 源码写入前通过既有 executable-source builder 校验生成的 spec/body;native Oracle routine caller 草稿在 rename 专用 validator 中校验 owner、name、type 和完整 PL/SQL 边界,并经 Tauri/Web 两条 backend 传输注册。routine rename caller view 在 prepare、替换后读回及删除旧 routine 前复用 Oracle view review API,拒绝声明名不匹配的 `CREATE OR REPLACE VIEW` 草稿;一般 view builder 对裸查询的契约未改。侧栏与 ObjectBrowser 的 routine draft 生命周期及编辑后旧 SQL 隐藏已补修。PR50 两入口 Web GUI 与 OceanBase Oracle 实库验收由主会话继续完成;本轮没有执行 Oracle DDL。原生 Oracle 实库测试继续暂缓,不计为通过。++## 2026-10-14 人工草稿流程增量验收++本段运行证据对应源码 `0ee2d78df50727c09a0bdecb083c373d29e5b2d3`,Web 后端 SHA-256 为 `4DF1CB1DA6CAFC8D4424F4FCFC67B97108B216C15B90750AB16B4BF9B902555F`。最终类型检查、Web 前端及 GNU 后端构建通过;复用 OceanBase 4.2.5.7 Oracle 模式、Connector/J 2.4.19 和 Agent 0.1.77。以下操作仅涉及本轮隔离对象,未执行过程或包内例程。++- 侧栏过程改名弹窗正常加载。手动修改调用方源码后,旧 SQL 预览隐藏、确认按钮禁用;重新校验后生成两处指向新名称的静态调用。确认改名后,旧过程不存在,新过程及调用方均为 `VALID`。+- 对象浏览器的包另存为正确拒绝包体中的动态旧名称引用,同时保留已生成的包规格 SQL 和可编辑包体。将包体改为静态调用后重新校验,创建新包及包体成功,原包及包体保留。+- 经产品查询入口读回,本轮六个对象均为 `VALID`,旧过程数量为 0,`USER_ERRORS` 编译错误数量为 0。隔离对象尚未清理,待例程守卫补丁复验后统一精确清理。+- GUI 同时发现例程调用方混合静态旧名调用与 `EXECUTE IMMEDIATE` 时,重写器只改静态调用,仍允许残留动态旧引用。实际执行前已人工删除该动态引用;生产 Rust 入口已复现失败测试,守卫补丁与最终产物复验待完成。本段成功证据不代表该遗漏已修复。++++原生 Oracle 实库继续获准暂缓;Web GUI 不替代原生桌面验收。本批同时补齐基线 HANA `column_data_type` 调用缺失的参数,使当前 Web 构建可执行。docs-export 构建发现基线依赖生成漂移;相关输入没有本次改动,因此保留基线产物,不将无关生成差异带入本批。++### 动态守卫复验与写后比较缺口++候选 `6399de7d6a5ad18629bc3cfc0f52aa88ec3d95fb` 的 GNU 后端构建通过,运行文件 SHA-256 为 `AF6F7BC7D4C1532A99D1CA107703ED0AB242E5CA0E9B5D1F082A06CC6D979D6A`。107 项 Rust 测试、25 项相关前端测试、Clippy 及窄增量双维审查通过。++- 修复产物在 GUI 中正确阻断混合静态调用与 `EXECUTE IMMEDIATE`,返回行列位置;调用方草稿保留,确认禁用。人工改成两次静态调用后,取消并重开同一目标仍保留单行草稿,重新校验成功。+- 执行后创建目标过程及替换调用方成功,但 OceanBase 读回定义在声明名、`IS`、`BEGIN` 之间插入换行,当前逐字源码比较误报不一致。通过产品查询入口读回确认调用方已含两处正确目标调用;七个隔离对象均为 `VALID`,旧过程仍保留。该执行为部分成功,不计整条重命名通过,也未自动重试或回滚。+- 已用真实 prepare/execute 入口和仅模拟外部数据库格式化的回归测试复现红灯;保守源码指纹修复与最终 GUI 复验待完成。++++### 写后指纹修复候选++`cb9e8ceb7087a193cca70acbab31d89498ec031c` 已补齐根例程写后、调用方写后和 DROP 前的保守 token 指纹比较,原始元数据快照仍精确比较。50 项前端定向测试、110 项 Rust 定向测试及增量双维独立审查通过;前端生产构建和 GNU Web 后端构建退出码均为 0。后端 SHA-256 为 `9DB127A46DCE737A06F1A2CC67A3039285B69798324FFA59EDB9CC347ACED48D`。最终产物 GUI 复验及隔离对象清理已完成,结果见下文。++- 定向用例覆盖数据库仅重排声明空白时完成改名、根对象单行草稿、调用方写入后字符串/注释/调用改变时禁止 DROP,以及原始快照仅空白改变仍在写前阻断。+- 核心 crate 的 `Clippy -D warnings` 通过。Web 的 `--no-deps` 定向检查通过;Tauri 的定向检查需对现有 `drain_collect`、`result_large_err` 告警明确豁免后通过。完整 Web 依赖检查因未修改驱动的既有告警失败,不能记为完整 CI Clippy 通过。本机 Rust 1.99.0,CI 固定 1.97.1。+- 完整类型检查已通过(`cb9e8ceb`,退出码 0):首次预检发现可用 6756 MiB,不足 6144 MiB 堆加 2048 MiB 余量,未执行;随后现场可用内存升至 8226 MiB,按原 6144 MiB 配置运行完整 `vue-tsc --noEmit` 成功,未降低限制。最终 SHA 的 CI 类型检查结果仍单独核对。+- 架构检查 27/28;唯一失败仍为 DuckDB 锁文件检查按 LF 分块,而本地文件为 CRLF。实际依赖条目存在,未修改无关锁文件或放宽检查。++### 最终产物 GUI 复验与清理++2026-10-14 核对运行文件为上述 `cb9e8ceb` 产物,仅监听回环地址;所载 OceanBase Oracle Agent JAR SHA-256 为 `D6C78A63F14FF0A8FCBD5FA074B4EAB93E5BE7F308D9609F83114807B6494B93`。通过产品 SQL 查询确认登录用户与当前 schema 均为本批既有测试身份。++- 先恢复本批调用方的静态调用加动态 SQL 场景,并精确移除上次部分执行创建的目标过程。侧栏预检正常结束,动态 SQL 仍被阻断,源草稿可编辑。+- 将调用方人工改为单行定义、两次静态调用,重新校验后执行重命名成功。通过产品查询读回:原名称对象数量为 0,目标过程与调用方两个对象均为 `VALID`,编译错误为 0。+- `USER_SOURCE` 全文确认两次调用均指向重命名目标;没有再因数据库重排声明空白误报失败,删除旧对象阶段也已完成。+- 按本批记录精确清理两个过程和两个包(含包体),再查询五个记录名称,`USER_OBJECTS` 与 `USER_ERRORS` 残留均为 0。没有执行测试过程或包内例程,其他对象未清理。++++以上完成 Web GUI 与 OceanBase Oracle 模式验收;原生 Oracle 实库仍获准暂缓,原生桌面 GUI 未执行,最终提交的远端 CI 单独跟踪。diff --git a/docs/testing/oracle-package-manual-preview.jpg b/docs/testing/oracle-package-manual-preview.jpgnew file mode 100644index 0000000000..e78d09ec4aBinary files /dev/null and b/docs/testing/oracle-package-manual-preview.jpg differdiff --git a/docs/testing/oracle-routine-manual-guard.jpg b/docs/testing/oracle-routine-manual-guard.jpgnew file mode 100644index 0000000000..19ca7b2babBinary files /dev/null and b/docs/testing/oracle-routine-manual-guard.jpg differdiff --git a/docs/testing/oracle-routine-manual-success.jpg b/docs/testing/oracle-routine-manual-success.jpgnew file mode 100644index 0000000000..cc22876bb9Binary files /dev/null and b/docs/testing/oracle-routine-manual-success.jpg differdiff --git a/src-tauri/src/commands/query.rs b/src-tauri/src/commands/query.rsindex a370bbedb3..d497917605 100644--- a/src-tauri/src/commands/query.rs+++ b/src-tauri/src/commands/query.rs@@ -847,6 +847,20 @@ pub fn build_executable_object_source_statements(dbx_core::object_source_sql::build_executable_object_source_statements(input)}+#[tauri::command]+pub fn validate_oracle_executable_object_source(+ input: dbx_core::object_source_sql::OracleObjectSourceValidationInput,+) -> Result<(), String> {+ dbx_core::object_source_sql::validate_oracle_executable_object_source(input)+}++#[tauri::command]+pub fn fingerprint_oracle_routine_object_source(+ input: dbx_core::object_source_sql::EditableObjectSourceSqlInput,+) -> Result<String, String> {+ dbx_core::object_source_sql::fingerprint_oracle_routine_object_source(input)+}+#[tauri::command]pub fn build_executable_object_source_sql(input: dbx_core::object_source_sql::EditableObjectSourceSqlInput,@@ -868,11 +882,44 @@ pub fn build_routine_rename_object_source_statements(dbx_core::object_source_sql::build_routine_rename_object_source_statements(input)}+#[tauri::command]+pub fn rewrite_oracle_routine_references(+ input: dbx_core::object_source_sql::OracleRoutineReferenceRewriteInput,+) -> Result<String, String> {+ dbx_core::object_source_sql::rewrite_oracle_routine_references(input)+}++#[tauri::command]+pub fn rewrite_oracle_table_references(+ input: dbx_core::object_source_sql::OracleTableReferenceRewriteInput,+) -> Result<String, String> {+ dbx_core::object_source_sql::rewrite_oracle_table_references(input)+}+#[tauri::command]pub fn build_view_ddl_sql(input: dbx_core::object_source_sql::BuildViewDdlInput) -> Result<String, String> {Ok(dbx_core::object_source_sql::build_view_ddl_sql(input))}+#[tauri::command]+pub fn parse_oracle_object_name(input: String) -> Result<String, String> {+ dbx_core::oracle_view_rename::parse_oracle_object_name(&input)+}++#[tauri::command]+pub fn build_oracle_view_rename_source(+ input: dbx_core::oracle_view_rename::OracleViewRenameSourceInput,+) -> Result<dbx_core::oracle_view_rename::OracleViewRenameSource, String> {+ dbx_core::oracle_view_rename::build_oracle_view_rename_source(input)+}++#[tauri::command]+pub fn review_oracle_view_rename_source(+ input: dbx_core::oracle_view_rename::OracleViewRenameSourceInput,+) -> dbx_core::oracle_view_rename::OracleViewRenameSourceReview {+ dbx_core::oracle_view_rename::review_oracle_view_rename_source(input)+}+#[tauri::command]pub fn build_table_structure_change_sql(options: dbx_core::table_structure_sql::TableStructureSqlOptions,diff --git a/src-tauri/src/lib.rs b/src-tauri/src/lib.rsindex 309c26fe9b..8c58408e01 100644--- a/src-tauri/src/lib.rs+++ b/src-tauri/src/lib.rs@@ -2244,9 +2244,16 @@ pub fn run() {commands::query::build_duplicate_table_structure_sql,commands::query::build_copy_table_data_sql,commands::query::build_executable_object_source_statements,+ commands::query::validate_oracle_executable_object_source,+ commands::query::fingerprint_oracle_routine_object_source,commands::query::build_executable_object_source_sql,commands::query::build_editable_object_source,commands::query::build_routine_rename_object_source_statements,+ commands::query::rewrite_oracle_routine_references,+ commands::query::rewrite_oracle_table_references,+ commands::query::parse_oracle_object_name,+ commands::query::build_oracle_view_rename_source,+ commands::query::review_oracle_view_rename_source,commands::query::build_view_ddl_sql,commands::query::build_table_structure_change_sql,commands::query::build_table_owner_change_sql,