Skip to content

armgit / dbx

Public Imported from GitHub
0

25 MB lightweight cross-platform database client for 100+ databases, including MySQL, PostgreSQL, SQLite, Redis, MongoDB, DuckDB, SQL Server, and Dameng. Built-in AI, MCP Server, CLI, desktop and Docker. | 轻量级跨平台数据库管理工具,支持 MySQL、PostgreSQL、SQLite、Redis、MongoDB、达梦等 100+ 数据库,提供桌面端、Docker、CLI、内置 AI 助手和 MCP。

fix(sqlserver): keep long multiline literals over 4000 chars

李子凡d0447bc264cc
diff --git a/crates/dbx-sql-data/src/data_grid_sql.rs b/crates/dbx-sql-data/src/data_grid_sql.rs
index 97d2a48bd5..0eba8a94b4 100644
--- a/crates/dbx-sql-data/src/data_grid_sql.rs
+++ b/crates/dbx-sql-data/src/data_grid_sql.rs
@@ -55,6 +55,9 @@ const MYSQL_DATA_GRID_BATCH_MAX_ROWS: usize = 500;
const MYSQL_DATA_GRID_BATCH_TARGET_SQL_BYTES: usize = 256 * 1024;
const ORACLE_SQL_LITERAL_MAX_BYTES: usize = 4000;
const ORACLE_LOB_LITERAL_CHUNK_BYTES: usize = 3900;
+/// SQL Server types an `N'..' + NCHAR(n) + N'..'` chain of non-`max` operands as
+/// `nvarchar(4000)`; a longer concatenation result is truncated without an error.
+const SQLSERVER_NVARCHAR_LITERAL_MAX_CHARS: usize = 4000;
#[derive(Debug, Clone, Serialize, Deserialize)]
#[cfg_attr(feature = "openapi", derive(utoipa::ToSchema))]
@@ -2887,10 +2890,19 @@ fn format_sqlserver_unicode_literal(text: &str) -> String {
parts.push(format!("N'{}'", segment.replace('\'', "''")));
}
if parts.is_empty() {
- "N''".to_string()
- } else {
- parts.join(" + ")
+ return "N''".to_string();
+ }
+ // SQL Server types a `+` chain of ordinary literals and `NCHAR(n)` as
+ // `nvarchar(4000)`, and silently truncates a longer result instead of
+ // failing, so a long value needs an `nvarchar(max)` operand to survive
+ // (issue #12202). A single literal needs no anchor: SQL Server already types
+ // a literal longer than 4000 characters as `nvarchar(max)`. Each emitted
+ // character of the chain is one UTF-16 code unit of `text`, so the value's
+ // own length is the length of the concatenation.
+ if parts.len() > 1 && text.encode_utf16().count() > SQLSERVER_NVARCHAR_LITERAL_MAX_CHARS {
+ parts.insert(0, "CAST(N'' AS NVARCHAR(MAX))".to_string());
}
+ parts.join(" + ")
}
fn is_sqlite_literal_database(database_type: Option<DatabaseType>) -> bool {
@@ -10363,6 +10375,26 @@ mod tests {
);
}
+ #[test]
+ fn sqlserver_long_multiline_literals_anchor_nvarchar_max() {
+ // A `+` chain of non-`max` operands is typed nvarchar(4000) by SQL Server, which
+ // silently truncates a longer result, so a long value must be anchored on
+ // nvarchar(max) or the copied statement loses everything past 4000 characters
+ // (issue #12202).
+ let long_value = format!("{}\n{}", "a".repeat(3000), "b".repeat(3000));
+ let literal = format_grid_sql_literal(&json!(long_value), Some(DatabaseType::SqlServer), None);
+ assert!(literal.starts_with("CAST(N'' AS NVARCHAR(MAX)) + N'"), "{literal}");
+ assert!(literal.contains(" + NCHAR(10) + N'"), "{literal}");
+
+ // A value that fits in nvarchar(4000) keeps the plain chain.
+ let short_value = format_grid_sql_literal(&json!("line1\nline2"), Some(DatabaseType::SqlServer), None);
+ assert_eq!(short_value, r"N'line1' + NCHAR(10) + N'line2'");
+
+ // A single long literal is already nvarchar(max) by SQL Server's own rules.
+ let single_line = format_grid_sql_literal(&json!("a".repeat(5000)), Some(DatabaseType::SqlServer), None);
+ assert_eq!(single_line, format!("N'{}'", "a".repeat(5000)));
+ }
+
#[test]
fn prepares_sqlserver_updates_without_doubling_backslashes() {
let result = prepare_data_grid_save(DataGridSaveStatementOptions {