Skip to content

armgit / dbx

Public Imported from GitHub
0

25 MB lightweight cross-platform database client for 100+ databases, including MySQL, PostgreSQL, SQLite, Redis, MongoDB, DuckDB, SQL Server, and Dameng. Built-in AI, MCP Server, CLI, desktop and Docker. | 轻量级跨平台数据库管理工具,支持 MySQL、PostgreSQL、SQLite、Redis、MongoDB、达梦等 100+ 数据库,提供桌面端、Docker、CLI、内置 AI 助手和 MCP。

feat(hana): enable table rename and structure editing

zipgfd3be84b3395
diff --git a/apps/desktop/src/lib/table/tableStructureCapabilities.ts b/apps/desktop/src/lib/table/tableStructureCapabilities.ts
index f52f1bfb5a..f4bcfd5d6d 100644
--- a/apps/desktop/src/lib/table/tableStructureCapabilities.ts
+++ b/apps/desktop/src/lib/table/tableStructureCapabilities.ts
@@ -276,6 +276,17 @@ const informixCapabilities = capabilities({
rebuildIndex: true,
});
+const sapHanaCapabilities = capabilities({
+ dialect: "oracle",
+ addColumn: true,
+ dropColumn: true,
+ renameColumn: true,
+ alterExistingColumn: true,
+ alterType: true,
+ alterNullability: true,
+ alterDefault: true,
+});
+
// Inceptor accepts ADD COLUMNS and CHANGE. DROP COLUMN and index/constraint DDL
// remain disabled until a safe server-supported form is verified.
const transwarpCapabilities = capabilities({
@@ -381,6 +392,7 @@ const capabilityByType: Partial<Record<DatabaseType, TableStructureCapabilities>
access: accessCapabilities,
clickhouse: clickhouseCapabilities,
informix: informixCapabilities,
+ saphana: sapHanaCapabilities,
transwarp: transwarpCapabilities,
influxdb: influxdbCapabilities,
manticoresearch: manticoreSearchCapabilities,
diff --git a/crates/dbx-core/assets/database-drivers.manifest.json b/crates/dbx-core/assets/database-drivers.manifest.json
index 34e7373491..3665bd4007 100644
--- a/crates/dbx-core/assets/database-drivers.manifest.json
+++ b/crates/dbx-core/assets/database-drivers.manifest.json
@@ -1468,7 +1468,7 @@
"schemaSearch": true,
"diagram": true,
"tableDataEdit": true,
- "tableStructureEdit": false,
+ "tableStructureEdit": true,
"tableImport": false,
"dataTransfer": false,
"sqlFileExecution": true,
diff --git a/crates/dbx-sql-schema/src/db_admin_sql.rs b/crates/dbx-sql-schema/src/db_admin_sql.rs
index 544b19532f..4ae28a90ca 100644
--- a/crates/dbx-sql-schema/src/db_admin_sql.rs
+++ b/crates/dbx-sql-schema/src/db_admin_sql.rs
@@ -804,7 +804,13 @@ pub fn build_duplicate_table_structure_sql(options: DuplicateTableStructureSqlOp
qualified_duplicate_target_name(options.database_type, options.schema.as_deref(), &options.target_name);
let structure_sql = if matches!(
options.database_type,
- Some(DatabaseType::Mysql | DatabaseType::Kyuubi | DatabaseType::Impala | DatabaseType::Argo)
+ Some(
+ DatabaseType::Mysql
+ | DatabaseType::Kyuubi
+ | DatabaseType::Impala
+ | DatabaseType::Argo
+ | DatabaseType::SapHana
+ )
) {
format!("CREATE TABLE {target} LIKE {source};")
} else if options.database_type == Some(DatabaseType::Questdb) {
@@ -979,6 +985,9 @@ pub fn supports_object_rename(database_type: Option<DatabaseType>, object_type:
if matches!(database_type, DatabaseType::Transwarp | DatabaseType::StarRocks) {
return object_type == DatabaseObjectType::Table;
}
+ if database_type == DatabaseType::SapHana {
+ return object_type == DatabaseObjectType::Table;
+ }
if matches!(object_type, DatabaseObjectType::Procedure | DatabaseObjectType::Function) {
return false;
}
@@ -1030,6 +1039,14 @@ pub fn build_rename_object_sql(options: RenameObjectSqlOptions) -> Result<String
));
}
+ if database_type == Some(DatabaseType::SapHana) {
+ return Ok(format!(
+ "RENAME TABLE {} TO {};",
+ qualified_name(database_type, options.schema.as_deref(), &options.old_name),
+ qualified_name(database_type, options.schema.as_deref(), &options.new_name)
+ ));
+ }
+
if database_type == Some(DatabaseType::Transwarp) {
return Ok(format!(
"ALTER TABLE {} RENAME TO {};",
@@ -2572,6 +2589,24 @@ mod tests {
}
}
+ #[test]
+ fn duplicate_table_structure_saphana_uses_like_instead_of_ctas() {
+ assert_eq!(
+ build_duplicate_table_structure_sql(DuplicateTableStructureSqlOptions {
+ database_type: Some(DatabaseType::SapHana),
+ schema: Some("APP".to_string()),
+ source_name: "orders".to_string(),
+ target_name: "orders_copy".to_string(),
+ table_comment: None,
+ column_comments: vec![],
+ primary_key_columns: vec![],
+ primary_key_constraint_name: None,
+ identifier_quote: None,
+ }),
+ "CREATE TABLE \"APP\".\"orders_copy\" LIKE \"APP\".\"orders\";"
+ );
+ }
+
#[test]
fn copy_table_data_vastbase_keeps_insert_and_target_quoting() {
for normalize_new_target_name in [false, true] {
@@ -3178,6 +3213,22 @@ mod tests {
}
}
+ #[test]
+ fn builds_saphana_table_rename_sql() {
+ let options = RenameObjectSqlOptions {
+ database_type: Some(DatabaseType::SapHana),
+ object_type: DatabaseObjectType::Table,
+ schema: Some("APP".to_string()),
+ old_name: "orders".to_string(),
+ new_name: "orders_copy".to_string(),
+ };
+ assert!(supports_object_rename(options.database_type, options.object_type));
+ assert_eq!(
+ build_rename_object_sql(options).unwrap(),
+ "RENAME TABLE \"APP\".\"orders\" TO \"APP\".\"orders_copy\";"
+ );
+ }
+
#[test]
fn builds_mysql_table_and_view_rename_sql() {
assert_eq!(
diff --git a/crates/dbx-sql-schema/src/table_structure_sql/column_alter.rs b/crates/dbx-sql-schema/src/table_structure_sql/column_alter.rs
index b935c91c66..7e3d924ba3 100644
--- a/crates/dbx-sql-schema/src/table_structure_sql/column_alter.rs
+++ b/crates/dbx-sql-schema/src/table_structure_sql/column_alter.rs
@@ -163,6 +163,7 @@ pub fn build_single_column_alter_sql(options: SingleColumnAlterSqlOptions) -> Ta
statements.extend(build_oracle_like_existing_column_sql(dialect, &table, &options.column))
}
}
+ StructureDialect::SapHana => statements.extend(build_saphana_existing_column_sql(&table, &options.column)),
StructureDialect::Dameng => {
statements.extend(build_dameng_existing_column_sql(&table, &options.column, true, &mut warnings))
}
@@ -783,6 +784,46 @@ pub(super) fn build_oracle_like_existing_column_sql(
statements
}
+pub(super) fn build_saphana_existing_column_sql(table: &str, column: &EditableStructureColumn) -> Vec<String> {
+ let Some(original) = &column.original else {
+ return Vec::new();
+ };
+ let mut statements = Vec::new();
+ let mut current_name = original.name.clone();
+ if column.name != original.name {
+ statements.push(format!(
+ "RENAME COLUMN {table}.{} TO {};",
+ quote_ident(StructureDialect::SapHana, &original.name),
+ quote_ident(StructureDialect::SapHana, &column.name)
+ ));
+ current_name = column.name.clone();
+ }
+
+ let type_changed = column.data_type.trim() != original.data_type.trim();
+ let nullable_changed = column.is_nullable != original.is_nullable;
+ let default_changed = normalize_default(Some(&column.default_value)) != original_default(column);
+ if type_changed || nullable_changed || default_changed {
+ let mut parts = vec![
+ quote_ident(StructureDialect::SapHana, &current_name),
+ column_data_type(StructureDialect::SapHana, column),
+ ];
+ let default_value = normalize_default(Some(&column.default_value));
+ if !default_value.is_empty() {
+ parts.push(format!(
+ "DEFAULT {}",
+ format_default_for_sql(StructureDialect::SapHana, &column.data_type, &default_value)
+ ));
+ } else if default_changed {
+ parts.push("DEFAULT NULL".to_string());
+ }
+ if nullable_changed {
+ parts.push(if column.is_nullable { "NULL" } else { "NOT NULL" }.to_string());
+ }
+ statements.push(format!("ALTER TABLE {table} ALTER ({});", parts.join(" ")));
+ }
+ statements
+}
+
pub(super) fn build_dameng_existing_column_sql(
table: &str,
column: &EditableStructureColumn,
diff --git a/crates/dbx-sql-schema/src/table_structure_sql/columns.rs b/crates/dbx-sql-schema/src/table_structure_sql/columns.rs
index 62a0dba696..178a3ba564 100644
--- a/crates/dbx-sql-schema/src/table_structure_sql/columns.rs
+++ b/crates/dbx-sql-schema/src/table_structure_sql/columns.rs
@@ -5,10 +5,10 @@ use super::column_alter::{
build_clickhouse_existing_column_sql, build_dameng_existing_column_sql, build_doris_existing_column_sql,
build_h2_existing_column_sql, build_informix_existing_column_sql, build_iris_existing_column_sql,
build_mysql_existing_column_clause, build_oracle_like_existing_column_sql, build_oscar_existing_column_sql,
- build_postgres_existing_column_sql, build_questdb_existing_column_sql, build_sqlite_existing_column_sql,
- build_sqlserver_drop_default_constraint_sql, build_sqlserver_existing_column_sql, build_xugu_existing_column_sql,
- dameng_drops_identity, has_column_extra_change, has_existing_column_attribute_change,
- validate_dameng_existing_identity_change,
+ build_postgres_existing_column_sql, build_questdb_existing_column_sql, build_saphana_existing_column_sql,
+ build_sqlite_existing_column_sql, build_sqlserver_drop_default_constraint_sql, build_sqlserver_existing_column_sql,
+ build_xugu_existing_column_sql, dameng_drops_identity, has_column_extra_change,
+ has_existing_column_attribute_change, validate_dameng_existing_identity_change,
};
use super::column_format::{
column_definition, has_dameng_identity, is_dameng_identity_compatible_type, is_mysql_character_data_type,
@@ -377,6 +377,7 @@ pub(super) fn build_column_sql(options: &TableStructureSqlOptions, warnings: &mu
#[cfg(feature = "duckdb-sidecar")]
StructureDialect::DuckDb => statements.extend(build_duckdb_existing_column_sql(&table, column)),
StructureDialect::Questdb => statements.extend(build_questdb_existing_column_sql(&table, column)),
+ StructureDialect::SapHana => statements.extend(build_saphana_existing_column_sql(&table, column)),
_ => warnings.push(format!("Editing existing columns is not supported for {database_label} yet.")),
}
if has_position_change {
@@ -720,7 +721,7 @@ pub(super) fn build_add_column_sql(
let definition = column_definition(dialect, column);
let mut statements = if database_type == Some(DatabaseType::Transwarp) {
vec![format!("ALTER TABLE {table} ADD COLUMNS ({definition});")]
- } else if is_oracle_like(dialect) || dialect == StructureDialect::Informix {
+ } else if is_oracle_like(dialect) || matches!(dialect, StructureDialect::Informix | StructureDialect::SapHana) {
vec![format!("ALTER TABLE {table} ADD ({definition});")]
} else {
let add_keyword = if dialect == StructureDialect::SqlServer
@@ -767,7 +768,7 @@ pub(super) fn build_add_column_sql(
pub(super) fn build_drop_column_sql(dialect: StructureDialect, table: &str, original: &ColumnInfo) -> Vec<String> {
let column_name = &original.name;
- if dialect == StructureDialect::Informix {
+ if matches!(dialect, StructureDialect::Informix | StructureDialect::SapHana) {
return vec![format!("ALTER TABLE {table} DROP ({});", quote_ident(dialect, column_name))];
}
let mut statements = Vec::new();
diff --git a/crates/dbx-sql-schema/src/table_structure_sql/dialect.rs b/crates/dbx-sql-schema/src/table_structure_sql/dialect.rs
index d09ccabf1b..8a21dffa0a 100644
--- a/crates/dbx-sql-schema/src/table_structure_sql/dialect.rs
+++ b/crates/dbx-sql-schema/src/table_structure_sql/dialect.rs
@@ -9,6 +9,7 @@ pub(super) enum StructureDialect {
#[cfg(feature = "duckdb-sidecar")]
DuckDb,
SqlServer,
+ SapHana,
Oracle,
Dameng,
// 神通 Oscar:Oracle 兼容方言,且支持 ALTER TABLE DROP/ADD PRIMARY KEY(与 Dameng 一致,
@@ -269,6 +270,14 @@ pub(super) fn capabilities_for(
alter_primary_key: true,
..base
},
+ Some(DatabaseType::SapHana) => TableStructureCapabilities {
+ dialect: StructureDialect::SapHana,
+ add_column: true,
+ drop_column: true,
+ rename_column: true,
+ alter_existing_column: true,
+ ..base
+ },
Some(DatabaseType::Dameng) => TableStructureCapabilities {
dialect: StructureDialect::Dameng,
add_column: true,
@@ -422,6 +431,7 @@ pub(super) fn dialect_label(dialect: StructureDialect) -> String {
#[cfg(feature = "duckdb-sidecar")]
StructureDialect::DuckDb => "duckdb",
StructureDialect::SqlServer => "sqlserver",
+ StructureDialect::SapHana => "saphana",
StructureDialect::Oracle => "oracle",
StructureDialect::Dameng => "dameng",
StructureDialect::Oscar => "oscar",
@@ -445,6 +455,7 @@ pub(super) fn database_type_for_dialect(dialect: StructureDialect) -> Option<Dat
#[cfg(feature = "duckdb-sidecar")]
StructureDialect::DuckDb => Some(DatabaseType::DuckDb),
StructureDialect::SqlServer => Some(DatabaseType::SqlServer),
+ StructureDialect::SapHana => Some(DatabaseType::SapHana),
StructureDialect::Oracle => Some(DatabaseType::Oracle),
StructureDialect::Dameng => Some(DatabaseType::Dameng),
StructureDialect::Oscar => Some(DatabaseType::Oscar),
diff --git a/crates/dbx-sql-schema/src/table_structure_sql/tests.rs b/crates/dbx-sql-schema/src/table_structure_sql/tests.rs
index 90937b5958..565d1eac19 100644
--- a/crates/dbx-sql-schema/src/table_structure_sql/tests.rs
+++ b/crates/dbx-sql-schema/src/table_structure_sql/tests.rs
@@ -83,6 +83,41 @@ fn mysql_table_engine_change_generates_alter_table() {
assert_eq!(result.statements, vec!["ALTER TABLE `remote_orders` ENGINE = FEDERATED;"]);
}
+#[test]
+fn saphana_table_structure_uses_add_drop_and_alter_syntax() {
+ let result = build_table_structure_change_sql(structure_change_options(
+ DatabaseType::SapHana,
+ Some("APP"),
+ "users",
+ vec![column("new_col")],
+ ));
+ assert!(result.warnings.is_empty(), "{:?}", result.warnings);
+ assert_eq!(result.statements, vec!["ALTER TABLE \"APP\".\"users\" ADD (\"new_col\" varchar(255));"]);
+
+ let mut renamed = column("display_name");
+ renamed.data_type = "NVARCHAR(100)".to_string();
+ renamed.original = Some(ColumnInfo {
+ name: "name".to_string(),
+ data_type: "VARCHAR(255)".to_string(),
+ is_nullable: true,
+ ..Default::default()
+ });
+ let result = build_table_structure_change_sql(structure_change_options(
+ DatabaseType::SapHana,
+ Some("APP"),
+ "users",
+ vec![renamed],
+ ));
+ assert!(result.warnings.is_empty(), "{:?}", result.warnings);
+ assert_eq!(
+ result.statements,
+ vec![
+ "RENAME COLUMN \"APP\".\"users\".\"name\" TO \"display_name\";",
+ "ALTER TABLE \"APP\".\"users\" ALTER (\"display_name\" NVARCHAR(100));",
+ ]
+ );
+}
+
#[test]
fn transwarp_table_comments_use_inceptor_syntax() {
let mut options =
diff --git a/crates/dbx-sql-schema/src/table_structure_sql/util.rs b/crates/dbx-sql-schema/src/table_structure_sql/util.rs
index 83c3262203..bf622651f7 100644
--- a/crates/dbx-sql-schema/src/table_structure_sql/util.rs
+++ b/crates/dbx-sql-schema/src/table_structure_sql/util.rs
@@ -12,6 +12,7 @@ fn is_schema_qualifying_dialect(dialect: StructureDialect) -> bool {
| StructureDialect::Dameng
| StructureDialect::Oscar
| StructureDialect::SqlServer
+ | StructureDialect::SapHana
| StructureDialect::H2
| StructureDialect::Informix
| StructureDialect::Sqlite
diff --git a/plugins/connection-types/saphana.yaml b/plugins/connection-types/saphana.yaml
index c2a9259ad4..86e13ff56c 100644
--- a/plugins/connection-types/saphana.yaml
+++ b/plugins/connection-types/saphana.yaml
@@ -25,7 +25,7 @@ capabilities:
schemaSearch: true
diagram: true
tableDataEdit: true
- tableStructureEdit: false
+ tableStructureEdit: true
tableImport: false
dataTransfer: false
sqlFileExecution: true