Skip to content

DesignCraft: An open-source page and layout design editor written by scratch in pure Rust

Integration (#645): French catalogue test: no duplicate or stale keys, fr.rs disjoint from the shared table, placeholders and edge spaces as in English

aiongg2c7e855d7f59
diff --git a/crates/ui-egui/src/i18n.rs b/crates/ui-egui/src/i18n.rs
index 6bace906f..82bb002b3 100644
--- a/crates/ui-egui/src/i18n.rs
+++ b/crates/ui-egui/src/i18n.rs
@@ -3907,6 +3907,9 @@ mod tests {
for (key, expected) in cs::TABLE {
assert_eq!(tr("cs", key), *expected, "cs: {key}");
}
+ for (key, expected) in fr::TABLE {
+ assert_eq!(tr("fr", key), *expected, "fr: {key}");
+ }
let unknown = String::from("A user-defined untranslated label");
for lang in ["cs", "uk", "ru", "ar", "pt-br", "it", "zh", "ja", "de", "fr", "es", "", "unknown"] {
assert!(std::ptr::eq(tr(lang, &unknown), unknown.as_str()));
@@ -3952,6 +3955,35 @@ mod tests {
}
}
+ #[test]
+ fn french_catalog_has_no_duplicate_or_stale_keys_and_keeps_placeholders() {
+ let catalog: HashMap<_, _> = fr::TABLE.iter().copied().collect();
+ assert_eq!(catalog.len(), fr::TABLE.len(), "duplicate French keys");
+ let shared: std::collections::HashSet<_> = TABLE.iter().map(|(key, _)| *key).collect();
+ // `fr::TABLE` is looked up first: a key there would hide the shared table's French column.
+ let both: Vec<_> = catalog.keys().filter(|k| shared.contains(*k)).collect();
+ assert!(both.is_empty(), "French keys also in the shared table: {both:?}");
+ let mut keys = std::collections::HashSet::new();
+ for table in [ar::TABLE, de::TABLE, it::TABLE, ja::TABLE, pt_br::TABLE, uk::TABLE, ru::TABLE, cs::TABLE] {
+ keys.extend(table.iter().map(|(key, _)| *key));
+ }
+ let stale: Vec<_> = catalog.keys().filter(|k| !keys.contains(*k)).collect();
+ assert!(stale.is_empty(), "French entries for unknown keys: {stale:?}");
+ let placeholders = |s: &str| {
+ let mut names = s.split('{').skip(1).filter_map(|part| part.split_once('}').map(|(name, _)| name.to_owned())).collect::<Vec<_>>();
+ names.sort();
+ names
+ };
+ let shared_french = TABLE.iter().filter_map(|(key, row)| row.get(1).map(|text| (*key, *text)));
+ for (key, translation) in fr::TABLE.iter().copied().chain(shared_french) {
+ assert!(!translation.trim().is_empty(), "empty {key}");
+ assert_eq!(key.starts_with(' '), translation.starts_with(' '), "leading space: {key}");
+ assert_eq!(key.ends_with(' '), translation.ends_with(' '), "trailing space: {key}");
+ assert_eq!(placeholders(key), placeholders(translation), "placeholders: {key}");
+ }
+ assert_eq!(tr("fr", "Group"), "Associer");
+ }
+
#[test]
fn ukrainian_catalog_covers_existing_keys_and_preserves_placeholders() {
let catalog: std::collections::HashMap<_, _> = uk::TABLE.iter().copied().collect();