DesignCraft: An open-source page and layout design editor written by scratch in pure Rust
fix(updates): address review feedback
Dylan M. Taylor47b3f8f9b4e3
diff --git a/crates/ui-egui/src/updates_ui.rs b/crates/ui-egui/src/updates_ui.rsindex d0d9807d4..3b08ee5cc 100644--- a/crates/ui-egui/src/updates_ui.rs+++ b/crates/ui-egui/src/updates_ui.rs@@ -15,6 +15,9 @@ pub(crate) struct Runtime {startup_check: bool,#[cfg(not(target_arch = "wasm32"))]check_requested: bool,+ /// The context of the last frame, to wake the UI when a check is queued from a menu callback.+ #[cfg(not(target_arch = "wasm32"))]+ repaint: Option<egui::Context>,pub(crate) manual_window_open: bool,pub(crate) status_message: Option<String>,}@@ -28,6 +31,8 @@ impl Default for Runtime {startup_check: false,#[cfg(not(target_arch = "wasm32"))]check_requested: false,+ #[cfg(not(target_arch = "wasm32"))]+ repaint: None,manual_window_open: false,status_message: None,}@@ -46,6 +51,9 @@ pub(crate) fn check(app: &mut DesignApp) -> Result<Value, String> {#[cfg(not(target_arch = "wasm32"))]{app.updates_rt.check_requested = true;+ if let Some(ctx) = &app.updates_rt.repaint {+ ctx.request_repaint();+ }Ok(Value::Null)}#[cfg(target_arch = "wasm32")]@@ -60,6 +68,7 @@ pub(crate) fn tick(app: &mut DesignApp, ctx: &egui::Context) {#[cfg(not(target_arch = "wasm32"))]{let rt = &mut app.updates_rt;+ rt.repaint = Some(ctx.clone());if std::mem::take(&mut rt.check_requested) {rt.updater.check_now(ctx);} else if rt.startup_check {