Skip to content

DesignCraft: An open-source page and layout design editor written by scratch in pure Rust

CI: run the gate through craft-common-actions' shared gate.yml; FreeBSD nightly and on release (#1645)

aionggae5a6d549cc2
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index d5b820d24..30a02804c 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -1,10 +1,7 @@
-# The CLAUDE.md quality gate (`cargo xtask ci`: fmt, clippy -D warnings, tests, assets, layers,
-# wasm) on every pull request and every push to main. Today only path-filtered workflows run on
-# pull requests, so most PRs land with no test run at all.
-#
-# Ported from wordcraft#800. Linux only; standard GitHub-hosted runner, no secrets.
name: CI
+# Quality gates for every push to main and every pull request (`cargo xtask ci`), through the
+# suite's shared gate workflow in craft-common-actions.
on:
push:
branches: [main]
@@ -14,58 +11,19 @@ on:
permissions:
contents: read
+# A newer push to a PR branch cancels its older run; every push to main runs to the end.
concurrency:
- group: ci-${{ github.ref }}
+ group: ci-${{ github.event_name == 'pull_request' && github.ref || github.run_id }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}
-env:
- # Same craft-fonts commit as release.yml, so the font tests see what a release build embeds.
- CRAFT_FONTS_REF: abb83316d96aa59c1cf64784289e378fe9fa5695
-
jobs:
gate:
- name: cargo xtask ci
- runs-on: ubuntu-24.04
- timeout-minutes: 90
- env:
- CARGO_TERM_COLOR: always
- CARGO_INCREMENTAL: "0"
- RUST_BACKTRACE: "1"
- steps:
- - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
- with:
- persist-credentials: false
-
- - name: Check out craft-fonts
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
- with:
- repository: storytold/craft-fonts
- ref: ${{ env.CRAFT_FONTS_REF }}
- path: craft-fonts
- persist-credentials: false
-
- - name: Install Linux build dependencies
- uses: storytold/craft-common-actions/actions/install-apt-packages@main
- with:
- packages: >-
- pkg-config libxkbcommon-dev libwayland-dev libx11-dev libxcb1-dev libxcursor-dev
- libxrandr-dev libxi-dev libfontconfig1-dev libfreetype-dev mesa-vulkan-drivers
-
- - name: Install Rust (stable + clippy, rustfmt, wasm32)
- run: |
- rustup toolchain install stable --profile minimal --component clippy,rustfmt \
- --target wasm32-unknown-unknown
- rustup default stable
-
- - uses: taiki-e/install-action@f7e5d7c961414b23f5b25b2da9294395d08513ad # v2.87.26
- with:
-
- - uses: Swatinem/rust-cache@6323deb102c322ba6fcbdcafc7e3dddab59af2b6 # v2.9.2
- with:
- save-if: ${{ github.ref == 'refs/heads/main' }}
-
- - name: Quality gate
- env:
- CRAFT_FONTS_DIR: ${{ github.workspace }}/craft-fonts
- run: cargo xtask ci
+ # Tracks @main so suite-wide CI fixes reach every app without a PR in each repository.
+ uses: storytold/craft-common-actions/.github/workflows/gate.yml@main
+ with:
+ # Same craft-fonts commit as release.yml.
+ craft-fonts-ref: abb83316d96aa59c1cf64784289e378fe9fa5695
+ timeout-minutes: 90
+ packages: >-
+ pkg-config libxkbcommon-dev libwayland-dev libx11-dev libxcb1-dev libxcursor-dev
+ libxrandr-dev libxi-dev libfontconfig1-dev libfreetype-dev mesa-vulkan-drivers
diff --git a/.github/workflows/freebsd.yml b/.github/workflows/freebsd.yml
index e60c2bdf3..8e562f8ba 100644
--- a/.github/workflows/freebsd.yml
+++ b/.github/workflows/freebsd.yml
@@ -2,16 +2,17 @@
# (GitHub has no FreeBSD runners). GPU tests skip themselves when the VM has no adapter.
name: FreeBSD
+# The VM build is slow, so it runs nightly on main and on pushes to `release`, not on every pull
+# request: a drifted dependency still shows up within a day, and always before a release ships.
+# PRs that change the FreeBSD workflow itself still run it.
on:
push:
- branches: [main]
+ branches: [release]
pull_request:
paths:
- - Cargo.toml
- - Cargo.lock
- - "**/Cargo.toml"
- - "crates/fonts/**"
- .github/workflows/freebsd.yml
+ schedule:
+ - cron: "27 2 * * *"
workflow_dispatch:
concurrency:
diff --git a/.github/workflows/windows-arm64.yml b/.github/workflows/windows-arm64.yml
index ed7060b99..85856800b 100644
--- a/.github/workflows/windows-arm64.yml
+++ b/.github/workflows/windows-arm64.yml
@@ -4,19 +4,17 @@
# out for now: PdfCraft saw an intermittent access violation in egui UI tests there.)
name: Windows ARM64
+# Nightly on main and on pushes to `release` (dependency and runner-image drift shows up within a
+# day, and always before a release ships), and on PRs that change the Windows packaging itself.
on:
+ schedule:
+ - cron: "3 5 * * *"
push:
- branches: [main]
+ branches: [release]
pull_request:
paths:
- - Cargo.toml
- - Cargo.lock
- - "**/Cargo.toml"
- - "**/build.rs"
- .github/workflows/windows-arm64.yml
- packaging/windows/**
- schedule:
- - cron: "41 4 * * 1" # weekly, so drift in the runner images shows up
workflow_dispatch:
concurrency: