Skip to content

DesignCraft: An open-source page and layout design editor written by scratch in pure Rust

Tables: a click on a border doesn't resize

aionggbddc70ebe84a
diff --git a/crates/tools/src/tests.rs b/crates/tools/src/tests.rs
index 009feb7dc..4b0bb837a 100644
--- a/crates/tools/src/tests.rs
+++ b/crates/tools/src/tests.rs
@@ -733,6 +733,10 @@ fn type_tool_drags_a_table_column_border() {
let mut t = create("type");
let expected = if degrees == 0.0 { Cursor::ResizeH } else { Cursor::ResizeV };
assert_eq!(t.cursor(&cx, on_border, Mods::default()), expected);
+ // A click with a 1 px wobble on the border changes nothing.
+ assert!(t.pointer(&cx, &PointerEvent::new(PointerKind::Down, on_border.x, on_border.y)).is_empty());
+ assert!(t.pointer(&cx, &PointerEvent::new(PointerKind::Drag, on_border.x + 1.0, on_border.y)).is_empty());
+ assert!(t.pointer(&cx, &PointerEvent::new(PointerKind::Up, on_border.x + 1.0, on_border.y)).is_empty());
// A press on the border starts a resize, not a text selection.
assert!(t.pointer(&cx, &PointerEvent::new(PointerKind::Down, on_border.x, on_border.y)).is_empty());
let a = t.pointer(&cx, &PointerEvent::new(PointerKind::Drag, dragged.x, dragged.y));
diff --git a/crates/tools/src/text.rs b/crates/tools/src/text.rs
index 195ee41b3..d1486e47b 100644
--- a/crates/tools/src/text.rs
+++ b/crates/tools/src/text.rs
@@ -159,6 +159,10 @@ impl Tool for TypeTool {
PointerKind::Drag => {
let Some(a) = self.start else { return vec![] };
if let Some(b) = self.border.as_mut() {
+ // A click with a little wobble must not resize.
+ if !b.begun && (ev.pos - a).hypot() < cx.tol(3.0) {
+ return vec![];
+ }
return b.drag(ev.pos, ev.mods.shift);
}
if self.cell_drag.is_some() {