Skip to content

DesignCraft: An open-source page and layout design editor written by scratch in pure Rust

PR-1394: checkboxes report whether they're enabled

moppeeerc0bf260b5731
diff --git a/crates/ui-egui/src/panels/properties.rs b/crates/ui-egui/src/panels/properties.rs
index b15e3471d..f562d4d05 100644
--- a/crates/ui-egui/src/panels/properties.rs
+++ b/crates/ui-egui/src/panels/properties.rs
@@ -3370,6 +3370,10 @@ mod tests {
let graphic = |app: &DesignApp| app.session.active().unwrap().doc.item(designcraft_doc::ids::ItemId(id)).unwrap().graphic().unwrap().clone();
assert_eq!(graphic(&app).auto_fit, designcraft_doc::Fitting::None);
let mut h = panel(app);
+ // A checkbox its section disables says so: Invert, with no text wrap.
+ use egui_kittest::kittest::NodeT;
+ assert!(h.get_by_label("Invert").accesskit_node().is_disabled());
+ assert!(!h.get_by_label("Auto-Fit").accesskit_node().is_disabled());
h.get_by_label("Auto-Fit").click();
h.run_steps(3);
assert_ne!(graphic(h.state()).auto_fit, designcraft_doc::Fitting::None, "Auto-Fit is on");
diff --git a/crates/ui-egui/src/widgets.rs b/crates/ui-egui/src/widgets.rs
index 645c83c1a..7ebd175a6 100644
--- a/crates/ui-egui/src/widgets.rs
+++ b/crates/ui-egui/src/widgets.rs
@@ -569,7 +569,7 @@ pub fn checkbox(ui: &mut Ui, on: &mut bool, label: &str) -> Response {
}
// Named and ticked or not for screen readers (and tests).
let checked = *on;
- resp.widget_info(|| egui::WidgetInfo::selected(egui::WidgetType::Checkbox, true, checked, label));
+ resp.widget_info(|| egui::WidgetInfo::selected(egui::WidgetType::Checkbox, ui.is_enabled(), checked, label));
resp
}