Skip to content

DesignCraft: An open-source page and layout design editor written by scratch in pure Rust

Edit › Clear with points selected deletes the points, not their paths

moppeeerc6821516e558
diff --git a/crates/engine/src/cmd/anchors.rs b/crates/engine/src/cmd/anchors.rs
index 6adc9b5c6..1307ddab1 100644
--- a/crates/engine/src/cmd/anchors.rs
+++ b/crates/engine/src/cmd/anchors.rs
@@ -577,6 +577,10 @@ mod tests {
assert_eq!(r["removed"], json!([l]));
assert!(s.doc().unwrap().doc.item(ItemId(l)).is_none());
assert!(s.execute("path.deletePoints", &json!({"points": []})).is_err());
+ // Edit › Clear with points selected deletes the points, not their paths.
+ s.execute("selection.set", &json!({"anchors": [[a, 0, 0]]})).unwrap();
+ s.execute("edit.clear", &json!({})).unwrap();
+ assert_eq!(s.doc().unwrap().doc.item(ItemId(a)).unwrap().path.subpaths[0].anchors.len(), 3, "one point gone, the frame stays");
}
#[test]
diff --git a/crates/engine/src/cmd/edit.rs b/crates/engine/src/cmd/edit.rs
index 1d2a9d1df..3205dd2ba 100644
--- a/crates/engine/src/cmd/edit.rs
+++ b/crates/engine/src/cmd/edit.rs
@@ -289,7 +289,7 @@ pub fn specs() -> Vec<CommandSpec> {
"Clear",
["Edit"],
Some("Delete"),
- "{ids?} — delete selected items (or the selected text or ruler guides)",
+ "{ids?} — delete selected items (or the selected text, points or ruler guides)",
has_doc,
|s, p| {
if s.doc()?.selection.text.is_some() && p.get("ids").is_none() {
@@ -298,6 +298,10 @@ pub fn specs() -> Vec<CommandSpec> {
if p.get("ids").is_none() && s.doc()?.selection.items.is_empty() && !s.doc()?.selection.guides.is_empty() {
return s.execute("guide.delete", &json!({}));
}
+ // Points selected with Direct Selection: they go, not their paths (as InDesign).
+ if p.get("ids").is_none() && !s.doc()?.selection.anchors.is_empty() {
+ return s.execute("path.deletePoints", &json!({}));
+ }
let ids = super::targets(s, p)?;
// With a placed graphic itself selected (Direct Selection), only the graphic goes: its
// frame stays, empty and selected (as in InDesign). Other items are deleted.