Skip to content

Devika is the first open-source implementation of an Agentic Software Engineer. Initially started as an open-source alternative to Devin.

Python

fields validation

rgsk44c3fb4acfbc
diff --git a/ui/bun.lockb b/ui/bun.lockb
index 84a0c25..9204232 100755
Binary files a/ui/bun.lockb and b/ui/bun.lockb differ
diff --git a/ui/package.json b/ui/package.json
index 9bf7a67..02c17b9 100644
--- a/ui/package.json
+++ b/ui/package.json
@@ -20,6 +20,7 @@
},
"type": "module",
"dependencies": {
+ "clsx": "^2.1.0",
"xterm": "^5.3.0",
"xterm-addon-fit": "^0.8.0"
}
diff --git a/ui/src/routes/settings/Settings/Button.svelte b/ui/src/routes/settings/Settings/Button.svelte
index 44f227e..b0ba418 100644
--- a/ui/src/routes/settings/Settings/Button.svelte
+++ b/ui/src/routes/settings/Settings/Button.svelte
@@ -1,5 +1,7 @@
<script lang="ts">
+ import clsx from "clsx";
export let isActive: boolean = undefined;
+ export let disabled: boolean = undefined;
export let onClick: () => void = undefined;
export let activeText: string = undefined;
export let text: string;
@@ -7,9 +9,12 @@
</script>
<button
- class={`px-4 py-2 rounded w-full mt-2 ${isActive ? "bg-slate-800" : "bg-indigo-700"}`}
+ class={clsx(
+ `px-4 py-2 rounded w-full mt-2 ${isActive ? "bg-slate-800" : "bg-indigo-700"}`,
+ disabled ? "cursor-not-allowed bg-gray-600" : "cursor-pointer"
+ )}
on:click={onClick}
- disabled={isActive}
+ disabled={isActive || disabled}
{type}
>
{@html isActive ? activeText : text}
diff --git a/ui/src/routes/settings/Settings/Input.svelte b/ui/src/routes/settings/Settings/Input.svelte
index 2e35a68..8049d57 100644
--- a/ui/src/routes/settings/Settings/Input.svelte
+++ b/ui/src/routes/settings/Settings/Input.svelte
@@ -51,6 +51,7 @@
}
.error-text {
+ margin-top: 4px;
color: #f55;
}
</style>
diff --git a/ui/src/routes/settings/Settings/Settings.svelte b/ui/src/routes/settings/Settings/Settings.svelte
index d7509c5..08a1c11 100644
--- a/ui/src/routes/settings/Settings/Settings.svelte
+++ b/ui/src/routes/settings/Settings/Settings.svelte
@@ -16,6 +16,21 @@
console.log(postResult);
settingsLoading = false;
}
+ function checkNonEmptyRecursive(obj) {
+ for (const key in obj) {
+ if (obj.hasOwnProperty(key)) {
+ if (typeof obj[key] === "object") {
+ if (!checkNonEmptyRecursive(obj[key])) {
+ return false;
+ }
+ } else if (!obj[key]) {
+ return false;
+ }
+ }
+ }
+ return true;
+ }
+ $: formValid = checkNonEmptyRecursive(result);
</script>
<div class="px-4 py-8 max-w-[600px]">
@@ -31,6 +46,7 @@
label={key}
type="text"
bind:value={result[mainKey][key]}
+ error={!result[mainKey][key] ? "field can't be empty" : ""}
/>
{/each}
</div>
@@ -38,11 +54,17 @@
{/each}
</div>
<div class="h-[20px]"></div>
+ {#if !formValid}
+ <p class="text-[#f55]">All fields must be filled</p>
+ <div class="h-[10px]"></div>
+ {/if}
+
<Button
type="submit"
text="Submit"
isActive={settingsLoading}
activeText="Submitting..."
+ disabled={!formValid}
></Button>
</form>
{/if}