Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

5.0 KB
Raw Blame
import smtplib
from unittest.mock import ANY, MagicMock, patch

import pytest

from libs.smtp import SMTPClient


def _mail() -> dict[str, str]:
    return {"to": "[email protected]", "subject": "Hi", "html": "<b>Hi</b>"}


@patch("libs.smtp.smtplib.SMTP", autospec=True)
def test_smtp_plain_success(mock_smtp_cls: MagicMock) -> None:
    mock_smtp = mock_smtp_cls.return_value
    client = SMTPClient(server="smtp.example.com", port=25, username="", password="", _from="[email protected]")
    client.send(_mail())

    mock_smtp_cls.assert_called_once_with("smtp.example.com", 25, timeout=10, local_hostname=ANY)
    mock_smtp.sendmail.assert_called_once()
    mock_smtp.quit.assert_called_once()


@patch("libs.smtp.smtplib.SMTP", autospec=True)
def test_smtp_tls_opportunistic_success(mock_smtp_cls: MagicMock) -> None:
    mock_smtp = mock_smtp_cls.return_value
    client = SMTPClient(
        server="smtp.example.com",
        port=587,
        username="user",
        password="pass",
        _from="[email protected]",
        use_tls=True,
        opportunistic_tls=True,
    )
    client.send(_mail())

    mock_smtp_cls.assert_called_once_with("smtp.example.com", 587, timeout=10, local_hostname=ANY)
    assert mock_smtp.ehlo.call_count == 2
    mock_smtp.starttls.assert_called_once()
    mock_smtp.login.assert_called_once_with("user", "pass")
    mock_smtp.sendmail.assert_called_once()
    mock_smtp.quit.assert_called_once()


@patch("libs.smtp.smtplib.SMTP_SSL", autospec=True)
def test_smtp_tls_ssl_branch_and_timeout(mock_smtp_ssl_cls: MagicMock) -> None:
    # Cover SMTP_SSL branch and TimeoutError handling
    mock_smtp = MagicMock()
    mock_smtp.sendmail.side_effect = TimeoutError("timeout")
    mock_smtp_ssl_cls.return_value = mock_smtp

    client = SMTPClient(
        server="smtp.example.com",
        port=465,
        username="",
        password="",
        _from="[email protected]",
        use_tls=True,
        opportunistic_tls=False,
    )
    with pytest.raises(TimeoutError):
        client.send(_mail())
    mock_smtp.quit.assert_called_once()


@patch("libs.smtp.smtplib.SMTP", autospec=True)
def test_smtp_generic_exception_propagates(mock_smtp_cls: MagicMock) -> None:
    mock_smtp = MagicMock()
    mock_smtp.sendmail.side_effect = RuntimeError("oops")
    mock_smtp_cls.return_value = mock_smtp

    client = SMTPClient(server="smtp.example.com", port=25, username="", password="", _from="[email protected]")
    with pytest.raises(RuntimeError):
        client.send(_mail())
    mock_smtp.quit.assert_called_once()


@patch("libs.smtp.smtplib.SMTP", autospec=True)
def test_smtp_smtplib_exception_in_login(mock_smtp_cls: MagicMock) -> None:
    # Ensure we hit the specific SMTPException except branch
    import smtplib

    mock_smtp = MagicMock()
    mock_smtp.login.side_effect = smtplib.SMTPException("login-fail")
    mock_smtp_cls.return_value = mock_smtp

    client = SMTPClient(
        server="smtp.example.com",
        port=25,
        username="user",  # non-empty to trigger login
        password="pass",
        _from="[email protected]",
    )
    with pytest.raises(smtplib.SMTPException):
        client.send(_mail())
    mock_smtp.quit.assert_called_once()


@pytest.mark.parametrize("use_tls", [False, True])
@pytest.mark.parametrize(
    "send_error_type",
    [
        None,
        smtplib.SMTPDataError,
        TimeoutError,
        RuntimeError,
    ],
)
@pytest.mark.parametrize("close_fails", [False, True])
def test_smtp_cleanup_preserves_send_result(
    use_tls: bool,
    send_error_type: type[Exception] | None,
    close_fails: bool,
    caplog: pytest.LogCaptureFixture,
) -> None:
    send_error: Exception | None = None
    if send_error_type is smtplib.SMTPDataError:
        send_error = smtplib.SMTPDataError(451, b"temporary send failure")
    elif send_error_type is not None:
        send_error = send_error_type("send failed")

    smtp_class = "libs.smtp.smtplib.SMTP_SSL" if use_tls else "libs.smtp.smtplib.SMTP"
    with patch(smtp_class, autospec=True) as mock_smtp_cls:
        mock_smtp = mock_smtp_cls.return_value
        mock_smtp.sendmail.side_effect = send_error
        mock_smtp.quit.side_effect = smtplib.SMTPServerDisconnected("connection lost during QUIT")
        if close_fails:
            mock_smtp.close.side_effect = OSError("close failed")
        client = SMTPClient(
            server="smtp.example.com",
            port=465 if use_tls else 25,
            username="",
            password="",
            _from="[email protected]",
            use_tls=use_tls,
        )

        if send_error is None:
            assert client.send(_mail()) is None
        else:
            with pytest.raises(type(send_error)) as exc_info:
                client.send(_mail())
            assert exc_info.value is send_error

        mock_smtp.sendmail.assert_called_once()
        mock_smtp.quit.assert_called_once()
        mock_smtp.close.assert_called_once()
        assert "Failed to quit SMTP connection" in caplog.text
        if close_fails:
            assert "Failed to close SMTP connection" in caplog.text