Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

5.9 KB
Raw Blame
import json
from collections.abc import Iterator
from unittest.mock import MagicMock, patch

import pytest
from redis.exceptions import ConnectionError

from services.email_code_login_challenge import (
    EmailCodeLoginChallengeStatus,
    EmailCodeLoginChallengeStore,
    EmailCodeLoginChallengeUnavailableError,
)
from tests.helpers.unit.config_override import apply_config_overrides

TOKEN = "00000000-0000-4000-8000-000000000001"


@pytest.fixture
def challenge_redis() -> Iterator[MagicMock]:
    with patch("services.email_code_login_challenge.redis_client") as mock_redis:
        yield mock_redis


def test_create_stores_only_one_per_email_v2_challenge(
    challenge_redis: MagicMock, monkeypatch: pytest.MonkeyPatch
) -> None:
    apply_config_overrides(
        monkeypatch,
        EMAIL_CODE_LOGIN_MAX_ATTEMPTS=5,
        EMAIL_CODE_LOGIN_TOKEN_EXPIRY_MINUTES=5,
    )

    with patch("services.email_code_login_challenge.uuid.uuid4", return_value=TOKEN):
        token = EmailCodeLoginChallengeStore.create(
            email="[email protected]",
            code="123456",
            account_id="account-id",
        )

    assert token == TOKEN
    challenge_key, ttl, serialized_payload = challenge_redis.setex.call_args.args
    assert challenge_key == EmailCodeLoginChallengeStore._challenge_key("[email protected]")
    assert ttl == 300
    assert json.loads(serialized_payload) == {
        "account_id": "account-id",
        "email": "[email protected]",
        "token_type": "email_code_login",
        "code": "123456",
        "remaining_attempts": 5,
        "challenge_version": 2,
        "state": "active",
        "token": TOKEN,
    }
    assert challenge_key != f"email_code_login:token:{TOKEN}"
    challenge_redis.set.assert_not_called()
    challenge_redis.delete.assert_not_called()


def test_verify_current_challenge_decrements_budget_without_refreshing_ttl(challenge_redis: MagicMock) -> None:
    challenge_redis.eval.return_value = [3, 4]

    result = EmailCodeLoginChallengeStore.verify(
        email="[email protected]",
        code="654321",
        token=TOKEN,
    )

    assert result.status is EmailCodeLoginChallengeStatus.INVALID_CODE
    assert result.remaining_attempts == 4
    eval_args = challenge_redis.eval.call_args.args
    assert eval_args[1] == 1
    assert eval_args[2] == EmailCodeLoginChallengeStore._challenge_key("[email protected]")
    assert eval_args[-5:] == ("email_code_login", TOKEN, "[email protected]", "654321", 2)
    challenge_redis.set.assert_not_called()
    challenge_redis.expire.assert_not_called()


@pytest.mark.parametrize(
    ("lua_response", "expected_status"),
    [
        ([1, -1], EmailCodeLoginChallengeStatus.INVALID_TOKEN),
        ([2, -1], EmailCodeLoginChallengeStatus.EMAIL_MISMATCH),
        ([4, -1], EmailCodeLoginChallengeStatus.VERIFIED),
        ([6, 0], EmailCodeLoginChallengeStatus.EXHAUSTED),
        ([8, -1], EmailCodeLoginChallengeStatus.INVALID_TOKEN),
    ],
)
def test_verify_maps_v2_lua_result(
    challenge_redis: MagicMock,
    lua_response: list[int],
    expected_status: EmailCodeLoginChallengeStatus,
) -> None:
    challenge_redis.eval.return_value = lua_response

    result = EmailCodeLoginChallengeStore.verify(
        email="[email protected]",
        code="123456",
        token=TOKEN,
    )

    assert result.status is expected_status
    challenge_redis.eval.assert_called_once()


def test_terminal_v2_challenge_blocks_pre_rollout_legacy_token_fallback(challenge_redis: MagicMock) -> None:
    legacy_token = "00000000-0000-4000-8000-000000000002"
    challenge_redis.eval.return_value = [8, -1]

    result = EmailCodeLoginChallengeStore.verify(
        email="[email protected]",
        code="111111",
        token=legacy_token,
    )

    assert result.status is EmailCodeLoginChallengeStatus.INVALID_TOKEN
    challenge_redis.eval.assert_called_once()
    assert f"email_code_login:token:{legacy_token}" not in challenge_redis.eval.call_args.args


def test_verify_supports_unversioned_token_created_before_rollout(challenge_redis: MagicMock) -> None:
    challenge_redis.eval.side_effect = [[0, -1], [4, -1]]

    result = EmailCodeLoginChallengeStore.verify(
        email="[email protected]",
        code="123456",
        token=TOKEN,
    )

    assert result.status is EmailCodeLoginChallengeStatus.VERIFIED
    assert challenge_redis.eval.call_count == 2
    legacy_args = challenge_redis.eval.call_args_list[1].args
    assert legacy_args[2] == f"email_code_login:token:{TOKEN}"
    assert legacy_args[-4:] == ("email_code_login", "[email protected]", "123456", 5)


def test_verify_rejects_versioned_payload_in_legacy_fallback(challenge_redis: MagicMock) -> None:
    challenge_redis.eval.side_effect = [[0, -1], [7, -1]]

    result = EmailCodeLoginChallengeStore.verify(
        email="[email protected]",
        code="123456",
        token=TOKEN,
    )

    assert result.status is EmailCodeLoginChallengeStatus.INVALID_TOKEN


def test_create_fails_closed_on_redis_error(challenge_redis: MagicMock) -> None:
    challenge_redis.setex.side_effect = ConnectionError("redis unavailable")

    with pytest.raises(EmailCodeLoginChallengeUnavailableError):
        EmailCodeLoginChallengeStore.create(
            email="[email protected]",
            code="123456",
            account_id=None,
        )


def test_verify_fails_closed_on_redis_error(challenge_redis: MagicMock) -> None:
    challenge_redis.eval.side_effect = ConnectionError("redis unavailable")

    with pytest.raises(EmailCodeLoginChallengeUnavailableError):
        EmailCodeLoginChallengeStore.verify(
            email="[email protected]",
            code="123456",
            token=TOKEN,
        )


def test_verify_fails_closed_on_unexpected_lua_response(challenge_redis: MagicMock) -> None:
    challenge_redis.eval.return_value = None

    with pytest.raises(EmailCodeLoginChallengeUnavailableError):
        EmailCodeLoginChallengeStore.verify(
            email="[email protected]",
            code="123456",
            token=TOKEN,
        )