Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

fix(api): enforce admin and RBAC permissions on data source integrates GET endpoint (#41079) (#41080)

Pranav Agarwal07119e3f009d
diff --git a/api/controllers/console/datasets/data_source.py b/api/controllers/console/datasets/data_source.py
index e0f857c1582..62a7ea84415 100644
--- a/api/controllers/console/datasets/data_source.py
+++ b/api/controllers/console/datasets/data_source.py
@@ -139,6 +139,8 @@ register_response_schema_models(
class DataSourceApi(Resource):
@setup_required
@login_required
+ @is_admin_or_owner_required
+ @rbac_permission_required(RBACResourceScope.WORKSPACE, RBACPermission.CREDENTIAL_MANAGE, resource_required=False)
@account_initialization_required
@console_ns.response(200, "Success", console_ns.models[DataSourceIntegrateListResponse.__name__])
@with_current_tenant_id
diff --git a/api/tests/unit_tests/controllers/console/test_workspace_credential_mutation_permissions.py b/api/tests/unit_tests/controllers/console/test_workspace_credential_mutation_permissions.py
index a46ce6b106d..f103e8a18ec 100644
--- a/api/tests/unit_tests/controllers/console/test_workspace_credential_mutation_permissions.py
+++ b/api/tests/unit_tests/controllers/console/test_workspace_credential_mutation_permissions.py
@@ -16,6 +16,7 @@ from controllers.console.workspace.tool_providers import ToolBuiltinProviderAddA
[
(ToolBuiltinProviderAddApi.post, RBACPermission.CREDENTIAL_CREATE),
(DataSourceApi.patch, RBACPermission.CREDENTIAL_MANAGE),
+ (DataSourceApi.get, RBACPermission.CREDENTIAL_MANAGE),
],
)
def test_workspace_credential_mutations_require_management_permission(