Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.
Python agentagentic-aiagentic-frameworkagentic-workflowaiautomationclaudedeepseekgenaigptllmlow-codemcpnextjsno-codeopenaipythonskillsworkflow
fix(qdrant): scope ID deletion to the dataset (#45586)
Jasper0712c68a842a
diff --git a/api/providers/vdb/vdb-qdrant/src/dify_vdb_qdrant/qdrant_vector.py b/api/providers/vdb/vdb-qdrant/src/dify_vdb_qdrant/qdrant_vector.pyindex 3c2c010d729..4d6a2fcc257 100644--- a/api/providers/vdb/vdb-qdrant/src/dify_vdb_qdrant/qdrant_vector.py+++ b/api/providers/vdb/vdb-qdrant/src/dify_vdb_qdrant/qdrant_vector.py@@ -312,6 +312,12 @@ class QdrantVector(BaseVector):@overridedef delete_by_ids(self, ids: list[str]):+ """Delete document IDs within this dataset's group, preserving all other points.++ Accepts an empty ID list. A successful call removes only matching IDs owned+ by this group. Remote collection-not-found responses are ignored; other+ client errors propagate.+ """from qdrant_client.http import modelsfrom qdrant_client.http.exceptions import UnexpectedResponse@@ -322,6 +328,10 @@ class QdrantVector(BaseVector):key="metadata.doc_id",match=models.MatchAny(any=ids),),+ models.FieldCondition(+ key="group_id",+ match=models.MatchValue(value=self._group_id),+ ),],)self._client.delete(diff --git a/api/providers/vdb/vdb-qdrant/tests/unit_tests/src/dify_vdb_qdrant/test_qdrant_vector.py b/api/providers/vdb/vdb-qdrant/tests/unit_tests/src/dify_vdb_qdrant/test_qdrant_vector.pyindex 2e5342bfc94..3664ce42b65 100644--- a/api/providers/vdb/vdb-qdrant/tests/unit_tests/src/dify_vdb_qdrant/test_qdrant_vector.py+++ b/api/providers/vdb/vdb-qdrant/tests/unit_tests/src/dify_vdb_qdrant/test_qdrant_vector.py@@ -10,6 +10,8 @@ from typing import Protocol, cast, overridefrom unittest.mock import MagicMock, patchimport pytest+from dify_vdb_qdrant import qdrant_vector as native_vector_module+from qdrant_client.http import models as native_qdrant_modelsfrom sqlalchemy import create_engine, selectfrom sqlalchemy.orm import Session@@ -460,3 +462,52 @@ def test_vector_reads_uncommitted_annotation_binding(assert session.scalar(stmt) is Nonefinally:engine.dispose()+++ "ids",+ [+ pytest.param([], id="empty"),+ pytest.param(["attachment-shared", "attachment-tail", "missing-id"], id="shared-collection"),+ ],+)+def test_delete_by_ids_preserves_other_dataset_vectors(tmp_path: Path, ids: list[str]) -> None:+ """A shared collection keeps other datasets' points and unrelated points in this dataset."""+ # Legacy tests reload this module with SDK import overrides. Restore the real SDK+ # before constructing a normal provider backed by its supported local storage mode.+ importlib.reload(native_vector_module)+ vector = native_vector_module.QdrantVector(+ collection_name="shared-attachment-scope",+ group_id="dataset-a",+ config=native_vector_module.QdrantConfig(endpoint=f"path:{tmp_path}"),+ )+ try:+ vector._client.create_collection(+ collection_name="shared-attachment-scope",+ vectors_config=native_qdrant_models.VectorParams(size=2, distance=native_qdrant_models.Distance.COSINE),+ )+ records = [+ (1, "dataset-a", "attachment-shared"),+ (2, "dataset-a", "attachment-tail"),+ (3, "dataset-a", "attachment-unrelated"),+ (4, "dataset-b", "attachment-shared"),+ (5, "dataset-b", "attachment-tail"),+ ]+ vector._client.upsert(+ collection_name="shared-attachment-scope",+ points=[+ native_qdrant_models.PointStruct(+ id=point_id,+ vector=[1.0, 0.0],+ payload={"group_id": group_id, "metadata": {"doc_id": doc_id}},+ )+ for point_id, group_id, doc_id in records+ ],+ )++ vector.delete_by_ids(ids)++ remaining, _ = vector._client.scroll(collection_name="shared-attachment-scope", limit=10)+ assert {point.id for point in remaining} == ({1, 2, 3, 4, 5} if not ids else {3, 4, 5})+ finally:+ vector._client.close()