Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.
Python agentagentic-aiagentic-frameworkagentic-workflowaiautomationclaudedeepseekgenaigptllmlow-codemcpnextjsno-codeopenaipythonskillsworkflow
fix(web): make tool category filters keyboard accessible (#40243)
yyh09d0cca5b997
diff --git a/oxlint-suppressions.json b/oxlint-suppressions.jsonindex b90834169ee..b5ef78304f6 100644--- a/oxlint-suppressions.json+++ b/oxlint-suppressions.json@@ -1818,14 +1818,6 @@"count": 1}},- "web/app/components/base/tab-slider-new/index.tsx": {- "jsx_a11y/click-events-have-key-events": {- "count": 1- },- "jsx_a11y/no-static-element-interactions": {- "count": 1- }- },"web/app/components/base/tab-slider-plain/index.tsx": {"jsx_a11y/click-events-have-key-events": {"count": 1diff --git a/web/app/components/base/tab-slider-new/__tests__/index.spec.tsx b/web/app/components/base/tab-slider-new/__tests__/index.spec.tsxindex 6068e9362b6..db28bfdedee 100644--- a/web/app/components/base/tab-slider-new/__tests__/index.spec.tsx+++ b/web/app/components/base/tab-slider-new/__tests__/index.spec.tsx@@ -3,11 +3,12 @@ import userEvent from '@testing-library/user-event'import TabSliderNew from '../index'describe('TabSliderNew', () => {- it('selects a tab', async () => {+ it('exposes and changes the selected tool category', async () => {const user = userEvent.setup()const onChange = vi.fn()render(<TabSliderNew+ ariaLabel="Tool categories"value="all"options={[{ value: 'all', text: 'All' },@@ -17,7 +18,19 @@ describe('TabSliderNew', () => {/>,)- await user.click(screen.getByText('Active'))+ expect(screen.getByRole('group', { name: 'Tool categories' })).toBeInTheDocument()++ const allButton = screen.getByRole('button', { name: 'All' })+ const activeButton = screen.getByRole('button', { name: 'Active' })++ expect(allButton).toHaveAttribute('aria-pressed', 'true')+ expect(activeButton).toHaveAttribute('aria-pressed', 'false')++ await user.click(allButton)+ expect(onChange).not.toHaveBeenCalled()++ activeButton.focus()+ await user.keyboard('{Enter}')expect(onChange).toHaveBeenCalledWith('active')})diff --git a/web/app/components/base/tab-slider-new/index.stories.tsx b/web/app/components/base/tab-slider-new/index.stories.tsxindex a0e876f987a..11e13cfbea3 100644--- a/web/app/components/base/tab-slider-new/index.stories.tsx+++ b/web/app/components/base/tab-slider-new/index.stories.tsx@@ -22,7 +22,7 @@ const TabSliderNewDemo = ({ initialValue = 'visual' }: { initialValue?: string }return (<div className="flex w-full max-w-sm flex-col gap-4 rounded-2xl border border-divider-subtle bg-components-panel-bg p-6"><div className="text-xs tracking-[0.18em] text-text-tertiary uppercase">Pill tabs</div>- <TabSliderNew value={value} options={OPTIONS} onChange={setValue} />+ <TabSliderNew ariaLabel="Builder mode" value={value} options={OPTIONS} onChange={setValue} /></div>)}diff --git a/web/app/components/base/tab-slider-new/index.tsx b/web/app/components/base/tab-slider-new/index.tsxindex c2edd1a767d..5ef37ac33a4 100644--- a/web/app/components/base/tab-slider-new/index.tsx+++ b/web/app/components/base/tab-slider-new/index.tsx@@ -1,5 +1,6 @@import type { FC } from 'react'import { cn } from '@langgenius/dify-ui/cn'+import { SegmentedControl, SegmentedControlItem } from '@langgenius/dify-ui/segmented-control'type Option = {value: string@@ -7,30 +8,36 @@ type Option = {icon?: React.ReactNode}type TabSliderProps = {+ ariaLabel: stringclassName?: stringvalue: stringonChange: (v: string) => voidoptions: Option[]}-const TabSliderNew: FC<TabSliderProps> = ({ className, value, onChange, options }) => {+const TabSliderNew: FC<TabSliderProps> = ({ ariaLabel, className, value, onChange, options }) => {return (- <div data-testid="tab-slider-new" className={cn(className, 'relative flex')}>+ <SegmentedControl+ aria-label={ariaLabel}+ data-testid="tab-slider-new"+ value={[value]}+ onValueChange={(nextValues) => {+ const nextValue = nextValues[0]+ if (nextValue && nextValue !== value) onChange(nextValue)+ }}+ className={cn(className, 'relative flex gap-0 rounded-none bg-transparent p-0')}+ >{options.map((option) => (- <div+ <SegmentedControlItemkey={option.value}+ value={option.value}data-testid={`tab-item-${option.value}`}- onClick={() => onChange(option.value)}- className={cn(- 'mr-1 flex h-8 cursor-pointer items-center rounded-lg border-[0.5px] border-transparent px-3 py-1.75 text-[13px] leading-4.5 font-medium text-text-tertiary hover:bg-state-base-hover',- value === option.value &&- 'border-components-main-nav-nav-button-border bg-state-base-hover text-components-main-nav-nav-button-text-active shadow-xs',- )}+ className="mr-1 h-8 justify-start gap-0 overflow-visible px-3 py-1.75 text-start text-[13px] leading-4.5 font-medium whitespace-normal text-text-tertiary transition-none hover:bg-state-base-hover hover:text-text-tertiary data-pressed:border-components-main-nav-nav-button-border data-pressed:bg-state-base-hover data-pressed:text-components-main-nav-nav-button-text-active data-pressed:shadow-xs">{option.icon}{option.text}- </div>+ </SegmentedControlItem>))}- </div>+ </SegmentedControl>)}diff --git a/web/app/components/integrations/tool-provider-toolbar.tsx b/web/app/components/integrations/tool-provider-toolbar.tsxindex c72ef4402c0..d29ef57da43 100644--- a/web/app/components/integrations/tool-provider-toolbar.tsx+++ b/web/app/components/integrations/tool-provider-toolbar.tsx@@ -2,6 +2,7 @@import type { ReactNode } from 'react'import { cn } from '@langgenius/dify-ui/cn'+import { useTranslation } from 'react-i18next'import { SearchInput } from '@/app/components/base/search-input'import TabSliderNew from '@/app/components/base/tab-slider-new'import UpdateSettingDialog from '@/app/components/header/account-setting/update-setting-dialog'@@ -42,6 +43,8 @@ export function ToolProviderToolbar({onKeywordsChange: (keywords: string) => voidonTagsChange: (tags: string[]) => void}) {+ const { t } = useTranslation()+return (<divclassName={cn(@@ -52,7 +55,12 @@ export function ToolProviderToolbar({)}>{!isRouteCategory && (- <TabSliderNew value={activeTab} onChange={onCategoryChange} options={options} />+ <TabSliderNew+ ariaLabel={t(($) => $['category.tools'], { ns: 'plugin' })}+ value={activeTab}+ onChange={onCategoryChange}+ options={options}+ />)}<div className="flex min-w-50 flex-1 items-center justify-between gap-2"><div className="flex min-w-0 items-center gap-2">