Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

fix(web): open command menu instantly with a lighter backdrop (#44330)

yyh0d64d3f3c9e8
diff --git a/lint.config.ts b/lint.config.ts
index 23f7fb2628d..2d623989777 100644
--- a/lint.config.ts
+++ b/lint.config.ts
@@ -31,10 +31,19 @@ export const stylingContractRules = {
},
{
pattern: '^(Dialog|AlertDialog)Content$',
- allow: ['w-*', 'min-w-*', 'max-w-*', 'h-*', 'min-h-*', 'max-h-*', 'overflow-hidden'],
+ allow: [
+ 'w-*',
+ 'min-w-*',
+ 'max-w-*',
+ 'h-*',
+ 'min-h-*',
+ 'max-h-*',
+ 'overflow-hidden',
+ 'transition-none',
+ ],
deny: ['max-w-none', 'max-h-none', 'w-screen', 'h-screen'],
message:
- '"{{className}}" is outside the {{component}} styling contract. The surface owns position, chrome and scrolling, and its parts own spacing; callers may only size it within the viewport. Compose DialogPortal, DialogBackdrop and DialogPopup for a custom surface.',
+ '"{{className}}" is outside the {{component}} styling contract. The surface owns position, chrome and scrolling, and its parts own spacing; callers may size it within the viewport or disable transitions. Compose DialogPortal, DialogBackdrop and DialogPopup for a custom surface.',
},
{
pattern: '^DialogPopup$',
diff --git a/packages/dify-ui/docs/overlays.md b/packages/dify-ui/docs/overlays.md
index 48032cb2342..881f82cc017 100644
--- a/packages/dify-ui/docs/overlays.md
+++ b/packages/dify-ui/docs/overlays.md
@@ -66,6 +66,8 @@ clipped, `display: none` or unmounted, and the shared positioner class turns tha
`DialogBody` scrolls between the other two. A wrapper between the surface and its parts, such as
a form, keeps the flex chain with `contents`. `DialogPopup` is the bare dialog element for a
surface that places and dresses itself.
+ `DialogContent` and `AlertDialogContent` allow `transition-none`, including state variants,
+ without requiring custom popup composition.
`DialogHeaderCloseButton` is the optional standard close icon inside `DialogHeader`; the header
reserves inline-end space when it contains the button. Without it, the header keeps its normal
gutters. Use the unstyled `DialogClose` with `render` for footer actions and custom close controls.
diff --git a/web/app/components/goto-anything/index.tsx b/web/app/components/goto-anything/index.tsx
index 043552bc0f0..ca388ed0b73 100644
--- a/web/app/components/goto-anything/index.tsx
+++ b/web/app/components/goto-anything/index.tsx
@@ -430,7 +430,11 @@ export function GotoAnything() {
handle={gotoAnythingDialogHandle}
onOpenChangeComplete={handleDialogOpenChangeComplete}
>
- <DialogContent initialFocus={inputRef} className="w-160">
+ <DialogContent
+ initialFocus={inputRef}
+ className="w-160 data-open:transition-none"
+ backdropProps={{ className: 'bg-background-overlay-alt data-open:transition-none' }}
+ >
<div
aria-hidden
className="pointer-events-none absolute inset-x-0 top-0 h-64 bg-[url('/marketplace/hero-gradient-noise.svg')] bg-cover bg-center opacity-18 dark:opacity-28"
diff --git a/web/plugins/eslint/hint-content.test.ts b/web/plugins/eslint/hint-content.test.ts
index d47df9306ab..e873e98ed1e 100644
--- a/web/plugins/eslint/hint-content.test.ts
+++ b/web/plugins/eslint/hint-content.test.ts
@@ -228,3 +228,25 @@ it('keeps centered dialog layout owned by the surface', () => {
}
}
})
+
+it('allows disabling dialog transitions without allowing surface or animation restyling', () => {
+ const diagnostics = lintFixture(`
+ import { DialogContent as Content } from '@langgenius/dify-ui/dialog'
+ import { AlertDialogContent } from '@langgenius/dify-ui/alert-dialog'
+ const examples = <>
+ <Content className="w-160 data-open:transition-none" />
+ <AlertDialogContent className="transition-none" />
+ <Content className="motion-reduce:transition-none" />
+ <Content className="data-open:scale-95 bg-transparent transition-all" />
+ <AlertDialogContent className="data-open:opacity-0" />
+ </>
+ `)
+ expect(diagnostics).toHaveLength(4)
+ for (const className of [
+ 'data-open:scale-95',
+ 'bg-transparent',
+ 'transition-all',
+ 'data-open:opacity-0',
+ ])
+ expect(diagnostics.some(({ message }) => message.includes(`"${className}"`))).toBe(true)
+})