Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

test(web): exercise real snippet validation and node data owners (#44639)

Stephen Zhou21a2081267a2
diff --git a/web/app/components/snippets/components/hooks/__tests__/use-snippet-publish.spec.ts b/web/app/components/snippets/components/hooks/__tests__/use-snippet-publish.spec.tsx
similarity index 58%
rename from web/app/components/snippets/components/hooks/__tests__/use-snippet-publish.spec.ts
rename to web/app/components/snippets/components/hooks/__tests__/use-snippet-publish.spec.tsx
index b9b0d5317d8..dbe4a6aabea 100644
--- a/web/app/components/snippets/components/hooks/__tests__/use-snippet-publish.spec.ts
+++ b/web/app/components/snippets/components/hooks/__tests__/use-snippet-publish.spec.tsx
@@ -1,16 +1,22 @@
+import type { ReactNode } from 'react'
import { act, waitFor } from '@testing-library/react'
-import { renderWorkflowHook } from '@/app/components/workflow/__tests__/workflow-test-env'
+import { CanvasNodesCatalogProbe } from '@/app/components/workflow/__tests__/canvas-nodes-catalog-probe'
+import { createNode } from '@/app/components/workflow/__tests__/fixtures'
+import { renderWorkflowCanvasHook } from '@/app/components/workflow/__tests__/workflow-test-env'
+import DatasetsDetailProvider from '@/app/components/workflow/datasets-detail-store/provider'
+import { CodeLanguage } from '@/app/components/workflow/nodes/code/types'
+import { BlockEnum, VarType } from '@/app/components/workflow/types'
import { toast } from '@/app/notifications'
import { consoleQuery } from '@/service/console'
-import { createConsoleQueryClient } from '@/test/console/query-data'
+import { legacyWorkflowVersionHistoryKey } from '@/service/console/workflow-version-cache'
+import { seedModelProviderQueries } from '@/test/console/model-provider'
+import { createConsoleQueryWrapper } from '@/test/console/query-data'
+import { seedToolProviders } from '@/test/console/tool-providers'
import { createDeferred } from '@/test/deferred'
import { useSnippetPublish } from '../use-snippet-publish'
const mockMutateAsync = vi.fn()
-const mockResetWorkflowVersionHistory = vi.fn()
-const mockHandleCheckBeforePublish = vi.fn<() => Promise<boolean>>()
-
vi.mock('@/app/notifications', () => ({
toast: {
error: vi.fn(),
@@ -18,16 +24,6 @@ vi.mock('@/app/notifications', () => ({
},
}))
-vi.mock('@/service/use-workflow', () => ({
- useResetWorkflowVersionHistory: () => mockResetWorkflowVersionHistory,
-}))
-
-vi.mock('@/app/components/workflow/hooks/use-checklist', () => ({
- useChecklistBeforePublish: () => ({
- handleCheckBeforePublish: mockHandleCheckBeforePublish,
- }),
-}))
-
vi.mock('@/service/console', async (importOriginal) => {
const actual = await importOriginal<typeof import('@/service/console')>()
const { withConsoleClientResponses } = await import('@/test/console/service-responses')
@@ -40,11 +36,46 @@ vi.mock('@/service/console', async (importOriginal) => {
}
})
-const renderPublish = () => {
- const queryClient = createConsoleQueryClient()
+const historyKey = [...legacyWorkflowVersionHistoryKey, '/snippets/snippet-1/workflows']
+
+const renderPublish = (code = 'def main():\n return {"answer": "hello"}') => {
+ const { queryClient } = createConsoleQueryWrapper()
+ seedModelProviderQueries(queryClient)
+ seedToolProviders(queryClient, {
+ builtInTools: [],
+ customTools: [],
+ workflowTools: [],
+ mcpTools: [],
+ })
+ queryClient.setQueryData(consoleQuery.workspaces.current.agentProviders.get.queryKey(), [])
+ queryClient.setQueryData(consoleQuery.spec.schemaDefinitions.get.queryKey(), [])
+ queryClient.setQueryData(historyKey, { pages: [{ data: [{ id: 'old-version' }] }] })
+ const nodes = [
+ createNode({
+ id: 'code',
+ data: {
+ type: BlockEnum.Code,
+ title: 'Code',
+ code_language: CodeLanguage.python3,
+ code,
+ variables: [],
+ outputs: { answer: { type: VarType.string, children: null } },
+ },
+ }),
+ ]
+ function PublishProviders({ children }: { children: ReactNode }) {
+ return (
+ <DatasetsDetailProvider nodes={nodes}>
+ <CanvasNodesCatalogProbe />
+ {children}
+ </DatasetsDetailProvider>
+ )
+ }
return {
- ...renderWorkflowHook(() => useSnippetPublish({ snippetId: 'snippet-1' }), {
+ ...renderWorkflowCanvasHook(() => useSnippetPublish({ snippetId: 'snippet-1' }), {
queryClient,
+ nodes,
+ wrapper: PublishProviders,
resource: { kind: 'snippet', snippetId: 'snippet-1' },
}),
queryClient,
@@ -53,8 +84,6 @@ const renderPublish = () => {
describe('useSnippetPublish', () => {
beforeEach(() => {
- vi.resetAllMocks()
- mockHandleCheckBeforePublish.mockResolvedValue(true)
mockMutateAsync.mockResolvedValue({ created_at: 1_712_345_678 })
})
@@ -99,37 +128,36 @@ describe('useSnippetPublish', () => {
})
await waitFor(() => expect(result.current.isPublishing).toBe(false))
- expect(mockHandleCheckBeforePublish).toHaveBeenCalledTimes(1)
expect(mockMutateAsync).toHaveBeenCalledWith({
params: { snippet_id: 'snippet-1' },
body: {},
})
expect(queryClient.getQueryData(detailKey)).toMatchObject({ is_published: true })
expect(store.getState().publishedAt).toBe(1_712_345_678_000)
- expect(mockResetWorkflowVersionHistory).toHaveBeenCalledTimes(1)
+ expect(queryClient.getQueryData(historyKey)).toBeUndefined()
expect(toast.success).toHaveBeenCalledWith('snippet.publishSuccess')
})
it('should not publish the snippet when checklist validation fails', async () => {
- mockHandleCheckBeforePublish.mockResolvedValue(false)
-
- const { result, store } = renderPublish()
+ const { result, store, queryClient } = renderPublish('')
await act(async () => {
await result.current.handlePublish()
})
- expect(mockHandleCheckBeforePublish).toHaveBeenCalledTimes(1)
expect(mockMutateAsync).not.toHaveBeenCalled()
+ expect(toast.error).toHaveBeenCalledWith(expect.stringContaining('[Code]'))
expect(store.getState().publishedAt).toBe(0)
- expect(mockResetWorkflowVersionHistory).not.toHaveBeenCalled()
+ expect(queryClient.getQueryData(historyKey)).toEqual({
+ pages: [{ data: [{ id: 'old-version' }] }],
+ })
expect(toast.success).not.toHaveBeenCalled()
})
it('should surface publish errors through toast feedback', async () => {
mockMutateAsync.mockRejectedValue(new Error('publish failed'))
- const { result, store } = renderPublish()
+ const { result, store, queryClient } = renderPublish()
await act(async () => {
await result.current.handlePublish()
@@ -137,7 +165,9 @@ describe('useSnippetPublish', () => {
expect(toast.error).toHaveBeenCalledWith('publish failed')
expect(store.getState().publishedAt).toBe(0)
- expect(mockResetWorkflowVersionHistory).not.toHaveBeenCalled()
+ expect(queryClient.getQueryData(historyKey)).toEqual({
+ pages: [{ data: [{ id: 'old-version' }] }],
+ })
expect(toast.success).not.toHaveBeenCalled()
})
})
diff --git a/web/app/components/workflow/nodes/_base/hooks/__tests__/use-available-var-list.spec.ts b/web/app/components/workflow/nodes/_base/hooks/__tests__/use-available-var-list.spec.ts
index b97a9e00ba5..b9a50b5cf81 100644
--- a/web/app/components/workflow/nodes/_base/hooks/__tests__/use-available-var-list.spec.ts
+++ b/web/app/components/workflow/nodes/_base/hooks/__tests__/use-available-var-list.spec.ts
@@ -1,129 +1,69 @@
-import type { Node, NodeOutPutVar, Var } from '@/app/components/workflow/types'
+import { createEdge, createNode } from '@/app/components/workflow/__tests__/fixtures'
+import { renderWorkflowCanvasHook } from '@/app/components/workflow/__tests__/workflow-test-env'
import { BlockEnum, VarType } from '@/app/components/workflow/types'
-import { renderWorkflowHook as renderHook } from '../../../../__tests__/workflow-test-env'
+import { consoleQuery } from '@/service/console'
+import { createConsoleQueryWrapper } from '@/test/console/query-data'
+import { seedToolProviders } from '@/test/console/tool-providers'
import useAvailableVarList from '../use-available-var-list'
-const mockGetTreeLeafNodes = vi.hoisted(() => vi.fn())
-const mockGetBeforeNodesInSameBranchIncludeParent = vi.hoisted(() => vi.fn())
-const mockGetNodeById = vi.hoisted(() => vi.fn())
-const mockGetNodeAvailableVars = vi.hoisted(() => vi.fn())
-vi.mock('@/app/components/snippets/draft-store', () => ({
- useSnippetDraftStore: (selector: (state: { inputFields: unknown[] }) => unknown) =>
- selector({ inputFields: [] }),
-}))
-
-vi.mock('../../../../hooks/use-workflow', async (importOriginal) => {
- const actual = await importOriginal<typeof import('../../../../hooks/use-workflow')>()
-
- return {
- ...actual,
-
- useWorkflow: () => ({
- getTreeLeafNodes: mockGetTreeLeafNodes,
- getBeforeNodesInSameBranchIncludeParent: mockGetBeforeNodesInSameBranchIncludeParent,
- getNodeById: mockGetNodeById,
- }),
- }
-})
-
-vi.mock('../../../../hooks/use-workflow-variables', async (importOriginal) => {
- const actual = await importOriginal<typeof import('../../../../hooks/use-workflow-variables')>()
-
- return {
- ...actual,
- useWorkflowVariables: () => ({
- getNodeAvailableVars: mockGetNodeAvailableVars,
- }),
- }
-})
-
-vi.mock('../use-node-info', () => ({
- default: () => ({
- parentNode: null,
- }),
-}))
-
-const createNode = (overrides: Partial<Node> = {}): Node =>
- ({
- id: 'node-1',
- type: 'custom',
- position: { x: 0, y: 0 },
- data: {
- type: BlockEnum.LLM,
- title: 'Node',
- desc: '',
- },
- ...overrides,
- }) as Node
-
-const outputVarsWithSystemVars: NodeOutPutVar[] = [
- {
- nodeId: 'vars-node',
- title: 'Vars',
- vars: [
- {
- variable: 'answer',
- type: VarType.string,
- },
- {
- variable: 'sys.files',
- type: VarType.arrayFile,
- },
- ] satisfies Var[],
- },
- {
- nodeId: 'global',
- title: 'SYSTEM',
- vars: [
- {
- variable: 'sys.user_id',
- type: VarType.string,
- },
- ] satisfies Var[],
- },
-]
-
-describe('useAvailableVarList', () => {
- beforeEach(() => {
- vi.clearAllMocks()
- mockGetBeforeNodesInSameBranchIncludeParent.mockReturnValue([createNode({ id: 'before-node' })])
- mockGetTreeLeafNodes.mockReturnValue([createNode({ id: 'leaf-node' })])
- mockGetNodeById.mockReturnValue(createNode({ id: 'node-1' }))
- mockGetNodeAvailableVars.mockReturnValue(outputVarsWithSystemVars)
+function renderVariables(kind: 'snippet' | 'app') {
+ const { queryClient } = createConsoleQueryWrapper()
+ seedToolProviders(queryClient, {
+ builtInTools: [],
+ customTools: [],
+ workflowTools: [],
+ mcpTools: [],
+ })
+ queryClient.setQueryData(consoleQuery.spec.schemaDefinitions.get.queryKey(), [])
+ return renderWorkflowCanvasHook(() => useAvailableVarList('consumer'), {
+ queryClient,
+ resource:
+ kind === 'snippet'
+ ? { kind, snippetId: 'snippet-1' }
+ : { kind, appId: 'app-1', mode: 'advanced-chat' },
+ nodes: [
+ createNode({
+ id: 'source',
+ data: {
+ type: BlockEnum.Code,
+ title: 'Answer',
+ outputs: { answer: { type: VarType.string, children: null } },
+ },
+ }),
+ createNode({ id: 'consumer' }),
+ ],
+ edges: [createEdge({ source: 'source', target: 'consumer' })],
})
+}
- it('filters system variables on snippet canvases', () => {
- const { result } = renderHook(
- () =>
- useAvailableVarList('node-1', {
- filterVar: () => true,
- }),
- { resource: { kind: 'snippet', snippetId: 'snippet-1' } },
- )
+describe('useAvailableVarList', () => {
+ it('keeps upstream outputs while excluding system variables on snippet canvases', () => {
+ const { result } = renderVariables('snippet')
expect(result.current.availableVars).toEqual([
- {
- nodeId: 'vars-node',
- title: 'Vars',
- vars: [
- {
- variable: 'answer',
- type: VarType.string,
- },
- ],
- },
+ expect.objectContaining({
+ nodeId: 'source',
+ vars: [expect.objectContaining({ variable: 'answer', type: VarType.string })],
+ }),
])
})
- it('keeps system variables outside snippet canvases', () => {
- const { result } = renderHook(
- () =>
- useAvailableVarList('node-1', {
- filterVar: () => true,
+ it('keeps upstream outputs and system variables on chatflow canvases', () => {
+ const { result } = renderVariables('app')
+
+ expect(result.current.availableVars).toEqual(
+ expect.arrayContaining([
+ expect.objectContaining({
+ nodeId: 'source',
+ vars: [expect.objectContaining({ variable: 'answer', type: VarType.string })],
}),
- { resource: { kind: 'app', appId: 'app-1', mode: 'advanced-chat' } },
+ expect.objectContaining({
+ nodeId: 'global',
+ vars: expect.arrayContaining([
+ expect.objectContaining({ variable: 'sys.user_id', type: VarType.string }),
+ ]),
+ }),
+ ]),
)
-
- expect(result.current.availableVars).toEqual(outputVarsWithSystemVars)
})
})
diff --git a/web/app/components/workflow/nodes/knowledge-base/__tests__/node.spec.tsx b/web/app/components/workflow/nodes/knowledge-base/__tests__/node.spec.tsx
index 891f7fec366..95d682fdce6 100644
--- a/web/app/components/workflow/nodes/knowledge-base/__tests__/node.spec.tsx
+++ b/web/app/components/workflow/nodes/knowledge-base/__tests__/node.spec.tsx
@@ -1,48 +1,20 @@
import type { KnowledgeBaseNodeType } from '../types'
-import type { ModelItem } from '@/app/components/header/account-setting/model-provider-page/declarations'
import type { CommonNodeType } from '@/app/components/workflow/types'
+import { zModelWithProviderEntityResponse } from '@dify/contracts/api/console/workspaces/zod.gen'
import { screen } from '@testing-library/react'
-import {
- ConfigurationMethodEnum,
- ModelStatusEnum,
- ModelTypeEnum,
-} from '@/app/components/header/account-setting/model-provider-page/declarations'
+import { ModelStatusEnum } from '@/app/components/header/account-setting/model-provider-page/declarations'
import { BlockEnum } from '@/app/components/workflow/types'
-import { renderWithConsoleQuery as render } from '@/test/console/query-data'
+import { consoleQuery } from '@/service/console'
+import {
+ createCatalogModelFixture,
+ createDefaultModelFixture,
+ createModelCatalogFixture,
+ seedModelProviderQueries,
+} from '@/test/console/model-provider'
+import { createConsoleQueryWrapper, renderWithConsoleQuery } from '@/test/console/query-data'
import Node from '../node'
import { ChunkStructureEnum, IndexMethodEnum, RetrievalSearchMethodEnum } from '../types'
-const mockUseEmbeddingModelStatus = vi.hoisted(() => vi.fn())
-
-vi.mock(
- '@/app/components/header/account-setting/model-provider-page/hooks',
- async (importOriginal) => {
- const actual =
- await importOriginal<
- typeof import('@/app/components/header/account-setting/model-provider-page/hooks')
- >()
- return {
- ...actual,
- useLanguage: () => 'en_US',
- }
- },
-)
-
-vi.mock('../hooks/use-embedding-model-status', () => ({
- useEmbeddingModelStatus: mockUseEmbeddingModelStatus,
-}))
-
-const createModelItem = (overrides: Partial<ModelItem> = {}): ModelItem => ({
- model: 'text-embedding-3-large',
- label: { en_US: 'Text Embedding 3 Large', zh_Hans: 'Text Embedding 3 Large' },
- model_type: ModelTypeEnum.textEmbedding,
- fetch_from: ConfigurationMethodEnum.predefinedModel,
- status: ModelStatusEnum.active,
- model_properties: {},
- load_balancing_enabled: false,
- ...overrides,
-})
-
const createNodeData = (
overrides: Partial<CommonNodeType<KnowledgeBaseNodeType>> = {},
): CommonNodeType<KnowledgeBaseNodeType> => ({
@@ -64,63 +36,64 @@ const createNodeData = (
...overrides,
})
-describe('KnowledgeBaseNode', () => {
- beforeEach(() => {
- vi.clearAllMocks()
-
- mockUseEmbeddingModelStatus.mockReturnValue({
- providerMeta: undefined,
- modelProvider: undefined,
- currentModel: createModelItem(),
- status: 'active',
- })
- })
+function renderNode(
+ data = createNodeData(),
+ model = createCatalogModelFixture({
+ model: 'text-embedding-3-large',
+ label: { en_US: 'Text Embedding 3 Large' },
+ model_type: 'text-embedding',
+ }),
+) {
+ const { queryClient } = createConsoleQueryWrapper()
+ seedModelProviderQueries(queryClient, [createModelCatalogFixture({ models: [model] })])
+ queryClient.setQueryData(
+ consoleQuery.workspaces.current.modelProviders.byProvider.models.get.queryKey({
+ input: { params: { provider: 'openai' } },
+ }),
+ {
+ data: [
+ zModelWithProviderEntityResponse.parse({
+ ...model,
+ provider: createDefaultModelFixture({ model_type: 'text-embedding' }).provider,
+ }),
+ ],
+ },
+ )
+ return renderWithConsoleQuery(<Node id="knowledge-base-1" data={data} />, { queryClient })
+}
+describe('KnowledgeBaseNode', () => {
// Embedding model row should mirror the selector status labels.
describe('Embedding Model Status', () => {
- it('should render active embedding model label when the model is available', () => {
- render(<Node id="knowledge-base-1" data={createNodeData()} />)
-
- expect(screen.getByText('Text Embedding 3 Large')).toBeInTheDocument()
- })
-
- it('should render configure required when embedding model status requires configuration', () => {
- mockUseEmbeddingModelStatus.mockReturnValue({
- providerMeta: undefined,
- modelProvider: undefined,
- currentModel: createModelItem({ status: ModelStatusEnum.noConfigure }),
- status: 'configure-required',
- })
-
- render(<Node id="knowledge-base-1" data={createNodeData()} />)
-
- expect(
- screen.getByText('modelProvider.modelProvider.selector.configureRequired'),
- ).toBeInTheDocument()
- })
-
- it('should render disabled when embedding model status is disabled', () => {
- mockUseEmbeddingModelStatus.mockReturnValue({
- providerMeta: undefined,
- modelProvider: undefined,
- currentModel: createModelItem({ status: ModelStatusEnum.disabled }),
- status: 'disabled',
- })
-
- render(<Node id="knowledge-base-1" data={createNodeData()} />)
+ it.each([
+ { status: ModelStatusEnum.active, label: 'Text Embedding 3 Large' },
+ {
+ status: ModelStatusEnum.noConfigure,
+ label: 'modelProvider.modelProvider.selector.configureRequired',
+ },
+ { status: ModelStatusEnum.disabled, label: 'modelProvider.modelProvider.selector.disabled' },
+ ])('renders $status from the selected model in the provider catalog', ({ status, label }) => {
+ renderNode(
+ createNodeData(),
+ createCatalogModelFixture({
+ model: 'text-embedding-3-large',
+ model_type: 'text-embedding',
+ label: { en_US: 'Text Embedding 3 Large' },
+ status,
+ }),
+ )
- expect(screen.getByText('modelProvider.modelProvider.selector.disabled')).toBeInTheDocument()
+ expect(screen.getByText(label)).toBeInTheDocument()
})
it('should render incompatible when embedding model status is incompatible', () => {
- mockUseEmbeddingModelStatus.mockReturnValue({
- providerMeta: undefined,
- modelProvider: undefined,
- currentModel: undefined,
- status: 'incompatible',
- })
-
- render(<Node id="knowledge-base-1" data={createNodeData()} />)
+ renderNode(
+ createNodeData(),
+ createCatalogModelFixture({
+ model: 'another-model',
+ model_type: 'text-embedding',
+ }),
+ )
expect(
screen.getByText('modelProvider.modelProvider.selector.incompatible'),
@@ -128,21 +101,11 @@ describe('KnowledgeBaseNode', () => {
})
it('should render configure model prompt when no embedding model is selected', () => {
- mockUseEmbeddingModelStatus.mockReturnValue({
- providerMeta: undefined,
- modelProvider: undefined,
- currentModel: undefined,
- status: 'empty',
- })
-
- render(
- <Node
- id="knowledge-base-1"
- data={createNodeData({
- embedding_model: undefined,
- embedding_model_provider: undefined,
- })}
- />,
+ renderNode(
+ createNodeData({
+ embedding_model: undefined,
+ embedding_model_provider: undefined,
+ }),
)
expect(screen.getByText('plugin.detailPanel.configureModel')).toBeInTheDocument()
@@ -151,84 +114,49 @@ describe('KnowledgeBaseNode', () => {
describe('Validation warnings', () => {
it('should render a warning banner when chunk structure is missing', () => {
- render(
- <Node
- id="knowledge-base-1"
- data={createNodeData({
- chunk_structure: undefined,
- })}
- />,
+ renderNode(
+ createNodeData({
+ chunk_structure: undefined,
+ }),
)
expect(screen.getByText(/chunkIsRequired/i)).toBeInTheDocument()
})
it('should render a warning value for the chunks input row when no chunk variable is selected', () => {
- render(
- <Node
- id="knowledge-base-1"
- data={createNodeData({
- index_chunk_variable_selector: [],
- })}
- />,
+ renderNode(
+ createNodeData({
+ index_chunk_variable_selector: [],
+ }),
)
expect(screen.getByText(/chunksVariableIsRequired/i)).toBeInTheDocument()
})
it('should render a warning value for retrieval settings when reranking is incomplete', async () => {
- render(
- <Node
- id="knowledge-base-1"
- data={createNodeData({
- retrieval_model: {
- top_k: 3,
- score_threshold_enabled: false,
- score_threshold: 0.5,
- search_method: RetrievalSearchMethodEnum.semantic,
- reranking_enable: true,
- },
- })}
- />,
+ renderNode(
+ createNodeData({
+ retrieval_model: {
+ top_k: 3,
+ score_threshold_enabled: false,
+ score_threshold: 0.5,
+ search_method: RetrievalSearchMethodEnum.semantic,
+ reranking_enable: true,
+ },
+ }),
)
expect(await screen.findByText(/rerankingModelIsRequired/i)).toBeInTheDocument()
})
it('should hide the embedding model row when the index method is not qualified', () => {
- render(
- <Node
- id="knowledge-base-1"
- data={createNodeData({
- indexing_technique: IndexMethodEnum.ECONOMICAL,
- })}
- />,
+ renderNode(
+ createNodeData({
+ indexing_technique: IndexMethodEnum.ECONOMICAL,
+ }),
)
expect(screen.queryByText('Text Embedding 3 Large')).not.toBeInTheDocument()
})
})
})
-
-vi.mock('@/service/console', async (importOriginal) => {
- const actual = await importOriginal<typeof import('@/service/console')>()
- const { withConsoleResponses } = await import('@/test/console/service-responses')
- return {
- ...actual,
- consoleQuery: withConsoleResponses(actual.consoleQuery, {
- 'workspaces.current.models.modelTypes.byModelType.get': async ({
- params,
- }: {
- params: { model_type: string }
- }) => ({
- data:
- params.model_type === ModelTypeEnum.textEmbedding
- ? [{ provider: 'openai', models: [createModelItem()] }]
- : [],
- }),
- 'workspaces.current.modelProviders.byProvider.models.get': async () => ({
- data: [createModelItem()],
- }),
- }),
- }
-})
diff --git a/web/app/components/workflow/nodes/tool/__tests__/node.spec.tsx b/web/app/components/workflow/nodes/tool/__tests__/node.spec.tsx
index d55a5177024..53a98d87ad8 100644
--- a/web/app/components/workflow/nodes/tool/__tests__/node.spec.tsx
+++ b/web/app/components/workflow/nodes/tool/__tests__/node.spec.tsx
@@ -1,21 +1,13 @@
import type { ToolNodeType } from '../types'
-import { render, screen } from '@testing-library/react'
+import { screen } from '@testing-library/react'
import { CollectionType } from '@/app/components/tools/types'
+import { renderWorkflowComponent } from '@/app/components/workflow/__tests__/workflow-test-env'
import { BlockEnum } from '@/app/components/workflow/types'
+import { createConsoleQueryWrapper } from '@/test/console/query-data'
+import { createToolProviderFixture } from '@/test/console/tool-provider-fixture'
+import { seedToolProviders } from '@/test/console/tool-providers'
import Node from '../node'
-const mockUseNodePluginInstallation = vi.hoisted(() => vi.fn())
-const mockUseCurrentToolCollection = vi.hoisted(() => vi.fn())
-
-vi.mock('../../../hooks/use-node-plugin-installation', () => ({
- useNodePluginInstallation: mockUseNodePluginInstallation,
-}))
-
-vi.mock('../hooks/use-current-tool-collection', () => ({
- __esModule: true,
- default: mockUseCurrentToolCollection,
-}))
-
const createNodeData = (overrides: Partial<ToolNodeType> = {}): ToolNodeType => ({
title: 'Google Search',
desc: '',
@@ -30,61 +22,45 @@ const createNodeData = (overrides: Partial<ToolNodeType> = {}): ToolNodeType =>
...overrides,
})
-describe('ToolNode', () => {
- beforeEach(() => {
- vi.clearAllMocks()
- mockUseNodePluginInstallation.mockReturnValue({
- isChecking: false,
- isMissing: false,
- uniqueIdentifier: undefined,
- canInstall: false,
- onInstallSuccess: vi.fn(),
- shouldDim: false,
- })
- mockUseCurrentToolCollection.mockReturnValue({
- currentTools: [],
- currCollection: undefined,
- })
+function renderTool(data: ToolNodeType, authorized = true) {
+ const { queryClient } = createConsoleQueryWrapper()
+ seedToolProviders(queryClient, {
+ builtInTools: [
+ createToolProviderFixture({
+ id: 'google_search',
+ name: 'google_search',
+ allow_delete: true,
+ is_team_authorization: authorized,
+ }),
+ ],
+ customTools: [],
+ workflowTools: [],
+ mcpTools: [],
})
+ return renderWorkflowComponent(<Node id="tool-node-1" data={data} />, { queryClient })
+}
- describe('Authorization Warning', () => {
- it('should keep configuration rows visible when the authorization warning is shown', () => {
- mockUseCurrentToolCollection.mockReturnValue({
- currentTools: [],
- currCollection: {
- allow_delete: true,
- is_team_authorization: false,
- },
- })
-
- render(
- <Node
- id="tool-node-1"
- data={createNodeData({
- tool_configurations: {
- region: { value: 'us' },
- },
- })}
- />,
- )
+describe('ToolNode', () => {
+ it('keeps configuration rows visible for a provider that requires authorization', () => {
+ renderTool(
+ createNodeData({
+ tool_configurations: { region: { value: 'us' } },
+ }),
+ false,
+ )
- expect(screen.getByText('region')).toBeInTheDocument()
- expect(screen.getByText('workflow.nodes.tool.authorizationRequired')).toBeInTheDocument()
- })
+ expect(screen.getByText('region')).toBeInTheDocument()
+ expect(screen.getByText('us')).toBeInTheDocument()
+ expect(screen.getByText('workflow.nodes.tool.authorizationRequired')).toBeInTheDocument()
})
- it('should render multi-select configuration values', () => {
- render(
- <Node
- id="tool-node-1"
- data={createNodeData({
- tool_configurations: {
- formats: { type: 'constant', value: ['png', 'svg'] },
- },
- })}
- />,
+ it('renders multi-select configuration values', () => {
+ renderTool(
+ createNodeData({
+ tool_configurations: { formats: { type: 'constant', value: ['png', 'svg'] } },
+ }),
)
- expect(screen.getByTitle('png, svg')).toHaveTextContent('png, svg')
+ expect(screen.getByText('png, svg')).toBeInTheDocument()
})
})