Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

test(web): replace node action mocks with real canvas behavior (#44495)

Stephen Zhou2695749e46dc
diff --git a/web/app/components/workflow/__tests__/workflow-browser-test-env.tsx b/web/app/components/workflow/__tests__/workflow-browser-test-env.tsx
new file mode 100644
index 00000000000..dad3f864e3b
--- /dev/null
+++ b/web/app/components/workflow/__tests__/workflow-browser-test-env.tsx
@@ -0,0 +1,66 @@
+import type { ReactElement } from 'react'
+import { ReactFlowProvider } from 'reactflow'
+import { afterEach, beforeEach, expect, vi } from 'vite-plus/test'
+import { render } from 'vitest-browser-react'
+import { consoleQuery } from '@/service/console'
+import { seedModelProviderQueries } from '@/test/console/model-provider'
+import { createConsoleQueryWrapper } from '@/test/console/query-data'
+import { seedToolProviders } from '@/test/console/tool-providers'
+import { createAppDetailFixture } from '@/test/fixtures/app'
+import { WorkflowContext } from '../context'
+import { EditorResourceScope } from '../editor-resource/provider'
+import { HooksStoreContext } from '../hooks-store/provider'
+import { createHooksStore, fullWorkflowAccessControl } from '../hooks-store/store'
+import { createWorkflowStore } from '../store/workflow'
+
+const unexpectedFetch = vi.fn<typeof fetch>(() => new Promise(() => {}))
+beforeEach(() => vi.stubGlobal('fetch', unexpectedFetch))
+afterEach(() => {
+ vi.unstubAllGlobals()
+ expect(unexpectedFetch).not.toHaveBeenCalled()
+})
+
+// Browser fixtures keep their own canvas geometry and tab order, sharing real editor providers.
+export async function renderWorkflowBrowserComponent(ui: ReactElement) {
+ const { queryClient, wrapper: Wrapper } = createConsoleQueryWrapper({ appDslVersion: '0.6.0' })
+ seedModelProviderQueries(queryClient)
+ queryClient.setQueryData(consoleQuery.workspaces.current.triggers.get.queryKey({ input: {} }), [])
+ queryClient.setQueryData(consoleQuery.rag.pipelines.recommendedPlugins.get.queryKey(), {
+ installed_recommended_plugins: [],
+ uninstalled_recommended_plugins: [],
+ })
+ queryClient.setQueryData(consoleQuery.spec.schemaDefinitions.get.queryKey(), [])
+ seedToolProviders(queryClient, {
+ builtInTools: [],
+ customTools: [],
+ workflowTools: [],
+ mcpTools: [],
+ })
+ const input = { input: { params: { app_id: 'app-1' } } }
+ queryClient.setQueryData(
+ consoleQuery.apps.byAppId.get.queryKey(input),
+ createAppDetailFixture({ id: 'app-1', mode: 'workflow' }),
+ )
+ for (const endpoint of [
+ consoleQuery.apps.byAppId.workflows.draft.systemVariables.get,
+ consoleQuery.apps.byAppId.workflows.draft.conversationVariables.get,
+ ])
+ queryClient.setQueryData(endpoint.queryKey(input), { items: [] })
+ const store = createWorkflowStore({})
+ const hooksStore = createHooksStore({
+ accessControl: fullWorkflowAccessControl,
+ doSyncWorkflowDraft: async () => undefined,
+ })
+ const screen = await render(
+ <Wrapper>
+ <EditorResourceScope resource={{ kind: 'app', appId: 'app-1', mode: 'workflow' }}>
+ <WorkflowContext value={store}>
+ <HooksStoreContext value={hooksStore}>
+ <ReactFlowProvider>{ui}</ReactFlowProvider>
+ </HooksStoreContext>
+ </WorkflowContext>
+ </EditorResourceScope>
+ </Wrapper>,
+ )
+ return { ...screen, store }
+}
diff --git a/web/app/components/workflow/nodes/_base/components/__tests__/node-resizer.browser.spec.tsx b/web/app/components/workflow/nodes/_base/components/__tests__/node-resizer.browser.spec.tsx
index 30daf750e90..3576c737351 100644
--- a/web/app/components/workflow/nodes/_base/components/__tests__/node-resizer.browser.spec.tsx
+++ b/web/app/components/workflow/nodes/_base/components/__tests__/node-resizer.browser.spec.tsx
@@ -1,19 +1,14 @@
import type { ReactNode } from 'react'
-import type { ResizeParamsWithDirection } from 'reactflow'
-import ReactFlow from 'reactflow'
+import type { NoteNodeType } from '@/app/components/workflow/note-node/types'
+import ReactFlow, { useNodes } from 'reactflow'
import { page, userEvent } from 'vite-plus/test/browser'
-import { render } from 'vitest-browser-react'
-import { WorkflowContext } from '@/app/components/workflow/context'
+import { createNode } from '@/app/components/workflow/__tests__/fixtures'
+import { renderWorkflowBrowserComponent as render } from '@/app/components/workflow/__tests__/workflow-browser-test-env'
import NoteNode from '@/app/components/workflow/note-node'
import { NoteTheme } from '@/app/components/workflow/note-node/types'
-import { createWorkflowStore } from '@/app/components/workflow/store/workflow'
import { BlockEnum } from '@/app/components/workflow/types'
import 'reactflow/dist/style.css'
-vi.mock('../../../../hooks/use-workflow', () => ({
- useNodesReadOnly: () => ({ nodesReadOnly: false }),
-}))
-
// Editing and persistence are independent of the Note's rendered resize affordance.
vi.mock('../../../../note-node/note-editor', () => ({
NoteEditorContextProvider: ({ children }: { children: ReactNode }) => children,
@@ -21,58 +16,28 @@ vi.mock('../../../../note-node/note-editor', () => ({
NoteEditorToolbar: () => null,
}))
-vi.mock('../../../../note-node/hooks', () => ({
- useNote: () => ({
- handleThemeChange: vi.fn(),
- handleEditorChange: vi.fn(),
- handleShowAuthorChange: vi.fn(),
- }),
-}))
-
-vi.mock('../../../../hooks/use-node-data-update', () => ({
- useNodeDataUpdate: () => ({ handleNodeDataUpdateWithSyncDraft: vi.fn() }),
-}))
-
-vi.mock('../../../../hooks/use-nodes-interactions', async () => {
- const { useStoreApi } = await import('reactflow')
- return {
- useNodesInteractions: () => {
- const store = useStoreApi()
- return {
- handleNodeResize: (id: string, { width, height }: ResizeParamsWithDirection) => {
- const { getNodes, setNodes } = store.getState()
- setNodes(
- getNodes().map((node) =>
- node.id === id
- ? {
- ...node,
- width,
- height,
- data: { ...node.data, width, height },
- }
- : node,
- ),
- )
- },
- }
- },
- }
-})
-
const noteNodeTypes = { note: NoteNode }
+function SavedNoteSize() {
+ const note = useNodes<NoteNodeType>().find((node) => node.id === 'note')
+ return (
+ <output aria-label="Saved note size">
+ {note?.data.width} × {note?.data.height}
+ </output>
+ )
+}
+
it('hides an unselected Note resize handle from pointer targeting until hover or keyboard focus, then resizes by dragging', async () => {
// Browser-owned: transparent descendants still participate in CSS hit testing,
// native Tab focus must reveal the real Note's resize affordance, and D3 drag needs real pointer events.
await page.viewport(1000, 800)
- const store = createWorkflowStore({})
const screen = await render(
- <WorkflowContext value={store}>
+ <>
<button type="button">Before canvas</button>
<div role="group" aria-label="Canvas" style={{ width: 800, height: 600 }}>
<ReactFlow
defaultNodes={[
- {
+ createNode({
id: 'note',
type: 'note',
ariaLabel: 'Note',
@@ -89,12 +54,13 @@ it('hides an unselected Note resize handle from pointer targeting until hover or
width: 300,
height: 200,
},
- },
+ }),
]}
nodeTypes={noteNodeTypes}
/>
</div>
- </WorkflowContext>,
+ <SavedNoteSize />
+ </>,
)
const node = screen.getByRole('button', { name: 'Note', exact: true })
const control = screen.getByRole('button', { name: 'common.resize.node' })
@@ -122,4 +88,8 @@ it('hides an unselected Note resize handle from pointer targeting until hover or
})
await expect.poll(() => node.element().getBoundingClientRect().width).toBeGreaterThan(300)
expect(node.element().getBoundingClientRect().height).toBeGreaterThan(200)
+ const size = node.element().getBoundingClientRect()
+ await expect
+ .element(screen.getByRole('status', { name: 'Saved note size' }))
+ .toHaveTextContent(`${size.width} × ${size.height}`)
})
diff --git a/web/app/components/workflow/nodes/_base/components/error-handle/__tests__/index.spec.tsx b/web/app/components/workflow/nodes/_base/components/error-handle/__tests__/index.spec.tsx
index 3ca7239f9cd..cf29d48422b 100644
--- a/web/app/components/workflow/nodes/_base/components/error-handle/__tests__/index.spec.tsx
+++ b/web/app/components/workflow/nodes/_base/components/error-handle/__tests__/index.spec.tsx
@@ -3,8 +3,8 @@ import type { NodeProps } from 'reactflow'
import type { CommonNodeType } from '@/app/components/workflow/types'
import { screen, waitFor } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
-import { ReactFlowProvider } from 'reactflow'
-import { createNode } from '@/app/components/workflow/__tests__/fixtures'
+import { ReactFlowProvider, useEdges, useNodes } from 'reactflow'
+import { createEdge, createNode } from '@/app/components/workflow/__tests__/fixtures'
import {
renderWorkflowComponent,
renderWorkflowFlowComponent,
@@ -18,11 +18,6 @@ import ErrorHandleTypeSelector from '../error-handle-type-selector'
import FailBranchCard from '../fail-branch-card'
import { ErrorHandleTypeEnum } from '../types'
-const { updateNode, deleteBranch } = vi.hoisted(() => ({
- updateNode: vi.fn(),
- deleteBranch: vi.fn(),
-}))
-
const render = (ui: ReactElement) => {
const result = renderWorkflowComponent(<ReactFlowProvider>{ui}</ReactFlowProvider>)
return {
@@ -32,13 +27,6 @@ const render = (ui: ReactElement) => {
}
}
-vi.mock('@/app/components/workflow/hooks/use-node-data-update', () => ({
- useNodeDataUpdate: () => ({ handleNodeDataUpdateWithSyncDraft: updateNode }),
-}))
-vi.mock('@/app/components/workflow/hooks/use-edges-interactions', () => ({
- useEdgesInteractions: () => ({ handleEdgeDeleteByDeleteBranch: deleteBranch }),
-}))
-
// Port connections and the block picker have their own canvas integration tests.
vi.mock('../../node-handle', () => ({ NodeSourceHandle: () => null }))
@@ -72,6 +60,42 @@ const renderErrorHandleNode = (data: CommonNodeType) =>
},
})
+function ErrorPanel() {
+ const nodes = useNodes<CommonNodeType>()
+ const edges = useEdges()
+ const node = nodes.find((node) => node.id === 'node-1')
+ if (!node) return null
+ return (
+ <>
+ <ErrorHandleOnPanel id={node.id} data={node.data} />
+ <output aria-label="Saved defaults">{JSON.stringify(node.data.default_value ?? null)}</output>
+ <output aria-label="Saved error strategy">{node.data.error_strategy ?? 'stop'}</output>
+ <output aria-label="Canvas edges">{edges.map((edge) => edge.id).join(',')}</output>
+ </>
+ )
+}
+
+function renderPanel(data: CommonNodeType) {
+ return renderWorkflowFlowComponent(<ErrorPanel />, {
+ nodes: [
+ createNode({ id: 'node-1', data }),
+ createNode({ id: 'target' }),
+ createNode({ id: 'other' }),
+ ],
+ edges: [
+ createEdge({
+ id: 'failure',
+ source: 'node-1',
+ target: 'target',
+ sourceHandle: ErrorHandleTypeEnum.failBranch,
+ }),
+ createEdge({ id: 'success', source: 'node-1', target: 'other', sourceHandle: 'source' }),
+ createEdge({ id: 'unrelated', source: 'other', target: 'target' }),
+ ],
+ hooksStoreProps: { doSyncWorkflowDraft: async () => undefined },
+ })
+}
+
describe('error-handle path', () => {
beforeAll(() => {
class MockDOMMatrixReadOnly {
@@ -91,10 +115,6 @@ describe('error-handle path', () => {
})
})
- beforeEach(() => {
- vi.clearAllMocks()
- })
-
afterAll(() => {
Object.defineProperty(window, 'DOMMatrixReadOnly', {
configurable: true,
@@ -209,12 +229,7 @@ describe('error-handle path', () => {
// The container components should show the correct branch card or default-value editor and propagate actions.
describe('Containers', () => {
it('should render the fail-branch panel body when the strategy is active', () => {
- render(
- <ErrorHandleOnPanel
- id="node-1"
- data={baseData({ error_strategy: ErrorHandleTypeEnum.failBranch })}
- />,
- )
+ renderPanel(baseData({ error_strategy: ErrorHandleTypeEnum.failBranch }))
expect(screen.getByText('workflow.nodes.common.errorHandle.title')).toBeInTheDocument()
expect(
@@ -231,33 +246,26 @@ describe('error-handle path', () => {
{ key: 'count', type: VarType.number, value: 7 },
],
})
- render(<ErrorHandleOnPanel id="node-1" data={data} />)
+ renderPanel(data)
const answer = screen.getByRole<HTMLInputElement>('textbox', { name: 'answer' })
await user.click(answer)
answer.select()
await user.paste('next')
- expect(updateNode).toHaveBeenLastCalledWith({
- id: 'node-1',
- data: {
- default_value: [
- { key: 'answer', type: VarType.string, value: 'next' },
- { key: 'count', type: VarType.number, value: 7 },
- ],
- },
- })
+ expect(
+ JSON.parse(screen.getByRole('status', { name: 'Saved defaults' }).textContent!),
+ ).toEqual([
+ { key: 'answer', type: VarType.string, value: 'next' },
+ { key: 'count', type: VarType.number, value: 7 },
+ ])
+ expect(answer).toHaveValue('next')
expect(data.default_value?.[0]?.value).toBe('draft')
})
it('collapses and reopens the configured failure strategy', async () => {
const user = userEvent.setup()
- render(
- <ErrorHandleOnPanel
- id="node-1"
- data={baseData({ error_strategy: ErrorHandleTypeEnum.failBranch })}
- />,
- )
+ renderPanel(baseData({ error_strategy: ErrorHandleTypeEnum.failBranch }))
const title = 'workflow.nodes.common.errorHandle.title'
const toggle = screen.getByRole('button', { name: title, expanded: true })
await user.click(toggle)
@@ -269,16 +277,21 @@ describe('error-handle path', () => {
expect(
screen.getByText('workflow.nodes.common.errorHandle.failBranch.customize'),
).toBeInTheDocument()
- expect(updateNode).not.toHaveBeenCalled()
+ expect(screen.getByRole('status', { name: 'Saved error strategy' })).toHaveTextContent(
+ ErrorHandleTypeEnum.failBranch,
+ )
+ expect(screen.getByRole('status', { name: 'Canvas edges' })).toHaveTextContent(
+ 'failure,success,unrelated',
+ )
})
it('removes the failure route and defaults when stop-on-error is selected', async () => {
const user = userEvent.setup()
- render(
- <ErrorHandleOnPanel
- id="node-1"
- data={baseData({ error_strategy: ErrorHandleTypeEnum.failBranch })}
- />,
+ renderPanel(
+ baseData({
+ error_strategy: ErrorHandleTypeEnum.failBranch,
+ default_value: [{ key: 'answer', type: VarType.string, value: 'old' }],
+ }),
)
await user.click(
screen.getByRole('button', { name: 'workflow.nodes.common.errorHandle.failBranch.title' }),
@@ -287,11 +300,11 @@ describe('error-handle path', () => {
screen.getByRole('menuitemradio', { name: /workflow.nodes.common.errorHandle.none.title/ }),
)
- expect(updateNode).toHaveBeenCalledWith({
- id: 'node-1',
- data: { error_strategy: undefined, default_value: undefined },
- })
- expect(deleteBranch).toHaveBeenCalledWith('node-1', ErrorHandleTypeEnum.failBranch)
+ expect(screen.getByRole('status', { name: 'Saved error strategy' }).textContent).toBe('stop')
+ expect(screen.getByRole('status', { name: 'Saved defaults' }).textContent).toBe('null')
+ expect(screen.getByRole('status', { name: 'Canvas edges' }).textContent).toBe(
+ 'success,unrelated',
+ )
expect(
screen.queryByText('workflow.nodes.common.errorHandle.failBranch.customize'),
).not.toBeInTheDocument()
diff --git a/web/app/components/workflow/nodes/_base/components/next-step/__tests__/item.browser.spec.tsx b/web/app/components/workflow/nodes/_base/components/next-step/__tests__/item.browser.spec.tsx
index 22466e4a29d..3d27667ea04 100644
--- a/web/app/components/workflow/nodes/_base/components/next-step/__tests__/item.browser.spec.tsx
+++ b/web/app/components/workflow/nodes/_base/components/next-step/__tests__/item.browser.spec.tsx
@@ -1,20 +1,22 @@
+import type { CommonNodeType } from '@/app/components/workflow/types'
+import ReactFlow, { useNodes } from 'reactflow'
import { page, userEvent } from 'vite-plus/test/browser'
-import { render } from 'vitest-browser-react'
+import { createNode } from '@/app/components/workflow/__tests__/fixtures'
+import { renderWorkflowBrowserComponent as render } from '@/app/components/workflow/__tests__/workflow-browser-test-env'
import { BlockEnum } from '@/app/components/workflow/types'
import Item from '../item'
-const { handleNodeSelect } = vi.hoisted(() => ({ handleNodeSelect: vi.fn() }))
-
-vi.mock('../../../../../hooks/use-nodes-interactions', () => ({
- useNodesInteractions: () => ({ handleNodeSelect }),
-}))
-vi.mock('../../../../../hooks/use-tool-icon', () => ({ useToolIcon: () => '' }))
-vi.mock('../../../../../hooks/use-workflow', () => ({
- useNodesReadOnly: () => ({ nodesReadOnly: false }),
-}))
-vi.mock('../../../../../hooks/use-available-blocks', () => ({
- useAvailableBlocks: () => ({ availablePrevBlocks: [], availableNextBlocks: [] }),
-}))
+function SelectedNodes() {
+ const nodes = useNodes<CommonNodeType>()
+ return (
+ <output aria-label="Selected nodes">
+ {nodes
+ .filter((node) => node.data.selected)
+ .map((node) => node.id)
+ .join(',')}
+ </output>
+ )
+}
// Real CSS and sequential focus catch controls skipped by Tab or hidden when menu focus returns.
it('reveals next-step actions to keyboard users and keeps restored focus visible', async () => {
@@ -28,6 +30,19 @@ it('reveals next-step actions to keyboard users and keeps restored focus visible
data={{ type: BlockEnum.Code, title: 'Transform', desc: '' }}
/>
</div>
+ <div style={{ width: 800, height: 400 }}>
+ <ReactFlow
+ defaultNodes={[
+ createNode({ id: 'previous-node', selected: true, data: { selected: true } }),
+ createNode({
+ id: 'next-node',
+ position: { x: 400, y: 0 },
+ data: { title: 'Transform' },
+ }),
+ ]}
+ />
+ </div>
+ <SelectedNodes />
</>,
)
await page.getByRole('button', { name: 'Before next step' }).click()
@@ -36,7 +51,13 @@ it('reveals next-step actions to keyboard users and keeps restored focus visible
await expect.element(jump).toHaveFocus()
expect(jump.element().checkVisibility({ opacityProperty: true })).toBe(true)
await userEvent.keyboard('{Enter}')
- expect(handleNodeSelect).toHaveBeenCalledWith('next-node')
+ await expect
+ .element(page.getByRole('status', { name: 'Selected nodes' }))
+ .toHaveTextContent('next-node')
+
+ expect(page.getByRole('status', { name: 'Selected nodes' }).element().textContent).toBe(
+ 'next-node',
+ )
await userEvent.keyboard('{Tab}')
const more = page.getByRole('button', { name: 'workflow.common.moreActions' })
diff --git a/web/app/components/workflow/nodes/iteration/__tests__/integration.spec.tsx b/web/app/components/workflow/nodes/iteration/__tests__/integration.spec.tsx
index 2b641f1e9f8..ec63d8e7d9c 100644
--- a/web/app/components/workflow/nodes/iteration/__tests__/integration.spec.tsx
+++ b/web/app/components/workflow/nodes/iteration/__tests__/integration.spec.tsx
@@ -2,16 +2,17 @@ import type { IterationNodeType } from '../types'
import type { PanelProps } from '@/types/workflow'
import { screen } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
-import { renderWorkflowFlowComponent as render } from '@/app/components/workflow/__tests__/workflow-test-env'
+import { useNodes } from 'reactflow'
+import { renderWorkflowFlowComponent } from '@/app/components/workflow/__tests__/workflow-test-env'
import { ErrorHandleMode } from '@/app/components/workflow/types'
import { toast } from '@/app/notifications'
+import { seedModelProviderQueries } from '@/test/console/model-provider'
+import { createConsoleQueryWrapper } from '@/test/console/query-data'
+import { seedToolProviders } from '@/test/console/tool-providers'
+import { createNode } from '../../../__tests__/fixtures'
import { BlockEnum, VarType } from '../../../types'
import Node from '../node'
import Panel from '../panel'
-import useConfig from '../use-config'
-
-const mockHandleNodeAdd = vi.fn()
-const mockHandleNodeIterationRerender = vi.fn()
vi.mock('@/app/notifications', () => ({
toast: {
@@ -26,52 +27,8 @@ vi.mock('../../iteration-start', () => ({
IterationStartNodeDumb: () => <div>iteration-start-node</div>,
}))
-vi.mock('../use-interactions', () => ({
- useNodeIterationInteractions: () => ({
- handleNodeIterationRerender: mockHandleNodeIterationRerender,
- }),
-}))
-
-vi.mock('../../../hooks/use-available-blocks', () => ({
- useAvailableBlocks: () => ({
- availableNextBlocks: [BlockEnum.Code],
- }),
-}))
-
-vi.mock('../../../hooks/use-nodes-interactions', () => ({
- useNodesInteractions: () => ({
- handleNodeAdd: mockHandleNodeAdd,
- }),
-}))
-
-vi.mock('../../_base/components/variable/var-reference-picker', () => ({
- __esModule: true,
- default: ({
- onChange,
- availableVars,
- }: {
- onChange: (value: string[], kindType?: string, varInfo?: { type: VarType }) => void
- availableVars?: unknown[]
- }) => (
- <button
- type="button"
- onClick={() => {
- if (availableVars) onChange(['child-node', 'text'], 'variable', { type: VarType.string })
- else onChange(['node-1', 'items'], 'variable', { type: VarType.arrayString })
- }}
- >
- {availableVars ? 'pick-output-var' : 'pick-input-var'}
- </button>
- ),
-}))
-
-vi.mock('../use-config', () => ({
- __esModule: true,
- default: vi.fn(),
-}))
-
-const mockUseConfig = vi.mocked(useConfig)
-const mockToastWarning = vi.mocked(toast.warning)
+// Variable selection has its own canvas integration; these scenarios edit parallel execution controls.
+vi.mock('../../_base/components/variable/var-reference-picker', () => ({ default: () => null }))
const createData = (overrides: Partial<IterationNodeType> = {}): IterationNodeType => ({
title: 'Iteration',
@@ -91,23 +48,6 @@ const createData = (overrides: Partial<IterationNodeType> = {}): IterationNodeTy
...overrides,
})
-const createConfigResult = (
- overrides: Partial<ReturnType<typeof useConfig>> = {},
-): ReturnType<typeof useConfig> => ({
- readOnly: false,
- inputs: createData(),
- filterInputVar: () => true,
- handleInputChange: vi.fn(),
- childrenNodeVars: [],
- iterationChildrenNodes: [],
- handleOutputVarChange: vi.fn(),
- changeParallel: vi.fn(),
- changeErrorResponseMode: vi.fn(),
- changeParallelNums: vi.fn(),
- changeFlattenOutput: vi.fn(),
- ...overrides,
-})
-
const panelProps: PanelProps = {
getInputVars: vi.fn(() => []),
toVarInputs: vi.fn(() => []),
@@ -117,117 +57,111 @@ const panelProps: PanelProps = {
runResult: null,
}
-describe('iteration path', () => {
- beforeEach(() => {
- vi.clearAllMocks()
- mockUseConfig.mockReturnValue(createConfigResult())
+function IterationPanel() {
+ const node = useNodes<IterationNodeType>().find((node) => node.id === 'iteration-node')
+ if (!node) return null
+ return (
+ <>
+ <Panel id={node.id} data={node.data} panelProps={panelProps} />
+ <output aria-label="Saved parallel configuration">
+ {JSON.stringify({ parallel: node.data.parallel_nums, policy: node.data.error_handle_mode })}
+ </output>
+ </>
+ )
+}
+
+function renderIteration(data = createData(), readOnly = false, candidate = false) {
+ const { queryClient } = createConsoleQueryWrapper({ appDslVersion: '0.6.0' })
+ seedModelProviderQueries(queryClient)
+ seedToolProviders(queryClient, {
+ builtInTools: [],
+ customTools: [],
+ workflowTools: [],
+ mcpTools: [],
})
+ return renderWorkflowFlowComponent(
+ candidate ? <Node id="iteration-node" data={data} /> : <IterationPanel />,
+ {
+ queryClient,
+ nodes: [
+ createNode({ id: 'iteration-node', data, width: 500, height: 400 }),
+ createNode({
+ id: 'start-node',
+ parentId: 'iteration-node',
+ data: {
+ type: BlockEnum.IterationStart,
+ isInIteration: true,
+ iteration_id: 'iteration-node',
+ },
+ }),
+ ],
+ initialStoreState: { canvasReadOnly: readOnly },
+ hooksStoreProps: { doSyncWorkflowDraft: async () => undefined },
+ },
+ )
+}
- it('should render candidate iteration nodes and show the parallel warning once', () => {
- render(
- <Node
- id="iteration-node"
- data={createData({
- _isCandidate: true,
- _children: [{ nodeId: 'child-1', nodeType: BlockEnum.Iteration }],
- is_parallel: true,
- _isShowTips: true,
- })}
- />,
- )
+const savedConfiguration = () =>
+ JSON.parse(screen.getByRole('status', { name: 'Saved parallel configuration' }).textContent!)
+describe('iteration path', () => {
+ it('renders a candidate iteration and shows its parallel warning once', () => {
+ renderIteration(
+ createData({
+ _isCandidate: true,
+ _children: [{ nodeId: 'start-node', nodeType: BlockEnum.IterationStart }],
+ is_parallel: true,
+ _isShowTips: true,
+ }),
+ false,
+ true,
+ )
expect(screen.getByText('iteration-start-node')).toBeInTheDocument()
expect(screen.getByRole('button', { name: 'workflow.common.addBlock' })).toBeInTheDocument()
- expect(mockToastWarning).toHaveBeenCalledExactlyOnceWith(
+ expect(toast.warning).toHaveBeenCalledExactlyOnceWith(
'workflowLogic.nodes.iteration.answerNodeWarningDesc',
)
})
- it('commits numeric parallelism and the selected error policy', async () => {
+ it('saves numeric parallelism and the selected error policy on the canvas', async () => {
const user = userEvent.setup()
- const handleInputChange = vi.fn()
- const handleOutputVarChange = vi.fn()
- const changeParallelNums = vi.fn()
- const changeErrorResponseMode = vi.fn()
-
- mockUseConfig.mockReturnValue(
- createConfigResult({
- inputs: createData({
- is_parallel: true,
- flatten_output: false,
- }),
- handleInputChange,
- handleOutputVarChange,
- changeParallelNums,
- changeErrorResponseMode,
- }),
- )
-
- render(<Panel id="iteration-node" data={createData()} panelProps={panelProps} />)
-
- const parallelInput = screen.getByRole('textbox', {
+ renderIteration(createData({ is_parallel: true }))
+ const input = screen.getByRole('textbox', {
name: 'workflowLogic.nodes.iteration.MaxParallelismTitle',
})
- await user.clear(parallelInput)
- await user.type(parallelInput, '7')
+ await user.clear(input)
+ await user.type(input, '7')
await user.click(screen.getByRole('combobox'))
await user.click(
screen.getByRole('option', {
name: 'workflowLogic.nodes.iteration.ErrorMethod.continueOnError',
}),
)
-
- expect(changeParallelNums).toHaveBeenCalledWith(7)
- expect(changeErrorResponseMode).toHaveBeenCalledWith(
- expect.objectContaining({
- value: ErrorHandleMode.ContinueOnError,
- }),
- )
+ expect(savedConfiguration()).toEqual({ parallel: 7, policy: ErrorHandleMode.ContinueOnError })
+ expect(input).toHaveValue('7')
})
- it('should hide parallel controls when parallel mode is disabled', () => {
- mockUseConfig.mockReturnValue(
- createConfigResult({
- inputs: createData({
- is_parallel: false,
- }),
- }),
- )
-
- render(<Panel id="iteration-node" data={createData()} panelProps={panelProps} />)
-
+ it('hides parallel controls when parallel mode is disabled', () => {
+ renderIteration()
expect(
screen.queryByRole('textbox', { name: 'workflowLogic.nodes.iteration.MaxParallelismTitle' }),
).not.toBeInTheDocument()
})
- it('does not save an empty parallel count and restores the configured value on blur', async () => {
+ it('preserves the saved parallel count and restores it on blur after clearing the input', async () => {
const user = userEvent.setup()
- const changeParallelNums = vi.fn()
- mockUseConfig.mockReturnValue(
- createConfigResult({
- inputs: createData({ is_parallel: true }),
- changeParallelNums,
- }),
- )
- render(<Panel id="iteration-node" data={createData()} panelProps={panelProps} />)
+ renderIteration(createData({ is_parallel: true }))
const input = screen.getByRole('textbox', {
name: 'workflowLogic.nodes.iteration.MaxParallelismTitle',
})
await user.clear(input)
await user.tab()
- expect(changeParallelNums).not.toHaveBeenCalled()
+ expect(savedConfiguration()).toEqual({ parallel: 3, policy: ErrorHandleMode.Terminated })
expect(input).toHaveValue('3')
})
- it('disables both parallel count controls in readonly mode', () => {
- mockUseConfig.mockReturnValue(
- createConfigResult({
- inputs: createData({ is_parallel: true }),
- readOnly: true,
- }),
- )
- render(<Panel id="iteration-node" data={createData()} panelProps={panelProps} />)
+ it('disables parallel count controls on a readonly canvas', () => {
+ renderIteration(createData({ is_parallel: true }), true)
expect(
screen.getByRole('textbox', { name: 'workflowLogic.nodes.iteration.MaxParallelismTitle' }),
).toBeDisabled()